Re: [PATCH] staging: gs_fpgaboot: io.c: Remove unused function

2015-01-02 Thread Insop Song
Reviewed-by: Insop Song Thank you, ISS On Thu, Jan 01, 2015 at 05:23:13PM +0100, Rickard Strandqvist wrote: > Remove the function bitswap() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Sign

Re: [PATCH] staging: gs_fpgaboot: io.c: Remove unused function

2015-01-02 Thread Insop Song
Reviewed-by: Insop Song insop.s...@gainspeed.com Thank you, ISS On Thu, Jan 01, 2015 at 05:23:13PM +0100, Rickard Strandqvist wrote: Remove the function bitswap() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off

Re: [PATCH] Configure FSL eSPI CSBEF, CSAFT, and whether to send all received data to user

2014-04-14 Thread Insop Song
On Tue, Apr 15, 2014 at 12:49:49AM +0100, Mark Brown wrote: > On Mon, Apr 14, 2014 at 02:38:53PM -0700, Insop Song wrote: > > On Mon, Apr 14, 2014 at 09:51:51PM +0100, Mark Brown wrote: > > > > Please also be sure to CC the mailing list on patches, the sourceforge >

Re: [PATCH] Configure FSL eSPI CSBEF, CSAFT, and whether to send all received data to user

2014-04-14 Thread Insop Song
On Tue, Apr 15, 2014 at 12:49:49AM +0100, Mark Brown wrote: > On Mon, Apr 14, 2014 at 02:38:53PM -0700, Insop Song wrote: > > On Mon, Apr 14, 2014 at 09:51:51PM +0100, Mark Brown wrote: > > > > Please also be sure to CC the mailing list on patches, the sourceforge >

Re: [PATCH] Configure FSL eSPI CSBEF, CSAFT, and whether to send all received data to user

2014-04-14 Thread Insop Song
On Mon, Apr 14, 2014 at 09:51:51PM +0100, Mark Brown wrote: > On Sat, Apr 12, 2014 at 11:48:35AM -0700, Jane Wan wrote: > > Make FSL eSPI properties configurable through device tree. The > > configurable parameters include CSnBEF and CSnAFT in ESPI_SPMODEn > > registers (n=0,1,2,3), and whether

Re: [PATCH] Configure FSL eSPI CSBEF, CSAFT, and whether to send all received data to user

2014-04-14 Thread Insop Song
On Tue, Apr 15, 2014 at 12:49:49AM +0100, Mark Brown wrote: On Mon, Apr 14, 2014 at 02:38:53PM -0700, Insop Song wrote: On Mon, Apr 14, 2014 at 09:51:51PM +0100, Mark Brown wrote: Please also be sure to CC the mailing list on patches, the sourceforge list has been unused for quite some

Re: [PATCH] Configure FSL eSPI CSBEF, CSAFT, and whether to send all received data to user

2014-04-14 Thread Insop Song
On Tue, Apr 15, 2014 at 12:49:49AM +0100, Mark Brown wrote: On Mon, Apr 14, 2014 at 02:38:53PM -0700, Insop Song wrote: On Mon, Apr 14, 2014 at 09:51:51PM +0100, Mark Brown wrote: Please also be sure to CC the mailing list on patches, the sourceforge list has been unused for quite some

Re: [PATCH] Configure FSL eSPI CSBEF, CSAFT, and whether to send all received data to user

2014-04-14 Thread Insop Song
On Mon, Apr 14, 2014 at 09:51:51PM +0100, Mark Brown wrote: On Sat, Apr 12, 2014 at 11:48:35AM -0700, Jane Wan wrote: Make FSL eSPI properties configurable through device tree. The configurable parameters include CSnBEF and CSnAFT in ESPI_SPMODEn registers (n=0,1,2,3), and whether to send

RE: [PATCH] Add support for flag status register on Micron chips.

2014-04-08 Thread Insop Song
lso > require reading the status register before reading the flag status register. > > This patch adds support for the flag status register in the n25q512a1 and > n25q00 Micron QSPI flash chips. > Reviewed his change, and it is more generic then my previous patch. Reviewed-by: Insop

RE: [PATCH] Add support for flag status register on Micron chips.

2014-04-08 Thread Insop Song
also require reading the status register before reading the flag status register. This patch adds support for the flag status register in the n25q512a1 and n25q00 Micron QSPI flash chips. Reviewed his change, and it is more generic then my previous patch. Reviewed-by: Insop Song insop.s

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
Dan, Thank you for pointing that out. This was for reviewing, so I would put this instead, then. Reviewed-by: Insop Song Regards, ISS -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info a

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
igned-off-by: Paul Bolle Signed-off-by: Insop Song > --- > Completely untested. > > By the way, do de...@driverdev.osuosl.org and > de...@linuxdriverproject.org deliver to the same list? > > drivers/staging/gs_fpgaboot/Makefile | 2 -- > 1 file changed, 2 dele

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
pebo...@tiscali.nl Signed-off-by: Insop Song insop.s...@gainspeed.com --- Completely untested. By the way, do de...@driverdev.osuosl.org and de...@linuxdriverproject.org deliver to the same list? drivers/staging/gs_fpgaboot/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
for pointing that out. This was for reviewing, so I would put this instead, then. Reviewed-by: Insop Song insop.s...@gainspeed.com Regards, ISS -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Insop Song
date for 3.15-rc1. > > > > > > Loads of cleanup fixes, a few drivers removed, and some new ones > added. > > > > > > All have been in linux-next for a while. > > > > > >[...] > > > > > > Insop Song (1): > > >

RE: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Insop Song
, a few drivers removed, and some new ones added. All have been in linux-next for a while. [...] Insop Song (1): staging: fpgaboot: Xilinx FPGA firmware download driver This commit adds checks for CONFIG_B4860G100. Is a patch to add a Kconfig symbol B4860G100 perhaps

Re: [PATCH] Remove warning printk

2014-03-28 Thread Insop Song
On Fri, Mar 28, 2014 at 1:46 AM, Greg KH wrote: > On Fri, Mar 28, 2014 at 08:05:23AM +0000, Insop Song wrote: >> Hi Greg, >> >> Will send out a new patch mail with single patch shortly. >> >> I have not yet find a good way to reply mail and add patch yet

RE: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

2014-03-28 Thread Insop Song
From: Arnd Bergmann Sent: Tuesday, March 25, 2014 8:48 AM To: gre...@linuxfoundation.org Cc: linux-kernel@vger.kernel.org; Insop Song Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro We specifically build the kernel with -Werror=date

[PATCH] Remove warning printk

2014-03-28 Thread Insop Song
Found from build with option -Werror=date-time Signed-off-by: Insop Song --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c index 89bc84d..7506900 100644

RE: [PATCH] Remove warning printk

2014-03-28 Thread Insop Song
; Insop Song Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro We specifically build the kernel with -Werror=date-time to detect such macros, which gives us this error: gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-W

RE: [PATCH] Remove warning printk

2014-03-28 Thread Insop Song
@vger.kernel.org; Insop Song Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro We specifically build the kernel with -Werror=date-time to detect such macros, which gives us this error: gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro __TIMESTAMP__ might prevent reproducible builds

[PATCH] Remove warning printk

2014-03-28 Thread Insop Song
Found from build with option -Werror=date-time Signed-off-by: Insop Song insop.s...@gainspeed.com --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c index

RE: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

2014-03-28 Thread Insop Song
From: Arnd Bergmann a...@arndb.de Sent: Tuesday, March 25, 2014 8:48 AM To: gre...@linuxfoundation.org Cc: linux-kernel@vger.kernel.org; Insop Song Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro We specifically build the kernel

Re: [PATCH] Remove warning printk

2014-03-28 Thread Insop Song
On Fri, Mar 28, 2014 at 1:46 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Mar 28, 2014 at 08:05:23AM +, Insop Song wrote: Hi Greg, Will send out a new patch mail with single patch shortly. I have not yet find a good way to reply mail and add patch yet with my mailing server

[PATCH] Remove warning printk

2014-03-27 Thread Insop Song
Found from build with option -Werror=date-time Signed-off-by: Insop Song Signed-off-by: Arnd Bergmann --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c index

[PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

2014-03-27 Thread Insop Song
Remove warning Insop Song (1): Remove warning printk drivers/staging/gs_fpgaboot/gs_fpgaboot.c |1 - 1 file changed, 1 deletion(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

[PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

2014-03-27 Thread Insop Song
Remove warning Insop Song (1): Remove warning printk drivers/staging/gs_fpgaboot/gs_fpgaboot.c |1 - 1 file changed, 1 deletion(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] Remove warning printk

2014-03-27 Thread Insop Song
Found from build with option -Werror=date-time Signed-off-by: Insop Song insop.s...@gainspeed.com Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers