Re: [PATCH 1/3] bus: fsl-mc: Fix test for end of loop

2021-02-09 Thread Ioana Ciornei
On Mon, Feb 08, 2021 at 09:58:10PM +0300, Dan Carpenter wrote: > On Mon, Feb 08, 2021 at 07:09:47PM +0200, Ioana Ciornei wrote: > > From: Dan Carpenter > > > > The "desc" pointer can't possibly be NULL here. If we can't find the > > correct &quo

[PATCH 3/3] bus: fsl-mc: list more commands as accepted through the ioctl

2021-02-08 Thread Ioana Ciornei
From: Ioana Ciornei Add some new MC firmware commands that can be received through the userspace ioctl interface - *get_max_frame_length and *_get_counter. Signed-off-by: Ioana Ciornei --- drivers/bus/fsl-mc/fsl-mc-uapi.c | 50 1 file changed, 50 insertions

[PATCH 2/3] bus: fsl-mc: add the dpdbg device type

2021-02-08 Thread Ioana Ciornei
From: Ioana Ciornei A new object type was recently added in MC. This has to be added in the fsl-mc bus device type list so that it can be properly listed. Signed-off-by: Ioana Ciornei --- drivers/bus/fsl-mc/fsl-mc-bus.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/bus

[PATCH 1/3] bus: fsl-mc: Fix test for end of loop

2021-02-08 Thread Ioana Ciornei
f066 ("bus: fsl-mc: add fsl-mc userspace support") Signed-off-by: Ioana Ciornei Signed-off-by: Dan Carpenter --- drivers/bus/fsl-mc/fsl-mc-uapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-uapi.c b/drivers/bus/fsl-mc/fsl-mc-uapi.c index eeb988c

[PATCH 0/3] bus: fsl-mc: minor updates

2021-02-08 Thread Ioana Ciornei
From: Ioana Ciornei This patch set adds a fix on the userspace support of the fsl-mc bus. Other than that, a missing device type is added and some other commands to the list of the accepted ones. Dan Carpenter (1): bus: fsl-mc: Fix test for end of loop Ioana Ciornei (2): bus: fsl-mc: add

Re: [PATCH net-next 5/9] net: squash switchdev attributes PRE_BRIDGE_FLAGS and BRIDGE_FLAGS

2021-02-08 Thread Ioana Ciornei
On Mon, Feb 08, 2021 at 01:21:37AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > There does not appear to be any strong reason why > br_switchdev_set_port_flag issues a separate notification for checking > the supported brport flags rather than just attempting to apply them and >

Re: [PATCH] bus: fsl-mc: Fix test for end of loop

2021-02-08 Thread Ioana Ciornei
On Mon, Feb 08, 2021 at 06:11:29PM +0300, Dan Carpenter wrote: > On Mon, Feb 08, 2021 at 02:18:04PM +0000, Ioana Ciornei wrote: > > On Mon, Feb 01, 2021 at 03:28:54PM +0300, Dan Carpenter wrote: > > > The "desc" pointer can't possibly be NULL here. If we can't

Re: [PATCH] bus: fsl-mc: Fix test for end of loop

2021-02-08 Thread Ioana Ciornei
On Mon, Feb 01, 2021 at 03:28:54PM +0300, Dan Carpenter wrote: > The "desc" pointer can't possibly be NULL here. If we can't find the > correct "desc" then tt points to the last element of the > fsl_mc_accepted_cmds[] array. Fix this by testing if > "i == FSL_MC_NUM_ACCEPTED_CMDS" instead. > >

Re: [PATCH] bus: fsl-mc: Fix test for end of loop

2021-02-02 Thread Ioana Ciornei
== FSL_MC_NUM_ACCEPTED_CMDS" instead. > > Fixes: 2cf1e703f066 ("bus: fsl-mc: add fsl-mc userspace support") > Signed-off-by: Dan Carpenter Acked-by: Ioana Ciornei Thanks! > --- > drivers/bus/fsl-mc/fsl-mc-uapi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] dpaa2-eth: Simplify the calculation of variables

2021-02-02 Thread Ioana Ciornei
-off-by: Jiapeng Chong Acked-by: Ioana Ciornei > --- > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c >

[PATCH 5/5] bus: fsl-mc: add autorescan sysfs

2021-01-14 Thread Ioana Ciornei
From: Ioana Ciornei Add the autorescan sysfs in order to enable/disable the DPRC IRQs on which automatic rescan of the bus is performed. This is important when dynamic creation of objects is needed to happen in a timely manner because object creation can be bundled together. Signed-off

[PATCH 4/5] bus: fsl-mc: add bus rescan attribute

2021-01-14 Thread Ioana Ciornei
From: Ioana Ciornei Introduce the rescan attribute as a bus attribute to synchronize the fsl-mc bus objects and the MC firmware. To rescan the fsl-mc bus, e.g., echo 1 > /sys/bus/fsl-mc/rescan Signed-off-by: Ioana Ciornei --- Documentation/ABI/stable/sysfs-bus-fsl-mc | 9 + MAINTAIN

[PATCH 2/5] bus: fsl-mc: export mc_cmd_hdr_read_cmdid() to the fsl-mc bus

2021-01-14 Thread Ioana Ciornei
From: Ioana Ciornei Export the mc_cmd_hdr_read_cmdid() function to the entire fsl-mc bus since it will be needed in the following patch. Signed-off-by: Ioana Ciornei --- drivers/bus/fsl-mc/fsl-mc-private.h | 2 ++ drivers/bus/fsl-mc/mc-sys.c | 2 +- 2 files changed, 3 insertions(+), 1

[PATCH 1/5] bus: fsl-mc: move fsl_mc_command struct in a uapi header

2021-01-14 Thread Ioana Ciornei
From: Ioana Ciornei Define "struct fsl_mc_command" as a structure that can cross the user/kernel boundary. Signed-off-by: Ioana Ciornei --- MAINTAINERS | 1 + include/linux/fsl/mc.h | 8 +--- include/uapi/linux/fsl_mc.h | 25

[PATCH 3/5] bus: fsl-mc: add fsl-mc userspace support

2021-01-14 Thread Ioana Ciornei
From: Ioana Ciornei Adding userspace support for the MC (Management Complex) means exporting an ioctl capable device file representing the root resource container. This new functionality in the fsl-mc bus driver intends to provide userspace applications an interface to interact with the MC

[PATCH 0/5] bus: fsl-mc: add userspace support

2021-01-14 Thread Ioana Ciornei
From: Ioana Ciornei This patch set adds userspace support in the fsl-mc bus along with a rescan attribute to the root DPRC container. An earlier discussion on this functionality can be found at the link below. I didn't continue with the versioning scheme since quite some time has passed since

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
On Mon, Jan 04, 2021 at 06:31:05PM +0100, Andrew Lunn wrote: > > The basic rules here should be, if the MDIO bus is registered, it is > > usable. There are things like PHY statistics, HWMON temperature > > sensors, etc, DSA switches, all which have a life cycle separate to > > the interface being

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
On Mon, Jan 04, 2021 at 04:11:02PM +0100, Geert Uytterhoeven wrote: > Hi Ioana, > > On Mon, Jan 4, 2021 at 3:53 PM Ioana Ciornei wrote: > > On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > > > Wolfram reports that his R-Car H2-based L

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
Hi Geert, On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > Wolfram reports that his R-Car H2-based Lager board can no longer be > rebooted in v5.11-rc1, as it crashes with an imprecise external abort. > The issue can be reproduced on other boards (e.g. Koelsch with R-Car >

Re: linux-next: build warning after merge of the net-next tree

2020-12-14 Thread Ioana Ciornei
On Tue, Dec 15, 2020 at 07:01:25AM +1100, Stephen Rothwell wrote: > Hi all, > > On Thu, 26 Nov 2020 17:40:57 +1100 Stephen Rothwell > wrote: > > > > After merging the net-next tree, today's linux-next build (htmldocs) > > produced this warning: > > > > include/linux/phy.h:869: warning:

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-12 Thread Ioana Ciornei
On Sat, Dec 12, 2020 at 04:58:56PM +0100, Jon Nettleton wrote: > On Fri, Dec 11, 2020 at 5:56 PM Ioana Ciornei wrote: > > > > On Fri, Dec 11, 2020 at 04:29:14PM +, Daniel Thompson wrote: > > > On Fri, Dec 11, 2020 at 02:01:28PM +, Ioana Ciornei wrote: > > >

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-11 Thread Ioana Ciornei
On Fri, Dec 11, 2020 at 04:29:14PM +, Daniel Thompson wrote: > On Fri, Dec 11, 2020 at 02:01:28PM +0000, Ioana Ciornei wrote: > > On Thu, Dec 10, 2020 at 08:06:36PM +0200, Ioana Ciornei wrote: > > > [Added also the netdev mailing list, I haven't heard of linux-netdev >

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-11 Thread Ioana Ciornei
On Thu, Dec 10, 2020 at 08:06:36PM +0200, Ioana Ciornei wrote: > [Added also the netdev mailing list, I haven't heard of linux-netdev > before but kept it] > > On Thu, Dec 10, 2020 at 05:31:56PM +, Daniel Thompson wrote: > > Hi Ioana > > Hi Daniel, > > >

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-11 Thread Ioana Ciornei
On Fri, Dec 11, 2020 at 09:30:43AM +, David Laight wrote: > From: Daniel Thompson > > Sent: 10 December 2020 17:32 > > > > On Mon, Jun 29, 2020 at 06:47:11PM +, Ioana Ciornei wrote: > > > Instead of realloc-ing the skb on the Tx path when the provided headroo

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-10 Thread Ioana Ciornei
[Added also the netdev mailing list, I haven't heard of linux-netdev before but kept it] On Thu, Dec 10, 2020 at 05:31:56PM +, Daniel Thompson wrote: > Hi Ioana Hi Daniel, > > On Mon, Jun 29, 2020 at 06:47:11PM +0000, Ioana Ciornei wrote: > > Instead of realloc-ing the skb

Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

2020-12-07 Thread Ioana Ciornei
On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote: > Add an 'of_node_put()' call when a tested device node is not available. > > Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > Signed-off-by: Christophe JAILLET Reviewed-by:

Re: [PATCH v1] net: phy: micrel: fix interrupt handling

2020-11-27 Thread Ioana Ciornei
On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote: > On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote: > > After migration to the shared interrupt support, the KSZ8031 PHY with > > enabled interrupt support was not able to notify about link status > > change. > > > >

Re: [PATCH v4] dt-bindings: misc: convert fsl,qoriq-mc from txt to YAML

2020-11-24 Thread Ioana Ciornei
> > Signed-off-by: Ionut-robert Aron > [laurentiu.tu...@nxp.com: update MINTAINERS, updates & fixes in schema] > Signed-off-by: Laurentiu Tudor Acked-by: Ioana Ciornei > --- > Changes in v4: > - use $ref to point to fsl,qoriq-mc-dpmac binding > > Changes in v3: >

Re: [PATCH] bus: fsl-mc: added missing fields to dprc_rsp_get_obj_region structure

2020-11-24 Thread Ioana Ciornei
> > Signed-off-by: Cristian Sovaiala > Signed-off-by: Laurentiu Tudor Reviewed-by: Ioana Ciornei > --- > drivers/bus/fsl-mc/dprc.c | 2 ++ > drivers/bus/fsl-mc/fsl-mc-private.h | 5 +++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/d

Re: [PATCH net-next 00/15] net: phy: add support for shared interrupts (part 3)

2020-11-23 Thread Ioana Ciornei
On Mon, Nov 23, 2020 at 02:37:13PM -0800, Jakub Kicinski wrote: > On Mon, 23 Nov 2020 23:13:11 +0100 Martin Blumenstingl wrote: > > > Ioana Ciornei (15): > > > net: phy: intel-xway: implement generic .handle_interrupt() callback > > > net: phy: intel-xway: re

[PATCH] bus: fsl-mc: simplify DPRC version check

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei Because the minimum supported DPRC version is 6.0, there is no need to check for incompatible 6.x versions lower to the minimum one. Just remove the second half of the check to simplify the logic. Signed-off-by: Ioana Ciornei --- drivers/bus/fsl-mc/dprc-driver.c | 4

[PATCH net-next 06/15] net: phy: meson-gxl: remove the use of .ack_callback()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 04/15] net: phy: icplus: remove the use .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 11/15] net: phy: ti: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 12/15] net: phy: ti: remove the use of .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 15/15] net: phy: remove the .did_interrupt() and .ack_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei Now that all the PHY drivers have been migrated to directly implement the generic .handle_interrupt() callback for a seamless support of shared IRQs and all the .config_inter() implementations clear any pending interrupts, we can safely remove the two callbacks

[PATCH net-next 14/15] net: phy: qsemi: remove the use of .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 13/15] net: phy: qsemi: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 10/15] net: phy: national: remove the use of the .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 07/15] net: phy: micrel: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 08/15] net: phy: micrel: remove the use of .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 09/15] net: phy: national: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 03/15] net: phy: icplus: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 02/15] net: phy: intel-xway: remove the use of .ack_interrupt()

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 01/15] net: phy: intel-xway: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 05/15] net: phy: meson-gxl: implement generic .handle_interrupt() callback

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 00/15] net: phy: add support for shared interrupts (part 3)

2020-11-23 Thread Ioana Ciornei
From: Ioana Ciornei This patch set aims to actually add support for shared interrupts in phylib and not only for multi-PHY devices. While we are at it, streamline the interrupt handling in phylib. For a bit of context, at the moment, there are multiple phy_driver ops that deal with this subject

[PATCH 3/3] staging: dpaa2-switch: pack the firmware command structures

2020-11-19 Thread Ioana Ciornei
From: Ioana Ciornei The structures defined in the dpsw-cmd.h header file describe exactly the layout of commands accepted by the MC firmware. Make sure that all these structures are packed. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h | 2 ++ 1 file changed, 2

[PATCH 2/3] staging: dpaa2-switch: make sure that the VLAN is not already configured

2020-11-19 Thread Ioana Ciornei
From: Ioana Ciornei When in the PREPARE state of a switchdev transaction, check if the requested VLAN is not already configured on the switch port. This keeps us from getting into a WARNING as below. [ 1389.683296] dpaa2_ethsw dpsw.0 eth0: VLAN 2 already configured [ 1389.689125

[PATCH 1/3] staging: dpaa2-switch: export the 'no buffer' counter in ethtool

2020-11-19 Thread Ioana Ciornei
From: Ionut-robert Aron Export the DPSW_CNT_ING_NO_BUFFER_DISCARD counter in ethtool for each switch interface. This is useful for debugging purposes. Signed-off-by: Ionut-robert Aron Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h | 8 +--- drivers

[PATCH 0/3] staging: dpaa2-switch: small updates and fixes

2020-11-19 Thread Ioana Ciornei
From: Ioana Ciornei This patch set is just a small set of fixes and an update on the ethtool counters exported by the dpaa2-switch driver. Ioana Ciornei (2): staging: dpaa2-switch: make sure that the VLAN is not already configured staging: dpaa2-switch: pack the firmware command

Re: [PATCH net-next v4 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-17 Thread Ioana Ciornei
On Tue, Nov 17, 2020 at 02:15:55PM -0600, Dan Murphy wrote: > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver > that supports 10M single pair cable. > > The device supports both 2.4-V p2p and 1-V p2p output voltage as defined > by IEEE 802.3cg 10Base-T1L specfications.

[PATCH RESEND net-next 05/18] net: phy: marvell: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH RESEND net-next 04/18] net: phy: microchip: remove the use of .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 08/18] net: phy: lxt: remove the use of .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 11/18] net: phy: amd: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH RESEND net-next 07/18] net: phy: lxt: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH RESEND net-next 13/18] net: phy: smsc: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH RESEND net-next 15/18] net: phy: ste10Xp: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH RESEND net-next 06/18] net: phy: marvell: remove the use of .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 17/18] net: phy: adin: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH RESEND net-next 16/18] net: phy: ste10Xp: remove the use of .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 09/18] net: phy: nxp-tja11xx: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH RESEND net-next 14/18] net: phy: smsc: remove the use of .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 18/18] net: phy: adin: remove the use of the .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 12/18] net: phy: amd: remove the use of .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 03/18] net: phy: microchip: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH RESEND net-next 02/18] net: phy: vitesse: remove the use of .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 00/18] net: phy: add support for shared interrupts (part 2)

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei This patch set aims to actually add support for shared interrupts in phylib and not only for multi-PHY devices. While we are at it, streamline the interrupt handling in phylib. For a bit of context, at the moment, there are multiple phy_driver ops that deal with this subject

[PATCH RESEND net-next 10/18] net: phy: nxp-tja11xx: remove the use of .ack_interrupt()

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH RESEND net-next 01/18] net: phy: vitesse: implement generic .handle_interrupt() callback

2020-11-13 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

Re: [PATCH net-next 00/18] net: phy: add support for shared interrupts (part 2)

2020-11-13 Thread Ioana Ciornei
On Thu, Nov 12, 2020 at 06:19:10PM -0800, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 17:54:55 +0200 Ioana Ciornei wrote: > > From: Ioana Ciornei > > > > This patch set aims to actually add support for shared interrupts in > > phylib and not only for

[PATCH net-next 02/18] net: phy: vitesse: remove the use of .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 00/18] net: phy: add support for shared interrupts (part 2)

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei This patch set aims to actually add support for shared interrupts in phylib and not only for multi-PHY devices. While we are at it, streamline the interrupt handling in phylib. For a bit of context, at the moment, there are multiple phy_driver ops that deal with this subject

[PATCH net-next 07/18] net: phy: lxt: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 06/18] net: phy: marvell: remove the use of .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 05/18] net: phy: marvell: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 09/18] net: phy: nxp-tja11xx: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 08/18] net: phy: lxt: remove the use of .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 15/18] net: phy: ste10Xp: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 13/18] net: phy: smsc: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 14/18] net: phy: smsc: remove the use of .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 10/18] net: phy: nxp-tja11xx: remove the use of .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 16/18] net: phy: ste10Xp: remove the use of .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 03/18] net: phy: microchip: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 12/18] net: phy: amd: remove the use of .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 18/18] net: phy: adin: remove the use of the .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

[PATCH net-next 11/18] net: phy: amd: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 17/18] net: phy: adin: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 01/18] net: phy: vitesse: implement generic .handle_interrupt() callback

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In an attempt to actually support shared IRQs in phylib, we now move the responsibility of triggering the phylib state machine or just returning IRQ_NONE, based on the IRQ status register, to the PHY driver. Having 3 different IRQ handling callbacks (.handle_interrupt

[PATCH net-next 04/18] net: phy: microchip: remove the use of .ack_interrupt()

2020-11-12 Thread Ioana Ciornei
From: Ioana Ciornei In preparation of removing the .ack_interrupt() callback, we must replace its occurrences (aka phy_clear_interrupt), from the 2 places where it is called from (phy_enable_interrupts and phy_disable_interrupts), with equivalent functionality. This means that clearing

Re: [RFC 6/9] staging: dpaa2-switch: add .ndo_start_xmit() callback

2020-11-05 Thread Ioana Ciornei
On Thu, Nov 05, 2020 at 02:45:12PM +0100, Andrew Lunn wrote: > > > Where is the TX confirm which uses this stored pointer. I don't see it > > > in this file. > > > > > > > The Tx confirm - dpaa2_switch_tx_conf() - is added in patch 5/9. > > Not so obvious. Could it be moved here? > Sure, I'll

Re: [RFC 5/9] staging: dpaa2-switch: handle Rx path on control interface

2020-11-05 Thread Ioana Ciornei
On Thu, Nov 05, 2020 at 01:45:16AM +0100, Andrew Lunn wrote: > > +/* Manage all NAPI instances for the control interface. > > + * > > + * We only have one RX queue and one Tx Conf queue for all > > + * switch ports. Therefore, we only need to enable the NAPI instance once, > > the > > + * first

Re: [RFC 8/9] staging: dpaa2-switch: properly setup switching domains

2020-11-05 Thread Ioana Ciornei
On Thu, Nov 05, 2020 at 12:08:10AM +0200, Vladimir Oltean wrote: > On Wed, Nov 04, 2020 at 06:57:19PM +0200, Ioana Ciornei wrote: > > From: Ioana Ciornei > > > > Until now, the DPAA2 switch was not capable to properly setup it's > > switching domains depending on the

Re: [RFC 6/9] staging: dpaa2-switch: add .ndo_start_xmit() callback

2020-11-05 Thread Ioana Ciornei
On Thu, Nov 05, 2020 at 02:04:39AM +0100, Andrew Lunn wrote: > > +static int dpaa2_switch_build_single_fd(struct ethsw_core *ethsw, > > + struct sk_buff *skb, > > + struct dpaa2_fd *fd) > > +{ > > + struct device *dev =

Re: [RFC 6/9] staging: dpaa2-switch: add .ndo_start_xmit() callback

2020-11-05 Thread Ioana Ciornei
On Wed, Nov 04, 2020 at 11:27:00PM +0200, Vladimir Oltean wrote: > On Wed, Nov 04, 2020 at 06:57:17PM +0200, Ioana Ciornei wrote: > > From: Ioana Ciornei > > > > Implement the .ndo_start_xmit() callback for the switch port interfaces. > > For each of the switch port

[RFC 0/9] staging: dpaa2-switch: add support for CPU terminated traffic

2020-11-04 Thread Ioana Ciornei
From: Ioana Ciornei This patch set adds support for Rx/Tx capabilities on DPAA2 switch port interfaces as well as fixing up so major blunders in how we take care of the switching domains. The netdev community considers this as a basic features, thus it's sent against the staging tree before

[RFC 9/9] staging: dpaa2-switch: accept only vlan-aware upper devices

2020-11-04 Thread Ioana Ciornei
From: Ioana Ciornei The DPAA2 Switch is not capable to handle traffic in a VLAN unaware fashion, thus the previous handling of both the accepted upper devices and the SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING flag was wrong. Fix this by checking if the bridge that we are joining is indeed VLAN

[RFC 8/9] staging: dpaa2-switch: properly setup switching domains

2020-11-04 Thread Ioana Ciornei
From: Ioana Ciornei Until now, the DPAA2 switch was not capable to properly setup it's switching domains depending on the existence, or lack thereof, of a upper bridge device. This meant that all switch ports of a DPSW object were switching by default even though they were not under the same

[RFC 3/9] staging: dpaa2-switch: setup RX path rings

2020-11-04 Thread Ioana Ciornei
From: Ioana Ciornei On the Rx path, when a pull-dequeue operation is performed on a software portal, available frame descriptors are put in a ring - a DMA memory storage - for further usage. Create the needed rings for both frame queues used on the control interface. Signed-off-by: Ioana

  1   2   3   4   5   >