Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Rafael J. Wysocki
On Wed, Jan 20, 2021 at 9:01 PM Saravana Kannan wrote: > > On Wed, Jan 20, 2021 at 11:15 AM Rafael J. Wysocki wrote: > > > > On Wed, Jan 20, 2021 at 7:51 PM Andy Shevchenko > > wrote: > > > > > > On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki >

Re: [PATCH v5 0/3] GENPD API improvements

2021-01-22 Thread Rafael J. Wysocki
On Thu, Jan 21, 2021 at 12:45 AM Dmitry Osipenko wrote: > > Hi, > > This series is a prerequisite for the power domain driver of NVIDIA Tegra > SoCs [1]. It extends the GENPD core with a better support of performance > states and eases linking of child/parent PDs for the PD drivers. > > [1]

Re: [PATCH v2] PM / clk: make PM clock layer compatible with clocks that must sleep

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 22, 2021 at 4:59 PM Nicolas Pitre wrote: > > On Fri, 22 Jan 2021, Rafael J. Wysocki wrote: > > > On Fri, Jan 22, 2021 at 4:48 PM Naresh Kamboju > > wrote: > > > > > > On Fri, 22 Jan 2021 at 20:39, Rafael J. Wysocki wrote: > > > &g

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-22 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 08:08:24PM +, David Howells wrote: > J. Bruce Fields wrote: > > So, I'm still confused: there must be some case where we know fscache > > actually works reliably and doesn't corrupt your data, right? > > Using ext2/3, for example. I

Re: [PATCH v2] PM / clk: make PM clock layer compatible with clocks that must sleep

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 22, 2021 at 4:48 PM Naresh Kamboju wrote: > > On Fri, 22 Jan 2021 at 20:39, Rafael J. Wysocki wrote: > > > > On Thu, Jan 21, 2021 at 8:01 PM Rafael J. Wysocki wrote: > > > > > > On Thu, Jan 21, 2021 at 6:23 PM Nicolas Pitre wrote: > > >

Re: [PATCH] intel_idle: remove definition of DEBUG

2021-01-22 Thread Rafael J. Wysocki
On Sat, Jan 16, 2021 at 12:58 AM wrote: > > From: Tom Rix > > Defining DEBUG should only be done in development. > So remove DEBUG. > > Signed-off-by: Tom Rix > --- > drivers/idle/intel_idle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/idle/intel_idle.c

Re: [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 8, 2021 at 5:03 PM Andy Shevchenko wrote: > > On Fri, Jan 8, 2021 at 5:28 PM Flavio Suligoi wrote: > > > > The gpio-line-names lists must respect some rules. > > > > This patch adds a new rule in documentation, to avoid > > the use of duplicate names in the same gpiochip. > > Thanks!

Re: [PATCH 0/3] acpi: cppc_acpi: fix sparse warnings

2021-01-22 Thread Rafael J. Wysocki
On Thu, Jan 7, 2021 at 12:19 PM Ionela Voinescu wrote: > > Hi guys, > > These patches just fix some trivial sparse warnings. > > Hope they help, > Ionela. > > Ionela Voinescu (3): > acpi: cppc_acpi: remove __iomem annotation for cpc_reg's address > acpi: cppc_acpi: add __iomem annotation to

Re: [PATCH -next] pnp: pnpbios: Use DEFINE_SPINLOCK() for spinlock

2021-01-22 Thread Rafael J. Wysocki
On Mon, Dec 28, 2020 at 2:50 PM Zheng Yongjun wrote: > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Signed-off-by: Zheng Yongjun > --- > drivers/pnp/pnpbios/bioscalls.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH] PNP: add printf attribute to log function

2021-01-22 Thread Rafael J. Wysocki
On Mon, Dec 21, 2020 at 5:04 PM wrote: > > From: Tom Rix > > Attributing the function allows the compiler to more thoroughly > check the use of the function with -Wformat and similar flags. > > Signed-off-by: Tom Rix > --- > drivers/pnp/interface.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH] acpi: Use DEVICE_ATTR_ macros

2021-01-22 Thread Rafael J. Wysocki
On Thu, Dec 17, 2020 at 1:47 PM Dwaipayan Ray wrote: > > Instead of open coding DEVICE_ATTR(), use the > DEVICE_ATTR_RW(), DEVICE_ATTR_RO() and DEVICE_ATTR_WO() > macros wherever possible. > > This required a few functions to be renamed but the > functionality itself is unchanged. > >

Re: [PATCH v2] PM / clk: make PM clock layer compatible with clocks that must sleep

2021-01-22 Thread Rafael J. Wysocki
On Thu, Jan 21, 2021 at 8:01 PM Rafael J. Wysocki wrote: > > On Thu, Jan 21, 2021 at 6:23 PM Nicolas Pitre wrote: > > > > The clock API splits its interface into sleepable ant atomic contexts: > > > > - clk_prepare/clk_unprepare for stuff that might sleep &g

[GIT PULL] ACPI fix for v5.11-rc5

2021-01-21 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-5.11-rc5 with top-most commit 78a18fec5258c8df9435399a1ea022d73d3eceb9 ACPI: scan: Make acpi_bus_get_device() clear return pointer on error on top of commit

Re: [PATCH v2] PM / clk: make PM clock layer compatible with clocks that must sleep

2021-01-21 Thread Rafael J. Wysocki
orks as before. > > Signed-off-by: Nicolas Pitre > > --- > > On Thu, 21 Jan 2021, Rafael J. Wysocki wrote: > > > So I'm going to drop this patch from linux-next until the issue is > > resolved, thanks! > > Here's the fixed version. Appl

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 06:55:13PM +, David Howells wrote: > J. Bruce Fields wrote: > > > > Fixing this requires a much bigger overhaul of cachefiles than this > > > patchset > > > performs. > > > > That sounds like "sometimes you may get

Re: [PATCH] ACPICA: fix -Wfallthrough

2021-01-21 Thread Rafael J. Wysocki
On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter wrote: > > > On 11/11/2020 02:11, Nick Desaulniers wrote: > > The "fallthrough" pseudo-keyword was added as a portable way to denote > > intentional fallthrough. This code seemed to be using a mix of > > fallthrough comments that GCC recognizes, and

Re: [PATCH] xfs: set inode size after creating symlink

2021-01-21 Thread Darrick J. Wong
e lower inode. Do directories have the same problem? I'm guessing no because every other file type calls vfs_getattr on the lower dentry, which should link us to xfs_vn_getattr. Reviewed-by: Darrick J. Wong --D > The command "stat path/to/symlink/in/ecryptfs" will report "S

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-21 Thread Rafael J. Wysocki
On Thu, Jan 21, 2021 at 5:34 PM Daniel Scally wrote: > > > On 21/01/2021 14:39, Rafael J. Wysocki wrote: > > On Thu, Jan 21, 2021 at 1:04 PM Daniel Scally wrote: > >> > >> On 21/01/2021 11:58, Rafael J. Wysocki wrote: > >>> On Thu, Jan 21, 2021 at 10

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 05:02:57PM +, David Howells wrote: > J. Bruce Fields wrote: > > > On Wed, Jan 20, 2021 at 10:21:24PM +, David Howells wrote: > > > Note that this uses SEEK_HOLE/SEEK_DATA to locate the data available > > > to b

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Wed, Jan 20, 2021 at 10:21:24PM +, David Howells wrote: > Note that this uses SEEK_HOLE/SEEK_DATA to locate the data available > to be read from the cache. Whilst this is an improvement from the > bmap interface, it still has a problem with regard to a modern >

Re: [PATCH] PM / clk: make PM clock layer compatible with clocks that must sleep

2021-01-21 Thread Rafael J. Wysocki
On Thu, Jan 21, 2021 at 1:11 PM Naresh Kamboju wrote: > > On Thu, 21 Jan 2021 at 16:28, Geert Uytterhoeven wrote: > > > > On Thu, Jan 21, 2021 at 10:13 AM Naresh Kamboju > > wrote: > > > On Tue, 5 Jan 2021 at 08:48, Nicolas Pitre wrote: > > > > > > > > The clock API splits its interface into

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-21 Thread Rafael J. Wysocki
On Thu, Jan 21, 2021 at 1:04 PM Daniel Scally wrote: > > > On 21/01/2021 11:58, Rafael J. Wysocki wrote: > > On Thu, Jan 21, 2021 at 10:47 AM Daniel Scally wrote: > >> Hi Rafael > >> > >> On 19/01/2021 13:15, Rafael J. Wysocki wrote: > >>>

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-21 Thread Rafael J. Wysocki
On Thu, Jan 21, 2021 at 10:47 AM Daniel Scally wrote: > > Hi Rafael > > On 19/01/2021 13:15, Rafael J. Wysocki wrote: > > On Mon, Jan 18, 2021 at 9:51 PM Daniel Scally wrote: > >> On 18/01/2021 16:14, Rafael J. Wysocki wrote: > >>> On Mon, Jan 1

Re: [PATCH -next] fs/xfs: convert comma to semicolon

2021-01-20 Thread Darrick J. Wong
On Fri, Dec 11, 2020 at 04:41:12PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Apparently I forgot to ack this before merging it... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Rafael J. Wysocki
On Wed, Jan 20, 2021 at 7:51 PM Andy Shevchenko wrote: > > On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki wrote: > > On Tue, Jan 12, 2021 at 7:02 PM Andy Shevchenko > > wrote: > > > On Tue, Jan 12, 2021 at 09:30:31AM -0800, Saravana Kannan wrote: > > &g

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Rafael J. Wysocki
On Wed, Jan 20, 2021 at 7:44 PM Andy Shevchenko wrote: > > On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki wrote: > > On Tue, Jan 12, 2021 at 4:47 PM Andy Shevchenko > > wrote: > > > On Tue, Jan 12, 2021 at 3:42 PM Calvin Johnson > > > wrote: > &g

[PATCH v1 0/6] ACPI: Clean up printing messages in some source files

2021-01-20 Thread Rafael J. Wysocki
Hi, This series cleans up messaging in some source files under drivers/acpi/ and get rids of some debug code pieces that aren't needed any more. The primary goal here was to get rid of things like ACPI_DEBUG_PRINT() or ACPI_EXCEPTION() from non-ACPICA code (they are specific to ACPICA and should

[PATCH v1 2/6] ACPI: PM: Clean up printing messages

2021-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Replace the remaining ACPI_DEBUG_PRINT() instances in device_pm.c with dev_dbg() invocations, drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not used any more, and drop the no longer needed ACPI_POWER_COMPONENT definition from the headers

[PATCH v1 3/6] ACPI: bus: Clean up printing messages

2021-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Replace all of the ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() instances in bus.c with pr_debug() and pr_info(), respectively, drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not used any more and replace direct printk() invocations with the matching pr_

[PATCH v1 1/6] ACPI: power: Clean up printing messages

2021-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Replace all of the ACPI_DEBUG_PRINT() instances in power.c with acpi_handle_debug() or pr_debug(), depending on the context, drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not used any more, and replace the direct invocations of printk

[PATCH v1 4/6] ACPI: scan: Clean up printing messages

2021-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Replace all of the ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() instances in scan.c with acpi_handle_debug() and acpi_handle_info(), respectively, and drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not used any more. While at it, drop the redundant "M

[PATCH v1 6/6] ACPI: bus: Drop ACPI_BUS_COMPONENT which is not used any more

2021-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki After dropping all of the code using ACPI_BUS_COMPONENT drop it too and modify the example in the documentation using it. Signed-off-by: Rafael J. Wysocki --- Documentation/firmware-guide/acpi/debug.rst | 13 ++--- drivers/acpi/sysfs.c

[PATCH v1 5/6] ACPI: utils: Clean up printing messages

2021-01-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Replace all of the ACPI_DEBUG_PRINT() instances in utils.c with pr_debug() and acpi_handle_debug(), drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not used any more and replace direct printk() invocations with pr_debug() calls (the log level

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 7:02 PM Andy Shevchenko wrote: > > On Tue, Jan 12, 2021 at 09:30:31AM -0800, Saravana Kannan wrote: > > On Tue, Jan 12, 2021 at 5:42 AM Calvin Johnson > > wrote: > > > > > > Using fwnode_get_id(), get the reg property value for DT node > > > or get the _ADR object value

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 4:47 PM Andy Shevchenko wrote: > > On Tue, Jan 12, 2021 at 3:42 PM Calvin Johnson > wrote: > > > > Using fwnode_get_id(), get the reg property value for DT node > > or get the _ADR object value for ACPI node. > > > > Signed-off-by: Calvin Johnson > > --- > > > > Changes

Re: [PATCH] resource: Remove unneeded semicolon

2021-01-19 Thread Rafael J. Wysocki
resource *res) { }; +static inline void revoke_devmem(struct resource *res) { } #endif #endif /* __ASSEMBLY__ */ The patch is fine AFAICS, so Reviewed-by: Rafael J. Wysocki but I'm not sure why it has been sent to me. It would be better to send it to Greg instead. Thanks!

Re: [PATCH] PM / clk: make PM clock layer compatible with clocks that must sleep

2021-01-19 Thread Rafael J. Wysocki
On Mon, Jan 18, 2021 at 12:50 AM Nicolas Pitre wrote: > > Ping. Applied as 5.12 material, sorry for the delay. Thanks! > On Mon, 4 Jan 2021, Nicolas Pitre wrote: > > > The clock API splits its interface into sleepable ant atomic contexts: > > > > - clk_prepare/clk_unprepare for stuff that

Re: [PATCH v2] driver core: Extend device_is_dependent()

2021-01-19 Thread Rafael J. Wysocki
On Fri, Jan 15, 2021 at 7:31 PM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > If the device passed as the target (second argument) to > device_is_dependent() is not completely registered (that is, it has > been initialized, but not added yet), but the parent poin

[tip: sched/urgent] x86: PM: Register syscore_ops for scale invariance

2021-01-19 Thread tip-bot2 for Rafael J. Wysocki
The following commit has been merged into the sched/urgent branch of tip: Commit-ID: 9c7d9017a49fb8516c13b7bff59b7da2abed23e1 Gitweb: https://git.kernel.org/tip/9c7d9017a49fb8516c13b7bff59b7da2abed23e1 Author:Rafael J. Wysocki AuthorDate:Fri, 08 Jan 2021 19:05:59 +01:00

Re: [PATCH] x86: PM: Register syscore_ops for scale invariance

2021-01-19 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 4:10 PM Rafael J. Wysocki wrote: > > On Tue, Jan 12, 2021 at 4:02 PM Peter Zijlstra wrote: > > > > On Fri, Jan 08, 2021 at 07:05:59PM +0100, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > On x86 scale inva

Re: [PATCH v2] driver core: Extend device_is_dependent()

2021-01-19 Thread Rafael J. Wysocki
On Mon, Jan 18, 2021 at 11:03 PM Saravana Kannan wrote: > > On Fri, Jan 15, 2021 at 10:30 AM Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > If the device passed as the target (second argument) to > > device_is_dependent() is not completely

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-19 Thread Rafael J. Wysocki
On Mon, Jan 18, 2021 at 9:51 PM Daniel Scally wrote: > > On 18/01/2021 16:14, Rafael J. Wysocki wrote: > > On Mon, Jan 18, 2021 at 1:37 AM Daniel Scally wrote: > >> In some ACPI tables we encounter, devices use the _DEP method to assert > >> a dependence on

Re: [PATCH v2 4/7] i2c: i2c-core-acpi: Add i2c_acpi_dev_name()

2021-01-19 Thread Rafael J. Wysocki
On Mon, Jan 18, 2021 at 9:55 PM Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Mon, Jan 18, 2021 at 12:34:25AM +, Daniel Scally wrote: > > We want to refer to an i2c device by name before it has been > > s/i2c device/acpi i2c device/ ? > > > created by the kernel;

[PATCH] ACPI: scan: Rearrange code related to acpi_get_device_data()

2021-01-18 Thread Rafael J. Wysocki
From: Rafael J. Wysocki There are two callers of acpi_get_device_data(), acpi_bus_get_device() and acpi_bus_get_acpi_device(), but only one of them takes the int return value into account. Moreover, the latter knows that it passes a valid return pointer to acpi_get_device_data() and it properly

Re: [PATCH v1 1/2] ACPI: scan: Rearrange memory allocation in acpi_device_add()

2021-01-18 Thread Rafael J. Wysocki
On Sat, Jan 16, 2021 at 1:37 PM Hans de Goede wrote: > > Hi, > > On 1/14/21 7:46 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The upfront allocation of new_bus_id is done to avoid allocating > > memory under acpi_device_lock, but it

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-18 Thread Rafael J. Wysocki
On Mon, Jan 18, 2021 at 1:37 AM Daniel Scally wrote: > > In some ACPI tables we encounter, devices use the _DEP method to assert > a dependence on other ACPI devices as opposed to the OpRegions that the > specification intends. We need to be able to find those devices "from" > the dependee, so

Re: [PATCH v2 1/7] acpi: utils: move acpi_lpss_dep() to utils

2021-01-18 Thread Rafael J. Wysocki
On Mon, Jan 18, 2021 at 1:30 PM Andy Shevchenko wrote: > > On Mon, Jan 18, 2021 at 12:34:22AM +, Daniel Scally wrote: > > I need to be able to identify devices which declare themselves to be > > dependent on other devices through _DEP; add this function to utils.c > > and export it to the

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Rafael J. Wysocki
CC Mika and Andy. On Mon, Jan 18, 2021 at 8:27 AM Kai-Heng Feng wrote: > > On Sat, Jan 9, 2021 at 12:25 AM Kai-Heng Feng > wrote: > > > > Commit 8765c5ba19490 ("ACPI / scan: Rework modalias creation when > > "compatible" is present") creates two modaliases for certain ACPI > > devices. However

[GIT PULL] ACPI fixes for v5.11-rc4

2021-01-15 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-5.11-rc4 with top-most commit 179892adb0436139fd8e6af7b27f54219c1750f8 Merge branch 'acpi-docs' on top of commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837 Linux 5.11-rc3 to receive

[PATCH v2] driver core: Extend device_is_dependent()

2021-01-15 Thread Rafael J. Wysocki
From: Rafael J. Wysocki If the device passed as the target (second argument) to device_is_dependent() is not completely registered (that is, it has been initialized, but not added yet), but the parent pointer of it is set, it may be missing from the list of the parent's children

Re: [PATCH] driver core: Extend device_is_dependent()

2021-01-15 Thread Rafael J. Wysocki
On Fri, Jan 15, 2021 at 6:21 PM Saravana Kannan wrote: > > On Fri, Jan 15, 2021 at 5:03 AM Rafael J. Wysocki wrote: > > > > On Fri, Jan 15, 2021 at 11:03 AM Stephan Gerhold > > wrote: > > > > > > Hi, > > > > > > On Thu, Jan 14, 202

Re: [PATCH] driver core: Extend device_is_dependent()

2021-01-15 Thread Rafael J. Wysocki
On Fri, Jan 15, 2021 at 11:03 AM Stephan Gerhold wrote: > > Hi, > > On Thu, Jan 14, 2021 at 11:31:12AM -0800, Saravana Kannan wrote: > > On Thu, Jan 14, 2021 at 10:41 AM Rafael J. Wysocki > > wrote: > > > > > > From: Rafael J. Wysocki

Re: [PATCH] driver core: Extend device_is_dependent()

2021-01-15 Thread Rafael J. Wysocki
On Thu, Jan 14, 2021 at 8:59 PM Saravana Kannan wrote: > > On Thu, Jan 14, 2021 at 11:38 AM Rafael J. Wysocki wrote: > > > > On Thu, Jan 14, 2021 at 8:32 PM Saravana Kannan > > wrote: > > > > > > On Thu, Jan 14, 2021 at 10:41 AM Rafael J. Wysocki &

Re: [PATCH] driver core: Extend device_is_dependent()

2021-01-14 Thread Rafael J. Wysocki
On Thu, Jan 14, 2021 at 8:32 PM Saravana Kannan wrote: > > On Thu, Jan 14, 2021 at 10:41 AM Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > When adding a new device link, device_is_dependent() is used to > > check whether or not

[PATCH v1 0/2] ACPI: scan: Janitorial changes in acpi_device_add()

2021-01-14 Thread Rafael J. Wysocki
Hi, As per the subject on top of linux-next from today. Please refer to the patch changelogs for details. Thanks!

[PATCH v1 1/2] ACPI: scan: Rearrange memory allocation in acpi_device_add()

2021-01-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The upfront allocation of new_bus_id is done to avoid allocating memory under acpi_device_lock, but it doesn't really help, because (1) it leads to many unnecessary memory allocations for _ADR devices, (2) kstrdup_const() is run under that lock anyway and (3

[PATCH v1 2/2] ACPI: scan: Adjust white space in acpi_device_add()

2021-01-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Add empty lines in some places in acpi_device_add() to help readability and drop leading spaces before the labels in there. No functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/scan.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions

[PATCH] driver core: Extend device_is_dependent()

2021-01-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki When adding a new device link, device_is_dependent() is used to check whether or not the prospective supplier device does not depend on the prospective consumer one to avoid adding loops to the graph of device dependencies. However, device_is_dependent() does not take

[PATCH] ACPI: thermal: Do not call acpi_thermal_check() directly

2021-01-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Calling acpi_thermal_check() from acpi_thermal_notify() directly is problematic if _TMP triggers Notify () on the thermal zone for which it has been evaluated (which happens on some systems), because it causes a new acpi_thermal_notify() invocation to be queued up every

Re: [PATCH 04/10] mm, fsdax: Refactor memory-failure handler for dax mapping

2021-01-14 Thread Darrick J. Wong
On Thu, Jan 14, 2021 at 05:38:33PM +0800, zhong jiang wrote: > > On 2021/1/14 11:52 上午, Ruan Shiyang wrote: > > > > > > On 2021/1/14 上午11:26, zhong jiang wrote: > > > > > > On 2021/1/14 9:44 上午, Ruan Shiyang wrote: > > > > > > > > > > > > On 2021/1/13 下午6:04, zhong jiang wrote: > > > > > >

Re: [PATCH 1/1] Documentation: ACPI: EINJ: Fix error type value for PCIe error

2021-01-14 Thread Rafael J. Wysocki
On Thu, Jan 14, 2021 at 8:20 AM Qiuxu Zhuo wrote: > > Fix the error type value for PCI Express uncorrectable non-fatal > error to 0x0080 and fix the error type value for PCI Express > uncorrectable fatal error to 0x0100. > > See Advanced Configuration and Power Interface Specification, >

Re: [RFC PATCH v3 02/16] cxl/acpi: Add an acpi_cxl module for the CXL interconnect

2021-01-13 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 1:29 AM Ben Widawsky wrote: > > From: Vishal Verma > > Add an acpi_cxl module to coordinate the ACPI portions of the CXL > (Compute eXpress Link) interconnect. This driver binds to ACPI0017 > objects in the ACPI tree, and coordinates access to the resources > provided by

Re: [PATCH v5 00/15] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2021-01-12 Thread Rafael J. Wysocki
3-cio2.c > media: v4l2-core: v4l2-async: Check sd->fwnode->secondary in > match_fwnode() > ACPI / bus: Add acpi_dev_get_next_match_dev() and helper macro > media: v4l2-fwnode: Include v4l2_fwnode_bus_type > ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver > > Heikki Krogerus (1): > software_node: Add support for fwnode_graph*() family of functions Please feel free to add Acked-by: Rafael J. Wysocki to all of the device properties patches in this series if that helps. Thanks!

Re: [PATCH v5 07/15] device property: Define format macros for ports and endpoints

2021-01-12 Thread Rafael J. Wysocki
ned int representing the > index of the node. To ensure commonality across the subsystems, provide a > set of macros to define the format. > > Suggested-by: Andy Shevchenko > Reviewed-by: Andy Shevchenko > Reviewed-by: Laurent Pinchart > Signed-off-by: Daniel Scally

Re: [PATCH v5 07/15] device property: Define format macros for ports and endpoints

2021-01-12 Thread Rafael J. Wysocki
On Sat, Jan 9, 2021 at 3:06 AM Laurent Pinchart wrote: > > Hi Rafael, > > Could you please let us know with an Acked-by Done, sorry for the delay. > if this patch can be merged through the linux-media tree for v5.12 ? Yes, it can. Thanks!

Re: [PATCH v5 13/15] ACPI / bus: Add acpi_dev_get_next_match_dev() and helper macro

2021-01-12 Thread Rafael J. Wysocki
Hi, On Sat, Jan 9, 2021 at 2:55 AM Laurent Pinchart wrote: > > Hi Rafael, > > Could you please review this patch, and let us know (see question in the > cover letter) Done, sorry for the delay. > if it can be merged through the linux-media tree for v5.12 > ? Yes, it can. Thanks!

Re: [PATCH v5 13/15] ACPI / bus: Add acpi_dev_get_next_match_dev() and helper macro

2021-01-12 Thread Rafael J. Wysocki
by: Andy Shevchenko > Signed-off-by: Daniel Scally Acked-by: Rafael J. Wysocki > --- > Changes in v5: > > - Changed commit subject > > drivers/acpi/utils.c| 30 ++ > include/acpi/acpi_bus.h | 7 +++ > 2 files changed, 33

Re: [PATCH][v3] cpufreq: intel_pstate: Get percpu max freq via HWP MSR register if available

2021-01-12 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 4:00 PM Chen Yu wrote: > > On Tue, Jan 12, 2021 at 02:52:50PM +0100, Rafael J. Wysocki wrote: > > On Tue, Jan 12, 2021 at 6:19 AM Chen Yu wrote: > > > > > > Currently when turbo is disabled(either by BIOS or by the user), the > > >

Re: Infinite recursion in device_reorder_to_tail() due to circular device links

2021-01-12 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 3:32 PM Rafael J. Wysocki wrote: > > On Mon, Jan 11, 2021 at 7:46 PM Stephan Gerhold wrote: > > > > Hi, > > > > since 5.11-rc1 I get kernel crashes with infinite recursion in > > device_reorder_to_tail() in some situations... It's a

Re: [PATCH] x86: PM: Register syscore_ops for scale invariance

2021-01-12 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 4:02 PM Peter Zijlstra wrote: > > On Fri, Jan 08, 2021 at 07:05:59PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > On x86 scale invariace tends to be disabled during resume from > > suspend-to-RAM, because

Re: [RFC PATCH v3 03/16] cxl/acpi: add OSC support

2021-01-12 Thread Rafael J. Wysocki
Something has gone wrong with CCing this to linux-acpi, but no worries. On Tue, Jan 12, 2021 at 1:29 AM Ben Widawsky wrote: > > From: Vishal Verma > > Add support to advertise OS capabilities, and request OS control for CXL > features using the ACPI _OSC mechanism. Advertise support for all >

Re: Infinite recursion in device_reorder_to_tail() due to circular device links

2021-01-12 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 7:46 PM Stephan Gerhold wrote: > > Hi, > > since 5.11-rc1 I get kernel crashes with infinite recursion in > device_reorder_to_tail() in some situations... It's a bit complicated to > explain so I want to apologize in advance for the long mail. :) > > Kernel panic - not

Re: [PATCH][v3] cpufreq: intel_pstate: Get percpu max freq via HWP MSR register if available

2021-01-12 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 6:19 AM Chen Yu wrote: > > Currently when turbo is disabled(either by BIOS or by the user), the > intel_pstate driver reads the max non-turbo frequency from the package-wide > MSR_PLATFORM_INFO(0xce) register. However on asymmetric platforms it is > possible in theory that

Re: [PATCH] drivers: core: Detach device from power domain on shutdown

2021-01-12 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 10:55 AM Dmitry Osipenko wrote: > > 02.12.2020 00:30, Furquan Shaikh пишет: > > When the system is powered off or rebooted, devices are not detached > > from their PM domain. This results in ACPI PM not being invoked and > > hence PowerResouce _OFF method not being invoked

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-12 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 11:44 PM Saravana Kannan wrote: > > On Mon, Jan 11, 2021 at 8:57 AM Rafael J. Wysocki wrote: > > > > On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > > > > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote:

Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-11 Thread Rafael J. Wysocki
On Sat, Jan 9, 2021 at 6:08 PM Rafael J. Wysocki wrote: > > On Saturday, January 9, 2021 10:37:41 AM CET Dexuan Cui wrote: > > > From: Andy Shevchenko > > > Sent: Saturday, January 9, 2021 12:52 AM > > >> > > >> Hi Rafael, Len, and all, &

Re: Malicious fs images was Re: ext4 regression in v5.9-rc2 from e7bfb5c9bb3d on ro fs with overlapped bitmaps

2021-01-11 Thread Darrick J. Wong
On Sun, Jan 10, 2021 at 07:41:02PM +0100, Pavel Machek wrote: > Hi! > > On Fri 2020-10-09 10:37:32, Theodore Y. Ts'o wrote: > > On Thu, Oct 08, 2020 at 03:22:59PM -0700, Josh Triplett wrote: > > > > > > I wasn't trying to make a *new* general principle or policy. I was under > > > the impression

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > > On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > > > > > On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Di

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Dickins wrote: > > Hi Rafael, > > > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > > fails to suspend when running 5.11-rc kernels: bisected to > > 5b6164d3465f

[PATCH v2 0/5] Optimize iommu_map_sg() performance

2021-01-11 Thread Isaac J. Manjarres
address ranges being mapped are within the appropriate limits. -Added Sai Prakash Ranjan's "Tested-by" tag. Thanks, Isaac Isaac J. Manjarres (5): iommu/io-pgtable: Introduce map_sg() as a page table op iommu/io-pgtable-arm: Hook up map_sg() iommu/io-pgtable-arm-v7s: Hook up map_sg

[PATCH v2 1/5] iommu/io-pgtable: Introduce map_sg() as a page table op

2021-01-11 Thread Isaac J. Manjarres
calls, and boosting overall iommu_map_sg() performance. Signed-off-by: Isaac J. Manjarres Tested-by: Sai Prakash Ranjan --- include/linux/io-pgtable.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/io-pgtable.h b/include/linux/io-pgtable.h index ea727eb..6d0e731 100644

[PATCH v2 5/5] iommu/arm-smmu: Hook up map_sg()

2021-01-11 Thread Isaac J. Manjarres
Now that everything is in place for iommu_map_sg() to defer mapping a scatter-gather list to the io-pgtable layer, implement the map_sg() callback in the SMMU driver, so that iommu_map_sg() can invoke it with the entire scatter-gather list that will be mapped. Signed-off-by: Isaac J. Manjarres

[PATCH v2 3/5] iommu/io-pgtable-arm-v7s: Hook up map_sg()

2021-01-11 Thread Isaac J. Manjarres
Implement the map_sg io-pgtable op for the ARMv7s io-pgtable code, so that IOMMU drivers can call it when they need to map a scatter-gather list. Signed-off-by: Isaac J. Manjarres Tested-by: Sai Prakash Ranjan --- drivers/iommu/io-pgtable-arm-v7s.c | 90

[PATCH v2 4/5] iommu: Introduce map_sg() as an IOMMU op for IOMMU drivers

2021-01-11 Thread Isaac J. Manjarres
in the io-pgtable layer. For IOMMU drivers that do not provide a callback, the default implementation of iterating through the scatter-gather list, while calling iommu_map() will be used. Signed-off-by: Isaac J. Manjarres Tested-by: Sai Prakash Ranjan --- drivers/iommu/iommu.c | 13

[PATCH v2 2/5] iommu/io-pgtable-arm: Hook up map_sg()

2021-01-11 Thread Isaac J. Manjarres
Implement the map_sg io-pgtable op for the ARM LPAE io-pgtable code, so that IOMMU drivers can call it when they need to map a scatter-gather list. Signed-off-by: Isaac J. Manjarres Tested-by: Sai Prakash Ranjan --- drivers/iommu/io-pgtable-arm.c | 86

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > On Sun, Jan 10, 2021 at 08:44:13PM -0800, Hugh Dickins wrote: > > Hi Rafael, > > > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > > fails to suspend when running 5.11-rc kernels: bisected to > > 5b6164d3465f

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Rafael J. Wysocki
Hi Hugh, Thanks for the report! On Mon, Jan 11, 2021 at 5:44 AM Hugh Dickins wrote: > > Hi Rafael, > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > fails to suspend when running 5.11-rc kernels: bisected to > 5b6164d3465f ("driver core: Reorder devices on successful

Re: [PATCH 1/2][v2] cpufreq: intel_pstate: Add parameter to get guarantee frequency

2021-01-11 Thread Rafael J. Wysocki
On Mon, Jan 11, 2021 at 8:40 AM Chen Yu wrote: > > Add input parameter to receive guarantee pstate from > intel_pstate_get_hwp_max() > for later use. I'm not a fan of this change, because the new argument will only be needed in one place where intel_pstate_get_hwp_max() and it requires adding

Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-09 Thread Rafael J. Wysocki
On Saturday, January 9, 2021 10:37:41 AM CET Dexuan Cui wrote: > > From: Andy Shevchenko > > Sent: Saturday, January 9, 2021 12:52 AM > >> > >> Hi Rafael, Len, and all, > >> Can you please take a look at the v2 patch? > >> > >> The Linux mainline has been broken for several weeks when it > >>

[PATCH] maintainers: update my email address

2021-01-08 Thread Darrick J. Wong
From: Darrick J. Wong Change my email contact ahead of a likely painful eleven-month migration to a certain cobalt enteprisey groupware cloud product that will totally break my workflow. Some day I may get used to having to email being sequestered behind both claret and cerulean oath2+sms 2fa

[PATCH 0/5] Optimize iommu_map_sg() performance

2021-01-08 Thread Isaac J. Manjarres
latencies is the same in both experiments. Clearly, reducing the jumps between the different layers in the IOMMU code offers a signficant performance boost in iommu_map_sg() latency. Thanks, Isaac Isaac J. Manjarres (5): iommu/io-pgtable: Introduce map_sg() as a page table op iommu/io-pgtable

[PATCH 5/5] iommu/arm-smmu: Hook up map_sg()

2021-01-08 Thread Isaac J. Manjarres
Now that everything is in place for iommu_map_sg() to defer mapping a scatter-gather list to the io-pgtable layer, implement the map_sg() callback in the SMMU driver, so that iommu_map_sg() can invoke it with the entire scatter-gather list that will be mapped. Signed-off-by: Isaac J. Manjarres

[PATCH 3/5] iommu/io-pgtable-arm-v7s: Hook up map_sg()

2021-01-08 Thread Isaac J. Manjarres
Implement the map_sg io-pgtable op for the ARMv7s io-pgtable code, so that IOMMU drivers can call it when they need to map a scatter-gather list. Signed-off-by: Isaac J. Manjarres --- drivers/iommu/io-pgtable-arm-v7s.c | 90 ++ 1 file changed, 90 insertions

[PATCH 4/5] iommu: Introduce map_sg() as an IOMMU op for IOMMU drivers

2021-01-08 Thread Isaac J. Manjarres
in the io-pgtable layer. For IOMMU drivers that do not provide a callback, the default implementation of iterating through the scatter-gather list, while calling iommu_map() will be used. Signed-off-by: Isaac J. Manjarres --- drivers/iommu/iommu.c | 13 + include/linux/iommu.h | 5 + 2

[PATCH 2/5] iommu/io-pgtable-arm: Hook up map_sg()

2021-01-08 Thread Isaac J. Manjarres
Implement the map_sg io-pgtable op for the ARM LPAE io-pgtable code, so that IOMMU drivers can call it when they need to map a scatter-gather list. Signed-off-by: Isaac J. Manjarres --- drivers/iommu/io-pgtable-arm.c | 86 ++ drivers/iommu/iommu.c

[PATCH 1/5] iommu/io-pgtable: Introduce map_sg() as a page table op

2021-01-08 Thread Isaac J. Manjarres
calls, and boosting overall iommu_map_sg() performance. Signed-off-by: Isaac J. Manjarres --- include/linux/io-pgtable.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/io-pgtable.h b/include/linux/io-pgtable.h index ea727eb..6d0e731 100644 --- a/include/linux/io-pgtable.h

Re: [PATCH 02/10] blk: Introduce ->corrupted_range() for block device

2021-01-08 Thread Darrick J. Wong
On Fri, Jan 08, 2021 at 10:55:00AM +0100, Christoph Hellwig wrote: > It happens on a dax_device. We should not interwind dax and block_device > even more after a lot of good work has happened to detangle them. I agree that the dax device should not be implied from the block device, but what

Re: [RFC PATCH v3 8/9] md: Implement ->corrupted_range()

2021-01-08 Thread Darrick J. Wong
On Fri, Jan 08, 2021 at 05:52:11PM +0800, Ruan Shiyang wrote: > > > On 2021/1/5 上午7:34, Darrick J. Wong wrote: > > On Fri, Dec 18, 2020 at 10:11:54AM +0800, Ruan Shiyang wrote: > > > > > > > > > On 2020/12/16 上午4:51, Darrick J. Wong wrote: > &

[PATCH] x86: PM: Register syscore_ops for scale invariance

2021-01-08 Thread Rafael J. Wysocki
From: Rafael J. Wysocki On x86 scale invariace tends to be disabled during resume from suspend-to-RAM, because the MPERF or APERF MSR values are not as expected then due to updates taking place after the platform firmware has been invoked to complete the suspend transition. That, of course

[GIT PULL] Device properties framework fixes for v5.11-rc3

2021-01-08 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ devprop-5.11-rc3 with top-most commit 3f7bddaf5d5a83aa2eb1e6d72db221d3ec43c813 device property: add description of fwnode cases on top of commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62

<    2   3   4   5   6   7   8   9   10   11   >