Re: [PATCH v1 4/4] cpufreq: intel_pstate: Implement the ->adjust_perf() callback

2020-12-08 Thread Rafael J. Wysocki
On Tue, Dec 8, 2020 at 1:44 PM Peter Zijlstra wrote: > > On Mon, Dec 07, 2020 at 05:38:58PM +0100, Rafael J. Wysocki wrote: > > > +static void intel_cpufreq_adjust_perf(unsigned int cpunum, > > + u

Re: [PATCH v1 2/4] cpufreq: schedutil: Adjust utilization instead of frequency

2020-12-08 Thread Rafael J. Wysocki
On Tue, Dec 8, 2020 at 9:52 AM Viresh Kumar wrote: > > On 07-12-20, 17:29, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > When avoiding reduction of the frequency after the target CPU has > > been busy since the previous frequency update, adju

[PATCH] ACPI: scan: Fix up _DEP-related terminology with supplier/consumer

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The ACPI namespace scanning code uses the terms master/slave when populating the list of _DEP dependencies, but that use has no external exposures and is not mandated by nor associated with any external specifications. Change the language used through-out to supplier

[PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep_ids[]

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki According to Hans, all device objects where the _HID returns "INT3396" also have a _CID returning "PNP0D80", so the former need not be present in acpi_ignore_dep_ids[] any more. Link: https://lore.kernel.org/linux-acpi/52a2b98c-6bf3-760b-eca9-93c

[PATCH v1 2/4] cpufreq: schedutil: Adjust utilization instead of frequency

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki When avoiding reduction of the frequency after the target CPU has been busy since the previous frequency update, adjust the utilization instead of adjusting the frequency, because doing so is more prudent (it is done to counter a possible utilization deficit after all

[PATCH v1 0/4] cpufreq: Allow drivers to receive more information from the governor

2020-12-07 Thread Rafael J. Wysocki
Hi, This is based on the RFC posted a few days ago: https://lore.kernel.org/linux-pm/1817571.2o5Kk4Ohv2@kreacher/ The majority of the original cover letter still applies, so let me quote it here: Using intel_pstate in the passive mode with HWP enabled, in particular under the schedutil

[PATCH v1 1/4] cpufreq: schedutil: Add util to struct sg_cpu

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Instead of passing util and max between functions while computing the utilization and capacity, store the former in struct sg_cpu (along with the latter and bw_dl). This will allow the current utilization value to be compared with the one obtained previously (which

[PATCH v1 4/4] cpufreq: intel_pstate: Implement the ->adjust_perf() callback

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make intel_pstate expose the ->adjust_perf() callback when it operates in the passive mode with HWP enabled which causes the schedutil governor to use that callback instead of ->fast_switch(). The minimum and target performance-level values passed by the go

[PATCH v1 3/4] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki First off, some cpufreq drivers (eg. intel_pstate) can pass hints beyond the current target frequency to the hardware and there are no provisions for doing that in the cpufreq framework. In particular, today the driver has to assume that it should not allow the frequency

Re: [RFC PATCH 0/4] Add processor to the ignore PSD override list

2020-12-07 Thread Rafael J. Wysocki
On Fri, Dec 4, 2020 at 11:45 PM Punit Agrawal wrote: > > Hi Rafael, > > Punit Agrawal writes: > > > Hi, > > > > While looking into Giovanni's patches to enable frequency invariance > > on AMD systems[0], I noticed an issue with initialising frequency > > domain information on a recent AMD APU. >

Re: [RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-07 Thread Rafael J. Wysocki
On Mon, Dec 7, 2020 at 8:47 AM Viresh Kumar wrote: > > On 30-11-20, 19:37, Rafael J. Wysocki wrote: > > Index: linux-pm/include/linux/cpufreq.h > > === > > --- linux-pm.orig/include/linux/cpufreq.h > &

Re: [PATCH] ACPI: fan: fix warning with CONFIG_DEBUG_LOCK_ALLOC

2020-12-07 Thread Rafael J. Wysocki
/sysfs.h > > Fixes: d19e470b6605c ('ACPI: fan: Expose fan performance state information') > Cc: Srinivas Pandruvada > Cc: Rafael J. Wysocki > Signed-off-by: Pierre-Louis Bossart > --- > drivers/acpi/fan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --

Re: [PATCH] ACPI: Add DMI quirk for GIGABYTE GB-BXBT-2807

2020-12-07 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 7:41 AM Chris Chiu wrote: > > From: "Jasper St. Pierre" > > The GIGABYTE GB-BXBT-2807 is a mini-PC which uses off the shelf > components, like an Intel GPU which is meant for mobile systems. > As such, it, by default, has a backlight controller exposed. > > Unfortunately,

Re: [PATCH v2] Revert "ACPI / resources: Use AE_CTRL_TERMINATE to terminate resources walks"

2020-12-07 Thread Rafael J. Wysocki
On Sat, Dec 5, 2020 at 7:42 PM Daniel Scally wrote: > > This reverts commit 8a66790b7850a6669129af078768a1d42076a0ef. > > Switching this function to AE_CTRL_TERMINATE broke the documented > behaviour of acpi_dev_get_resources() - AE_CTRL_TERMINATE does not, in > fact, terminate the resource walk

Re: [PATCH] ACPI: scan: Add PNP0D80 to the _DEP exceptions list

2020-12-07 Thread Rafael J. Wysocki
On Sat, Dec 5, 2020 at 7:41 PM Hans de Goede wrote: > > Hi, > > On 12/5/20 4:29 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The PNP0D80 ("Windows-compatible System Power Management Controller") > > device ID is used for i

[PATCH] ACPI: scan: Add PNP0D80 to the _DEP exceptions list

2020-12-05 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The PNP0D80 ("Windows-compatible System Power Management Controller") device ID is used for identifying the special device object providing the LPI (Low-power S0 Idle) _DSM interface [1]. That device object does not supply any operation regions, but it appea

Re: [PATCH] acpi: resource: Use AE_ABORT_METHOD to terminate acpi_dev_get_resources()

2020-12-05 Thread Rafael J. Wysocki
On Friday, December 4, 2020 1:27:40 AM CET Daniel Scally wrote: > Switching this function to AE_CTRL_TERMINATE broke the documented > behaviour of acpi_dev_get_resources() - AE_CTRL_TERMINATE does not, in > fact, terminate the resource walk because acpi_walk_resource_buffer() > ignores it

Re: [PATCH] drivers: acpi: add opt-out of Apple-specific property parsing

2020-12-03 Thread Rafael J. Wysocki
On Thu, Dec 3, 2020 at 6:47 PM Enrico Weigelt, metux IT consult wrote: > > Most x86 machines aren't Apple machines, especially VMs. > Therefore allow opt-out, making the kernel a few KBs smaller, > eg. for embedded or high-density VMs. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- >

Re: [PATCH] driver core: Reorder devices on successful probe

2020-12-03 Thread Rafael J. Wysocki
erhead-related concerns. There still are some, but maybe that doesn't matter in practice. Also, I kind of expect this to blow up somewhere, but since I have no examples ready from the top of my head, I think let's try and see, so: Acked-by: Rafael. J. Wysocki > --- > drivers/base/dd.c |

Re: [RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-03 Thread Rafael J. Wysocki
On Thu, Dec 3, 2020 at 1:42 PM Peter Zijlstra wrote: > > On Mon, Nov 30, 2020 at 07:37:01PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > First off, some cpufreq drivers (eg. intel_pstate) can pass hints > > beyond the current ta

Re: power-off delay/hang due to commit 6d25be57 (mainline)

2020-12-02 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 7:31 PM Rafael J. Wysocki wrote: > > On Wed, Dec 2, 2020 at 7:03 PM Sebastian Andrzej Siewior > wrote: > > > > On 2020-10-26 18:20:59 [+0100], To Rafael J. Wysocki wrote: > > > > > > > Done as Bug 208877. > > > > >

Re: power-off delay/hang due to commit 6d25be57 (mainline)

2020-12-02 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 7:03 PM Sebastian Andrzej Siewior wrote: > > On 2020-10-26 18:20:59 [+0100], To Rafael J. Wysocki wrote: > > > > > > Done as Bug 208877. > > > > Rafael, do you have any suggestions? > > > > > > I've lost track of

Re: [RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-02 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 4:59 PM Doug Smythies wrote: > > Hi Rafael, > > On 2020.11.30 10:37 Rafael J. Wysocki wrote: > > > First off, some cpufreq drivers (eg. intel_pstate) can pass hints > > beyond the current target frequency to the hardware and there are

Re: [RFC] ACPI PM during kernel poweroff/reboot

2020-12-02 Thread Rafael J. Wysocki
On Tue, Dec 1, 2020 at 10:38 PM Furquan Shaikh wrote: > > On Wed, Nov 25, 2020 at 10:29 AM Furquan Shaikh wrote: > > > > On Wed, Nov 25, 2020 at 9:51 AM Rafael J. Wysocki wrote: > > > > > > On Wed, Nov 25, 2020 at 6:43 PM Furquan Shaikh wrote: > > &

Re: [PATCH V2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT

2020-12-01 Thread Darrick J. Wong
ute") > Reported-by: David Howells > Signed-off-by: Eric Sandeen > Reviewed-by: David Howells Looks fine to me, Reviewed-by: Darrick J. Wong --D > --- > V2: Change flag value per Darrick Wong > Tweak comment per Darrick Wong > Add Fixes: tags & reported

Re: [PATCH v4 2/5] resource: Add irqresource_disabled()

2020-12-01 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 6:41 PM John Garry wrote: > > Add a common function to set the fields for a irq resource to disabled, > which mimics what is done in acpi_dev_irqresource_disabled(), with a view > to replace that function. > > Signed-off-by: John Garry Reviewed-by:

Re: [PATCH v4 3/5] ACPI: Drop acpi_dev_irqresource_disabled()

2020-12-01 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 6:41 PM John Garry wrote: > > The functionality of acpi_dev_irqresource_disabled() is same as in common > irqresource_disabled(), so drop acpi_dev_irqresource_disabled() in favour > of that function. > > Signed-off-by: John Garry Acked-by:

Re: [PATCH 2/2] statx: move STATX_ATTR_DAX attribute handling to filesystems

2020-12-01 Thread Darrick J. Wong
On Tue, Dec 01, 2020 at 10:59:36AM -0600, Eric Sandeen wrote: > It's a bit odd to set STATX_ATTR_DAX into the statx attributes in the VFS; > while the VFS can detect the current DAX state, it is the filesystem which > actually sets S_DAX on the inode, and the filesystem is the place that > knows

Re: [PATCH 1/2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT

2020-12-01 Thread Darrick J. Wong
On Tue, Dec 01, 2020 at 10:57:11AM -0600, Eric Sandeen wrote: > STATX_ATTR_MOUNT_ROOT and STATX_ATTR_DAX got merged with the same value, > so one of them needs fixing. Move STATX_ATTR_DAX. > > While we're in here, clarify the value-matching scheme for some of the > attributes, and explain why the

Re: [GIT PULL] cpupower update for Linux 5.11-rc1

2020-12-01 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 10:47 PM Shuah Khan wrote: > > Hi Rafael, > > Please pull the following cpupower update for Linux 5.11-rc1. > > This cpupower update for Linux 5.11-rc1 consists of a change to provide > online and offline CPU information. This change makes it easier to keep > track of

Re: [PATCH] cpuidle: Select polling interval based on a c-state with a longer target residency

2020-12-01 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 11:32 PM Mel Gorman wrote: > > On Mon, Nov 30, 2020 at 08:06:44PM +0100, Rafael J. Wysocki wrote: > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > > > b/Documentation/admin-guide/kernel-parameters.txt > > > index

Re: [PATCH] cpuidle: Select polling interval based on a c-state with a longer target residency

2020-11-30 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 10:22 AM Mel Gorman wrote: > > It was noted that a few workloads that idle rapidly regressed when commit > 36fcb4292473 ("cpuidle: use first valid target residency as poll time") > was merged. The workloads in question were heavy communicators that idle > rapidly and were

[RFC][PATCH 0/2] cpufreq: Allow drivers to receive more information from the governor

2020-11-30 Thread Rafael J. Wysocki
Hi, Using intel_pstate in the passive mode with HWP enabled, in particular under the schedutil governor, is still kind of problematic, because it has to assume that it should not allow the frequency to fall below the one requested by the governor. For this reason, it translates the target

[RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers

2020-11-30 Thread Rafael J. Wysocki
From: Rafael J. Wysocki First off, some cpufreq drivers (eg. intel_pstate) can pass hints beyond the current target frequency to the hardware and there are no provisions for doing that in the cpufreq framework. In particular, today the driver has to assume that it should allow the frequency

[RFC][PATCH 2/2] cpufreq: intel_pstate: Implement the ->adjust_perf() callback

2020-11-30 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make intel_pstate expose the ->adjust_perf() callback when it operates in the passive mode with HWP enabled which causes the schedutil governor to use that callback instead of ->fast_switch(). The minimum and target performance-level values passed by the go

Re: [PATCH] fs: iomap: Replace bio_add_page with __bio_add_page in iomap_add_to_ioend

2020-11-30 Thread Darrick J. Wong
On Mon, Nov 30, 2020 at 03:28:51PM +0800, chenle...@gmail.com wrote: > From: Lei Chen > > iomap_add_to_ioend append page on wpc->ioend->io_bio. If io_bio is full, > iomap_chain_bio will allocate a new bio. So when bio_add_page is called, > pages is guaranteed to be appended into

Re: [PATCH] driver core: Fix a couple of typos

2020-11-30 Thread Rafael J. Wysocki
On Fri, Nov 27, 2020 at 11:46 AM Thierry Reding wrote: > > From: Thierry Reding > > These were just some minor typos that have crept in recently and are > easily fixed. > > Signed-off-by: Thierry Reding Reviewed-by: Rafael J. Wysocki > --- > drivers/base/core.c |

[GIT PULL] Power management fix for v5.10-rc5

2020-11-26 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-5.10-rc6 with top-most commit 05b8955f43536c3e1e73edc39639aac9ae32edd8 Merge branch 'cpufreq/arm/fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm on top of commit

Re: [PATCH] cpuidle: Allow configuration of the polling interval before cpuidle enters a c-state

2020-11-26 Thread Rafael J. Wysocki
On Thu, Nov 26, 2020 at 6:25 PM Mel Gorman wrote: > > It was noted that a few workloads that idle rapidly regressed when commit > 36fcb4292473 ("cpuidle: use first valid target residency as poll time") > was merged. The workloads in question were heavy communicators that idle > rapidly and were

Re: [PATCH v2] cpufreq: Fix error return code in cpufreq_online()

2020-11-26 Thread Rafael J. Wysocki
On Thu, Nov 26, 2020 at 2:12 AM Wang ShaoBo wrote: > > Fix to return proper error code instead of 0 in cpufreq_online(), as done > elsewhere in this function. > > Signed-off-by: Wang ShaoBo > --- > drivers/cpufreq/cpufreq.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff

Re: [PATCH v3 2/5] ACPI: Make acpi_dev_irqresource_disabled() public

2020-11-26 Thread Rafael J. Wysocki
On Thu, Nov 26, 2020 at 9:49 AM John Garry wrote: > > On 25/11/2020 17:43, Rafael J. Wysocki wrote: > > On Wed, Nov 25, 2020 at 6:25 PM John Garry wrote: > >> To allow the platform device to "put" an irq, make the function to reset > >> an A

Re: [PATCH v2] acpi: Fix use-after-free in acpi_ipmi.c

2020-11-26 Thread Rafael J. Wysocki
On Thu, Nov 26, 2020 at 2:26 AM Youling Tang wrote: > > kfree() has been called inside put_device so anther kfree would cause a > use-after-free bug. > > Signed-off-by: Youling Tang > --- > drivers/acpi/acpi_ipmi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/acpi_ipmi.c

Re: [PATCH] misc: rtsx: rts5249 support runtime PM

2020-11-26 Thread Rafael J. Wysocki
On Thu, Nov 26, 2020 at 4:07 AM 吳昊澄 Ricky wrote: > > > -Original Message- > > From: Rafael J. Wysocki [mailto:raf...@kernel.org] > > Sent: Wednesday, November 25, 2020 10:04 PM > > To: Bjorn Helgaas; 吳昊澄 Ricky [cut] > > > > +static void rtsx

Re: [PATCH v2] resource: provide meaningful MODULE_LICENSE() in test suite

2020-11-25 Thread Rafael J. Wysocki
On Wed, Nov 25, 2020 at 5:17 PM Andy Shevchenko wrote: > > modpost complains that module has no licence provided. > Provide it via meaningful MODULE_LICENSE(). > > Reported-by: Stephen Rothwell > Signed-off-by: Andy Shevchenko > --- > v2: resent with linux-acpi@ included >

Re: [RFC] ACPI PM during kernel poweroff/reboot

2020-11-25 Thread Rafael J. Wysocki
On Wed, Nov 25, 2020 at 6:43 PM Furquan Shaikh wrote: > > On Wed, Nov 25, 2020 at 8:39 AM Rafael J. Wysocki wrote: > > > > On Thu, Nov 12, 2020 at 8:19 PM Furquan Shaikh wrote: > > > > > > On x86 Chromebooks, we have observed this issue for a long time now -

Re: [PATCH v3 2/5] ACPI: Make acpi_dev_irqresource_disabled() public

2020-11-25 Thread Rafael J. Wysocki
On Wed, Nov 25, 2020 at 6:25 PM John Garry wrote: > > To allow the platform device to "put" an irq, make the function to reset > an ACPI companion device irq resource public. > > Signed-off-by: John Garry I'd rather move it to kernel/resource.c as it is not ACPI-specific and its only connection

Re: [RFC] ACPI PM during kernel poweroff/reboot

2020-11-25 Thread Rafael J. Wysocki
On Thu, Nov 12, 2020 at 8:19 PM Furquan Shaikh wrote: > > On x86 Chromebooks, we have observed this issue for a long time now - > when the system is powered off or rebooted, ACPI PM is not invoked and > this results in PowerResource _OFF methods not being invoked for any > of the devices. The

Re: [PATCH] acpi: Fix use-after-free in acpi_ipmi.c

2020-11-25 Thread Rafael J. Wysocki
On Tue, Nov 24, 2020 at 1:51 PM Youling Tang wrote: > > kfree() has been called inside put_device so anther kfree would cause a > use-after-free bug. > > Signed-off-by: Youling Tang > --- > drivers/acpi/acpi_ipmi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [PATCH] ACPI: processor: Drop duplicate setting of shared_cpu_map

2020-11-25 Thread Rafael J. Wysocki
On Tue, Nov 24, 2020 at 1:00 AM Punit Agrawal wrote: > > 'shared_cpu_map', stored as part of the per-processor > acpi_processor_performance structre, is used to store cpus that share > a performance domain. By definition it contains the owning cpu. > > While building the 'shared_cpu_map' it is

Re: [PATCH V4 1/3] sched/core: Move schedutil_cpu_util() to core.c

2020-11-25 Thread Rafael J. Wysocki
On Tue, Nov 24, 2020 at 7:26 AM Viresh Kumar wrote: > > There is nothing schedutil specific in schedutil_cpu_util(), move it to > core.c and define it only for CONFIG_SMP. > > Signed-off-by: Viresh Kumar For the schedutil part: Acked-by: Rafael J. Wysocki > --- >

Re: [PATCH V4 2/3] sched/core: Rename schedutil_cpu_util() and allow rest of the kernel to use it

2020-11-25 Thread Rafael J. Wysocki
t; thermal core (that will be done in a later commit). > > Signed-off-by: Viresh Kumar For the schedutil change: Acked-by: Rafael J. Wysocki > --- > include/linux/sched.h| 21 + > kernel/sched/core.c | 11 +-- > kernel/sched/cpufreq_sc

Re: [PATCH] nfsd: Fix error return code in nfsd_file_cache_init()

2020-11-25 Thread J. Bruce Fields
On Wed, Nov 25, 2020 at 03:39:33AM -0500, Huang Guobin wrote: > Fix to return PTR_ERR() error code from the error handling case instead of > 0 in function nfsd_file_cache_init(), as done elsewhere in this function. > > Fixes: 65294c1f2c5e7("nfsd: add a new struct file caching facility to nfsd") >

Re: [PATCH] misc: rtsx: rts5249 support runtime PM

2020-11-25 Thread Rafael J. Wysocki
On Tue, Nov 24, 2020 at 9:49 PM Bjorn Helgaas wrote: > > [+cc Rafael, linux-pm for runtime PM question below] > > On Tue, Nov 24, 2020 at 02:02:02PM +0800, ricky...@realtek.com wrote: > > From: Ricky Wu > > > > rtsx_pci_sdmmc: add to support autosuspend when the rtd3_en is set > > > > rtsx_pcr:

Re: [PATCH] cpufreq: Fix error return code in cpufreq_online()

2020-11-25 Thread Rafael J. Wysocki
On Wed, Nov 25, 2020 at 1:49 PM Wang ShaoBo wrote: > > Fix to return proper error code instaed of 0 in cpufreq_online(), as done s/instaed/instead/ > elsewhere in this function. > > Signed-off-by: Wang ShaoBo > --- > drivers/cpufreq/cpufreq.c | 5 - > 1 file changed, 4 insertions(+), 1

答复: [PATCH v3 4/5] crypto: hisilicon/hpre - add 'ECDH' algorithm

2020-11-24 Thread yumeng (J)
Ok, I think I can make a patch to keep them at "include/crypto" . -邮件原件- 发件人: Stephan Mueller [mailto:smuel...@chronox.de] 发送时间: 2020年11月19日 4:25 收件人: yumeng (J) ; herb...@gondor.apana.org.au; da...@davemloft.net 抄送: linux-cry...@vger.kernel.org; Xu Zaibo ; Wangzhou (B) ; li

Potential Issue in Tracing Ring Buffer

2020-11-24 Thread J. Avila
Hello, In the ftrace logs we've collected internally, we have found that there are situations where time seems to go backwards; this breaks userspace tools which expect time to always go forward in these logs. For example, in this snippet from a db845c running a 5.10-rc4 kernel[1] (thanks for

[PATCH v1 0/2] PM: ACPI: PCI: Address issues related to signaling wakeup from bridges

2020-11-24 Thread Rafael J. Wysocki
Hi, These patches fix two problems related to wakeup signaling configuration for bridges. The first one is that wakeup signaling may be disabled prematurely for a bridge (patch [1/2]) and the second one is that device wakeup power configuration may need to be changed when enabling wakeup

[PATCH v1 1/2] PM: ACPI: PCI: Drop acpi_pm_set_bridge_wakeup()

2020-11-24 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The idea behind acpi_pm_set_bridge_wakeup() was to allow bridges to be reference counted for wakeup enabling, because they may be enabled to signal wakeup on behalf of their subordinate devices and that may happen for multiple times in a row, whereas for the other devices

[PATCH v1 2/2] PM: ACPI: Refresh wakeup device power configuration every time

2020-11-24 Thread Rafael J. Wysocki
From: Rafael J. Wysocki When wakeup signaling is enabled for a bridge for the second (or every next) time in a row, its existing device wakeup power configuration may not match the new conditions. For example, some devices below it may have been put into low-power states and that changes

Re: [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled

2020-11-24 Thread Rafael J. Wysocki
On Tuesday, November 24, 2020 6:31:56 PM CET Kai-Heng Feng wrote: > > > On Nov 24, 2020, at 22:00, Rafael J. Wysocki wrote: > > > > On Tue, Nov 24, 2020 at 8:36 AM Kai-Heng Feng > > wrote: > >> > >> Dell Precision 5550 fails to detect

Re: [PATCH V2] PM / EM: Micro optimization in em_cpu_energy

2020-11-24 Thread Rafael J. Wysocki
On 11/23/2020 11:29 AM, Pavankumar Kondeti wrote: When the sum of the utilization of CPUs in a power domain is zero, return the energy as 0 without doing any computations. Signed-off-by: Pavankumar Kondeti --- V2: Fixed the function name in the commit message. include/linux/energy_model.h |

Re: [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled

2020-11-24 Thread Rafael J. Wysocki
On Tue, Nov 24, 2020 at 8:36 AM Kai-Heng Feng wrote: > > Dell Precision 5550 fails to detect Thunderbolt device hotplug events, > once the Thunderbolt device and its root port are runtime-suspended to > D3cold. > > While putting the entire hierarchy to D3cold, the root port ACPI GPE is > enabled

[PATCH 4/5] ACPI: EC: Untangle error handling in advance_transaction()

2020-11-23 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Introduce acpi_ec_spurious_interrupt() for recording spurious interrupts and use it for error handling in advance_transaction(), drop the (now redundant) original error handling block from there along with a frew goto statements that are not necessar

[PATCH 5/5] ACPI: EC: Clean up status flags checks in advance_transaction()

2020-11-23 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Eliminate comparisons from the status flags checks in advance_transaction() (especially from the one that is only correct, because the value of the flag checked in there is 1) and rearrange the code for more clarity while at it. No intentional functio

[PATCH 0/5] ACPI: EC: Cleanups in advance_transaction()

2020-11-23 Thread Rafael J. Wysocki
Hi All, Just a few cleanups related to the advance_transaction() routine in ec.c. Please see patch changelogs for details. Thanks!

[PATCH 3/5] ACPI: EC: Simplify error handling in advance_transaction()

2020-11-23 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Notice that the value of t in advance_transaction() does not change after its initialization and: - Initialize t upfront (and rearrange the definitions of local variables while at it). - Check it against NULL in a block executed when it is NULL. -

[PATCH 2/5] ACPI: EC: Rename acpi_ec_is_gpe_raised()

2020-11-23 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Rename acpi_ec_is_gpe_raised() into acpi_ec_gpe_status_set(), update its callers accordingly and drop the ternary operator (which isn't really necessary in there) from it. No intentional functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/acp

[PATCH 1/5] ACPI: EC: Fold acpi_ec_clear_gpe() into its caller

2020-11-23 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Fold acpi_ec_clear_gpe() which is only used in one place into its caller and clean up comments related to that function while at it. No intentional functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/ec.c | 35 +---

Re: [PATCH v2] PM: Add dev_wakeup_path() helper

2020-11-23 Thread Rafael J. Wysocki
On Thu, Nov 19, 2020 at 8:26 AM wrote: > > From: Patrice Chotard > > Add dev_wakeup_path() helper to avoid to spread > dev->power.wakeup_path test in drivers. > > Signed-off-by: Patrice Chotard > Reviewed-by: Ulf Hansson > --- > > Changes from v1: > - Fold the 4 v1 patches into one > - Add

Re: [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE coordination

2020-11-23 Thread Rafael J. Wysocki
>000 0/6 > _kernel_size_le_hi32+0x0x88ffd274 > > - (1) ANY coordination: > totalslack req alloc/free caller > 2560 256 2/0 > _kernel_size_le_hi32+0x0x88fed410 >00

Re: [PATCH v2] powercap: Adjust printing the constraint name with new line

2020-11-23 Thread Rafael J. Wysocki
On Tue, Nov 17, 2020 at 2:48 PM Lukasz Luba wrote: > > The constrain name has limit of size 30, which sometimes might be hit. > When this happens the new line might get lost. Prevent this and set the > max limit for name string length equal 29. This would result is proper > string clamping (when

Re: [PATCH] PM / suspend: fix kernel-doc markup

2020-11-23 Thread Rafael J. Wysocki
arameter or member > 'state' not described in 'suspend_prepare' > > Signed-off-by: Alex Shi > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Pavel Machek > Cc: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > kernel/power/suspend.c | 2 ++

Re: [PATCH 0/2] Remove one more platform_device_add_properties() call

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 4:32 PM Heikki Krogerus wrote: > > Hi, > > I originally introduced these as part of my series where I was > proposing PM ops for software nodes [1], but since that still needs > work, I'm sending these two separately. > > So basically I'm only modifying dwc3-pci.c so it

Re: [PATCH v2] docs: ACPI: enumeration: add PCI hierarchy representation

2020-11-23 Thread Rafael J. Wysocki
On Fri, Nov 20, 2020 at 12:12 PM Flavio Suligoi wrote: > > For "fixed" PCI devices, such as chips directly soldered > on the main board (ethernet, Wi-Fi, serial ports, etc.), > it is possible to find an ACPI enumeration. > > This allows to add useful properties to these devices. > Just for an

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley wrote: > > On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > > wrote: [cut] > > > > Maintainers routinely review 1-line trivial patches, not to mention > > internal API changes, etc. > >

Re: [PATCH 2/2] intel_idle: Fix intel_idle() vs tracing

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 3:35 PM Peter Zijlstra wrote: > > On Mon, Nov 23, 2020 at 02:54:47PM +0100, Rafael J. Wysocki wrote: > > > intel_idle_init_cstates_acpi() needs to be updated too as it doesn't > > pick up the flags automatically. > > Ooh, it has two different sta

Re: [PATCH 2/2] intel_idle: Fix intel_idle() vs tracing

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 2:46 PM Peter Zijlstra wrote: > > On Mon, Nov 23, 2020 at 11:26:39AM +0100, Rafael J. Wysocki wrote: > > On Fri, Nov 20, 2020 at 12:50 PM Peter Zijlstra > > wrote: > > > > > > cpuidle->enter() callbacks should not call into tra

Re: [PATCH v1] docs: ACPI: dsd: enable hyperlink in final references

2020-11-23 Thread Rafael J. Wysocki
On Thu, Nov 19, 2020 at 2:40 PM Sakari Ailus wrote: > > On Thu, Nov 19, 2020 at 01:58:01PM +0100, Flavio Suligoi wrote: > > For inline web links, no special markup are needed. > > > > Signed-off-by: Flavio Suligoi > > Thanks! > > Acked-by: Sakari Ailus Applied as 5.11 material, thanks!

Re: [PATCH 064/141] ACPI: Fix fall-through warnings for Clang

2020-11-23 Thread Rafael J. Wysocki
On Fri, Nov 20, 2020 at 7:34 PM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 >

Re: [PATCH V3 1/2] sched/core: Rename and move schedutil_cpu_util() to core.c

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 11:05 AM Viresh Kumar wrote: > > On 19-11-20, 13:30, Rafael J. Wysocki wrote: > > On Thu, Nov 19, 2020 at 8:38 AM Viresh Kumar > > wrote: > > > > > > There is nothing schedutil specific in schedutil_cpu_util(), move it to > >

Re: [PATCH 2/2] intel_idle: Fix intel_idle() vs tracing

2020-11-23 Thread Rafael J. Wysocki
On Fri, Nov 20, 2020 at 12:50 PM Peter Zijlstra wrote: > > cpuidle->enter() callbacks should not call into tracing because RCU > has already been disabled. Instead of doing the broadcast thing > itself, simply advertise to the cpuidle core that those states stop > the timer. > > Signed-off-by:

[GIT PULL] xfs: fixes for 5.10-rc5

2020-11-21 Thread Darrick J. Wong
itializing per-AG structures - Fix nowait directio writes that partially succeed but return EAGAIN. - Revert last week's rmap comparison patch because it was wrong. ---- Darrick J. Wong (5): xfs: fix the minrecs logic when dealing

Re: [PATCH] fs/stat: set attributes_mask for STATX_ATTR_DAX

2020-11-20 Thread Darrick J. Wong
[Adding fsdevel to cc since this is a filesystems question] On Fri, Nov 20, 2020 at 04:58:09PM -0800, Randy Dunlap wrote: > Hi, > > I don't know this code, but: > > On 11/20/20 4:33 PM, XiaoLi Feng wrote: > > From: Xiaoli Feng > > > > keep attributes and attributes_mask are consistent for > >

[GIT PULL] ACPI fixes for v5.10-rc5

2020-11-19 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-5.10-rc5 with top-most commit de15e20f50b126b3a5a753dd259df775e6a0ea5c Merge branch 'acpi-fan' on top of commit 09162bc32c880a791c6c0668ce0745cf7958f576 Linux 5.10-rc4 to receive

[GIT PULL] Power management fixes for v5.10-rc5

2020-11-19 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-5.10-rc5 with top-most commit 3a8ac4d39651c71d6d2f3376b13d0bad1484249a Merge branch 'pm-cpuidle' on top of commit 09162bc32c880a791c6c0668ce0745cf7958f576 Linux 5.10-rc4 to receive

Re: [PATCH 2/2] PCI: Disable Precision Time Measurement during suspend

2020-11-19 Thread Rafael J. Wysocki
On Thu, Nov 19, 2020 at 6:45 PM David E. Box wrote: > > On Thu, 2020-11-19 at 13:01 +0100, Rafael J. Wysocki wrote: > > On Thu, Nov 19, 2020 at 1:17 AM David E. Box > > wrote: > > > On Intel client platforms that support suspend-to-idle, like Ice > > > Lake,

Re: [PATCH V3 1/2] sched/core: Rename and move schedutil_cpu_util() to core.c

2020-11-19 Thread Rafael J. Wysocki
On Thu, Nov 19, 2020 at 8:38 AM Viresh Kumar wrote: > > There is nothing schedutil specific in schedutil_cpu_util(), move it to > core.c and rename it to sched_cpu_util(), so it can be used from other > parts of the kernel as well. The patch does more than this, though. I would do that in two

Re: [PATCH 1/3] driver core: simply go out if the same device_link is added again

2020-11-19 Thread Rafael J. Wysocki
On Thu, Nov 19, 2020 at 12:18 PM Dong Aisheng wrote: > > It's possible that the same device link may be added by parsing the > function dependecy in DT. e.g. clock/gpio/regulators. > Simply go out for this case. Why? > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki&

Re: [PATCH 2/2] PCI: Disable Precision Time Measurement during suspend

2020-11-19 Thread Rafael J. Wysocki
while suspended. To prevent this, after saving the PTM control register, > disable the feature. The feature will be returned to its previous state > during restore. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=209361 > Reported-by: Len Brown > Suggested-by: Rafael J.

[PATCH] cpufreq: Fix up several kerneldoc comments

2020-11-18 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Fix up the remaining kerneldoc comments that don't adhere to the expected format and clarify some of them a bit. No functional changes. Signed-off-by: Rafael J. Wysocki --- drivers/cpufreq/cpufreq.c | 72 +++--- 1 file changed

Re: high number of dropped packets/rx_missed_errors from 4.17 kernel

2020-11-18 Thread Rafael J. Wysocki
On Tuesday, November 17, 2020 7:31:29 PM CET Rafael J. Wysocki wrote: > On 11/16/2020 8:11 AM, Andrei Popa wrote: > > Hello, > > > > After an update from vmlinuz-4.15.0-106-generic to vmlinuz-5.4.0-37-generic > > we experience, on a number of servers, a very high numb

Re: [PATCH] xfs: return corresponding errcode if xfs_initialize_perag() fail

2020-11-18 Thread Darrick J. Wong
MEM correctly during > initialisation of perag structures") /me suspects you really want Fixes: 9b2471797942 ("xfs: cache unlinked pointers in an rhashtable") but otherwise this is legit. Reviewed-by: Darrick J. Wong --D > Reported-by: Hulk Robot > Signed-off-by: Yu Kuai > --- &

[GIT PULL] nfsd bugfix for 5.10

2020-11-18 Thread J. Bruce Fields
Please pull git://linux-nfs.org/~bfields/linux.git tags/nfsd-5.10-2 Just one quick fix for a tracing oops. --b. Scott Mayhew (1): SUNRPC: Fix oops in the rpc_xdr_buf event class include/trace/events/sunrpc.h | 3 ++- 1

Re: [RFC PATCH V2] acpi/irq: Add stacked IRQ domain support to PCI interrupt link

2020-11-18 Thread Rafael J. Wysocki
On Wed, Nov 18, 2020 at 2:46 PM Ard Biesheuvel wrote: > > On Tue, 17 Nov 2020 at 19:57, Bjorn Helgaas wrote: > > > > Nit: please don't just make up random styles for the subject. Run > > "git log --oneline" on the file and/or the directory and try to follow > > the existing convention. Using

Re: [PATCH v1 0/4] PM: Add dev_wakeup_path() helper

2020-11-18 Thread Rafael J. Wysocki
On Fri, Nov 6, 2020 at 8:34 AM wrote: > > From: Patrice Chotard > > Add dev_wakeup_path() helper to avoid to spread > dev->power.wakeup_path test in drivers. OK > Cc: amelie.delau...@st.com, > erwan_le...@st.com, > fabrice.gasn...@st.com, > alexandre.tor...@st.com, >

Re: [RFC PATCH 2/9] cxl/acpi: add OSC support

2020-11-18 Thread Rafael J. Wysocki
On Tue, Nov 17, 2020 at 12:26 AM Dan Williams wrote: > > On Mon, Nov 16, 2020 at 10:00 AM Jonathan Cameron > wrote: > > > > On Tue, 10 Nov 2020 21:43:49 -0800 > > Ben Widawsky wrote: > > > > > From: Vishal Verma > > > > > > Add support to advertise OS capabilities, and request OS control for

Re: [PATCH v3 3/3] [RFC] CPUFreq: Add support for cpu-perf-dependencies

2020-11-18 Thread Rafael J. Wysocki
On Wed, Nov 18, 2020 at 5:42 AM Viresh Kumar wrote: > > On 17-11-20, 14:06, Rafael J. Wysocki wrote: > > Is this really a cpufreq thing, though, or is it arch stuff? I think > > the latter, because it is not necessary for anything in cpufreq. > > > > Yes

Re: [RFC PATCH 1/9] cxl/acpi: Add an acpi_cxl module for the CXL interconnect

2020-11-18 Thread Rafael J. Wysocki
On Tue, Nov 17, 2020 at 10:45 PM Dan Williams wrote: > > On Tue, Nov 17, 2020 at 6:33 AM Rafael J. Wysocki wrote: > [..] > > > +static struct acpi_driver acpi_cxl_driver = { > > > > First of all, no new acpi_driver instances, pretty please! > > > >

Re: [PATCH v4] Add power/gpu_frequency tracepoint.

2020-11-17 Thread Rafael J. Wysocki
On 11/16/2020 10:05 PM, Steven Rostedt wrote: On Mon, 16 Nov 2020 12:55:29 -0800 Peiyong Lin wrote: Hi there, May I ask whether the merge window has passed? If so is it possible to ask for a review? This is up to the maintainers of power management to accept this. Rafael? I'd say up to

Re: [PATCH v7 0/8] add support for direct I/O with fscrypt using blk-crypto

2020-11-17 Thread Darrick J. Wong
On Tue, Nov 17, 2020 at 12:15:26PM -0500, Theodore Y. Ts'o wrote: > What is the expected use case for Direct I/O using fscrypt? This > isn't a problem which is unique to fscrypt, but one of the really > unfortunate aspects of the DIO interface is the silent fallback to > buffered I/O. We've

<    4   5   6   7   8   9   10   11   12   13   >