Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

lue (with post-increment) or the post-value (with pre-increment)). In that case, my comment below regarding the double-free is also not correct. Setting the freed pointer to NULL is not needed. My bad. We should go with your format: while (i--) -Jack On Thu, 11 Feb 2016 11:29:43 +0200 Jack Morgenst

Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

On Wed, 10 Feb 2016 19:15:20 +0100 Rasmus Villemoes wrote: > On Wed, Feb 10 2016, Yishai Hadas wrote: > > >> @@ -2429,7 +2429,7 @@ err_thread: > >>flush_workqueue(priv->mfunc.master.comm_wq); > >>destroy_workqueue(priv->mfunc.master.comm_wq); > >> err_slaves: > >> - while (--i) { >

Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

On Wed, 10 Feb 2016 19:15:20 +0100 Rasmus Villemoes wrote: > On Wed, Feb 10 2016, Yishai Hadas wrote: > > >> @@ -2429,7 +2429,7 @@ err_thread: > >>flush_workqueue(priv->mfunc.master.comm_wq); > >>

Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

lue (with post-increment) or the post-value (with pre-increment)). In that case, my comment below regarding the double-free is also not correct. Setting the freed pointer to NULL is not needed. My bad. We should go with your format: while (i--) -Jack On Thu, 11 Feb 2016 11:29:43 +0200 Jack Morgenst

Re: [PATCH] infiniband/mlx4: check for mapping error

On Mon, 16 Mar 2015 18:49:59 +0100 (CET) Sebastian Ott wrote: > From: Sebastian Ott > To: linux-r...@vger.kernel.org, linux-kernel@vger.kernel.org > cc: Roland Dreier , Sean Hefty > , Hal Rosenstock , Or > Gerlitz , "David S. Miller" > , Yishai Hadas , Ira Weiny &g

Re: [PATCH] infiniband/mlx4: check for mapping error

...@gmail.com, Or Gerlitz ogerl...@mellanox.com, David S. Miller da...@davemloft.net, Yishai Hadas yish...@mellanox.com, Ira Weiny ira.we...@intel.com, Jack Morgenstein ja...@dev.mellanox.co.il, Matan Barak mat...@mellanox.com, Moni Shoua mo...@mellanox.com, Jiri Kosina jkos...@suse.cz Subject

Re: [PATCH v2 1/2] net/mlx4_core: clean up cq_res_start_move_to()

ACK. OK. -Jack On Tue, 14 Jan 2014 20:45:36 +0100 Paul Bolle wrote: > Building resource_tracker.o triggers a GCC warning: > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In > function 'mlx4_HW2SW_CQ_wrapper': > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3019:16: >

Re: [PATCH v2 2/2] net/mlx4_core: clean up srq_res_start_move_to()

ACK. OK. -Jack On Tue, 14 Jan 2014 20:46:52 +0100 Paul Bolle wrote: > Building resource_tracker.o triggers a GCC warning: > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In > function 'mlx4_HW2SW_SRQ_wrapper': > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3202:17: >

Re: [PATCH v2 2/2] net/mlx4_core: clean up srq_res_start_move_to()

ACK. OK. -Jack On Tue, 14 Jan 2014 20:46:52 +0100 Paul Bolle pebo...@tiscali.nl wrote: Building resource_tracker.o triggers a GCC warning: drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_HW2SW_SRQ_wrapper':

Re: [PATCH v2 1/2] net/mlx4_core: clean up cq_res_start_move_to()

ACK. OK. -Jack On Tue, 14 Jan 2014 20:45:36 +0100 Paul Bolle pebo...@tiscali.nl wrote: Building resource_tracker.o triggers a GCC warning: drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_HW2SW_CQ_wrapper':

Re: [PATCH 1/2] net/mlx4_core: clean up cq_res_start_move_to()

This time, replying to the list as well. -Jack P.S. sorry for the delay, I was swamped. On Tue, 07 Jan 2014 14:01:18 +0100 Paul Bolle wrote: > + } else { > + /* state == RES_CQ_HW */ > + if (r->com.state != RES_CQ_ALLOCATED) if (state != RES_CQ_HW || r->com.state

Re: [PATCH 2/2] net/mlx4_core: clean up srq_res_start_move_to()

On Tue, 07 Jan 2014 14:02:14 +0100 Paul Bolle wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c > b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index > a41f01e..8ace450 100644 --- > a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ >

Re: [PATCH 2/2] net/mlx4_core: clean up srq_res_start_move_to()

On Tue, 07 Jan 2014 14:02:14 +0100 Paul Bolle pebo...@tiscali.nl wrote: diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index a41f01e..8ace450 100644 --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++

Re: [PATCH 1/2] net/mlx4_core: clean up cq_res_start_move_to()

This time, replying to the list as well. -Jack P.S. sorry for the delay, I was swamped. On Tue, 07 Jan 2014 14:01:18 +0100 Paul Bolle pebo...@tiscali.nl wrote: + } else { + /* state == RES_CQ_HW */ + if (r-com.state != RES_CQ_ALLOCATED) if (state != RES_CQ_HW ||

Re: [PATCH 5/25] IB/mlx4: fix error return code

On Sun, 29 Dec 2013 23:47:20 +0100 Julia Lawall wrote: > diff --git a/drivers/infiniband/hw/mlx4/sysfs.c > b/drivers/infiniband/hw/mlx4/sysfs.c index 97516eb..db2ea31 100644 > --- a/drivers/infiniband/hw/mlx4/sysfs.c > +++ b/drivers/infiniband/hw/mlx4/sysfs.c > @@ -582,8 +582,10 @@ static int

Re: [PATCH 5/25] IB/mlx4: fix error return code

On Sun, 29 Dec 2013 23:47:20 +0100 Julia Lawall julia.law...@lip6.fr wrote: diff --git a/drivers/infiniband/hw/mlx4/sysfs.c b/drivers/infiniband/hw/mlx4/sysfs.c index 97516eb..db2ea31 100644 --- a/drivers/infiniband/hw/mlx4/sysfs.c +++ b/drivers/infiniband/hw/mlx4/sysfs.c @@ -582,8 +582,10

Re: [PATCH RFC 51/77] mthca: Update MSI/MSI-X interrupts enablement code

On Wed, 2 Oct 2013 12:49:07 +0200 Alexander Gordeev wrote: > Subject: [PATCH RFC 51/77] mthca: Update MSI/MSI-X interrupts > enablement code Date: Wed, 2 Oct 2013 12:49:07 +0200 > Sender: linux-rdma-ow...@vger.kernel.org > X-Mailer: git-send-email 1.7.7.6 > > As result of recent re-design of

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gordeev

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: UPDATING THIS REPLY. Your change log confused me. The change below is not from a "recent re-design", it is required due to an earlier patch in this patch set. >From the log, I assumed that the change you are talking about is already

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: NACK. This change does not do anything logically as far as I can tell. pci_enable_msix in the current upstream kernel itself calls pci_msix_table_size. The current code yields the same results as the code suggested below. (i.e., the

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev agord...@redhat.com wrote: NACK. This change does not do anything logically as far as I can tell. pci_enable_msix in the current upstream kernel itself calls pci_msix_table_size. The current code yields the same results as the code suggested

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev agord...@redhat.com wrote: UPDATING THIS REPLY. Your change log confused me. The change below is not from a recent re-design, it is required due to an earlier patch in this patch set. From the log, I assumed that the change you are talking

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev agord...@redhat.com wrote: As result of recent re-design of the MSI/MSI-X interrupts enabling pattern this driver has to be updated to use the new technique to obtain a optimal number of MSI/MSI-X interrupts required. Signed-off-by:

Re: [PATCH RFC 51/77] mthca: Update MSI/MSI-X interrupts enablement code

On Wed, 2 Oct 2013 12:49:07 +0200 Alexander Gordeev agord...@redhat.com wrote: Subject: [PATCH RFC 51/77] mthca: Update MSI/MSI-X interrupts enablement code Date: Wed, 2 Oct 2013 12:49:07 +0200 Sender: linux-rdma-ow...@vger.kernel.org X-Mailer: git-send-email 1.7.7.6 As result of recent

Re: [PATCH v2] IB/mlx4: silence GCC warning

On Monday 25 February 2013 19:23, Roland Dreier wrote: > On Mon, Feb 25, 2013 at 8:54 AM, Roland Dreier wrote: > > I'm finally noticing that this is in the build_mlx_header() function, > > which is pretty much a slow path. Certainly another compare isn't > > going to change performance given all

Re: [PATCH v2] IB/mlx4: silence GCC warning

On Monday 25 February 2013 19:23, Roland Dreier wrote: On Mon, Feb 25, 2013 at 8:54 AM, Roland Dreier rol...@kernel.org wrote: I'm finally noticing that this is in the build_mlx_header() function, which is pretty much a slow path. Certainly another compare isn't going to change performance

Re: [PATCH v2] IB/mlx4: silence GCC warning

On Thursday 21 February 2013 11:02, Paul Bolle wrote: > diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c > index 19e0637..512fde3 100644 > --- a/drivers/infiniband/hw/mlx4/qp.c > +++ b/drivers/infiniband/hw/mlx4/qp.c > @@ -1778,8 +1778,8 @@ static int

Re: [PATCH v2] IB/mlx4: silence GCC warning

On Thursday 21 February 2013 11:02, Paul Bolle wrote: diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c index 19e0637..512fde3 100644 --- a/drivers/infiniband/hw/mlx4/qp.c +++ b/drivers/infiniband/hw/mlx4/qp.c @@ -1778,8 +1778,8 @@ static int

Re: [PATCH] IB/lmx4: silence GCC warning

You could use: u16 uninitialized_var(vlan); instead. Although this in the special QP data flow, I still prefer to avoid adding extra code (even setting initial values at procedure entry). The line above will also do the job. "uninitialized_var" is used elsewhere in the driver. See, for

Re: [PATCH] IB/lmx4: silence GCC warning

You could use: u16 uninitialized_var(vlan); instead. Although this in the special QP data flow, I still prefer to avoid adding extra code (even setting initial values at procedure entry). The line above will also do the job. uninitialized_var is used elsewhere in the driver. See, for

Re: linux-next: build failure after merge of the akpm tree

Hi Roland, I am on vacation until next Tuesday -- I'll look at this then. -Jack On Monday 24 September 2012 21:36, Roland Dreier wrote: > On Mon, Sep 24, 2012 at 7:02 AM, Stephen Rothwell > wrote: > > After merging the akpm tree, today's linux-next build (powerpc > > ppc64_defconfig) failed

Re: linux-next: build failure after merge of the akpm tree

Hi Roland, I am on vacation until next Tuesday -- I'll look at this then. -Jack On Monday 24 September 2012 21:36, Roland Dreier wrote: On Mon, Sep 24, 2012 at 7:02 AM, Stephen Rothwell s...@canb.auug.org.au wrote: After merging the akpm tree, today's linux-next build (powerpc

Re: linux-next: manual merge of the net-next tree with the infiniband tree

On Thursday 12 July 2012 05:13, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in > include/linux/mlx4/device.h between commit 396f2feb05d7 ("mlx4_core: > Implement mechanism for reserved Q_Keys") from the infiniband tree and > commit

Re: linux-next: manual merge of the net-next tree with the infiniband tree

On Thursday 12 July 2012 05:09, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in > drivers/net/ethernet/mellanox/mlx4/main.c between commit 6634961c14d3 > ("mlx4: Put physical GID and P_Key table sizes in mlx4_phys_caps struct > and

Re: linux-next: manual merge of the net-next tree with the infiniband tree

On Thursday 12 July 2012 05:09, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/ethernet/mellanox/mlx4/main.c between commit 6634961c14d3 (mlx4: Put physical GID and P_Key table sizes in mlx4_phys_caps struct and paravirtualize

Re: linux-next: manual merge of the net-next tree with the infiniband tree

On Thursday 12 July 2012 05:13, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in include/linux/mlx4/device.h between commit 396f2feb05d7 (mlx4_core: Implement mechanism for reserved Q_Keys) from the infiniband tree and commit 0ff1fb654bec

Re: [PATCH] mlx4: fix build break

On Tuesday 12 February 2008 00:18, Roland Dreier wrote: > Thanks, applied. > > Jack, I thought you guys tested the build on powerpc. How did this > sneak through? > It did not sneak through, because the problem does not exist in the OFED git. The following commit was performed to

Re: [PATCH] mlx4: fix build break

On Tuesday 12 February 2008 00:18, Roland Dreier wrote: Thanks, applied. Jack, I thought you guys tested the build on powerpc. How did this sneak through? It did not sneak through, because the problem does not exist in the OFED git. The following commit was performed to

Re: [ofa-general] [GIT PULL] please pull infiniband.git

On Tuesday 27 November 2007 08:21, Roland Dreier wrote: > Linus, please pull from > > master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git > for-linus > > > Jack Morgenstein (1): > mlx4_core: Fix state check in mlx4_qp_modify() > MUST

Re: [ofa-general] [GIT PULL] please pull infiniband.git

On Tuesday 27 November 2007 08:21, Roland Dreier wrote: Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus Jack Morgenstein (1): mlx4_core: Fix state check in mlx4_qp_modify() MUST also enter the patch I send yesterday

Re: [ofa-general] Updated InfiniBand/RDMA merge plans for 2.6.24

ft patch set to the OpenFabrics list on September 18: [ofa-general] [PATCH 0 of 5] XRC implementation patches (libibverbs, libmlx4, core, mlx4) Jack Morgenstein [ofa-general] [PATCH 1 of 5] libibverbs: XRC implementation Jack Morgenstein [ofa-general] [PATCH 2 of 5] libmlx4: XRC implement

Re: [ofa-general] Updated InfiniBand/RDMA merge plans for 2.6.24

to the OpenFabrics list on September 18: [ofa-general] [PATCH 0 of 5] XRC implementation patches (libibverbs, libmlx4, core, mlx4) Jack Morgenstein [ofa-general] [PATCH 1 of 5] libibverbs: XRC implementation Jack Morgenstein [ofa-general] [PATCH 2 of 5] libmlx4: XRC implementation Jack

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

On Thursday 13 September 2007 20:57, Roland Dreier wrote: > HW specific: > >  - I already merged patches to enable MSI-X by default for mthca and >    mlx4.  I hope there aren't too many systems that get hosed if a >    MSI-X interrupt is generated. > >  - Jack and Michael's mlx4 FMR support.  

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

On Thursday 13 September 2007 20:57, Roland Dreier wrote: HW specific:  - I already merged patches to enable MSI-X by default for mthca and    mlx4.  I hope there aren't too many systems that get hosed if a    MSI-X interrupt is generated.  - Jack and Michael's mlx4 FMR support.  Will