Re: [PATCH 0/3] staging/skein: more cleanup

2014-05-22 Thread Jake Edge
On Wed, 21 May 2014 01:52:17 +0400 Anton Saraev wrote: > On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote: > > On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote: > > > > but some kind of tests are needed to ensure nothing breaks before > > digging into tha

Re: [PATCH 0/3] staging/skein: more cleanup

2014-05-22 Thread Jake Edge
On Wed, 21 May 2014 01:52:17 +0400 Anton Saraev wrote: On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote: On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote: but some kind of tests are needed to ensure nothing breaks before digging into that ... I have some test: slightly

Re: [PATCH 0/3] staging/skein: more cleanup

2014-05-20 Thread Jake Edge
alt with at this point. That rats nest of ifdefs in skein_block.c needs attention, but some kind of tests are needed to ensure nothing breaks before digging into that ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line "unsubscribe linu

[PATCH 3/3] staging/skein: variable/member name cleanup

2014-05-20 Thread Jake Edge
Rename a few more variables and structure member names to lower case. Signed-off-by: Jake Edge --- against staging-next branch of staging tree drivers/staging/skein/skein.c | 148 +- drivers/staging/skein/skein.h | 34 drivers/staging

[PATCH 2/3] staging/skein: comment typos

2014-05-20 Thread Jake Edge
fix some comment typos Signed-off-by: Jake Edge --- against staging-next branch of staging tree drivers/staging/skein/threefish_api.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/skein/threefish_api.h b/drivers/staging/skein

[PATCH 0/3] staging/skein: more cleanup

2014-05-20 Thread Jake Edge
in one file, made sense. Jake Edge (3): move all threefish block functions to one file, remove unneeded include fix some comment typos Rename a few more variables and structure member names to lower case. drivers/staging/skein/Makefile |4 +- drivers/staging/skein

[PATCH 0/3] staging/skein: more cleanup

2014-05-20 Thread Jake Edge
in one file, made sense. Jake Edge (3): move all threefish block functions to one file, remove unneeded include fix some comment typos Rename a few more variables and structure member names to lower case. drivers/staging/skein/Makefile |4 +- drivers/staging/skein

[PATCH 2/3] staging/skein: comment typos

2014-05-20 Thread Jake Edge
fix some comment typos Signed-off-by: Jake Edge j...@lwn.net --- against staging-next branch of staging tree drivers/staging/skein/threefish_api.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/skein/threefish_api.h b/drivers/staging

[PATCH 3/3] staging/skein: variable/member name cleanup

2014-05-20 Thread Jake Edge
Rename a few more variables and structure member names to lower case. Signed-off-by: Jake Edge j...@lwn.net --- against staging-next branch of staging tree drivers/staging/skein/skein.c | 148 +- drivers/staging/skein/skein.h | 34 drivers

Re: [PATCH 0/3] staging/skein: more cleanup

2014-05-20 Thread Jake Edge
with at this point. That rats nest of ifdefs in skein_block.c needs attention, but some kind of tests are needed to ensure nothing breaks before digging into that ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH v3 1/1] staging/skein: rename files and clean up directory structure

2014-05-19 Thread Jake Edge
Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). Signed-off-by: Jake Edge --- v3: against staging-next branch of staging tree

Re: [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars

2014-05-19 Thread Jake Edge
; > Is that ok with you? Sure, that seems fine ... I only had fairly minor quibbles, the vast majority of it is good stuff ... Not sure it's useful (or even the right way to go about it), but, if it is, Greg (or Jason or whoever) can add my: Reviewed-by: Jake Edge to the patch set ... j

Re: [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars

2014-05-19 Thread Jake Edge
Xptr[3] = > + const u64 *X_ptr[4]; /* use for debugging (help cc put Xn in regs) */ > + > + X_ptr[0] = X_ptr[1] = X_ptr[2] = X_ptr[3] = bunch of Xs in through here too ... is X special somehow? maybe so because it is used in all that loop-unrolling gunk? jake -- Ja

Re: [PATCH v2 06/06] staging: crypto: skein: rename files

2014-05-19 Thread Jake Edge
#include > -#include > +#include incidentally, none of the threefish_*_block.c files actually needs linux/string.h ... there may be other files where that's true too, it seems to have just gotten added everywhere ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from thi

Re: [PATCH v2 06/06] staging: crypto: skein: rename files

2014-05-19 Thread Jake Edge
deleting it in this patch or a separate one, it seems to me. jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

[PATCH v3 1/1] staging/skein: rename files and clean up directory structure

2014-05-19 Thread Jake Edge
Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). Signed-off-by: Jake Edge j...@lwn.net --- v3: against staging-next branch

Re: [PATCH v2 06/06] staging: crypto: skein: rename files

2014-05-19 Thread Jake Edge
it in this patch or a separate one, it seems to me. jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 06/06] staging: crypto: skein: rename files

2014-05-19 Thread Jake Edge
+#include threefish_api.h incidentally, none of the threefish_*_block.c files actually needs linux/string.h ... there may be other files where that's true too, it seems to have just gotten added everywhere ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from

Re: [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars

2014-05-19 Thread Jake Edge
-- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars

2014-05-19 Thread Jake Edge
with you? Sure, that seems fine ... I only had fairly minor quibbles, the vast majority of it is good stuff ... Not sure it's useful (or even the right way to go about it), but, if it is, Greg (or Jason or whoever) can add my: Reviewed-by: Jake Edge j...@lwn.net to the patch set ... jake -- Jake

Re: [PATCH v2 1/1] staging/skein: rename files and clean up directory structure

2014-05-18 Thread Jake Edge
her stuff (function names, etc.) on hold and see how far Anton got ... fwiw, I did look at the lists to see if someone had already been working on this stuff, which is why it is such a good idea make sure the patches get posted publicly ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To un

[PATCH v2 1/1] staging/skein: rename files and clean up directory structure

2014-05-18 Thread Jake Edge
Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). Signed-off-by: Jake Edge --- Against next-20140516 v2: use git format-patch

Re: [PATCH 1/1] staging/skein: rename files and clean up directory structure

2014-05-18 Thread Jake Edge
On Sun, 18 May 2014 11:42:53 -0700 Joe Perches wrote: > On Sun, 2014-05-18 at 12:36 -0600, Jake Edge wrote: > > Clean up file names and locations. Get rid of include/ directory > > and move those up to the top-level. Rename files to get rid of > > upper case. Re

Re: [PATCH 1/1] staging/skein: rename files and clean up directory structure

2014-05-18 Thread Jake Edge
On Sun, 18 May 2014 11:42:53 -0700 Joe Perches wrote: On Sun, 2014-05-18 at 12:36 -0600, Jake Edge wrote: Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused

[PATCH v2 1/1] staging/skein: rename files and clean up directory structure

2014-05-18 Thread Jake Edge
Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). Signed-off-by: Jake Edge j...@lwn.net --- Against next-20140516 v2: use git

Re: [PATCH v2 1/1] staging/skein: rename files and clean up directory structure

2014-05-18 Thread Jake Edge
names, etc.) on hold and see how far Anton got ... fwiw, I did look at the lists to see if someone had already been working on this stuff, which is why it is such a good idea make sure the patches get posted publicly ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe

[PATCH] staging/rtl8187se fix sparse complaints

2014-04-13 Thread Jake Edge
it be static? drivers/staging/rtl8187se//ieee80211/ieee80211_crypt_wep.c:269:6: warning: symbol 'ieee80211_crypto_wep_exit' was not declared. Should it be static? by adding an include file into source files and moving some declarations around into the proper header files. Signed-off-by: Jake Edge

[PATCH] staging/rtl8187se fix sparse complaints

2014-04-13 Thread Jake Edge
it be static? drivers/staging/rtl8187se//ieee80211/ieee80211_crypt_wep.c:269:6: warning: symbol 'ieee80211_crypto_wep_exit' was not declared. Should it be static? by adding an include file into source files and moving some declarations around into the proper header files. Signed-off-by: Jake Edge j

[PATCHv3 1/1] staging/bcm fix hostmibs.c checkpatch problems

2014-04-04 Thread Jake Edge
Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Signed-off-by: Jake Edge --- Against next-20140403 v3: fixes suggested by Dan Carpenter v2: fixes suggested by Joe Perches There are still some > 80 length lines that require more substantive rework to fix. drivers/staging/

[PATCHv3 1/1] staging/bcm fix hostmibs.c checkpatch problems

2014-04-04 Thread Jake Edge
Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Signed-off-by: Jake Edge j...@edge2.net --- Against next-20140403 v3: fixes suggested by Dan Carpenter v2: fixes suggested by Joe Perches There are still some 80 length lines that require more substantive rework to fix. drivers

Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

2014-03-28 Thread Jake Edge
On Sun, 23 Mar 2014 10:45:09 -0700 Joe Perches wrote: > On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote: > > Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c > > Making code checkpatch clean shouldn't be the primary goal here. Perhaps not, but it was *my* goal :)

[PATCH v2 1/1] staging/bcm: fix hostmibs.c checkpatch problems

2014-03-28 Thread Jake Edge
From: Jake Edge Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Against next-20140328 tree Signed-off-by: Jake Edge --- There were two > 80 lines that I couldn't find a sensible way to split up, otherwise it is checkpatch clean v2: fixes suggested by Joe Perches diff --

[PATCH v2 1/1] staging/bcm: fix hostmibs.c checkpatch problems

2014-03-28 Thread Jake Edge
From: Jake Edge j...@edge2.net Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Against next-20140328 tree Signed-off-by: Jake Edge j...@edge2.net --- There were two 80 lines that I couldn't find a sensible way to split up, otherwise it is checkpatch clean v2: fixes suggested by Joe

Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

2014-03-28 Thread Jake Edge
On Sun, 23 Mar 2014 10:45:09 -0700 Joe Perches wrote: On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote: Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Making code checkpatch clean shouldn't be the primary goal here. Perhaps not, but it was *my* goal :) Removing uses

[PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

2014-03-22 Thread Jake Edge
From: Jake Edge Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Against next-20140321 tree Signed-off-by: Jake Edge --- There were two > 80 lines that I couldn't find a sensible way to split up, otherwise it is checkpatch clean diff --git a/drivers/staging/bcm/hostmibs.

[PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

2014-03-22 Thread Jake Edge
From: Jake Edge j...@edge2.net Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Against next-20140321 tree Signed-off-by: Jake Edge j...@edge2.net --- There were two 80 lines that I couldn't find a sensible way to split up, otherwise it is checkpatch clean diff --git a/drivers

Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-06 Thread Jake Edge
On Mon, 06 May 2013 17:24:19 +0200 Johannes Berg wrote: > On Mon, 2013-05-06 at 09:21 -0600, Jake Edge wrote: > > > > Thanks for the report. Is the AP on a passive channel by any > > > chance (5 GHz, or channels 12/13)? > > > > No, from what I can see on my r

Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-06 Thread Jake Edge
or the other SSID) ... but Stanislaw seems to have pinpointed the issue. thanks, jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-06 Thread Jake Edge
es's commit above, fwiw, but just turning off that flag in 3.9 as your patch does fixes it. seems like that needs to head to Linus and the stable folks ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-06 Thread Jake Edge
as your patch does fixes it. seems like that needs to head to Linus and the stable folks ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-06 Thread Jake Edge
. Is the AP on a passive channel by any chance (5 GHz, or channels 12/13)? No, from what I can see on my router, it is using channel 36 (5.180 GHz) for the SSID in question (and channel 11 2.462 GHz for the other SSID) ... but Stanislaw seems to have pinpointed the issue. thanks, jake -- Jake

Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-06 Thread Jake Edge
On Mon, 06 May 2013 17:24:19 +0200 Johannes Berg wrote: On Mon, 2013-05-06 at 09:21 -0600, Jake Edge wrote: Thanks for the report. Is the AP on a passive channel by any chance (5 GHz, or channels 12/13)? No, from what I can see on my router, it is using channel 36 (5.180 GHz

Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-05 Thread Jake Edge
the second bisection (3.8-3.9) ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-05 Thread Jake Edge
and led to the second bisection (3.8-3.9) ... jake -- Jake Edge - LWN - j...@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: still in 3.9-rc6 - fan speed at 100% after suspend/resume regression

2013-04-13 Thread Jake Edge
il Matthias opens a new one? > can you please test thermal -thermal branch at > git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git I just tried it, no difference in behavior (fan on full, temp6 == 100°C) ... I took all the defaults when I did a 'make oldconfig', some of which looked therm

Re: still in 3.9-rc6 - fan speed at 100% after suspend/resume regression

2013-04-13 Thread Jake Edge
/git/rzhang/linux.git I just tried it, no difference in behavior (fan on full, temp6 == 100°C) ... I took all the defaults when I did a 'make oldconfig', some of which looked thermal-related ... was I supposed to set them differently? thanks, jake -- Jake Edge - LWN - j...@lwn.net - http

Re: sleep/fan problem bisected to 73201dbec64aebf6b0dca855b523f437972dc7bb

2013-04-12 Thread Jake Edge
On Fri, 12 Apr 2013 12:08:31 -0600 Jake Edge wrote: > I have been having a problem on my laptop (HP Compaq 2510p) over the > last two months with >= 3.7 kernels. After the first resume, it turns > on the fan and leaves it running at top speed no matter what the > system is do

sleep/fan problem bisected to 73201dbec64aebf6b0dca855b523f437972dc7bb

2013-04-12 Thread Jake Edge
just in Fedora or my kernels >=3.7, not in the bisect, cuz those don't come back from the sleep) ... in the "good" case, it normally sits around 30, but goes as high as 50 (and sometimes reports 0 for a try or two -- frozen motherboard! :) ... thoughts on this? Other info you need or

sleep/fan problem bisected to 73201dbec64aebf6b0dca855b523f437972dc7bb

2013-04-12 Thread Jake Edge
don't come back from the sleep) ... in the good case, it normally sits around 30, but goes as high as 50 (and sometimes reports 0 for a try or two -- frozen motherboard! :) ... thoughts on this? Other info you need or things I should be trying? thanks, jake -- Jake Edge - LWN - j...@lwn.net - http

Re: sleep/fan problem bisected to 73201dbec64aebf6b0dca855b523f437972dc7bb

2013-04-12 Thread Jake Edge
On Fri, 12 Apr 2013 12:08:31 -0600 Jake Edge wrote: I have been having a problem on my laptop (HP Compaq 2510p) over the last two months with = 3.7 kernels. After the first resume, it turns on the fan and leaves it running at top speed no matter what the system is doing. I finally bisected