Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-03-03 Thread Jakub Kicinski
On Tue, 02 Mar 2021 08:04:20 +0100 Martin Schiller wrote: > On 2021-03-01 09:56, Xie He wrote: > > On Sun, Feb 28, 2021 at 10:56 PM Martin Schiller wrote: > >> I mean the change from only one hdlc interface to both hdlc and > >> hdlc_x25. > >> > >> I can't estimate how many users are out there

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-03-03 Thread Jakub Kicinski
On Tue, 2 Mar 2021 12:55:47 +0100 Dmitry Vyukov wrote: > On Tue, Mar 2, 2021 at 10:06 AM Hillf Danton wrote: > > On Mar 2, 2021 at 16:40 Dmitry Vyukov wrote: > > >I hoped this would get at least into 5.12. syzbot can't start testing > > >arm32 because of this. FWIW the submission never got

Re: [PATCH 01/11] pragma once: delete include/linux/atm_suni.h

2021-02-28 Thread Jakub Kicinski
On Sun, 28 Feb 2021 19:58:17 +0300 Alexey Dobriyan wrote: > From c17ac63e1334c742686cd411736699c1d34d45a7 Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan > Date: Wed, 10 Feb 2021 21:07:45 +0300 > Subject: [PATCH 01/11] pragma once: delete include/linux/atm_suni.h > > This file has been empty

Re: [PATCH v3] net/core/skbuff: fix passing wrong size to __alloc_skb

2021-02-28 Thread Jakub Kicinski
On Sun, 28 Feb 2021 18:14:46 + Alexander Lobakin wrote: > > [1] WARNING in __alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:5014 > > Call Trace: > > __alloc_pages include/linux/gfp.h:511 [inline] > > __alloc_pages_node include/linux/gfp.h:524 [inline] > > alloc_pages_node

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 15:44:42 +0800 Huazhong Tan wrote: > From: Guangbin Huang > > If phy uses generic driver and autoneg is on, enter command > "ethtool -s eth0 speed 50" will not change phy speed actually, but > command "ethtool eth0" shows speed is 50Mb/s because phydev->speed > has been set

Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 07:23:31 -0800 Richard Cochran wrote: > On Thu, Feb 25, 2021 at 10:15:16PM +0100, Heiko Thiery wrote: > > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > > This is only the case when the interface is down. This can be reproduced > > by reading with

Re: [PATCH] net: phy: make mdio_bus_phy_suspend/resume as __maybe_unused

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 23:53:20 +0100 Andrew Lunn wrote: > On Thu, Feb 25, 2021 at 03:57:27PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When CONFIG_PM_SLEEP is disabled, the compiler warns about unused > > functions: > > > > drivers/net/phy/phy_device.c:273:12: error: unused

Re: [PATCH 1/3] net: mscc: ocelot: select NET_DEVLINK

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 15:38:31 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > Without this option, the driver fails to link: > > ld.lld: error: undefined symbol: devlink_sb_register > [...] > > Fixes: f59fd9cab730 ("net: mscc: ocelot: configure watermarks using > devlink-sb") >

Re: [PATCH] mt7601u: fix always true expression

2021-02-25 Thread Jakub Kicinski
) > Fixes: c869f77d6abb ("add mt7601u driver") > Signed-off-by: Colin Ian King Acked-by: Jakub Kicinski Thanks for the fix!

[GIT PULL] Networking for 5.12-rc1

2021-02-25 Thread Jakub Kicinski
the access method for the dpaa_napi_portal Signed-off-by: Jakub Kicinski Antonio Quartulli (1): wireguard: avoid double unlikely() notation when using IS_ERR() Brett Creeley (2): ice: Set trusted VF as default VSI when

Re: [PATCH net] net: hsr: add support for EntryForgetTime

2021-02-25 Thread Jakub Kicinski
On Wed, 24 Feb 2021 14:55:17 +0100 Andrew Lunn wrote: > On Wed, Feb 24, 2021 at 10:46:49AM +0100, Marco Wenzel wrote: > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a > > node does not send any frame within this time, the sequence number check > > for can be ignored.

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-24 Thread Jakub Kicinski
On Thu, 25 Feb 2021 08:21:01 +0800 Coiby Xu wrote: > On Wed, Feb 24, 2021 at 08:48:41AM -0800, Jakub Kicinski wrote: > >On Wed, 24 Feb 2021 19:41:41 +0800 Coiby Xu wrote: > >> I'm not sure if I understand you correctly. Do you mean we shouldn't > >> disable i40iw for

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 23:38:03 +0800 Kefeng Wang wrote: > HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move > 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead > of HAVE_JUMP_LABLE. > > Fixes: 971502d77faa ("bridge: netfilter: unroll NF_HOOK helper in bridge >

Re: [PATCH] ipv6: Honor route mtu if it is within limit of dev mtu

2021-02-24 Thread Jakub Kicinski
On Mon, 22 Feb 2021 22:02:35 +0530 Kaustubh Pandey wrote: > When netdevice MTU is increased via sysfs, NETDEV_CHANGEMTU is raised. > > addrconf_notify -> rt6_mtu_change -> rt6_mtu_change_route -> > fib6_nh_mtu_change > > As part of handling NETDEV_CHANGEMTU notification we land up on a >

Re: [PATCH net-next v3 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 01:32:50 +0530 Sharath Chandra Vurukala wrote: > +/* MAP CSUM headers */ > +struct rmnet_map_v5_csum_header { > +#if defined(__LITTLE_ENDIAN_BITFIELD) > + u8 next_hdr:1; > + u8 header_type:7; > + u8 hw_reserved:7; > + u8 csum_valid_required:1; > +#elif

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 19:41:41 +0800 Coiby Xu wrote: > On Tue, Feb 23, 2021 at 12:22:07PM -0800, Jakub Kicinski wrote: > >On Mon, 22 Feb 2021 15:07:01 +0800 Coiby Xu wrote: > >> i40iw consumes huge amounts of memory. For example, on a x86_64 machine, > >> i40iw consumed

Re: UBSAN: shift-out-of-bounds in nl802154_new_interface

2021-02-23 Thread Jakub Kicinski
On Tue, 23 Feb 2021 19:26:26 -0500 Alexander Aring wrote: > Hi, > > On Tue, 23 Feb 2021 at 18:48, Jakub Kicinski wrote: > > > > Alex, there seems to be a few more syzbot reports for nl802154 beyond > > what you posted fixes for. Are you looking at these? >

Re: [PATCHSET] making unix_bind() undo mknod on failure

2021-02-23 Thread Jakub Kicinski
and #8/8 is a minor followup cleanup. Individual patches in followups. Dave is out this week, but this looks good to me. You said "please review" - I'm assuming you'll send these to Linus yourself, so: Acked-by: Jakub Kicinski

Re: UBSAN: shift-out-of-bounds in nl802154_new_interface

2021-02-23 Thread Jakub Kicinski
Alex, there seems to be a few more syzbot reports for nl802154 beyond what you posted fixes for. Are you looking at these? On Mon, 22 Feb 2021 00:05:29 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:3af409ca net: enetc: fix destroyed phylink

Re: [PATCH net-next v2] net: dsa: mt7530: support MDB operations

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 18:07:17 +0800 DENG Qingfang wrote: > Support port MDB add to/delete from MT7530 ARL. > > As the hardware can manage multicast forwarding itself, trapping > multicast traffic to the CPU is no longer required. > > Signed-off-by: DENG Qingfang # Form letter - net-next is

Re: [PATCH] ibmveth: Switch to using the new API kobj_to_dev()

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 16:02:21 +0800 Yang Li wrote: > fixed the following coccicheck: > ./drivers/net/ethernet/ibm/ibmveth.c:1805:51-52: WARNING opportunity for > kobj_to_dev() > > Reported-by: Abaci Robot > Signed-off-by: Yang Li # Form letter - net-next is closed We have already sent the

Re: [PATCH net] atl1c: switch to napi_gro_receive

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 09:40:45 +0800 Sieng Piaw Liew wrote: > Changing to napi_gro_receive() improves efficiency significantly. Tested > on Intel Core2-based motherboards and iperf3. > > Signed-off-by: Sieng Piaw Liew net-next is currently closed (see the note below). Would you mind resending

Re: [PATCH v4 net-next] net: socket: use BIT() for MSG_*

2021-02-23 Thread Jakub Kicinski
On Wed, 17 Feb 2021 14:54:27 +0800 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The bit mask for MSG_* seems a little confused here. Replace it > with BIT() to make it clear to understand. > > Signed-off-by: Menglong Dong # Form letter - net-next is closed We have already sent

Re: [PATCH net v2 0/2] net: dsa: Learning fixes for b53/bcm_sf2

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 14:30:08 -0800 Florian Fainelli wrote: > This patch series contains a couple of fixes for the b53/bcm_sf2 drivers > with respect to configuring learning. > > The first patch is wiring-up the necessary dsa_switch_ops operations in > order to support the offloading of bridge

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 15:07:01 +0800 Coiby Xu wrote: > i40iw consumes huge amounts of memory. For example, on a x86_64 machine, > i40iw consumed 1.5GB for Intel Corporation Ethernet Connection X722 for > for 1GbE while "craskernel=auto" only reserved 160M. With the module > parameter

Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

2021-02-23 Thread Jakub Kicinski
On Sun, 21 Feb 2021 21:05:50 -0800 Florian Fainelli wrote: > On 2/21/2021 17:35, Sieng Piaw Liew wrote: > > In ndo_stop functions, netdev_completed_queue() is called during forced > > tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if > > there is any tx skb left. > > > >

Re: [PATCH v2] netdevsim: fib: remove unneeded semicolon

2021-02-23 Thread Jakub Kicinski
On Tue, 23 Feb 2021 10:28:46 +0800 Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong # Form letter - net-next is closed We have already sent the networking

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

2021-02-22 Thread Jakub Kicinski
On Sat, 20 Feb 2021 07:56:55 +0100 Heiko Thiery wrote: > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > This is only the case when the interface is down. This can be reproduced > by reading with 'phc_ctrl eth0 get'. > > Like described in the change in

Re: [PATCH net-next 2/2] net: ipv6: don't generate link local address on PUREIP device

2021-02-22 Thread Jakub Kicinski
On Tue, 23 Feb 2021 10:03:11 +0800 rocco.yue wrote: > On Thu, 2021-02-04 at 14:06 +0800, rocco.yue wrote: > > On Fri, 2021-01-29 at 19:07 -0800, Jakub Kicinski wrote: > > > On Thu, 28 Jan 2021 13:58:09 +0800 Rocco Yue wrote: > [...] > > > > > &g

Re: [PATCH net v3] net: introduce CAN specific pointer in the struct net_device

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 16:02:51 +0100 Oleksij Rempel wrote: > Since 20dd3850bcf8 ("can: Speed up CAN frame receiption by using > ml_priv") the CAN framework uses per device specific data in the AF_CAN > protocol. For this purpose the struct net_device->ml_priv is used. Later > the ml_priv usage in

Re: [PATCH 03/20] devlink: Manual replacement of the deprecated strlcpy() with return values

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 16:12:14 +0100 Romain Perier wrote: > diff --git a/net/core/devlink.c b/net/core/devlink.c > index 737b61c2976e..7eb445460c92 100644 > --- a/net/core/devlink.c > +++ b/net/core/devlink.c > @@ -9461,10 +9461,10 @@ EXPORT_SYMBOL_GPL(devlink_port_param_value_changed); > void

Re: [PATCH] net: tap: remove redundant assignments

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 22:57:48 +0800 Tang Bin wrote: > In the function tap_get_user, the assignment of 'err' at both places > is redundant, so remove one. > > Signed-off-by: Tang Bin > --- > drivers/net/tap.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [PATCH] ethernet/microchip:remove unneeded variable: "ret"

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 10:58:18 +0800 dingsen...@163.com wrote: > From: dingsenjie > > remove unneeded variable: "ret". > > Signed-off-by: dingsenjie # Form letter - net-next is closed We have already sent the networking pull request for 5.12 and therefore net-next is closed for new drivers,

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote: > >> This will not be sufficient for my usecase: To stay compatible with older > >> versions of fastd, I can't set the T flag in the first packet of the > >> handshake, as it won't be known whether the peer has a new enough fastd > >>

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-19 Thread Jakub Kicinski
On Thu, 18 Feb 2021 12:23:28 -0800 Xie He wrote: > On Thu, Feb 18, 2021 at 12:06 PM Xie He wrote: > > > > On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky wrote: > > > > > > This is how we write code, we use defines instead of constant numbers, > > > comments to describe tricky parts and

Re: [PATCH net] r8152: move r8153_mac_clk_spd

2021-02-19 Thread Jakub Kicinski
On Fri, 19 Feb 2021 17:38:03 +0800 Hayes Wang wrote: > Move calling r8153_mac_clk_spd() from r8153_first_init() to rtl8153_up(), > and from r8153_enter_oob() to rtl8153_down(). > > r8153_mac_clk_spd() is used for RTL8153A. However, RTL8153B use > r8153_first_init() and r8153_enter_oob(), too.

Re: [PATCH v7 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-18 Thread Jakub Kicinski
On Wed, 17 Feb 2021 22:08:55 -0800 John Fastabend wrote: > > Performance Testing > > > > The test environment is Aliyun ECS server. > > Test cmd: > > ``` > > xdpsock -i eth0 -t -S -s > > ``` > > > > Test result data: > > > > size64 512 10241500 >

Re: [net-next PATCH v6 02/15] net: phy: Introduce fwnode_mdio_find_device()

2021-02-18 Thread Jakub Kicinski
On Thu, 18 Feb 2021 10:56:41 +0530 Calvin Johnson wrote: > +/** > + * fwnode_mdio_find_device - Given a fwnode, find the mdio_device > + * @np: pointer to the mdio_device's fwnode > + * > + * If successful, returns a pointer to the mdio_device with the embedded > + * struct device refcount

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Jakub Kicinski
On Wed, 17 Feb 2021 22:30:14 +0100 Arnd Bergmann wrote: > On Wed, Feb 17, 2021 at 9:20 PM Min Li wrote: > > I attached the G.8273.2 document, where chapter 6 is about supporting > > physical layer > > frequency. And combo mode is Renesas way to support this requirement. Other > > companies > >

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-17 Thread Jakub Kicinski
On Tue, 16 Feb 2021 08:20:46 + Lee Jones wrote: > On Mon, 15 Feb 2021, Jakub Kicinski wrote: > > On Mon, 15 Feb 2021 08:49:52 + Lee Jones wrote: > > > Yes, please share. > > > > https://github.com/kuba-moo/nipa > > Thanks for this. > >

Re: [PATCH v2 net-next 1/3] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-17 Thread Jakub Kicinski
On Tue, 16 Feb 2021 13:12:29 -0500 Vincent Cheng wrote: > >> +} > >> + > >> +static int wait_for_sys_apll_dpll_lock(struct idtcm *idtcm) > >> +{ > >> + const char *fmt = "%d ms SYS lock timeout: APLL Loss Lock %d DPLL > >> state %d"; > >> + u8 i = LOCK_TIMEOUT_MS / LOCK_POLL_INTERVAL_MS; > >

Re: [PATCH v2 net-next 1/3] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-15 Thread Jakub Kicinski
On Sat, 13 Feb 2021 00:06:04 -0500 vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > Part of the device initialization aligns the rising edge of the output > clock to the internal 1 PPS clock. If the system APLL and DPLL is not > locked, then the alignment will fail and there will be

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-15 Thread Jakub Kicinski
On Mon, 15 Feb 2021 08:49:52 + Lee Jones wrote: > > Jakub can explain how he added these checks. > > Yes, please share. https://github.com/kuba-moo/nipa

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-12 Thread Jakub Kicinski
On Fri, 12 Feb 2021 15:06:41 +0100 Bjarni Jonasson wrote: > At Power-On Reset, transients may cause the LCPLL to lock onto a > clock that is momentarily unstable. This is normally seen in QSGMII > setups where the higher speed 6G SerDes is being used. > This patch adds an initial LCPLL Reset to

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread Jakub Kicinski
On Fri, 12 Feb 2021 08:01:15 -0600 Alex Elder wrote: > On 2/11/21 8:04 PM, Jakub Kicinski wrote: > > On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: > >> +/* MAP CSUM headers */ > >> +struct rmnet_map_v5_csum_header { > >> + u8 n

Re: [PATCH v1 5/7] net: ipa: Add support for IPA on MSM8998

2021-02-12 Thread Jakub Kicinski
On Thu, 11 Feb 2021 18:50:13 +0100 AngeloGioacchino Del Regno wrote: > MSM8998 features IPA v3.1 (GSI v1.0): add the required configuration > data for it. > > Signed-off-by: AngeloGioacchino Del Regno > This one does not build: drivers/net/ipa/ipa_data-msm8998.c:382:3: error: ‘struct

Re: [PATCH v1 1/7] net: ipa: Add support for IPA v3.1 with GSI v1.0

2021-02-12 Thread Jakub Kicinski
On Thu, 11 Feb 2021 18:50:09 +0100 AngeloGioacchino Del Regno wrote: > In preparation for adding support for the MSM8998 SoC's IPA, > add the necessary bits for IPA version 3.1 featuring GSI 1.0, > found on at least MSM8998. > > Signed-off-by: AngeloGioacchino Del Regno > please check your

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-11 Thread Jakub Kicinski
On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: > +/* MAP CSUM headers */ > +struct rmnet_map_v5_csum_header { > + u8 next_hdr:1; > + u8 header_type:7; > + u8 hw_reserved:5; > + u8 priority:1; > + u8 hw_reserved_bit:1; > + u8 csum_valid_required:1;

Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

2021-02-10 Thread Jakub Kicinski
On Wed, 10 Feb 2021 17:06:29 + Hariprasad Kelam wrote: > > On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote: > > > v4: > > > - Corrected indentation issues > > > - Use FEC_OFF if user requests for FEC_AUTO mode > > > - Do not clear fec stats in case of user changes > > >

Re: [EXT] Re: [PATCH net-next 5/7] net: marvell: prestera: add LAG support

2021-02-10 Thread Jakub Kicinski
On Tue, 9 Feb 2021 20:31:32 + Mickey Rachamim wrote: > On Tuesday, February 9, 2021 7:35 PM Jakub Kicinski wrote: > > Sounds like we have 3 people who don't like FW-heavy designs dominating the > > kernel - this conversation can only go one way. > > Marvell, Plvision any

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-10 Thread Jakub Kicinski
On Wed, 10 Feb 2021 11:55:31 +0530 Manivannan Sadhasivam wrote: > On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > > This may be a stupid suggestion, but would the integration look les

Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

2021-02-09 Thread Jakub Kicinski
On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote: > v4: > - Corrected indentation issues > - Use FEC_OFF if user requests for FEC_AUTO mode > - Do not clear fec stats in case of user changes > fec mode > - dont hide fec stats depending on interface mode >

Re: [PATCH net-next 5/7] net: marvell: prestera: add LAG support

2021-02-09 Thread Jakub Kicinski
On Tue, 09 Feb 2021 12:56:55 +0100 Tobias Waldekranz wrote: > > I ask myself that question pretty much every day. Sadly I have no clear > > answer. > > Thank you for your candid answer, really appreciate it. I do not envy > you one bit, making those decisions must be extremely hard. > > >

Re: [PATCH net-next 5/7] net: marvell: prestera: add LAG support

2021-02-09 Thread Jakub Kicinski
On Tue, 9 Feb 2021 14:58:26 +0100 Andrew Lunn wrote: > > At the same time some FW is necessary. Certain chip functions, are > > best driven by a micro-controller running a tight control loop. > > For a smart NIC, i could agree. But a switch? The data path is in > hardware. The driver is all

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-09 Thread Jakub Kicinski
On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > This may be a stupid suggestion, but would the integration look less a > backdoor if it would have been named "mhi_wwan" and it exposed already > all the AT+DIAG+QMI+MBIM+NMEA possible channels as chardevs, not just > QMI? What's DIAG?

Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 00:31:34 -0600 Samuel Holland wrote: > On 2/8/21 12:28 AM, Samuel Holland wrote: > > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error > > pointers to optional clocks were replaced by NULL to simplify the resume > > callback implementation. However, that

Re: [PATCH net-next 5/7] net: marvell: prestera: add LAG support

2021-02-08 Thread Jakub Kicinski
On Mon, 08 Feb 2021 20:54:29 +0100 Tobias Waldekranz wrote: > On Thu, Feb 04, 2021 at 21:16, Jakub Kicinski wrote: > > On Wed, 3 Feb 2021 18:54:56 +0200 Vadym Kochan wrote: > >> From: Serhiy Boiko > >> > >> The following features are supported: &

Re: [PATCH 0/3] Fix some seq_file users that were recently broken

2021-02-08 Thread Jakub Kicinski
On Sun, 7 Feb 2021 13:11:45 -0800 Andrew Morton wrote: > On Sat, 6 Feb 2021 14:29:24 -0800 Jakub Kicinski wrote: > > On Fri, 5 Feb 2021 14:35:50 -0800 Andrew Morton wrote: > > > On Fri, 05 Feb 2021 11:36:30 +1100 NeilBrown wrote: > > > 1f4aace60b0e ("fs/seq_fil

Re: [PATCH net] vsock: fix locking in vsock_shutdown()

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 16:04:31 +0100 Stefano Garzarella wrote: > What do you suggest? > > I did it this way because by modifying only the caller, we would have a > nested lock. > > This way instead we are sure that if we backport this patch, we don't > forget to touch hvs_shutdown() as well. I'm

Re: [PATCH v2 00/24] net: stmmac: Fix clocks/reset-related procedures

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 16:55:44 +0300 Serge Semin wrote: > Baikal-T1 SoC is equipped with two Synopsys DesignWare GMAC v3.73a-based > ethernet interfaces with no internal Ethernet PHY attached. The IP-cores > are configured as GMAC-AXI with CSR interface clocked by a dedicated > signal. Each of which

Re: net-next build error (3)

2021-02-08 Thread Jakub Kicinski
On Sun, 07 Feb 2021 18:20:14 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:e93fac3b drivers: net: xen-netfront: Simplify the calculat.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=160930c4d0 > kernel

Re: [PATCH] drivers: net: ethernet: sun: Fix couple of spells in the file sunhme.c

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 15:00:01 + Edward Cree wrote: > On 05/02/2021 12:47, Bhaskar Chowdhury wrote: > > > > > > s/fuck/mess/ > > s/fucking/s/ > > > > Signed-off-by: Bhaskar Chowdhury > > Right or wrong, these are not "spelling fixes". > Please do not misrepresent your patch in your

Re: [net-next v4 00/14] Add Marvell CN10K support

2021-02-08 Thread Jakub Kicinski
On Sat, 6 Feb 2021 04:19:59 +0530 Geetha sowjanya wrote: > The current admin function (AF) driver and the netdev driver supports > OcteonTx2 silicon variants. The same OcteonTx2's > Resource Virtualization Unit (RVU) is carried forward to the next-gen > silicon ie OcteonTx3, with some changes and

Re: [PATCH v2 net-next] net: socket: use BIT() for MSG_*

2021-02-08 Thread Jakub Kicinski
On Sat, 6 Feb 2021 19:18:16 -0800 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The bit mask for MSG_* seems a little confused here. Replace it > with BIT() to make it clear to understand. > > Changes since v1: > - use BIT() instead of BIT_MASK() > > Signed-off-by: Menglong Dong

Re: [PATCH net-next] net/packet: Improve the comment about LL header visibility criteria

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 21:51:36 -0500 Willem de Bruijn wrote: > On Fri, Feb 5, 2021 at 5:42 PM Xie He wrote: > > > > The "dev_has_header" function, recently added in > > commit d549699048b4 ("net/packet: fix packet receive on L3 devices > > without visible hard header"), > > is more accurate as

Re: [PATCH v8 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp11x ethernet device tree

2021-02-06 Thread Jakub Kicinski
On Sat, 6 Feb 2021 18:45:48 +0200 stef...@marvell.com wrote: > From: Konstantin Porotchkin > > CM3 SRAM address space would be used for Flow Control configuration. > > Signed-off-by: Stefan Chulski > Signed-off-by: Konstantin Porotchkin Isn't there are requirement to CC the DT mailing list

Re: [PATCH net-next v2 0/7] net: ipa: a mix of small improvements

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 16:10:53 -0600 Alex Elder wrote: > Version 2 of this series restructures a couple of the changed > functions (in patches 1 and 2) to avoid blocks of indented code > by returning early when possible, as suggested by Jakub. The > description of the first patch was changed as a

Re: [PATCH 0/3] Fix some seq_file users that were recently broken

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 14:35:50 -0800 Andrew Morton wrote: > On Fri, 05 Feb 2021 11:36:30 +1100 NeilBrown wrote: > > > A recent change to seq_file broke some users which were using seq_file > > in a non-"standard" way ... though the "standard" isn't documented, so > > they can be excused. The

Re: [PATCH] net: core: Clean code style issues in `neighbour.c`

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 14:28:21 +0800 Zheng Yongjun wrote: > Do code format alignment to clean code style issues. > > Signed-off-by: Zheng Yongjun I don't think these changes make the code substantively more readable. At the same time they make the history harder to follow and may cause backporting

Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 16:01:43 -0800 Amy Parker wrote: > This patchset updates atarilance.c and sun3lance.c to follow the kernel > style guide. Each patch tackles a different issue in the style guide. These are very, very old drivers, nobody worked on them for a decade. What's your motivation for

Re: [PATCH net-next] net: core: Return the correct errno code

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 11:19:23 +0800 Zheng Yongjun wrote: > When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. > > Signed-off-by: Zheng Yongjun > --- > net/core/rtnetlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/rtnetlink.c

Re: [PATCH net-next] net: ipv4: Return the correct errno code

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 15:26:57 +0800 Zheng Yongjun wrote: > When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. > > Signed-off-by: Zheng Yongjun > --- > net/ipv4/devinet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/devinet.c

Re: [PATCH net-next] net: Return the correct errno code

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 11:14:26 -0800 Jesse Brandeburg wrote: > Zheng Yongjun wrote: > > > When kzalloc failed, should return ENOMEM rather than ENOBUFS. > > All these patches have the same subject and description, couldn't they > just be part of a single series with a good cover letter? Agreed.

Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-02-05 Thread Jakub Kicinski
On Fri, 5 Feb 2021 14:15:01 + Hariprasad Kelam wrote: > > > Will add multi advertised mode support in near future. > > > > Looking at patch 6 it seems like the get side already supports multiple > > modes, > > although the example output only lists supported no advertised. > > > > Is the

Re: [PATCH net-next 7/7] net: marvell: prestera: fix port event handling on init

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:54:58 +0200 Vadym Kochan wrote: > For some reason there might be a crash during ports creation if port > events are handling at the same time because fw may send initial > port event with down state. > > The crash points to cancel_delayed_work() which is called when port

Re: [PATCH net-next 5/7] net: marvell: prestera: add LAG support

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:54:56 +0200 Vadym Kochan wrote: > From: Serhiy Boiko > > The following features are supported: > > - LAG basic operations > - create/delete LAG > - add/remove a member to LAG > - enable/disable member in LAG > - LAG Bridge support > -

Re: [PATCH net-next 2/7] net: marvell: prestera: disable events interrupt while handling

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:54:53 +0200 Vadym Kochan wrote: > There are change in firmware which requires that receiver will > disable event interrupts before handling them and enable them > after finish with handling. Events still may come into the queue > but without receiver interruption. Sounds

Re: [PATCH net-next v2 0/4] Fix W=1 compilation warnings in net/* folder

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 15:51:08 +0200 Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v2: > * Patch 3: Added missing include file. > v1: https://lore.kernel.org/lkml/20210203101612.4004322-1-l...@kernel.org > * Removed Fixes lines. > * Changed target from net to be net-next. > *

Re: [PATCH net-next 2/7] net: ipa: synchronize NAPI only for suspend

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 09:28:50 -0600 Alex Elder wrote: > int gsi_channel_suspend(struct gsi *gsi, u32 channel_id, bool stop) > { > struct gsi_channel *channel = >channel[channel_id]; > + int ret; > > - return __gsi_channel_stop(channel, stop); > + /* Synchronize NAPI if

Re: [PATCH net-next 1/7] net: ipa: restructure a few functions

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 09:28:49 -0600 Alex Elder wrote: > Make __gsi_channel_start() and __gsi_channel_stop() more structurally > and semantically similar to each other: > - Restructure __gsi_channel_start() to always return at the end of > the function, similar to the way __gsi_channel_stop()

Re: [PATCH net-next] net: core: Remove extra spaces

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote: > Do codingstyle clean up to remove extra spaces. > > Signed-off-by: Zheng Yongjun > --- > net/core/neighbour.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > index

Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 06:32:32 +0100 Jürgen Groß wrote: > On 04.02.21 00:48, Jakub Kicinski wrote: > > On Tue, 2 Feb 2021 08:09:38 +0100 Juergen Gross wrote: > >> Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") > >> xenvif_rx_ring_slots

Re: [net-next v3 00/14] Add Marvell CN10K support

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 12:04:54 -0800 Jesse Brandeburg wrote: > Geetha sowjanya wrote: > > > v2-v3 > > Reposting as a single thread. > > FYI, it didn't work, suggest you try adding the git-send-email option > (via git-config) > > sendemail.thread=true > sendemail.chainreplyto=false > > And you

Re: [PATCH] net/qrtr: replaced useless kzalloc with kmalloc in qrtr_tun_write_iter()

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 10:51:59 -0800 Jakub Kicinski wrote: > On Thu, 4 Feb 2021 15:02:30 +0600 Sabyrzhan Tasbolatov wrote: > > Replaced kzalloc() with kmalloc(), there is no need for zeroed-out > > memory for simple void *kbuf. > > There is no need for zeroed-out memory bec

Re: [PATCH] net/qrtr: replaced useless kzalloc with kmalloc in qrtr_tun_write_iter()

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 15:02:30 +0600 Sabyrzhan Tasbolatov wrote: > Replaced kzalloc() with kmalloc(), there is no need for zeroed-out > memory for simple void *kbuf. There is no need for zeroed-out memory because it's immediately overwritten by copy_from_iter... > >For potential, separate clean up

Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 17:37:41 + Hariprasad Kelam wrote: > > > + req->args.speed = req_ks.base.speed; > > > + /* firmware expects 1 for half duplex and 0 for full duplex > > > + * hence inverting > > > + */ > > > + req->args.duplex = req_ks.base.duplex ^ 0x1; > > > + req->args.an =

Re: [PATCH] net/qrtr: restrict user-controlled length in qrtr_tun_write_iter()

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 15:20:59 +0600 Sabyrzhan Tasbolatov wrote: > syzbot found WARNING in qrtr_tun_write_iter [1] when write_iter length > exceeds KMALLOC_MAX_SIZE causing order >= MAX_ORDER condition. > > Additionally, there is no check for 0 length write. > > [1] > WARNING: mm/page_alloc.c:5011

Re: [PATCH] octeontx2-af: remove unneeded semicolon

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 15:46:58 -0800 Jesse Brandeburg wrote: > Yang Li wrote: > > > Eliminate the following coccicheck warning: > > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3: > > Unneeded semicolon > > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1809:3-4: > >

Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()

2021-02-03 Thread Jakub Kicinski
On Tue, 2 Feb 2021 08:09:38 +0100 Juergen Gross wrote: > Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") > xenvif_rx_ring_slots_available() is no longer called only from the rx > queue kernel thread, so it needs to access the rx queue with the > associated queue held. > >

Re: [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 09:54:22 -0800 Randy Dunlap wrote: > On 2/3/21 7:15 AM, Bhaskar Chowdhury wrote: > > > > s/initialsation/initialisation/ > > s/specifiing/specifying/ > > > > Signed-off-by: Bhaskar Chowdhury > > Hi, > > $Subject has a typo/spello. This happens more than you'd think with

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > The current patchset only supports QMI channel so I'd request you to > > > revi

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Jakub Kicinski
On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > >> Jakub, Dave, Adding you both to get your reviews on this series. I've > >> provided an explanation above and in the previous iteration [1]. > > > >Let's be clear what the review would be for. Yet another QMI chardev > >or the

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-02 Thread Jakub Kicinski
On Tue, 2 Feb 2021 09:52:08 +0530 Manivannan Sadhasivam wrote: > > > I don't see the connection here, sorry. > > > > For instance USB_NET_CDC_MBIM driver creates the /dev/cdc-wdmX chardev node > > for > > configuring the modems which supports MBIM protocol over USB. Like that, > > this > >

Re: [PATCH net-next v2 0/7] net: ipa: don't disable NAPI in suspend

2021-02-02 Thread Jakub Kicinski
On Mon, 1 Feb 2021 13:44:20 -0500 Willem de Bruijn wrote: > On Mon, Feb 1, 2021 at 12:28 PM Alex Elder wrote: > > > > This is version 2 of a series that reworks the order in which things > > happen during channel stop and suspend (and start and resume), in > > order to address a hang that has

Re: [PATCH 0/9] drivers: net: update tasklet_init callers

2021-02-02 Thread Jakub Kicinski
On Sun, 31 Jan 2021 00:47:21 +0100 Emil Renner Berthing wrote: > This updates the remaining callers of tasklet_init() in drivers/net > to the new API introduced in > commit 12cc923f1ccc ("tasklet: Introduce new initialization API") > > All changes are done by coccinelle using the following

Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-02-02 Thread Jakub Kicinski
On Sun, 31 Jan 2021 18:41:05 +0530 Hariprasad Kelam wrote: > From: Christina Jacob > > Register set_link_ksetting callback with driver such that > link configurations parameters like advertised mode,speed, duplex > and autoneg can be configured. > > below command > ethtool -s eth0 advertise 0x1

Re: [Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-02-02 Thread Jakub Kicinski
On Sun, 31 Jan 2021 18:41:04 +0530 Hariprasad Kelam wrote: > From: Christina Jacob > > Register get_link_ksettings callback to get link status information > from the driver. As virtual function (vf) shares same physical link > same API is used for both the drivers and for loop back drivers >

Re: [Patch v3 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-02-02 Thread Jakub Kicinski
On Mon, 1 Feb 2021 10:54:40 +0530 Hariprasad Kelam wrote: > From: Christina Jacob > > Add ethtool support to configure fec modes baser/rs and > support to fecth FEC stats from CGX as well PHY. > > Configure fec mode > - ethtool --set-fec eth0 encoding rs/baser/off/auto > Query fec mode >

Re: [PATCH net 1/4] ipv6: silence compilation warning for non-IPV6 builds

2021-02-02 Thread Jakub Kicinski
On Tue, 2 Feb 2021 20:55:28 +0200 Leon Romanovsky wrote: > On Tue, Feb 02, 2021 at 08:29:09AM -0800, Jakub Kicinski wrote: > > On Tue, 2 Feb 2021 15:55:41 +0200 Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > The W=1 compilation of allmodco

Re: [PATCH net-next v2 0/4] bridge: mrp: Extend br_mrp_switchdev_*

2021-02-02 Thread Jakub Kicinski
On Tue, 2 Feb 2021 21:06:49 +0100 Horatiu Vultur wrote: > The 02/02/2021 11:50, Jakub Kicinski wrote: > > On Tue, 2 Feb 2021 08:40:02 +0100 Rasmus Villemoes wrote: > > > I am planning to test these, but it's unlikely I'll get around to it > > > this week unfortunately.

<    1   2   3   4   5   6   7   8   9   10   >