Re: [PATCH] octeontx2-af: Remove unneeded semicolon

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 07:50:59 + Xu Wang wrote: > fix semicolon.cocci warnings: > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3: Unneeded > semicolon > > Signed-off-by: Xu Wang I squashed your 3 patches for octeontx2-af and applied them to net-next. Thanks.

Re: [PATCH net] tcp: Fix potential use-after-free due to double kfree().

2021-01-19 Thread Jakub Kicinski
On Mon, 18 Jan 2021 14:59:20 +0900 Kuniyuki Iwashima wrote: > Receiving ACK with a valid SYN cookie, cookie_v4_check() allocates struct > request_sock and then can allocate inet_rsk(req)->ireq_opt. After that, > tcp_v4_syn_recv_sock() allocates struct sock and copies ireq_opt to > inet_sk(sk)->inet

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Jakub Kicinski
On Wed, 20 Jan 2021 00:59:17 + Grant Grundler wrote: > > > Thanks for the patch, this looks like an improvement over: > > > > > > 59b4a8fa27f5 ("CDC-NCM: remove "connected" log message") > > > > > > right? Should we bring the "network connection: connected" message back? > > > > Yes, we can r

Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 15:43:43 -0800 Ivan Babrou wrote: > On Thu, Dec 17, 2020 at 10:14 AM Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 17:29:06 -0800 Ivan Babrou wrote: > > > Without this change the driver tries to allocate too many queues, > > > breaching th

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Jakub Kicinski
On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote: > RTL8156 sends notifications about every 32ms. > Only display/log notifications when something changes. > > This issue has been reported by others: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1832472 > https://lkml.or

Re: [PATCH 2/2] ethernet: igb: e1000_phy: Check for ops.force_speed_duplex existence

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 07:55:19 +0100 Paul Menzel wrote: > Am 05.01.21 um 18:25 schrieb Greg KH: > > On Tue, Jan 05, 2021 at 06:16:59PM +0100, Paul Menzel wrote: > >> Am 03.11.20 um 19:39 schrieb Jakub Kicinski: > >>> On Tue, 3 Nov 2020 08:35:09 +0100 Paul Menze

Re: [PATCH net-next] mdio, phy: fix -Wshadow warnings triggered by nested container_of()

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 16:21:35 +0100 Andrew Lunn wrote: > On Sat, Jan 16, 2021 at 04:13:22PM +, Alexander Lobakin wrote: > > container_of() macro hides a local variable '__mptr' inside. This > > becomes a problem when several container_of() are nested in each > > other within single line or plain

Re: [PATCH net 1/2] net: mrp: fix definitions of MRP test packets

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 16:42:14 +0100 Rasmus Villemoes wrote: > On 28/12/2020 23.24, Jakub Kicinski wrote: > > On Wed, 23 Dec 2020 15:45:32 +0100 Rasmus Villemoes wrote: > >> Wireshark says that the MRP test packets cannot be decoded - and the > >> reason for that is t

Re: [PATCH v1] ipv4: add iPv4_is_multicast() check in ip_mc_leave_group().

2021-01-18 Thread Jakub Kicinski
On Sun, 17 Jan 2021 05:34:16 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > There is no iPv4_is_multicast() check added to ip_mc_leave_group() > to check if imr->imr_multiaddr.s_addr is a multicast address. > If not a multicast address, it may result in an error. Could you please sa

Re: [PATCH] net/qla3xxx: switch from 'pci_' to 'dma_' API

2021-01-18 Thread Jakub Kicinski
On Sun, 17 Jan 2021 09:15:42 +0100 Christophe JAILLET wrote: > @@ -2525,9 +2519,8 @@ static int ql_alloc_net_req_rsp_queues(struct > ql3_adapter *qdev) > wmb(); > > qdev->req_q_virt_addr = > - pci_alloc_consistent(qdev->pdev, > - (size_t) qdev->re

Re: [PATCH net v2] tcp: fix TCP_USER_TIMEOUT with zero window

2021-01-18 Thread Jakub Kicinski
On Fri, 15 Jan 2021 14:30:58 -0800 Enke Chen wrote: > From: Enke Chen > > The TCP session does not terminate with TCP_USER_TIMEOUT when data > remain untransmitted due to zero window. > > The number of unanswered zero-window probes (tcp_probes_out) is > reset to zero with incoming acks irrespect

Re: [PATCH v4 net-next] net: bridge: check vlan with eth_type_vlan() method

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 13:55:11 +0200 Nikolay Aleksandrov wrote: > On 17/01/2021 10:09, menglong8.d...@gmail.com wrote: > > From: Menglong Dong > > > > Replace some checks for ETH_P_8021Q and ETH_P_8021AD with > > eth_type_vlan(). > > > > Signed-off-by: Menglong Dong > > Acked-by: Nikolay Aleksan

Re: [PATCH net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters

2021-01-18 Thread Jakub Kicinski
On Tue, 19 Jan 2021 06:19:23 +0900 Bongsu Jeon wrote: > On Tue, Jan 19, 2021 at 6:01 AM Jakub Kicinski wrote: > > > > On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote: > > > From: Bongsu Jeon > > > > > > Fix the code because NCI_CORE_INIT_CMD i

Re: [PATCH net-next] net: core: Namespace-ify sysctl_wmem_default and sysctl_rmem_default

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 13:15:28 -0800 Jakub Kicinski wrote: > On Mon, 18 Jan 2021 12:15:18 +0100 Christian Brauner wrote: > > On Sun, Jan 17, 2021 at 06:23:19PM +0800, menglong8.d...@gmail.com wrote: > > > From: Menglong Dong > > > > > > For now, sysctl_wmem

Re: [PATCH v3 12/21] net: stmmac: dwmac-sun8i: Prepare for second EMAC clock register

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 02:08:39 + Andre Przywara wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index 58e0511badba..00c10ec7b693 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/et

Re: [PATCH net-next] net: core: Namespace-ify sysctl_wmem_default and sysctl_rmem_default

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 12:15:18 +0100 Christian Brauner wrote: > On Sun, Jan 17, 2021 at 06:23:19PM +0800, menglong8.d...@gmail.com wrote: > > From: Menglong Dong > > > > For now, sysctl_wmem_default and sysctl_rmem_default are globally > > unified. It's not convenient in some case. For example, whe

Re: [PATCH net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters

2021-01-18 Thread Jakub Kicinski
On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0 > but there is no parameters in NCI1.x. > > Signed-off-by: Bongsu Jeon What's the Fixes tag for this change?

Re: [PATCH 0/2] net: dsa: mv88e6xxx: fix vlan filtering for 6250

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 14:22:57 +0100 Rasmus Villemoes wrote: > On 17/01/2021 22.08, Vladimir Oltean wrote: > > Hi Rasmus, > > > > On Sat, Jan 16, 2021 at 03:39:34AM +0100, Rasmus Villemoes wrote: > >> I finally managed to figure out why enabling VLAN filtering on the > >> 6250 broke all (ingressin

Re: [PATCH net-next 7/7] net: ipa: allow arbitrary number of interconnects

2021-01-18 Thread Jakub Kicinski
On Sun, 17 Jan 2021 10:03:41 -0600 Alex Elder wrote: > On 1/16/21 9:12 PM, Jakub Kicinski wrote: > > On Fri, 15 Jan 2021 06:50:50 -0600 Alex Elder wrote: > >> Currently we assume that the IPA hardware has exactly three > >> interconnects. But that won't be guara

Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 11:45:44 +0100 Ahmed S. Darwish wrote: > On Mon, Jan 11, 2021 at 02:54:06PM +0100, Ahmed S. Darwish wrote: > > Hi, > > > > On Tue, Dec 22, 2020 at 10:03:37AM +0100, Ahmed S. Darwish wrote: > > ... > > > > > > Included is an RFC patch to fix the points above: if the RESET flag

Re: [PATCH net-next 7/7] net: ipa: allow arbitrary number of interconnects

2021-01-16 Thread Jakub Kicinski
On Fri, 15 Jan 2021 06:50:50 -0600 Alex Elder wrote: > Currently we assume that the IPA hardware has exactly three > interconnects. But that won't be guaranteed for all platforms, > so allow any number of interconnects to be specified in the > configuration data. > > For each platform, define an

Re: [PATCH v3 net-next] net: bridge: check vlan with eth_type_vlan() method

2021-01-16 Thread Jakub Kicinski
On Thu, 14 Jan 2021 20:41:31 -0800 menglong8.d...@gmail.com wrote: > - if (data[IFLA_BR_VLAN_PROTOCOL]) { > - switch (nla_get_be16(data[IFLA_BR_VLAN_PROTOCOL])) { > - case htons(ETH_P_8021Q): > - case htons(ETH_P_8021AD): > - break; > -

Re: [PATCH net-next 1/1] stmmac: intel: change all EHL/TGL to auto detect phy addr

2021-01-16 Thread Jakub Kicinski
es. Signed-off-by: Voon Weifeng Signed-off-by: Wong Vee Khee Link: https://lore.kernel.org/r/20201106094341.4241-1-vee.khee.w...@intel.com Signed-off-by: Jakub Kicinski It's relatively small, and Jan reports it makes his boards detect the PHY. The change went in via -next and into Linus's tree during the 5.11 merge window.

Re: [PATCH v2] hv_netvsc: Add (more) validation for untrusted Hyper-V values

2021-01-15 Thread Jakub Kicinski
> off the end of an array, or subvert an existing validation via integer > overflow. Ensure that outgoing packets do not have any leftover guest > memory that has not been zeroed out. > > Reported-by: Juan Vazquez > Signed-off-by: Andrea Parri (Microsoft) > Cc: "David S.

Re: [PATCH v10 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-01-15 Thread Jakub Kicinski
On Wed, 13 Jan 2021 19:40:28 +0100 Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] > boards

Re: [RFC PATCH net 1/2] net: introduce CAN specific pointer in the struct net_device

2021-01-15 Thread Jakub Kicinski
On Fri, 15 Jan 2021 15:30:35 +0100 Oleksij Rempel wrote: > Since 20dd3850bcf8 ("can: Speed up CAN frame receiption by using > ml_priv") the CAN framework uses per device specific data in the AF_CAN > protocol. For this purpose the struct net_device->ml_priv is used. Later > the ml_priv usage in CAN

Re: [PATCH net 0/2] ipv6: fixes for the multicast routes

2021-01-15 Thread Jakub Kicinski
On Fri, 15 Jan 2021 19:42:07 +0100 Matteo Croce wrote: > From: Matteo Croce > > Fix two wrong flags in the IPv6 multicast routes created > by the autoconf code. Any chance for Fixes tags here?

Re: [EXT] [PATCH v3] octeontx2-af: Fix missing check bugs in rvu_cgx.c

2021-01-15 Thread Jakub Kicinski
On Fri, 15 Jan 2021 21:27:58 +0800 (CST) Yingjie Wang wrote: > Thanks for your reply. I have resended the email with the Reviewed-by tag. Thanks, applied. In the future there is no need to resend to add the tags. The automation will gather the tags the patch received on the latest revision.

Re: [PATCH net-next 0/6] net: ipa: GSI interrupt updates

2021-01-15 Thread Jakub Kicinski
On Fri, 15 Jan 2021 04:42:14 -0600 Alex Elder wrote: > On 1/14/21 8:08 PM, Jakub Kicinski wrote: > > Dropped the fixes tags (since its not a series of fixes) and applied. > > Thanks for applying these. > > Do you only want "Fixes" tags on patches posted for the

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-15 Thread Jakub Kicinski
On Fri, 15 Jan 2021 13:38:48 + Lee Jones wrote: > Okay, so what would you like me to do? Would you like me to re-submit > the set based only on net-next Yes, rebase your patches on net-next, recheck everything builds okay and resubmit. You should always develop against the tree that will merg

Re: [PATCH v2 net-next] net: bridge: check vlan with eth_type_vlan() method

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 18:23:44 -0800 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > Replace some checks for ETH_P_8021Q and ETH_P_8021AD with > eth_type_vlan(). > > Signed-off-by: Menglong Dong This adds a new warning when built with W=1 C=1: net/bridge/br_vlan.c:920:28: warning: inc

Re: [PATCH net-next] net: core: use eth_type_vlan in tap_get_user_xdp

2021-01-14 Thread Jakub Kicinski
On Wed, 13 Jan 2021 23:44:36 -0800 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > Replace the check for ETH_P_8021Q and ETH_P_8021AD in > tap_get_user_xdp with eth_type_vlan. > > Signed-off-by: Menglong Dong Similarly to bridge, please convert all the instances in tap in one patch.

Re: [PATCH net-next 0/6] net: ipa: GSI interrupt updates

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 15:22:54 -0800 Saeed Mahameed wrote: > On Wed, 2021-01-13 at 11:15 -0600, Alex Elder wrote: > > This series implements some updates for the GSI interrupt code, > > buliding on some bug fixes implemented last month. > > > > The first two are simple changes made to improve readab

Re: [GIT PULL] Networking for 5.11-rc4

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 13:37:17 -0800 Linus Torvalds wrote: > On Thu, Jan 14, 2021 at 12:05 PM Jakub Kicinski wrote: > > > > Current release - regressions: > > ... > > Current release - always broken: > > So I understand what you mean, but it does sound odd with

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 16:11:41 -0500 Jarod Wilson wrote: > In truth, this code started out as a copy of bond_eth_hash(), which also > only uses the last byte, though of both source and destination macs. In > the typical use case for the requesting user, the bond is formed from two > onboard NICs, whi

[GIT PULL] Networking for 5.11-rc4

2021-01-14 Thread Jakub Kicinski
k - mlxsw: core: Thermal control fixes - ipv6: validate GSO SKB against MTU before finish IPv6 processing - stmmac: use __napi_schedule() for PREEMPT_RT - net: mvpp2: remove Pause and Asym_Pause support Misc: - remove from MAINTAINERS folks

Re: [PATCH v6 12/16] net: tip: fix a couple kernel-doc markups

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 10:59:08 -0500 Jon Maloy wrote: > On 1/14/21 3:04 AM, Mauro Carvalho Chehab wrote: > > A function has a different name between their prototype > > and its kernel-doc markup: > > > > ../net/tipc/link.c:2551: warning: expecting prototype for > > link_reset_stats(). Prototype

Re: [EXT] Re: [PATCH net-next] net: mvpp2: extend mib-fragments name to mib-fragments-err

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 16:13:23 + Stefan Chulski wrote: > > > From: Stefan Chulski > > > > > > This patch doesn't change any functionality, but just extend MIB > > > counter register and ethtool-statistic names with "err". > > > > > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter.

Re: [PATCH net-next] net: mvpp2: extend mib-fragments name to mib-fragments-err

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 12:07:38 +0200 stef...@marvell.com wrote: > From: Stefan Chulski > > This patch doesn't change any functionality, but just extend > MIB counter register and ethtool-statistic names with "err". > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > Extend REG nam

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 08:33:49 + Lee Jones wrote: > On Wed, 13 Jan 2021, Jakub Kicinski wrote: > > > On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > > > Resending

Re: [PATCH] net: stmmac: Fixed mtu channged by cache aligned

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 11:41:09 +0800 David Wu wrote: > Since the original mtu is not used when the mtu is updated, > the mtu is aligned with cache, this will get an incorrect. > For example, if you want to configure the mtu to be 1500, > but mtu 1536 is configured in fact. > > Fixed: eaf4fac478077 (

Re: [PATCH v1 1/1] time64.h: Consolidated PSEC_PER_SEC definition

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 17:37:09 +0200 Andy Shevchenko wrote: > We have currently three users of the PSEC_PER_SEC each of them defining it > individually. Instead, move it to time64.h to be available for everyone. > > There is a new user coming with the same constant in use. It will also > make its li

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > Resending the stragglers again. > > > This set is part of a larger effort attempting to clean-up W=1 > > kern

Re: [PATCH V3] drivers: net: marvell: Fixed two spellings,controling to controlling and oen to one

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 09:26:48 -0800 Randy Dunlap wrote: > On 1/12/21 2:31 AM, Bhaskar Chowdhury wrote: > > s/oen/one/ > > s/controling/controlling/ > > > > Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap Applied, thanks.

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > This comes from an end-user request, where they're running multiple VMs on > hosts with bonded interfaces connected to some interest switch topologies, > where 802.3ad isn't an option. They're currently running a proprietary > solution that e

Re: [PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-13 Thread Jakub Kicinski
On Fri, 8 Jan 2021 17:45:54 +0200 Claudiu Beznea wrote: > KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special > power saving mode (backup mode) that cuts the power for almost all > parts of the SoC. The rail powering the ethernet PHY is also cut off. > When resuming, in case the PHY

Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 21:27:35 +0800 (CST) Yingjie Wang wrote: > Thanks for your reply. I commit this change on linux-next/stable > branch, and I use "git log --pretty=fixes" command to get the Fixes > tag. I want to know if I need to make a change on any other branch > and commit it? For networkin

Re: [PATCH net] net: stmmac: use __napi_schedule() for PREEMPT_RT

2021-01-13 Thread Jakub Kicinski
On Tue, 12 Jan 2021 15:01:22 +0100 Sebastien Laveze wrote: > From: Seb Laveze > > Use of __napi_schedule_irqoff() is not safe with PREEMPT_RT in which > hard interrupts are not disabled while running the threaded interrupt. > > Using __napi_schedule() works for both PREEMPT_RT and mainline Linux

Re: kernel BUG at net/core/dev.c:NUM!

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 02:27:27 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:c49243e8 Merge branch 'net-fix-issues-around-register_netd.. > git tree: net > console output: https://syzkaller.appspot.com/x/log.txt?x=11da7ba8d0 > kernel config: ht

Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 08:23:54 + David Howells wrote: > Jakub Kicinski wrote: > > > On Tue, 12 Jan 2021 15:59:15 + David Howells wrote: > > > From: Baptiste Lepers > > > > > > The call state may be changed at any time by the data-ready routine in

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 18:15:20 +0100 Eric Dumazet wrote: > > IDK much about MM, but we already have a kmem_cache for skbs and now > > we're building a cache on top of a cache. Shouldn't MM take care of > > providing a per-CPU BH-only lockless cache? > > I think part of the improvement comes from

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 05:46:05 +0100 Eric Dumazet wrote: > On Wed, Jan 13, 2021 at 2:02 AM Jakub Kicinski wrote: > > > > On Tue, 12 Jan 2021 13:23:16 +0100 Eric Dumazet wrote: > > > On Tue, Jan 12, 2021 at 12:08 PM Alexander Lobakin > > > wrote: > > >

Re: [PATCH] net: phy: smsc: fix clk error handling

2021-01-12 Thread Jakub Kicinski
k_get_optional() throw an error but instead of returning the error it > > ignores it. > > > > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > > support") > > Suggested-by: Jakub Kicinski > > Signed-off-by: Marco Felsch > > Reviewed-by: Andrew Lunn Applied, thanks!

Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 15:59:15 + David Howells wrote: > From: Baptiste Lepers > > The call state may be changed at any time by the data-ready routine in > response to received packets, so if the call state is to be read and acted > upon several times in a function, READ_ONCE() must be used unle

Re: [PATCH v1] net/ipv4: add IPv4_is_multicast() check in ip_mc_leave_group().

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 00:47:09 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > There is no IPv4_is_multicast() check added to ip_mc_leave_group() > to determine whether imr->imr_multiaddr.s_addr is a multicast address. > If not a multicast address, it may result in an error. > In some c

Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2021-01-12 Thread Jakub Kicinski
On Mon, 11 Jan 2021 18:09:49 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > In rvu_mbox_handler_cgx_mac_addr_get() > and rvu_mbox_handler_cgx_mac_addr_set(), > the msg is expected only from PFs that are mapped to CGX LMACs. > It should be checked before mapping, > so we add the is_cg

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 13:23:16 +0100 Eric Dumazet wrote: > On Tue, Jan 12, 2021 at 12:08 PM Alexander Lobakin wrote: > > > > From: Edward Cree > > Date: Tue, 12 Jan 2021 09:54:04 + > > > > > Without wishing to weigh in on whether this caching is a good idea... > > > > Well, we already have

Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 11:55:11 -0800 Praveen Chaudhary wrote: > Hi Jakub > > Thanks for the review, > > Sure, I will reraise the patch (again v0i, sonce no code changes) after > adding space before '<'. > > This patch adds lines in 'include/uapi/', that requires ABI version changes > for debian

Re: [PATCv4 net-next] octeontx2-pf: Add RSS multi group support

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 04:17:44 + Geethasowjanya Akula wrote: > Hi All, > > Any feedback on this patch. I think Dave merged it already, see commit 81a4362016e7 ("octeontx2-pf: Add RSS multi group support") in net-next.

Re: [PATCH v2 0/3] hv_netvsc: Prevent packet loss during VF add/remove

2021-01-11 Thread Jakub Kicinski
On Fri, 8 Jan 2021 16:53:40 -0800 Long Li wrote: > From: Long Li > > This patch set fixes issues with packet loss on VF add/remove. These patches are for net-next? They just optimize the amount of packet loss on switch, not fix bugs, right?

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Jakub Kicinski
On Tue, 12 Jan 2021 01:47:27 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote: > > On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > > > From: Stefan Chulski > > > > > > Packet Processor hardware not co

Re: [PATCH] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote: > There is no usrio config defined for default gem config leading to > a kernel panic devices that don't define a data. This issue can be > reprdouced with microchip polar fire soc where compatible string > is defined as "cdns,macb". > > Fixes:

Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 13:58:29 -0800 Praveen Chaudhary wrote: > For IPv4, default route is learned via DHCPv4 and user is allowed to change > metric using config etc/network/interfaces. But for IPv6, default route can > be learned via RA, for which, currently a fixed metric value 1024 is used. > > I

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Jakub Kicinski
On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > From: Stefan Chulski > > Packet Processor hardware not connected to MAC flow control unit and > cannot support TX flow control. > This patch disable flow control support. > > Fixes: 3f518509dedc ("ethernet: Add new driver for Marvel

Re: KMSAN: kernel-infoleak in move_addr_to_user (4)

2021-01-11 Thread Jakub Kicinski
Looks like a AF_CAN socket: r0 = socket(0x1d, 0x2, 0x6) getsockname$packet(r0, &(0x7f000100)={0x11, 0x0, 0x0, 0x1, 0x0, 0x6, @broadcast}, &(0x7f00)=0x14) On Sun, 10 Jan 2021 02:19:15 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:73d62e81

Re: [PATCH 5.10 018/145] net: dcb: Validate netlink message in DCB handler

2021-01-11 Thread Jakub Kicinski
driver") > Signed-off-by: Petr Machata > Link: > https://lore.kernel.org/r/a2a9b88418f3a58ef211b718f2970128ef9e3793.1608673640.git...@pmachata.org > Signed-off-by: Jakub Kicinski > Signed-off-by: Greg Kroah-Hartman Unfortunately we need to call backs

Re: [PATCH net-next 1/3] bus: mhi: core: Add helper API to return number of free TREs

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 18:16:17 +0100 Loic Poulain wrote: > From: Hemant Kumar > > Introduce mhi_get_free_desc_count() API to return number > of TREs available to queue buffer. MHI clients can use this > API to know before hand if ring is full without calling queue > API. > > Signed-off-by: Hemant

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 15:36:45 +0100 Andrew Lunn wrote: > > +static void ar9331_get_stats64(struct dsa_switch *ds, int port, > > + struct rtnl_link_stats64 *s) > > +{ > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > > + struct ar9331_sw_port *p = &p

Re: [PATCH net-next] net/bridge: fix misspellings using codespell tool

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 20:03:49 -0800 Randy Dunlap wrote: > On 1/7/21 6:53 PM, menglong8.d...@gmail.com wrote: > > From: Menglong Dong > > > > Some typos are found out by codespell tool: > > > > $ codespell ./net/bridge/ > > ./net/bridge/br_stp.c:604: permanant ==> permanent > > ./net/bridge/br_stp

Re: [PATCH net-next 0/4] net: ipa: support COMPILE_TEST

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 17:34:00 -0600 Alex Elder wrote: > This series adds the IPA driver as a possible target when > the COMPILE_TEST configuration is enabled. Two small changes to > dependent subsystems needed to be made for this to work. > > Version 2 of this series adds one more patch, which add

Re: [PATCH] net/ipv6: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'.

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 10:47:34 +0800 Jiapeng Zhong wrote: > The print format of this parameter does not match, because it is defined > as int type, so modify the matching format of this parameter to %d format. > > Signed-off-by: Jiapeng Zhong > Reported-by: Abaci > --- > net/ipv6/proc.c | 2 +- >

Re: [PATCH net v3] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-08 Thread Jakub Kicinski
On Fri, 8 Jan 2021 11:18:39 +0100 Daniel Borkmann wrote: > On 1/8/21 3:28 AM, Dongseok Yi wrote: > > skbs in fraglist could be shared by a BPF filter loaded at TC. If TC > > writes, it will call skb_ensure_writable -> pskb_expand_head to create > > a private linear section for the head_skb. And the

[GIT PULL] Networking for 5.11-rc3

2021-01-07 Thread Jakub Kicinski
e: CT: Use per flow counter when CT flow accounting is enabled - mlx5e: Fix SWP offsets when vlan inserted by driver Misc: - bpf: Fix a task_iter bug caused by a bpf -> net merge conflict resolution And the usual many fixes to various error

Re: [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 12:00:44 -0800 Florian Fainelli wrote: > On 1/7/21 11:58 AM, Aleksander Jan Bajkowski wrote: > > Exclude RMII from modes that report 1 GbE support. Reduced MII supports > > up to 100 MbE. > > > > Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Please make

Re: [PATCH] octeontx2-af: fix memory leak of lmac and lmac->name

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 22:31:30 +0530 Sunil Kovvuri wrote: > On Thu, Jan 7, 2021 at 6:11 PM Colin King wrote: > > > > From: Colin Ian King > > > > Currently the error return paths don't kfree lmac and lmac->name > > leading to some memory leaks. Fix this by adding two error return > > paths that kfr

Re: [PATCH net 2/2] net: ipa: re-enable NAPI before enabling interrupt

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 15:43:25 -0600 Alex Elder wrote: > @@ -743,21 +743,21 @@ static void gsi_channel_freeze(struct gsi_channel > *channel) > set_bit(GSI_CHANNEL_FLAG_STOPPING, channel->flags); > smp_mb__after_atomic(); /* Ensure gsi_channel_poll() sees new value */ > > - napi_dis

Re: [PATCH net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 11:27:29 -0800 Randy Dunlap wrote: > On 1/6/21 11:15 AM, Florian Fainelli wrote: > > All of the OF code that is used has stubbed and will compile and link > > just fine, keeping COMPILE_TEST is enough. > > Yes, that matches my understanding. > > I wish we had a list of which

Re: [PATCH net-next] net: phy: bcm7xxx: Add an entry for BCM72116

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 09:09:44 -0800 Florian Fainelli wrote: > BCM72116 features a 28nm integrated EPHY, add an entry to match this PHY > OUI. > > Signed-off-by: Florian Fainelli net or net-next? Looks like just adding and ID and there is nothing new in net-next in the area AFAICT.

Re: [PATCH v2] docs: octeontx2: tune rst markup

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 17:17:35 +0100 Lukas Bulwahn wrote: > Commit 80b9414832a1 ("docs: octeontx2: Add Documentation for NPA health > reporters") added new documentation with improper formatting for rst, and > caused a few new warnings for make htmldocs in octeontx2.rst:169--202. > > Tune markup and

Re: [PATCH net-next v3 0/7] bcm63xx_enet: major makeover of driver

2021-01-07 Thread Jakub Kicinski
On Wed, 6 Jan 2021 22:42:01 +0800 Sieng Piaw Liew wrote: > This patch series aim to improve the bcm63xx_enet driver by integrating the > latest networking features, i.e. batched rx processing, BQL, build_skb, > etc. > > The newer enetsw SoCs are found to be able to do unaligned rx DMA by adding >

Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-07 Thread Jakub Kicinski
On Thu, 07 Jan 2021 09:13:40 + Alexander Lobakin wrote: > From: Jakub Kicinski > Date: Wed, 6 Jan 2021 16:30:56 -0800 > > > On Wed, 06 Jan 2021 20:40:28 + Alexander Lobakin wrote: > >> 'net_header' is not used outside of this function, so can be

Re: [BUG] from x86: Support kmap_local() forced debugging

2021-01-06 Thread Jakub Kicinski
On Wed, 6 Jan 2021 17:03:48 -0800 Linus Torvalds wrote: > I wonder whether there is other code that "knows" about kmap() only > affecting PageHighmem() pages thing that is no longer true. > > Looking at some other code, skb_gro_reset_offset() looks suspiciously > like it also thinks highmem pages

Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-06 Thread Jakub Kicinski
On Wed, 06 Jan 2021 20:40:28 + Alexander Lobakin wrote: > 'net_header' is not used outside of this function, so can be moved > from BSS onto the stack. > Declarations of one-element arrays are discouraged, and there's no > need to store 'empty' in BSS. Simply allocate it from heap at init. Are

Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2021-01-06 Thread Jakub Kicinski
On Tue, 5 Jan 2021 22:49:17 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > In rvu_mbox_handler_cgx_mac_addr_get() > and rvu_mbox_handler_cgx_mac_addr_set(), > the msg is expected only from PFs that are mapped to CGX LMACs. > It should be checked before mapping, > so we add the is_cg

Re: [PATCH net-next] nfc: Add a virtual nci device driver

2021-01-06 Thread Jakub Kicinski
On Wed, 6 Jan 2021 08:16:47 +0900 Bongsu Jeon wrote: > On Tue, Jan 5, 2021 at 4:48 AM Jakub Kicinski wrote: > > > thank you for your answer. > > > I think that neard(NFC deamon) is necessary to test the NCI subsystem > > > meaningfully. > > > The NCI virtu

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2021-01-06 Thread Jakub Kicinski
On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao@zju.edu.cn wrote: > > I used this one for a test: > > > > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bug...@linux.alibaba.com/ > > > > I'm not getting the Fixes tag when I download the mbo

[GIT PULL] Networking for 5.11-rc3

2021-01-04 Thread Jakub Kicinski
framework does not handle exclusive clock use well, other drivers may reconfigure the second clock Misc: - ppp: change PPPIOCUNBRIDGECHAN ioctl request number to follow existing scheme Signed-off-by: Jaku

Re: [PATCH 5.10 01/63] net/sched: sch_taprio: reset child qdiscs before freeing them

2021-01-04 Thread Jakub Kicinski
t;https://syzkaller.appspot.com/bug?id=f362872379bf8f0017fb667c1ab158f2d1e764ae > >Reported-by: syzbot+8971da381fb5a31f5...@syzkaller.appspotmail.com > >Signed-off-by: Davide Caratti > >Acked-by: Vinicius Costa Gomes > >Link: > >https://lore.kernel.org/r/63b6d79b0e

Re: [PATCH net,stable v2] net: cdc_ncm: correct overhead in delayed_ndp_size

2021-01-04 Thread Jakub Kicinski
On Sun, 3 Jan 2021 22:23:09 +0200 Jouni Seppänen wrote: > if (ctx->drvflags & CDC_NCM_FLAG_NDP_TO_END) > - delayed_ndp_size = ALIGN(ctx->max_ndp_size, > ctx->tx_ndp_modulus); > + delayed_ndp_size = ctx->max_ndp_size + > + max((u32)ctx->tx_ndp_modu

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-04 Thread Jakub Kicinski
On Sun, 3 Jan 2021 03:12:21 +0100 Martin Blumenstingl wrote: > Hi Andrew, > > On Sun, Jan 3, 2021 at 3:09 AM Andrew Lunn wrote: > > > > On Sun, Jan 03, 2021 at 02:25:43AM +0100, Martin Blumenstingl wrote: > > > Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. > > > Without t

Re: [PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Jakub Kicinski
On Mon, 4 Jan 2021 15:18:50 +0100 Andrew Lunn wrote: > On Mon, Jan 04, 2021 at 10:38:02AM +, Charles Keepax wrote: > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > > macb_set_tx_clk were gated on the presence of this flag. > > > > - if (!clk) > > + if (!bp->tx_clk || !(bp->

Re: [PATCH v1] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2021-01-04 Thread Jakub Kicinski
On Tue, 29 Dec 2020 23:24:26 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > In rvu_mbox_handler_cgx_mac_addr_get() and > rvu_mbox_handler_cgx_mac_addr_set(), > the msg is expected only from PFs that are mapped to CGX LMACs. > It should be checked before mapping, so we add the is_cgx

Re: [PATCH] mlx4: style: replace zero-length array with flexible-array member.

2021-01-04 Thread Jakub Kicinski
On Wed, 30 Dec 2020 14:28:51 +0800 YANG LI wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use "flexible array members"[1] for these > cases. The older style of one-element o

Re: [PATCH net-next] nfc: Add a virtual nci device driver

2021-01-04 Thread Jakub Kicinski
On Thu, 31 Dec 2020 14:22:45 +0900 Bongsu Jeon wrote: > On Tue, Dec 29, 2020 at 6:16 AM Jakub Kicinski wrote: > > > > On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote: > > > From: Bongsu Jeon > > > > > > A NCI virtual device can be made to simula

Re: [PATCH] [v2]net:ppp: remove disc_data_lock in ppp line discipline

2021-01-04 Thread Jakub Kicinski
On Fri, 1 Jan 2021 11:37:18 +0800 Gao Yan wrote: > In tty layer, it provides tty->ldisc_sem to protect all tty_ldisc_ops > including ppp_sync_ldisc. So I think tty->ldisc_sem can also > protect tty->disc_data, and the disc_data_lock is not necessary. > > Signed-off-by: Gao Yan Please make sure t

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-30 Thread Jakub Kicinski
On Mon, 28 Dec 2020 16:14:17 -0500 Konstantin Ryabitsev wrote: > On Mon, Dec 28, 2020 at 01:05:26PM -0800, Florian Fainelli wrote: > > On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > > > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > > Konstantin, would you be wi

Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping

2020-12-29 Thread Jakub Kicinski
On Tue, 29 Dec 2020 17:52:56 -0800 Cong Wang wrote: > On Tue, Dec 29, 2020 at 5:39 PM Jakub Kicinski wrote: > > > > On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > &g

Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping

2020-12-29 Thread Jakub Kicinski
On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:78cbac647e61 Merge branch 'ip-faster-in-order-IP-fragments' > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=14df482840 > kernel config:

Re: INFO: task hung in tls_sw_cancel_work_tx

2020-12-29 Thread Jakub Kicinski
On Fri, 07 Feb 2020 15:08:09 -0800 syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:90568ecf Merge tag 'kvm-5.6-2' of git://git.kernel.org/pub.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=16513809e0 > kernel config

Re: memory leak in tls_init

2020-12-29 Thread Jakub Kicinski
On Thu, 26 Sep 2019 18:19:09 -0700 syzbot wrote: > 2019/09/26 13:11:21 executed programs: 23 > BUG: memory leak > unreferenced object 0x88810e482a00 (size 512): >comm "syz-executor.4", pid 6874, jiffies 4295090041 (age 14.090s) >hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00

<    1   2   3   4   5   6   7   8   9   10   >