Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-08 Thread Jakub Kicinski
On Sat, 5 Dec 2020 22:44:08 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > To support jumbo frames, each rx ring dma buffer is 9K in size. > But the chip only stores a single frame per dma buffer. > > When the chip is working with the default 1500 byte MTU, a 9K > dma buffer goes

Re: [PATCH v3 1/7] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 11:24:17 -0600 Mario Limonciello wrote: > On 12/4/20 2:09 PM, Mario Limonciello wrote: > > From: Vitaly Lifshits > > > > Changed a configuration in the flows to align with > > architecture requirements to achieve S0i3.2 substate. > > > > Also fixed a typo in the previous commit

Re: [BUG] iwlwifi: card unusable after firmware crash

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 11:27:50 + Rui Salvaterra wrote: > Hi, everyone, > > I'm running Linux 5.10-rc7 with this firmware/hardware: > > [1.431878] iwlwifi :02:00.0: loaded firmware version > 29.198743027.0 7265D-29.ucode op_mode iwlmvm > [1.431899] iwlwifi :02:00.0: Detected

Re: [PATCH net-next] bonding: set xfrm feature flags more sanely

2020-12-07 Thread Jakub Kicinski
ode. > > Cc: Jay Vosburgh > Cc: Veaceslav Falico > Cc: Andy Gospodarek > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Thomas Davis > Cc: net...@vger.kernel.org > Signed-off-by: Jarod Wilson Applied, thanks!

Re: [PATCH net v1 2/2] net: dsa: microchip: improve port count comments

2020-12-07 Thread Jakub Kicinski
On Tue, 8 Dec 2020 00:31:16 +0100 Andrew Lunn wrote: > On Sat, Dec 05, 2020 at 10:28:14AM -0500, Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > > > Port counts in microchip dsa drivers can be quite confusing: > > on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port, > > yet on

Re: [PATCH] net: stmmac: dwmac-meson8b: fix mask definition of the m250_sel mux

2020-12-07 Thread Jakub Kicinski
On Mon, 07 Dec 2020 10:31:46 +0100 Jerome Brunet wrote: > > The m250_sel mux clock uses bit 4 in the PRG_ETH0 register. Fix this by > > shifting the PRG_ETH0_CLK_M250_SEL_MASK accordingly as the "mask" in > > struct clk_mux expects the mask relative to the "shift" field in the > > same struct. > >

Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 15:04:58 + Ioana Ciornei wrote: > On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote: > > Add an 'of_node_put()' call when a tested device node is not available. > > > > Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > >

Re: [PATCH v3] bridge: Fix a deadlock when enabling multicast snooping

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 10:56:45 +0200 Nikolay Aleksandrov wrote: > On 05/12/2020 01:56, Joseph Huang wrote: > > When enabling multicast snooping, bridge module deadlocks on multicast_lock > > if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2 > > network. > > > > The deadlock

Re: [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-07 Thread Jakub Kicinski
On Sun, 6 Dec 2020 14:27:12 +0100 Aleksander Jan Bajkowski wrote: > This patch allows to use all PHYs on GRX300 and GRX330. The ARX300 has 3 > and the GRX330 has 4 integrated PHYs connected to different ports compared > to VRX200. > > Port configurations: > > xRX200: > GMAC0:

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-07 Thread Jakub Kicinski
On Fri, 4 Dec 2020 19:02:32 +0200 Andra Paraschiv wrote: > diff --git a/include/uapi/linux/vm_sockets.h b/include/uapi/linux/vm_sockets.h > index fd0ed7221645d..46735376a57a8 100644 > --- a/include/uapi/linux/vm_sockets.h > +++ b/include/uapi/linux/vm_sockets.h > @@ -145,7 +145,7 @@ > > struct

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-05 Thread Jakub Kicinski
On Fri, 4 Dec 2020 14:38:03 -0800 Alexander Duyck wrote: > > > The patches look good to me. Just need to address the minor issue that > > > seems to have been present prior to the introduction of this patch > > > set. > > > > > > Reviewed-by: Alexander Duyck > > > > Thanks for your review.

Re: [PATCH] ch_ktls: fix build warning for ipv4-only config

2020-12-05 Thread Jakub Kicinski
On Sun, 6 Dec 2020 00:18:44 +0100 Arnd Bergmann wrote: > > This is for evrey clang build or just W=1+? Would be annoying if clang > > produced this on every build with 5.10 (we need to decide fix vs -next). > > The -Wsometimes-uninitialized is enabled unconditionally for clang, > but this only

Re: [PATCH] octeontx2-pf: Add RSS multi group support

2020-12-05 Thread Jakub Kicinski
On Fri, 4 Dec 2020 14:54:51 +0530 Geetha sowjanya wrote: > Hardware supports 8 RSS groups per interface. Currently we are using > only group '0'. This patch allows user to create new RSS groups/contexts > and use the same as destination for flow steering rules. > > usage: > To steer the traffic

Re: [PATCH net] net: marvell: prestera: Fix error return code in prestera_port_create()

2020-12-05 Thread Jakub Kicinski
On Fri, 4 Dec 2020 16:49:42 +0800 Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family > ASIC devices") > Reported-by: Hulk

sparse annotation for error types?

2020-12-05 Thread Jakub Kicinski
Hi! Recently we've been getting a steady stream of patches from Changzhong to fix missing assignment to error variables before jumping to error cases. I wonder if for new code it'd make sense to add an annotation for a type which has to be returned non-zero? What I have in mind is the following

Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications

2020-12-05 Thread Jakub Kicinski
On Sat, 5 Dec 2020 22:11:39 +0100 Rasmus Villemoes wrote: > > Looks like a nice clean up on a quick look. > > > > Please separate patches 1 and 11 (which are the two bug fixes I see) > > I think patch 2 is a bug fix as well, but I'd like someone from NXP to > comment. Sure, makes sense. > >

Re: [PATCH 11/20] ethernet: ucc_geth: fix use-after-free in ucc_geth_remove()

2020-12-05 Thread Jakub Kicinski
On Sat, 5 Dec 2020 22:04:28 +0100 Rasmus Villemoes wrote: > On 05/12/2020 21.48, Jakub Kicinski wrote: > > On Sat, 5 Dec 2020 20:17:34 +0100 Rasmus Villemoes wrote: > >> - unregister_netdev(dev); > >> - free_netdev(dev); > >>ucc_geth_memclean(ugeth);

Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications

2020-12-05 Thread Jakub Kicinski
On Sat, 5 Dec 2020 20:17:23 +0100 Rasmus Villemoes wrote: > While trying to figure out how to allow bumping the MTU with the > ucc_geth driver, I fell into a rabbit hole and stumbled on a whole > bunch of issues of varying importance - some are outright bug fixes, > while most are a matter of

Re: [PATCH 11/20] ethernet: ucc_geth: fix use-after-free in ucc_geth_remove()

2020-12-05 Thread Jakub Kicinski
On Sat, 5 Dec 2020 20:17:34 +0100 Rasmus Villemoes wrote: > - unregister_netdev(dev); > - free_netdev(dev); > ucc_geth_memclean(ugeth); > if (of_phy_is_fixed_link(np)) > of_phy_deregister_fixed_link(np); > of_node_put(ugeth->ug_info->tbi_node); >

Re: [PATCH net-next] bonding: correct rr balancing during link failure

2020-12-05 Thread Jakub Kicinski
On Wed, 02 Dec 2020 20:55:57 + Lars Everbrand wrote: > This patch updates the sending algorithm for roundrobin to avoid > over-subscribing interface(s) when one or more interfaces in the bond is > not able to send packets. This happened when order was not random and > more than 2 interfaces

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-05 Thread Jakub Kicinski
On Sat, 05 Dec 2020 08:06:40 +0100 Sven Eckelmann wrote: > On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult > wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > Is there some explanation besides

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 22:47:09 +0100 Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] >

Re: [PATCH net-next 2/3] net: hns3: add priv flags support to switch limit promisc mode

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 20:18:55 +0800 Huazhong Tan wrote: > @@ -224,6 +224,7 @@ static int hclge_map_unmap_ring_to_vf_vector(struct > hclge_vport *vport, bool en, > static int hclge_set_vf_promisc_mode(struct hclge_vport *vport, >struct hclge_mbx_vf_to_pf_cmd

Re: [PATCH net-next 3/3] net: hns3: refine the VLAN tag handle for port based VLAN

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 20:18:56 +0800 Huazhong Tan wrote: > tranmist Please spell check the commit messages and comments.

Re: [PATCH] ch_ktls: fix build warning for ipv4-only config

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 23:26:16 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_IPV6 is disabled, clang complains that a variable > is uninitialized for non-IPv4 data: > > drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c:1046:6: error: > variable 'cntrl1' is used

Re: [PATCH net-next v4] net/nfc/nci: Support NCI 2.x initial sequence

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 07:31:47 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > implement the NCI 2.x initial sequence to support NCI 2.x NFCC. > Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed. > If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work. > > In NCI

Re: [PATCH v2] net: bna: remove trailing semicolon in macro definition

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 08:36:22 -0800 t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > Clean up escaped newlines. > > Signed-off-by: Tom Rix Applied, thanks!

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult Thanks for the patches. Please drop the "metux IT consult"

Re: [PATCH net] openvswitch: fix error return code in validate_and_copy_dec_ttl()

2020-12-04 Thread Jakub Kicinski
On Fri, 04 Dec 2020 13:07:48 +0100 Eelco Chaudron wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Changing 'return start' to 'return action_start' can fix this bug. > > > > Fixes: 69929d4c49e1 ("net:

Re: [PATCH net] net: bridge: vlan: fix error return code in __vlan_add()

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 12:47:07 +0200 Nikolay Aleksandrov wrote: > On 04/12/2020 10:48, Zhang Changzhong wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: f8ed289fab84 ("bridge: vlan: use

Re: [PATCH net] ipv4: fix error return code in rtm_to_fib_config()

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 09:04:08 -0700 David Ahern wrote: > On 12/4/20 1:48 AM, Zhang Changzhong wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: d15662682db2 ("ipv4: Allow ipv6 gateway with ipv4 routes") >

Re: [PATCH v2 net-next] nfc: s3fwrn5: skip the NFC bootloader mode

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 10:37:53 +0200 Krzysztof Kozlowski wrote: > On Fri, Dec 04, 2020 at 07:52:57AM +0900, Bongsu Jeon wrote: > > From: Bongsu Jeon > > > > If there isn't a proper NFC firmware image, Bootloader mode will be > > skipped. > > > > Signed-off-by: Bongsu Jeon > > --- > > > >

Re: [PATCH net v1] net: dsa: ksz8795: use correct number of physical ports

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 16:46:45 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > The ksz8795 has five physical ports, but the driver assumes > it has only four. This prevents the driver from working correctly. > > Fix by indicating the correct number of physical ports. > > Fixes:

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 00:20:37 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > A number of ethernet drivers require crc32 functionality to be > avaialable in the kernel, causing a link error otherwise: > Add the missing 'select CRC32' entries in Kconfig for each of them. > > Signed-off-by:

Re: [PATCH net 1/1] net: ipa: pass the correct size when freeing DMA memory

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 17:28:16 -0600 Bjorn Andersson wrote: > > When the coherent memory is freed in gsi_trans_pool_exit_dma(), we > > are mistakenly passing the size of a single element in the pool > > rather than the actual allocated size. Fix this bug. > > > > Fixes: 9dd441e4ed575 ("soc: qcom:

Re: [net-next v4 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 14:05:09 +0100 Andrea Mayer wrote: > This patchset provides support for the SRv6 End.DT4 and End.DT6 (VRF mode) > behaviors. > > The SRv6 End.DT4 behavior is used to implement multi-tenant IPv4 L3 VPNs. It > decapsulates the received packets and performs IPv4 routing lookup in

Re: [PATCH] dpaa_eth: fix build errorr in dpaa_fq_init

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 15:49:21 +0100 Björn Töpel wrote: > On Thu, 3 Dec 2020 at 15:46, Anders Roxell wrote: > > > > When building FSL_DPAA_ETH the following build error shows up: > > > > /tmp/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function > > ‘dpaa_fq_init’: > >

Re: [PATCH] enetc: fix build warning

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 12:18:16 + Claudiu Manoil wrote: > >-Original Message- > >From: Arnd Bergmann > >Sent: Friday, December 4, 2020 12:37 AM > [...] > >Subject: [PATCH] enetc: fix build warning > > > >From: Arnd Bergmann > > > >When CONFIG_OF is disabled, there is a harmless warning

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 14:54:55 +0200 Leon Romanovsky wrote: > Thanks, pulled to mlx5-next > > Jason, Jakob, > > Can you please pull that mlx5-next branch to your trees? > git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git Could you post a PR with a proper description and so on?

Re: [PATCH net v3] bonding: fix feature flag setting at init time

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 22:14:12 -0500 Jarod Wilson wrote: > On Thu, Dec 3, 2020 at 11:50 AM Jakub Kicinski wrote: > > > > On Wed, 2 Dec 2020 19:43:57 -0500 Jarod Wilson wrote: > > > bond_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL | NETIF_F_GSO_UDP_L4; > &

Re: [PATCH] net/mlx5e: fix non-IPV6 build

2020-12-03 Thread Jakub Kicinski
On Fri, 04 Dec 2020 01:20:15 + patchwork-bot+netdev...@kernel.org wrote: > Hello: > > This patch was applied to netdev/net-next.git (refs/heads/master): > > On Fri, 4 Dec 2020 00:12:59 +0100 you wrote: > > From: Arnd Bergmann > > > > When IPv6 is disabled, the flow steering code causes a

Re: [PATCH net-next 1/4] ptp: clockmatrix: reset device and check BOOT_STATUS

2020-12-03 Thread Jakub Kicinski
On Thu, 3 Dec 2020 10:20:16 -0500 min.li...@renesas.com wrote: > From: Min Li > > SM_RESET device only when loading full configuration and check > for BOOT_STATUS. Also remove polling for write trigger done in > _idtcm_settime(). > > Signed-off-by: Min Li Please fix the checkpatch warnings:

Re: [GIT PULL] Networking for 5.10-rc7

2020-12-03 Thread Jakub Kicinski
On Thu, 3 Dec 2020 13:18:13 -0800 Linus Torvalds wrote: > On Thu, Dec 3, 2020 at 12:45 PM Jakub Kicinski wrote: > > Networking fixes for 5.10-rc7, including fixes from bpf, netfilter, > > wireless drivers, wireless mesh and can. > > Thanks, pulled. > > And btw

[GIT PULL] Networking for 5.10-rc7

2020-12-03 Thread Jakub Kicinski
ed-off-by: Jakub Kicinski Antoine Tenart (2): netfilter: bridge: reset skb->pkt_type after NF_INET_POST_ROUTING traversal net: ip6_gre: set dev->hard_header_len when using header_ops Björn Töpel (1): net, xsk:

Re: [PATCH net] net: mvpp2: Fix error return code in mvpp2_open()

2020-12-03 Thread Jakub Kicinski
On Thu, 3 Dec 2020 16:23:46 +0100 Andrew Lunn wrote: > On Thu, Dec 03, 2020 at 10:18:06PM +0800, Wang Hai wrote: > > Fix to return negative error code -ENOENT from invalid configuration > > error handling case instead of 0, as done elsewhere in this function. > > > > Fixes: 4bb043262878 ("net:

Re: [PATCH] bridge: Fix a deadlock when enabling multicast snooping

2020-12-03 Thread Jakub Kicinski
On Tue, 1 Dec 2020 16:40:47 -0500 Joseph Huang wrote: > When enabling multicast snooping, bridge module deadlocks on multicast_lock > if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2 > network. > > The deadlock was caused by the following sequence: While holding the lock,

Re: [PATCH v3 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-03 Thread Jakub Kicinski
On Thu, 3 Dec 2020 18:53:20 +0100 Oleksij Rempel wrote: > On Thu, Dec 03, 2020 at 08:35:17AM -0800, Jakub Kicinski wrote: > > On Thu, 3 Dec 2020 09:50:11 +0100 Oleksij Rempel wrote: > > > @Jakub, > > > > > > > You can't take sleeping locks from .ndo_ge

Re: [PATCH net v3] bonding: fix feature flag setting at init time

2020-12-03 Thread Jakub Kicinski
On Wed, 2 Dec 2020 19:43:57 -0500 Jarod Wilson wrote: > bond_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL | NETIF_F_GSO_UDP_L4; > -#ifdef CONFIG_XFRM_OFFLOAD > - bond_dev->hw_features |= BOND_XFRM_FEATURES; > -#endif /* CONFIG_XFRM_OFFLOAD */ > bond_dev->features |=

Re: [PATCH net v3] bonding: fix feature flag setting at init time

2020-12-03 Thread Jakub Kicinski
m offload setup post-module-load") > Reported-by: Ivan Vecera > Suggested-by: Ivan Vecera > Cc: Jay Vosburgh > Cc: Veaceslav Falico > Cc: Andy Gospodarek > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Thomas Davis > Cc: net...@vger.kernel.org >

Re: [PATCH v3 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-03 Thread Jakub Kicinski
On Thu, 3 Dec 2020 09:50:11 +0100 Oleksij Rempel wrote: > @Jakub, > > > You can't take sleeping locks from .ndo_get_stats64. > > > > Also regmap may sleep? > > > > + ret = regmap_read(priv->regmap, reg, ); > > Yes. And underling layer is mdio bus which is by default sleeping as > well. >

Re: [PATCH v5 net-next 0/4] nfc: s3fwrn5: Support a UART interface

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 20:47:37 +0900 Bongsu Jeon wrote: > S3FWRN82 is the Samsung's NFC chip that supports the UART communication. > Before adding the UART driver module, I did refactoring the s3fwrn5_i2c > module > to reuse the common blocks. Applied, thanks!

Re: [PATCH v2 net-next] net: ipa: fix build-time bug in ipa_hardware_config_qsb()

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 08:15:02 -0600 Alex Elder wrote: > Jon Hunter reported observing a build bug in the IPA driver: > > https://lore.kernel.org/netdev/5b5d9d40-94d5-5dad-b861-fd9bef826...@nvidia.com > > The problem is that the QMB0 max read value set for IPA v4.5 (16) is > too large to fit in

Re: [PATCH net] net: bridge: Fix a warning when del bridge sysfs

2020-12-02 Thread Jakub Kicinski
On Tue, 1 Dec 2020 22:01:14 +0800 Wang Hai wrote: > If adding bridge sysfs fails, br->ifobj will be NULL, there is no > need to delete its non-existent sysfs when deleting the bridge device, > otherwise, it will cause a warning. So, when br->ifobj == NULL, > directly return can fix this bug. > >

Re: [PATCH net-next] octeontx2-af: debugfs: delete dead code

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 12:33:00 +0530 Sunil Kovvuri wrote: > On Wed, Dec 2, 2020 at 12:28 PM Dan Carpenter > wrote: > > These debugfs never return NULL so all this code will never be run. > > > > In the normal case, (and in this case particularly), the debugfs > > functions are not supposed to be

Re: [PATCH v3] NFC: nxp-nci: Make firmware GPIO pin optional

2020-12-02 Thread Jakub Kicinski
On Tue, 1 Dec 2020 12:39:09 +0100 Schrempf Frieder wrote: > From: Frieder Schrempf > > There are other NXP NCI compatible NFC controllers such as the PN7150 > that use an integrated firmware and therefore do not have a GPIO to > select firmware downloading mode. To support this kind of

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 14:03:53 -0500 Jarod Wilson wrote: > On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote: > > > > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > > > + if (bond->dev->reg_state != NETREG_REGISTERED) > > > + got

Re: [PATCH v3 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 15:09:04 +0100 Oleksij Rempel wrote: > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel Ah, I missed the v3 (like most reviewers it seems :)). The sleeping in ndo_get_stats64 question applies.

Re: [PATCH v2 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 13:07:12 +0100 Oleksij Rempel wrote: > +static void ar9331_read_stats(struct ar9331_sw_port *port) > +{ > + mutex_lock(>lock); > + mutex_unlock(>lock); > +} > +static void ar9331_get_stats64(struct dsa_switch *ds, int port, > +struct

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > + if (bond->dev->reg_state != NETREG_REGISTERED) > + goto noreg; > + > if (newval->value == BOND_MODE_ACTIVEBACKUP) > bond->dev->wanted_features |= BOND_XFRM_FEATURES; > else >

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Jakub Kicinski
On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote: > >> + status = netif_rx(skb); > > > > If I'm reading things right this is in process context, so netif_rx_ni() > > > > Is it? The stack looks as follows > > ax88796c_skb_return() > ax88796c_rx_fixup() >

Re: [PATCH v13 0/4] userspace MHI client interface driver

2020-12-01 Thread Jakub Kicinski
On Tue, 1 Dec 2020 13:48:36 -0700 Jeffrey Hugo wrote: > On 12/1/2020 1:03 PM, Jakub Kicinski wrote: > > On Tue, 1 Dec 2020 12:40:50 -0700 Jeffrey Hugo wrote: > >> On 12/1/2020 12:29 PM, Jakub Kicinski wrote: > >>> On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Ku

Re: [PATCH net-next 0/4] net: ipa: IPA v4.5 aggregation and Qtime

2020-12-01 Thread Jakub Kicinski
On Mon, 30 Nov 2020 17:37:08 -0600 Alex Elder wrote: > This series updates some IPA register definitions that change in > substantive ways for IPA v4.5. > > One register defines parameters used by an endpoint to aggregate > multiple packets into a buffer. The size and position of most > fields

Re: [PATCH net-next 2/2] net: ipa: add support for inline checksum offload

2020-12-01 Thread Jakub Kicinski
On Mon, 30 Nov 2020 18:41:43 -0600 Alex Elder wrote: > Starting with IPA v4.5, IP payload checksum offload is implemented > differently. > > Prior to v4.5, the IPA hardware appends an rmnet_map_dl_csum_trailer > structure to each packet if checksum offload is enabled in the > download direction

Re: [PATCH] net: phy: marvell: replace phy_modify()

2020-12-01 Thread Jakub Kicinski
On Mon, 30 Nov 2020 18:41:35 +0800 Yejune Deng wrote: > a set of phy_set_bits() looks more neater > > Signed-off-by: Yejune Deng Looks like that's what those helpers are for so applied to net-next, thanks.

Re: [PATCH v13 0/4] userspace MHI client interface driver

2020-12-01 Thread Jakub Kicinski
On Tue, 1 Dec 2020 12:40:50 -0700 Jeffrey Hugo wrote: > On 12/1/2020 12:29 PM, Jakub Kicinski wrote: > > On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar wrote: > >> This patch series adds support for UCI driver. UCI driver enables userspace > >> clients to communic

Re: [PATCH v13 0/4] userspace MHI client interface driver

2020-12-01 Thread Jakub Kicinski
On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar wrote: > This patch series adds support for UCI driver. UCI driver enables userspace > clients to communicate to external MHI devices like modem and WLAN. UCI driver > probe creates standard character device file nodes for userspace clients to >

Re: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-12-01 Thread Jakub Kicinski
On Tue, 1 Dec 2020 05:23:23 + George Cherian wrote: > > > > You seem to have missed the feedback Saeed and I gave you on v2. > > > > > > > > Did you test this with the errors actually triggering? Devlink > > > > should store only > > > Yes, the same was tested using devlink health test

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-12-01 Thread Jakub Kicinski
On Tue, 1 Dec 2020 09:35:29 +0200 Ido Schimmel wrote: > > Looking at the patch from Marco to move back to a field now I'm > > wondering how you run into this, Ido :D > > > > AFAIU the extension is only added if process as a KCOV handle. > > > > Are you using KCOV? > > Hi Jakub, > > Yes. We

Re: [PATCH] net: wan: remove trailing semicolon in macro definition

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 08:57:34 -0800 t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix This one looks fine, applied, thanks.

Re: [PATCH] net: bna: remove trailing semicolon in macro definition

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 08:55:50 -0800 t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > --- > drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH net-next v3] net/nfc/nci: Support NCI 2.x initial sequence

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 22:36:31 +0900 bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > implement the NCI 2.x initial sequence to support NCI 2.x NFCC. > Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed. > If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work. >

Re: [PATCH 1/2] vxlan: Add needed_headroom for lower device

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 13:52:46 +0100 Sven Eckelmann wrote: > It was observed that sending data via batadv over vxlan (on top of > wireguard) reduced the performance massively compared to raw ethernet or > batadv on raw ethernet. A check of perf data showed that the > vxlan_build_skb was calling all

Re: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 19:32:50 +0530 George Cherian wrote: > Add health reporters for RVU NPA block. > NPA Health reporters handle following HW event groups > - GENERAL events > - ERROR events > - RAS events > - RVU event > An event counter per event is maintained in SW. > > Output: > #

Re: [PATCHv5 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-30 Thread Jakub Kicinski
On Thu, 26 Nov 2020 19:32:49 +0530 George Cherian wrote: > Add devlink support to AF driver. Basic devlink support is added. > Currently info_get is the only supported devlink ops. > > devlink ouptput looks like this > # devlink dev > pci/0002:01:00.0 > # devlink dev info > pci/0002:01:00.0:

Re: [PATCH v5 2/3] net: add kcov handle to skb extensions

2020-11-30 Thread Jakub Kicinski
On Sat, 21 Nov 2020 18:09:41 +0200 Ido Schimmel wrote: > + Florian > > On Thu, Oct 29, 2020 at 05:36:19PM +, Aleksandr Nogikh wrote: > > From: Aleksandr Nogikh > > > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > > code that is not reachable during normal system

Re: [PATCH v2 net-next 1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface

2020-11-30 Thread Jakub Kicinski
On Mon, 30 Nov 2020 21:00:27 +0900 Bongsu jeon wrote: > From: Bongsu Jeon > > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon All patches in the series should have the same version. If the patch was not

Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-28 Thread Jakub Kicinski
On Fri, 27 Nov 2020 20:35:55 +0100 Marc Kleine-Budde wrote: > On 11/27/20 5:27 PM, Jakub Kicinski wrote: > > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote: > >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: > >>> GPIO_ACTIVE_x flags are not corre

Re: [PATCH net-next 0/6] net: ipa: start adding IPA v4.5 support

2020-11-28 Thread Jakub Kicinski
On Wed, 25 Nov 2020 14:45:16 -0600 Alex Elder wrote: > This series starts updating the IPA code to support IPA hardware > version 4.5. > > The first patch fixes a problem found while preparing these updates. > Testing shows the code works with or without the change, and with > the fix the code

Re: [PATCH] powerpc: fix the allyesconfig build

2020-11-28 Thread Jakub Kicinski
On Sat, 28 Nov 2020 16:20:54 +1100 Stephen Rothwell wrote: > On Fri, 27 Nov 2020 17:56:42 -0800 Jakub Kicinski wrote: > > > > What's the offending structure in hisilicon? I'd rather have a look > > packing structs with pointers in 'em sounds questionable. > >

Re: [PATCH v1] net: phy: micrel: fix interrupt handling

2020-11-27 Thread Jakub Kicinski
On Fri, 27 Nov 2020 15:11:08 + Ioana Ciornei wrote: > On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote: > > On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote: > > > After migration to the shared interrupt support, the KSZ8031 PHY with > > > enabled interrupt support

Re: [PATCH] powerpc: fix the allyesconfig build

2020-11-27 Thread Jakub Kicinski
On Sat, 28 Nov 2020 12:28:19 +1100 Stephen Rothwell wrote: > There are 2 drivers that have arrays of packed structures that contain > pointers that end up at unaligned offsets. These produce warnings in > the PowerPC allyesconfig build like this: > > WARNING: 148 bad relocations >

Re: [PATCH net-next v7 0/5] net/x25: netdev event handling

2020-11-27 Thread Jakub Kicinski
On Thu, 26 Nov 2020 07:35:52 +0100 Martin Schiller wrote: > Changes to v6: > o integrated some code styling suggestions by Jakub. > > Changes to v5: > o fix numbering in commit message of patch 2/5. > > Changes to v4: > o also establish layer2 (LAPB) on NETDEV_UP events, if the carrier is >

Re: [PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-27 Thread Jakub Kicinski
On Fri, 27 Nov 2020 20:22:18 +0900 bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > Extract the common phy blocks to reuse it. > The UART module will use the common blocks. > > Signed-off-by: Bongsu Jeon > --- > Changes in v2: > - remove the common function's definition in common header

Re: [PATCH] NFC:Fix Warning: Comparison to bool

2020-11-27 Thread Jakub Kicinski
On Thu, 26 Nov 2020 15:15:42 +0800 Runzhe Wang wrote: > This patch uses the shdlc->rnr variable as a judgment condition of > statement, rather than compares with bool. > > Signed-off-by: Runzhe Wang > Reported-by: Abaci "Fix Warning" sounds like you're addressing a real compiler warning,

Re: [PATCH net-next 5/7] net: hns3: add more info to hns3_dbg_bd_info()

2020-11-27 Thread Jakub Kicinski
On Fri, 27 Nov 2020 16:47:20 +0800 Huazhong Tan wrote: > Since TX hardware checksum and RX completion checksum have been > supported now, so add related information in hns3_dbg_bd_info(). > > Signed-off-by: Huazhong Tan drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:266:22: warning:

Re: [PATCH net-next 1/7] net: hns3: add support for RX completion checksum

2020-11-27 Thread Jakub Kicinski
On Fri, 27 Nov 2020 16:47:16 +0800 Huazhong Tan wrote: > In some cases (for example ip fragment), hardware will > calculate the checksum of whole packet in RX, and setup > the HNS3_RXD_L2_CSUM_B flag in the descriptor, so add > support to utilize this checksum. > > Signed-off-by: Huazhong Tan

[GIT PULL] Networking

2020-11-27 Thread Jakub Kicinski
Signed-off-by: Jakub Kicinski Alexander Duyck (3): tcp: Allow full IP tos/IPv6 tclass to be reflected in L3 header tcp: Set INET_ECN_xmit configuration in tcp_reinit_congestion_control tcp: Set ECT0 bit in tos/tclass

Re: [PATCH 0/8] Rid W=1 warnings in Net

2020-11-27 Thread Jakub Kicinski
On Thu, 26 Nov 2020 13:38:45 + Lee Jones wrote: > Resending the stragglers. > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. This set doesn't apply to net-next, please rebase.

Re: [PATCH v3] lan743x: fix for potential NULL pointer dereference with bare card

2020-11-27 Thread Jakub Kicinski
On Fri, 27 Nov 2020 11:39:41 +0300 Sergej Bauer wrote: > > On Tue, Nov 3, 2020 at 8:41 PM Jakub Kicinski wrote: > > > On Mon, 2 Nov 2020 01:35:55 +0300 Sergej Bauer wrote: > > > > This is the 3rd revision of the patch fix for potential null pointer > >

Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-27 Thread Jakub Kicinski
On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote: > On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > > These are simple defines so they could be used in DTS but they will not > > have the same meaning: > > 1.

Re: [PATCH net-next v3 1/2] lockdep: Introduce in_softirq lockdep assert

2020-11-25 Thread Jakub Kicinski
cs due to the BH > disabled confusion, so add a comment to emphasize that. > > And the softirq context can be interrupted by hard IRQ or NMI > context, lockdep_assert_in_softirq() need to assert about hard > IRQ or NMI context too. > > Suggested-by: Jakub Kicinski > S

Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 15:45:05 -0600 Alex Elder wrote: > On 11/22/20 5:40 PM, Rikard Falkeborn wrote: > > These are only used as input arguments to qmi_handle_init() which > > accepts const pointers to both qmi_ops and qmi_msg_handler. Make them > > const to allow the compiler to put them in

Re: [PATCH net-next v6 2/5] net/lapb: support netdev events

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 10:39:35 +0100 Martin Schiller wrote: > This patch allows layer2 (LAPB) to react to netdev events itself and > avoids the detour via layer3 (X.25). > > 1. Establish layer2 on NETDEV_UP events, if the carrier is already up. > > 2. Call lapb_disconnect_request() on

Re: [PATCH net-next v2] bridge: mrp: Implement LC mode for MRP

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 09:25:25 +0100 Horatiu Vultur wrote: > Extend MRP to support LC mode(link check) for the interconnect port. > This applies only to the interconnect ring. > > Opposite to RC mode(ring check) the LC mode is using CFM frames to > detect when the link goes up or down and based on

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 13:03:30 +0100 Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] >

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 13:03:30 +0100 Łukasz Stelmach wrote: > +static int > +ax88796c_start_xmit(struct sk_buff *skb, struct net_device *ndev) > +{ > + struct ax88796c_device *ax_local = to_ax88796c_device(ndev); > + > + skb_queue_tail(_local->tx_wait_q, skb); > + if

Re: [PATCH net-next] net: switch to storing KCOV handle directly in sk_buff

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 18:34:36 +0100 Marco Elver wrote: > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index ffe3dcc0ebea..070b1077d976 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -233,6 +233,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t > gfp_mask, >

Re: [PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 00:07:56 +0100 Antonio Borneo wrote: > The rtl8211f supports downshift and before commit 5502b218e001 > ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") > the read-back of register MII_CTRL1000 was used to detect the > negotiated link speed. > The code added in

Re: [PATCH net-next v2 0/3] net: ptp: use common defines for PTP message types in further drivers

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 08:44:15 +0100 Christian Eggers wrote: > Changes in v2: > > - resend, as v1 was sent before the prerequisites were merged > - removed mismatch between From: and Signed-off-by: > - [2/3] Reviewed-by: Ido Schimmel > - [3/3] Reviewed-by: Antoine Tenart > - [3/3]

Re: [PATCH] net: stmmac: fix incorrect merge of patch upstream

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 23:37:29 +0100 Antonio Borneo wrote: > Commit 757926247836 ("net: stmmac: add flexible PPS to dwmac > 4.10a") was intended to modify the struct dwmac410_ops, but it got > somehow badly merged and modified the struct dwmac4_ops. > > Revert the modification in struct dwmac4_ops

<    1   2   3   4   5   6   7   8   9   10   >