On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote:
> flow_dissector_key_icmp::id is of type u16 (CPU byteorder),
> ICMP header has its ID field in network byteorder obviously.
> Sparse says:
>
> net/core/flow_dissector.c:178:43: warning: restricted __be16 degrades to
> integer
>
> Conv
On Thu, Oct 15, 2020 at 06:43 AM CEST, John Fastabend wrote:
[...]
> Jakub, any opinions on if we should just throw an error if users try to
> add a sock to a map with a parser but no verdict? At the moment we fall
> through and add the socket, but it wont do any receive parsing/verdict.
> At the
On Mon, Oct 12, 2020 at 07:09 PM CEST, Alex Dewar wrote:
> If bpf_prog_inc_not_zero() fails for skb_parser, then bpf_prog_put() is
> called unconditionally on skb_verdict, even though it may be NULL. Fix
> and tidy up error path.
>
> Addresses-Coverity-ID: 1497799: Null pointer dereferences (FORWAR
er dereferences (FORWARD_NULL)
> Fixes: 743df8b7749f ("bpf, sockmap: Check skb_verdict and skb_parser programs
> explicitly")
> Signed-off-by: Alex Dewar
> ---
Acked-by: Jakub Sitnicki
el codebase uses both __acquires(rcu) and __acquires(RCU).
> I couldn't find any guidance which one is preferred, so I used
> what is easier to type out.
>
> Fixes: 0365351524d7 ("net: Allow iterating sockmap and sockhash")
> Reported-by: kernel test robot
> Signed-off-by: Lorenz Bauer
> ---
Acked-by: Jakub Sitnicki
Describe the purpose of BPF sk_lookup program, how it can be attached, when
it gets invoked, and what information gets passed to it. Point the reader
to examples and further documentation.
Signed-off-by: Jakub Sitnicki
---
Documentation/bpf/index.rst | 1 +
Documentation/bpf
On Wed, Jul 22, 2020 at 05:05 PM CEST, Willem de Bruijn wrote:
> On Wed, Jul 22, 2020 at 11:02 AM Jakub Sitnicki wrote:
>>
>> On Wed, Jul 22, 2020 at 04:42 PM CEST, Kuniyuki Iwashima wrote:
>> > Can I submit a patch to net tree that rewrites udp[46]_lib_lookup2()
On Wed, Jul 22, 2020 at 04:42 PM CEST, Kuniyuki Iwashima wrote:
> Can I submit a patch to net tree that rewrites udp[46]_lib_lookup2() to
> use only 'result' ?
Feel free. That should make the conflict resolution even easier later
on.
Thanks,
-jkbs
On Wed, Jul 22, 2020 at 05:21 AM CEST, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the bpf-next tree got conflicts in:
>
> net/ipv4/udp.c
> net/ipv6/udp.c
>
> between commit:
>
> efc6b6f6c311 ("udp: Improve load balancing for SO_REUSEPORT.")
>
> from the net tree and com
On Mon, Jul 20, 2020 at 09:37 PM CEST, Alexei Starovoitov wrote:
> On Mon, Jul 20, 2020 at 11:49 AM Stephen Rothwell
> wrote:
>>
>> Hi all,
>>
>> On Mon, 20 Jul 2020 08:51:54 -0700 Randy Dunlap
>> wrote:
>> >
>> > on i386 or x86_64:
>> >
>> > # CONFIG_INET is not set
>> > # CONFIG_NET_NS is not
if (err) {
> printf("Failed parser prog detach\n");
> goto out_sockmap;
> }
>
> - err = bpf_prog_detach(map_fd_rx, BPF_SK_SKB_STREAM_VERDICT);
> + err = bpf_prog_detach2(verdict_prog, map_fd_rx,
> BPF_SK_SKB_STREAM_VERDICT);
> if (err) {
> printf("Failed parser prog detach\n");
> goto out_sockmap;
Reviewed-by: Jakub Sitnicki
; @@ -508,6 +505,11 @@ static bool sk_is_udp(const struct sock *sk)
> sk->sk_protocol == IPPROTO_UDP;
> }
>
> +static bool sock_map_redirect_allowed(const struct sock *sk)
> +{
> + return sk_is_tcp(sk) && sk->sk_state != TCP_LISTEN;
> +}
> +
> static bool sock_map_sk_is_suitable(const struct sock *sk)
> {
> return sk_is_tcp(sk) || sk_is_udp(sk);
Acked-by: Jakub Sitnicki
On Fri, May 29, 2020 at 11:05 AM CEST, dihu wrote:
> On 2020/5/27 5:10, John Fastabend wrote:
>> dihu wrote:
>>> From 865a45747de6b68fd02a0ff128a69a5c8feb73c3 Mon Sep 17 00:00:00 2001
>>> From: dihu
>>> Date: Mon, 25 May 2020 17:23:16 +0800
>>> Subject: [PATCH] bpf/sockmap: fix kernel panic at __
On Mon, Mar 04, 2019 at 03:05 PM CET, kernel test robot wrote:
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: 1d79895aef18fa05789995d86d523c9b2ee58a02 ("sk_msg: Always cancel strp
> work before freeing the psock")
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-ne
On Tue, Nov 01, 2016 at 03:35 PM GMT, David Miller wrote:
> From: Jakub Sitnicki
> Date: Tue, 01 Nov 2016 16:13:51 +0100
>
>> On Mon, Oct 31, 2016 at 07:15 PM GMT, David Miller wrote:
>>> From: Jakub Sitnicki
>>> Date: Sun, 30 Oct 2016 14:03:11 +0100
>>&
On Mon, Oct 31, 2016 at 07:25 PM GMT, Tom Herbert wrote:
> On Sun, Oct 30, 2016 at 6:03 AM, Jakub Sitnicki wrote:
>> On Fri, Oct 28, 2016 at 02:25 PM GMT, Tom Herbert wrote:
>>>
>>> If this patch is being done to be compatible with IPv4 I guess that's
>>>
On Mon, Oct 31, 2016 at 07:15 PM GMT, David Miller wrote:
> From: Jakub Sitnicki
> Date: Sun, 30 Oct 2016 14:03:11 +0100
>
>> 2) ensure the flow labels used in both directions are the same (either
>>reflected by one side, or fixed, e.g. not used and set to 0), so that
On Fri, Oct 28, 2016 at 02:25 PM GMT, Tom Herbert wrote:
> On Fri, Oct 28, 2016 at 1:32 AM, Jakub Sitnicki wrote:
>> On Thu, Oct 27, 2016 at 10:35 PM GMT, Tom Herbert wrote:
>>> On Mon, Oct 24, 2016 at 2:28 AM, Jakub Sitnicki wrote:
>>>> Same as for the transmit pat
On Thu, Oct 27, 2016 at 10:35 PM GMT, Tom Herbert wrote:
> On Mon, Oct 24, 2016 at 2:28 AM, Jakub Sitnicki wrote:
>> Same as for the transmit path, let's do our best to ensure that received
>> ICMP errors that may be subject to forwarding will be routed the same
>> path
On Thu, Oct 27, 2016 at 03:25 PM GMT, David Miller wrote:
> From: Jakub Sitnicki
> Date: Mon, 24 Oct 2016 11:28:52 +0200
>
>> +inner_iph = skb_header_pointer(
>> +skb, skb_transport_offset(skb) + sizeof(*icmph),
>> +sizeof(_inner_iph), &
On Thu, Oct 27, 2016 at 03:24 PM GMT, David Miller wrote:
> From: Jakub Sitnicki
> Date: Mon, 24 Oct 2016 11:28:51 +0200
>
>> diff --git a/include/linux/icmpv6.h b/include/linux/icmpv6.h
>> index 57086e9..6282e03 100644
>> --- a/include/linux/icmpv6.h
>> +++ b/i
On Wed, Oct 26, 2016 at 09:32 AM GMT, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c:1557:6: warning: no
> previous prototype for 'rtl8192eu_power_off' [-Wmissing-prototypes]
>
> In fact, this function is only used in th
the
offending IPv6 datagram that triggered the error, rather than the flow
of the ICMP error itself.
Signed-off-by: Jakub Sitnicki
---
include/net/flow.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/net/flow.h b/include/net/flow.h
index 035aa77..73ee3aa 100644
--- a/include/net
Commit 644d0e656958 ("ipv6 Use get_hash_from_flowi6 for rt6 hash") has
turned rt6_info_hash_nhsfn() into a one-liner, so it no longer makes
sense to keep it around.
Also the accompanying documentation comment has become outdated, so just
remove it altogether.
Signed-off-by: Jakub Sitni
label. Otherwise packets from flow in the opposite direction and ICMP
errors will not be routed over the same ECMP link.
Export the function for calculating the multipath hash so that we can
use it also on receive side, when forwarding ICMP errors.
Signed-off-by: Jakub Sitnicki
---
include/linux
Allow our callers to influence the choice of ECMP link by honoring the
hash passed together with the flow info. This will allow for special
treatment of ICMP errors which we would like to route over the same link
as the IP datagram that triggered the error.
Signed-off-by: Jakub Sitnicki
---
net
the client host, with
flow label set, has been run from one of the server hosts. Full test
is available at [1].
-Jakub
[1]
https://github.com/jsitnicki/tools/blob/master/net/tests/ecmp/test-ecmp-icmpv6-error-routing.sh
Jakub Sitnicki (5):
ipv6: Fold rt6_info_hash_nhsfn() into its only caller
Same as for the transmit path, let's do our best to ensure that received
ICMP errors that may be subject to forwarding will be routed the same
path as flow that triggered the error, if it was going in the opposite
direction.
Signed-off-by: Jakub Sitnicki
---
net/ipv6/route.c
On Wed, Sep 28, 2016 at 10:20 PM GMT, Jarod Wilson wrote:
> While looking into an MTU issue with sfc, I started noticing that almost
> every NIC driver with an ndo_change_mtu function implemented almost
> exactly the same range checks, and in many cases, that was the only
> practical thing their nd
The kbuild test robot reports the following build error for
i386-randconfig-c0-09230740:
>> ERROR: "ieee80211_hdrlen" [drivers/staging/rtl8188eu/r8188eu.ko] undefined!
Add a dependency on CFG80211 to fix it.
Signed-off-by: Jakub Sitnicki
---
Same issue has also been reported
show up as a monX network device, which can be used by the
userspace programs for monitoring network traffic.
It is intended as an exploratory/debugging tool for rtl8188eu driver.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/Makefile | 1 +
drivers/staging/rtl8188eu
ore: 43.0 Mbits/sec
after: 41.6 Mbits/sec
[1]
https://lkml.kernel.org/g/1441383439-27007-1-git-send-email-jsitni...@gmail.com
[2] https://github.com/lwfinger/rtl8188eu/issues/73#issuecomment-138588729
Jakub Sitnicki (1):
staging: rtl8188eu: Introduce monitor interface for IEEE 802.11 frames
-email-jsitni...@gmail.com
Jakub Sitnicki (4):
staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants
staging: rtl8188eu: wrap a long if condition and remove extra
parenthesis
staging: rtl8188eu: don't duplicate ieee80211 WLAN_AUTH_* constants
staging: rtl8188eu: do
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index 554c04d..844ed6f 100644
--- a/drivers
linux/ieee80211.h already defines constants for authentication
algorithms. Remove the duplicated definitions.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/include/ieee80211.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h
linux/ieee80211.h already defines constants for information element IDs.
Resolve discrepancies in naming and remove the duplicated definitions.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 2 +-
drivers/staging/rtl8188eu/include/ieee80211.h | 38
linux/ieee80211.h already defines constants for spatial multiplexing
power save modes. Remove the duplicated definitions.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/include/wifi.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
On Sat, Jul 25, 2015 at 04:30 PM CEST, Dan Carpenter
wrote:
> On Sat, Jul 25, 2015 at 04:05:52PM +0200, Jakub Sitnicki wrote:
>> On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman
>> wrote:
>> > On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote:
On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman
wrote:
> On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote:
>> linux/ieee80211.h already defines constants for information element IDs.
>> Include it where needed, resolve discrepancies in naming, and remove th
operators.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 ++-
drivers/staging/rtl8188eu/include/ieee80211.h | 38 --
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 3 +-
3 files changed, 5 insertions(+), 40 deletions(-)
diff
Flag is never set. Remove it and the code that is dead because of it.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/hal/odm.c | 11 --
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 21 --
drivers/staging/rtl8188eu/hal/usb_halinit.c
On Wed, Jun 24, 2015 at 07:23 AM CEST, Jakub Sitnicki
wrote:
> linux/ieee80211.h already defines constants for information element IDs.
> Include it where needed, resolve discrepancies in naming, and remove the
> duplicated definitions.
>
> While at it, wrap a line that was too
On Sat, Jul 18, 2015 at 06:46 AM CEST, Sudip Mukherjee
wrote:
> On Fri, Jul 17, 2015 at 05:33:55PM +0200, Jakub Sitnicki wrote:
>> On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee
>> wrote:
>> > Stop using DBG_88E which is a custom macro for printing debuggin
On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee
wrote:
> Stop using DBG_88E which is a custom macro for printing debugging
> messages. Instead start using pr_debug and in the process define
> pr_fmt.
In the end, don't we want to use netdev_dbg() everywhere where we work
with a struct net_
On Thu, Jul 16, 2015 at 04:04 AM CEST, Sreenath Madasu
wrote:
> This one of the TODO tasks for staging rtl8188eu driver. I have removed
> the code referring to channel > 14 for rtw_ap.c, rtw_ieee80211.c and
> rtw_mlme.c files. Please review.
>
> Signed-off-by: Sreenath Madasu
I would consider r
On Tue, Jul 14, 2015 at 10:04 PM CEST, Mateusz Kulikowski
wrote:
> Remove ack_policy enum and some unused RTL_DEBUG enums.
>
> Signed-off-by: Mateusz Kulikowski
> ---
[snip]
> diff --git a/drivers/staging/rtl8192e/rtllib_debug.h
> b/drivers/staging/rtl8192e/rtllib_debug.h
> index 42e88d6..2f4
RFtype in struct HAL_VERSION duplicates rf_type in struct
hal_data_8188e, and does not change. Remove it and the macros that test
it.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/hal/hal_com.c | 12 +---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 15
Both rtl8188e_read_chip_version() and ReadChipVersion8188E() are used
only in one place. Make ReadChipVersion8188E() a void function and
eliminate its wrapper - rtl8188e_read_chip_version().
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 11 ++-
1
ROM version on RTL8188EU is always 0.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 2 --
drivers/staging/rtl8188eu/include/HalVerDef.h | 2 --
3 files changed, 1 insertion(+), 5 deletions
This field is not used anywhere. Also, kill the rt_regulator_mode enum
which exists just for this field.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 ---
drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 7 ---
2 files changed, 10 deletions
IC type on RTL8188EU is always 8188E. Remove it and all the macros that
check it.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/hal/hal_com.c | 13 +
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 1 -
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2
This series of clean-up patches is a result of a review of
rtl8188e_read_chip_version().
The motivation for getting it in shape is that this function could
serve as read_chip_version function callback in struct rtl_hal_ops,
if this driver gets converted to use rtl_usb (rtlwifi).
Jakub Sitnicki
linux/ieee80211.h already defines constants for capability bits.
Include it where needed, resolve discrepancies in naming, and remove the
duplicated definitions.
Also, make use of WLAN_CAPABILITY_IS_STA_BSS() macro to check if neither
ESS nor IBSS capability bits are set.
Signed-off-by: Jakub
operators.
Signed-off-by: Jakub Sitnicki
---
This patch depends on commit 04fbf979b39b ("rtl8188eu: don't duplicate
ieee80211 constants for status/reason") in staging-next branch.
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 ++-
drivers/staging/rtl8188eu/include/ie
On Thu, Jun 18, 2015 at 10:30 AM CEST, Sudip Mukherjee
wrote:
> On Thu, Jun 18, 2015 at 08:31:59AM +0200, Jakub Sitnicki wrote:
>> Flag is never set. Remove it and the code that is dead because of it.
>>
>> Signed-off-by: Jakub Sitnicki
>> ---
>
>>
>&
Flag is never set. Remove it and the code that is dead because of it.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/hal/odm.c | 11 --
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 21 --
drivers/staging/rtl8188eu/hal/usb_halinit.c
On Mon, Apr 27, 2015 at 07:12 PM CEST, Larry Finger
wrote:
> These drivers do not use mac80211, which is a prerequisite for inclusion in
> the
> regular wifi tree. A complete rewrite will be needed to get them out of
> staging.
> Nonetheless, cleanups are in order.
Regarding the rtl8188eu dr
Also, remove rt_multi_func enum used exclusively by the killed macros.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_hal.h
b/drivers/staging
There is no interface to register PIDs of processes the driver should
send a signal to. Remove it.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/include/drv_types.h | 1 -
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
drivers/staging/rtl8188eu/include
ODE=n:
94c84035d59285408b866a57b442276d r8188eu.o.before
94c84035d59285408b866a57b442276d r8188eu.o.after
Signed-off-by: Jakub Sitnicki
---
Patch generated with more context to hopefully make the review easier.
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 14 +-
drivers/staging/rtl8188eu
__kstrtab___check_region 15 - -15
__ksymtab___check_region 16 - -16
__check_region71 - -71
Signed-off-by: Jakub Sitnicki
---
include/linux/ioport.h | 8
kernel/resource.c | 32
as KEY_F14..18 events.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=52841
Signed-off-by: Jakub Sitnicki
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-microsoft.c | 2 ++
3 files changed, 4 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers
On Fri, Jan 30, 2015 at 01:01 AM CET, Rafael J. Wysocki wrote:
> On Monday, December 22, 2014 11:34:48 PM Rafael J. Wysocki wrote:
>> On Monday, December 22, 2014 12:19:44 PM Jakub Sitnicki wrote:
>> > On Fri, Dec 12, 2014 at 08:47 AM CET, Jakub Sitnicki wrote:
>> >
On Fri, Dec 12, 2014 at 08:47 AM CET, Jakub Sitnicki wrote:
> Rafael J. Wysocki writes:
>
>> On Monday, December 08, 2014 10:01:57 PM Jakub Sitnicki wrote:
>>> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
>>> index 782e822..f980ff7 100644
>>>
Rafael J. Wysocki writes:
> On Monday, December 08, 2014 10:01:57 PM Jakub Sitnicki wrote:
>> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
>> index 782e822..f980ff7 100644
>> --- a/drivers/pnp/resource.c
>> +++ b/drivers/pnp/resource.c
>> @@ -1
PNP core is the last user of the __check_region() which has been
deprecated for almost 12 years (since v2.5.54). Replace it with a combo
of __request_region() followed by __release_region().
pnp_check_port() and pnp_check_mem() remain racy after this change.
Signed-off-by: Jakub Sitnicki
Please ignore the patch sequence number. It is a single patch, not a
part of a series.
Newbie mistake. Please let me know if I should resend the patch.
Thanks,
Jakub
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
Mo
Please ignore the patch sequence number. It is a single patch, not a
part of a series.
Newbie mistake. Please let me know if I should resend the patch.
Thanks,
Jakub
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
Mo
acl.c has not been (directly) using the interface defined by
linux/capability.h header since commit 3bd858ab1c451725c07a
("Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid
check"). Remove it.
Signed-off-by: Jakub Sitnicki
---
fs/ext2/acl.c | 1 -
1 file changed, 1 deletio
acl.c has not been (directly) using the interface defined by
linux/capability.h header since commit 3bd858ab1c451725c07a
("Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid
check"). Remove it.
Signed-off-by: Jakub Sitnicki
---
fs/ext4/acl.c | 1 -
1 file changed, 1 deletio
70 matches
Mail list logo
