Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov wrote: > Hello. > > On 1/23/2015 12:26 PM, Mohammad Jamal wrote: > >> This patch solves the coding style issues such as space after , > > >s/after/before/? > >> and removes the blank lines > > > Extra blank lines, you mean? > >>

Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram wrote: > Hi Mohammad Jamal, > > On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal > wrote: >> This patch solves the coding style issue warning >> by replacing the shifting operations by BIT macro >> >> Signed-off-by: Mohammad Jamal >> --- >>

Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram varkabhad...@gmail.com wrote: Hi Mohammad Jamal, On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal md.jamalmohiud...@gmail.com wrote: This patch solves the coding style issue warning by replacing the shifting operations by BIT macro

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Jamal Mohammad
On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 1/23/2015 12:26 PM, Mohammad Jamal wrote: This patch solves the coding style issues such as space after , s/after/before/? and removes the blank lines Extra blank lines, you mean?

Re: [PATCH] include:linux:Optimizations to __skb_push

2015-01-22 Thread Jamal Mohammad
On Thu, Jan 22, 2015 at 11:54 PM, Eric Dumazet wrote: > On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert wrote: > >> Hmm, this seems less readable to me. What is the effect of this patch? >> Does the compiler even produce different assembly? > > No change at all in generated assembly, this looks

Re: [PATCH] include:linux:Optimizations to __skb_push

2015-01-22 Thread Jamal Mohammad
On Thu, Jan 22, 2015 at 11:54 PM, Eric Dumazet eduma...@google.com wrote: On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert therb...@google.com wrote: Hmm, this seems less readable to me. What is the effect of this patch? Does the compiler even produce different assembly? No change at all in

Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration

2015-01-15 Thread Jamal Mohammad
I think you are write ... checkpatch.pl was giving the error at the line so i added a blank line... i will send an updated patch.. On Thu, Jan 15, 2015 at 11:40 PM, Johan Hovold wrote: > On Thu, Jan 15, 2015 at 06:20:43PM +0100, Linus Walleij wrote: >> On Tue, Jan 13, 2015 at 4:09 PM, Mohammad

Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration

2015-01-15 Thread Jamal Mohammad
I think you are write ... checkpatch.pl was giving the error at the line so i added a blank line... i will send an updated patch.. On Thu, Jan 15, 2015 at 11:40 PM, Johan Hovold jo...@kernel.org wrote: On Thu, Jan 15, 2015 at 06:20:43PM +0100, Linus Walleij wrote: On Tue, Jan 13, 2015 at 4:09