[PATCH 04/25] staging: lustre: libcfs: replace MAX_NUMNODES with nr_node_ids

From: Amir Shehata Replace depricated MAX_NUMNODES with nr_node_ids. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons

[PATCH 14/25] staging: lustre: libcfs: rename i to node for cfs_cpt_set_nodemask

From: Dmitry Eremin Rename variable i to node to make code easier to understand. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin

[PATCH 10/25] staging: lustre: libcfs: provide debugfs files for distance handling

://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/libcfs/module.c | 53 + 1 file changed, 53 insertions(+) diff --git a/drivers/staging/lustre/lnet/libcfs/module.c b/drivers

[PATCH 02/25] staging: lustre: libcfs: rename variable i to cpu

From: Dmitry Eremin Change the name of the variable i used for for_each_cpu() to cpu for code readability. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23303 Reviewed-by: James Simmons Reviewed-by: Doug

[PATCH 16/25] staging: lustre: libcfs: rename cpumask_var_t variables to *_mask

ug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata <amir.sheh...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm..

[PATCH 07/25] staging: lustre: libcfs: NUMA support

..@me.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../staging/lustre/include/linux/libcfs/libcfs_cpu.h | 4 .../lustre/include/linux/libcfs/linux/linux-cpu.h | 2 ++ drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c | 6 ++ drivers/staging/lustre/lnet/

[PATCH 15/25] staging: lustre: libcfs: rename i to cpu for cfs_cpt_bind

Amir Shehata <amir.sheh...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 6 +++--- 1 file changed, 3

[PATCH 16/25] staging: lustre: libcfs: rename cpumask_var_t variables to *_mask

://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../staging/lustre/lnet/libcfs/linux/linux-cpu.c | 62 +++--- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers

[PATCH 07/25] staging: lustre: libcfs: NUMA support

of a particular NUMA node. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs_cpu.h

[PATCH 15/25] staging: lustre: libcfs: rename i to cpu for cfs_cpt_bind

From: Dmitry Eremin Rename variable i to cpu to make code easier to understand. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin

[PATCH 12/25] staging: lustre: libcfs: fix libcfs_cpu coding style

ud.com/23304 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Doug Oucharek <dou...@me.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../lustre/include/linux/libcfs/libcfs_cpu.h | 35 ---

[PATCH 12/25] staging: lustre: libcfs: fix libcfs_cpu coding style

From: Dmitry Eremin This patch bring the lustre CPT code into alignment with the Linux kernel coding style. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23304 Reviewed-by: James Simmons Reviewed-by: Doug

[PATCH 17/25] staging: lustre: libcfs: rename goto label in cfs_cpt_table_print

l.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 17/25] staging: lustre: libcfs: rename goto label in cfs_cpt_table_print

From: Dmitry Eremin Change goto label out to err. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons

[PATCH 18/25] staging: lustre: libcfs: clear up failure patch in cfs_cpt_*_print

mitry.ere...@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata <amir.sheh...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signe

[PATCH 18/25] staging: lustre: libcfs: clear up failure patch in cfs_cpt_*_print

/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions

[PATCH 21/25] staging: lustre: libcfs: report NUMA node instead of just node

rowse/LU-8703 Reviewed-on: https://review.whamcloud.com/23306 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Patrick Farrell <p...@cray.com> Reviewed-by: Olaf Weber <olaf.we...@hpe.com> Reviewed-by: Oleg Drokin <

[PATCH 13/25] staging: lustre: libcfs: use int type for CPT identification.

304 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Doug Oucharek <dou...@me.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h | 2 +- ...

[PATCH 21/25] staging: lustre: libcfs: report NUMA node instead of just node

From: Dmitry Eremin Reporting "HW nodes" is too generic. It really is reporting "HW NUMA nodes". Update the debug message. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23306 Reviewed-by: Jam

[PATCH 13/25] staging: lustre: libcfs: use int type for CPT identification.

From: Dmitry Eremin Use int type for CPT identification to match the linux kernel CPU identification. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23304 Reviewed-by: James Simmons Reviewed-by: Doug Oucharek

[PATCH 19/25] staging: lustre: libcfs: update debug messages

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata <amir.sheh...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James S

[PATCH 19/25] staging: lustre: libcfs: update debug messages

Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 00/25] staging: lustre: libcfs: SMP rework

of just node staging: lustre: libcfs: update debug messages in CPT creation code staging: lustre: libcfs: rework CPU pattern parsing code staging: lustre: libcfs: change CPT estimate algorithm James Simmons (1): staging: lustre: libcfs: merge UMP and SMP libcfs cpu header code .../lustre

[PATCH 23/25] staging: lustre: libcfs: rework CPU pattern parsing code

3306 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9715 Reviewed-on: https://review.whamcloud.com/27872 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Patrick Farrell <p...@cray.com> Reviewed-by: Olaf Weber <olaf.we..

[PATCH 00/25] staging: lustre: libcfs: SMP rework

of just node staging: lustre: libcfs: update debug messages in CPT creation code staging: lustre: libcfs: rework CPU pattern parsing code staging: lustre: libcfs: change CPT estimate algorithm James Simmons (1): staging: lustre: libcfs: merge UMP and SMP libcfs cpu header code .../lustre

[PATCH 23/25] staging: lustre: libcfs: rework CPU pattern parsing code

Signed-off-by: Amir Shehata Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23306 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9715 Reviewed-on: https://review.whamcloud.com/27872 Reviewed-by: James Simmons

[PATCH 22/25] staging: lustre: libcfs: update debug messages in CPT code

ug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23306 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Patrick Farrell <p...@cray.com> Reviewed-by: Olaf Weber <olaf.we...@hpe.com>

[PATCH 25/25] staging: lustre: libcfs: merge UMP and SMP libcfs cpu header code

Currently we have two headers, linux-cpu.h that contains the SMP version and libcfs_cpu.h contains the UMP version. We can simplify the headers into a single header which handles both cases. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/L

[PATCH 22/25] staging: lustre: libcfs: update debug messages in CPT code

://review.whamcloud.com/23306 Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Reviewed-by: Patrick Farrell Reviewed-by: Olaf Weber Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 18 +- 1 file changed, 9

[PATCH 25/25] staging: lustre: libcfs: merge UMP and SMP libcfs cpu header code

Currently we have two headers, linux-cpu.h that contains the SMP version and libcfs_cpu.h contains the UMP version. We can simplify the headers into a single header which handles both cases. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9859 Reviewed-on: https

[PATCH 20/25] staging: lustre: libcfs: make tolerant to offline CPUs and empty NUMA nodes

hamcloud.com/23222 Reviewed-by: Amir Shehata <amir.sheh...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../lustre/include/linux/libcfs/linux/linux-cpu

[PATCH 20/25] staging: lustre: libcfs: make tolerant to offline CPUs and empty NUMA nodes

Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/linux/linux-cpu.h | 2 + .../staging/lustre/lnet/libcfs/linux/linux-cpu.c | 132 + drivers/staging/lustre/lnet/lnet/lib-msg.c | 2 + 3 files changed, 60

[PATCH 24/25] staging: lustre: libcfs: change CPT estimate algorithm

22-239 2 : 36-51,104-119,172-187,240-255 3 : 52-67,120-135,188-203,256-271 Signed-off-by: Dmitry Eremin <dmitry.ere...@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/24304 Reviewed-by: James Simmons <uja.o..

[PATCH 24/25] staging: lustre: libcfs: change CPT estimate algorithm

19,172-187,240-255 3 : 52-67,120-135,188-203,256-271 Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/24304 Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin Signed-off-by: James S

Re: [PATCH 4/6] staging: lustre: rearrange placement of CPU partition management code.

> Currently the code for cpu-partition tables lives in various places. > The non-SMP code is partly in libcfs/libcfs_cpu.h as static inlines, > and partly in lnet/libcfs/libcfs_cpu.c - some of the functions are > tiny and could well be inlines. > > The SMP code is all in

Re: [PATCH 4/6] staging: lustre: rearrange placement of CPU partition management code.

> Currently the code for cpu-partition tables lives in various places. > The non-SMP code is partly in libcfs/libcfs_cpu.h as static inlines, > and partly in lnet/libcfs/libcfs_cpu.c - some of the functions are > tiny and could well be inlines. > > The SMP code is all in

Re: [PATCH 3/6] staging: lustre: remove include/linux/libcfs/linux/linux-cpu.h

> This include file contains definitions used when CONFIG_SMP > is in effect. Other includes contain corresponding definitions > for when it isn't. > This can be hard to follow, so move the definitions to the one place. > > As HAVE_LIBCFS_CPT is defined precisely when CONFIG_SMP, we discard >

Re: [PATCH 3/6] staging: lustre: remove include/linux/libcfs/linux/linux-cpu.h

> This include file contains definitions used when CONFIG_SMP > is in effect. Other includes contain corresponding definitions > for when it isn't. > This can be hard to follow, so move the definitions to the one place. > > As HAVE_LIBCFS_CPT is defined precisely when CONFIG_SMP, we discard >

Re: [PATCH 1/6] staging: lustre: move stack-check macros to libcfs_debug.h

> CDEBUG_STACK() and CHECK_STACK() are macros to help with > debugging, so move them from >drivers/staging/lustre/include/linux/libcfs/linux/libcfs.h > to >drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h > > This seems a more fitting location, and is a step towards > removing

Re: [PATCH 1/6] staging: lustre: move stack-check macros to libcfs_debug.h

> CDEBUG_STACK() and CHECK_STACK() are macros to help with > debugging, so move them from >drivers/staging/lustre/include/linux/libcfs/linux/libcfs.h > to >drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h > > This seems a more fitting location, and is a step towards > removing

Re: [PATCH 2/6] staging: lustre: remove libcfs/linux/libcfs.h

> This include file is only included in one place, > and only contains a list of other include directives. > So just move all those to the place where this file > is included, and discard the file. > > One include directive uses a local name ("linux-cpu.h"), so > that needs to be given a proper

Re: [PATCH 2/6] staging: lustre: remove libcfs/linux/libcfs.h

> This include file is only included in one place, > and only contains a list of other include directives. > So just move all those to the place where this file > is included, and discard the file. > > One include directive uses a local name ("linux-cpu.h"), so > that needs to be given a proper

[PATCH] staging: lustre: libcfs: use dynamic minors for /dev/{lnet,obd}

oud.com/29741 Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Jian Yu <jian...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/include/linux/libcfs/linux/libcfs.h

[PATCH] staging: lustre: libcfs: use dynamic minors for /dev/{lnet,obd}

y: Jian Yu Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/include/linux/libcfs/linux/libcfs.h| 1 - drivers/staging/lustre/include/uapi/linux/lnet/lnetctl.h | 11 --- .../staging/lustre/include/uapi/linux/lustre/lustre_ioctl.h | 2 -- drivers/stag

Re: [PATCH 03/17] staging: lustre: LNET excludes USERIO

> LNET_MINOR and USERIO_MINOR are the same value, so > they cannot both be used in the same kernel. > Until this is resolved, don't allow them to be built > together. This saves automatic testing from noticing this > known problem. Nak. I have the proper fix for this. Will push right away. >

Re: [PATCH 03/17] staging: lustre: LNET excludes USERIO

> LNET_MINOR and USERIO_MINOR are the same value, so > they cannot both be used in the same kernel. > Until this is resolved, don't allow them to be built > together. This saves automatic testing from noticing this > known problem. Nak. I have the proper fix for this. Will push right away. >

Re: [PATCH 17/17] staging: lustre: remove cruft from libcfs/linux/libcfs.h

> These defines are unused or nearly unused, and do not > help at all. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > .../staging/lustre/include/linux/libcfs/curproc.h |2 -- > .../lustre/inclu

Re: [PATCH 17/17] staging: lustre: remove cruft from libcfs/linux/libcfs.h

> These defines are unused or nearly unused, and do not > help at all. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../staging/lustre/include/linux/libcfs/curproc.h |2 -- > .../lustre/include/linux/libcfs/linux/libcfs.h | 17 -

Re: [PATCH 16/17] staging: lustre: discard linux-time.h

> Very little is left in linux-time.h. > Move CFS_TICK to libcfs.h discard the test. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > .../staging/lustre/include/linux/libcfs/libcfs.h |5 ++ > .../lus

Re: [PATCH 16/17] staging: lustre: discard linux-time.h

> Very little is left in linux-time.h. > Move CFS_TICK to libcfs.h discard the test. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../staging/lustre/include/linux/libcfs/libcfs.h |5 ++ > .../lustre/include/linux/libcfs/linux/libcfs.h |1 >

Re: [PATCH 15/17] staging: lustre: discard cfs_time_before_64()

> cfs_time_before_64 is the same as time_before64() > similarly cfs_time_beforeq_64() matsches time_before_eq64() > So just use the standard interfaces. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > .

Re: [PATCH 15/17] staging: lustre: discard cfs_time_before_64()

> cfs_time_before_64 is the same as time_before64() > similarly cfs_time_beforeq_64() matsches time_before_eq64() > So just use the standard interfaces. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../lustre/include/linux/libcfs/linux/l

Re: [PATCH 13/17] staging: lustre: libcfs: remove cfs_timeout_cap()

> This wrapper is only used once, so open-code it as max(). > > This allows us to remove the libcfs_time.h include file. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > .../staging/lustre/include/

Re: [PATCH 13/17] staging: lustre: libcfs: remove cfs_timeout_cap()

> This wrapper is only used once, so open-code it as max(). > > This allows us to remove the libcfs_time.h include file. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../staging/lustre/include/linux/libcfs/libcfs.h |1 > .../lustre/include/linux

Re: [PATCH 11/17] staging: lustre: libcfs: discard cfs_time_shift().

> This function simply multiplies by HZ and adds jiffies. > This is simple enough to be opencoded, and doing so > makes the code easier to read. > > Same for cfs_time_shift_64() Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@su

Re: [PATCH 14/17] staging: lustre: discard cfs_duration_sec()

> cfs_duration_sec() simply divides by HZ. > It is mostly used to report durations in debug messages. > Remove and just use X/HZ. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > .../lustre/include/linux/li

Re: [PATCH 11/17] staging: lustre: libcfs: discard cfs_time_shift().

> This function simply multiplies by HZ and adds jiffies. > This is simple enough to be opencoded, and doing so > makes the code easier to read. > > Same for cfs_time_shift_64() Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../lustre/include/li

Re: [PATCH 14/17] staging: lustre: discard cfs_duration_sec()

> cfs_duration_sec() simply divides by HZ. > It is mostly used to report durations in debug messages. > Remove and just use X/HZ. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../lustre/include/linux/libcfs/linux/linux-time.h |5 - > .../stag

Re: [PATCH 12/17] staging: lustre: libcfs: discard cfs_time_after()

> cfs_time_after() behaves exactly like time_after() > similarly cfs_time_aftereq() matches time_after_eq() > > so discard the cfs versions. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > .../lustre/i

Re: [PATCH 12/17] staging: lustre: libcfs: discard cfs_time_after()

> cfs_time_after() behaves exactly like time_after() > similarly cfs_time_aftereq() matches time_after_eq() > > so discard the cfs versions. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../lustre/include/linux/libcfs/libcfs_time.h | 14 ---

Re: [PATCH 09/17] staging: lustre: cfs_time_current() -> jiffies.

> Discard cfs_time_current() and cfs_time_current64() > and use jiffies and get_jiffies_64() like the rest of the kernel. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > .../lustre/include/linux/libcf

Re: [PATCH 09/17] staging: lustre: cfs_time_current() -> jiffies.

> Discard cfs_time_current() and cfs_time_current64() > and use jiffies and get_jiffies_64() like the rest of the kernel. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../lustre/include/linux/libcfs/libcfs_time.h |2 - > .../lustre/include/linux/

Re: [PATCH 10/17] staging: lustre: libcfs: discard cfs_time_add/sub

ant for seconds). So the time is changed to > "unsigned long". Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > .../lustre/include/linux/libcfs/libcfs_time.h | 12 +- > .../lustre/include/lin

Re: [PATCH 10/17] staging: lustre: libcfs: discard cfs_time_add/sub

ant for seconds). So the time is changed to > "unsigned long". Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../lustre/include/linux/libcfs/libcfs_time.h | 12 +- > .../lustre/include/linux/libcfs/linux/linux-time.h |8 +-- >

Re: [PATCH 08/17] staging: lustre: add container_of_safe()

lidpointer in > surrounding code, > - container_of_safe() when there is no obviously better alternative. It's nice to see this become part of the kernel proper Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > ---

Re: [PATCH 08/17] staging: lustre: add container_of_safe()

lidpointer in > surrounding code, > - container_of_safe() when there is no obviously better alternative. It's nice to see this become part of the kernel proper Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > .../staging/lustre/include/linux/libcfs/libcfs.h

Re: [PATCH 07/17] staging: lustre: ldlm: free resource when ldlm_lock_create() fails.

> ldlm_lock_create() gets a resource, but don't put it on > all failure paths. It should. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > drivers/staging/lustre/lustre/ldlm/ldlm_lock.c |6 +- > 1 fi

Re: [PATCH 07/17] staging: lustre: ldlm: free resource when ldlm_lock_create() fails.

> ldlm_lock_create() gets a resource, but don't put it on > all failure paths. It should. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/ldlm/ldlm_lock.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > &

Re: [PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref()

isn't too uncommon, and will disappear in a future >patch. >Now that the code it together, it becomes apparent that >we are dropping a ref on the namespace *before* the last >use. So keep the ref until after. Reviewed-by: James Simmons <jsimm...@infradead.org&

Re: [PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref()

isn't too uncommon, and will disappear in a future >patch. >Now that the code it together, it becomes apparent that >we are dropping a ref on the namespace *before* the last >use. So keep the ref until after. Reviewed-by: James Simmons > Signed-off-by: NeilBrown

Re: [PATCH 05/17] staging: lustre: remove unneeded include.

> cfs_hash usage was removed from cl_object.c > some time ago, so remove the #include as well. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > drivers/staging/lustre/lustre/obdclass/cl_object.c |1 - &g

Re: [PATCH 05/17] staging: lustre: remove unneeded include.

> cfs_hash usage was removed from cl_object.c > some time ago, so remove the #include as well. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/obdclass/cl_object.c |1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH 02/17] staging: lustre: remove unused ldlm_completion_ast_async()

> This function is unused. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > drivers/staging/lustre/lustre/include/lustre_dlm.h |1 - > drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 23 > -

Re: [PATCH 02/17] staging: lustre: remove unused ldlm_completion_ast_async()

> This function is unused. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/include/lustre_dlm.h |1 - > drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 23 > > 2 files changed, 24 deletio

Re: [PATCH 01/17] staging: lustre: remove invariant in cl_io_read_ahead()

> This invariant can fail as ci_type is somtimes CIS_INIT. > > According to Jinshan Xiong, or of the most recent significant > change to this code, "We should get rid of it." > > So do that. Reviewed-by: James Simmons <jsimm...@infradead.org> > Fixes:

Re: [PATCH 01/17] staging: lustre: remove invariant in cl_io_read_ahead()

> This invariant can fail as ci_type is somtimes CIS_INIT. > > According to Jinshan Xiong, or of the most recent significant > change to this code, "We should get rid of it." > > So do that. Reviewed-by: James Simmons > Fixes: 1e1db2a97be5 ("stag

Re: [PATCH 04/17] staging: lustre: remove unused hash tables.

> exp_lock_hash and exp_flock_hash are unused in > the client, so remove all references. > > Also remove unused hashtable size definitions. Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > driv

Re: [PATCH 04/17] staging: lustre: remove unused hash tables.

> exp_lock_hash and exp_flock_hash are unused in > the client, so remove all references. > > Also remove unused hashtable size definitions. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/include/lustre_dlm.h | 10 ---

Re: [PATCH 2/3] staging: lustre: lmv: correctly iput lmo_root

t unmount. > > Fixes: 8f18c8a48b73 ("staging: lustre: lmv: separate master object with > master stripe") > Signed-off-by: NeilBrown <ne...@suse.com> Reviewed-by: James Simmons <jsimm...@infradead.org> > --- > drivers/staging/lustre/lustre/lmv/lmv_obd.c |

Re: [PATCH 3/3] staging: lustre: lnet/selftest: don't ignore status from lstcon_test_add

> If lstcon_test_add sets 'ret' (passed by reference) to 1, > then lst_test_add_ioctl() ignores the return value. > This isn't justified - the return value must be zero for 'ret' > to be meaningful. > > Signed-off-by: NeilBrown <ne...@suse.com> Reviewed-by: James Simmons

Re: [PATCH 3/3] staging: lustre: lnet/selftest: don't ignore status from lstcon_test_add

> If lstcon_test_add sets 'ret' (passed by reference) to 1, > then lst_test_add_ioctl() ignores the return value. > This isn't justified - the return value must be zero for 'ret' > to be meaningful. > > Signed-off-by: NeilBrown Reviewed-by: James Simmons > --- > dri

Re: [PATCH 2/3] staging: lustre: lmv: correctly iput lmo_root

t unmount. > > Fixes: 8f18c8a48b73 ("staging: lustre: lmv: separate master object with > master stripe") > Signed-off-by: NeilBrown Reviewed-by: James Simmons > --- > drivers/staging/lustre/lustre/lmv/lmv_obd.c |2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH 1/3] staging: lustre: lov: use correct env in lov_io_data_version_end()

sub_env, much like > other code in the same file. > > Fixes: f0cf21ab ("staging: lustre: clio: add CIT_DATA_VERSION and remove > IOC_LOV_GETINFO") > Signed-off-by: NeilBrown <ne...@suse.com> Reviewed-by: James Simmons <jsimm...@infradead.org> > --- >

Re: [PATCH 1/3] staging: lustre: lov: use correct env in lov_io_data_version_end()

sub_env, much like > other code in the same file. > > Fixes: f0cf21ab ("staging: lustre: clio: add CIT_DATA_VERSION and remove > IOC_LOV_GETINFO") > Signed-off-by: NeilBrown Reviewed-by: James Simmons > --- > drivers/staging/lustre/lustre/lov/lov_io.c |2 +- >

Re: [PATCH] staging: lustre: update the TODO list

> On Sun, 2018-02-11 at 18:00 -0500, James Simmons wrote: > > As more people become involved with the progression of the lustre > > client it needs to more clear what needs to be done to leave > > staging. Update the TODO list with the various bugs and changes > &g

Re: [PATCH] staging: lustre: update the TODO list

> On Sun, 2018-02-11 at 18:00 -0500, James Simmons wrote: > > As more people become involved with the progression of the lustre > > client it needs to more clear what needs to be done to leave > > staging. Update the TODO list with the various bugs and changes > &g

[PATCH] staging: lustre: update the TODO list

of code. Some even cover updating the user land utilities to meet the kernel requirements. Several bugs have already been addressed and just need to be pushed to the staging tree. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/TODO

[PATCH] staging: lustre: update the TODO list

of code. Some even cover updating the user land utilities to meet the kernel requirements. Several bugs have already been addressed and just need to be pushed to the staging tree. Signed-off-by: James Simmons --- drivers/staging/lustre/TODO | 310 ++-- 1

Re: [PATCH] staging: lustre: lnet: return of an error code should be negative

> Return value of error codes should typically be negative. > Issue reported by checkpatch.pl > Reviewed-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> > --- > drivers/staging/lustre/lnet/selftest/framework

Re: [PATCH] staging: lustre: lnet: return of an error code should be negative

> Return value of error codes should typically be negative. > Issue reported by checkpatch.pl > Reviewed-by: James Simmons > Signed-off-by: Sumit Pundir > --- > drivers/staging/lustre/lnet/selftest/framework.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] staging: lustre: llite: replace variable length array

> On 01/30/2018 03:04 AM, Dilger, Andreas wrote: > > On Jan 27, 2018, at 14:42, Sven Dziadek wrote: > >> > >> The functionality of the removed variable length array is already > >> implemented by the function xattr_full_name in fs/xattr.c > >> > >> This fixes the sparse

Re: [PATCH] staging: lustre: llite: replace variable length array

> On 01/30/2018 03:04 AM, Dilger, Andreas wrote: > > On Jan 27, 2018, at 14:42, Sven Dziadek wrote: > >> > >> The functionality of the removed variable length array is already > >> implemented by the function xattr_full_name in fs/xattr.c > >> > >> This fixes the sparse warning: > >> warning:

Re: [PATCH 3.16 002/136] staging: lustre: ptlrpc: kfree used instead of kvfree

> 3.16.54-rc1 review patch. If anyone has any objections, please let me know. Reviewed-by: James Simmons <jsimm...@infradead.org> > -- > > From: Nadav Amit <na...@vmware.com> > > commit c3eec59659cf25916647d2178c541302bb4822ad upstream. >

Re: [PATCH 3.16 002/136] staging: lustre: ptlrpc: kfree used instead of kvfree

> 3.16.54-rc1 review patch. If anyone has any objections, please let me know. Reviewed-by: James Simmons > -- > > From: Nadav Amit > > commit c3eec59659cf25916647d2178c541302bb4822ad upstream. > > rq_reqbuf is allocated using kvmalloc() but

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> > +static inline bool > > +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md > > *lsm2) > > +{ > > + int idx; > > + > > + if (lsm1->lsm_md_magic != lsm2->lsm_md_magic || > > + lsm1->lsm_md_stripe_count != lsm2->lsm_md_stripe_count || > > +

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> > +static inline bool > > +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md > > *lsm2) > > +{ > > + int idx; > > + > > + if (lsm1->lsm_md_magic != lsm2->lsm_md_magic || > > + lsm1->lsm_md_stripe_count != lsm2->lsm_md_stripe_count || > > +

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> > On Feb 8, 2018, at 10:10 PM, NeilBrown <ne...@suse.com> wrote: > > > > On Thu, Feb 08 2018, Oleg Drokin wrote: > > > >>> On Feb 8, 2018, at 8:39 PM, NeilBrown <ne...@suse.com> wrote: > >>> > >>> On

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

> > On Feb 8, 2018, at 10:10 PM, NeilBrown wrote: > > > > On Thu, Feb 08 2018, Oleg Drokin wrote: > > > >>> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: > >>> > >>> On Tue, Aug 16 2016, James Simmons wrote: > >> > >&

Re: [PATCH] staging: lustre: lnet: avoid uninitialized return value

ized in this function [-Werror=maybe-uninitialized] > > A failure from alloc_ordered_workqueue() tends to indicate an > out-of-memory condition, so return -ENOMEM in both cases. > The second error path was a preexisting bug, where we always > returned zero after a kvmalloc_array()

Re: [PATCH] staging: lustre: lnet: avoid uninitialized return value

ized in this function [-Werror=maybe-uninitialized] > > A failure from alloc_ordered_workqueue() tends to indicate an > out-of-memory condition, so return -ENOMEM in both cases. > The second error path was a preexisting bug, where we always > returned zero after a kvmalloc_array()

<    1   2   3   4   5   6   7   8   9   10   >