[PATCH 44/64] staging: lustre: uapi: remove BIT macro from UAPI headers

2017-08-14 Thread James Simmons
The BIT macro is not available for UAPI headers so remove it from the lustre UAPI headers. Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../lustre/include/uapi/linux/lustre/lustre_idl.h | 38 +++--- .../lustre/include/uapi/linux/lustre/lustre_user.h | 12 +++-

[PATCH 44/64] staging: lustre: uapi: remove BIT macro from UAPI headers

2017-08-14 Thread James Simmons
The BIT macro is not available for UAPI headers so remove it from the lustre UAPI headers. Signed-off-by: James Simmons --- .../lustre/include/uapi/linux/lustre/lustre_idl.h | 38 +++--- .../lustre/include/uapi/linux/lustre/lustre_user.h | 12 +++ 2 files changed, 25

[PATCH 40/64] staging: lustre: uapi: remove libcfs.h from lustre_id.h/lustre_user.h

2017-08-14 Thread James Simmons
These are the last UAPI headers that contain libcfs.h which is internal kernel header. Since it is not available to user land remove libcfs.h and add the need headers that libcfs.h provided. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/L

[PATCH 40/64] staging: lustre: uapi: remove libcfs.h from lustre_id.h/lustre_user.h

2017-08-14 Thread James Simmons
These are the last UAPI headers that contain libcfs.h which is internal kernel header. Since it is not available to user land remove libcfs.h and add the need headers that libcfs.h provided. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https

[PATCH 45/64] staging: lustre: fid: add include path to Makefile

2017-08-14 Thread James Simmons
Start to rationalize include paths in the fid source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/fid/Makefile | 3 +++ drivers/staging/lustre/lustre/fid/fid_internal.h | 4 ++-- drivers/staging/lustre/lustre/fid/fid_lib.c

[PATCH 45/64] staging: lustre: fid: add include path to Makefile

2017-08-14 Thread James Simmons
Start to rationalize include paths in the fid source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/fid/Makefile | 3 +++ drivers/staging/lustre/lustre/fid/fid_internal.h | 4 ++-- drivers/staging/lustre/lustre/fid/fid_lib.c | 4 ++-- drivers/staging

[PATCH 47/64] staging: lustre: ptlrpc: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the ptlrpc/ldlm source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/ldlm/interval_tree.c | 6 +++--- drivers/staging/lustre/lustre/ldlm/l_lock.c | 6 +++--- drivers/staging/lustre/lustr

[PATCH 47/64] staging: lustre: ptlrpc: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the ptlrpc/ldlm source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/ldlm/interval_tree.c | 6 +++--- drivers/staging/lustre/lustre/ldlm/l_lock.c | 6 +++--- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 12

[PATCH 43/64] staging: lustre: uapi: use proper byteorder functions in lustre_idl.h

2017-08-14 Thread James Simmons
In order for lustre_idl.h to be usable for both user land and kernel space it has to use the proper byteorder functions. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: http://review.whamcloud.com/16916 Reviewed-by:

[PATCH 43/64] staging: lustre: uapi: use proper byteorder functions in lustre_idl.h

2017-08-14 Thread James Simmons
In order for lustre_idl.h to be usable for both user land and kernel space it has to use the proper byteorder functions. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: http://review.whamcloud.com/16916 Reviewed-by: Frank Zago Reviewed

[PATCH 49/64] staging: lustre: lmv: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the lmv source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/lmv/Makefile | 3 +++ drivers/staging/lustre/lustre/lmv/lmv_fld.c | 14 +++--- drivers/staging/lustre/lustre/lmv/lmv_intent.c

[PATCH 49/64] staging: lustre: lmv: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the lmv source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/lmv/Makefile | 3 +++ drivers/staging/lustre/lustre/lmv/lmv_fld.c | 14 +++--- drivers/staging/lustre/lustre/lmv/lmv_intent.c | 16

[PATCH 46/64] staging: lustre: fld: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the fld source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/fld/Makefile | 3 +++ drivers/staging/lustre/lustre/fld/fld_cache.c| 16 drivers/staging/lustre/lustre/fld/fld_inte

[PATCH 46/64] staging: lustre: fld: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the fld source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/fld/Makefile | 3 +++ drivers/staging/lustre/lustre/fld/fld_cache.c| 16 drivers/staging/lustre/lustre/fld/fld_internal.h | 8 drivers

[PATCH 50/64] staging: lustre: lov: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the lov source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/lov/Makefile | 3 ++ .../staging/lustre/lustre/lov/lov_cl_internal.h| 6 ++-- drivers/staging/lustre/lustre/lov/lov_dev.c

[PATCH 50/64] staging: lustre: lov: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the lov source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/lov/Makefile | 3 ++ .../staging/lustre/lustre/lov/lov_cl_internal.h| 6 ++-- drivers/staging/lustre/lustre/lov/lov_dev.c| 2 +- drivers/staging/lustre

[PATCH 48/64] staging: lustre: llite: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the llite source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/llite/Makefile | 3 ++ drivers/staging/lustre/lustre/llite/dcache.c | 6 ++-- drivers/staging/lustre/lustre/llite/dir.c

[PATCH 48/64] staging: lustre: llite: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the llite source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/Makefile | 3 ++ drivers/staging/lustre/lustre/llite/dcache.c | 6 ++-- drivers/staging/lustre/lustre/llite/dir.c | 16 +- drivers

[PATCH 52/64] staging: lustre: mgc: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the mgc source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/mgc/Makefile | 3 +++ drivers/staging/lustre/lustre/mgc/lproc_mgc.c| 4 ++-- drivers/staging/lustre/lustre/mgc/mgc_internal.

[PATCH 52/64] staging: lustre: mgc: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the mgc source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/mgc/Makefile | 3 +++ drivers/staging/lustre/lustre/mgc/lproc_mgc.c| 4 ++-- drivers/staging/lustre/lustre/mgc/mgc_internal.h | 10 +- drivers/staging

[PATCH 51/64] staging: lustre: mdc: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the mdc source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/mdc/Makefile | 3 +++ drivers/staging/lustre/lustre/mdc/lproc_mdc.c| 4 ++-- drivers/staging/lustre/lustre/mdc/mdc_internal.

[PATCH 51/64] staging: lustre: mdc: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the mdc source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/mdc/Makefile | 3 +++ drivers/staging/lustre/lustre/mdc/lproc_mdc.c| 4 ++-- drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 +- drivers/staging/lustre/lustre

[PATCH 53/64] staging: lustre: obdclass: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the obdclass source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/obdclass/Makefile | 3 +++ drivers/staging/lustre/lustre/obdclass/cl_io.c | 8 drivers/staging/lustre/lustre/ob

[PATCH 53/64] staging: lustre: obdclass: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the obdclass source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/obdclass/Makefile | 3 +++ drivers/staging/lustre/lustre/obdclass/cl_io.c | 8 drivers/staging/lustre/lustre/obdclass/cl_lock.c | 8

[PATCH 55/64] staging: lustre: osc: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the osc source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/osc/Makefile | 3 ++ drivers/staging/lustre/lustre/osc/lproc_osc.c | 6 ++-- .../staging/lustre/lustre/osc/osc_cl_internal.h

[PATCH 55/64] staging: lustre: osc: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the osc source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/osc/Makefile | 3 ++ drivers/staging/lustre/lustre/osc/lproc_osc.c | 6 ++-- .../staging/lustre/lustre/osc/osc_cl_internal.h| 6 ++-- drivers/staging/lustre

[PATCH 56/64] staging: lustre: lustre: cleanup paths for lustre internal headers

2017-08-14 Thread James Simmons
Rationalize include paths for the lustre internal headers Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/include/cl_object.h | 4 ++-- drivers/staging/lustre/lustre/include/llog_swab.h | 2 +- .../staging/lustre/lustre/include/lprocfs_status.

[PATCH 56/64] staging: lustre: lustre: cleanup paths for lustre internal headers

2017-08-14 Thread James Simmons
Rationalize include paths for the lustre internal headers Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/include/cl_object.h | 4 ++-- drivers/staging/lustre/lustre/include/llog_swab.h | 2 +- .../staging/lustre/lustre/include/lprocfs_status.h | 6 ++--- drivers/staging

[PATCH 57/64] staging: lustre: lustre: cleanup paths for lustre UAPI headers

2017-08-14 Thread James Simmons
Rationalize include paths for the lustre uapi headers Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/include/uapi/linux/lustre/lustre_cfg.h | 2 +- drivers/staging/lustre/include/uapi/linux/lustre/lustre_fid.h | 2 +- drivers/staging/lustre/includ

[PATCH 57/64] staging: lustre: lustre: cleanup paths for lustre UAPI headers

2017-08-14 Thread James Simmons
Rationalize include paths for the lustre uapi headers Signed-off-by: James Simmons --- drivers/staging/lustre/include/uapi/linux/lustre/lustre_cfg.h | 2 +- drivers/staging/lustre/include/uapi/linux/lustre/lustre_fid.h | 2 +- drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h

[PATCH 59/64] staging: lustre: lnet: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the lnet core source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/lnet/Makefile | 3 +++ drivers/staging/lustre/lnet/lnet/acceptor.c| 2 +- drivers/staging/lustre/lnet/lnet/api-ni.c | 4 ++-- d

[PATCH 59/64] staging: lustre: lnet: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the lnet core source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/Makefile | 3 +++ drivers/staging/lustre/lnet/lnet/acceptor.c| 2 +- drivers/staging/lustre/lnet/lnet/api-ni.c | 4 ++-- drivers/staging/lustre/lnet/lnet

[PATCH 54/64] staging: lustre: obdecho: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the obdecho source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/obdecho/Makefile | 3 +++ .../staging/lustre/lustre/obdecho/echo_client.c| 24 +++--- 2 files changed, 15 insertions(

[PATCH 54/64] staging: lustre: obdecho: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the obdecho source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/obdecho/Makefile | 3 +++ .../staging/lustre/lustre/obdecho/echo_client.c| 24 +++--- 2 files changed, 15 insertions(+), 12 deletions(-) diff

[PATCH 60/64] staging: lustre: ko2iblnd: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the ko2iblnd source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/klnds/o2iblnd/Makefile | 3 +++ drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-)

[PATCH 60/64] staging: lustre: ko2iblnd: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the ko2iblnd source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/klnds/o2iblnd/Makefile | 3 +++ drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 58/64] staging: lustre: lnet: selftest: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the lnet selftest source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/selftest/Makefile | 3 +++ drivers/staging/lustre/lnet/selftest/conctl.c | 6 +++--- drivers/staging/lustre/lnet/selftest/conrpc.c

[PATCH 58/64] staging: lustre: lnet: selftest: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the lnet selftest source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/Makefile | 3 +++ drivers/staging/lustre/lnet/selftest/conctl.c | 6 +++--- drivers/staging/lustre/lnet/selftest/conrpc.c | 4 ++-- drivers/staging

[PATCH 61/64] staging: lustre: ksocklnd: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the ksocklnd source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/klnds/socklnd/Makefile | 3 +++ drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 +++--- 2 files changed, 6 insertions(+), 3 del

[PATCH 64/64] staging: lustre: lnet: cleanup paths for all LNet headers

2017-08-14 Thread James Simmons
Rationalize include paths in all the lnet header files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/include/linux/lnet/api.h | 2 +- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 14 +++--- drivers/staging/lustre/include

[PATCH 61/64] staging: lustre: ksocklnd: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the ksocklnd source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/klnds/socklnd/Makefile | 3 +++ drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 64/64] staging: lustre: lnet: cleanup paths for all LNet headers

2017-08-14 Thread James Simmons
Rationalize include paths in all the lnet header files. Signed-off-by: James Simmons --- drivers/staging/lustre/include/linux/lnet/api.h | 2 +- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 14 +++--- drivers/staging/lustre/include/linux/lnet/lib-types.h

[PATCH 62/64] staging: lustre: libcfs: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the libcfs source code files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/Makefile| 3 +++ drivers/staging/lustre/lnet/libcfs/debug.c | 2 +- drivers/staging/lustre/lnet/libcfs/

[PATCH 62/64] staging: lustre: libcfs: add include path to Makefile

2017-08-14 Thread James Simmons
Rationalize include paths in the libcfs source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/libcfs/Makefile| 3 +++ drivers/staging/lustre/lnet/libcfs/debug.c | 2 +- drivers/staging/lustre/lnet/libcfs/fail.c | 2

[PATCH 63/64] staging: lustre: libcfs: cleanup paths for libcfs headers

2017-08-14 Thread James Simmons
Rationalize include paths in all the libcfs header files. Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../staging/lustre/include/linux/libcfs/libcfs.h | 24 +++--- .../lustre/include/linux/libcfs/libcfs_debug.h | 2 +- 2 files changed, 13 insertions(

[PATCH 63/64] staging: lustre: libcfs: cleanup paths for libcfs headers

2017-08-14 Thread James Simmons
Rationalize include paths in all the libcfs header files. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h | 24 +++--- .../lustre/include/linux/libcfs/libcfs_debug.h | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH 32/64] staging: lustre: libcfs: remove LOGL and LOGU macros

2017-08-14 Thread James Simmons
The macro LOGU is not used anymore and LOGL is used in one place. No reason to keep LOGL around anymore. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/22138 Reviewed-by: Dmitry

[PATCH 32/64] staging: lustre: libcfs: remove LOGL and LOGU macros

2017-08-14 Thread James Simmons
The macro LOGU is not used anymore and LOGL is used in one place. No reason to keep LOGL around anymore. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/22138 Reviewed-by: Dmitry Eremin Reviewed-by: Jinshan Xiong

[PATCH 07/64] staging: lustre: uapi: remove userland version of obd_ioctl_*()

2017-08-14 Thread James Simmons
The header lustre_ioctl.h has both kernel and user space versions of obd_ioctl_*() functions. Lets remove the user land version which have been integrated into the lustre tools. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Re

[PATCH 05/64] staging: lustre: uapi: move lu_fid, ost_id funcs out of lustre_idl.h

2017-08-14 Thread James Simmons
Remove the debug macros and properly handle the returned error codes. Place both UAPI headers lustre_fid.h and lustre_ostid.h into the uapi directory. Signed-off-by: Ben Evans <bev...@cray.com> Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.

[PATCH 07/64] staging: lustre: uapi: remove userland version of obd_ioctl_*()

2017-08-14 Thread James Simmons
The header lustre_ioctl.h has both kernel and user space versions of obd_ioctl_*() functions. Lets remove the user land version which have been integrated into the lustre tools. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https

[PATCH 05/64] staging: lustre: uapi: move lu_fid, ost_id funcs out of lustre_idl.h

2017-08-14 Thread James Simmons
and properly handle the returned error codes. Place both UAPI headers lustre_fid.h and lustre_ostid.h into the uapi directory. Signed-off-by: Ben Evans Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/22712 Reviewed

Re: [PATCH] staging: lustre: mgc: fix potential use after free in error path

2017-08-14 Thread James Simmons
cld->cld_recover = recover_cld; > } > > - if (!locked) > - mutex_lock(>cld_lock); > + mutex_lock(>cld_lock); > + cld->cld_recover = recover_cld; > cld->cld_params = params_cld; > cld->cld_sptlrpc = sptlrpc_cld; > mutex_unlock(>cld_lock); > -- > 2.7.4 Reviewed-by: James Simmons <jsimm...@infradead.org>

Re: [PATCH] staging: lustre: mgc: fix potential use after free in error path

2017-08-14 Thread James Simmons
d_recover = recover_cld; > } > > - if (!locked) > - mutex_lock(>cld_lock); > + mutex_lock(>cld_lock); > + cld->cld_recover = recover_cld; > cld->cld_params = params_cld; > cld->cld_sptlrpc = sptlrpc_cld; > mutex_unlock(>cld_lock); > -- > 2.7.4 Reviewed-by: James Simmons

Re: [PATCH] staging: lustre: lnet: fix incorrect arguments order calling lstcon_session_new

2017-08-14 Thread James Simmons
> From: Colin Ian King > > The arguments args->lstio_ses_force and args->lstio_ses_timeout are > in the incorrect order. Fix this by swapping them around. > > Detected by CoverityScan, CID#1226833 ("Arguments in wrong order") This patch is being tracked under

Re: [PATCH] staging: lustre: lnet: fix incorrect arguments order calling lstcon_session_new

2017-08-14 Thread James Simmons
> From: Colin Ian King > > The arguments args->lstio_ses_force and args->lstio_ses_timeout are > in the incorrect order. Fix this by swapping them around. > > Detected by CoverityScan, CID#1226833 ("Arguments in wrong order") This patch is being tracked under

Re: [lustre-devel] [PATCH] staging: lustre: fix minor typos in comments

2017-08-03 Thread James Simmons
> Fix minor typos in comments. Acked-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: NeilBrown <ne...@suse.com> > --- > drivers/staging/lustre/lustre/llite/namei.c | 2 +- > drivers/staging/lustre/lustre/mdc/mdc_locks.c | 4 ++-- > 2 files changed

Re: [lustre-devel] [PATCH] staging: lustre: fix minor typos in comments

2017-08-03 Thread James Simmons
> Fix minor typos in comments. Acked-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/llite/namei.c | 2 +- > drivers/staging/lustre/lustre/mdc/mdc_locks.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [PATCH] staging: lustre: declare fiemap_for_stripe static

2017-08-03 Thread James Simmons
> Declare fiemap_for_stripe as static to fix sparse warnings: > > > warning: symbol 'fiemap_for_stripe' was not declared. Should it be > > static? Acked-by: James Simmons <jsimm...@infradead.org> > Signed-off-by: David Wittman <dwitt...@gmail.com> > ---

Re: [PATCH] staging: lustre: declare fiemap_for_stripe static

2017-08-03 Thread James Simmons
> Declare fiemap_for_stripe as static to fix sparse warnings: > > > warning: symbol 'fiemap_for_stripe' was not declared. Should it be > > static? Acked-by: James Simmons > Signed-off-by: David Wittman > --- > drivers/staging/lustre/lustre/lov/lov_object.c | 10 +

Re: [PATCH] staging: lustre: obd: make echo_lock_ops const

2017-08-03 Thread James Simmons
> Declare echo_lock_ops object of type cl_lock_operations as const as it > is only passed to the function cl_lock_slice_add. The corresponding > argument is of type const, so make the object const. > Acked-by: James Simmons <jsimm...@infradead.org> > Signed-off-by:

Re: [PATCH] staging: lustre: obd: make echo_lock_ops const

2017-08-03 Thread James Simmons
> Declare echo_lock_ops object of type cl_lock_operations as const as it > is only passed to the function cl_lock_slice_add. The corresponding > argument is of type const, so make the object const. > Acked-by: James Simmons > Signed-off-by: Bhumika Goyal > --- > d

Re: [PATCH 18/20] staging: lustre: llite: Remove filtering of seclabel xattr

2017-07-27 Thread James Simmons
amcloud.com/27292 > Reviewed-by: John L. Hammond <john.hamm...@intel.com> > Reviewed-by: Sebastien Buisson <sbuis...@ddn.com> > Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> > Signed-off-by: James Simmons <jsimm...@infradead.org> > --- > drivers/staging/lus

Re: [PATCH 18/20] staging: lustre: llite: Remove filtering of seclabel xattr

2017-07-27 Thread James Simmons
I missed in this push. Please drop this patch and I will resent the correct patches later. > Signed-off-by: Robin Humble > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9562 > Reviewed-on: https://review.whamcloud.com/27292 > Reviewed-by: John L. Hammond > Reviewed-by: Seb

[PATCH 1/2] staging: lustre: lov: use u64 instead of loff_t in lov_object_fiemap()

2017-07-26 Thread James Simmons
fm_start' Signed-off-by: Bobi Jam <bobijam...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8773 Reviewed-on: https://review.whamcloud.com/23461 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by:

[PATCH 1/2] staging: lustre: lov: use u64 instead of loff_t in lov_object_fiemap()

2017-07-26 Thread James Simmons
obi Jam Reported-by: Dan Carpenter Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8773 Reviewed-on: https://review.whamcloud.com/23461 Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Reviewed-by: Jinshan Xiong Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/stag

[PATCH 2/2] staging: lustre: lov: refactor lov_object_fiemap()

2017-07-26 Thread James Simmons
Reviewed-on: https://review.whamcloud.com/23461 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Jinshan Xiong <jinshan.xi...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <

[PATCH 2/2] staging: lustre: lov: refactor lov_object_fiemap()

2017-07-26 Thread James Simmons
From: Bobi Jam Add fiemap_for_stripe() to get file map extent from each stripe device. Signed-off-by: Bobi Jam Reported-by: Dan Carpenter Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8773 Reviewed-on: https://review.whamcloud.com/23461 Reviewed-by: James Simmons Reviewed-by: Andreas

[PATCH 0/2] staging: lustre: lov: fix sparse errors for fiemap

2017-07-26 Thread James Simmons
The following error was reported by Dan Carpenter lov_object_fiemap() has following static checker warning: drivers/staging/lustre/lustre/lov/lov_object.c:1241 lov_object_fiemap() warn: signed overflow undefined. 'fm_start + fm_length < fm_start' This patch set

[PATCH 0/2] staging: lustre: lov: fix sparse errors for fiemap

2017-07-26 Thread James Simmons
The following error was reported by Dan Carpenter lov_object_fiemap() has following static checker warning: drivers/staging/lustre/lustre/lov/lov_object.c:1241 lov_object_fiemap() warn: signed overflow undefined. 'fm_start + fm_length < fm_start' This patch set resolves those issues. Bobi Jam

[PATCH 00/20] staging: lustre: batch of fixes to decrease test failures

2017-07-26 Thread James Simmons
limitation James Simmons (6): staging: lustre: ldlm: restore interval_iterate_reverse function staging: lustre: lustre: fix all less than 0 comparison for unsigned values staging: lustre: ptlrpc: restore 64-bit time for struct ptlrpc_cli_req staging: lustre: ptlrpc: don't use CFS_DURATION_T

[PATCH 00/20] staging: lustre: batch of fixes to decrease test failures

2017-07-26 Thread James Simmons
limitation James Simmons (6): staging: lustre: ldlm: restore interval_iterate_reverse function staging: lustre: lustre: fix all less than 0 comparison for unsigned values staging: lustre: ptlrpc: restore 64-bit time for struct ptlrpc_cli_req staging: lustre: ptlrpc: don't use CFS_DURATION_T

[PATCH 03/20] staging: lustre: ldlm: crash on umount in cleanup_resource

2017-07-26 Thread James Simmons
exander.lezh...@seagate.com> Reviewed-on: http://review.whamcloud.com/13908 Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/hash.c | 47 ++ drivers/stagi

[PATCH 03/20] staging: lustre: ldlm: crash on umount in cleanup_resource

2017-07-26 Thread James Simmons
: https://jira.hpdd.intel.com/browse/LU-6304 Xyratex-bug-id: MRP-2352 Reviewed-by: Vitaly Fertman Reviewed-by: Alexander Boyko Tested-by: Alexander Lezhoev Reviewed-on: http://review.whamcloud.com/13908 Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/libcfs

[PATCH 04/20] staging: lustre: lov: fix 'control flow' error in lov_io_init_released

2017-07-26 Thread James Simmons
rowse/LU-4048 Reviewed-on: http://review.whamcloud.com/7824 Reviewed-by: Jinshan Xiong <jinshan.xi...@intel.com> Reviewed-by: Emoly Liu <emoly....@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: John L. Hammond <john.hamm...@intel.com> Reviewed-by: Oleg Droki

[PATCH 04/20] staging: lustre: lov: fix 'control flow' error in lov_io_init_released

2017-07-26 Thread James Simmons
d.com/7824 Reviewed-by: Jinshan Xiong Reviewed-by: Emoly Liu Reviewed-by: James Simmons Reviewed-by: John L. Hammond Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/lov/lov_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/lustre/

[PATCH 02/20] staging: lustre: ldlm: restore missing newlines in ldlm sysfs files

2017-07-26 Thread James Simmons
109 Reviewed-on: https://review.whamcloud.com/25522 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Mike Pershin <mike.pers...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/ld

[PATCH 02/20] staging: lustre: ldlm: restore missing newlines in ldlm sysfs files

2017-07-26 Thread James Simmons
From: "John L. Hammond" Restore the missing trailing newlines in /sys/fs/lustre/ldlm/namespaces/*/lru_{max_age,size}. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9109 Reviewed-on: https://review.whamcloud.com/25522 Reviewed-by: James Simmons

[PATCH 06/20] staging: lustre: lmv: assume a real connection in lmv_connect()

2017-07-26 Thread James Simmons
riate error path of lmv_connect(). Signed-off-by: John L. Hammond <john.hamm...@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7669 Reviewed-on: http://review.whamcloud.com/18018 Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: wangdi <di.w...@intel.com> S

[PATCH 06/20] staging: lustre: lmv: assume a real connection in lmv_connect()

2017-07-26 Thread James Simmons
Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7669 Reviewed-on: http://review.whamcloud.com/18018 Reviewed-by: Andreas Dilger Reviewed-by: wangdi Signed-off-by: James Simmons --- .../lustre/lustre/include/lustre/lustre_idl.h | 2 +- drivers/staging/lus

[PATCH 09/20] staging: lustre: ptlrpc: no need to reassign mbits for replay

2017-07-26 Thread James Simmons
ed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/ptlrpc/client.c | 28 +-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/c

[PATCH 09/20] staging: lustre: ptlrpc: no need to reassign mbits for replay

2017-07-26 Thread James Simmons
gned-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6808 Reviewed-on: http://review.whamcloud.com/23048 Reviewed-by: Fan Yong Reviewed-by: Alex Zhuravlev Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/ptlrpc/client.c

[PATCH 07/20] staging: lustre: lov: Ensure correct operation for large object sizes

2017-07-26 Thread James Simmons
dreas Dilger <andreas.dil...@intel.com> Reviewed-by: Jinshan Xiong <jinshan.xi...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/lov/lov_ea.c | 23 +--

[PATCH 05/20] staging: lustre: lov: remove unused code

2017-07-26 Thread James Simmons
John L. Hammond <john.hamm...@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5814 Reviewed-on: http://review.whamcloud.com/14878 Reviewed-by: Frank Zago <fz...@cray.com> Reviewed-by: Ben Evans <bev...@cray.com> Reviewed-by: James Simmons <uja.o...@yahoo.co

[PATCH 07/20] staging: lustre: lov: Ensure correct operation for large object sizes

2017-07-26 Thread James Simmons
Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/lov/lov_ea.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c index ac0bf64..2a8fee8 100644

[PATCH 05/20] staging: lustre: lov: remove unused code

2017-07-26 Thread James Simmons
-id: https://jira.hpdd.intel.com/browse/LU-5814 Reviewed-on: http://review.whamcloud.com/14878 Reviewed-by: Frank Zago Reviewed-by: Ben Evans Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/include/obd_class.h | 9 +- drivers/stag

[PATCH 11/20] staging: lustre: lustre: fix all less than 0 comparison for unsigned values

2017-07-26 Thread James Simmons
Remove all test of less than zero for unsigned values found with -Wtype-limits. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8843 Reviewed-on: https://review.whamcloud.com/23811 Reviewed-by: Andreas Dilger <andreas.dil...@

[PATCH 11/20] staging: lustre: lustre: fix all less than 0 comparison for unsigned values

2017-07-26 Thread James Simmons
Remove all test of less than zero for unsigned values found with -Wtype-limits. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8843 Reviewed-on: https://review.whamcloud.com/23811 Reviewed-by: Andreas Dilger Reviewed-by: Jian Yu Reviewed-by: Dmitry Eremin

[PATCH 08/20] staging: lustre: ptlrpc: correct use of list_add_tail()

2017-07-26 Thread James Simmons
ob.gloss...@intel.com> Reviewed-by: Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/ptlrpc/sec_gc.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 10/20] staging: lustre: ldlm: restore interval_iterate_reverse function

2017-07-26 Thread James Simmons
Earlier the function interval_iterate_reverse function was removed since it wasn't used by anyone. Now it is being restored since it will be used by a future patch. Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../staging/lustre/lustre/include/interval_tree.h | 4 +++ d

[PATCH 08/20] staging: lustre: ptlrpc: correct use of list_add_tail()

2017-07-26 Thread James Simmons
t it to do. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8270 Reviewed-on: http://review.whamcloud.com/20784 Reviewed-by: Andreas Dilger Reviewed-by: Bob Glossman Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drive

[PATCH 10/20] staging: lustre: ldlm: restore interval_iterate_reverse function

2017-07-26 Thread James Simmons
Earlier the function interval_iterate_reverse function was removed since it wasn't used by anyone. Now it is being restored since it will be used by a future patch. Signed-off-by: James Simmons --- .../staging/lustre/lustre/include/interval_tree.h | 4 +++ drivers/staging/lustre/lustre/ldlm

[PATCH 15/20] staging: lustre: ptlrpc: print times in microseconds

2017-07-26 Thread James Simmons
-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Minh Diep <minh.d...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 15 ---

[PATCH 15/20] staging: lustre: ptlrpc: print times in microseconds

2017-07-26 Thread James Simmons
Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c index f874781

[PATCH 14/20] staging: lustre: ptlrpc: don't use CFS_DURATION_T for time64_t

2017-07-26 Thread James Simmons
The libcfs CFS_DURATION_T define is really only for jiffies and its being used with time64_t in some of the ptlrpc code. Lets remove CFS_DURATION_T and replaced it with normal %lld instead. Signed-off-by: James Simmons <uja.o...@yahoo.com> Reviewed-on: https://review.whamcloud.com/24977 Int

[PATCH 14/20] staging: lustre: ptlrpc: don't use CFS_DURATION_T for time64_t

2017-07-26 Thread James Simmons
The libcfs CFS_DURATION_T define is really only for jiffies and its being used with time64_t in some of the ptlrpc code. Lets remove CFS_DURATION_T and replaced it with normal %lld instead. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/24977 Intel-bug-id: https

[PATCH 12/20] staging: lustre: linkea: linkEA size limitation

2017-07-26 Thread James Simmons
m> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../lustre/lustre/include/lustre/lustre_idl.h | 5 +- .../staging/lustre/lustre/include/lustre_linkea.h | 15 - drivers/staging/lustre/lustre/llite/llite_lib.c| 2

[PATCH 12/20] staging: lustre: linkea: linkEA size limitation

2017-07-26 Thread James Simmons
: https://jira.hpdd.intel.com/browse/LU-8569 Reviewed-on: https://review.whamcloud.com/23500 Reviewed-by: Andreas Dilger Reviewed-by: wangdi Reviewed-by: Lai Siyao Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../lustre/lustre/include/lustre/lustre_idl.h | 5 +- .../staging/lustre

[PATCH 17/20] staging: lustre: llite: allow cached acls

2017-07-26 Thread James Simmons
Signed-off-by: Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-on: https://review.whamcloud.com/25965 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-by: Bob Glossman <bob.gloss...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Droki

[PATCH 17/20] staging: lustre: llite: allow cached acls

2017-07-26 Thread James Simmons
Reviewed-on: https://review.whamcloud.com/25965 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-by: Bob Glossman Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/file.c | 3 --- drivers/staging/lustre

<    2   3   4   5   6   7   8   9   10   11   >