Re: Avoiding unnecessary jump relocations in gas?

2015-05-07 Thread Jan Beulich
>>> On 07.05.15 at 08:02, wrote: > AFAICT gas will produce relocations for jumps to global labels in the > same file. This doesn't seem directly harmful to me, except that, on > x86, it forces five-byte jumps instead of two-byte jumps. > > This seems especially unfortunate, since even hidden and

Re: regression from your recent change to x86's copy_user_handle_tail()

2015-04-23 Thread Jan Beulich
>>> On 23.04.15 at 17:33, wrote: > On Tue, Apr 21, 2015 at 11:33 PM, Jan Beulich wrote: >> >> while the description of commit cae2a173fe certainly makes sense, the >> change itself ignores the __probe_kernel_write() code path, for which >> the destination

Re: regression from your recent change to x86's copy_user_handle_tail()

2015-04-23 Thread Jan Beulich
>>> On 23.04.15 at 17:33, wrote: > On Tue, Apr 21, 2015 at 11:33 PM, Jan Beulich wrote: >> >> while the description of commit cae2a173fe certainly makes sense, the >> change itself ignores the __probe_kernel_write() code path, for which >> the destination

regression from your recent change to x86's copy_user_handle_tail()

2015-04-21 Thread Jan Beulich
Linus, while the description of commit cae2a173fe certainly makes sense, the change itself ignores the __probe_kernel_write() code path, for which the destination address is expected to be in kernel space but accesses may still fault. I.e. the use of plain memset() causes __probe_kernel_write() to

Re: [Xen-devel] [PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-21 Thread Jan Beulich
>>> On 20.04.15 at 19:09, wrote: > A different approach, given the dual nature of the AC flag now is to gate > setup_smap() on a kernel rpl of 0. SMAP necessarily can't be used in a > paravirtual situation where the kernel runs in cpl > 0. "Can't" isn't true here - for 64-bit PV Xen guests, whic

Re: [Xen-devel] [PATCH] XSA120 follows to the Linux kernel.

2015-04-14 Thread Jan Beulich
>>> On 10.04.15 at 16:37, wrote: > On 03/04/15 15:28, Konrad Rzeszutek Wilk wrote: >> Hey David and Boris, >> >> Please see the two patches - the first one fixes an situation that >> the original XSA-120 patch hadn't considered. >> >> The second patch is more of just a cleanup. Can be 4.1 materi

Re: [PATCH 4/8] x86: Add support for rd/wr fs/gs base

2015-04-13 Thread Jan Beulich
>>> On 11.04.15 at 01:05, wrote: >> One might argue that this code serves no purpose, but it's there, so >> we had better keep our per-invocation usage of DEBUG_STACK within 4k. > > Only if you run NKLD. I doubt KDB or GDB support nesting. > We can ask Jan if he still uses it. I didn't have the

Re: [PATCH] Kconfig: drop bogus default values

2015-03-24 Thread Jan Beulich
>>> On 23.03.15 at 23:58, wrote: > On Monday 23 March 2015 22:24:28 Paul Bolle wrote: >> > A real world case is PCI_QUIRKS in the mainline kernel: >> > >> > init/Kconfig:1554: default y >> > arch/s390/Kconfig:59: def_bool n >> > >> > When setting PCI!=n && EXPERT=n then on each architecture

Re: [PATCH] Kconfig: drop bogus default values

2015-03-24 Thread Jan Beulich
>>> On 23.03.15 at 22:08, wrote: > On Thursday 12 March 2015 13:11:47 Paul Bolle wrote: >> On Wed, 2015-03-11 at 13:59 +, Jan Beulich wrote: >> > Default "no" is pretty pointless for options without (visible) prompts: >> >> Related: is

Re: [PATCH] Kconfig: drop bogus default values

2015-03-12 Thread Jan Beulich
>>> On 12.03.15 at 13:11, wrote: > On Wed, 2015-03-11 at 13:59 +, Jan Beulich wrote: >> Default "no" is pretty pointless for options without (visible) prompts: > > Related: is there ever a situation where using "default n" or "def_bool > n

Re: [PATCH v1 2/2] x86: kconfig: remove X86_UP_APIC

2015-03-12 Thread Jan Beulich
>>> On 12.03.15 at 00:10, wrote: > config X86_LOCAL_APIC > def_bool y > - depends on X86_64 || SMP || X86_32_NON_STANDARD || X86_UP_APIC || > PCI_MSI > + depends on X86_64 || SMP || X86_32_NON_STANDARD || PCI_MSI I.e. building a 32-bit kernel with APIC support but with !SMP, !PCI_

Re: [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Jan Beulich
>>> On 11.03.15 at 15:44, wrote: > On 11/03/15 14:42, Konrad Rzeszutek Wilk wrote: >> On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: >>> It's not clear to me why only the enabling operation got handled so >>> far. >> >> Reviewed

[PATCH] Kconfig: drop bogus default values

2015-03-11 Thread Jan Beulich
Default "no" is pretty pointless for options without (visible) prompts: They only clutter .config-s with "# CONFIG_... is not set" and thus prevent users of "make oldconfig", when the option obtains a prompt or its prompt becomes visible, noticing that these may now b

[PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Jan Beulich
It's not clear to me why only the enabling operation got handled so far. Signed-off-by: Jan Beulich --- drivers/xen/xen-pciback/conf_space_header.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) --- 4.0-rc3-xen-pciback.orig/drivers/xen/xen-pciback/conf_space_hea

[PATCH 1/2] xen-pciback: limit guest control of command register

2015-03-11 Thread Jan Beulich
alter any of the bits collected together as PCI_COMMAND_GUEST permissive mode is now required to be enabled globally or on the specific device. This is CVE-2015-2150 / XSA-120. Signed-off-by: Jan Beulich Reviewed-by: Konrad Rzeszutek Wilk --- drivers/xen/xen-pciback/conf_space.c|2

RE: [PATCH v5] modify the IO_TLB_SEGSIZE and IO_TLB_DEFAULT_SIZE configurable as flexible requirement about SW-IOMMU.

2015-03-05 Thread Jan Beulich
>>> On 05.03.15 at 09:52, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Thursday, March 5, 2015 4:40 PM >> >>> On 05.03.15 at 04:53, wrote: >> >> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] >> >> S

RE: [PATCH v5] modify the IO_TLB_SEGSIZE and IO_TLB_DEFAULT_SIZE configurable as flexible requirement about SW-IOMMU.

2015-03-05 Thread Jan Beulich
>>> On 05.03.15 at 04:53, wrote: >> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] >> Sent: Thursday, March 5, 2015 3:43 AM >> On Tue, Mar 03, 2015 at 04:11:09PM +0800, Wang Xiaoming wrote: >> > @@ -101,13 +119,32 @@ setup_io_tlb_npages(char *str) { >> >if (isdigit(*str)) { >> >

Re: [PATCH 5/4] x86/mm: Further simplify 1 GB kernel linear mappings handling

2015-03-05 Thread Jan Beulich
c: Dexuan Cui > Cc: Greg Kroah-Hartman > Cc: H. Peter Anvin > Cc: jbeul...@suse.com > Cc: Jan Beulich > Cc: Joonsoo Kim > Cc: Juergen Gross > Cc: Linus Torvalds > Cc: Pavel Machek > Cc: Thomas Gleixner > Cc: Tony Lindgren > Cc: Toshi Kani > Cc: Vlastim

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-04 Thread Jan Beulich
>>> On 04.03.15 at 05:53, wrote: > On 03/03/2015 08:20 PM, Luis R. Rodriguez wrote: >> On Tue, Mar 3, 2015 at 2:06 AM, David Vrabel wrote: >>> On 03/03/15 09:40, Luis R. Rodriguez wrote: if X86_64 && SPARSEMEM_VMEMMAP Now Xen should not have SPARSEMEM_VMEMMAP but PVOPs' goal is to

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-03 Thread Jan Beulich
>>> On 03.03.15 at 10:40, wrote: > Let's go down the rabbit hole for a bit. HAVE_ARCH_KASAN will be > selected on x86 when: > > if X86_64 && SPARSEMEM_VMEMMAP > > Now Xen should not have SPARSEMEM_VMEMMAP Why would that be? Jan -- To unsubscribe from this list: send the line "unsubscribe linu

[tip:x86/asm] x86-64: Also clear _PAGE_GLOBAL from __supported_pte_mask if !cpu_has_pge

2015-02-18 Thread tip-bot for Jan Beulich
Commit-ID: 0cdb81bef20b1d9e12111fa6cd81f748ebd87778 Gitweb: http://git.kernel.org/tip/0cdb81bef20b1d9e12111fa6cd81f748ebd87778 Author: Jan Beulich AuthorDate: Fri, 23 Jan 2015 08:35:13 + Committer: Ingo Molnar CommitDate: Thu, 19 Feb 2015 02:18:26 +0100 x86-64: Also clear

[tip:irq/core] irqflags: Fix (at least latent) code generation issue

2015-02-18 Thread tip-bot for Jan Beulich
Commit-ID: db2dcb4f91d5fec5c346a82c309187ee821e2495 Gitweb: http://git.kernel.org/tip/db2dcb4f91d5fec5c346a82c309187ee821e2495 Author: Jan Beulich AuthorDate: Tue, 20 Jan 2015 13:00:46 + Committer: Ingo Molnar CommitDate: Thu, 19 Feb 2015 01:08:42 +0100 irqflags: Fix (at least

[tip:x86/asm] x86-64: Also clear _PAGE_GLOBAL from __supported_pte_mask if !cpu_has_pge

2015-02-18 Thread tip-bot for Jan Beulich
Commit-ID: 3ebfaff2bbd1d2ef882e475245d9f0276f21fe83 Gitweb: http://git.kernel.org/tip/3ebfaff2bbd1d2ef882e475245d9f0276f21fe83 Author: Jan Beulich AuthorDate: Fri, 23 Jan 2015 08:35:13 + Committer: Ingo Molnar CommitDate: Thu, 19 Feb 2015 00:44:46 +0100 x86-64: Also clear

[tip:x86/build] x86/Kconfig: Simplify X86_UP_APIC handling

2015-02-18 Thread tip-bot for Jan Beulich
Commit-ID: 50849eefea3ba8aa6e540e0cbdc9533098f25656 Gitweb: http://git.kernel.org/tip/50849eefea3ba8aa6e540e0cbdc9533098f25656 Author: Jan Beulich AuthorDate: Thu, 5 Feb 2015 15:31:56 + Committer: Ingo Molnar CommitDate: Wed, 18 Feb 2015 22:10:54 +0100 x86/Kconfig: Simplify

[tip:x86/build] x86/Kconfig: Avoid issuing pointless turned off entries to .config

2015-02-18 Thread tip-bot for Jan Beulich
Commit-ID: e0fd24a3b4ad7b4084b41944835952eedec53f98 Gitweb: http://git.kernel.org/tip/e0fd24a3b4ad7b4084b41944835952eedec53f98 Author: Jan Beulich AuthorDate: Thu, 5 Feb 2015 15:39:34 + Committer: Ingo Molnar CommitDate: Wed, 18 Feb 2015 22:08:46 +0100 x86/Kconfig: Avoid issuing

[tip:x86/build] x86/Kconfig: Simplify X86_IO_APIC dependencies

2015-02-18 Thread tip-bot for Jan Beulich
Commit-ID: b1da1e715d4faf01468b7f45f7098922bc85ea8e Gitweb: http://git.kernel.org/tip/b1da1e715d4faf01468b7f45f7098922bc85ea8e Author: Jan Beulich AuthorDate: Thu, 5 Feb 2015 15:35:21 + Committer: Ingo Molnar CommitDate: Wed, 18 Feb 2015 22:09:33 +0100 x86/Kconfig: Simplify

[tip:sched/core] sched/numa: Avoid some pointless iterations

2015-02-18 Thread tip-bot for Jan Beulich
Commit-ID: 890a5409f9d0c84d75a1e16eebdfe91d8a57ef1e Gitweb: http://git.kernel.org/tip/890a5409f9d0c84d75a1e16eebdfe91d8a57ef1e Author: Jan Beulich AuthorDate: Mon, 9 Feb 2015 12:30:00 +0100 Committer: Ingo Molnar CommitDate: Wed, 18 Feb 2015 16:18:02 +0100 sched/numa: Avoid some

Re: [Xen-devel] [PATCH 13/13] xen: allow more than 512 GB of RAM for 64 bit pv-domains

2015-02-18 Thread Jan Beulich
>>> On 18.02.15 at 10:37, wrote: > On 02/18/2015 10:21 AM, Paul Bolle wrote: >> On Wed, 2015-02-18 at 07:52 +0100, Juergen Gross wrote: >>> --- a/arch/x86/xen/Kconfig >>> +++ b/arch/x86/xen/Kconfig >>> @@ -23,14 +23,29 @@ config XEN_PVHVM >>> def_bool y >>> depends on XEN && PCI && X86_LOC

RE: [Xen-devel] [PATCH v4] modify the IO_TLB_SEGSIZE and IO_TLB_DEFAULT_SIZE configurable as flexible requirement about SW-IOMMU.

2015-02-18 Thread Jan Beulich
>>> On 18.02.15 at 10:09, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, February 17, 2015 6:09 PM >> >>> On 17.02.15 at 07:51, wrote: >> > --- a/Documentation/kernel-parameters.txt >> > +++ b/Documentation/ke

Re: [Xen-devel] [PATCH v4] modify the IO_TLB_SEGSIZE and IO_TLB_DEFAULT_SIZE configurable as flexible requirement about SW-IOMMU.

2015-02-17 Thread Jan Beulich
>>> On 17.02.15 at 07:51, wrote: > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -3438,10 +3438,12 @@ bytes respectively. Such letter suffixes can also be > entirely omitted. > it if 0 is given (See Documentation/cgroups/memory.tx

Re: [tip:sched/urgent] sched/fair: Avoid using uninitialized variable in preferred_group_nid()

2015-02-09 Thread Jan Beulich
It's perfectly fine to add it. Jan > --- > Subject: sched/numa: Avoid some pointless iterations > From: Jan Beulich > Date: Mon Feb 9 12:30:00 CET 2015 > > Commit 81907478c431 ("sched/fair: Avoid using uninitialized variable > in preferred_group_nid()") unc

[PATCH] x86/Kconfig: avoid issuing pointless turned off entries to .config

2015-02-05 Thread Jan Beulich
ng an incremental update of the configuration (make oldconfig). Signed-off-by: Jan Beulich --- arch/x86/Kconfig | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) --- 3.19-rc7/arch/x86/Kconfig +++ 3.19-rc7-x86-Kconfig-cleanup/arch/x86/Kconfig @@ -232,12 +232,10 @@ c

[PATCH] x86/Kconfig: simplify X86_IO_APIC dependencies

2015-02-05 Thread Jan Beulich
Since dependencies are transitive, we don't really need to repeat those of X86_UP_IOAPIC. Furthermore avoid the symbol getting entered into .config when it is off by having the default simply Y and the dependencies solely handled via the intended for that purpose "depends on". Sig

[PATCH] x86/Kconfig: simplify X86_UP_APIC handling

2015-02-05 Thread Jan Beulich
We don't really need a helper symbol for that. For one, it's pointlessly getting set to Y for all configurations (even 64-bit ones). And then the purpose can be fulfilled by suitably adjusting X86_UP_APIC: Hide its prompt when PCI_MSI, and default it to PCI_MSI. Signed-off-by: Jan B

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 22:03, wrote: > On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: >> Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) >> CONFIG_AS_ is reserved for assembly magic, and is never used by the the >> kconfig system. >> >> (Well. I might have made bits of t

Re: [Xen-devel] [PATCH 1/3] xen: mark pvscsi frontend request consumed only after last read

2015-01-30 Thread Jan Beulich
>>> On 30.01.15 at 12:21, wrote: > @@ -734,11 +734,11 @@ static int scsiback_do_cmd_fn(struct vscsibk_info *info) > if (!pending_req) > return 1; > > - ring_req = RING_GET_REQUEST(ring, rc); > + memcpy(&ring_req, RING_GET_REQUEST(ring,

[tip:sched/urgent] sched/fair: Avoid using uninitialized variable in preferred_group_nid()

2015-01-28 Thread tip-bot for Jan Beulich
Commit-ID: 81907478c4311a679849216abf723999184ab984 Gitweb: http://git.kernel.org/tip/81907478c4311a679849216abf723999184ab984 Author: Jan Beulich AuthorDate: Fri, 23 Jan 2015 08:25:38 + Committer: Ingo Molnar CommitDate: Wed, 28 Jan 2015 13:14:12 +0100 sched/fair: Avoid using

Re: [tip:sched/urgent] sched/fair: Avoid using uninitialized variable in preferred_group_nid()

2015-01-28 Thread Jan Beulich
>>> On 28.01.15 at 15:29, wrote: > Commit-ID: 81907478c4311a679849216abf723999184ab984 > Gitweb: > http://git.kernel.org/tip/81907478c4311a679849216abf723999184ab984 > Author: Jan Beulich > AuthorDate: Fri, 23 Jan 2015 08:25:38 + > Committer: Ingo Mo

Re: [PATCH v5 2/2] x86/xen: allow privcmd hypercalls to be preempted on 64-bit

2015-01-27 Thread Jan Beulich
>>> On 27.01.15 at 02:51, wrote: Even if David told you this would be acceptable, I have to question an abstract model of fixing issues on only 64-bit kernels - this may be acceptable for distro purposes, but seems hardly the right approach for upstream. If 32-bit ones are to become deliberately

Re: [Xen-devel] [RFC v4 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-26 Thread Jan Beulich
>>> On 23.01.15 at 19:58, wrote: > On Fri, Jan 23, 2015 at 11:45:06AM +, David Vrabel wrote: >> On 23/01/15 00:29, Luis R. Rodriguez wrote: >> > @@ -1243,6 +1247,25 @@ void xen_evtchn_do_upcall(struct pt_regs *regs) >> >set_irq_regs(old_regs); >> > } >> > >> > +/* >> > + * CONFIG_PREEMP

Re: x86/MCE: drop bogus const modifier from AMD's bank4_names()

2015-01-23 Thread Jan Beulich
>>> On 23.01.15 at 10:58, wrote: > On Fri, Jan 23, 2015 at 08:32:01AM +, Jan Beulich wrote: >> The compiler validly warns about it being ignored. >> >> Signed-off-by: Jan Beulich > > Applied, thanks. > > Out of curiosity: When do you see thi

Re: sched/fair: avoid using uninitialized variable in preferred_group_nid()

2015-01-23 Thread Jan Beulich
>>> On 23.01.15 at 10:54, wrote: > On Fri, Jan 23, 2015 at 08:25:38AM +, Jan Beulich wrote: >> At least some gcc versions - validly afaict - warn about potentially >> using max_group uninitialized: There's no way the compiler can prove >> that the b

[PATCH] xen/tmem: mark xen_tmem_init() __init

2015-01-23 Thread Jan Beulich
As a module_init() function, this should have been this way from the beginning. Signed-off-by: Jan Beulich --- drivers/xen/tmem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 3.19-rc5/drivers/xen/tmem.c +++ 3.19-rc5-xen-tmem-init/drivers/xen/tmem.c @@ -374,7 +374,7 @@ static

[PATCH] x86-64: also clear _PAGE_GLOBAL from __supported_pte_mask if !cpu_has_pge

2015-01-23 Thread Jan Beulich
Not just setting it when the feature is available is for consistency, and may allow Xen to drop its custom clearing of the flag (unless it needs it cleared earlier than this code executes). Note that the change is benign to ix86, as the flag starts out clear there. Signed-off-by: Jan Beulich

x86/MCE: drop bogus const modifier from AMD's bank4_names()

2015-01-23 Thread Jan Beulich
The compiler validly warns about it being ignored. Signed-off-by: Jan Beulich --- arch/x86/kernel/cpu/mcheck/mce_amd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 3.19-rc5/arch/x86/kernel/cpu/mcheck/mce_amd.c +++ 3.19-rc5-x86-MCE-AMD-bank4_names/arch/x86/kernel/cpu/mcheck

[PATCH] x86/raid6: correctly check for assembler capabilities

2015-01-23 Thread Jan Beulich
Just like for AVX2 (which simply needs an #if -> #ifdef conversion), SSSE3 assembler support should be checked for before using it. Signed-off-by: Jan Beulich Cc: Jim Kukunas Cc: Neil Brown --- arch/x86/Makefile |1 + lib/raid6/algos.c |2 +- lib/raid6/recov_avx2.c |

sched/fair: avoid using uninitialized variable in preferred_group_nid()

2015-01-23 Thread Jan Beulich
by exiting the outer loop when max_faults is still zero after the inner loop. For the compiler's sake, mark max_group uninitialized, as we're now able to prove it's not actually being used uninitalized anymore. Signed-off-by: Jan Beulich Cc: Rik van Riel --- kernel/sched/fair.c |

[PATCH] ix86: log unhandled signals from do_trap() just like x86-64 does

2015-01-23 Thread Jan Beulich
There not being a similar difference in page fault handling, I can't see why 32- and 64-bit should differ in behavior here. Signed-off-by: Jan Beulich --- arch/x86/kernel/traps.c |2 -- 1 file changed, 2 deletions(-) --- 3.19-rc5/arch/x86/kernel/traps.c +++ 3.19-rc5-ix86-show-unha

[PATCH v2] irqflags: fix (at least latent) code generation issue

2015-01-20 Thread Jan Beulich
preceding it (which was slightly wrong from at least from 2.6.37 onwards). The code bloat was observed in reality with an experimental x86 patch. Signed-off-by: Jan Beulich --- v2: Deal with architectures not defining raw_irqs_disabled() by retaining the CONFIG_TRACE_IRQFLAGS_SUPPORT-dependent

[tip:x86/urgent] x86, irq: Properly tag virtualization entry in / proc/interrupts

2015-01-20 Thread tip-bot for Jan Beulich
Commit-ID: 4a0d3107d6b19125f21172c2b7d95f9c30ecaf6f Gitweb: http://git.kernel.org/tip/4a0d3107d6b19125f21172c2b7d95f9c30ecaf6f Author: Jan Beulich AuthorDate: Fri, 16 Jan 2015 15:47:07 + Committer: Thomas Gleixner CommitDate: Tue, 20 Jan 2015 12:37:23 +0100 x86, irq: Properly tag

[PATCH] x86: properly tag virtualization entry in /proc/interrupts

2015-01-16 Thread Jan Beulich
The mis-naming likely was a copy-and-paste effect. Signed-off-by: Jan Beulich --- arch/x86/kernel/irq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 3.19-rc4/arch/x86/kernel/irq.c +++ 3.19-rc4-xen-x86-HYP-interrupt/arch/x86/kernel/irq.c @@ -127,7 +127,7 @@ int

Re: your recent tools/include/ adjustments

2015-01-13 Thread Jan Beulich
>>> On 13.01.15 at 14:29, wrote: > Em Tue, Jan 13, 2015 at 08:48:35AM +, Jan Beulich escreveu: >> Arnaldo, >> >> considering that tools/include/ gets used by other than just perf, in >> particular arch/x86/vdso/vdso2c.c, would you mind clarifying how >

your recent tools/include/ adjustments

2015-01-13 Thread Jan Beulich
Arnaldo, considering that tools/include/ gets used by other than just perf, in particular arch/x86/vdso/vdso2c.c, would you mind clarifying how "tools: Move bitops.h from tools/perf/util to tools/" adding an inclusion of asm/hweight.h to linux/bitops.h is supposed to work, when the only potentiall

[PATCH v2] xen/x86: properly retrieve NMI reason

2015-01-12 Thread Jan Beulich
t hold zero all the time. Note further that hardware NMI handling for PVH doesn't currently work anyway due to missing code in the hypervisor (but it is expected to work the native rather than the PV way). Signed-off-by: Jan Beulich Reviewed-by: Boris Ostrovsky --- v2: Use DEFINE_GUEST_HANDLE

Re: [Xen-devel] [PATCH 3/3] xen: use correct type for physical addresses

2015-01-09 Thread Jan Beulich
>>> On 09.01.15 at 13:51, wrote: > On 09/01/15 09:57, Jan Beulich wrote: >>>>> On 08.01.15 at 18:01, wrote: >>> @@ -284,7 +286,7 @@ static void __init xen_update_mem_tables(unsigned long >>> pfn, unsigned long mfn) >>> } >&

Re: [Xen-devel] [PATCH 3/3] xen: use correct type for physical addresses

2015-01-09 Thread Jan Beulich
>>> On 08.01.15 at 18:01, wrote: > --- a/arch/x86/xen/setup.c > +++ b/arch/x86/xen/setup.c > @@ -140,7 +140,7 @@ static void __init xen_del_extra_mem(u64 start, u64 size) > unsigned long __ref xen_chk_extra_mem(unsigned long pfn) > { > int i; > - unsigned long addr = PFN_PHYS(pfn); > +

Re: [Xen-devel] [PATCH RFC] xen-time: decreasing the rating of the xen clocksource below that of the tsc clocksource for dom0's

2015-01-07 Thread Jan Beulich
>>> On 07.01.15 at 17:30, wrote: > On Wed, 2015-01-07 at 17:16 +0100, Imre Palik wrote: >> From: "Palik, Imre" >> >> In Dom0's the use of the TSC clocksource (whenever it is stable enough to >> be used) instead of the Xen clocksource should not cause any issues, as >> Dom0 VMs never live-migrate

Re: xen/x86: properly retrieve NMI reason

2015-01-06 Thread Jan Beulich
>>> David Vrabel 01/05/15 11:35 AM >>> >On 19/12/14 16:16, Jan Beulich wrote: >> Using the native code here can't work properly, as the hypervisor would >> normally have cleared the two reason bits by the time Dom0 gets to see >> the NMI (if passed to

Re: 答复:[PATCH] perf core: Use KSTK_ESP() instead of pt_regs->sp while output user regs

2015-01-05 Thread Jan Beulich
>>> Andy Lutomirski 01/02/15 7:03 PM >>> >On Jan 2, 2015 8:11 AM, "Jan Beulich" wrote: >> Trying to guess what you mean by "this": A stack switch gets expressed by >> CFI annotations just like any other frame pointer adjustments. See f

Re: 答复:[PATCH] perf core: Use KSTK_ESP() instead of pt_regs->sp while output user regs

2015-01-02 Thread Jan Beulich
de -> IST exception -> NMI, then >task_pt_regs is entirely uninitialized. Assuming all the CFI >annotations are correct, the unwinder could still do it from the >kernel. > >Note that, as far as I know, Jan Beulich is the only person who uses >the unwinder on kernel code. Jan

Re: [Xen-devel] xen/x86: properly retrieve NMI reason

2015-01-02 Thread Jan Beulich
>>> David Vrabel 12/23/14 12:01 PM >>> >On 19/12/14 16:16, Jan Beulich wrote: >> Using the native code here can't work properly, as the hypervisor would >> normally have cleared the two reason bits by the time Dom0 gets to see >> the NMI (if passed to

[tip:x86/urgent] x86: Fix step size adjustment during initial memory mapping

2014-12-23 Thread tip-bot for Jan Beulich
Commit-ID: 132978b94e66f8ad7d20790f8332f0e9c1426029 Gitweb: http://git.kernel.org/tip/132978b94e66f8ad7d20790f8332f0e9c1426029 Author: Jan Beulich AuthorDate: Fri, 19 Dec 2014 16:10:54 + Committer: Ingo Molnar CommitDate: Tue, 23 Dec 2014 11:39:34 +0100 x86: Fix step size

xen/x86: properly retrieve NMI reason

2014-12-19 Thread Jan Beulich
e that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port 0x61 in a DomU would be even worse, while the shared info field would just hold zero all the time. Signed-off-by: Jan Beulich --- arch/x86/xen/enlighten.c| 22 +- include/xen/

[PATCH] x86: fix step size adjustment during initial memory mapping

2014-12-19 Thread Jan Beulich
range boundary of zero can't really work well. Signed-off-by: Jan Beulich Cc: Yinghai Lu --- arch/x86/mm/init.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) --- 3.18/arch/x86/mm/init.c +++ 3.18-x86-init-mem-steps/arch/x86/mm/init.c @@ -409,2

[tip:x86/apic] x86: Avoid building unused IRQ entry stubs

2014-12-19 Thread tip-bot for Jan Beulich
Commit-ID: 2414e021ac8d588f1b09f64891f69a3e26feadf1 Gitweb: http://git.kernel.org/tip/2414e021ac8d588f1b09f64891f69a3e26feadf1 Author: Jan Beulich AuthorDate: Mon, 3 Nov 2014 08:39:43 + Committer: Thomas Gleixner CommitDate: Tue, 16 Dec 2014 14:08:14 +0100 x86: Avoid building

[tip:x86/apic] x86: irq: Fix placement of mp_should_keep_irq()

2014-12-19 Thread tip-bot for Jan Beulich
Commit-ID: e10679825924580845c4825deaaddf5331ff627c Gitweb: http://git.kernel.org/tip/e10679825924580845c4825deaaddf5331ff627c Author: Jan Beulich AuthorDate: Mon, 3 Nov 2014 08:15:42 + Committer: Thomas Gleixner CommitDate: Tue, 16 Dec 2014 14:08:14 +0100 x86: irq: Fix placement

Re: [Xen-devel] [PATCH 1/4] xen: build infrastructure for generating hypercall depending symbols

2014-12-15 Thread Jan Beulich
>>> On 15.12.14 at 12:38, wrote: > On 11/12/14 18:04, Juergen Gross wrote: >> --- a/arch/x86/syscalls/Makefile >> +++ b/arch/x86/syscalls/Makefile > > Why are these changes here and not in arch/x86/xen/Makefile? Because this needs to be done in a step that (afaict) has no hook in the Xen-specifi

Re: [Xen-devel] [PATCH 1/4] xen: build infrastructure for generating hypercall depending symbols

2014-12-15 Thread Jan Beulich
>>> On 12.12.14 at 23:48, wrote: > On 12/11/2014 01:04 PM, Juergen Gross wrote: >> diff --git a/scripts/xen-hypercalls.sh b/scripts/xen-hypercalls.sh >> new file mode 100644 >> index 000..e6447b7 >> --- /dev/null >> +++ b/scripts/xen-hypercalls.sh >> @@ -0,0 +1,11 @@ >> +#!/bin/sh >> +out="$1"

Re: [PATCH v2 1/2] sched: add cond_resched_irq()

2014-12-11 Thread Jan Beulich
>>> On 11.12.14 at 00:34, wrote: > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -4239,6 +4239,16 @@ int __sched _cond_resched(void) > } > EXPORT_SYMBOL(_cond_resched); > > +int __sched cond_resched_irq(void) > +{ > + if (should_resched()) { > + preempt_schedule_ir

Re: [PATCH v5 8/9] xen-pciback: drop SR-IOV VFs when PF driver unloads

2014-12-04 Thread Jan Beulich
>>> On 04.12.14 at 12:07, wrote: > On 03/12/14 21:40, Konrad Rzeszutek Wilk wrote: >> From: Jan Beulich >> >> When a PF driver unloads, it may find it necessary to leave the VFs >> around simply because of pciback having marked them as assigned to a >>

Re: [Xen-devel] [PATCH v4] Fixes for PCI backend for 3.19

2014-12-02 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 12/02/14 4:05 PM >>> >On Tue, Dec 02, 2014 at 10:10:11AM +, Jan Beulich wrote: >> >>> On 21.11.14 at 23:17, wrote: >> > Konrad Rzeszutek Wilk (7): >> > xen/pciback: Don't deadlock when unbinding. >

Re: [Xen-devel] [PATCH v4] Fixes for PCI backend for 3.19

2014-12-02 Thread Jan Beulich
>>> On 21.11.14 at 23:17, wrote: > Konrad Rzeszutek Wilk (7): > xen/pciback: Don't deadlock when unbinding. > driver core: Provide an wrapper around the mutex to do lockdep warnings > xen/pciback: Include the domain id if removing the device whilst still > in use > xen/pci

Re: [PATCH] irqflags: fix (at least latent) code generation issue

2014-11-28 Thread Jan Beulich
>>> On 10.11.14 at 13:13, wrote: > * Jan Beulich wrote: >> @@ -131,7 +131,7 @@ >> } while (0) >> >> >> -#else /* !CONFIG_TRACE_IRQFLAGS_SUPPORT */ >> +#else /* !CONFIG_TRACE_IRQFLAGS */ >> >> #define local_irq_en

Re: [PATCH] xen-pciback: drop SR-IOV VFs when PF driver unloads

2014-11-23 Thread Jan Beulich
>>> On 21.11.14 at 23:03, wrote: > I rewrote it a bit to be more in the style of pciback: >[...] > [v2: Removed the switch statement, moved it about] What you don't mention here is that you also removed the outer loop, yet that breaks functionality afaict: There can (and I suppose normally will)

Re: [Xen-devel] [PATCH 4/4] x86/xen: use the maximum MFN to calculate the required DMA mask

2014-11-20 Thread Jan Beulich
t; Provide a get_required_mask op that uses the maximum MFN to calculate > the DMA mask. > > Signed-off-by: David Vrabel Reviewed-by: Jan Beulich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [Xen-devel] [PATCH 3/3] x86/xen: use the maximum MFN to calculate the required DMA mask

2014-11-13 Thread Jan Beulich
>>> On 13.11.14 at 11:38, wrote: > On 12/11/14 15:55, Jan Beulich wrote: >>>>> On 12.11.14 at 16:25, wrote: >>> +u64 >>> +xen_swiotlb_get_required_mask(struct device *dev) >>> +{ >>> + u64 max_mfn; >>>

Re: [Xen-devel] [PATCH 2/3] x86: allow dma_get_required_mask() to be overridden

2014-11-13 Thread Jan Beulich
>>> On 13.11.14 at 11:25, wrote: On 12.11.14 at 16:25, wrote: >> --- a/arch/x86/include/asm/device.h >> +++ b/arch/x86/include/asm/device.h >> @@ -13,4 +13,6 @@ struct dev_archdata { >> struct pdev_archdata { >> }; >> >> +#define ARCH_HAS_DMA_GET_REQUIRED_MASK > > Is there a particular

Re: [Xen-devel] [PATCH 2/3] x86: allow dma_get_required_mask() to be overridden

2014-11-13 Thread Jan Beulich
>>> On 12.11.14 at 16:25, wrote: > --- a/arch/x86/include/asm/device.h > +++ b/arch/x86/include/asm/device.h > @@ -13,4 +13,6 @@ struct dev_archdata { > struct pdev_archdata { > }; > > +#define ARCH_HAS_DMA_GET_REQUIRED_MASK Is there a particular reason you put this here rather than in dma-ma

Re: [Xen-devel] [PATCH 3/3] x86/xen: use the maximum MFN to calculate the required DMA mask

2014-11-13 Thread Jan Beulich
>>> On 12.11.14 at 16:55, wrote: On 12.11.14 at 16:25, wrote: >> +u64 >> +xen_swiotlb_get_required_mask(struct device *dev) >> +{ >> +u64 max_mfn; >> + >> +max_mfn = HYPERVISOR_memory_op(XENMEM_maximum_ram_page, NULL); >> + >> +return DMA_BIT_MASK(fls64(max_mfn << PAGE_SHIFT) + 1

Re: [PATCH, RFC] x86: also CFI-annotate certain inline asm()s

2014-11-12 Thread Jan Beulich
>>> On 12.11.14 at 21:36, wrote: > On Mon, Nov 10, 2014 at 11:42 PM, Jan Beulich wrote: >> >> Nothing crashes with the unwind information being wrong. It is >> solely you who was claiming (without proof) years ago that the >> unwinder repeatedly caused issues

Re: [Xen-devel] [PATCH 3/3] x86/xen: use the maximum MFN to calculate the required DMA mask

2014-11-12 Thread Jan Beulich
>>> On 12.11.14 at 17:59, wrote: > On 12/11/14 15:55, Jan Beulich wrote: >>>>> On 12.11.14 at 16:25, wrote: >>> +u64 >>> +xen_swiotlb_get_required_mask(struct device *dev) >>> +{ >>> + u64 max_mfn; >>>

Re: [Xen-devel] [PATCH 3/3] x86/xen: use the maximum MFN to calculate the required DMA mask

2014-11-12 Thread Jan Beulich
>>> On 12.11.14 at 16:25, wrote: > +u64 > +xen_swiotlb_get_required_mask(struct device *dev) > +{ > + u64 max_mfn; > + > + max_mfn = HYPERVISOR_memory_op(XENMEM_maximum_ram_page, NULL); > + > + return DMA_BIT_MASK(fls64(max_mfn << PAGE_SHIFT) + 1); > +} The value the hypercall returns

Re: [PATCH, RFC] x86: also CFI-annotate certain inline asm()s

2014-11-10 Thread Jan Beulich
>>> On 10.11.14 at 19:10, wrote: > Btw, the sane thing to do is to make your infrastructure just say "If > my frame walker hits a push/pop without CFI information, I'll just add > it myself". > > Yes, that involved having to actuall ylook at the instruction. Tough > shit. Just do it right. There

Re: [PATCH, RFC] x86: also CFI-annotate certain inline asm()s

2014-11-10 Thread Jan Beulich
>>> On 10.11.14 at 18:56, wrote: > So no. A very strong NACK. The code was too ugly to live, there is no good > stated reason for it, and the only reason I can even remotely imagine is > wrong and complete crap anyway (ie making the CFI annotations a correctness > issue by introducing other infras

[PATCH] xen-pciback: drop SR-IOV VFs when PF driver unloads

2014-11-06 Thread Jan Beulich
allows the driver to be loaded again with it being able to create the VFs anew, but which also allows to then pass through the PF instead of the VFs). Don't do this however for any VFs currently in active use by a guest. Signed-off-by: Jan Beulich --- drivers/xen/xen-pciback/pci_stub.c |

Re: [PATCH, RFC] x86: also CFI-annotate certain inline asm()s

2014-11-06 Thread Jan Beulich
>>> On 05.11.14 at 18:23, wrote: > On Wed, Nov 5, 2014 at 9:13 AM, Jan Beulich wrote: >>>>> Andy Lutomirski 11/04/14 8:40 PM >>> >>>On 11/04/2014 01:24 AM, Jan Beulich wrote: >>>> The main obstacle to having done this long ago was the nee

Re: [PATCH, RFC] x86: also CFI-annotate certain inline asm()s

2014-11-05 Thread Jan Beulich
>>> Andy Lutomirski 11/04/14 8:40 PM >>> >On 11/04/2014 01:24 AM, Jan Beulich wrote: >> The main obstacle to having done this long ago was the need to >> determine whether annotations are needed in the first place: They need >> to be avoided when a frame

Re: [PATCH 0/2] x86-64: allow using RIP-relative addressing for per-CPU data

2014-11-05 Thread Jan Beulich
>>> Andy Lutomirski 11/04/14 8:33 PM >>> >On 11/04/2014 12:49 AM, Jan Beulich wrote: >> Observing that per-CPU data (in the SMP case) is reachable by >> exploiting 64-bit address wraparound, these two patches >> arrange for using the one byte shorter R

Re: [tip:x86/boot] x86-64: Use RIP-relative addressing for most per-CPU accesses

2014-11-05 Thread Jan Beulich
>>> "H. Peter Anvin" 11/04/14 9:11 PM >>> >On 11/04/2014 11:45 AM, tip-bot for Jan Beulich wrote: >> x86-64: Use RIP-relative addressing for most per-CPU accesses >> >> Observing that per-CPU data (in the SMP case) is reachable by >> exploi

[tip:x86/boot] x86-64: Use RIP-relative addressing for most per-CPU accesses

2014-11-04 Thread tip-bot for Jan Beulich
Commit-ID: 97b67ae559947f1e208439a1bf6a734da3087006 Gitweb: http://git.kernel.org/tip/97b67ae559947f1e208439a1bf6a734da3087006 Author: Jan Beulich AuthorDate: Tue, 4 Nov 2014 08:50:48 + Committer: Thomas Gleixner CommitDate: Tue, 4 Nov 2014 20:43:14 +0100 x86-64: Use RIP-relative

[tip:x86/boot] x86-64: Handle PC-relative relocations on per-CPU data

2014-11-04 Thread tip-bot for Jan Beulich
Commit-ID: 6d24c5f72dfb26e5fa7f02fa9266dfdbae41adba Gitweb: http://git.kernel.org/tip/6d24c5f72dfb26e5fa7f02fa9266dfdbae41adba Author: Jan Beulich AuthorDate: Tue, 4 Nov 2014 08:50:18 + Committer: Thomas Gleixner CommitDate: Tue, 4 Nov 2014 20:43:14 +0100 x86-64: Handle PC

[tip:x86/boot] x86: Convert a few more per-CPU items to read-mostly ones

2014-11-04 Thread tip-bot for Jan Beulich
Commit-ID: 2c773dd31fbacbbb6425f8a9d3f97e0010272368 Gitweb: http://git.kernel.org/tip/2c773dd31fbacbbb6425f8a9d3f97e0010272368 Author: Jan Beulich AuthorDate: Tue, 4 Nov 2014 08:26:42 + Committer: Thomas Gleixner CommitDate: Tue, 4 Nov 2014 20:13:28 +0100 x86: Convert a few more

[tip:x86/apic] x86: Avoid building unused IRQ entry stubs

2014-11-04 Thread tip-bot for Jan Beulich
Commit-ID: 8c66877ee65ec4e6974e9aa69bc53abe4a603f10 Gitweb: http://git.kernel.org/tip/8c66877ee65ec4e6974e9aa69bc53abe4a603f10 Author: Jan Beulich AuthorDate: Mon, 3 Nov 2014 08:39:43 + Committer: Thomas Gleixner CommitDate: Tue, 4 Nov 2014 20:11:59 +0100 x86: Avoid building

[tip:x86/apic] x86: irq: Fix placement of mp_should_keep_irq()

2014-11-04 Thread tip-bot for Jan Beulich
Commit-ID: 3b67bdc6599e25b082f12dbde6b0ce91dd235549 Gitweb: http://git.kernel.org/tip/3b67bdc6599e25b082f12dbde6b0ce91dd235549 Author: Jan Beulich AuthorDate: Mon, 3 Nov 2014 08:15:42 + Committer: Thomas Gleixner CommitDate: Tue, 4 Nov 2014 19:12:41 +0100 x86: irq: Fix placement

[PATCH, RFC] x86: also CFI-annotate certain inline asm()s

2014-11-04 Thread Jan Beulich
s) arch/x86/kernel/kprobes/ arch/x86/kernel/kvm/ drivers/char/i8k.c:i8k_smm() drivers/char/toshiba.c:tosh_smm() drivers/lguest/x86/ Signed-off-by: Jan Beulich Cc: Tony Jones --- arch/x86/Makefile| 22 arch/x86/include/as

[PATCH 2/2] x86-64: use RIP-relative addressing for most per-CPU accesses

2014-11-04 Thread Jan Beulich
he dependency on the minimum kernel load address, arbitrarily low values for CONFIG_PHYSICAL_START are now no longer possible. A link time assertion is being added, directing to the need to increase that value when it triggers. Signed-off-by: Jan Beulich --- a

[PATCH 0/2] x86-64: allow using RIP-relative addressing for per-CPU data

2014-11-04 Thread Jan Beulich
addressing for most per-CPU accesses Signed-off-by: Jan Beulich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FA

[PATCH 1/2] x86-64: handle PC-relative relocations on per-CPU data

2014-11-04 Thread Jan Beulich
This is in preparation of using RIP-relative addressing in many of the per-CPU accesses. Signed-off-by: Jan Beulich --- arch/x86/boot/compressed/misc.c | 14 +- arch/x86/tools/relocs.c | 38 -- 2 files changed, 41 insertions(+), 11

[PATCH] x86: convert a few more per-CPU items to read-mostly ones

2014-11-04 Thread Jan Beulich
t got converted to per-CPU data years ago). Signed-off-by: Jan Beulich --- arch/x86/include/asm/percpu.h|2 +- arch/x86/include/asm/processor.h |4 ++-- arch/x86/kernel/setup_percpu.c |2 +- arch/x86/kernel/smpboot.c|2 +- 4 files changed, 5 insertions(+), 5 dele

[PATCH] irqflags: fix (at least latent) code generation issue

2014-11-04 Thread Jan Beulich
preceding it (which was slightly wrong from at least from 2.6.37 onwards). The code bloat was observed in reality with an experimental x86 patch I'm about to post as RFC. Signed-off-by: Jan Beulich --- include/linux/irqflags.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- 3.1

<    1   2   3   4   5   6   7   8   9   10   >