[PATCH] md: Fix missing unused status line of /proc/mdstat

how() once to print the status line also for multiple reads. Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") Signed-off-by: Jan Glauber --- drivers/md/md.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/md/md.c b/dr

[RFC 1/1] edac: Add a counter parameter for edac_device_handle_ue/ce()

On Mon, Jul 15, 2019 at 01:53:07PM +0300, Hanna Hawa wrote: > Add a counter parameter in order to avoid losing errors count for edac > device, the error count reports the number of errors reported by an edac > device similar to the way MC_EDAC do. > > Signed-off-by: Hanna Hawa > --- >

Re: [PATCH v2 0/5] Add NUMA-awareness to qspinlock

-qspinlocks - 56149.41 73.90 224 576.95 290.31 Also frontend-stalls are reduced to 50% and interconnect traffic is greatly reduced. Tested-by: Jan Glauber --Jan Am Fr., 29. März 2019 um 16:23 Uhr schrieb Alex Kogan

Re: [PATCH] lockref: Limit number of cmpxchg loop retries

On Thu, Jun 06, 2019 at 10:28:12AM +, Jan Glauber wrote: > On Thu, Jun 06, 2019 at 10:41:54AM +0100, Will Deacon wrote: > > On Thu, Jun 06, 2019 at 08:03:27AM +0000, Jan Glauber wrote: > > > On Wed, Jun 05, 2019 at 01:16:46PM -0700, Linus Torvalds wrote: > > > >

Re: [PATCH] lockref: Limit number of cmpxchg loop retries

On Thu, Jun 06, 2019 at 10:41:54AM +0100, Will Deacon wrote: > On Thu, Jun 06, 2019 at 08:03:27AM +0000, Jan Glauber wrote: > > On Wed, Jun 05, 2019 at 01:16:46PM -0700, Linus Torvalds wrote: > > > On Wed, Jun 5, 2019 at 6:49 AM Jan Glauber wrote: > > > > > >

Re: [PATCH] lockref: Limit number of cmpxchg loop retries

On Wed, Jun 05, 2019 at 01:16:46PM -0700, Linus Torvalds wrote: > On Wed, Jun 5, 2019 at 6:49 AM Jan Glauber wrote: > > > > Add an upper bound to the loop to force the fallback to spinlocks > > after some time. A retry value of 100 should not impact any hardware > > th

[PATCH] lockref: Limit number of cmpxchg loop retries

not impact any hardware that does not have this issue. With the retry limit the performance of an open-close testcase improved between 60-70% on ThunderX2. Suggested-by: Linus Torvalds Signed-off-by: Jan Glauber --- lib/lockref.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/lockref.c b

Re: [RFC] Disable lockref on arm64

On Wed, May 01, 2019 at 05:01:40PM +0100, Will Deacon wrote: > Hi Jan, > > [+Peter and Linus, since they enjoy this stuff] > > On Mon, Apr 29, 2019 at 02:52:11PM +0000, Jan Glauber wrote: > > I've been looking into performance issues that were reported for several > &g

Re: [RFC] Disable lockref on arm64

On Wed, May 01, 2019 at 09:41:08AM -0700, Linus Torvalds wrote: > On Mon, Apr 29, 2019 at 7:52 AM Jan Glauber wrote: > > > > It turned out the issue we have on ThunderX2 is the file open-close sequence > > with small read sizes. If the used files are opened read-only the >

Re: dcache_readdir NULL inode oops

Hi Al, On Fri, Nov 30, 2018 at 04:32:28PM +, Will Deacon wrote: > On Fri, Nov 30, 2018 at 04:08:52PM +, Al Viro wrote: > > On Fri, Nov 30, 2018 at 09:16:49AM -0600, Eric W. Biederman wrote: > > > >> > + inode_lock(parent->d_inode); > > > >> > dentry->d_fsdata = NULL; > > >

[RFC] Disable lockref on arm64

Hi Catalin & Will, I've been looking into performance issues that were reported for several test-cases, for instance an nginx benchmark. It turned out the issue we have on ThunderX2 is the file open-close sequence with small read sizes. If the used files are opened read-only the lockref code

Re: [PATCH 4/7] crypto: cavium: zip: no need to check return value of debugfs_create functions

> Cc: "David S. Miller" > Cc: Robert Richter > Cc: Jan Glauber > Cc: linux-cry...@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > drivers/crypto/cavium/zip/zip_main.c | 52 ++-- > 1 file changed, 11 insertions(+), 41 deletions(-) Reviewed-by: Jan Glauber thanks, Jan

Re: dcache_readdir NULL inode oops

On Wed, Nov 28, 2018 at 08:08:06PM +, Will Deacon wrote: > I spent some more time looking at this today... > > On Fri, Nov 23, 2018 at 06:05:25PM +, Will Deacon wrote: > > Doing some more debugging, it looks like the usual failure case is where > > one CPU clears the inode field in the

Re: dcache_readdir NULL inode oops

On Wed, Nov 28, 2018 at 08:08:06PM +, Will Deacon wrote: > I spent some more time looking at this today... > > On Fri, Nov 23, 2018 at 06:05:25PM +, Will Deacon wrote: > > Doing some more debugging, it looks like the usual failure case is where > > one CPU clears the inode field in the

Re: dcache_readdir NULL inode oops

On Tue, Nov 20, 2018 at 07:03:17PM +, Will Deacon wrote: > On Tue, Nov 20, 2018 at 06:28:54PM +, Will Deacon wrote: > > On Sat, Nov 10, 2018 at 11:17:03AM +0000, Jan Glauber wrote: > > > On Fri, Nov 09, 2018 at 03:58:56PM +, Will Deacon wrote: > > > > On F

Re: dcache_readdir NULL inode oops

On Tue, Nov 20, 2018 at 07:03:17PM +, Will Deacon wrote: > On Tue, Nov 20, 2018 at 06:28:54PM +, Will Deacon wrote: > > On Sat, Nov 10, 2018 at 11:17:03AM +0000, Jan Glauber wrote: > > > On Fri, Nov 09, 2018 at 03:58:56PM +, Will Deacon wrote: > > > > On F

WARN_ON after gic_reserve_range

Hi Marc, with 4.20-rc3 I see two WARN_ON's firing on a ThunderX2 system that come from commit 3fb68faee867 (irqchip/gic-v3-its: Register LPI tables with EFI config table). Global efi_memreserve_root is NULL as it will only be set when early initcalls are running, but from the backtrace the

WARN_ON after gic_reserve_range

Hi Marc, with 4.20-rc3 I see two WARN_ON's firing on a ThunderX2 system that come from commit 3fb68faee867 (irqchip/gic-v3-its: Register LPI tables with EFI config table). Global efi_memreserve_root is NULL as it will only be set when early initcalls are running, but from the backtrace the

Re: dcache_readdir NULL inode oops

On Fri, Nov 09, 2018 at 03:58:56PM +, Will Deacon wrote: > On Fri, Nov 09, 2018 at 02:37:51PM +0000, Jan Glauber wrote: > > I'm seeing the following oops reproducible with upstream kernel on arm64 > > (ThunderX2): > > [...] > > > It happens after 1-3 hours o

Re: dcache_readdir NULL inode oops

On Fri, Nov 09, 2018 at 03:58:56PM +, Will Deacon wrote: > On Fri, Nov 09, 2018 at 02:37:51PM +0000, Jan Glauber wrote: > > I'm seeing the following oops reproducible with upstream kernel on arm64 > > (ThunderX2): > > [...] > > > It happens after 1-3 hours o

dcache_readdir NULL inode oops

Hi Al, I'm seeing the following oops reproducible with upstream kernel on arm64 (ThunderX2): [ 5428.795719] Unable to handle kernel NULL pointer dereference at virtual address 0040 [ 5428.813838] Mem abort info: [ 5428.820721] ESR = 0x9606 [ 5428.828476] Exception class =

dcache_readdir NULL inode oops

Hi Al, I'm seeing the following oops reproducible with upstream kernel on arm64 (ThunderX2): [ 5428.795719] Unable to handle kernel NULL pointer dereference at virtual address 0040 [ 5428.813838] Mem abort info: [ 5428.820721] ESR = 0x9606 [ 5428.828476] Exception class =

Re: KASAN: use-after-scope in ext4_group_desc_csum

On Fri, Oct 05, 2018 at 05:32:07PM +0200, Dmitry Vyukov wrote: [...] > This all makes me think that somebody else has left these 0xf8 in > shadow before ext4_map_blocks started executing. > Unfortunately debugging garbage in stack shadow is not completely > trivial and there is no common recipe.

Re: KASAN: use-after-scope in ext4_group_desc_csum

On Fri, Oct 05, 2018 at 05:32:07PM +0200, Dmitry Vyukov wrote: [...] > This all makes me think that somebody else has left these 0xf8 in > shadow before ext4_map_blocks started executing. > Unfortunately debugging garbage in stack shadow is not completely > trivial and there is no common recipe.

Re: KASAN: use-after-scope in ext4_group_desc_csum

On Fri, Oct 05, 2018 at 01:13:52PM +0200, Dmitry Vyukov wrote: > On Fri, Oct 5, 2018 at 12:16 PM, Jan Glauber wrote: > > Hi, > > > > I'm getting below warning when I enable CONFIG_KASAN_EXTRA=y on a arm64 > > ThunderX2 system. > > As far as I can tell

Re: KASAN: use-after-scope in ext4_group_desc_csum

On Fri, Oct 05, 2018 at 01:13:52PM +0200, Dmitry Vyukov wrote: > On Fri, Oct 5, 2018 at 12:16 PM, Jan Glauber wrote: > > Hi, > > > > I'm getting below warning when I enable CONFIG_KASAN_EXTRA=y on a arm64 > > ThunderX2 system. > > As far as I can tell

KASAN: use-after-scope in ext4_group_desc_csum

Hi, I'm getting below warning when I enable CONFIG_KASAN_EXTRA=y on a arm64 ThunderX2 system. As far as I can tell this is present since KASAN_EXTRA was introduced (4.16). [ 64.547333] == [ 64.561933] BUG: KASAN:

KASAN: use-after-scope in ext4_group_desc_csum

Hi, I'm getting below warning when I enable CONFIG_KASAN_EXTRA=y on a arm64 ThunderX2 system. As far as I can tell this is present since KASAN_EXTRA was introduced (4.16). [ 64.547333] == [ 64.561933] BUG: KASAN:

Re: [PATCH] EDAC, thunderx: Remove VLA usage

> [1] > https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.com > > Cc: David Daney > Cc: Jan Glauber > Cc: Borislav Petkov > Cc: Mauro Carvalho Chehab > Cc: linux-e...@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Jan Gl

Re: [PATCH] EDAC, thunderx: Remove VLA usage

> [1] > https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.com > > Cc: David Daney > Cc: Jan Glauber > Cc: Borislav Petkov > Cc: Mauro Carvalho Chehab > Cc: linux-e...@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Jan Gl

Re: [PATCH 4/4] i2c: xlp9xx: Add MAINTAINERS entry

On Tue, May 22, 2018 at 01:54:14PM +0200, Wolfram Sang wrote: > On Wed, May 16, 2018 at 12:00:19AM -0700, George Cherian wrote: > > The i2c XLP9xx driver is maintained by Cavium. > > Add George Cherian and Jan Glauber as the Maintainers. > > > > Signed-off-by:

Re: [PATCH 4/4] i2c: xlp9xx: Add MAINTAINERS entry

On Tue, May 22, 2018 at 01:54:14PM +0200, Wolfram Sang wrote: > On Wed, May 16, 2018 at 12:00:19AM -0700, George Cherian wrote: > > The i2c XLP9xx driver is maintained by Cavium. > > Add George Cherian and Jan Glauber as the Maintainers. > > > > Si

Re: [PATCH 1/2] arm64: defconfig: enable THUNDER_NIC_VF

On Fri, Mar 02, 2018 at 03:37:36PM +0100, Jan Glauber wrote: > Without this option the NIC on ThunderX1 is not coming up > so enable it to get a working network interface. > > Signed-off-by: Jan Glauber <jglau...@cavium.com> > --- > arch/arm64/configs/defconfig |

Re: [PATCH 1/2] arm64: defconfig: enable THUNDER_NIC_VF

On Fri, Mar 02, 2018 at 03:37:36PM +0100, Jan Glauber wrote: > Without this option the NIC on ThunderX1 is not coming up > so enable it to get a working network interface. > > Signed-off-by: Jan Glauber > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 inserti

Re: [PATCH] crypto: testmgr: Allow different compression results

On Thu, Apr 19, 2018 at 11:42:11AM +0800, Herbert Xu wrote: > On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > > goto out; > > } > > > &

Re: [PATCH] crypto: testmgr: Allow different compression results

On Thu, Apr 19, 2018 at 11:42:11AM +0800, Herbert Xu wrote: > On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > > goto out; > > } > > > &

[PATCH] crypto: testmgr: Allow different compression results

test. Do something similar for test_comp(). Signed-off-by: Mahipal Challa <mcha...@cavium.com> Signed-off-by: Balakrishna Bhamidipati <bbhamidip...@cavium.com> [jglau...@cavium.com: removed unrelated printk changes, rewrote commit msg, fixed whitespace and unneeded initialization] Signe

[PATCH] crypto: testmgr: Allow different compression results

lar for test_comp(). Signed-off-by: Mahipal Challa Signed-off-by: Balakrishna Bhamidipati [jglau...@cavium.com: removed unrelated printk changes, rewrote commit msg, fixed whitespace and unneeded initialization] Signed-off-by: Jan Glauber --- crypto/testmgr.c |

[PATCH v2 1/5] crypto: thunderx_zip: Fix fallout from CONFIG_VMAP_STACK

forever for the completion byte to contain a non-zero value. Allocating the result struct from 1:1 mapped memory resolves this bug. Signed-off-by: Jan Glauber <jglau...@cavium.com> Reviewed-by: Robert Richter <rrich...@cavium.com> Cc: stable <sta...@vger.kernel.org> # 4.14 --- dri

[PATCH v2 1/5] crypto: thunderx_zip: Fix fallout from CONFIG_VMAP_STACK

forever for the completion byte to contain a non-zero value. Allocating the result struct from 1:1 mapped memory resolves this bug. Signed-off-by: Jan Glauber Reviewed-by: Robert Richter Cc: stable # 4.14 --- drivers/crypto/cavium/zip/zip_crypto.c | 22 ++ 1 file changed, 14

[PATCH v2 5/5] crypto: thunderx_zip: Fix smp_processor_id() warnings

will occur but everything will continue to work, so just ignore it. Signed-off-by: Jan Glauber <jglau...@cavium.com> Reviewed-by: Robert Richter <rrich...@cavium.com> --- drivers/crypto/cavium/zip/zip_device.c | 4 ++-- drivers/crypto/cavium/zip/zip_main.c | 2 +- 2 files changed, 3 inse

[PATCH v2 5/5] crypto: thunderx_zip: Fix smp_processor_id() warnings

will occur but everything will continue to work, so just ignore it. Signed-off-by: Jan Glauber Reviewed-by: Robert Richter --- drivers/crypto/cavium/zip/zip_device.c | 4 ++-- drivers/crypto/cavium/zip/zip_main.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto

[PATCH v2 4/5] crypto: thunderx_zip: Fix statistics pending request value

The pending request counter was read from the wrong register. While at it, there is no need to use an atomic for it as it is only read localy in a loop. Signed-off-by: Jan Glauber <jglau...@cavium.com> Reviewed-by: Robert Richter <rrich...@cavium.com> --- drivers/crypto/cavium/zi

[PATCH v2 3/5] crypto: thunderx_zip: Prevent division by zero

Avoid two potential divisions by zero when calculating average values for the zip statistics. Signed-off-by: Jan Glauber <jglau...@cavium.com> Reviewed-by: Robert Richter <rrich...@cavium.com> --- drivers/crypto/cavium/zip/zip_main.c | 9 + 1 file changed, 5 insertions(+),

[PATCH v2 4/5] crypto: thunderx_zip: Fix statistics pending request value

The pending request counter was read from the wrong register. While at it, there is no need to use an atomic for it as it is only read localy in a loop. Signed-off-by: Jan Glauber Reviewed-by: Robert Richter --- drivers/crypto/cavium/zip/zip_main.c | 13 + drivers/crypto/cavium/zip

[PATCH v2 3/5] crypto: thunderx_zip: Prevent division by zero

Avoid two potential divisions by zero when calculating average values for the zip statistics. Signed-off-by: Jan Glauber Reviewed-by: Robert Richter --- drivers/crypto/cavium/zip/zip_main.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cavium/zip

[PATCH v2 2/5] crypto: thunderx_zip: Limit result reading attempts

and a small delay between the reading attempts. Signed-off-by: Jan Glauber <jglau...@cavium.com> Reviewed-by: Robert Richter <rrich...@cavium.com> Cc: stable <sta...@vger.kernel.org> # 4.14 --- drivers/crypto/cavium/zip/common.h | 21 + drivers/crypto/cavium/zip/

[PATCH v2 2/5] crypto: thunderx_zip: Limit result reading attempts

and a small delay between the reading attempts. Signed-off-by: Jan Glauber Reviewed-by: Robert Richter Cc: stable # 4.14 --- drivers/crypto/cavium/zip/common.h | 21 + drivers/crypto/cavium/zip/zip_deflate.c | 4 ++-- drivers/crypto/cavium/zip/zip_inflate.c | 4 ++-- 3 files

[PATCH v2 0/5] ThunderX ZIP driver bug fixes

Some bug fixes for this driver after it stopped working with virtual mapped stacks. I think the first two patches qualify for stable. Jan Glauber (5): crypto: thunderx_zip: Fix fallout from CONFIG_VMAP_STACK crypto: thunderx_zip: Limit result reading attempts crypto: thunderx_zip: Prevent

[PATCH v2 0/5] ThunderX ZIP driver bug fixes

Some bug fixes for this driver after it stopped working with virtual mapped stacks. I think the first two patches qualify for stable. Jan Glauber (5): crypto: thunderx_zip: Fix fallout from CONFIG_VMAP_STACK crypto: thunderx_zip: Limit result reading attempts crypto: thunderx_zip: Prevent

Re: [PATCH 1/2] crypto: thunderx_zip: Fix fallout from CONFIG_VMAP_STACK

On Wed, Mar 28, 2018 at 03:05:56PM +0200, Jan Glauber wrote: > Enabling virtual mapped kernel stacks breaks the thunderx_zip > driver. On compression or decompression the executing CPU hangs > in an endless loop. The reason for this is the usage of __pa > by the driver which does no

Re: [PATCH 1/2] crypto: thunderx_zip: Fix fallout from CONFIG_VMAP_STACK

On Wed, Mar 28, 2018 at 03:05:56PM +0200, Jan Glauber wrote: > Enabling virtual mapped kernel stacks breaks the thunderx_zip > driver. On compression or decompression the executing CPU hangs > in an endless loop. The reason for this is the usage of __pa > by the driver which does no

[PATCH 1/2] crypto: thunderx_zip: Fix fallout from CONFIG_VMAP_STACK

forever for the completion byte to contain a non-zero value. Allocating the result struct from 1:1 mapped memory resolves this bug. Signed-off-by: Jan Glauber <jglau...@cavium.com> Reviewed-by: Robert Richter <rrich...@cavium.com> Cc: stable <sta...@vger.kernel.org> # 4.14 --- dri

[PATCH 1/2] crypto: thunderx_zip: Fix fallout from CONFIG_VMAP_STACK

forever for the completion byte to contain a non-zero value. Allocating the result struct from 1:1 mapped memory resolves this bug. Signed-off-by: Jan Glauber Reviewed-by: Robert Richter Cc: stable # 4.14 --- drivers/crypto/cavium/zip/zip_crypto.c | 22 ++ 1 file changed, 14

[PATCH 2/2] crypto: thunderx_zip: Limit result reading attempts

and a small delay between the reading attempts. Signed-off-by: Jan Glauber <jglau...@cavium.com> Reviewed-by: Robert Richter <rrich...@cavium.com> Cc: stable <sta...@vger.kernel.org> # 4.14 --- drivers/crypto/cavium/zip/common.h | 22 ++ drivers/crypto/cavium/zip/

[PATCH 2/2] crypto: thunderx_zip: Limit result reading attempts

and a small delay between the reading attempts. Signed-off-by: Jan Glauber Reviewed-by: Robert Richter Cc: stable # 4.14 --- drivers/crypto/cavium/zip/common.h | 22 ++ drivers/crypto/cavium/zip/zip_deflate.c | 4 ++-- drivers/crypto/cavium/zip/zip_inflate.c | 4 ++-- 3 files

Re: [PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

On Mon, Mar 26, 2018 at 11:28:28AM +0200, Arnd Bergmann wrote: > On Mon, Mar 26, 2018 at 10:52 AM, Jan Glauber > <jan.glau...@caviumnetworks.com> wrote: > > On Tue, Mar 06, 2018 at 03:02:01PM +0100, Jan Glauber wrote: > >> On Tue, Mar 06, 2018 at 02:12:29PM

Re: [PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

On Mon, Mar 26, 2018 at 11:28:28AM +0200, Arnd Bergmann wrote: > On Mon, Mar 26, 2018 at 10:52 AM, Jan Glauber > wrote: > > On Tue, Mar 06, 2018 at 03:02:01PM +0100, Jan Glauber wrote: > >> On Tue, Mar 06, 2018 at 02:12:29PM +0100, Arnd Bergmann wrote: > >> > On

Re: [PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

On Tue, Mar 06, 2018 at 03:02:01PM +0100, Jan Glauber wrote: > On Tue, Mar 06, 2018 at 02:12:29PM +0100, Arnd Bergmann wrote: > > On Fri, Mar 2, 2018 at 3:37 PM, Jan Glauber <jglau...@cavium.com> wrote: > > > ThunderX1 dual socket has 96 CPUs and ThunderX2 has 224 CPUs. >

Re: [PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

On Tue, Mar 06, 2018 at 03:02:01PM +0100, Jan Glauber wrote: > On Tue, Mar 06, 2018 at 02:12:29PM +0100, Arnd Bergmann wrote: > > On Fri, Mar 2, 2018 at 3:37 PM, Jan Glauber wrote: > > > ThunderX1 dual socket has 96 CPUs and ThunderX2 has 224 CPUs. > > > > Are you

Re: [PATCH v2] i2c: xlp9xx: Add support for SMBAlert

is the i2c controller main interrupt. > > > > Signed-off-by: Kamlakant Patel <kamlakant.pa...@cavium.com> > > Signed-off-by: George Cherian <george.cher...@cavium.com> > > Are the previous reviewers happy now? Reviewed-by: Jan Glauber <jglau...@ca

Re: [PATCH v2] i2c: xlp9xx: Add support for SMBAlert

is the i2c controller main interrupt. > > > > Signed-off-by: Kamlakant Patel > > Signed-off-by: George Cherian > > Are the previous reviewers happy now? Reviewed-by: Jan Glauber > > --- > > drivers/i2c/busses/i2c-xlp9xx.c | 24

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

On Wed, Mar 14, 2018 at 07:29:37PM +, Ard Biesheuvel wrote: > This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. FWIW, the revert fixes the boot hang I'm seeing on ThunderX1. --Jan > Commit 864b75f9d6b0 ("mm/page_alloc: fix memmap_init_zone pageblock > alignment") modified the

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

On Wed, Mar 14, 2018 at 07:29:37PM +, Ard Biesheuvel wrote: > This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. FWIW, the revert fixes the boot hang I'm seeing on ThunderX1. --Jan > Commit 864b75f9d6b0 ("mm/page_alloc: fix memmap_init_zone pageblock > alignment") modified the

Re: [PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

On Tue, Mar 06, 2018 at 02:12:29PM +0100, Arnd Bergmann wrote: > On Fri, Mar 2, 2018 at 3:37 PM, Jan Glauber <jglau...@cavium.com> wrote: > > ThunderX1 dual socket has 96 CPUs and ThunderX2 has 224 CPUs. > > Are you sure about those numbers? From my counting, I would

Re: [PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

On Tue, Mar 06, 2018 at 02:12:29PM +0100, Arnd Bergmann wrote: > On Fri, Mar 2, 2018 at 3:37 PM, Jan Glauber wrote: > > ThunderX1 dual socket has 96 CPUs and ThunderX2 has 224 CPUs. > > Are you sure about those numbers? From my counting, I would have expected > twice that nu

Re: [PATCHv2 1/3] i2c: xlp9xx: Check for Bus state before every transfer

I don't know how valuable same-company reviewed-by's are in the end, but the patches look good to me with the small change in SMBalert, so you could add: Reviewed-by: Jan Glauber <jglau...@cavium.com> --Jan On Tue, Feb 27, 2018 at 01:26:18PM +, George Cherian wrote: > I2C b

Re: [PATCHv2 1/3] i2c: xlp9xx: Check for Bus state before every transfer

I don't know how valuable same-company reviewed-by's are in the end, but the patches look good to me with the small change in SMBalert, so you could add: Reviewed-by: Jan Glauber --Jan On Tue, Feb 27, 2018 at 01:26:18PM +, George Cherian wrote: > I2C bus enters the STOP condition af

Re: [PATCH 3/3] i2c: xlp9xx: Add support for SMBAlert

On Tue, Feb 27, 2018 at 01:26:20PM +, George Cherian wrote: > Add support for SMBus alert mechanism to i2c-xlp9xx driver. > The second interrupt is parsed to use for SMBus alert. > The first interrupt is the i2c controller main interrupt. > > Signed-off-by: Kamlakant Patel

Re: [PATCH 3/3] i2c: xlp9xx: Add support for SMBAlert

On Tue, Feb 27, 2018 at 01:26:20PM +, George Cherian wrote: > Add support for SMBus alert mechanism to i2c-xlp9xx driver. > The second interrupt is parsed to use for SMBus alert. > The first interrupt is the i2c controller main interrupt. > > Signed-off-by: Kamlakant Patel > Signed-off-by:

[PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

ThunderX1 dual socket has 96 CPUs and ThunderX2 has 224 CPUs. Therefore raise the default number of CPUs from 64 to 256 by adding an arm64 specific option to override the generic default. Signed-off-by: Jan Glauber <jglau...@cavium.com> --- arch/arm64/configs/defconfig | 1 + 1 file chan

[PATCH 2/2] arm64: defconfig: Raise NR_CPUS to 256

ThunderX1 dual socket has 96 CPUs and ThunderX2 has 224 CPUs. Therefore raise the default number of CPUs from 64 to 256 by adding an arm64 specific option to override the generic default. Signed-off-by: Jan Glauber --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 1/2] arm64: defconfig: enable THUNDER_NIC_VF

Without this option the NIC on ThunderX1 is not coming up so enable it to get a working network interface. Signed-off-by: Jan Glauber <jglau...@cavium.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/c

[PATCH 1/2] arm64: defconfig: enable THUNDER_NIC_VF

Without this option the NIC on ThunderX1 is not coming up so enable it to get a working network interface. Signed-off-by: Jan Glauber --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH] i2c: octeon: Prevent error message on bus error

The error message: [Fri Feb 16 13:42:13 2018] i2c-thunderx :01:09.4: unhandled state: 0 is mis-leading as state 0 (bus error) is not an unknown state. Return -EIO as before but avoid printing the message. Also rename STAT_ERROR to STATE_BUS_ERROR. Signed-off-by: Jan Glauber <jg

[PATCH] i2c: octeon: Prevent error message on bus error

The error message: [Fri Feb 16 13:42:13 2018] i2c-thunderx :01:09.4: unhandled state: 0 is mis-leading as state 0 (bus error) is not an unknown state. Return -EIO as before but avoid printing the message. Also rename STAT_ERROR to STATE_BUS_ERROR. Signed-off-by: Jan Glauber --- drivers

Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files

Hi Will, I just hit the same issue with 4.16-rc2. The patch makes it compilable again. --Jan On Mon, Feb 19, 2018 at 11:02:39AM +, Will Deacon wrote: > Hi John, > > On Mon, Feb 19, 2018 at 10:19:35AM +, John Garry wrote: > > On 19/02/2018 06:39, Bhupesh Sharma wrote: > > >Since commit

Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files

Hi Will, I just hit the same issue with 4.16-rc2. The patch makes it compilable again. --Jan On Mon, Feb 19, 2018 at 11:02:39AM +, Will Deacon wrote: > Hi John, > > On Mon, Feb 19, 2018 at 10:19:35AM +, John Garry wrote: > > On 19/02/2018 06:39, Bhupesh Sharma wrote: > > >Since commit

Re: [Bug fix] octeon-i2c driver updates

his patch? > > BR, > Sean Zhang > > -Original Message- > From: Zhang, Sean C. (NSB - CN/Hangzhou) > Sent: Monday, November 27, 2017 4:38 PM > To: 'Jan Glauber' <jan.glau...@caviumnetworks.com> > Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.k

Re: [Bug fix] octeon-i2c driver updates

his patch? > > BR, > Sean Zhang > > -Original Message- > From: Zhang, Sean C. (NSB - CN/Hangzhou) > Sent: Monday, November 27, 2017 4:38 PM > To: 'Jan Glauber' > Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.

Re: [Bug fix] octeon-i2c driver updates

On Thu, Nov 23, 2017 at 11:42:36AM +, Zhang, Sean C. (NSB - CN/Hangzhou) wrote: > Dear Maintainer, > > For octeon TWSI controller, I found below two cases, maybe can be improved. Hi Sean, form the description below this looks like you're fixing a bug. Can you elaborate on when the I2C bus

Re: [Bug fix] octeon-i2c driver updates

On Thu, Nov 23, 2017 at 11:42:36AM +, Zhang, Sean C. (NSB - CN/Hangzhou) wrote: > Dear Maintainer, > > For octeon TWSI controller, I found below two cases, maybe can be improved. Hi Sean, form the description below this looks like you're fixing a bug. Can you elaborate on when the I2C bus

Re: MCP251x SPI CAN controller on Cavium ThunderX

On Wed, Nov 15, 2017 at 02:31:45PM +0100, Marc Kleine-Budde wrote: > On 11/15/2017 01:40 PM, Marc Kleine-Budde wrote: > > mcp251x_spi_trans() is called with len=3, > > priv->spi_tx_buf and priv->spi_rx_buf point to previously allocared memory > > > > priv->spi_tx_buf has been filled before

Re: MCP251x SPI CAN controller on Cavium ThunderX

On Wed, Nov 15, 2017 at 02:31:45PM +0100, Marc Kleine-Budde wrote: > On 11/15/2017 01:40 PM, Marc Kleine-Budde wrote: > > mcp251x_spi_trans() is called with len=3, > > priv->spi_tx_buf and priv->spi_rx_buf point to previously allocared memory > > > > priv->spi_tx_buf has been filled before

Re: MCP251x SPI CAN controller on Cavium ThunderX

On Wed, Nov 15, 2017 at 11:54:20AM +0100, Marc Kleine-Budde wrote: > On 11/14/2017 01:02 PM, Mark Brown wrote: > > On Mon, Nov 13, 2017 at 01:17:42PM -0800, Tim Harvey wrote: > > > >> When a register is read from the mcp251x driver the > >> octeon_spi_do_transfer() gets a spi_message with a

Re: MCP251x SPI CAN controller on Cavium ThunderX

On Wed, Nov 15, 2017 at 11:54:20AM +0100, Marc Kleine-Budde wrote: > On 11/14/2017 01:02 PM, Mark Brown wrote: > > On Mon, Nov 13, 2017 at 01:17:42PM -0800, Tim Harvey wrote: > > > >> When a register is read from the mcp251x driver the > >> octeon_spi_do_transfer() gets a spi_message with a

[PATCH] MAINTAINERS: Split Cavium EDAC entry and add myself

Split the Cavium EDAC entry into MIPS and ARM drivers because they have different maintainers and mailing lists. Add myself as additional maintainer to the ThunderX driver. Signed-off-by: Jan Glauber <jglau...@cavium.com> --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 de

[PATCH] MAINTAINERS: Split Cavium EDAC entry and add myself

Split the Cavium EDAC entry into MIPS and ARM drivers because they have different maintainers and mailing lists. Add myself as additional maintainer to the ThunderX driver. Signed-off-by: Jan Glauber --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: net/sunrpc: v4.14-rc4 lockdep warning

Hi Trond, is there a patch available for this issue? I'm running into with 4.14-rc5 on my ARM64 board. thanks, Jan 2017-10-11 19:49 GMT+02:00 Trond Myklebust : > On Tue, 2017-10-10 at 10:19 -0700, t...@kernel.org wrote: >> Hello, >> >> On Tue, Oct 10, 2017 at 04:48:57PM

Re: net/sunrpc: v4.14-rc4 lockdep warning

Hi Trond, is there a patch available for this issue? I'm running into with 4.14-rc5 on my ARM64 board. thanks, Jan 2017-10-11 19:49 GMT+02:00 Trond Myklebust : > On Tue, 2017-10-10 at 10:19 -0700, t...@kernel.org wrote: >> Hello, >> >> On Tue, Oct 10, 2017 at 04:48:57PM +, Trond Myklebust

Re: [PATCH 0/6] Switch arm64 over to qrwlock

esults are _way_ better. Also, with the old implementation above test hung the machine which does not happen with the queued variant. If you want you can add: Tested-by: Jan Glauber <jglau...@cavium.com> --Jan > Cheers, > > Will > > --->8 > > Will Deacon (6): >

Re: [PATCH 0/6] Switch arm64 over to qrwlock

better. Also, with the old implementation above test hung the machine which does not happen with the queued variant. If you want you can add: Tested-by: Jan Glauber --Jan > Cheers, > > Will > > --->8 > > Will Deacon (6): > kernel/locking: Use struct qrwlock instead of struct __q

Re: [PATCH v10 3/7] edac,soc: thunderx: Add wrapper for EDAC LMC PCI device

On Wed, Sep 27, 2017 at 06:19:01PM +0200, Borislav Petkov wrote: > On Mon, Sep 25, 2017 at 02:34:58PM +0200, Jan Glauber wrote: > > Cavium SOCs contain a memory controller that is presented as a > > PCI device. This PCI device will be used by an EDAC driver and >

Re: [PATCH v10 3/7] edac,soc: thunderx: Add wrapper for EDAC LMC PCI device

On Wed, Sep 27, 2017 at 06:19:01PM +0200, Borislav Petkov wrote: > On Mon, Sep 25, 2017 at 02:34:58PM +0200, Jan Glauber wrote: > > Cavium SOCs contain a memory controller that is presented as a > > PCI device. This PCI device will be used by an EDAC driver and >

Re: [v4,0/3] Workaround for bus/slot reset on Cavium cn8xxx root ports

gt; > > > WBBR, > > Vadim > > > > On Fri, Sep 08, 2017 at 10:10:30AM +0200, Jan Glauber wrote: > > > Using vfio-pci on a combination of cn8xxx and some PCI devices results in > > > a kernel panic. This is triggered by issuing a bus or a slot reset >

Re: [v4,0/3] Workaround for bus/slot reset on Cavium cn8xxx root ports

m > > > > On Fri, Sep 08, 2017 at 10:10:30AM +0200, Jan Glauber wrote: > > > Using vfio-pci on a combination of cn8xxx and some PCI devices results in > > > a kernel panic. This is triggered by issuing a bus or a slot reset > > > on the PCI device. > >

[PATCH v10 2/7] perf: export perf_event_update_userpage()

Export perf_event_update_userpage(). This change is needed to allow building a PMU driver as a kernel module. Cc: Peter Zijlstra <pet...@infradead.org> Cc: Ingo Molnar <mi...@redhat.com> Cc: Arnaldo Carvalho de Melo <a...@kernel.org> Signed-off-by: Jan Glauber <jglau...@ca

[PATCH v10 0/7] Cavium ARM64 uncore PMU support

alphabetic ordering in some places - Store pmu name in struct pmu - Use devm_* - Remove mapping of LMC events, expose hardware event numbers directly - Simplify event removal Changes to v8: - Wrapper for PCI devices Jan Glauber (7): edac: thunderx: Remove suspend/resume support pe

[PATCH v10 2/7] perf: export perf_event_update_userpage()

Export perf_event_update_userpage(). This change is needed to allow building a PMU driver as a kernel module. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Signed-off-by: Jan Glauber --- kernel/events/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/events

[PATCH v10 0/7] Cavium ARM64 uncore PMU support

alphabetic ordering in some places - Store pmu name in struct pmu - Use devm_* - Remove mapping of LMC events, expose hardware event numbers directly - Simplify event removal Changes to v8: - Wrapper for PCI devices Jan Glauber (7): edac: thunderx: Remove suspend/resume support pe

  1   2   3   4   5   6   7   8   9   10   >