Re: [PATCH] ASoC: max98090 not need to return fail if fail to request hpdet irq.

2014-07-30 Thread Jarkko Nikula
On 07/30/2014 04:50 AM, jianqun wrote: From: xujianqun x...@rock-chips.com Since hardware may not MUST to use IRQ pin of max98090 as jack detect, the driver can work well without it, can report jack trigger to CPU by a GPIO. But here driver will register fail caused by failed to request irq.

Re: [alsa-devel] [PATCH] ASoC: max98090 add irq valid check

2014-07-30 Thread Jarkko Nikula
Hi On 07/30/2014 11:54 AM, jianqun wrote: From: Jianqun x...@rock-chips.com Since IRQ pin from max98090 may NC, the irq number will be zero, that is invalid for request_threaded_irq, so just add irq valid check there. Since hardware may not MUST to use IRQ pin of max98090 as jack detect, the

Re: [PATCH] ASoC: Intel: avoid format string leak to thread name

2014-05-23 Thread Jarkko Nikula
mes from sound/soc/intel/sst-acpi.c so only developer can hit this but to be on safe side: Acked-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ASoC: Intel: avoid format string leak to thread name

2014-05-23 Thread Jarkko Nikula
developer can hit this but to be on safe side: Acked-by: Jarkko Nikula jarkko.nik...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH] sound: soc: intel: remove unneeded dependency from Makefile

2014-05-09 Thread Jarkko Nikula
introduced in 1eee978f4258 ("ASoC: Intel: split the pcm and compress to different files"). Vinod, do you have something coming soon to these Makefiles or would it be better take this now? Tested-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [alsa-devel] [PATCH] sound: soc: intel: remove unneeded dependency from Makefile

2014-05-09 Thread Jarkko Nikula
(ASoC: Intel: split the pcm and compress to different files). Vinod, do you have something coming soon to these Makefiles or would it be better take this now? Tested-by: Jarkko Nikula jarkko.nik...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: randconfig build error with next-20140226, in sound/soc/intel/sst-baytrail-ipc.c

2014-02-26 Thread Jarkko Nikula
On 02/26/2014 04:36 PM, Jim Davis wrote: Building with the attached random configuration file, sound/soc/intel/sst-baytrail-ipc.c: In function 'sst_byt_get_dsp_position': sound/soc/intel/sst-baytrail-ipc.c:743:2: error: implicit declaration of function 'memcpy_fromio'

Re: randconfig build error with next-20140226, in sound/soc/intel/sst-baytrail-ipc.c

2014-02-26 Thread Jarkko Nikula
On 02/26/2014 04:36 PM, Jim Davis wrote: Building with the attached random configuration file, sound/soc/intel/sst-baytrail-ipc.c: In function 'sst_byt_get_dsp_position': sound/soc/intel/sst-baytrail-ipc.c:743:2: error: implicit declaration of function 'memcpy_fromio'

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-19 Thread Jarkko Nikula
On 01/17/2014 05:57 PM, Mark Brown wrote: On Fri, Jan 17, 2014 at 09:37:56AM +0200, Jarkko Nikula wrote: Sidenote: actually this modalias/module loading issue is different and not related to stable ACPI i2c/spi slave device names. Oh, I'd been under the impression that it was the rewrite

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-19 Thread Jarkko Nikula
On 01/17/2014 05:57 PM, Mark Brown wrote: On Fri, Jan 17, 2014 at 09:37:56AM +0200, Jarkko Nikula wrote: Sidenote: actually this modalias/module loading issue is different and not related to stable ACPI i2c/spi slave device names. Oh, I'd been under the impression that it was the rewrite

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Jarkko Nikula
On 01/16/2014 09:46 PM, Mark Brown wrote: On Thu, Jan 16, 2014 at 09:05:09PM +0800, Zhang Rui wrote: On Thu, 2014-01-16 at 13:27 +0100, Wolfram Sang wrote: This seems a gap to me but I'm not 100% sure. I saw Grant Likely introduced the OF style MODALIAS to platform bus, and OF style

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Jarkko Nikula
On 01/16/2014 09:46 PM, Mark Brown wrote: On Thu, Jan 16, 2014 at 09:05:09PM +0800, Zhang Rui wrote: On Thu, 2014-01-16 at 13:27 +0100, Wolfram Sang wrote: This seems a gap to me but I'm not 100% sure. I saw Grant Likely introduced the OF style MODALIAS to platform bus, and OF style

Re: [PATCH] spi: Check conflicting CS based on spi->chip_select instead of device name

2014-01-09 Thread Jarkko Nikula
uld work regardless what the device name will be in future. Cc: Jarkko Nikula Signed-off-by: Mika Westerberg --- drivers/spi/spi.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 349ebba4b199..13dcc360bde6 100

Re: [PATCH] spi: Check conflicting CS based on spi-chip_select instead of device name

2014-01-09 Thread Jarkko Nikula
regardless what the device name will be in future. Cc: Jarkko Nikula jarkko.nik...@linux.intel.com Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/spi/spi.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi.c b

Re: [RFC 4/4] ASoC: RX-51: Add DT support to sound driver

2013-11-30 Thread Jarkko Nikula
Hi On 11/06/2013 04:32 PM, Pavel Machek wrote: > Hi! > >> This patch adds device tree support to the Nokia N900 audio driver. > > Note, N900 audio driver. > >> +- compatible: "nokia,rx51-audio" > > Still, it is rx51-audio. If it is feasible, could we move away from > rx51 naming and into n900

Re: [RFC 4/4] ASoC: RX-51: Add DT support to sound driver

2013-11-30 Thread Jarkko Nikula
Hi On 11/06/2013 04:32 PM, Pavel Machek wrote: Hi! This patch adds device tree support to the Nokia N900 audio driver. Note, N900 audio driver. +- compatible: nokia,rx51-audio Still, it is rx51-audio. If it is feasible, could we move away from rx51 naming and into n900 naming that

Re: [RFC 16/23] ASoC: omap: mcbsp, mcpdm, dmic: raw read and write endian fix

2013-11-16 Thread Jarkko Nikula
looking at the _relaxed definitions in arch/arm/include/asm/io.h. Acked-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC 16/23] ASoC: omap: mcbsp, mcpdm, dmic: raw read and write endian fix

2013-11-16 Thread Jarkko Nikula
by looking at the _relaxed definitions in arch/arm/include/asm/io.h. Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/3] ACPI: add module autoloading support for ACPI enumerated devices

2013-10-14 Thread Jarkko Nikula
all. Will add it in next version. You could have my pre- "Tested-by: Jarkko Nikula ". With your set I see bunch of failing modprobe calls from udev for i2c:INTABCD:xy and platform:INTDCBA:xy modaliases gone. -- Jarkko -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 1/3] ACPI: add module autoloading support for ACPI enumerated devices

2013-10-14 Thread Jarkko Nikula
all. Will add it in next version. You could have my pre- Tested-by: Jarkko Nikula jarkko.nik...@linux.intel.com. With your set I see bunch of failing modprobe calls from udev for i2c:INTABCD:xy and platform:INTDCBA:xy modaliases gone. -- Jarkko -- To unsubscribe from this list: send the line

Re: [PATCH 1/6] ASoC: omap: simplify platform_get_resource_byname/devm_ioremap_resource

2013-08-19 Thread Jarkko Nikula
sound/soc/omap/omap-mcpdm.c |3 --- > 2 files changed, 3 insertions(+), 9 deletions(-) > To the patch and catch of missing clock release in omap-dmic.c in case of failing devm_ioremap_resource: Acked-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

Re: [PATCH 1/6] ASoC: omap: simplify platform_get_resource_byname/devm_ioremap_resource

2013-08-19 Thread Jarkko Nikula
deletions(-) To the patch and catch of missing clock release in omap-dmic.c in case of failing devm_ioremap_resource: Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] ASoC: OMAP: Remove obsolete Makefile line

2013-05-30 Thread Jarkko Nikula
Makefile | 1 - > 1 file changed, 1 deletion(-) > True, commit 91d94af ("omap: Remove support for omap2evm") removed only omap2evm.o. Acked-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majo

Re: [PATCH] ASoC: OMAP: Remove obsolete Makefile line

2013-05-30 Thread Jarkko Nikula
/Makefile | 1 - 1 file changed, 1 deletion(-) True, commit 91d94af (omap: Remove support for omap2evm) removed only omap2evm.o. Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] omap: convert to devm_ioremap_resource()

2013-03-11 Thread Jarkko Nikula
error messages can be removed from the failure code paths. > > Signed-off-by: Silviu-Mihai Popescu > --- > sound/soc/omap/omap-dmic.c |9 +++-- > sound/soc/omap/omap-mcpdm.c |8 +++- > 2 files changed, 6 insertions(+), 11 deletions(-) > Acked-by: Jarkko Niku

Re: [PATCH] omap: convert to devm_ioremap_resource()

2013-03-11 Thread Jarkko Nikula
be removed from the failure code paths. Signed-off-by: Silviu-Mihai Popescu silviupopescu1...@gmail.com --- sound/soc/omap/omap-dmic.c |9 +++-- sound/soc/omap/omap-mcpdm.c |8 +++- 2 files changed, 6 insertions(+), 11 deletions(-) Acked-by: Jarkko Nikula jarkko.nik

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-09 Thread Jarkko Nikula
ve for omap1 and omap2+. Acked-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-09 Thread Jarkko Nikula
for omap1 and omap2+. Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH v2] watchdog: omap_wdt: convert to new watchdog core

2012-09-10 Thread Jarkko Nikula
; crash as device was probably accessed with some clocks off. Thanks to > Jarkko Nikula for reporting this. > > drivers/watchdog/Kconfig|1 + > drivers/watchdog/omap_wdt.c | 266 > ++- > 2 files changed, 114 insertions(+), 153 de

Re: [PATCH v2] watchdog: omap_wdt: convert to new watchdog core

2012-09-10 Thread Jarkko Nikula
as device was probably accessed with some clocks off. Thanks to Jarkko Nikula jarkko.nik...@bitmer.com for reporting this. drivers/watchdog/Kconfig|1 + drivers/watchdog/omap_wdt.c | 266 ++- 2 files changed, 114 insertions(+), 153 deletions

Re: [PATCH] watchdog: omap_wdt: convert to new watchdog core

2012-09-07 Thread Jarkko Nikula
On Fri, Sep 07, 2012 at 06:51:43PM +0300, Aaro Koskinen wrote: > Thanks for the report! I'll look into this and test with other > Nokia boards. I tested the patch only with N800 and v3.6-rc4 > (4cbe5a555fa58a79b6ecbb6c531b8bab0650778d) and did not see any issues > with normal use cases (boot,

Re: [PATCH] watchdog: omap_wdt: convert to new watchdog core

2012-09-07 Thread Jarkko Nikula
Hi On Tue, Sep 04, 2012 at 05:41:24PM +0300, Aaro Koskinen wrote: > Convert omap_wdt to new watchdog core. On OMAP boards, there are usually > multiple watchdogs. Since the new watchdog core supports multiple > watchdogs, all watchdog drivers used on OMAP should be converted. > > The legacy

Re: [PATCH] watchdog: omap_wdt: convert to new watchdog core

2012-09-07 Thread Jarkko Nikula
Hi On Tue, Sep 04, 2012 at 05:41:24PM +0300, Aaro Koskinen wrote: Convert omap_wdt to new watchdog core. On OMAP boards, there are usually multiple watchdogs. Since the new watchdog core supports multiple watchdogs, all watchdog drivers used on OMAP should be converted. The legacy watchdog

Re: [PATCH] watchdog: omap_wdt: convert to new watchdog core

2012-09-07 Thread Jarkko Nikula
On Fri, Sep 07, 2012 at 06:51:43PM +0300, Aaro Koskinen wrote: Thanks for the report! I'll look into this and test with other Nokia boards. I tested the patch only with N800 and v3.6-rc4 (4cbe5a555fa58a79b6ecbb6c531b8bab0650778d) and did not see any issues with normal use cases (boot,

Re: [PATCH 4/9] sound/soc/omap/am3517evm.c: fix error return code

2012-08-20 Thread Jarkko Nikula
= snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_FSR_SRC_FSX, 0, > SND_SOC_CLOCK_IN); > if (ret < 0) { > printk(KERN_ERR "can't set CPU system clock > OMAP_MCBSP_FSR_SRC_FSX\n"); > Acked-by: Jarkko Nikula -- To unsubscribe from th

Re: [PATCH 4/9] sound/soc/omap/am3517evm.c: fix error return code

2012-08-20 Thread Jarkko Nikula
) { printk(KERN_ERR can't set CPU system clock OMAP_MCBSP_FSR_SRC_FSX\n); Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 84/90] ARM: OMAP: Update changed TSC2301 config names in N800 board files

2007-04-05 Thread Jarkko Nikula
On Wed, 4 Apr 2007 14:06:03 -0400 "ext Tony Lindgren" <[EMAIL PROTECTED]> wrote: > From: Jarkko Nikula <[EMAIL PROTECTED]> > > Signed-off-by: Jarkko Nikula <[EMAIL PROTECTED]> > Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> > --- > arch

Re: [PATCH 84/90] ARM: OMAP: Update changed TSC2301 config names in N800 board files

2007-04-05 Thread Jarkko Nikula
On Wed, 4 Apr 2007 14:06:03 -0400 ext Tony Lindgren [EMAIL PROTECTED] wrote: From: Jarkko Nikula [EMAIL PROTECTED] Signed-off-by: Jarkko Nikula [EMAIL PROTECTED] Signed-off-by: Tony Lindgren [EMAIL PROTECTED] --- arch/arm/mach-omap2/board-n800-audio.c |2 +- arch/arm/mach-omap2

<    1   2   3   4   5