Re: [RFC] cgroup simplify space stripping

2007-10-27 Thread Jason Uhlenkott
On Fri, Oct 26, 2007 at 22:50:45 -0700, Jason Uhlenkott wrote: > Could be BUILD_BUG_ON, even. Oh, never mind -- I see you've reached that conclusion in the other thread. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PR

Re: [RFC] cgroup simplify space stripping

2007-10-27 Thread Jason Uhlenkott
On Fri, Oct 26, 2007 at 22:50:45 -0700, Jason Uhlenkott wrote: Could be BUILD_BUG_ON, even. Oh, never mind -- I see you've reached that conclusion in the other thread. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [RFC] cgroup simplify space stripping

2007-10-26 Thread Jason Uhlenkott
On Wed, Oct 24, 2007 at 10:36:21 -0700, Paul Jackson wrote: > From: Paul Jackson <[EMAIL PROTECTED]> > > Simplify the space stripping code in cgroup file write. > > Signed-off-by: Paul Jackson <[EMAIL PROTECTED]> > > --- > > This patch applies after both: > Adrian Bunk's: [2.6 patch]

Re: [patch 1/1] Drop CAP_SYS_RAWIO requirement for FIBMAP

2007-10-26 Thread Jason Uhlenkott
On Fri, Oct 26, 2007 at 14:59:57 -0700, Mike Waychison wrote: > Jason Uhlenkott wrote: > >Additionally, ext3_bmap() has this to say about it: > > > >if (EXT3_I(inode)->i_state & EXT3_STATE_JDATA) { > >/* > >

Re: [patch 1/1] Drop CAP_SYS_RAWIO requirement for FIBMAP

2007-10-26 Thread Jason Uhlenkott
On Fri, Oct 26, 2007 at 01:22:17 +0100, Alan Cox wrote: > On Thu, 25 Oct 2007 16:06:40 -0700 > Mike Waychison <[EMAIL PROTECTED]> wrote: > > > Remove the need for having CAP_SYS_RAWIO when doing a FIBMAP call on an > > open file descriptor. > > > > It would be nice to allow users to have

Re: [patch 1/1] Drop CAP_SYS_RAWIO requirement for FIBMAP

2007-10-26 Thread Jason Uhlenkott
On Fri, Oct 26, 2007 at 01:22:17 +0100, Alan Cox wrote: On Thu, 25 Oct 2007 16:06:40 -0700 Mike Waychison [EMAIL PROTECTED] wrote: Remove the need for having CAP_SYS_RAWIO when doing a FIBMAP call on an open file descriptor. It would be nice to allow users to have permission to see

Re: [patch 1/1] Drop CAP_SYS_RAWIO requirement for FIBMAP

2007-10-26 Thread Jason Uhlenkott
On Fri, Oct 26, 2007 at 14:59:57 -0700, Mike Waychison wrote: Jason Uhlenkott wrote: Additionally, ext3_bmap() has this to say about it: if (EXT3_I(inode)-i_state EXT3_STATE_JDATA) { /* * This is a REALLY heavyweight approach, but the use

Re: [RFC] cgroup simplify space stripping

2007-10-26 Thread Jason Uhlenkott
On Wed, Oct 24, 2007 at 10:36:21 -0700, Paul Jackson wrote: From: Paul Jackson [EMAIL PROTECTED] Simplify the space stripping code in cgroup file write. Signed-off-by: Paul Jackson [EMAIL PROTECTED] --- This patch applies after both: Adrian Bunk's: [2.6 patch] kernel/cgroup.c:

Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions

2007-10-19 Thread Jason Uhlenkott
On Fri, Oct 19, 2007 at 14:11:18 -0700, Andrew Morton wrote: > On Fri, 19 Oct 2007 13:18:23 -0600 > [EMAIL PROTECTED] wrote: > > > +static inline unsigned long deap_pfn(u8 edeap, u32 deap) > > +{ > > + deap >>= PAGE_SHIFT; > > + deap |= (edeap & 1) << (32 - PAGE_SHIFT); > > + return deap; >

Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions

2007-10-19 Thread Jason Uhlenkott
On Fri, Oct 19, 2007 at 14:11:18 -0700, Andrew Morton wrote: On Fri, 19 Oct 2007 13:18:23 -0600 [EMAIL PROTECTED] wrote: +static inline unsigned long deap_pfn(u8 edeap, u32 deap) +{ + deap = PAGE_SHIFT; + deap |= (edeap 1) (32 - PAGE_SHIFT); + return deap; +} + +static

[PATCH] trivial: fix do_sys_open() prototype

2007-10-16 Thread Jason Uhlenkott
Fix an argument name in do_sys_open()'s prototype. Signed-off-by: Jason Uhlenkott <[EMAIL PROTECTED]> Index: linux/include/linux/fs.h === --- linux.orig/include/linux/fs.h 2007-10-16 15:19:26.632794062 -0700 +++ linux/i

[PATCH] trivial: fix do_sys_open() prototype

2007-10-16 Thread Jason Uhlenkott
Fix an argument name in do_sys_open()'s prototype. Signed-off-by: Jason Uhlenkott [EMAIL PROTECTED] Index: linux/include/linux/fs.h === --- linux.orig/include/linux/fs.h 2007-10-16 15:19:26.632794062 -0700 +++ linux/include

Re: kfree(0) - ok?

2007-08-15 Thread Jason Uhlenkott
On Wed, Aug 15, 2007 at 11:20:33 +0200, Jan Engelhardt wrote: > > On Aug 15 2007 10:37, Rene Herman wrote: > > On 08/15/2007 09:28 AM, Jan Engelhardt wrote: > >> On Aug 14 2007 16:21, Jason Uhlenkott wrote: > > > >> > On Tue, Aug 14, 2007 at 15:55:48 -0700

Re: kfree(0) - ok?

2007-08-15 Thread Jason Uhlenkott
On Wed, Aug 15, 2007 at 09:28:54 +0200, Jan Engelhardt wrote: > > On Aug 14 2007 16:21, Jason Uhlenkott wrote: > >On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: > >> NULL is not 0 though. > > > >It is. Its representation isn't guaranteed to be

Re: kfree(0) - ok?

2007-08-15 Thread Jason Uhlenkott
On Wed, Aug 15, 2007 at 09:28:54 +0200, Jan Engelhardt wrote: On Aug 14 2007 16:21, Jason Uhlenkott wrote: On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, C guarantees that. Equality

Re: kfree(0) - ok?

2007-08-15 Thread Jason Uhlenkott
On Wed, Aug 15, 2007 at 11:20:33 +0200, Jan Engelhardt wrote: On Aug 15 2007 10:37, Rene Herman wrote: On 08/15/2007 09:28 AM, Jan Engelhardt wrote: On Aug 14 2007 16:21, Jason Uhlenkott wrote: On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: NULL is not 0 though

Re: kfree(0) - ok?

2007-08-14 Thread Jason Uhlenkott
On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: > NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, but the constant value 0 when used in pointer context is always a null pointer (and in fact the standard requires that NULL be #defined as 0 or

Re: kfree(0) - ok?

2007-08-14 Thread Jason Uhlenkott
On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, but the constant value 0 when used in pointer context is always a null pointer (and in fact the standard requires that NULL be #defined as 0 or a

Re: [2.6.20.16 review 27/28] NTP: remove clock_was_set() call to prevent deadlock

2007-08-12 Thread Jason Uhlenkott
On Sat, Aug 11, 2007 at 21:48:19 +0200, Willy Tarreau wrote: > The clock_was_set() call in seconds_overflow() which happens only when > leap seconds are inserted / deleted is wrong in two aspects: > > 1. it results in a call to on_each_cpu() with interrupts disabled > 2. it is potential deadlock

Re: [2.6.20.16 review 27/28] NTP: remove clock_was_set() call to prevent deadlock

2007-08-12 Thread Jason Uhlenkott
On Sat, Aug 11, 2007 at 21:48:19 +0200, Willy Tarreau wrote: The clock_was_set() call in seconds_overflow() which happens only when leap seconds are inserted / deleted is wrong in two aspects: 1. it results in a call to on_each_cpu() with interrupts disabled 2. it is potential deadlock

Re: [PATCH] fujtisu application panel driver

2007-07-04 Thread Jason Uhlenkott
On Mon, Jul 02, 2007 at 11:17:24 -0700, Stephen Hemminger wrote: > +static int __init apanel_init(void) > +{ > + void __iomem *bios; > + u8 devno; > + int found = 0; > + > + if (!dmi_check_system(apanel_dmi_table)) { > + printk(KERN_WARNING "apanel: DMI information does

Re: [PATCH] fujtisu application panel driver

2007-07-04 Thread Jason Uhlenkott
On Mon, Jul 02, 2007 at 11:17:24 -0700, Stephen Hemminger wrote: +static int __init apanel_init(void) +{ + void __iomem *bios; + u8 devno; + int found = 0; + + if (!dmi_check_system(apanel_dmi_table)) { + printk(KERN_WARNING apanel: DMI information does not

Re: CONFIG_PRINTK_TIME woes

2005-08-22 Thread Jason Uhlenkott
On Mon, Aug 22, 2005 at 01:20:52PM -0700, David S. Miller wrote: > From: [EMAIL PROTECTED] > Date: Mon, 22 Aug 2005 10:42:22 -0700 > > > At the other extreme ... the current use of sched_clock() with > > potentially nano-second resolution is way over the top. > > Not really, when I'm debugging

Re: CONFIG_PRINTK_TIME woes

2005-08-22 Thread Jason Uhlenkott
On Mon, Aug 22, 2005 at 01:20:52PM -0700, David S. Miller wrote: From: [EMAIL PROTECTED] Date: Mon, 22 Aug 2005 10:42:22 -0700 At the other extreme ... the current use of sched_clock() with potentially nano-second resolution is way over the top. Not really, when I'm debugging TCP events

Re: [ACPI] Re: 2.6.12-rc1-mm3

2005-03-25 Thread Jason Uhlenkott
On Fri, Mar 25, 2005 at 11:12:39PM -0500, Len Brown wrote: > I realize now I didn't answer your original question. > The reason ACPI now depends on PM is that > it makes it easier for us to do a more orderly shutdown -- > acpi registers as a device so it can do some stuff > upon the PM device

Re: [ACPI] Re: 2.6.12-rc1-mm3

2005-03-25 Thread Jason Uhlenkott
On Fri, Mar 25, 2005 at 09:24:21PM -0500, Len Brown wrote: > What bad things happen if you define CONFIG_PM on SN2? None, other than slightly enlarging the kernel with some suspend/resume stuff we don't care about. It's always been unavailable for SN2 builds: depends on IA64_GENERIC || IA64_DIG

[PATCH 2.6.12-rc1-mm3] Fix typo in scdrv_init()

2005-03-25 Thread Jason Uhlenkott
Fix a typo in scdrv_init() which was breaking the build for SGI sn2. Signed-off-by: Jason Uhlenkott <[EMAIL PROTECTED]> Index: linux/drivers/char/snsc.c === --- linux.orig/drivers/char/snsc.c 2005-03-25 16:53:13.426753917

Re: [ACPI] Re: 2.6.12-rc1-mm3

2005-03-25 Thread Jason Uhlenkott
On Fri, Mar 25, 2005 at 08:56:58PM -0500, Len Brown wrote: > Please send me the .config you'd like to build. arch/ia64/configs/sn2_defconfig > I believe that what we want to do is include CONFIG_PM. At first glance, it looks like that will enable suspend/resume functionality (which I don't

Re: 2.6.12-rc1-mm3

2005-03-25 Thread Jason Uhlenkott
n't have (or want) on sn2. The following fixes it, but I'm not sure what the original rationale was. Len? Signed-off-by: Jason Uhlenkott <[EMAIL PROTECTED]> Index: linux/drivers/acpi/Kconfig === --- linux.orig/drivers/acpi/Kconfig

Re: 2.6.12-rc1-mm3

2005-03-25 Thread Jason Uhlenkott
(or want) on sn2. The following fixes it, but I'm not sure what the original rationale was. Len? Signed-off-by: Jason Uhlenkott [EMAIL PROTECTED] Index: linux/drivers/acpi/Kconfig === --- linux.orig/drivers/acpi/Kconfig 2005-03

[PATCH 2.6.12-rc1-mm3] Fix typo in scdrv_init()

2005-03-25 Thread Jason Uhlenkott
Fix a typo in scdrv_init() which was breaking the build for SGI sn2. Signed-off-by: Jason Uhlenkott [EMAIL PROTECTED] Index: linux/drivers/char/snsc.c === --- linux.orig/drivers/char/snsc.c 2005-03-25 16:53:13.426753917 -0800

Re: [ACPI] Re: 2.6.12-rc1-mm3

2005-03-25 Thread Jason Uhlenkott
On Fri, Mar 25, 2005 at 09:24:21PM -0500, Len Brown wrote: What bad things happen if you define CONFIG_PM on SN2? None, other than slightly enlarging the kernel with some suspend/resume stuff we don't care about. It's always been unavailable for SN2 builds: depends on IA64_GENERIC || IA64_DIG

Re: [PATCH] Prezeroing V8 + free_hot_zeroed_page + free_cold_zeroed page

2005-03-17 Thread Jason Uhlenkott
On Thu, Mar 17, 2005 at 05:36:50PM -0800, Christoph Lameter wrote: > +while (avenrun[0] >= ((unsigned long)sysctl_scrub_load << FSHIFT)) { > + set_current_state(TASK_UNINTERRUPTIBLE); > + schedule_timeout(30*HZ); > + } This should probably be

Re: [PATCH] Prezeroing V8 + free_hot_zeroed_page + free_cold_zeroed page

2005-03-17 Thread Jason Uhlenkott
On Thu, Mar 17, 2005 at 05:36:50PM -0800, Christoph Lameter wrote: +while (avenrun[0] = ((unsigned long)sysctl_scrub_load FSHIFT)) { + set_current_state(TASK_UNINTERRUPTIBLE); + schedule_timeout(30*HZ); + } This should probably be TASK_INTERRUPTIBLE.

Re: LKCD on 2.6 IA64 Linux Kernel

2005-01-25 Thread Jason Uhlenkott
On Tue, Jan 25, 2005 at 03:16:21PM -, [EMAIL PROTECTED] wrote: > Hi all, > > I tried using lkcd on a ia64 machine running on 2.6.5-7.111 SuSe Kernel for > debugging. I configured the swap device as the dump device and I created > panics,oops to generate dumps. The dump happens in

Re: LKCD on 2.6 IA64 Linux Kernel

2005-01-25 Thread Jason Uhlenkott
On Tue, Jan 25, 2005 at 03:16:21PM -, [EMAIL PROTECTED] wrote: Hi all, I tried using lkcd on a ia64 machine running on 2.6.5-7.111 SuSe Kernel for debugging. I configured the swap device as the dump device and I created panics,oops to generate dumps. The dump happens in /var/log/dump on