Re: [PATCH V4 7/7] vDPA/ifcvf: deduce VIRTIO device ID from pdev ids

2021-03-16 Thread Jason Wang
在 2021/3/15 下午3:45, Zhu Lingshan 写道: static u32 ifcvf_vdpa_get_device_id(struct vdpa_device *vdpa_dev) { - return VIRTIO_ID_NET; + struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev); + u32 ret = -EOPNOTSUPP; + + if (ifcvf_probed_virtio_net(vf)) + ret = VIRTIO_I

Re: [PATCH V4 6/7] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-16 Thread Jason Wang
ERR(ifcvf->pdev, "VIRTIO_F_ACCESS_PLATFORM not negotiated\n"); Should be "is not negotiated". Otherwise: Acked-by: Jason Wang + return -EINVAL; + } + + return 0; +} + void ifcvf_read_net_config(struct ifcvf_hw *hw, u64 offset,

Re: [PATCH V4 5/7] vDPA/ifcvf: fetch device feature bits when probe

2021-03-16 Thread Jason Wang
Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.c | 12 ++-- drivers/vdpa/ifcvf/ifcvf_base.h | 2 ++ drivers/vdpa/ifcvf/ifcvf_main.c | 2 ++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf

Re: [PATCH V4 4/7] vDPA/ifcvf: remove the version number string

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: This commit removes the version number string, using kernel version is enough. Signed-off-by: Zhu Lingshan Reviewed-by: Leon Romanovsky Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH V4 3/7] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan Acked-by: Jason Wang If you want to have a general driver, you proba

Re: [PATCH V4 2/7] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.h | 5 + drivers/vdpa/ifcvf/ifcvf_main.c | 5 + 2 files changed, 10 insertions

Re: [PATCH V4 1/7] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions

Re: [PATCH] vhost: Fix vhost_vq_reset()

2021-03-15 Thread Jason Wang
_le(vq); vhost_disable_cross_endian(vq); And so user_be is used before being set. To fix that, reverse the lines order as there is no other dependency between them. Signed-off-by: Laurent Vivier Acked-by: Jason Wang --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-14 Thread Jason Wang
On 2021/3/15 9:14 上午, Jie Deng wrote: On 2021/3/12 16:58, Arnd Bergmann wrote: On Fri, Mar 12, 2021 at 2:33 PM Jie Deng wrote: + +/** + * struct virtio_i2c_req - the virtio I2C request structure + * @out_hdr: the OUT header of the virtio I2C message + * @buf: the buffer into which data is

Re: linux-next: Tree for Mar 11 [drivers/vdpa/virtio_pci/vp_vdpa.ko]

2021-03-12 Thread Jason Wang
On 2021/3/12 2:18 上午, Randy Dunlap wrote: On 3/10/21 9:14 PM, Stephen Rothwell wrote: Hi all, Warning: Some of the branches in linux-next are still based on v5.12-rc1, so please be careful if you are trying to bisect a bug. News: if your -next included tree is based on Linus' tree tag v5.12-

[PATCH] vdpa: fix build dependency of VIRTIO_PCI_LIB

2021-03-12 Thread Jason Wang
The modern PCI device module should be built independently without VIRTIO. This patch fixes this. Fixes: 7075992ba8873(“vdpa: introduce virtio pci driver") Reported-by: Randy Dunlap Signed-off-by: Jason Wang --- drivers/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-11 Thread Jason Wang
On 2021/3/12 2:40 下午, Zhu, Lingshan wrote: On 3/12/2021 1:52 PM, Jason Wang wrote: On 2021/3/11 3:19 下午, Zhu, Lingshan wrote: On 3/11/2021 2:20 PM, Jason Wang wrote: On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu

Re: [PATCH 2/2] vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails

2021-03-11 Thread Jason Wang
is case to avoid to use an invalid pointer in other functions such as vhost_vdpa_config_put(). Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") Cc: lingshan@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- d

Re: [PATCH 1/2] vhost-vdpa: fix use-after-free of v->config_ctx

2021-03-11 Thread Jason Wang
y_SYSCALL_64_after_hwframe+0x44/0xae Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") Cc: lingshan@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 4 +++- 1 file changed, 3 insertion

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-11 Thread Jason Wang
On 2021/3/11 3:19 下午, Zhu, Lingshan wrote: On 3/11/2021 2:20 PM, Jason Wang wrote: On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-10 Thread Jason Wang
On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this when set features. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.c

Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-10 Thread Jason Wang
On 2021/3/11 12:23 下午, Zhu Lingshan wrote: On 3/11/2021 11:25 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-o

Re: [PATCH V3 1/6] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-10 Thread Jason Wang
On 2021/3/11 12:21 下午, Zhu Lingshan wrote: On 3/11/2021 11:23 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan

Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 8 drivers/vdpa/ifcvf/ifcvf_main

Re: [PATCH V3 1/6] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this when set features. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.c | 8 drivers/vdpa/ifcvf/ifcvf_base.h | 1 + drivers/vdpa/ifcvf/ifcvf_main.c | 5

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-09 Thread Jason Wang
On 2021/3/10 10:22 上午, Jie Deng wrote: On 2021/3/4 17:15, Jason Wang wrote: +    } + +    if (msgs[i].flags & I2C_M_RD) +    memcpy(msgs[i].buf, req->buf, msgs[i].len); Sorry if I had asked this before but any rason not to use msg[i].buf directly? The msg[i]

Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-08 Thread Jason Wang
On 2021/3/9 10:28 上午, Zhu, Lingshan wrote: On 3/9/2021 10:23 AM, Jason Wang wrote: On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.h | 5 +   drivers/vdpa

Re: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit removes the version number string, using kernel version is enough. Signed-off-by: Zhu Lingshan --- Acked-by: Jason Wang drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/vdpa/ifcvf

Re: [PATCH V2 3/4] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan Acked-by: Jason Wang You probably need to rename the drive

Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 5 + drivers/vdpa/ifcvf/ifcvf_main.c | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/vdpa

Re: [PATCH V2 1/4] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4

Re: [RFC PATCH 10/10] vhost/vdpa: return configuration bytes read and written to user space

2021-03-07 Thread Jason Wang
On 2021/3/5 4:37 下午, Stefano Garzarella wrote: On Thu, Mar 04, 2021 at 04:31:22PM +0800, Jason Wang wrote: On 2021/3/2 10:06 下午, Stefano Garzarella wrote: On Tue, Mar 02, 2021 at 12:05:35PM +0800, Jason Wang wrote: On 2021/2/16 5:44 下午, Stefano Garzarella wrote: vdpa_get_config() and

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-07 Thread Jason Wang
On 2021/3/5 10:19 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA. C5000X-PL vendor id 0x1AF4, device id 0x1000, subvendor id 0x8086, sub device id 0x0001 To distinguish C5000X-PL from other ifcvf driven devices, the original ifcvf device is named

Re: [PATCH 1/3] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-07 Thread Jason Wang
ifcvf_vdpa_get_vendor_id(struct vdpa_device *vdpa_dev) { - return IFCVF_SUBSYS_VENDOR_ID; + struct ifcvf_adapter *adapter = vdpa_to_adapter(vdpa_dev); + struct pci_dev *pdev = adapter->pdev; + + return pdev->subsystem_vendor; } Acked-by: Jason Wang stat

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-04 Thread Jason Wang
On 2021/3/5 1:47 下午, Jie Deng wrote: On 2021/3/4 17:15, Jason Wang wrote: On 2021/3/4 9:59 上午, Jie Deng wrote: Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. The

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/4 9:50 下午, Cornelia Huck wrote: On Thu, 4 Mar 2021 16:24:16 +0800 Jason Wang wrote: On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-04 Thread Jason Wang
On 2021/3/4 9:59 上午, Jie Deng wrote: Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. The device specification can be found on https://lists.oasis-open.org/archives/virtio-

Re: [RFC PATCH 01/10] vdpa: add get_config_size callback in vdpa_config_ops

2021-03-04 Thread Jason Wang
On 2021/3/2 10:15 下午, Stefano Garzarella wrote: On Tue, Mar 02, 2021 at 12:14:13PM +0800, Jason Wang wrote: On 2021/2/16 5:44 下午, Stefano Garzarella wrote: This new callback is used to get the size of the configuration space of vDPA devices. Signed-off-by: Stefano Garzarella ---  include

Re: [RFC PATCH 10/10] vhost/vdpa: return configuration bytes read and written to user space

2021-03-04 Thread Jason Wang
On 2021/3/2 10:06 下午, Stefano Garzarella wrote: On Tue, Mar 02, 2021 at 12:05:35PM +0800, Jason Wang wrote: On 2021/2/16 5:44 下午, Stefano Garzarella wrote: vdpa_get_config() and vdpa_set_config() now return the amount of bytes read and written, so let's return them to the user space

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote: On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-02 Thread Jason Wang
On 2021/3/2 5:47 下午, Michael S. Tsirkin wrote: On Mon, Mar 01, 2021 at 11:56:50AM +0800, Jason Wang wrote: On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notif

[PATCH V2] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
ility. " Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend") Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index ef688c8c0e0e..e93572e2e344 100644 --- a/

Re: [PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
On 2021/3/2 5:51 下午, Michael S. Tsirkin wrote: On Tue, Mar 02, 2021 at 04:14:18AM -0500, Jason Wang wrote: When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock(). Signed-off-by: Jason Wang Indeed and it's not just

[PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock(). Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index

Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver

2021-03-02 Thread Jason Wang
On 2021/3/2 1:16 下午, Viresh Kumar wrote: On 02-03-21, 13:06, Jie Deng wrote: Yeah. Actually, the backend only needs "struct virtio_i2c_out_hdr out_hdr" and "struct virtio_i2c_in_hdr in_hdr" for communication. So we only need to keep the first two in uapi and move "struct virtio_i2c_req" into t

Re: [RFC PATCH 01/10] vdpa: add get_config_size callback in vdpa_config_ops

2021-03-02 Thread Jason Wang
On 2021/2/16 5:44 下午, Stefano Garzarella wrote: This new callback is used to get the size of the configuration space of vDPA devices. Signed-off-by: Stefano Garzarella --- include/linux/vdpa.h | 4 drivers/vdpa/ifcvf/ifcvf_main.c | 6 ++ drivers/vdpa/mlx5/net/mlx5_

Re: [RFC PATCH 10/10] vhost/vdpa: return configuration bytes read and written to user space

2021-03-02 Thread Jason Wang
On 2021/2/16 5:44 下午, Stefano Garzarella wrote: vdpa_get_config() and vdpa_set_config() now return the amount of bytes read and written, so let's return them to the user space. We also modify vhost_vdpa_config_validate() to return 0 (bytes read or written) instead of an error, when the buffer

Re: [PATCH] vdpa/mlx5: Fix wrong use of bit numbers

2021-02-28 Thread Jason Wang
t;) Signed-off-by: Eli Cohen Acked-by: Jason Wang --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index dc7031132fff..7d21b857a94a 100644 --- a/drivers/vdp

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-28 Thread Jason Wang
On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notify the kernel that it's a legacy guest. Ugh :( Well, although I think adding an ioctl is doable, may I know what the use

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-28 Thread Jason Wang
On 2021/3/1 5:30 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 05:30:37PM +0800, Jason Wang wrote: On 2021/2/24 4:43 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: Basically on first guest access QEMU would tell kernel whether

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-28 Thread Jason Wang
On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote: On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-26 Thread Jason Wang
On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07 +0800 Jason Wang wrote: On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07 +0800 Jason Wang wrote: On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason Wang wrote: On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/23 6:17 下午, Jason Wang wrote: On 2021/2/23 6:01 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 05:46:20PM +0800, Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/24 4:43 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: Basically on first guest access QEMU would tell kernel whether guest is using the legacy or the modern interface. E.g. virtio_pci_config_read/virtio_pci_config_write will

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason Wang wrote: On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 2:46 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 02:04:36PM +0800, Jason Wang wrote: On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 1:17 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/23 6:01 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 05:46:20PM +0800, Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/23 下午5:26, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 08:05:26AM +0200, Eli Cohen wrote: On Sun, Feb 21, 2021 at 04:52:05PM -0500, Michael S. Tsirkin wrote: On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote:

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception

[PATCH V4 3/3] vdpa: introduce virtio pci driver

2021-02-22 Thread Jason Wang
: Jason Wang --- drivers/vdpa/Kconfig | 7 + drivers/vdpa/Makefile | 1 + drivers/vdpa/virtio_pci/Makefile | 2 + drivers/vdpa/virtio_pci/vp_vdpa.c | 458 ++ 4 files changed, 468 insertions(+) create mode 100644 drivers/vdpa/virtio_pci

[PATCH V4 2/3] vdpa: set the virtqueue num during register

2021-02-22 Thread Jason Wang
This patch delay the queue number setting to vDPA device registering. This allows us to probe the virtqueue numbers between device allocation and registering. Reviewed-by: Stefano Garzarella Signed-off-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 ++--- drivers/vdpa/mlx5/net

[PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-22 Thread Jason Wang
Bergmann Cc: Anders Roxell Cc: Guenter Roeck Reported-by: Naresh Kamboju Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module") Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 11 ++- drivers/virtio/Makefile | 2 +- 2 files changed, 7 insertions(+), 6

[PATCH V4 0/3] virtio-pci: introduce modern device module

2021-02-22 Thread Jason Wang
th virtio-pci driver - No feature whitelist, supporting any features (mq, config etc) Jason Wang (3): virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN vdpa: set the virtqueue num during register vdpa: introduce virtio pci driver drivers/vdpa/Kconfig | 7 + drivers/vdpa

Re: [PATCH 2/2 v1] vdpa/mlx5: Enable user to add/delete vdpa device

2021-02-22 Thread Jason Wang
name vdpa0 3. Show vdpa devices $ vdpa dev show vdpa0: type network mgmtdev pci/:3b:00.1 vendor_id max_vqs 16 \ max_vq_size 256 Signed-off-by: Eli Cohen Reviewed-by: Parav Pandit Acked-by: Jason Wang --- v0->v1: set mgtdev->ndev NULL on dev delete drivers/vdpa/ml

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-22 Thread Jason Wang
On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exc

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-22 Thread Jason Wang
On 2021/2/23 1:09 上午, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when config space i

Re: [PATCH V4 2/2] vdpa: introduce virtio pci driver

2021-02-22 Thread Jason Wang
On 2021/2/22 5:04 下午, Stefano Garzarella wrote: On Sat, Feb 20, 2021 at 04:46:29PM +0800, Jason Wang wrote: This patch introduce a vDPA driver for virtio-pci device. It bridges the virtio-pci control command to the vDPA bus. This will be used for features prototyping and testing. Note that

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-22 Thread Jason Wang
On 2021/2/22 3:29 下午, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 11:42:44AM +0800, Jason Wang wrote: On 2021/2/19 11:38 下午, Guenter Roeck wrote: On 2/19/21 12:45 AM, Jason Wang wrote: We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-21 Thread Jason Wang
On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when config space is accessed before features are set. We should relieve the verify_min_features() check and allow featu

Re: [PATCH] virtio: remove export for virtio_config_{enable, disable}

2021-02-21 Thread Jason Wang
On 2021/2/21 12:28 上午, Xianting Tian wrote: virtio_config_enable(), virtio_config_disable() are only used inside drivers/virtio/virtio.c, so it doesn't need export the symbols. Signed-off-by: Xianting Tian Acked-by: Jason Wang --- drivers/virtio/virtio.c | 6 ++ include/

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-21 Thread Jason Wang
On 2021/2/19 11:38 下午, Guenter Roeck wrote: On 2/19/21 12:45 AM, Jason Wang wrote: We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may break various default configs which want virtio devices. So this patch fixes this by hide the prompot and

Re: [PATCH] net: check if protocol extracted by virtio_net_hdr_set_proto is correct

2021-02-21 Thread Jason Wang
On 2021/2/19 10:55 下午, Willem de Bruijn wrote: On Fri, Feb 19, 2021 at 3:53 AM Jason Wang wrote: On 2021/2/18 11:50 下午, Willem de Bruijn wrote: On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote: For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't set) based o

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-21 Thread Jason Wang
On 2021/2/19 6:12 下午, Arnd Bergmann wrote: On Fri, Feb 19, 2021 at 9:45 AM Jason Wang wrote: We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may break various default configs which want virtio devices. So this patch fixes this by hide the

[PATCH V4 1/2] vdpa: set the virtqueue num during register

2021-02-20 Thread Jason Wang
This patch delay the queue number setting to vDPA device registering. This allows us to probe the virtqueue numbers between device allocation and registering. Signed-off-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 ++--- drivers/vdpa/mlx5/net/mlx5_vnet.c| 4 ++-- drivers

[PATCH V4 2/2] vdpa: introduce virtio pci driver

2021-02-20 Thread Jason Wang
: Jason Wang --- drivers/vdpa/Kconfig | 7 + drivers/vdpa/Makefile | 1 + drivers/vdpa/virtio_pci/Makefile | 2 + drivers/vdpa/virtio_pci/vp_vdpa.c | 456 ++ 4 files changed, 466 insertions(+) create mode 100644 drivers/vdpa/virtio_pci

[PATCH V4 0/2] virtio-pci: introduce modern device module

2021-02-20 Thread Jason Wang
common codes from virito-pci and share it with vDPA driver - Use dynamic id in order to be less confusing with virtio-pci driver - No feature whitelist, supporting any features (mq, config etc) Jason Wang (2): vdpa: set the virtqueue num during register vdpa: introduce virtio pci driv

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-19 Thread Jason Wang
On 2021/2/20 10:05 上午, Si-Wei Liu wrote: On 2/18/2021 7:10 PM, Jason Wang wrote: On 2021/2/18 8:43 下午, Si-Wei Liu wrote: On 2/17/2021 8:44 PM, Jason Wang wrote: On 2021/2/10 下午4:59, Si-Wei Liu wrote: On 2/9/2021 7:53 PM, Jason Wang wrote: On 2021/2/10 上午10:30, Si-Wei Liu wrote

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-19 Thread Jason Wang
On 2021/2/19 6:13 下午, Christoph Hellwig wrote: On Fri, Feb 19, 2021 at 03:45:09AM -0500, Jason Wang wrote: We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may break various default configs which want virtio devices. So this patch fixes this by

Re: [PATCH] net: check if protocol extracted by virtio_net_hdr_set_proto is correct

2021-02-19 Thread Jason Wang
On 2021/2/18 11:50 下午, Willem de Bruijn wrote: On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote: For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't set) based on the type in the virtio net hdr, but the skb could contain anything since it could come from packet_snd th

[PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-19 Thread Jason Wang
-by: Naresh Kamboju Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module") Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 6b9b81f4b8c2..be

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-19 Thread Jason Wang
On 2021/2/13 4:14 上午, Guenter Roeck wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang Reported-by: Naresh Kamboju I don't really see the point of having to enable VIRTIO_PCI_MODERN because otherwise VIRTIO_PCI no longer works. If VIRTIO_PC

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-18 Thread Jason Wang
On 2021/2/18 8:43 下午, Si-Wei Liu wrote: On 2/17/2021 8:44 PM, Jason Wang wrote: On 2021/2/10 下午4:59, Si-Wei Liu wrote: On 2/9/2021 7:53 PM, Jason Wang wrote: On 2021/2/10 上午10:30, Si-Wei Liu wrote: On 2/8/2021 10:37 PM, Jason Wang wrote: On 2021/2/9 下午2:12, Eli Cohen wrote: On

Re: [PATCH v2 3/3] vdpa/mlx5: defer clear_virtqueues to until DRIVER_OK

2021-02-17 Thread Jason Wang
Fixes: b35ccebe3ef7 ("vdpa/mlx5: Restore the hardware used index after change map") Signed-off-by: Si-Wei Liu Acked-by: Jason Wang Acked-by: Eli Cohen I take it back. I think we don't need to clear the indexes at all. In case we need to restore indexes we'll get the right values thro

Re: [PATCH v2 2/3] vdpa/mlx5: fix feature negotiation across device reset

2021-02-17 Thread Jason Wang
bogus (incomplete) checksum transmitted on the wire. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Signed-off-by: Si-Wei Liu Acked-by: Jason Wang --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 25 +++-- 1 file changed, 15 insertions(+), 10 del

Re: [PATCH for 5.10] vdpa_sim: fix param validation in vdpasim_get_config()

2021-02-17 Thread Jason Wang
offset, { struct vdpasim *vdpasim = vdpa_to_sim(vdpa); - if (offset + len < sizeof(struct virtio_net_config)) + if (offset + len <= sizeof(struct virtio_net_config)) memcpy(buf, (u8 *)&vdpasim->config + offset, len); } Acked-by: Jason Wang

Re: [PATCH] arm64: defconfig: enable modern virtio pci device

2021-02-17 Thread Jason Wang
On 2021/2/11 下午7:52, Arnd Bergmann wrote: On Wed, Feb 10, 2021 at 8:05 PM Anders Roxell wrote: Since patch ("virtio-pci: introduce modern device module") got added it is not possible to boot a defconfig kernel in qemu with a virtio pci device. Add CONFIG_VIRTIO_PCI_MODERN=y fragment makes th

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-17 Thread Jason Wang
On 2021/2/10 下午8:35, Michael S. Tsirkin wrote: On Wed, Feb 10, 2021 at 12:44:03PM +0800, Jason Wang wrote: On 2021/2/9 下午10:20, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/virtio/Kconfig

Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

2021-02-17 Thread Jason Wang
On 2021/2/10 下午6:08, Stefano Garzarella wrote: On Tue, Feb 09, 2021 at 04:31:23AM -0500, Michael S. Tsirkin wrote: On Tue, Feb 09, 2021 at 11:24:03AM +0800, Jason Wang wrote: On 2021/2/9 上午2:38, Michael S. Tsirkin wrote: > On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wr

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-17 Thread Jason Wang
On 2021/2/10 下午4:59, Si-Wei Liu wrote: On 2/9/2021 7:53 PM, Jason Wang wrote: On 2021/2/10 上午10:30, Si-Wei Liu wrote: On 2/8/2021 10:37 PM, Jason Wang wrote: On 2021/2/9 下午2:12, Eli Cohen wrote: On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: On 2021/2/8 下午6:04, Eli

Re: [PATCH] virtio-mmio: Use to_virtio_mmio_device() to simply code

2021-02-10 Thread Jason Wang
On 2021/2/10 上午11:04, Tang Bin wrote: The file virtio_mmio.c has defined the function to_virtio_mmio_device, so use it instead of container_of() to simply code. And remove superfluous blank lines in this file. Signed-off-by: Tang Bin --- drivers/virtio/virtio_mmio.c | 16 +---

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Jason Wang
On 2021/2/9 下午10:20, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 10 +- drivers/virtio/Makefile| 1 + drivers/virtio/virtio_pci_common.h | 27

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Jason Wang
On 2021/2/9 下午6:15, Naresh Kamboju wrote: Hi Jason, On Mon, 4 Jan 2021 at 12:28, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 10 +- drivers/virtio/Makefile| 1 + drivers/virtio/virtio_pci_common.h | 27 +- drivers

Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

2021-02-09 Thread Jason Wang
On 2021/2/9 下午5:00, Stefano Garzarella wrote: On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote: It's legal to have 'offset + len' equal to sizeof(struct virtio_net_config), since 'ndev->config' is a 'struct virtio_ne

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-09 Thread Jason Wang
On 2021/2/10 上午8:26, Si-Wei Liu wrote: On 2/8/2021 7:37 PM, Jason Wang wrote: On 2021/2/6 下午8:29, Si-Wei Liu wrote: While virtq is stopped,  get_vq_state() is supposed to be  called to  get  sync'ed  with  the latest internal avail_index from device. The saved avail_index is us

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-09 Thread Jason Wang
On 2021/2/10 上午10:30, Si-Wei Liu wrote: On 2/8/2021 10:37 PM, Jason Wang wrote: On 2021/2/9 下午2:12, Eli Cohen wrote: On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: On 2021/2/8 下午6:04, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: On 2021/2/8

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-08 Thread Jason Wang
On 2021/2/9 下午2:12, Eli Cohen wrote: On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: On 2021/2/8 下午6:04, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: On 2021/2/8 下午2:37, Eli Cohen wrote: On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-08 Thread Jason Wang
On 2021/2/6 下午8:29, Si-Wei Liu wrote: While virtq is stopped, get_vq_state() is supposed to be called to get sync'ed with the latest internal avail_index from device. The saved avail_index is used to restate the virtq once device is started. Commit b35ccebe3ef7 introduced the clear_vir

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-08 Thread Jason Wang
On 2021/2/8 下午8:04, Michael S. Tsirkin wrote: On Mon, Feb 08, 2021 at 01:42:27PM +0800, Jason Wang wrote: On 2021/2/5 下午11:34, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang I don't exactly get why we need to split the m

<    1   2   3   4   5   6   7   8   9   10   >