On 13.04.2021 18:38, Max Gurtovoy wrote:
On 4/11/2021 10:26 PM, Javier González wrote:
On 11.04.2021 12:10, Max Gurtovoy wrote:
On 4/10/2021 9:32 AM, Javier González wrote:
On 10 Apr 2021, at 02.30, Chaitanya Kulkarni
wrote:
On 4/9/21 17:22, Max Gurtovoy wrote:
On 2/19/2021 2:45 PM
On 11.04.2021 12:10, Max Gurtovoy wrote:
On 4/10/2021 9:32 AM, Javier González wrote:
On 10 Apr 2021, at 02.30, Chaitanya Kulkarni wrote:
On 4/9/21 17:22, Max Gurtovoy wrote:
On 2/19/2021 2:45 PM, SelvaKumar S wrote:
This patchset tries to add support for TP4065a ("Simple Copy Co
> On 10 Apr 2021, at 02.30, Chaitanya Kulkarni
> wrote:
>
> On 4/9/21 17:22, Max Gurtovoy wrote:
>>> On 2/19/2021 2:45 PM, SelvaKumar S wrote:
>>> This patchset tries to add support for TP4065a ("Simple Copy Command"),
>>> v2020.05.04 ("Ratified")
>>>
>>> The Specification can be found in
On 08.04.2021 14:15, Christoph Hellwig wrote:
On Thu, Apr 08, 2021 at 12:30:16PM +0200, Javier González wrote:
Aligning to MDTS is our current behavior, although all kernels up to
5.11 had a bug in the calculation.
I see. Let me check internally and see what's going on with
write-zeroes
On 23.03.2021 13:43, Javier González wrote:
On 23.03.2021 13:31, Christoph Hellwig wrote:
On Tue, Mar 23, 2021 at 09:37:49AM +0100, Javier González wrote:
Quick question. It seems like the current quirk simply disables
write-zeroes. Would you be open for a quirk that aligns with MDTS
On 23.03.2021 13:31, Christoph Hellwig wrote:
On Tue, Mar 23, 2021 at 09:37:49AM +0100, Javier González wrote:
Quick question. It seems like the current quirk simply disables
write-zeroes. Would you be open for a quirk that aligns with MDTS for
models that implemented it this way before TP4040
On 11.03.2021 11:47, Christoph Hellwig wrote:
On Wed, Mar 10, 2021 at 12:00:30PM -0800, Keith Busch wrote:
On Wed, Mar 10, 2021 at 02:41:10PM +0100, Christoph Hellwig wrote:
> On Wed, Mar 10, 2021 at 02:21:56PM +0100, Christoph Hellwig wrote:
> > Can you try this patch instead?
> >
> >
On 21.01.2021 05:47, Jens Axboe wrote:
On 1/21/21 12:22 AM, Pan Bian wrote:
The allocated page is not released if error occurs in
nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid
possible memory leak issue.
Applied, thanks.
General question for Matias - is lightnvm maintained
On 08.12.2020 13:24, Johannes Thumshirn wrote:
On 08/12/2020 14:13, Javier González wrote:
On 08.12.2020 12:37, Johannes Thumshirn wrote:
On 08/12/2020 13:22, Javier González wrote:
Good idea. Are you thinking of a sysfs entry to select the backend?
Not sure on this one, initially I thought
On 08.12.2020 12:37, Johannes Thumshirn wrote:
On 08/12/2020 13:22, Javier González wrote:
Good idea. Are you thinking of a sysfs entry to select the backend?
Not sure on this one, initially I thought of a sysfs file, but then
how would you do it. One "global" sysfs entry is prob
On 08.12.2020 08:40, Johannes Thumshirn wrote:
On 07/12/2020 20:27, Javier González wrote:
Good point. We can share some performance data on how Simple Copy scales
in terms of bw / latency and the CPU usage. Do you have anything else in
mind?
With an emulation in the kernel, we could make
On 08.12.2020 07:44, Hannes Reinecke wrote:
On 12/7/20 11:12 PM, Douglas Gilbert wrote:
On 2020-12-07 9:56 a.m., Hannes Reinecke wrote:
On 12/7/20 3:11 PM, Christoph Hellwig wrote:
So, I'm really worried about:
a) a good use case. GC in f2fs or btrfs seem like good use cases, as
does
On 07.12.2020 15:56, Hannes Reinecke wrote:
On 12/7/20 3:11 PM, Christoph Hellwig wrote:
So, I'm really worried about:
a) a good use case. GC in f2fs or btrfs seem like good use cases, as
does accelating dm-kcopyd. I agree with Damien that lifting dm-kcopyd
to common code would also
On 07.12.2020 15:11, Christoph Hellwig wrote:
So, I'm really worried about:
a) a good use case. GC in f2fs or btrfs seem like good use cases, as
does accelating dm-kcopyd. I agree with Damien that lifting dm-kcopyd
to common code would also be really nice. I'm not 100% sure it should
> On 8 Jul 2020, at 18.34, Matthew Wilcox wrote:
>
> On Wed, Jul 08, 2020 at 06:08:12PM +0200, Javier González wrote:
>>> I just wanted to get clarification there, because to me it sounded like
>>> you expected Kanchan to do it, and Kanchan assuming it &qu
> On 8 Jul 2020, at 17.06, Jens Axboe wrote:
>
> On 7/8/20 9:02 AM, Matthew Wilcox wrote:
>>> On Wed, Jul 08, 2020 at 08:59:50AM -0600, Jens Axboe wrote:
>>> On 7/8/20 8:58 AM, Matthew Wilcox wrote:
On Wed, Jul 08, 2020 at 08:54:07AM -0600, Jens Axboe wrote:
> On 7/8/20 6:58 AM,
On 03.07.2020 09:44, Matias Bjorling wrote:
-Original Message-
From: Javier González
Sent: Monday, 29 June 2020 21.39
To: Damien Le Moal
Cc: Matias Bjorling ; ax...@kernel.dk;
kbu...@kernel.org; h...@lst.de; s...@grimberg.me;
martin.peter...@oracle.com; Niklas Cassel ; Hans
Holmberg
On 02.07.2020 08:41, Niklas Cassel wrote:
On Wed, Jul 01, 2020 at 01:16:52PM +0200, Javier González wrote:
On 16.06.2020 12:25, Niklas Cassel wrote:
> Add a new max_active zones definition in the sysfs documentation.
> This definition will be common for all devices utilizing the zoned
On 16.06.2020 12:25, Niklas Cassel wrote:
Add a new max_active zones definition in the sysfs documentation.
This definition will be common for all devices utilizing the zoned block
device support in the kernel.
Export max_active_zones according to this new definition for NVMe Zoned
Namespace
)
+{
+}
+static inline unsigned int queue_max_active_zones(const struct request_queue
*q)
+{
+ return 0;
+}
#endif /* CONFIG_BLK_DEV_ZONED */
static inline bool rq_is_sync(struct request *rq)
--
2.26.2
___
linux-nvme mailing list
linux-n...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Looks good to me
Reviewed-by: Javier González
}
#endif /* CONFIG_BLK_DEV_ZONED */
static inline bool rq_is_sync(struct request *rq)
--
2.26.2
___
linux-nvme mailing list
linux-n...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Looks good to me.
Reviewed-by: Javier González
On 29.06.2020 01:00, Damien Le Moal wrote:
On 2020/06/29 8:01, Matias Bjorling wrote:
The NVMe Zoned Namespace Command Set adds support for associating
data to a zone through the Zone Descriptor Extension feature.
To allow user-space to associate data to a zone, add support through
the
On 18.06.2020 10:32, Matias Bjørling wrote:
On 18/06/2020 10.27, Javier González wrote:
On 18.06.2020 10:04, Matias Bjørling wrote:
On 17/06/2020 19.23, Kanchan Joshi wrote:
This patchset enables issuing zone-append using aio and io-uring
direct-io interface.
For aio, this introduces opcode
On 17.06.2020 23:56, Christoph Hellwig wrote:
On Wed, Jun 17, 2020 at 10:53:36PM +0530, Kanchan Joshi wrote:
This patchset enables issuing zone-append using aio and io-uring direct-io
interface.
For aio, this introduces opcode IOCB_CMD_ZONE_APPEND. Application uses start LBA
of the zone to
On 18.06.2020 10:04, Matias Bjørling wrote:
On 17/06/2020 19.23, Kanchan Joshi wrote:
This patchset enables issuing zone-append using aio and io-uring direct-io
interface.
For aio, this introduces opcode IOCB_CMD_ZONE_APPEND. Application uses start LBA
of the zone to issue append. On
t;
}
--
2.17.1
Looks good to me.
Reviewed-by: Javier González
On 28.04.2020 07:49, Niklas Cassel wrote:
On Tue, Apr 28, 2020 at 09:06:51AM +0200, Javier González wrote:
CAUTION: This email originated from outside of Western Digital. Do not click on
links or open attachments unless you recognize the sender and know that the
content is safe
On 27.04.2020 18:22, Niklas Cassel wrote:
On Mon, Apr 27, 2020 at 08:03:11PM +0200, Javier González wrote:
On 27.04.2020 14:34, Niklas Cassel wrote:
> When jumping to the out_put_disk label, we will call put_disk(), which will
> trigger a call to disk_release(), which calls blk_put
bio;
> }
> -EXPORT_SYMBOL(bio_map_kern);
>
> static void bio_copy_kern_endio(struct bio *bio)
> {
> --
> 2.7.4
Haven’t realized we were the only users at this point. Nice cleanup.
Reviewed-by: Javier González
signature.asc
Description: Message signed with OpenPGP
ns the first line.
>
> Yeah Okay. Will prepare V2 with this and also s/previx/prefix in the
> title.
>
> Thanks for the review.
>
> Minwoo Im
Besides Chaitanya’s comments, looks good. You can add my review on V2.
Reviewed-by: Javier González
signature.asc
Description: Message signed with OpenPGP
for (i = 0; i < bio->bi_vcnt; i++) {
> + bv = >bi_io_vec[i];
> + page = bv->bv_page;
> + for (e = 0; e < bv->bv_len; e += PBLK_EXPOSED_PAGE_SIZE, nbv++)
> + if (nbv >= off)
> + mem
of the largest possible size is submitted.
Fixes: f9f9d1ae2c66 ("lightnvm: pblk: prevent stall due to wb threshold")
Signed-off-by: Javier González
---
Matias: Can you apply this as a fix to 5.1. This is a case I missed when fixing
the wb threshold, which is also scheduled for 5.1
Than
+ Mailing lists
> On 7 Feb 2019, at 18.48, Javier González wrote:
>
>
>
>> On 7 Feb 2019, at 18.12, Stephen Bates wrote:
>>
>> Hi All
>>
>>> A BPF track will join the annual LSF/MM Summit this year! Please read the
>>> updated de
htnvm: pblk: guarantee that backpointer is respected
on writer stall")
Signed-off-by: Javier González
---
Changes since V1:
- Fix a bad arithmetinc on the rate-limiter max_io calculation (from
Hans)
Changes since V2:
- Address case where mw_cunits = 0 in the new math
driver
t; index a6386d5acd73..ac3ab778e976 100644
> --- a/drivers/lightnvm/pblk.h
> +++ b/drivers/lightnvm/pblk.h
> @@ -487,6 +487,7 @@ struct pblk_line {
> __le32 *vsc;/* Valid sector count in line */
>
> struct kref ref;/* Write buffer L2P references */
> + atomic_t sec_to_update; /* Outstanding L2P updates to ppa */
>
> struct pblk_w_err_gc *w_err_gc; /* Write error gc recovery metadata */
>
> --
> 2.17.1
Looks good to me. Again, good marathon-catch! :)
Reviewed-by: Javier González
signature.asc
Description: Message signed with OpenPGP
> On 31 Jan 2019, at 21.10, Hans Holmberg wrote:
>
> On Thu, Jan 31, 2019 at 5:33 PM Javier González wrote:
>>> On 31 Jan 2019, at 11.41, Hans Holmberg wrote:
>>>
>>> Hi Javier!
>>>
>>> How did you test this? I'm trying to add a test cas
t=1
> 1+0 records in
> 1+0 records out
> 262144 bytes (262 kB, 256 KiB) copied, 0.000718515 s, 365 MB/s
> # dd if=/dev/zero of=/dev/pblk0 oflag=direct bs=512k count=1
>
>
>
>> On Wed, Jan 30, 2019 at 11:28 AM Javier González wrote:
>>
>> In order to respect mw
htnvm: pblk: guarantee that backpointer is respected
on writer stall")
Signed-off-by: Javier González
---
Changes since V1:
- Fix a bad arithmetinc on the rate-limiter max_io calculation (from
Hans)
drivers/lightnvm/pblk-rb.c | 25 +++--
drivers/lightnvm/pblk
-356,7 +376,7 @@ static int pblk_recov_scan_oob(struct pblk *pblk, struct
> pblk_line *line,
> int ret;
> u64 left_ppas = pblk_sec_in_open_line(pblk, line) - lm->smeta_sec;
>
> - if (pblk_line_wp_is_unbalanced(pblk, line))
> + if (pblk_line_wps_are_unbalanced(pblk, line))
> pblk_warn(pblk, "recovering unbalanced line (%d)\n", line->id);
>
> ppa_list = p.ppa_list;
> --
> 2.17.1
Looks good to me.
Reviewed-by: Javier González
signature.asc
Description: Message signed with OpenPGP
> On 29 Jan 2019, at 17.36, Heiner Litz wrote:
>
> Javier,
>
> On Tue, Jan 29, 2019 at 12:13 AM Javier González wrote:
> > On 27 Jan 2019, at 07.54, Heiner Litz wrote:
> >
> > This patch fixes a race condition where a write is mapped to the last
> >
> On 29 Jan 2019, at 16.49, Hans Holmberg wrote:
>
> On Tue, Jan 29, 2019 at 4:03 PM Javier González wrote:
>>> On 29 Jan 2019, at 13.49, Hans Holmberg wrote:
>>>
>>> On Tue, Jan 29, 2019 at 12:19 PM Javier González wrote:
>>>>>
> On 29 Jan 2019, at 13.49, Hans Holmberg wrote:
>
> On Tue, Jan 29, 2019 at 12:19 PM Javier González wrote:
>>> On 29 Jan 2019, at 09.47, h...@owltronix.com wrote:
>>>
>>> From: Hans Holmberg
>>>
>>> pblk stripes writes of minimal
> On 29 Jan 2019, at 09.47, h...@owltronix.com wrote:
>
> From: Hans Holmberg
>
> pblk stripes writes of minimal write size across all non-offline chunks
> in a line, which means that the maximum write pointer delta should not
> exceed the minimal write size. Extend the line write pointer
> On 29 Jan 2019, at 11.15, Hans Holmberg
> wrote:
>
> On Fri, Jan 25, 2019 at 2:08 PM Matias Bjørling wrote:
>> On 1/25/19 11:09 AM, Javier González wrote:
>>> In order to respect mw_cuinits, pblk's write buffer maintains a
>>> backpointer to protect
> On 27 Jan 2019, at 07.54, Heiner Litz wrote:
>
> This patch fixes a race condition where a write is mapped to the last
> sectors of a line. The write is synced to the device but the L2P is not
> updated yet. When the line is garbage collected before the L2P update is
> performed, the sectors
htnvm: pblk: guarantee that backpointer is respected
on writer stall")
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-rb.c | 25 +++--
drivers/lightnvm/pblk-rl.c | 5 ++---
drivers/lightnvm/pblk.h| 2 +-
3 files changed, 22 insertions(+), 10 deletions(-)
> On 25 Jan 2019, at 10.15, Hans Holmberg
> wrote:
>
> On Thu, Jan 24, 2019 at 2:19 PM Javier González wrote:
>>> On 22 Jan 2019, at 11.15, h...@owltronix.com wrote:
>>>
>>> From: Hans Holmberg
>>>
>>> pblk_line_meta_free might sl
> On 24 Jan 2019, at 17.38, Andy Shevchenko wrote:
>
> On Thu, Jan 24, 2019 at 4:36 PM Javier González wrote:
>
>> It is not pushed anywhere yet, but I have been working on a tool to make
>> a pblk recovery tool to enable FTL repairs if something fails in the
>>
> + guid_t instance_uuid;
>
> /* Persistent write amplification counters, 4kb sector I/Os */
> atomic64_t user_wa; /* Sectors written by user */
> @@ -1360,14 +1360,6 @@ static inline unsigned int pblk_get_secs(struct bio
> *bio)
> return bio->
> On 24 Jan 2019, at 15.13, Andy Shevchenko wrote:
>
> On Thu, Jan 24, 2019 at 3:45 PM Javier González wrote:
>>> On 24 Jan 2019, at 14.36, Andy Shevchenko wrote:
>>> On Thu, Jan 24, 2019 at 3:19 PM Javier González wrote:
>>>>> On 24 Jan 201
> On 24 Jan 2019, at 14.36, Andy Shevchenko wrote:
>
> On Thu, Jan 24, 2019 at 3:19 PM Javier González wrote:
>>> On 24 Jan 2019, at 13.16, Andy Shevchenko
>>> wrote:
>>> On Mon, Jan 21, 2019 at 09:47:32AM +0100, Christoph Hellwig wrote:
>>>>
ee(pblk);
>
> --
> 2.17.1
Can you add a comment too indicating that this is only safe on a single
threaded shutdown?
Otherwise the patch looks good.
Reviewed-by: Javier González
signature.asc
Description: Message signed with OpenPGP
> On 24 Jan 2019, at 13.16, Andy Shevchenko
> wrote:
>
> On Mon, Jan 21, 2019 at 09:47:32AM +0100, Christoph Hellwig wrote:
>> On Thu, Jan 10, 2019 at 04:30:51PM +0200, Andy Shevchenko wrote:
>>> There are new types and helpers that are supposed to be used in new code.
>>>
>>> As a
pointer and the state on core so that the erase
path is transparent to pblk wrt OCSSD version.
Signed-off-by: Javier González
---
drivers/lightnvm/core.c | 44 ++--
drivers/lightnvm/pblk-core.c | 54 +---
2 files changed
pointer and the state on core so that the erase
path is transparent to pblk wrt OCSSD version.
Signed-off-by: Javier González
---
drivers/lightnvm/core.c | 44 ++--
drivers/lightnvm/pblk-core.c | 54 +---
2 files changed
for
outlined metadata for the case where the reported OOB area is 0. It
should be pretty simple to do that on top of these patches though.
Thanks,
Javier
Javier González (3):
lightnvm: use internal allocation for chunk log page
lightnvm: do no update csecs and sos on 1.2
lightnvm: pblk: support
for
outlined metadata for the case where the reported OOB area is 0. It
should be pretty simple to do that on top of these patches though.
Thanks,
Javier
Javier González (3):
lightnvm: use internal allocation for chunk log page
lightnvm: do no update csecs and sos on 1.2
lightnvm: pblk: support
in the metdatada scheme could cause
ordering issues.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-core.c | 14 --
drivers/lightnvm/pblk.h | 1 +
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index
in the metdatada scheme could cause
ordering issues.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-core.c | 14 --
drivers/lightnvm/pblk.h | 1 +
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index
Bad blocks can grow at runtime. Check that the number of valid blocks in
a line are within the sanity threshold before allocating the line for
new writes.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-core.c | 38 --
d
Bad blocks can grow at runtime. Check that the number of valid blocks in
a line are within the sanity threshold before allocating the line for
new writes.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-core.c | 38 --
drivers/lightnvm/pblk-init.c
Check that the lba stored in the LBA metadata is correct in the GC path
too. This requires a new helper function to check random reads in the
vector read.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-read.c | 39 +--
Check that the lba stored in the LBA metadata is correct in the GC path
too. This requires a new helper function to check random reads in the
vector read.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-read.c | 39 +--
1 file changed, 33 insertions
Return a meaningful error when the sanity vector I/O check fails.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-core.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnv
Return a meaningful error when the sanity vector I/O check fails.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-core.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index
In the event of a mismatch between the read LBA and the metadata pointer
reported by the device, improve the error message to be able to detect
the offending physical address (PPA) mapped to the corrupted LBA.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-
In the event of a mismatch between the read LBA and the metadata pointer
reported by the device, improve the error message to be able to detect
the offending physical address (PPA) mapped to the corrupted LBA.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-read.c | 42
g the
issue.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-rb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c
index 7a632913475f..024a366a995c 100644
--- a/drivers/lightnvm/pblk-r
g the
issue.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-rb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c
index 7a632913475f..024a366a995c 100644
--- a/drivers/lightnvm/pblk-rb.c
+++ b/drivers/lightnvm/
A bunch of small fixes and extra checks for pblk. Non is critical, though
("lightnvm: pblk: check for chunk size before allocating it") might be nice to
get into 4.17 as it is a fix for the 2.0 pblk patches.
Javier
Javier González (11):
lightnvm: pblk: fail gracefully on line alloc. failure
Call nvm_submit_io directly and remove an unnecessary indirection on the
read path.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-read.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/lightnvm/pblk-read.c b/d
Call nvm_submit_io directly and remove an unnecessary indirection on the
read path.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-read.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c
A bunch of small fixes and extra checks for pblk. Non is critical, though
("lightnvm: pblk: check for chunk size before allocating it") might be nice to
get into 4.17 as it is a fix for the 2.0 pblk patches.
Javier
Javier González (11):
lightnvm: pblk: fail gracefully on line alloc. failure
Remove dead function for manual sync. I/O
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-core.c | 7 ---
drivers/lightnvm/pblk.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
Remove dead function for manual sync. I/O
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-core.c | 7 ---
drivers/lightnvm/pblk.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index cc34d5d9652d..5f960a6609c8
know
when this happens.
In the case of pblk, we pad the open line (close all open chunks) to
improve data retention. In the event of an ungraceful shutdown, avoid
this part and just clean up.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/core.c | 10 +-
know
when this happens.
In the case of pblk, we pad the open line (close all open chunks) to
improve data retention. In the event of an ungraceful shutdown, avoid
this part and just clean up.
Signed-off-by: Javier González
---
drivers/lightnvm/core.c | 10 +-
drivers/lightnvm/pblk-c
Remove unnecessary argument on pblk_line_free()
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-core.c | 6 +++---
drivers/lightnvm/pblk-init.c | 2 +-
drivers/lightnvm/pblk.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/d
Remove unnecessary argument on pblk_line_free()
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-core.c | 6 +++---
drivers/lightnvm/pblk-init.c | 2 +-
drivers/lightnvm/pblk.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/lightnvm/pblk-core.c b
Do the check for the chunk state after making sure that the chunk type
is supported.
Fixes: 32ef9412c114 ("lightnvm: pblk: implement get log report chunk")
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-init.c | 6 +++---
1 file changed, 3
Do the check for the chunk state after making sure that the chunk type
is supported.
Fixes: 32ef9412c114 ("lightnvm: pblk: implement get log report chunk")
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-init.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
In the event of a line failing to allocate, fail gracefully and stop the
pipeline to avoid more write failing in the same place.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-init.c | 5 +
drivers/lightnvm/pblk-map.c
In the event of a line failing to allocate, fail gracefully and stop the
pipeline to avoid more write failing in the same place.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-init.c | 5 +
drivers/lightnvm/pblk-map.c | 33 -
2 files changed, 29
Changes since V1 - from Matias:
- rename a function to line__reinit
- propagate error code
- improve commit message
Javier González (1):
lightnvm: pblk: take bitmap alloc. out of critical section
drivers/lightnvm/pblk-core.c | 97 +---
1 file changed
Changes since V1 - from Matias:
- rename a function to line__reinit
- propagate error code
- improve commit message
Javier González (1):
lightnvm: pblk: take bitmap alloc. out of critical section
drivers/lightnvm/pblk-core.c | 97 +---
1 file changed
pblk allocates line bitmaps within the line lock unnecessarily. In order
to take pressure out of the fast patch, allocate line bitmaps outside
of this lock and refactor accordingly.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-core.
pblk allocates line bitmaps within the line lock unnecessarily. In order
to take pressure out of the fast patch, allocate line bitmaps outside
of this lock and refactor accordingly.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-core.c | 97
> On 17 Apr 2018, at 04.48, Matias Bjørling <m...@lightnvm.io> wrote:
>
> On 4/16/18 12:21 PM, Javier González wrote:
>> Allocate line bitmaps outside of the line lock on line preparation.
>> Signed-off-by: Javier González <jav...@cnexlabs.com>
>
>
>
> On 17 Apr 2018, at 04.48, Matias Bjørling wrote:
>
> On 4/16/18 12:21 PM, Javier González wrote:
>> Allocate line bitmaps outside of the line lock on line preparation.
>> Signed-off-by: Javier González
>
>
> The patch description tells what the patch does, i
> On 17 Apr 2018, at 05.03, Matias Bjørling <m...@lightnvm.io> wrote:
>
> On 4/16/18 12:25 PM, Javier González wrote:
>> Check that the lba stored in the LBA metadata is correct in the GC path
>> too. This requires a new helper function to check random reads in the
&g
> On 17 Apr 2018, at 05.03, Matias Bjørling wrote:
>
> On 4/16/18 12:25 PM, Javier González wrote:
>> Check that the lba stored in the LBA metadata is correct in the GC path
>> too. This requires a new helper function to check random reads in the
>> vector read.
>&g
Javier
> On 17 Apr 2018, at 05.12, Matias Bjørling <m...@lightnvm.io> wrote:
>
> On 4/16/18 12:25 PM, Javier González wrote:
>> Remove unnecessary argument on pblk_line_free()
>
> Why was the argument no longer needed?
You can see it is not used... It a straig
Javier
> On 17 Apr 2018, at 05.12, Matias Bjørling wrote:
>
> On 4/16/18 12:25 PM, Javier González wrote:
>> Remove unnecessary argument on pblk_line_free()
>
> Why was the argument no longer needed?
You can see it is not used... It a straightforward clean up.
J
In the event of a line failing to allocate, fail gracefully and stop the
pipeline to avoid more write failing in the same place.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-init.c | 5 +
drivers/lightnvm/pblk-map.c
In the event of a line failing to allocate, fail gracefully and stop the
pipeline to avoid more write failing in the same place.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-init.c | 5 +
drivers/lightnvm/pblk-map.c | 33 -
2 files changed, 29
Check that the lba stored in the LBA metadata is correct in the GC path
too. This requires a new helper function to check random reads in the
vector read.
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-read.c | 39 +--
A bunch of small fixes and extra checks for pblk. Non is critical, though
("lightnvm: pblk: check for chunk size before allocating it") might be nice to
get into 4.17 as it is a fix for the 2.0 pblk patches.
Javier
Javier González (11):
lightnvm: pblk: fail gracefully on line allo
Check that the lba stored in the LBA metadata is correct in the GC path
too. This requires a new helper function to check random reads in the
vector read.
Signed-off-by: Javier González
---
drivers/lightnvm/pblk-read.c | 39 +--
1 file changed, 33 insertions
A bunch of small fixes and extra checks for pblk. Non is critical, though
("lightnvm: pblk: check for chunk size before allocating it") might be nice to
get into 4.17 as it is a fix for the 2.0 pblk patches.
Javier
Javier González (11):
lightnvm: pblk: fail gracefully on line allo
Do the check for the chunk state after making sure that the chunk type
is supported.
Fixes: 32ef9412c114 ("lightnvm: pblk: implement get log report chunk")
Signed-off-by: Javier González <jav...@cnexlabs.com>
---
drivers/lightnvm/pblk-init.c | 6 +++---
1 file changed, 3
1 - 100 of 1003 matches
Mail list logo
