Re: 2.6.21-rc5: known regressions with patches

2007-03-27 Thread Jay Cliburn
On Wed, 28 Mar 2007 01:00:24 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > Subject: atl1 net driver: problem with sockets > References : http://lkml.org/lkml/2007/3/21/248 > Submitter : Jose Alberto Reguero <[EMAIL PROTECTED]> > Patch :

[PATCH] atl1: remove unnecessary crc inversion

2007-03-27 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> The original vendor driver contained a private ether_crc_le() function that produced an inverted crc. When we changed to the kernel version of ether_crc_le(), we neglected to undo the inversion. Let's do it now. Discovered by and patch proffered b

[PATCH] atl1: remove unnecessary crc inversion

2007-03-27 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] The original vendor driver contained a private ether_crc_le() function that produced an inverted crc. When we changed to the kernel version of ether_crc_le(), we neglected to undo the inversion. Let's do it now. Discovered by and patch proffered by Jose

Re: 2.6.21-rc5: known regressions with patches

2007-03-27 Thread Jay Cliburn
On Wed, 28 Mar 2007 01:00:24 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: Subject: atl1 net driver: problem with sockets References : http://lkml.org/lkml/2007/3/21/248 Submitter : Jose Alberto Reguero [EMAIL PROTECTED] Patch : http://marc.info/?l=linux-netdevm=117502041808665w=2

[PATCH 6/6] atl1: bump version number

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> Bump the version number. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c i

[PATCH 5/6] atl1: add L1 device id to pci_ids, then use it

2007-02-14 Thread Jay Cliburn
From: Chris Snook <[EMAIL PROTECTED]> Add device id for the Attansic L1 chip to pci_ids.h, then use it. Signed-off-by: Chris Snook <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |2 +- include/linux/pci_ids.h

[PATCH 4/6] atl1: remove unused define

2007-02-14 Thread Jay Cliburn
From: Chris Snook <[EMAIL PROTECTED]> Remove unused define from atl1_main.c. Signed-off-by: Chris Snook <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[PATCH 3/6] atl1: read MAC address from register

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> On some Asus motherboards containing the L1 NIC, the MAC address is written by the BIOS directly to the MAC register during POST, and is not stored in eeprom. If we don't succeed in fetching the MAC address from eeprom or spi, try reading it directl

[PATCH 2/6] atl1: fix bad ioread address

2007-02-14 Thread Jay Cliburn
From: Al Viro <[EMAIL PROTECTED]> An ioread32 statement reads the wrong address. Fix it. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_hw.c |

[PATCH 1/6] atl1: drop NET_PCI from Kconfig

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> The atl1 driver doesn't need NET_PCI. Remove it from Kconfig. Noticed by Chad Sprouse. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --- drivers/net/Kconfig |2 +- 1 files changed,

[PATCH 0/6] atl1: bugfix, cleanup, enhancement

2007-02-14 Thread Jay Cliburn
Jeff, Please accept the following patchset for the atl1 network device driver. * Drop unnecessary NET_PCI config * Fix incorrect hash table address * Read MAC address from register * Remove unused define * Add Attansic L1 device id to pci_ids * Bump version number This patchset contains changes

[PATCH 0/6] atl1: bugfix, cleanup, enhancement

2007-02-14 Thread Jay Cliburn
Jeff, Please accept the following patchset for the atl1 network device driver. * Drop unnecessary NET_PCI config * Fix incorrect hash table address * Read MAC address from register * Remove unused define * Add Attansic L1 device id to pci_ids * Bump version number This patchset contains changes

[PATCH 1/6] atl1: drop NET_PCI from Kconfig

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] The atl1 driver doesn't need NET_PCI. Remove it from Kconfig. Noticed by Chad Sprouse. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- drivers/net/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 2/6] atl1: fix bad ioread address

2007-02-14 Thread Jay Cliburn
From: Al Viro [EMAIL PROTECTED] An ioread32 statement reads the wrong address. Fix it. Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- drivers/net/atl1/atl1_hw.c |2 +- 1 files changed, 1 insertions

[PATCH 3/6] atl1: read MAC address from register

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] On some Asus motherboards containing the L1 NIC, the MAC address is written by the BIOS directly to the MAC register during POST, and is not stored in eeprom. If we don't succeed in fetching the MAC address from eeprom or spi, try reading it directly from

[PATCH 4/6] atl1: remove unused define

2007-02-14 Thread Jay Cliburn
From: Chris Snook [EMAIL PROTECTED] Remove unused define from atl1_main.c. Signed-off-by: Chris Snook [EMAIL PROTECTED] Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/atl1

[PATCH 5/6] atl1: add L1 device id to pci_ids, then use it

2007-02-14 Thread Jay Cliburn
From: Chris Snook [EMAIL PROTECTED] Add device id for the Attansic L1 chip to pci_ids.h, then use it. Signed-off-by: Chris Snook [EMAIL PROTECTED] Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |2 +- include/linux/pci_ids.h |1 + 2 files changed, 2

[PATCH 6/6] atl1: bump version number

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] Bump the version number. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c index 09f3375

[PATCH netdev#atl1 1/1] atl1: clean up extern, global scope declarations

2007-02-06 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> atl1: move extern to header file; make some global code static Move an extern declaration to a header file. Make needlessly global functions static. Noticed by Adrian Bunk. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net

Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups

2007-02-06 Thread Jay Cliburn
On Tue, 6 Feb 2007 23:12:29 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote: > >... > > Changes since 2.6.20-rc6-mm2: > >... > > git-netdev-all.patch > >... > > git trees > >... > > > This patch contains the following possible

Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups

2007-02-06 Thread Jay Cliburn
On Tue, 6 Feb 2007 23:12:29 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote: ... Changes since 2.6.20-rc6-mm2: ... git-netdev-all.patch ... git trees ... This patch contains the following possible cleanups: - move extern

[PATCH netdev#atl1 1/1] atl1: clean up extern, global scope declarations

2007-02-06 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] atl1: move extern to header file; make some global code static Move an extern declaration to a header file. Make needlessly global functions static. Noticed by Adrian Bunk. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1.h

[PATCH netdev#atl1 3/3] pci_ids: add Attansic vendor id

2007-02-03 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> pci_ids: add Attansic vendor id Add Attansic to pci_ids and use the ID in the driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |2 +- include/linux/pci_ids.h |2 ++ 2 files changed, 3 inse

[PATCH netdev#atl1 2/3] maintainers: add atl1 maintainers

2007-02-03 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> MAINTAINERS: add atl1 maintainers Add a maintainers entry for atl1. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- MAINTAINERS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS i

[PATCH netdev#atl1 1/3] atl1: remove whitespace damage

2007-02-03 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> atl1: fix whitespace damage Remove trailing whitespace and spaces preceding tabs. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1.h |8 +- drivers/net/atl1/atl1_ethtool.c | 42 ++-- drivers/net/at

[PATCH netdev#atl1 0/3] atl1: fix whitespace, add maintainers and pci_ids

2007-02-03 Thread Jay Cliburn
This set of patches completes the final bit of tidying up in the Attansic ethernet driver. Sorry for nickel-and-diming you, Jeff, but this really should be the end of it for awhile. Summary: 1. Clean up whitespace damage. 2. Add a maintainers entry. 3. Add a pci_ids entry. --- MAINTAINERS

[PATCH netdev#atl1 0/3] atl1: fix whitespace, add maintainers and pci_ids

2007-02-03 Thread Jay Cliburn
This set of patches completes the final bit of tidying up in the Attansic ethernet driver. Sorry for nickel-and-diming you, Jeff, but this really should be the end of it for awhile. Summary: 1. Clean up whitespace damage. 2. Add a maintainers entry. 3. Add a pci_ids entry. --- MAINTAINERS

[PATCH netdev#atl1 1/3] atl1: remove whitespace damage

2007-02-03 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] atl1: fix whitespace damage Remove trailing whitespace and spaces preceding tabs. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1.h |8 +- drivers/net/atl1/atl1_ethtool.c | 42 ++-- drivers/net/atl1/atl1_hw.h

[PATCH netdev#atl1 2/3] maintainers: add atl1 maintainers

2007-02-03 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] MAINTAINERS: add atl1 maintainers Add a maintainers entry for atl1. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- MAINTAINERS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 465e083

[PATCH netdev#atl1 3/3] pci_ids: add Attansic vendor id

2007-02-03 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] pci_ids: add Attansic vendor id Add Attansic to pci_ids and use the ID in the driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |2 +- include/linux/pci_ids.h |2 ++ 2 files changed, 3 insertions(+), 1

[PATCH 2.6.20-rc7 2/2] atl1: add ethtool set ring params functionality

2007-01-31 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> Fix up some constants relating to max and min ring descriptor counts. Also add functionality to enable ethtool to set tx and rx ring parameters. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1.h |4 +- driv

[PATCH 2.6.20-rc7 1/2] atl1: get rid of pci_module_init

2007-01-31 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> pci_module_init is deprecated. Use pci_register_driver instead. Discovered by and modification suggested by Alan Cox. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |5 + 1 files changed, 1 inse

Re: [PATCH] atl1_main: pci_module_int returns to haunt us

2007-01-31 Thread Jay Cliburn
Alan wrote: Perhaps Adrian would care to simply delete the pci_module_init ancient compat code so nobody else can inadvertently merge a driver that uses it. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [PATCH] atl1_main: pci_module_int returns to haunt us

2007-01-31 Thread Jay Cliburn
Alan wrote: Perhaps Adrian would care to simply delete the pci_module_init ancient compat code so nobody else can inadvertently merge a driver that uses it. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude

[PATCH 2.6.20-rc7 1/2] atl1: get rid of pci_module_init

2007-01-31 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] pci_module_init is deprecated. Use pci_register_driver instead. Discovered by and modification suggested by Alan Cox. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |5 + 1 files changed, 1 insertions(+), 4 deletions

[PATCH 2.6.20-rc7 2/2] atl1: add ethtool set ring params functionality

2007-01-31 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] Fix up some constants relating to max and min ring descriptor counts. Also add functionality to enable ethtool to set tx and rx ring parameters. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1.h |4 +- drivers/net/atl1

Re: [PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI

2007-01-27 Thread Jay Cliburn
The subject line on all four of the current crop of atl1 patches is incorrect; they were generated against *2.6.20-rc6*, not rc5. I apologize for the error. Jay - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

[PATCH 2.6.20-rc5 3/4] atl1: properly use CONFIG_PM

2007-01-27 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> Fix power management by properly using ifdef CONFIG_PM. Discovered by and modification suggested by Andrew Morton. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |7 +-- 1 files changed, 5 inse

[PATCH 2.6.20-rc5 4/4] atl1: incorporate reviewer comments

2007-01-27 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> Incorporate reviewer comments from: Randy Dunlap, http://lkml.org/lkml/2007/1/21/157 Arjan van de Ven, http://lkml.org/lkml/2007/1/22/21 Francois Romieu, http://lkml.org/lkml/2007/1/22/49 Fixup to follow coding standards, remove MII defines already

[PATCH 2.6.20-rc5 2/4] atl1: add missing include dma-mapping.h

2007-01-27 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> Include dma-mapphing.h to provide DMA_32BIT_MASK and DMA_64BIT_MASK. Discovered by and modification suggested by Andrew Morton. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |1 + 1 files changed, 1 inse

[PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI

2007-01-27 Thread Jay Cliburn
From: Luca Tettamanti <[EMAIL PROTECTED]> Unconditionally enable MSI in atl1 driver. Also remove some useless #ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not configured in. Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-27 Thread Jay Cliburn
Jeff Garzik wrote: As a driver maintainer, you need to patch sets, and submit them in a timely fashion to me. Note I said patch set, not patch, in following with Rule #3 from Documentation/SubmittingPatches. Also make sure to review http://linux.yyz.us/patch-format.html Understood. Both

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-27 Thread Jay Cliburn
Luca Tettamanti wrote: [snip] Anyway... Unconditionally enable MSI in atl1 driver. Also remove some useless #ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not configured in. Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]> Acked-by: Jay Cliburn <[EMAIL PROTE

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-27 Thread Jay Cliburn
Luca Tettamanti wrote: [snip] Anyway... Unconditionally enable MSI in atl1 driver. Also remove some useless #ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not configured in. Signed-off-by: Luca Tettamanti [EMAIL PROTECTED] Acked-by: Jay Cliburn [EMAIL PROTECTED] I tested

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-27 Thread Jay Cliburn
Jeff Garzik wrote: As a driver maintainer, you need to patch sets, and submit them in a timely fashion to me. Note I said patch set, not patch, in following with Rule #3 from Documentation/SubmittingPatches. Also make sure to review http://linux.yyz.us/patch-format.html Understood. Both

[PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI

2007-01-27 Thread Jay Cliburn
From: Luca Tettamanti [EMAIL PROTECTED] Unconditionally enable MSI in atl1 driver. Also remove some useless #ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not configured in. Signed-off-by: Luca Tettamanti [EMAIL PROTECTED] Signed-off-by: Jay Cliburn [EMAIL PROTECTED

[PATCH 2.6.20-rc5 2/4] atl1: add missing include dma-mapping.h

2007-01-27 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] Include dma-mapphing.h to provide DMA_32BIT_MASK and DMA_64BIT_MASK. Discovered by and modification suggested by Andrew Morton. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH 2.6.20-rc5 3/4] atl1: properly use CONFIG_PM

2007-01-27 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] Fix power management by properly using ifdef CONFIG_PM. Discovered by and modification suggested by Andrew Morton. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions

[PATCH 2.6.20-rc5 4/4] atl1: incorporate reviewer comments

2007-01-27 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] Incorporate reviewer comments from: Randy Dunlap, http://lkml.org/lkml/2007/1/21/157 Arjan van de Ven, http://lkml.org/lkml/2007/1/22/21 Francois Romieu, http://lkml.org/lkml/2007/1/22/49 Fixup to follow coding standards, remove MII defines already found

Re: [PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI

2007-01-27 Thread Jay Cliburn
The subject line on all four of the current crop of atl1 patches is incorrect; they were generated against *2.6.20-rc6*, not rc5. I apologize for the error. Jay - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-23 Thread Jay Cliburn
Jeff Garzik wrote: OK, I have merged the monolithic patch into jgarzik/netdev-2.6.git#atl1. Once I'm done merging patches tonight, I will merge this new 'atl1' branch into the 'ALL' meta-branch, which will auto-propagate this driver into Andrew Morton's -mm for testing. For future driver

Re: [PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-23 Thread Jay Cliburn
Jeff Garzik wrote: OK, I have merged the monolithic patch into jgarzik/netdev-2.6.git#atl1. Once I'm done merging patches tonight, I will merge this new 'atl1' branch into the 'ALL' meta-branch, which will auto-propagate this driver into Andrew Morton's -mm for testing. For future driver

Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

2007-01-22 Thread Jay Cliburn
Arjan, thank you very much for reviewing the driver. Arjan van de Ven wrote: On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote: [snip] +void atl1_irq_disable(struct atl1_adapter *adapter) +{ + atomic_inc(>irq_sem); + iowrite32(0, adapter->hw.hw_addr + R

Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

2007-01-22 Thread Jay Cliburn
Arjan, thank you very much for reviewing the driver. Arjan van de Ven wrote: On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote: [snip] +void atl1_irq_disable(struct atl1_adapter *adapter) +{ + atomic_inc(adapter-irq_sem); + iowrite32(0, adapter-hw.hw_addr + REG_IMR

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
Randy Dunlap wrote: On Sun, 21 Jan 2007 15:07:37 -0600 Jay Cliburn wrote: [snip] + value = ioread16(hw->hw_addr + REG_PCIE_CAP_LIST); + return ((value & 0xFF00) == 0x6C00) ? 0 : 1; Are there defines or enums for these? Fewer magic numbers would be nice/helpful/readable.

[PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> From: Chris Snook <[EMAIL PROTECTED]> This patch contains auxiliary C files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]> ---

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> From: Chris Snook <[EMAIL PROTECTED]> This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]>

[PATCH 1/4] atl1: Build files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> From: Chris Snook <[EMAIL PROTECTED]> This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --

[PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-21 Thread Jay Cliburn
This is the latest submittal of the patchset providing support for the Attansic L1 gigabit ethernet adapter. This patchset is built against kernel version 2.6.20-rc5. This version incorporates all comments from: Christoph Hellwig: http://lkml.org/lkml/2007/1/11/43

[PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-21 Thread Jay Cliburn
This is the latest submittal of the patchset providing support for the Attansic L1 gigabit ethernet adapter. This patchset is built against kernel version 2.6.20-rc5. This version incorporates all comments from: Christoph Hellwig: http://lkml.org/lkml/2007/1/11/43

[PATCH 1/4] atl1: Build files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] From: Chris Snook [EMAIL PROTECTED] This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- Kconfig | 11

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] From: Chris Snook [EMAIL PROTECTED] This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- atl1.h| 288

[PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] From: Chris Snook [EMAIL PROTECTED] This patch contains auxiliary C files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- atl1_ethtool.c | 436

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-21 Thread Jay Cliburn
Randy Dunlap wrote: On Sun, 21 Jan 2007 15:07:37 -0600 Jay Cliburn wrote: [snip] + value = ioread16(hw-hw_addr + REG_PCIE_CAP_LIST); + return ((value 0xFF00) == 0x6C00) ? 0 : 1; Are there defines or enums for these? Fewer magic numbers would be nice/helpful/readable. [snip

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-15 Thread Jay Cliburn
Francois Romieu wrote: Jay Cliburn <[EMAIL PROTECTED]> : [...] I welcome any comments on the rationality of this approach. An URL for the current version of the patch would be welcome too :o) Sorry. Forgot to do that. The current version may be found here: ftp://hogchain.net/pub

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-15 Thread Jay Cliburn
Christoph Hellwig wrote: On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: +struct csum_param { + unsigned buf_len:14; + unsigned dma_int:1; + unsigned pkt_int:1; + u16 valan_tag; + unsigned eop:1; + /* command */ + unsigned coalese:1

Re: [PATCH] Add suport for Marvell 88SE6121 in pata_marvell

2007-01-15 Thread Jay Cliburn
:03.0 +0100 @@ -49,7 +49,7 @@ [snip] Works-for-me: Jay Cliburn <[EMAIL PROTECTED]> The following dmesg snippet after applying the patch shows life from the hitherto unsupported device: (I connected an unpartitioned SATA HDD to it.) == [ 39.789326] PCI: Setting latency

Re: [PATCH] Add suport for Marvell 88SE6121 in pata_marvell

2007-01-15 Thread Jay Cliburn
:03.0 +0100 @@ -49,7 +49,7 @@ [snip] Works-for-me: Jay Cliburn [EMAIL PROTECTED] The following dmesg snippet after applying the patch shows life from the hitherto unsupported device: (I connected an unpartitioned SATA HDD to it.) == [ 39.789326] PCI: Setting latency timer

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-15 Thread Jay Cliburn
Christoph Hellwig wrote: On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: +struct csum_param { + unsigned buf_len:14; + unsigned dma_int:1; + unsigned pkt_int:1; + u16 valan_tag; + unsigned eop:1; + /* command */ + unsigned coalese:1

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-15 Thread Jay Cliburn
Francois Romieu wrote: Jay Cliburn [EMAIL PROTECTED] : [...] I welcome any comments on the rationality of this approach. An URL for the current version of the patch would be welcome too :o) Sorry. Forgot to do that. The current version may be found here: ftp://hogchain.net/pub/linux/m2v

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Jay Cliburn
On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote: > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > > +/** > > + * atl1.h - atl1 main header > > Please remove these kind of comments, they get out of date far too soon > and don't real

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-11 Thread Jay Cliburn
On Thu, Jan 11, 2007 at 09:27:04AM +, Christoph Hellwig wrote: On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: +/** + * atl1.h - atl1 main header Please remove these kind of comments, they get out of date far too soon and don't really help anything. (Also everywhere else

[PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-10 Thread Jay Cliburn
This is the latest submittal of the patchset providing support for the Attansic L1 gigabit ethernet adapter. This patchset is built against kernel version 2.6.20-rc4 current git as of 20070109. The monolithic version of this patchset may be found at:

[PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-10 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> From: Chris Snook <[EMAIL PROTECTED]> This patch contains auxiliary C files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]> ---

[PATCH 1/4] atl1: Build files for Attansic L1 driver

2007-01-10 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> From: Chris Snook <[EMAIL PROTECTED]> This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-10 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> From: Chris Snook <[EMAIL PROTECTED]> This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Signed-off-by: Chris Snook <[EMAIL PROTECTED]>

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-10 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] From: Chris Snook [EMAIL PROTECTED] This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- atl1.h| 266

[PATCH 1/4] atl1: Build files for Attansic L1 driver

2007-01-10 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] From: Chris Snook [EMAIL PROTECTED] This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- Kconfig | 11

[PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-10 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] From: Chris Snook [EMAIL PROTECTED] This patch contains auxiliary C files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- atl1_ethtool.c | 528

[PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-10 Thread Jay Cliburn
This is the latest submittal of the patchset providing support for the Attansic L1 gigabit ethernet adapter. This patchset is built against kernel version 2.6.20-rc4 current git as of 20070109. The monolithic version of this patchset may be found at:

Re: [BUG] commit 3c517a61, slab: better fallback allocation behavior

2006-12-11 Thread Jay Cliburn
Christoph Lameter wrote: Ahh. Fallback_alloc() does not do the check for GFP_WAIT as done in cache_grow(). Thus interrupts are disabled when we call kmem_getpages() which results in the failure. Duplicate the handling of GFP_WAIT in cache_grow(). Jay could you try this patch? The patch

Re: [BUG] commit 3c517a61, slab: better fallback allocation behavior

2006-12-11 Thread Jay Cliburn
Christoph Lameter wrote: Ahh. Fallback_alloc() does not do the check for GFP_WAIT as done in cache_grow(). Thus interrupts are disabled when we call kmem_getpages() which results in the failure. Duplicate the handling of GFP_WAIT in cache_grow(). Jay could you try this patch? The patch

Re: [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

2006-11-25 Thread Jay Cliburn
Luca Tettamanti wrote: Got the board, done some basic testing: so far so good :) The controller also supports MSI and (at least with my chipset - G965) it works fine: 218: 80649 0 PCI-MSI-edge eth1 which is nice, otherwise it ends up sharing the IRQ with SATA and USB. I

Re: [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

2006-11-25 Thread Jay Cliburn
Luca Tettamanti wrote: Got the board, done some basic testing: so far so good :) The controller also supports MSI and (at least with my chipset - G965) it works fine: 218: 80649 0 PCI-MSI-edge eth1 which is nice, otherwise it ends up sharing the IRQ with SATA and USB. I

[PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2006-11-19 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> This patch contains auxiliary C files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- atl1_ethtool.c | 530 +++ atl1_hw.c

[PATCH 1/4] atl1: Build files for Attansic L1 driver

2006-11-19 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- Kconfig | 12 Makefile |1 + atl1/Makefile | 30 +

[PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

2006-11-19 Thread Jay Cliburn
Based upon feedback from Stephen Hemminger and Francois Romieu, please consider this resubmitted patchset that provides support for the Attansic L1 gigabit ethernet adapter. This patchset is built against 2.6.19-rc6. The original patchset was submitted 20060927. The monolithic version of this

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2006-11-19 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- atl1.h | 251 ++ atl1_hw

[PATCH 2/4] atl1: Header files for Attansic L1 driver

2006-11-19 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] This patch contains the header files needed by the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- atl1.h | 251 ++ atl1_hw.h| 991

[PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

2006-11-19 Thread Jay Cliburn
Based upon feedback from Stephen Hemminger and Francois Romieu, please consider this resubmitted patchset that provides support for the Attansic L1 gigabit ethernet adapter. This patchset is built against 2.6.19-rc6. The original patchset was submitted 20060927. The monolithic version of this

[PATCH 1/4] atl1: Build files for Attansic L1 driver

2006-11-19 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- Kconfig | 12 Makefile |1 + atl1/Makefile | 30 ++ 3 files

[PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2006-11-19 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] This patch contains auxiliary C files for the Attansic L1 gigabit ethernet adapter driver. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- atl1_ethtool.c | 530 +++ atl1_hw.c | 840

<    1   2