Robert Hancock wrote:
Kuan Luo wrote:
Hi, robert
One customer reported that their system received a nmi interrupt after
issuing dd if=/dev/sdb of=/dev/null on a defective disk in rhel4u6.
I tested it and found that my system hung both in rhel4u6(2.6.9-67) and
2.6.24-rc7.
The patch can work
Ingo Molnar wrote:
* Jeff Garzik [EMAIL PROTECTED] wrote:
+ unsigned long flags;
+
+ local_irq_save(flags);
hm, couldnt we attach the irq disabling to some spinlock, in a natural
way? Explicit flags fiddling is a PITA once we do things like threaded
irq handlers, -rt, etc
Nick Piggin wrote:
Anyway, the idea of making fsync/fdatasync etc. safe by default is
a good idea IMO, and is a bad bug that we don't do that :(
Agreed... it's also disappointing that [unless I'm mistaken] you have
to hack each filesystem to support barriers.
It seems far easier to make
Jamie Lokier wrote:
Jeff Garzik wrote:
Nick Piggin wrote:
Anyway, the idea of making fsync/fdatasync etc. safe by default is
a good idea IMO, and is a bad bug that we don't do that :(
Agreed... it's also disappointing that [unless I'm mistaken] you have
to hack each filesystem to support
Jamie Lokier wrote:
By durable, I mean that fsync() should actually commit writes to
physical stable storage,
Yes, it should.
I was surprised that fsync() doesn't do this already. There was a lot
of effort put into block I/O write barriers during 2.5, so that
journalling filesystems can
Divy Le Ray wrote:
So, it sounds like Krishna's patch is ok, because the race does not
exist anymore in this driver?
The first part is right indeed, but the second part is breaking the
current usage of txq_stopped and
the logic that stops and restarts the Tx queue.
I can submit a patch
Mark Lord wrote:
Jeff Garzik wrote:
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few
Elias Oltmanns wrote:
The general idea: A daemon running in user space monitors input data
from an accelerometer. When the daemon detects a critical condition,
i.e., a sudden acceleration (for instance, laptop slides off the desk),
it signals the kernel so the hard disk may be put into a (more)
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few issues outlined below.
In the
Marin Mitov wrote:
On Tuesday 26 February 2008 12:59:04 am you wrote:
Divy Le Ray wrote:
From: "Divy Le Ray" <[EMAIL PROTECTED]>
Date: Wed, 20 Feb 2008 21:57:08 -0800
The driver is cxgb3 here, it uses LLTX.
That's extremely unfortunate, hopefully you can update it to
use a model like tg3
Welcome to test this... (attached, not tested nor even compiled, really)
Jeff
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 0562b0a..7b1f1ee 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -1694,12 +1694,17 @@ void
Divy Le Ray wrote:
From: "Divy Le Ray" <[EMAIL PROTECTED]>
Date: Wed, 20 Feb 2008 21:57:08 -0800
The driver is cxgb3 here, it uses LLTX.
That's extremely unfortunate, hopefully you can update it to
use a model like tg3 and others use. LLTX is a lost cause
for hardware device drivers, and in
Tim Ellis wrote:
On 15 Feb 2008, at 21:45, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote:
That's strange though. Somebody with knowledge of that HW (or
specs) who
can spot something ? Could it be an issue with timing ?
I don't have HW access to this
Alan Cox wrote:
Signed-off-by: Crane Cai <[EMAIL PROTECTED]>
Acked-by: Jeff Garzik <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Vomitted-upon-by: Alan Cox <[EMAIL PROTECTED]>
- if ((pdev->class >
Mark Lord wrote:
Pavel Machek wrote:
This is a patch (very ugly, assumes you have just one disk) to bring
powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch
as a base.
It saves .5W compared to config with disk spinning, and even .15W
compared to hdparm -y... on my thinkpad
/libata.h |1 -
2 files changed, 4 insertions(+), 2 deletions(-)
Adrian Bunk (1):
make atapi_dmadir static
Jeff Garzik (1):
Revert "power_state: get rid of write-only variable in SATA"
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index fbc243
Pavel Machek wrote:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
Author: Pavel Machek <[EMAIL PROTECTED]>
Date: Thu Feb 21 13:56:55 2008 +0100
power_state: get rid of write-only variable in SATA
This is pretty unlikely to be it. Can you double check that this patch
really breaks
Michael S. Tsirkin wrote:
git bisect points at this commit:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
power_state: get rid of write-only variable in SATA
Hello Pavel --
It looks like this not a write-only variable after all...
Jeff
--
To unsubscribe from this list: send the
Marin Mitov wrote:
Hi all,
I experience very rare freezes at heavy outbound traffic
(sending ~4GB DVD image to another host(s) on the same LAN)
using skge driver (NIC on the mobo) as well as (recently tested)
using rtl8139 or dmfe NICs on the PCI bus. There is a single
switch between them
Björn Steinbrink wrote:
On 2008.02.07 00:58:42 +0100, Thomas Gleixner wrote:
current mainline triggers:
WARNING: at /home/tglx/work/kernel/x86/linux-2.6/arch/x86/mm/highmem_32.c:52
kmap_atomic_prot+0xe5/0x19b()
Modules linked in: ahci(+) sata_sil libata sd_mod scsi_mod raid1 ext3 jbd
Ondrej Zary wrote:
When the chip dies (probably because of a bug somewhere in the driver),
de_stop_rxtx() fails and changing the media type crashes the whole machine.
Replace BUG_ON() in de_set_media() with a warning.
Signed-off-by: Ondrej Zary <[EMAIL PROTECTED]>
---
Ondrej Zary wrote:
When the chip dies (probably because of a bug somewhere in the driver),
de_stop_rxtx() fails and changing the media type crashes the whole machine.
Replace BUG_ON() in de_set_media() with a warning.
Signed-off-by: Ondrej Zary [EMAIL PROTECTED]
---
Björn Steinbrink wrote:
On 2008.02.07 00:58:42 +0100, Thomas Gleixner wrote:
current mainline triggers:
WARNING: at /home/tglx/work/kernel/x86/linux-2.6/arch/x86/mm/highmem_32.c:52
kmap_atomic_prot+0xe5/0x19b()
Modules linked in: ahci(+) sata_sil libata sd_mod scsi_mod raid1 ext3 jbd
Marin Mitov wrote:
Hi all,
I experience very rare freezes at heavy outbound traffic
(sending ~4GB DVD image to another host(s) on the same LAN)
using skge driver (NIC on the mobo) as well as (recently tested)
using rtl8139 or dmfe NICs on the PCI bus. There is a single
switch between them
Michael S. Tsirkin wrote:
git bisect points at this commit:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
power_state: get rid of write-only variable in SATA
Hello Pavel --
It looks like this not a write-only variable after all...
Jeff
--
To unsubscribe from this list: send the
Pavel Machek wrote:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
Author: Pavel Machek [EMAIL PROTECTED]
Date: Thu Feb 21 13:56:55 2008 +0100
power_state: get rid of write-only variable in SATA
This is pretty unlikely to be it. Can you double check that this patch
really breaks
/libata.h |1 -
2 files changed, 4 insertions(+), 2 deletions(-)
Adrian Bunk (1):
make atapi_dmadir static
Jeff Garzik (1):
Revert power_state: get rid of write-only variable in SATA
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index fbc2435..4fbcce7 100644
Mark Lord wrote:
Pavel Machek wrote:
This is a patch (very ugly, assumes you have just one disk) to bring
powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch
as a base.
It saves .5W compared to config with disk spinning, and even .15W
compared to hdparm -y... on my thinkpad
Alan Cox wrote:
Signed-off-by: Crane Cai [EMAIL PROTECTED]
Acked-by: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]
Vomitted-upon-by: Alan Cox [EMAIL PROTECTED]
- if ((pdev-class 8) == PCI_CLASS_STORAGE_IDE) {
- u8 tmp
Tim Ellis wrote:
On 15 Feb 2008, at 21:45, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote:
That's strange though. Somebody with knowledge of that HW (or
specs) who
can spot something ? Could it be an issue with timing ?
I don't have HW access to this
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Date: Wed, 20 Feb 2008 21:57:08 -0800
The driver is cxgb3 here, it uses LLTX.
That's extremely unfortunate, hopefully you can update it to
use a model like tg3 and others use. LLTX is a lost cause
for hardware device drivers, and in fact
Welcome to test this... (attached, not tested nor even compiled, really)
Jeff
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 0562b0a..7b1f1ee 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -1694,12 +1694,17 @@ void
Marin Mitov wrote:
On Tuesday 26 February 2008 12:59:04 am you wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Date: Wed, 20 Feb 2008 21:57:08 -0800
The driver is cxgb3 here, it uses LLTX.
That's extremely unfortunate, hopefully you can update it to
use a model like tg3 and
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few issues outlined below.
In the
Elias Oltmanns wrote:
The general idea: A daemon running in user space monitors input data
from an accelerometer. When the daemon detects a critical condition,
i.e., a sudden acceleration (for instance, laptop slides off the desk),
it signals the kernel so the hard disk may be put into a (more)
Mark Lord wrote:
Jeff Garzik wrote:
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few
Divy Le Ray wrote:
So, it sounds like Krishna's patch is ok, because the race does not
exist anymore in this driver?
The first part is right indeed, but the second part is breaking the
current usage of txq_stopped and
the logic that stops and restarts the Tx queue.
I can submit a patch
Jamie Lokier wrote:
By durable, I mean that fsync() should actually commit writes to
physical stable storage,
Yes, it should.
I was surprised that fsync() doesn't do this already. There was a lot
of effort put into block I/O write barriers during 2.5, so that
journalling filesystems can
Grant Grundler wrote:
On Mon, Feb 18, 2008 at 05:40:42PM +0100, Ondrej Zary wrote:
I think that de2104x driver should be removed (or at least its
MODULE_DEVICE_TABLE) and MODULE_DEVICE_TABLE with only 21040 and 21041 PCI
IDs added to de4x5.
I can send a patch if this is acceptable.
It's
Grant Grundler wrote:
ISTR there was a time when tulip would compete with de4x5 for devices.
tulip is the preferred driver. That's clearly no longer the case
and perhaps both distro's need to revisit this.
The only reason why de4x5 still exists is that the /tulip/ driver fails
to work on a
Grant Grundler wrote:
ISTR there was a time when tulip would compete with de4x5 for devices.
tulip is the preferred driver. That's clearly no longer the case
and perhaps both distro's need to revisit this.
The only reason why de4x5 still exists is that the /tulip/ driver fails
to work on a
Grant Grundler wrote:
On Mon, Feb 18, 2008 at 05:40:42PM +0100, Ondrej Zary wrote:
I think that de2104x driver should be removed (or at least its
MODULE_DEVICE_TABLE) and MODULE_DEVICE_TABLE with only 21040 and 21041 PCI
IDs added to de4x5.
I can send a patch if this is acceptable.
It's
David Miller wrote:
Jeff, I really don't want to pull that tree in. Please trust me as
your upstream to handle merging issues, as needed.
I trust you... Otherwise I wouldn't have volunteered to move my
upstream from Linus to you :)
My main issues/motivations were:
* quite simply, just
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ahci.c| 23 +--
drivers/ata/libata-core.c | 16 ++--
drivers/ata/libata-pmp.c
Christoph Hellwig wrote:
On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
hm. We'll see how it plays out... on the remove side, the above is
exact what happens in gdth_remove_one() without my patch, thus
consolidating two cases of the same code into one. There is a less
Pavel Machek wrote:
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek <[EMAIL PROTECTED]>
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b4985bc..a31572d 100644
--- a/drivers/ata/libata-core.c
+++
Christoph Hellwig wrote:
Eventually we shoud just kill the INT_COAL ifdefed code. It has never
been enabled and clutters up the driver quite badly.
Noted (queued)... fine by me, and makes life easier.
+#ifdef CONFIG_EISA
+ if ((ha->type == GDT_EISA) && (ha->ccb_phys))
+
Atsushi Nemoto wrote:
Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by
conversion to generic PHY layer in kernel 2.6.23.
Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 81bf005..1d210ed 100644
--- a/drivers/net/macb.c
Laura Garcia wrote:
Use register offset definition for WOLcgClr. This patch does not
change the driver behaviour.
Signed-off-by: Laura Garcia Liebana <[EMAIL PROTECTED]>
modified: drivers/net/via-rhine.c
---
drivers/net/via-rhine.c |2 +-
1 files changed, 1 insertions(+), 1
a_free()
- delete pointless zero-initializations of ha struct members, as these
are zeroed when ha is allocated (and never assigned any other value,
prior to the explicit zero initializations)
- consolidate thrice-repeated spinlock init
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
N
The following
make ARCH=i386 allmodconfig && \
make ARCH=i386 -sj5
on x86-64 produces the following build breakage at the post-build stage:
[...]
Root device is (9, 0)
Setup is 12504 bytes (padded to 12800 bytes).
System is 1883 kB
Kernel: arch/x86/boot/bzImage is ready (#2)
Andrew Morton wrote:
On Sat, 23 Feb 2008 12:31:02 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]>
wrote:
On Sat, 23 Feb 2008, Jeff Garzik wrote:
I know I am probably shooting myself in the foot here, since I am the original
author of mvsas, but...
Should we be adding new drivers duri
Olof Johansson wrote:
Hi,
On Sat, Feb 23, 2008 at 09:13:33AM -0600, James Bottomley wrote:
Jeff Garzik (1):
mvsas: Add Marvell 6440 SAS/SATA driver
[...]
drivers/scsi/mvsas.c| 2981
I just noticed that the file permissions
- Fix build 'make randconfig' build warning spotted by Toralf Foerster:
drivers/scsi/mvsas.c: In function 'mvs_hexdump':
drivers/scsi/mvsas.c:715: error: implicit declaration of function 'isalnum'
- Remove unneeded prototypes (spotted by hch)
Signed-off-by: Jeff Garzik <[EMAIL PROTEC
Jeff Garzik wrote:
On the net driver side of things, I have a few new net drivers that I
have queued for 2.6.26, because they did not make the merge window. This
is inconsistent with your apparently policy.
s/apparently/apparent/
Sometimes my fingers don't type the words that come out of my
James Bottomley wrote:
This is the latest crop of bug fixes plus one new driver: mvsas. We're
[...]
Jeff Garzik (1):
mvsas: Add Marvell 6440 SAS/SATA driver
[...]
Ke Wei (1):
mvsas: convert from rough draft to working driver
I know I am probably shooting myself in the foot
James Bottomley wrote:
This is the latest crop of bug fixes plus one new driver: mvsas. We're
[...]
Jeff Garzik (1):
mvsas: Add Marvell 6440 SAS/SATA driver
[...]
Ke Wei (1):
mvsas: convert from rough draft to working driver
I know I am probably shooting myself in the foot
Jeff Garzik wrote:
On the net driver side of things, I have a few new net drivers that I
have queued for 2.6.26, because they did not make the merge window. This
is inconsistent with your apparently policy.
s/apparently/apparent/
Sometimes my fingers don't type the words that come out of my
Olof Johansson wrote:
Hi,
On Sat, Feb 23, 2008 at 09:13:33AM -0600, James Bottomley wrote:
Jeff Garzik (1):
mvsas: Add Marvell 6440 SAS/SATA driver
[...]
drivers/scsi/mvsas.c| 2981
I just noticed that the file permissions
Andrew Morton wrote:
On Sat, 23 Feb 2008 12:31:02 -0800 (PST) Linus Torvalds [EMAIL PROTECTED]
wrote:
On Sat, 23 Feb 2008, Jeff Garzik wrote:
I know I am probably shooting myself in the foot here, since I am the original
author of mvsas, but...
Should we be adding new drivers during -rc
The following
make ARCH=i386 allmodconfig \
make ARCH=i386 -sj5
on x86-64 produces the following build breakage at the post-build stage:
[...]
Root device is (9, 0)
Setup is 12504 bytes (padded to 12800 bytes).
System is 1883 kB
Kernel: arch/x86/boot/bzImage is ready (#2)
()
- delete pointless zero-initializations of ha struct members, as these
are zeroed when ha is allocated (and never assigned any other value,
prior to the explicit zero initializations)
- consolidate thrice-repeated spinlock init
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
NOTE: Applies on top
Laura Garcia wrote:
Use register offset definition for WOLcgClr. This patch does not
change the driver behaviour.
Signed-off-by: Laura Garcia Liebana [EMAIL PROTECTED]
modified: drivers/net/via-rhine.c
---
drivers/net/via-rhine.c |2 +-
1 files changed, 1 insertions(+), 1
Atsushi Nemoto wrote:
Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by
conversion to generic PHY layer in kernel 2.6.23.
Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED]
---
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 81bf005..1d210ed 100644
--- a/drivers/net/macb.c
Christoph Hellwig wrote:
Eventually we shoud just kill the INT_COAL ifdefed code. It has never
been enabled and clutters up the driver quite badly.
Noted (queued)... fine by me, and makes life easier.
+#ifdef CONFIG_EISA
+ if ((ha-type == GDT_EISA) (ha-ccb_phys))
+
Pavel Machek wrote:
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek [EMAIL PROTECTED]
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b4985bc..a31572d 100644
--- a/drivers/ata/libata-core.c
+++
Christoph Hellwig wrote:
On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
hm. We'll see how it plays out... on the remove side, the above is
exact what happens in gdth_remove_one() without my patch, thus
consolidating two cases of the same code into one. There is a less
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ahci.c| 23 +--
drivers/ata/libata-core.c | 16 ++--
drivers/ata/libata-pmp.c
David Miller wrote:
Jeff, I really don't want to pull that tree in. Please trust me as
your upstream to handle merging issues, as needed.
I trust you... Otherwise I wouldn't have volunteered to move my
upstream from Linus to you :)
My main issues/motivations were:
* quite simply, just
Daniel Barkalow wrote:
I find that the sequence of changes I make is pretty much unrelated to the
sequence of changes that end up in the project's history, because my
changes as I make them involve writing a lot of stubs (so I can build) and
then filling them out. It's beneficial to have
Anders Eriksson wrote:
Is smartd prepared to handle /dev/sdX style devices?
Yes. You need to pass "-d ata" to smartd and smartctl, if your scripts
are not already doing so.
If this is the prefered driver these days, maybe it shouldn't be marked
experimental in the menu anymore?
It's
Ingo Molnar wrote:
2) you might know that Deja-Vu moment when you look at a new patch that
has been submitted to lkml and you have a strange, weird "feeling"
that there's something wrong about the patch.
It's totally subconscious, and you take a closer look and a few
seconds
Anders Eriksson wrote:
Hi,
Trying out 2.6.25-rc2 smartd always causes my box to hang. I can switch
vt:s and the keyboard seems to work.
Using sysrq-e I noticed a callpath open -> ext3 -> journals -> sync_buffer ->
io_scheduel -> generic_unplig_device.
I'd guess the open stems from smartd.
Anders Eriksson wrote:
Hi,
Trying out 2.6.25-rc2 smartd always causes my box to hang. I can switch
vt:s and the keyboard seems to work.
Using sysrq-e I noticed a callpath open - ext3 - journals - sync_buffer -
io_scheduel - generic_unplig_device.
I'd guess the open stems from smartd.
Ingo Molnar wrote:
2) you might know that Deja-Vu moment when you look at a new patch that
has been submitted to lkml and you have a strange, weird feeling
that there's something wrong about the patch.
It's totally subconscious, and you take a closer look and a few
seconds
Anders Eriksson wrote:
Is smartd prepared to handle /dev/sdX style devices?
Yes. You need to pass -d ata to smartd and smartctl, if your scripts
are not already doing so.
If this is the prefered driver these days, maybe it shouldn't be marked
experimental in the menu anymore?
It's not
Daniel Barkalow wrote:
I find that the sequence of changes I make is pretty much unrelated to the
sequence of changes that end up in the project's history, because my
changes as I make them involve writing a lot of stubs (so I can build) and
then filling them out. It's beneficial to have
Lachlan McIlroy wrote:
Remove empty file fs/xfs/Makefile-linux-2.6.
Already in the upstream kernel...
commit 1803f3389b7ac9ed33ea561b3b94e22e2864a95d
Author: Linus Torvalds <[EMAIL PROTECTED]>
Date: Wed Feb 20 19:55:09 2008 -0800
Remove empty file remnants that were left in the
Krzysztof Halasa wrote:
Jeff Garzik <[EMAIL PROTECTED]> writes:
If a driver is full of lines of length >80, that's a problem.
I'm not sure.
We all have more than 80-chars wide displays for years, don't we? The
Every time this discussion comes up, people point out that it remain
Pavel Machek wrote:
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek <[EMAIL PROTECTED]>
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b4985bc..a31572d 100644
--- a/drivers/ata/libata-core.c
+++
Pavel Machek wrote:
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek [EMAIL PROTECTED]
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b4985bc..a31572d 100644
--- a/drivers/ata/libata-core.c
+++
Krzysztof Halasa wrote:
Jeff Garzik [EMAIL PROTECTED] writes:
If a driver is full of lines of length 80, that's a problem.
I'm not sure.
We all have more than 80-chars wide displays for years, don't we? The
Every time this discussion comes up, people point out that it remains
highly
Lachlan McIlroy wrote:
Remove empty file fs/xfs/Makefile-linux-2.6.
Already in the upstream kernel...
commit 1803f3389b7ac9ed33ea561b3b94e22e2864a95d
Author: Linus Torvalds [EMAIL PROTECTED]
Date: Wed Feb 20 19:55:09 2008 -0800
Remove empty file remnants that were left in the
Divy Le Ray wrote:
Jeff Garzik wrote:
Mostly fixes, a few cleanups (generally assisting fixes), and an
exception for PS3 wireless because it had been posted, reviewed and
acked for a while, just not committed.
Please pull from 'upstream-davem' branch of
master.kernel.org:/pub/scm/linux/kernel
Ingo Molnar wrote:
* Jeff Garzik <[EMAIL PROTECTED]> wrote:
After analyzing the elements that save_flags/cli/sti/restore_flags
were protecting, convert their usages to a global spinlock (the
easiest and most obvious next-step). There were some usages of flags
being intentionally
Note: Tejun's change is a feature addition, but one that is IMO
important for debugging and serious-bug workarounds. It's
self-contained and should not affect anyone not using the new parm.
Please pull from 'upstream-linus' branch of
-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Andrew, here is a patch that drastically reduces the number of sparse
warnings in libata. Alan Cox has suggested a clamp_t macro be added
to kernel.h instead to avoid this issue. I don't believe Jeff Garzik
has given an opinion yet (other than not ap
Holger Macht wrote:
On Thu 14. Feb - 13:40:48, Holger Macht wrote:
If a device/bay is inside a docking station, we need to register for dock
events additionally to bay events. If a dock event occurs, the dock driver
will call the appropriate handler (ata_acpi_ap_notify() or
Harvey Harrison wrote:
Use ld_qdi and ld_winbond to avoid shadowing static int
variables qdi and winbond. The ld_ prefix refers to
legacy_data.
drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one
drivers/ata/pata_legacy.c:128:12: originally declared here
Greg KH wrote:
On Mon, Feb 18, 2008 at 08:34:42AM +0100, Jonas Bonn wrote:
And again, what does this buy us?
Clarity and simplicity, I hope... there are a bunch of definitions
scattered about the kernel that omit the __devinitdata modifier despite the
documentation stating that it should
In current upstream, fs/xfs/Makefile-linux-2.6 is zero bytes, which
means 'make distclean' deletes, and git promptly (and properly) squawks
about a working tree/index difference.
Would somebody please delete this file?
Thanks,
Jeff
--
To unsubscribe from this list: send the line
Note: this is based off of Linus's latest commit
(5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous
submissions are now upstream (thanks!).
Please pull from 'upstream-davem' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-davem
to receive
Adrian Bunk wrote:
This patch fixes a check-after-use spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git
a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 6e9f619..963630c 100644
---
Harvey Harrison wrote:
The forward declarations were already marked static, make the definitions
be static as well. Fixes the sparse warnings as well.
drivers/net/tlan.c:1403:5: warning: symbol 'TLan_HandleInvalid' was not
declared. Should it be static?
drivers/net/tlan.c:1435:5: warning:
Leonardo Potenza wrote:
From: Leonardo Potenza <[EMAIL PROTECTED]>
Suppress the warning message about the 'netcard_portlist' defined but not used.
Signed-off-by: Leonardo Potenza <[EMAIL PROTECTED]>
---
When building cs89x0 as a module, the following warning message is generated:
Thomas Klein wrote:
This patch adds kdump support to the ehea driver. As the firmware doesn't free
resource handles automatically, the driver has to run an as simple as possible
free resource function in case of a crash shutdown. The function iterates over
two arrays freeing all resource handles
Thomas Klein wrote:
This patch adds kdump support to the ehea driver. As the firmware doesn't free
resource handles automatically, the driver has to run an as simple as possible
free resource function in case of a crash shutdown. The function iterates over
two arrays freeing all resource handles
Leonardo Potenza wrote:
From: Leonardo Potenza [EMAIL PROTECTED]
Suppress the warning message about the 'netcard_portlist' defined but not used.
Signed-off-by: Leonardo Potenza [EMAIL PROTECTED]
---
When building cs89x0 as a module, the following warning message is generated:
Harvey Harrison wrote:
The forward declarations were already marked static, make the definitions
be static as well. Fixes the sparse warnings as well.
drivers/net/tlan.c:1403:5: warning: symbol 'TLan_HandleInvalid' was not
declared. Should it be static?
drivers/net/tlan.c:1435:5: warning:
Adrian Bunk wrote:
This patch fixes a check-after-use spotted by the Coverity checker.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git
a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 6e9f619..963630c 100644
---
201 - 300 of 7471 matches
Mail list logo
