Re: Kernel Options.

2007-06-26 Thread Jeff Mahoney
ck out Documentation/nfsroot.txt. - -Jeff - -- Jeff Mahoney SUSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFGgZB0LPWxlyuTD7IRAiGxAKCgvUOCkf5nTsxnWb7ZXk4rD70PjACfdWPb NgG6bIdZlLJqgQmAtMb05KI= =cAOo --

[PATCH] saa7134: fix thread shutdown handling

2007-06-21 Thread Jeff Mahoney
8, when request_irq() failed. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> --- drivers/media/video/saa7134/saa7134-tvaudio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/video/saa7134/saa7134-tvaudio.c 2007-06-12 15:45:16.0 -0400 +++ b/drivers/me

[PATCH] reiserfs: mailing list has moved

2007-06-07 Thread Jeff Mahoney
This patch changes MAINTAINERS to reflect the new location of the reiserfs development mailing list. The old list forwards to the new one. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/MAINTAINERS

Re: 2.6.21 reiserfs -- cicular locking?

2007-04-27 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Mahoney wrote: > Takashi Iwai wrote: >>> At Fri, 27 Apr 2007 07:09:01 -0400, >>> Jeff Mahoney wrote: >>>> -BEGIN PGP SIGNED MESSAGE- >>>> Hash: SHA1 >>>> >>>> Takash

Re: 2.6.21 reiserfs -- cicular locking?

2007-04-27 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Takashi Iwai wrote: > At Fri, 27 Apr 2007 07:09:01 -0400, > Jeff Mahoney wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Takashi Iwai wrote: >>> At Fri, 27 Apr 2007 12:09:03 +0200, >>>

Re: 2.6.21 reiserfs -- cicular locking?

2007-04-27 Thread Jeff Mahoney
dy holding lock: >> (&inode->i_mutex){--..}, at: [] open_namei+0xe2/0x5a2 >> >> which lock already depends on the new lock. > The message disappears when I revert the patch: > > commit 9b7f375505f5611efb562065b57814b28a81abc3 > Author: Jeff Mahoney <[EMAIL P

Re: [PATCH] reiserfs: fix xattr root locking/refcount bug

2007-04-22 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Morton wrote: > On Sat, 21 Apr 2007 11:26:31 -0400 Jeff Mahoney <[EMAIL PROTECTED]> wrote: > >> The listxattr() and getxattr() operations are only protected by a read >> lock. As a result, if either of these opera

Re: [RFC][PATCH] reiserfs vs BKL

2007-04-21 Thread Jeff Mahoney
time. Interestingly, I've been doing reiserfs xattr development recently using 2.6.21-rc7-git2, and I'm not seeing any of these messages. # CONFIG_PREEMPT_NONE is not set CONFIG_PREEMPT_VOLUNTARY=y # CONFIG_PREEMPT is not set # CONFIG_PREEMPT_BKL is not set - -Jeff - -- Jeff Mahoney SUSE L

[PATCH] reiserfs: fix xattr root locking/refcount bug

2007-04-21 Thread Jeff Mahoney
dir() only checked for a negative dentry and returned -ENODATA. This version treats a missing privroot as -ENODATA. This is safe since xattrs are disabled automatically in reiserfs_xattr_init() when the privroot can't be created or found. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]&

Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs

2007-04-21 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Mahoney wrote: > Andrea Righi wrote: >> Jeff Mahoney wrote: >>> I have the patchset that I mentioned, but I'm not proposing it for 2.6.21. >>> It's much too invasive to be introduced in an -rc7, but it do

Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs

2007-04-21 Thread Jeff Mahoney
Andrea Righi wrote: > Jeff Mahoney wrote: >> I have the patchset that I mentioned, but I'm not proposing it for 2.6.21. >> It's much too invasive to be introduced in an -rc7, but it does include >> locking changes that I believe avoid this bug. >> >&

Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs

2007-04-20 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Morton wrote: > On Wed, 18 Apr 2007 11:00:00 -0400 > Jeff Mahoney <[EMAIL PROTECTED]> wrote: > >>> Do you think that could be a reason of the extra reference count on >>> xattr_root dentry? >> No, I

Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs

2007-04-18 Thread Jeff Mahoney
lock. If we get two concurrent threads looking up an xattr before the root has been saved, there's a window where REISERFS_SB(s)->xattr_root is NULL but we've already looked it up and taken a reference on it. I have a patch set to clean up the extended attribute code that fixes this pro

Re: [PATCH] autofs4: fix race in unhashed dentry code

2007-04-11 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Kent wrote: > On Thu, 2007-04-12 at 02:00 +0800, Ian Kent wrote: >> On Thu, 2007-04-12 at 01:49 +0800, Ian Kent wrote: >>> On Wed, 2007-04-11 at 11:05 -0400, Jeff Mahoney wrote: >>>> Commit f50b6f8691cae2e0064c499

[PATCH] autofs4: fix race in unhashed dentry code

2007-04-11 Thread Jeff Mahoney
emoval from the rehash list. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> --- fs/autofs4/root.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/fs/autofs4/root.c 2007-04-11 09:41:44.0 -0400 +++ b/fs/autofs4/root.c 2007-04-11 10:54:37.0 -0400 @@ -47

Re: Reiser4. BEST FILESYSTEM EVER.

2007-04-08 Thread Jeff Mahoney
n the long term, both in > terms of support as the kernel migrated and new feature support. It > is for that reason that Hans' personality traits that tend to drive > away those developers who would help them, beyond those that he hires, > is what has been so self-destructive to Rei

Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks

2007-02-07 Thread Jeff Mahoney
t; remove it and directly mark the inodes as private. >> >> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> >> Cc: Jeff Mahoney <[EMAIL PROTECTED]> >> >> Index: b/fs/reiserfs/xattr.c >>

Re: reiserfs NET=n build error

2006-11-19 Thread Jeff Mahoney
for this architecture". > > reiserfs use of it is just plain broken. net/* is fine, since all > final uses are via csum_fold() or equivalents. > > Note that reiserfs use is broken in another way: it takes fixed-endian value > and feeds it to cpu_to_le32(). IOW, even if everything

Re: reiserfs NET=n build error

2006-11-19 Thread Jeff Mahoney
dependent checksums, but there's still the issue of old kernels not understanding it on any arch. Kind of a nice shot to the foot considering the work I put into making reiserfs endian safe in the 2.4 days. I'm hoping there's a better solution to be found than creating a checksu

Re: reiserfs NET=n build error

2006-11-19 Thread Jeff Mahoney
its output varies by architecture. > > I would copy a relatively simple C implementation, like > arch/h8300/lib/checksum.c As long as the h8300 version has the same output as the x86 version. - -Jeff - -- Jeff Mahoney SUSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.2

Re: [PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Dilger wrote: > On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote: >> Currently, if a corrupted directory entry with rec_len=0 is encountered, >> we still trust that the data is valid. This can cause an infin

[PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Jeff Mahoney
where de->rec_len == 0 is used by itself and I'd be fine doing that too, but I figure more integrity checking isn't a bad thing. This fixes the problem described at: http://projects.info-pull.com/mokb/MOKB-10-11-2006.html Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> diff

Re: 2.6.12.3 clock drifting twice too fast (amd64)

2005-08-17 Thread Jeff Mahoney
is may take some time. Specifically, I get this ... nsxfeval-0251 [06] acpi_evaluate_object : Handle is NULL and Pathname is relative ... for several paths, which a bit of debugging tells me is _PR[0-3] from the root node. Unfortunately, there is no instance of _PR[0-3] in the DSDT asl file. - -Jeff - --

Re: 2.6.12.3 clock drifting twice too fast (amd64)

2005-08-16 Thread Jeff Mahoney
). It does appear that time is running 2x normal time. Booting with noapictimer cleared up the timing issues, though it did introduce some IRQ badness. - -Jeff - -- Jeff Mahoney SuSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFDAnPzLPWxlyuTD7IRAuQ+AKCoK4Bvj9YaSxK1cYzK

Re: BUG: reiserfs+acl+quota deadlock

2005-08-12 Thread Jeff Mahoney
ent when the inode is created, xattrs will be locked so that the ACL can be inherited. Since reiserfs_new_inode is called from the VFS layer with inode->i_sem downed, {set,remove}xattr is locked out. The default ACL can't be removed/added/changed while reiserfs_new_inode is running. There

[PATCH] reiserfs: fix deadlock in inode creation failure path w/ default ACL

2005-07-18 Thread Jeff Mahoney
relock is just to balance out the release in the caller. The locking needs some reworking to be more sane, but that's more intrusive and I was just looking to fix this bug. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> diff -ruNpX dontdiff linux-2.6.13-rc3/fs/reiserfs/inode.c linux

[PATCH] Lindent: ignore .indent.pro

2005-07-13 Thread Jeff Mahoney
When I recently submitted a Lindent patch, it turned out that my .indent.pro options were also applied to the tree. This patch directs indent(1) to ignore the .indent.pro directives and only use options specified on the command line. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]>

[PATCH/SCRIPT] reiserfs: run scripts/Lindent on reiserfs code

2005-07-12 Thread Jeff Mahoney
The attached script runs scripts/Lindent against fs/reiserfs.c and include/linux/reiserfs_*.h It's a quick one-liner consisting of: scripts/Lindent fs/reiserfs/*.c include/linux/reiserfs_*.h -Jeff -- Jeff Mahoney SuSE Labs reiserfs-lindent.sh Description: Bourne shell script

[PATCH] reiserfs: fix up case where indent misreads the code

2005-07-12 Thread Jeff Mahoney
indent(1) doesn't know how to handle the "do not compile" error. It results in the item_ops array declaration being indented a tab stop in when it should not be. This patch replaces it with a #error that describes why it's failing. Signed-off-by: Jeff Mahoney <[EMAIL P

Re: [PATCH/URL] reiserfs: reformat code with Lindent

2005-07-12 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus Torvalds wrote: > > On Tue, 12 Jul 2005, Jeff Mahoney wrote: >> This patch contains the result of running scripts/Lindent against >> fs/reiserfs/*.c and include/linux/reiserfs_*.h. > > That can't be true. It

[PATCH/URL] reiserfs: reformat code with Lindent

2005-07-12 Thread Jeff Mahoney
wouldn't really oppose them either. Due to the size of this patch (1.5M), I've posted it at: ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/cleanups/2.6.13-rc2/01-reiserfs-lindent.diff -Jeff -- Jeff Mahoney SuSE Labs - To unsubscribe from this list: send the line "unsubsc

[PATCH 1/3] openfirmware: generate device table for userspace

2005-07-06 Thread Jeff Mahoney
-tools and hotplug must be applied. Those patches are available at: ftp://ftp.suse.com/pub/people/jeffm/linux/macio-hotplug/ Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> diff -ruNpX dontdiff linux-2.6.13-rc2.orig/arch/ppc/syslib/of_device.c linux-2.6.13-rc2/arch/ppc/syslib/of_de

[PATCH 2/3 (updated)] openfirmware: add sysfs nodes for open firmware devices

2005-07-06 Thread Jeff Mahoney
on option enables a list of files. -obj-$(CONFIG_PPC_PMAC) += macio_asic.o +obj-$(CONFIG_PPC_PMAC) += macio_asic.o macio_sysfs.o obj-$(CONFIG_PMAC_MEDIABAY)+= mediabay.o obj-$(CONFIG_MAC_EMUMOUSEBTN) += mac_hid.o -- Jeff Mahoney SuSE Labs - To unsubscribe from this list: se

Re: [PATCH 2/3 (updated)] openfirmware: add sysfs nodes for open firmware devices

2005-07-06 Thread Jeff Mahoney
> unhappy on my G5. > > I'm trying to hunt down the reason (no oopses, at least). Hrm. These patches always get more fun. What behavior are you seeing? - -Jeff - -- Jeff Mahoney SuSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFCzEF3LPWxlyuTD7

[PATCH 3/3] openfirmware: implement hotplug for macio devices

2005-07-06 Thread Jeff Mahoney
effm/linux/macio-hotplug/ Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> diff -ruNpX dontdiff linux-2.6.13-rc2.orig/drivers/macintosh/macio_asic.c linux-2.6.13-rc2/drivers/macintosh/macio_asic.c --- linux-2.6.13-rc2.orig/drivers/macintosh/macio_asic.c2005-07-06 11:44:21.0

[PATCH] vfs: namei operations should pass nameidata when available

2005-03-28 Thread Jeff Mahoney
ch filesystem is already passed valid nameidata from open_namei in the existing code. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> Index: linux-2.6.11/fs/namei.c === --- linux-2.6.11.orig/fs/namei.c +++ linux-2.6.11/fs/namei.c @@

Re: [PATCH] blockdev: fix for racing mount/umount

2005-03-17 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus Torvalds wrote: > > On Tue, 15 Mar 2005, Jeff Mahoney wrote: > >>This patch is another take at fixing the race between mount and umount >>resetting the blocksize and causing buffer errors, infinite loops in >>__getb

Re: [PATCH] blockdev: fix for racing mount/umount

2005-03-15 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus Torvalds wrote: > > On Tue, 15 Mar 2005, Jeff Mahoney wrote: > >>This patch is another take at fixing the race between mount and umount >>resetting the blocksize and causing buffer errors, infinite loops in >>__getb

[PATCH] blockdev: fix for racing mount/umount

2005-03-15 Thread Jeff Mahoney
ng it for a new mount. It's ugly, and I'm open to suggestions, but it seems to be the only way to stop this race reliably. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> diff -ruNpX dontdiff linux-2.6.11/fs/block_dev.c linux-2.6.11.bs/fs/block_dev.c --- linux-2.6.11/fs/block_d

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Jeff Mahoney
biliy would be to have the kernel replace spaces with > underscores for the sake of matching. That would make life easier for > everybody. I had suggested this a few days ago, but got no response. Can we agree that this would be an acceptable solution? - -Jeff - -- Jeff Mahoney SuSE Labs -BEGI

Re: [PATCH 1/4] vfs: adds the S_PRIVATE flag and adds use to security

2005-03-05 Thread Jeff Mahoney
.au/~akpm/linux/patches/stuff/selinux-reiserfs/) That's correct, the others are unchanged. - -Jeff - -- Jeff Mahoney SuSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCKe+XLPWxlyuTD7IRApGeAJ9UWMIQSV1WlKlJg1Ml/hP36zSW0ACePTDW qGUzKyItFVw9DFp9UoyaNHQ= =LdAr

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-04 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Olaf Hering wrote: > On Thu, Mar 03, Jeff Mahoney wrote: > > >>-BEGIN PGP SIGNED MESSAGE- >>Hash: SHA1 >> >>Olaf Hering wrote: >> >>> On Thu, Mar 03, Jeff Mahoney wrote: >>> >>

Re: [PATCH 1/4] vfs: adds the S_PRIVATE flag and adds use to security

2005-03-03 Thread Jeff Mahoney
will be NULL on NFS filesystems. I'll send out a revised version later this evening. - -Jeff - -- Jeff Mahoney SuSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCJ74eLPWxlyuTD7IRAg3zAJ4w5ThhGVHoTNKf+4TyqwU/NtRUvACfWnje EIiFuTZPWZq245g/9xrkZLA= =hTpo -END PGP

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-03 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Olaf Hering wrote: > On Thu, Mar 03, Jeff Mahoney wrote: > > >>Is whitespace (in any form) allowed in the compatible value? > > > Yes, whitespace is used at least in the toplevel compatible file, like > 'Power

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-03 Thread Jeff Mahoney
lug to work with macio devices, patches to module-init-tools >>and hotplug must be applied. Those patches are available at: >> >>ftp://ftp.suse.com/pub/people/jeffm/linux/macio-hotplug/ >> >>Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]> > &

Re: Help tracking down problem --- endless loop in __find_get_block_slow (now with the patch)

2005-02-28 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Mahoney wrote: > Andrew Morton wrote: > >>>Jeff Mahoney <[EMAIL PROTECTED]> wrote: >>> >>> >>>>In my experience, the loop is actually outside of >>>>__find_get_block_slow(), in __

Re: Help tracking down problem --- endless loop in __find_get_block_slow

2005-02-28 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Mahoney wrote: > Andrew Morton wrote: > >>>Jeff Mahoney <[EMAIL PROTECTED]> wrote: >>> >>> >>>>In my experience, the loop is actually outside of >>>>__find_get_block_slow(), in __

Re: Help tracking down problem --- endless loop in __find_get_block_slow

2005-02-25 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Morton wrote: > Jeff Mahoney <[EMAIL PROTECTED]> wrote: > >>In my experience, the loop is actually outside of >>__find_get_block_slow(), in __getblk_slow(). I've been using xmon to >>interrupt the kerne

Re: Help tracking down problem --- endless loop in __find_get_block_slow

2005-02-22 Thread Jeff Mahoney
, the loop is actually outside of __find_get_block_slow(), in __getblk_slow(). I've been using xmon to interrupt the kernel, and the results vary but are all rooted in the for(;;) loop in __getblk_slow. It appears as though grow_buffers is finding/creating the page, but then __find_get_block ca

Re: Controversy over dynamic linking -- how to end the panic

2001-06-21 Thread Jeff Mahoney
dware for which the driver provides an interface) without the driver code - however, the driver requires the kernel to be usable. Still using your analogy, it would seem the driver is the application, and the kernel is the library. The facilities that the driver provides to the kerne

Re: Linux 2.4.6-pre3 breaks ReiserFS mount on boot

2001-06-18 Thread Jeff Mahoney
gt; > > Out of curiousity, what device are you trying to boot from? 03:42, at least > > according to linux/Documentation/devices.txt, corresponds to /dev/hda42. > > or, noting that kdevname used hexadecimal, > /dev/hdb2 Ugh. Ignore me, I should've known that. -Jeff

Re: Linux 2.4.6-pre3 breaks ReiserFS mount on boot

2001-06-18 Thread Jeff Mahoney
to mount? I'm not familiar with how some IDE RAID controllers present disks, but it was the first thing I noticed. -Jeff -- Jeff Mahoney [EMAIL PROTECTED] [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: LANANA: To Pending Device Number Registrants

2001-05-15 Thread Jeff Mahoney
n, thus making the disk replaced. The "moving" of the disk to a different location shouldn't be much different than a device disappearing and reappearing. Of course, this is all a high level view of the whole process, but I thought I'd throw it out there for comment.

<    1   2