Re: linux-next: build warning after merge of the wireless-drivers-next tree

>>> > access to retry count") >>> > >>> > This is a correct diagnosis. >>> >>> Thanks for the report. Jes, can you send a patch to fix this? (Unless >>> someone else beats to it.) >>> >>> -- >>> Kalle Valo >> >> I posted a patch on the 26th that fixes this > > Thanks, I see it: > > https://patchwork.kernel.org/patch/9448225/ > > The commit log doesn't mention anything about the compilation warning, > I'll add that. Also a Fixes line is nice to have. I'm happy with this fix Acked-by: Jes Sorensen <jes.soren...@redhat.com>

Re: linux-next: build warning after merge of the wireless-drivers-next tree

his is a correct diagnosis. >>> >>> Thanks for the report. Jes, can you send a patch to fix this? (Unless >>> someone else beats to it.) >>> >>> -- >>> Kalle Valo >> >> I posted a patch on the 26th that fixes this > > Thanks, I see it: > > https://patchwork.kernel.org/patch/9448225/ > > The commit log doesn't mention anything about the compilation warning, > I'll add that. Also a Fixes line is nice to have. I'm happy with this fix Acked-by: Jes Sorensen

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

John Heenan writes: > Barry Day has submitted real world reports for the 8192eu and 8192cu. > This needs to be acknowledged. I have submitted real world reports for > the 8723bu. Lets get this a little more clear - first of all, I have asked you to investigate which part resolves

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

John Heenan writes: > Barry Day has submitted real world reports for the 8192eu and 8192cu. > This needs to be acknowledged. I have submitted real world reports for > the 8723bu. Lets get this a little more clear - first of all, I have asked you to investigate which part resolves the problem.

Re: [PATCH] net: alteon: acenic: use new api ethtool_{get|set}_link_ksettings

t/alteon/acenic.c | 65 ++--- > 1 files changed, 35 insertions(+), 30 deletions(-) Nothing that sticks out to me Acked-by: Jes Sorensen <jes.soren...@gmail.com> Jes > diff --git a/drivers/net/ethernet/alteon/acenic.c > b/drivers/net/ethernet/alteon/acenic.c > index a5c1e29..16f0c70

Re: [PATCH] net: alteon: acenic: use new api ethtool_{get|set}_link_ksettings

> 1 files changed, 35 insertions(+), 30 deletions(-) Nothing that sticks out to me Acked-by: Jes Sorensen Jes > diff --git a/drivers/net/ethernet/alteon/acenic.c > b/drivers/net/ethernet/alteon/acenic.c > index a5c1e29..16f0c70 100644 > --- a/drivers/net/ethernet/alteon/acen

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

Joe Perches <j...@perches.com> writes: > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> Code is 80 characters wide, and comments are /* */ never the ugly C++ >> crap. > > You might look at the recent Linus Torvalds authored commit > 5e467652ffef (?

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

Joe Perches writes: > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> Code is 80 characters wide, and comments are /* */ never the ugly C++ >> crap. > > You might look at the recent Linus Torvalds authored commit > 5e467652ffef (?printk: re-organize log_out

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

John Heenan writes: > The rtl8723bu wireless IC shows evidence of a more agressive approach to > power saving, powering down its RF side when there is no wireless > interfacing but leaving USB interfacing intact. This makes the wireless > IC more suitable for use in devices which

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

John Heenan writes: > The rtl8723bu wireless IC shows evidence of a more agressive approach to > power saving, powering down its RF side when there is no wireless > interfacing but leaving USB interfacing intact. This makes the wireless > IC more suitable for use in devices which need to keep

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

John Heenan writes: > Thanks for your reply. > > The code was tested on a Cube i9 which has an internal rtl8723bu. > > No other devices were tested. > > I am happy to accept in an ideal context hard coding macpower is > undesirable, the comment is undesirable and it is wrong to

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

John Heenan writes: > Thanks for your reply. > > The code was tested on a Cube i9 which has an internal rtl8723bu. > > No other devices were tested. > > I am happy to accept in an ideal context hard coding macpower is > undesirable, the comment is undesirable and it is wrong to assume the > issue

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

John Heenan writes: > Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set > macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) > using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results > occurs with 'Fix for

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

John Heenan writes: > Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set > macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) > using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results > occurs with 'Fix for authentication

Re: [PATCH 24/54] md/raid1: Improve another size determination in setup_conf()

Dan Carpenter writes: > Compare: > > foo = kmalloc(sizeof(*foo), GFP_KERNEL); > > This says you are allocating enough space for foo. It can be reviewed > by looking at one line. If you change the type of foo it will still > work. > > foo =

Re: [PATCH 24/54] md/raid1: Improve another size determination in setup_conf()

Dan Carpenter writes: > Compare: > > foo = kmalloc(sizeof(*foo), GFP_KERNEL); > > This says you are allocating enough space for foo. It can be reviewed > by looking at one line. If you change the type of foo it will still > work. > > foo = kmalloc(sizeof(struct whatever),

Re: md/raid1: Improve another size determination in setup_conf()

SF Markus Elfring writes: >>> How do you value compliance with coding styles? >> >> The Linux Coding Style is not a law, > > How serious can such guidelines become for software developers? > >> nor is it at all perfect. > > I got a similar impression. But are there

Re: md/raid1: Improve another size determination in setup_conf()

SF Markus Elfring writes: >>> How do you value compliance with coding styles? >> >> The Linux Coding Style is not a law, > > How serious can such guidelines become for software developers? > >> nor is it at all perfect. > > I got a similar impression. But are there enough items where a mostly

Re: md/raid1: Improve another size determination in setup_conf()

SF Markus Elfring writes: but patches that just fix coding style are a bad thing >>> >>> When you find such a change opportunity so "bad", are there any >>> circumstances left over where you would dare to touch the corresponding >>> source code line. >> >>

Re: md/raid1: Improve another size determination in setup_conf()

SF Markus Elfring writes: but patches that just fix coding style are a bad thing >>> >>> When you find such a change opportunity so "bad", are there any >>> circumstances left over where you would dare to touch the corresponding >>> source code line. >> >> If you actually rewrite the code

Re: [PATCH 24/54] md/raid1: Improve another size determination in setup_conf()

Dan Carpenter writes: > On Thu, Oct 06, 2016 at 11:29:20AM +0200, Richard Weinberger wrote: >> On Thu, Oct 6, 2016 at 11:22 AM, SF Markus Elfring >> wrote: >> > From: Markus Elfring >> > Date: Tue, 4 Oct

Re: [PATCH 24/54] md/raid1: Improve another size determination in setup_conf()

Dan Carpenter writes: > On Thu, Oct 06, 2016 at 11:29:20AM +0200, Richard Weinberger wrote: >> On Thu, Oct 6, 2016 at 11:22 AM, SF Markus Elfring >> wrote: >> > From: Markus Elfring >> > Date: Tue, 4 Oct 2016 21:46:18 +0200 >> > >> > Replace the specification of a data structure by a pointer

Re: md/raid1: Improve another size determination in setup_conf()

SF Markus Elfring writes: Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. >>> >>> Isn't this pure matter of taste? >>> Some

Re: md/raid1: Improve another size determination in setup_conf()

SF Markus Elfring writes: Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. >>> >>> Isn't this pure matter of taste? >>> Some developers prefer sizeof(*ptr)

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches <j...@perches.com> writes: > On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote: >> Your output shows it moving to the text segment - if it's in a different >> segment, eg. rodata, you should use output demonstrating that to justify >> the change. >

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches writes: > On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote: >> Your output shows it moving to the text segment - if it's in a different >> segment, eg. rodata, you should use output demonstrating that to justify >> the change. > > For size, rodata _is

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches <j...@perches.com> writes: > On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote: >> Joe Perches <j...@perches.com> writes: >> > Make the init arrays const to reduce data. >> > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* &

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches writes: > On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote: >> Joe Perches writes: >> > Make the init arrays const to reduce data. >> > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* >> > (allyesconfig: x86-32) >> >   tex

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches writes: > Make the init arrays const to reduce data. > > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: > x86-32) >text data bss dec hex filename > 80107 13651 58 93816 16e78 >

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

Joe Perches writes: > Make the init arrays const to reduce data. > > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: > x86-32) >text data bss dec hex filename > 80107 13651 58 93816 16e78 >

Re: [PATCH 08/16] md/bitmap: Rename a jump label in location_store()

SF Markus Elfring writes: > From: Markus Elfring > Date: Tue, 27 Sep 2016 15:46:22 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring

Re: [PATCH 08/16] md/bitmap: Rename a jump label in location_store()

SF Markus Elfring writes: > From: Markus Elfring > Date: Tue, 27 Sep 2016 15:46:22 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/md/bitmap.c | 18 +- > 1 file changed, 9 insertions(+), 9

Re: [PATCH 01/16] md/bitmap: Use kmalloc_array() in bitmap_storage_alloc()

SF Markus Elfring writes: > From: Markus Elfring > Date: Tue, 27 Sep 2016 13:01:07 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus

Re: [PATCH 01/16] md/bitmap: Use kmalloc_array() in bitmap_storage_alloc()

SF Markus Elfring writes: > From: Markus Elfring > Date: Tue, 27 Sep 2016 13:01:07 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

Joe Perches writes: > On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: >> On 09/24/2016 12:32 PM, Joe Perches wrote: > [] >> o Reindent all the switch/case blocks to a more normal >> kernel style (git diff -w would show no changes here) >> That sounds like busy work to

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

Joe Perches writes: > On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: >> On 09/24/2016 12:32 PM, Joe Perches wrote: > [] >> o Reindent all the switch/case blocks to a more normal >> kernel style (git diff -w would show no changes here) >> That sounds like busy work to me, but if you want

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

Larry Finger writes: > On 09/24/2016 12:32 PM, Joe Perches wrote: >> Is there any value in that or is Jes' work going to make >> doing any or all of this unnecessary and futile? > > That is not yet determined. The only driver that is to be replaced at > this point is

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

Larry Finger writes: > On 09/24/2016 12:32 PM, Joe Perches wrote: >> Is there any value in that or is Jes' work going to make >> doing any or all of this unnecessary and futile? > > That is not yet determined. The only driver that is to be replaced at > this point is rtl8192cu. Jes only has USB

Re: [PATCH] staging: squash lines for simple wrapper functions

Masahiro Yamada writes: > Remove unneeded variables and assignments. > > While we are here, clean up the following as well: > - refactor rtl8723a_get_bcn_valid() a bit > - remove unneeded casts in sii164Get{Vendor,Device}ID() > > Signed-off-by: Masahiro Yamada

Re: [PATCH] staging: squash lines for simple wrapper functions

Masahiro Yamada writes: > Remove unneeded variables and assignments. > > While we are here, clean up the following as well: > - refactor rtl8723a_get_bcn_valid() a bit > - remove unneeded casts in sii164Get{Vendor,Device}ID() > > Signed-off-by: Masahiro Yamada > --- > >

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Remove ternary operator

On 09/12/16 09:58, Bhumika Goyal wrote: > Relational and logical operators evaluate to either true or false. > Explicit conversion is not needed so remove the ternary operator. > Done using coccinelle: > > @r@ > expression A,B; > symbol true,false; > binary operator b = {==,!=,&&,||,>=,<=,>,<}; >

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Remove ternary operator

On 09/12/16 09:58, Bhumika Goyal wrote: > Relational and logical operators evaluate to either true or false. > Explicit conversion is not needed so remove the ternary operator. > Done using coccinelle: > > @r@ > expression A,B; > symbol true,false; > binary operator b = {==,!=,&&,||,>=,<=,>,<}; >

Re: rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

Kalle Valo writes: > Colin Ian King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistakes in dev_dbg message. >> >> Signed-off-by: Colin Ian King >> Reviewed-by: Julian Calaby

Re: rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

Kalle Valo writes: > Colin Ian King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistakes in dev_dbg message. >> >> Signed-off-by: Colin Ian King >> Reviewed-by: Julian Calaby > > I assume Jes will take this. It's on my list, sorry been swamped in LPC stuff and other work

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

Joe Perches <j...@perches.com> writes: > On Tue, 2016-09-06 at 12:00 -0400, Jes Sorensen wrote: > >> Nothing wrong with these patches, however I intend to post a patch to >> remove this driver soon, so it's kind of a waste of your time to spend >> too many cycles

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

Joe Perches writes: > On Tue, 2016-09-06 at 12:00 -0400, Jes Sorensen wrote: > >> Nothing wrong with these patches, however I intend to post a patch to >> remove this driver soon, so it's kind of a waste of your time to spend >> too many cycles on it. > > It might

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

Matthias Beyer writes: > This patchset fixes some errors and warnings reported by checkpatch.pl. > > Matthias Beyer (5): > drivers: staging: rtl8723au: core: Fix checkpatch.pl errors > drivers: staging: rtl8723au: core: simplify if-break-else > drivers: staging:

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

Matthias Beyer writes: > This patchset fixes some errors and warnings reported by checkpatch.pl. > > Matthias Beyer (5): > drivers: staging: rtl8723au: core: Fix checkpatch.pl errors > drivers: staging: rtl8723au: core: simplify if-break-else > drivers: staging: rtl8723au: core: Refactor

Re: fix:rtl8xxxu_core: mark symbols static where possible

Kalle Valo writes: > Baoyou Xie wrote: >> We get 1 warning about global functions without a declaration >> in the rtl8xxxu rtl8xxxu_core.c when building with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: >> warning: no previous

Re: fix:rtl8xxxu_core: mark symbols static where possible

Kalle Valo writes: > Baoyou Xie wrote: >> We get 1 warning about global functions without a declaration >> in the rtl8xxxu rtl8xxxu_core.c when building with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: >> warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' >>

Re: [PATCH] Staging: rtl8723au: os_intfs: fixed case statement is variable issue

sunbing <sunb...@redflag-linux.com> writes: > On Aug 11, 2016, at 23:25, Jes Sorensen <jes.soren...@redhat.com> wrote: > >> Bing Sun <sunb...@redflag-linux.com> writes: >>> Fixed sparse parse error: >>> Expected constant expression in case s

Re: [PATCH] Staging: rtl8723au: os_intfs: fixed case statement is variable issue

sunbing writes: > On Aug 11, 2016, at 23:25, Jes Sorensen wrote: > >> Bing Sun writes: >>> Fixed sparse parse error: >>> Expected constant expression in case statement. >>> >>> Signed-off-by: Bing Sun >>> --- >>> drivers/stagi

Re: [PATCH] Staging: rtl8723au: os_intfs: fixed case statement is variable issue

Bing Sun writes: > Fixed sparse parse error: > Expected constant expression in case statement. > > Signed-off-by: Bing Sun > --- > drivers/staging/rtl8723au/os_dep/os_intfs.c | 11 +-- > 1 file changed, 5 insertions(+), 6

Re: [PATCH] Staging: rtl8723au: os_intfs: fixed case statement is variable issue

Bing Sun writes: > Fixed sparse parse error: > Expected constant expression in case statement. > > Signed-off-by: Bing Sun > --- > drivers/staging/rtl8723au/os_dep/os_intfs.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git

Re: [PATCH] Staging: rtl8723au: rtw_xmit: fixed coding style issues

Shiva Kerdel writes: > Fixed some coding style issues that were detected as errors. > > Signed-off-by: Shiva Kerdel You have already been told this once by Greg. Describe what you are fixing in the commit message, and don't fix more than one type of bug per

Re: [PATCH] Staging: rtl8723au: rtw_xmit: fixed coding style issues

Shiva Kerdel writes: > Fixed some coding style issues that were detected as errors. > > Signed-off-by: Shiva Kerdel You have already been told this once by Greg. Describe what you are fixing in the commit message, and don't fix more than one type of bug per commit. Jes > --- >

Re: [PATCH 0955/1285] Replace numeric parameter like 0444 with macro

Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using

Re: [PATCH 0955/1285] Replace numeric parameter like 0444 with macro

Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Stefan Lippers-Hollmann <s@gmx.de> writes: > Hi > > On 2016-07-20, Arnd Bergmann wrote: >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: >> > Arnd Bergmann <a...@arndb.de> writes: >> > > On Wednesday, July 20, 2016 7:

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Stefan Lippers-Hollmann writes: > Hi > > On 2016-07-20, Arnd Bergmann wrote: >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: >> > Arnd Bergmann writes: >> > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> >

Re: [PATCH 3/3] staging/rtl8192e: avoid comparing unsigned type >= 0

hanged, 5 insertions(+), 3 deletions(-) Looks good to me! Acked-by: Jes Sorensen <jes.soren...@redhat.com> > diff --git a/drivers/staging/rtl8192e/rtl819x_Qos.h > b/drivers/staging/rtl8192e/rtl819x_Qos.h > index 463122db6d29..61da8f7475bb 100644 > --- a/drivers/staging/rtl8192e/rtl

Re: [PATCH 3/3] staging/rtl8192e: avoid comparing unsigned type >= 0

unction to clarify the types and simplify > the check while removing the warning. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/rtl8192e/rtl819x_Qos.h| 3 --- > drivers/staging/rtl8192e/rtl819x_TSProc.c | 5 + > 2 files changed, 5 insertions(+), 3 deletions(-) Lo

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann <a...@arndb.de> writes: > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> Arnd Bergmann <a...@arndb.de> writes: >> Well it really all depends on how much time I have and how much others >> step up and help contribute t

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> Well it really all depends on how much time I have and how much others >> step up and help contribute to the code. For rtl8xxxu my plans are as >> f

Re: [PATCH] staging: rtl8723au: hal: check BT_Active and BT_State with correct bit pattern

Colin King writes: > From: Colin Ian King > > BT_Active and BT_State are being masked with 0x00ff so it the subsequent > comparisons with 0x are therefore a buggy check. Instead, check them > against 0x00ff. > > Unfortunately I

Re: [PATCH] staging: rtl8723au: hal: check BT_Active and BT_State with correct bit pattern

Colin King writes: > From: Colin Ian King > > BT_Active and BT_State are being masked with 0x00ff so it the subsequent > comparisons with 0x are therefore a buggy check. Instead, check them > against 0x00ff. > > Unfortunately I couldn't find a datasheet or hardware to see if

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann <a...@arndb.de> writes: > On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: >> Arnd Bergmann <a...@arndb.de> writes: >> I think that would be better, albeit not a big issue. > > Ok, and since Kalle applied the first patch to his tree, I'

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> I think that would be better, albeit not a big issue. > > Ok, and since Kalle applied the first patch to his tree, I'm now sending > a series of three patch

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann <a...@arndb.de> writes: > On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: >> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > index 2c8a526773ed..e0a2fe5e6148 100644

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: >> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > index 2c8a526773ed..e0a2fe5e6148 100644 >> > --- a/dr

Re: [PATCH 3/3] staging/rtl8192u: use s8 instead of char

++--- > 3 files changed, 11 insertions(+), 11 deletions(-) Looks good to me Acked-by: Jes Sorensen <jes.soren...@redhat.com>

Re: [PATCH 3/3] staging/rtl8192u: use s8 instead of char

rtions(+), 11 deletions(-) Looks good to me Acked-by: Jes Sorensen

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always > false due to limited range of

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always > false due to limited range of data type

Re: [PATCH] rtlwifi: use s8 instead of char

David Laight <david.lai...@aculab.com> writes: > From: Arnd Bergmann >> On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote: >> > >> > Arnd, >> > >> > rtlwifi and rtl8xxxu are two distinct drivers managed by different >> > p

Re: [PATCH] rtlwifi: use s8 instead of char

David Laight writes: > From: Arnd Bergmann >> On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote: >> > >> > Arnd, >> > >> > rtlwifi and rtl8xxxu are two distinct drivers managed by different >> > people. I'd be really nic

Re: [PATCH] rtlwifi: use s8 instead of char

Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited > range of data type

Re: [PATCH] rtlwifi: use s8 instead of char

Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited > range of data type [-Werror=type-limits] >

Re: [PATCH 0/2] *** r8723au: Replace semaphore lock with mutex ***

Binoy Jayan writes: > Hi, > > These are a set of patches which removes semaphores from: > > drivers/staging/rtl8723au > > These are part of a bigger effort to eliminate all semaphores > from the linux kernel. > > They build correctly (individually and as a whole). > NB: I

Re: [PATCH 0/2] *** r8723au: Replace semaphore lock with mutex ***

Binoy Jayan writes: > Hi, > > These are a set of patches which removes semaphores from: > > drivers/staging/rtl8723au > > These are part of a bigger effort to eliminate all semaphores > from the linux kernel. > > They build correctly (individually and as a whole). > NB: I have not tested this as

Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

Jes Sorensen <jes.soren...@redhat.com> writes: > Colin King <colin.k...@canonical.com> writes: >> From: Colin Ian King <colin.k...@canonical.com> >> >> path_b_ok is being assigned but immediately after path_a_ok is being >> compared to the value 0x03.

Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

Jes Sorensen writes: > Colin King writes: >> From: Colin Ian King >> >> path_b_ok is being assigned but immediately after path_a_ok is being >> compared to the value 0x03. This appears to be a typo on the >> variable name, compare path_b_ok instead. &g

Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

Colin King writes: > From: Colin Ian King > > path_b_ok is being assigned but immediately after path_a_ok is being > compared to the value 0x03. This appears to be a typo on the > variable name, compare path_b_ok instead. > > Signed-off-by:

Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

Colin King writes: > From: Colin Ian King > > path_b_ok is being assigned but immediately after path_a_ok is being > compared to the value 0x03. This appears to be a typo on the > variable name, compare path_b_ok instead. > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

Greg KH <gre...@linuxfoundation.org> writes: > On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote: >> > Ok, but still no need to put it under arch/ anything, it should go in >> > drivers/ like all other drivers and busses are, no matter what the

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

Greg KH writes: > On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote: >> > Ok, but still no need to put it under arch/ anything, it should go in >> > drivers/ like all other drivers and busses are, no matter what the arch >> > it happens to run on is. >

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

Greg KH <gre...@linuxfoundation.org> writes: > On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote: >> Greg KH <gre...@linuxfoundation.org> writes: >> > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >> >> This patchset moves the

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

Greg KH writes: > On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote: >> Greg KH writes: >> > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >> >> This patchset moves the visorbus driver >> >> (fromdrivers/staging/unisys/visor

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

Greg KH writes: > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >> This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus) >> and its dependent headers files (from drivers/staging/unisys/include) >> out of staging into the main

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

Greg KH writes: > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >> This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus) >> and its dependent headers files (from drivers/staging/unisys/include) >> out of staging into the main kernel tree. >> >> The

Re: [PATCH v2] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

Jandy Gou writes: > make C=1 M=drivers/staging/rtl8723au/ > > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to > restricted __le16 > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to > restricted __le32 > > Signed-off-by:

Re: [PATCH v2] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

Jandy Gou writes: > make C=1 M=drivers/staging/rtl8723au/ > > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to > restricted __le16 > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to > restricted __le32 > > Signed-off-by: Jandy Gou > --- >

Re: [PATCH] rtl8xxxu: hide unused tables

Kalle Valo <kv...@codeaurora.org> writes: > Jes Sorensen <jes.soren...@redhat.com> writes: > >> Arnd Bergmann <a...@arndb.de> writes: >>> The references to some arrays in the rtl8xxxu driver were moved inside >>> of an #ifdef, but the sym

Re: [PATCH] rtl8xxxu: hide unused tables

Kalle Valo writes: > Jes Sorensen writes: > >> Arnd Bergmann writes: >>> The references to some arrays in the rtl8xxxu driver were moved inside >>> of an #ifdef, but the symbols remain outside, resulting in build warnings: >>>

Re: [PATCH] rtl8xxxu: hide unused tables

Arnd Bergmann writes: > The references to some arrays in the rtl8xxxu driver were moved inside > of an #ifdef, but the symbols remain outside, resulting in build warnings: > > rtl8xxxu/rtl8xxxu.c:1506:33: error: 'rtl8188ru_radioa_1t_highpa_table' > defined but not used >

Re: [PATCH] rtl8xxxu: hide unused tables

Arnd Bergmann writes: > The references to some arrays in the rtl8xxxu driver were moved inside > of an #ifdef, but the symbols remain outside, resulting in build warnings: > > rtl8xxxu/rtl8xxxu.c:1506:33: error: 'rtl8188ru_radioa_1t_highpa_table' > defined but not used >

Re: [PATCH] rtl8xxxu: fix uninitialized return value in ret

Colin King writes: > From: Colin Ian King > > several functions are not initializing a return status in ret > resulting in garbage to be returned instead of 0 for success. > Currently, the calls to these functions are not checking the > return,

Re: [PATCH] rtl8xxxu: fix uninitialized return value in ret

Colin King writes: > From: Colin Ian King > > several functions are not initializing a return status in ret > resulting in garbage to be returned instead of 0 for success. > Currently, the calls to these functions are not checking the > return, however, it seems prudent to return the correct

Re: [PATCH] Staging: rtl8723au: Remove unused functions

il.com> > --- > drivers/staging/rtl8723au/core/rtw_wlan_util.c | 10 -- > drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 2 -- > 2 files changed, 12 deletions(-) Acked-by: Jes Sorensen <jes.soren...@redhat.com>

Re: [PATCH] Staging: rtl8723au: Remove unused functions

tw_wlan_util.c | 10 -- > drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 2 -- > 2 files changed, 12 deletions(-) Acked-by: Jes Sorensen

<    1   2   3   4   5   6   7   8   >