application and
checked the kernel source for details).
Signed-off-by: Jesper Juhl
---
net/ipv4/tcp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 4475b3b..9f3a2db 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2229,7 +2229,7
application and
checked the kernel source for details).
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
net/ipv4/tcp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 4475b3b..9f3a2db 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
Fix a few trivial mem leaks when returning from scan_tree/scan_rom.
Signed-off-by: Jesper Juhl
---
Documentation/ia64/aliasing-test.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Documentation/ia64/aliasing-test.c
b/Documentation/ia64/aliasing-test.c
index 62a190d
If 'down_read_trylock' fails we'll curently leak the memory allocated to
'buffer'.
Fix the leak by simply kfree'ing 'buffer' before returning '-EDEADLK'.
Signed-off-by: Jesper Juhl
---
.../lustre/lustre/libcfs/linux/linux-curproc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions
Make sure we always free(param); and remove a redundant "goto out;"
just before we'll hit the label anyway.
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6655/hostap.c | 25 ++---
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/stag
If we successfully allocate 'fw_event' but subsequently fail to
allocate 'fw_event->event_data' then we'll return from the function
without properly freeing 'fw_event'.
This patch takes care of that leak.
Signed-off-by: Jesper Juhl
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c |4 +++-
1 fi
Not really a problem, but nice IMHO; the Coverity static analyzer
complains that we use the pointer 'e' after it has been freed, so move
the freeing below the final use, even if that use is just using the
value of the pointer and not actually dereferencing it.
Signed-off-by: Jesper Juhl
Not really a problem, but nice IMHO; the Coverity static analyzer
complains that we use the pointer 'e' after it has been freed, so move
the freeing below the final use, even if that use is just using the
value of the pointer and not actually dereferencing it.
Signed-off-by: Jesper Juhl j
If we successfully allocate 'fw_event' but subsequently fail to
allocate 'fw_event-event_data' then we'll return from the function
without properly freeing 'fw_event'.
This patch takes care of that leak.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c
Make sure we always free(param); and remove a redundant goto out;
just before we'll hit the label anyway.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6655/hostap.c | 25 ++---
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers
If 'down_read_trylock' fails we'll curently leak the memory allocated to
'buffer'.
Fix the leak by simply kfree'ing 'buffer' before returning '-EDEADLK'.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
.../lustre/lustre/libcfs/linux/linux-curproc.c |4 +++-
1 files changed, 3
Fix a few trivial mem leaks when returning from scan_tree/scan_rom.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
Documentation/ia64/aliasing-test.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Documentation/ia64/aliasing-test.c
b/Documentation/ia64/aliasing
oblems you find. That would be
more likely to get peoples attention - and would also potentially result
in some nice fixes being merged.
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsub
peoples attention - and would also potentially result
in some nice fixes being merged.
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line
Coverity complains about a use after free for 'res1' and 'res2' since
we use the value of the pointers in a 'dev_dbg()' after they have been
freed. That's not really a problem, but it still seems cleaner to
defer freeing until we are completely done with the pointers.
Signed-off-by: Jesper Juhl
Coverity complains about a use after free for 'res1' and 'res2' since
we use the value of the pointers in a 'dev_dbg()' after they have been
freed. That's not really a problem, but it still seems cleaner to
defer freeing until we are completely done with the pointers.
Signed-off-by: Jesper Juhl j
, but nice IMHO.
Signed-off-by: Jesper Juhl
---
drivers/infiniband/hw/cxgb3/iwch_provider.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c
b/drivers/infiniband/hw/cxgb3/iwch_provider.c
index 0bdf09a..145d82a 100644
, but nice IMHO.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/infiniband/hw/cxgb3/iwch_provider.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c
b/drivers/infiniband/hw/cxgb3/iwch_provider.c
index 0bdf09a..145d82a
we actually mean.
Signed-off-by: Jesper Juhl
---
kernel/relay.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/relay.c b/kernel/relay.c
index e8cd202..806931b 100644
--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -166,13 +166,13 @@ static struct rchan_
actually mean.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
kernel/relay.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/relay.c b/kernel/relay.c
index e8cd202..806931b 100644
--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -166,13 +166,13 @@ static struct rchan_buf
The file uses nothing from the header, so remove it.
Signed-off-by: Jesper Juhl
---
drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c
b/drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c
The file uses nothing from the header, so remove it.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c
b/drivers/scsi/mpt3sas
regex='/PCI_OP_WRITE(\([a-z]*[a-z]\).*[1-4])/pci_bus_write_config_\1/'
>
> all_kconfigs | xargs $1 -a \
> --regex='/^[ \t]*\(\(menu\)*config\)[ \t]+\([a-zA-Z0-9_]+\)/\3/'
>
This works for me. Thanks.
Tested-by: Jesper Juhl
--
Jes
Unmatched ( or \( while compiling pattern
>
> oh well, looks like noone is using it / noone cares enough...
>
I use it. I haven't bothered (yet) to look into the cause of the message
it spews since the etags ('TAGS') file it produces still seems to work
well enough.
--
Jesper Juh
well enough.
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
.
Tested-by: Jesper Juhl j...@chaosbits.net
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
sible kernel config combinations - that may or may not
boot on any given system. The point was only to test that some
combination of options did in fact build (if it also boots then all the
better, but that was never part of the goal; as I saw it).
I may be wrong, but that was/is my expectations for 'randconfig'.
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
'if ((!help) && (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember
to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping
to the 'err_out' label rather than the 'out' label in
ctnetlink_create_expect().
This patch should get rid of the leak.
Signed-off-by: Jesper Juhl
We fail to release 'urb' if '_rtl_prep_rx_urb()' fails in
_rtl_usb_receive().
This patch should take care of the leak.
Signed-off-by: Jesper Juhl
---
drivers/net/wireless/rtlwifi/usb.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
note: compile tested only.
diff --git a/drivers
If kzalloc() or csio_hw_check_fwconfig() fail we may leave the
csio_hw_flash_config() function without freeing allocated memory or
firmware. This should take care of the leaks.
Signed-off-by: Jesper Juhl
---
drivers/scsi/csiostor/csio_hw.c | 15 +--
1 files changed, 9 insertions
If kzalloc() or csio_hw_check_fwconfig() fail we may leave the
csio_hw_flash_config() function without freeing allocated memory or
firmware. This should take care of the leaks.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/scsi/csiostor/csio_hw.c | 15 +--
1 files
We fail to release 'urb' if '_rtl_prep_rx_urb()' fails in
_rtl_usb_receive().
This patch should take care of the leak.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/net/wireless/rtlwifi/usb.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
note: compile tested only
'if ((!help) (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember
to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping
to the 'err_out' label rather than the 'out' label in
ctnetlink_create_expect().
This patch should get rid of the leak.
Signed-off-by: Jesper Juhl j
; as I saw it).
I may be wrong, but that was/is my expectations for 'randconfig'.
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
On Thu, 20 Dec 2012, Sasha Levin wrote:
> We already know q!=NULL at that point, no need to retest.
>
Right, and even if it was ==NULL then 'free(NULL)' is guaranteed to be a
NOP, so it would still be fine.
Reviewed-by: Jesper Juhl
> Signed-off-by: Sasha Levin
> ---
>
On Thu, 20 Dec 2012, Sasha Levin wrote:
We already know q!=NULL at that point, no need to retest.
Right, and even if it was ==NULL then 'free(NULL)' is guaranteed to be a
NOP, so it would still be fine.
Reviewed-by: Jesper Juhl j...@chaosbits.net
Signed-off-by: Sasha Levin sasha.le
;;
> evt->rating = 350;
> evt->irq = -1;
>
Looks good to me.
Feel free to add
Reviewed-by: Jesper Juhl
if you like.
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsu
to be just 'error0' and
'error1'.
Signed-off-by: Jesper Juhl
---
drivers/mmc/host/vub300.c | 29 +++--
1 files changed, 11 insertions(+), 18 deletions(-)
This is a resend. I originally submitted this back in January:
http://lkml.indiana.edu/hypermail/linux/kernel
The file uses nothing from the header, so including it is pointless.
Signed-off-by: Jesper Juhl
---
drivers/power/bq2415x_charger.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c
index ee842b3..2d1b568
The file uses nothing from the version.h header, so there is no reason
to include it.
Signed-off-by: Jesper Juhl
---
drivers/net/ethernet/marvell/mvneta.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net/ethernet
te. While input core
>* will do this for us at resume time reconnect may happen
> @@ -1224,6 +1243,9 @@ static int atkbd_reconnect(struct serio *serio)
> }
>
> atkbd_enable(atkbd);
> + if (atkbd->write)
> + atkbd_activate(atkbd
* will do this for us at resume time reconnect may happen
@@ -1224,6 +1243,9 @@ static int atkbd_reconnect(struct serio *serio)
}
atkbd_enable(atkbd);
+ if (atkbd-write)
+ atkbd_activate(atkbd);
+
retval = 0;
out:
--
Jesper Juhl j
The file uses nothing from the version.h header, so there is no reason
to include it.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/net/ethernet/marvell/mvneta.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers
The file uses nothing from the header, so including it is pointless.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/power/bq2415x_charger.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c
index
to be just 'error0' and
'error1'.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/mmc/host/vub300.c | 29 +++--
1 files changed, 11 insertions(+), 18 deletions(-)
This is a resend. I originally submitted this back in January:
http://lkml.indiana.edu
-by: Jesper Juhl j...@chaosbits.net
if you like.
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
nt_io_accounting;
> int print_task_context_switch_counts;
> -__u64 stime, utime;
>
> #define PRINTF(fmt, arg...) {\
> if (dbg) { \
>
Seems fine to me...
--
Jesper Juhlhttp://www.chaosbits.net/
D
print_task_context_switch_counts;
-__u64 stime, utime;
#define PRINTF(fmt, arg...) {\
if (dbg) { \
Seems fine to me...
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain
Since rc_unregister_device() frees its argument there's no need to
subsequently call rc_free_device() on the same variable - in fact it's
a double free bug.
Easily fixed by just removing the rc_free_device() call.
Signed-off-by: Jesper Juhl
---
drivers/media/rc/gpio-ir-recv.c |1 -
1 files
rc_unregister_device(). That fixes the
problem since rc_free_device() just does nothing if passed NULL and
there's no further use of 'rcdev' after the call to rc_free_device()
so it's not needed there.
Signed-off-by: Jesper Juhl
---
drivers/media/rc/gpio-ir-recv.c |2 +-
1 files changed, 1
On Thu, 25 Oct 2012, Rafael J. Wysocki wrote:
> On Sunday 21 of October 2012 22:35:46 Jesper Juhl wrote:
> > If acpi_ds_create_walk_state() succeeds, but the call to
> > ACPI_ALLOCATE_ZEROED() fails, then we'll return from the function
> > without properly fre
On Thu, 25 Oct 2012, Rafael J. Wysocki wrote:
On Sunday 21 of October 2012 22:35:46 Jesper Juhl wrote:
If acpi_ds_create_walk_state() succeeds, but the call to
ACPI_ALLOCATE_ZEROED() fails, then we'll return from the function
without properly freeing 'next_walk_state'.
Signed-off
rc_unregister_device(). That fixes the
problem since rc_free_device() just does nothing if passed NULL and
there's no further use of 'rcdev' after the call to rc_free_device()
so it's not needed there.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/media/rc/gpio-ir-recv.c |2 +-
1 files
Since rc_unregister_device() frees its argument there's no need to
subsequently call rc_free_device() on the same variable - in fact it's
a double free bug.
Easily fixed by just removing the rc_free_device() call.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/media/rc/gpio-ir-recv.c
On Mon, 22 Oct 2012, Greg Kroah-Hartman wrote:
> On Thu, Oct 18, 2012 at 09:51:56PM +0200, Jesper Juhl wrote:
> >
> > Signed-off-by: Jesper Juhl
>
> Someone already beat you to this patch, sorry.
>
Heh. That happens - no problem - as long as it gets fixed :)
--
On Mon, 22 Oct 2012, Greg Kroah-Hartman wrote:
On Thu, Oct 18, 2012 at 09:51:56PM +0200, Jesper Juhl wrote:
Signed-off-by: Jesper Juhl j...@chaosbits.net
Someone already beat you to this patch, sorry.
Heh. That happens - no problem - as long as it gets fixed :)
--
Jesper Juhl j
If acpi_ds_create_walk_state() succeeds, but the call to
ACPI_ALLOCATE_ZEROED() fails, then we'll return from the function
without properly freeing 'next_walk_state'.
Signed-off-by: Jesper Juhl
---
drivers/acpi/acpica/dsmethod.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff
If acpi_ds_create_walk_state() succeeds, but the call to
ACPI_ALLOCATE_ZEROED() fails, then we'll return from the function
without properly freeing 'next_walk_state'.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/acpi/acpica/dsmethod.c |3 ++-
1 files changed, 2 insertions(+), 1
map all mapped buffers when
> + mapping error is detected in the middle)
> +
"... if buffers are allocated in a loop..."
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from
Signed-off-by: Jesper Juhl
---
drivers/staging/csr/csr_framework_ext.c|1 -
drivers/staging/csr/csr_time.c |1 -
drivers/staging/csr/io.c |1 -
drivers/staging/csr/monitor.c |1 -
drivers/staging/csr/netdev.c |1
drivers/staging/silicom/bypasslib/bplibk.h actually uses stuff from
version.h so it should include the header.
drivers/staging/silicom/bp_proc.c and
drivers/staging/silicom/bypasslib/bypass.c currently include the
header but use nothing from it so they don't need to.
Signed-off-by: Jesper Juhl
The file uses nothing from linux/version.h, so the include is
pointless - remove it.
Signed-off-by: Jesper Juhl
---
drivers/staging/dgrp/dgrp_sysfs.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgrp/dgrp_sysfs.c
b/drivers/staging/dgrp/dgrp_sysfs.c
The header is not needed, so remove it.
Signed-off-by: Jesper Juhl
---
drivers/media/platform/s5p-tv/mixer_video.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/platform/s5p-tv/mixer_video.c
b/drivers/media/platform/s5p-tv/mixer_video.c
index 0c1cd89
The header is not needed, so remove it.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/media/platform/s5p-tv/mixer_video.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/platform/s5p-tv/mixer_video.c
b/drivers/media/platform/s5p-tv
The file uses nothing from linux/version.h, so the include is
pointless - remove it.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/dgrp/dgrp_sysfs.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgrp/dgrp_sysfs.c
b/drivers/staging
drivers/staging/silicom/bypasslib/bplibk.h actually uses stuff from
version.h so it should include the header.
drivers/staging/silicom/bp_proc.c and
drivers/staging/silicom/bypasslib/bypass.c currently include the
header but use nothing from it so they don't need to.
Signed-off-by: Jesper Juhl j
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/csr/csr_framework_ext.c|1 -
drivers/staging/csr/csr_time.c |1 -
drivers/staging/csr/io.c |1 -
drivers/staging/csr/monitor.c |1 -
drivers/staging/csr/netdev.c
+ mapping error is detected in the middle)
+
... if buffers are allocated in a loop...
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line
On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
> On Mon, Oct 15, 2012 at 9:03 PM, Jesper Juhl wrote:
> > On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
> >
> >> On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl wrote:
> >> > On Mon, 15 Oct 2012, Jesper Juhl wrote
On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
On Mon, Oct 15, 2012 at 9:03 PM, Jesper Juhl j...@chaosbits.net wrote:
On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl j...@chaosbits.net wrote:
On Mon, 15 Oct 2012, Jesper Juhl wrote:
On Sat, 13
On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
> On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl wrote:
> > On Mon, 15 Oct 2012, Jesper Juhl wrote:
> >
> >> On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
> >>
[...]
> > Currently there are two checks for 'rc' being l
On Mon, 15 Oct 2012, Jesper Juhl wrote:
> On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
>
> > On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl wrote:
> > > There are two checks for 'rc' being less than zero with no change to
> > > 'rc' between the two, so the sec
Ok, so I had a little problem with my mail servers clock that caused the
mail below to be timestamped a few years in the past, so I assume noone
saw it - thus, resending.
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text
On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
> On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl wrote:
> > There are two checks for 'rc' being less than zero with no change to
> > 'rc' between the two, so the second is just dead code - remove it.
> >
> >
On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl j...@chaosbits.net wrote:
There are two checks for 'rc' being less than zero with no change to
'rc' between the two, so the second is just dead code - remove it.
Signed-off-by: Jesper Juhl j
Ok, so I had a little problem with my mail servers clock that caused the
mail below to be timestamped a few years in the past, so I assume noone
saw it - thus, resending.
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top
On Mon, 15 Oct 2012, Jesper Juhl wrote:
On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl j...@chaosbits.net wrote:
There are two checks for 'rc' being less than zero with no change to
'rc' between the two, so the second is just dead code - remove
On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl j...@chaosbits.net wrote:
On Mon, 15 Oct 2012, Jesper Juhl wrote:
On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
[...]
Currently there are two checks for 'rc' being less than zero with no
change
There are two checks for 'rc' being less than zero with no change to
'rc' between the two, so the second is just dead code - remove it.
Signed-off-by: Jesper Juhl
---
drivers/media/usb/stk1160/stk1160-i2c.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/media
let 'physical_node' go out of scope
and leak the memory we allocated.
This patch fixes the leak by simply freeing the unused/unneeded memory
pointed to by 'physical_node' just before we jump to 'err:'.
Signed-off-by: Jesper Juhl
---
drivers/acpi/glue.c |1 +
1 files changed, 1 insertions(+)
'physical_node' go out of scope
and leak the memory we allocated.
This patch fixes the leak by simply freeing the unused/unneeded memory
pointed to by 'physical_node' just before we jump to 'err:'.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/acpi/glue.c |1 +
1 files changed, 1
There are two checks for 'rc' being less than zero with no change to
'rc' between the two, so the second is just dead code - remove it.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/media/usb/stk1160/stk1160-i2c.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff
; scripts/checkincludes.pl | 113
> ++
> 1 file changed, 65 insertions(+), 48 deletions(-)
>
>
Minor detail. Your patches are for "scripts/checkincludes.pl" but the
subject says "scripts/checkpatch.pl"... You may want to
(-)
Minor detail. Your patches are for scripts/checkincludes.pl but the
subject says scripts/checkpatch.pl... You may want to get it straight
what you are patching and let the subject reflect reality :-)
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org
Just a completely trivial patch to remove a completely redundant blank
line from usr/gen_init_cpio.c
Signed-off-by: Jesper Juhl
---
usr/gen_init_cpio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c
index af0f22f..b2e46bc 100644
--- a/usr
Just a completely trivial patch to remove a completely redundant blank
line from usr/gen_init_cpio.c
Signed-off-by: Jesper Juhl j...@codesealer.com
---
usr/gen_init_cpio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c
index af0f22f..b2e46bc 100644
On Sat, 18 Aug 2012, Tony Finch wrote:
> Jesper Juhl wrote:
>
> > In newer glibc's (versions > 2.06) reasonably secure permissions of
> > 0600 are used when creating a temporary file with mkstemp(). But for
> > older glibc's (versions <= 2.06) 0666 is used wh
On Sat, 18 Aug 2012, Tony Finch wrote:
Jesper Juhl j...@chaosbits.net wrote:
In newer glibc's (versions 2.06) reasonably secure permissions of
0600 are used when creating a temporary file with mkstemp(). But for
older glibc's (versions = 2.06) 0666 is used which is not secure.
Thanks
..
Signed-off-by: Jesper Juhl
---
net/caif/chnl_net.c | 4
1 file changed, 4 insertions(+)
Note: compile tested only.
diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c
index 69771c0..e597733 100644
--- a/net/caif/chnl_net.c
+++ b/net/caif/chnl_net.c
@@ -94,6 +94,10 @@ static int
s, add a call to umask() that ensures we always set
at most 0600 on the temporary file (and then restore the umask again
so we don't interfere with anything that hapens further on).
Signed-off-by: Jesper Juhl
---
scripts/unifdef.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
a call to umask() that ensures we always set
at most 0600 on the temporary file (and then restore the umask again
so we don't interfere with anything that hapens further on).
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
scripts/unifdef.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
..
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
net/caif/chnl_net.c | 4
1 file changed, 4 insertions(+)
Note: compile tested only.
diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c
index 69771c0..e597733 100644
--- a/net/caif/chnl_net.c
+++ b/net/caif/chnl_net.c
@@ -94,6 +94,10
.
Unfortunately we just get NULL back, so we can't really tell the user
exactely what went wrong, but we can at least avoid crashing and
return an error (-EIO seemed more generic and more suitable here than
-ENOMEM or something else, so I picked that).
Signed-off-by: Jesper Juhl
---
drivers/char
i.c. If you
> can resubmit on top of my staging tree, I will apply it there.
>
No problem. I'll have that patch for you in a moment when I'm done
fetching your tree.
> git://github.com/shpedoikal/linux.git v3.6-rc1-tpmdd-staging
>
> > > Signed-off-by: Jesper Juhl
>
have that patch for you in a moment when I'm done
fetching your tree.
git://github.com/shpedoikal/linux.git v3.6-rc1-tpmdd-staging
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/char/tpm/tpm_bios.c | 5 +
1 file changed, 5 insertions(+)
Compile tested only
.
Unfortunately we just get NULL back, so we can't really tell the user
exactely what went wrong, but we can at least avoid crashing and
return an error (-EIO seemed more generic and more suitable here than
-ENOMEM or something else, so I picked that).
Signed-off-by: Jesper Juhl j...@chaosbits.net
Include version.h where actually needed, remove where unneeded.
Signed-off-by: Jesper Juhl
---
drivers/staging/csr/csr_panic.c| 1 -
drivers/staging/csr/drv.c | 3 +--
drivers/staging/csr/io.c | 2 +-
drivers/staging/csr/monitor.c | 3
On Fri, 10 Aug 2012, Mark Brown wrote:
> On Fri, Aug 10, 2012 at 08:12:57PM +0200, Jesper Juhl wrote:
> > There is no need to include version.h in sound/soc/codecs/isabelle.c -
> > this patch removes the pointless include.
>
> Not sure what this patch is against, there app
There is no need to include version.h in sound/soc/codecs/isabelle.c -
this patch removes the pointless include.
Signed-off-by: Jesper Juhl
---
sound/soc/codecs/isabelle.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/isabelle.c b/sound/soc/codecs/isabelle.c
index 5d8f39e
of your troubles, you
could try bisecting between your last working kernel and 3.5.1 to try and
narrow it down to one (or a few) commits that are causing your trouble.
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails
1 - 100 of 2260 matches
Mail list logo
