On 03/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Fri, 3 Aug 2007 00:53:44 +0200
> Jesper Juhl <[EMAIL PROTECTED]> wrote:
>
> > On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote:
> > > On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote
On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote:
> On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
[snip]
> > y'know, we could have a debug option which will spit warnings if someone
> > does a !__GFP_WAIT allocation while !in_atomic() (only works
On 02/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> On 02/08/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > On Thu, Aug 02, 2007 at 09:57:07PM +0200, Jesper Juhl wrote:
> > > I get this build error with the current mainline git tree.
> > > Le
On 02/08/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Thu, Aug 02, 2007 at 09:57:07PM +0200, Jesper Juhl wrote:
> > I get this build error with the current mainline git tree.
> > Let me know if further details are needed...
> >...
>
> -ENODOTCONFIG
>
On 02/08/07, Al Viro <[EMAIL PROTECTED]> wrote:
> On Thu, Aug 02, 2007 at 10:03:03PM +0200, Jesper Juhl wrote:
> > I believe Guennadi's point is that gcc does not warn about it in the
> > case of c[4] = "0123"; but only in the case of c[4] = "01234" -
On 02/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> I get this build error with the current mainline git tree.
When I say "current mainline git tree" I mean that HEAD is at
370504cf7c68b953de55c41d5e0be97d30f3cf00
> Let me know if further details are needed...
>
>
nown,
> >really...
>
> What does this have to do with the kernel? The string "0123" is
> generally _five_ characters long, so c[4] is not enough.
> Or use strncpy.
>
I believe Guennadi's point is that gcc does not warn about it in the
case of c[4] = "0123"; but
: In function 'next_thread':
include/linux/sched.h:1650: error: implicit declaration of function
'rcu_dereference'
include/linux/sched.h:1650: warning: initialization makes pointer from
integer without a cast
make[1]: *** [init/noinitramfs.o] Error 1
make: *** [init] Error 2
--
Jesper Juhl <[EMAIL PROTEC
On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 2 Aug 2007 01:55:33 +0200
> Jesper Juhl <[EMAIL PROTECTED]> wrote:
>
[snip]
> > +++ b/drivers/message/fusion/mptbase.c
> > @@ -1393,18 +1393,18 @@ mpt_attach(struct pci_dev *pdev, const struct
> &
On 02/08/07, Andrew Morton [EMAIL PROTECTED] wrote:
On Thu, 2 Aug 2007 01:55:33 +0200
Jesper Juhl [EMAIL PROTECTED] wrote:
[snip]
+++ b/drivers/message/fusion/mptbase.c
@@ -1393,18 +1393,18 @@ mpt_attach(struct pci_dev *pdev, const struct
pci_device_id *id)
struct proc_dir_entry
: In function 'next_thread':
include/linux/sched.h:1650: error: implicit declaration of function
'rcu_dereference'
include/linux/sched.h:1650: warning: initialization makes pointer from
integer without a cast
make[1]: *** [init/noinitramfs.o] Error 1
make: *** [init] Error 2
--
Jesper Juhl [EMAIL PROTECTED
in the case of c[4] = 01234 - so if
we do have such initializations in the kernel we may have some bugs
hiding there that gcc doesn't warn us about.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http
On 02/08/07, Jesper Juhl [EMAIL PROTECTED] wrote:
I get this build error with the current mainline git tree.
When I say current mainline git tree I mean that HEAD is at
370504cf7c68b953de55c41d5e0be97d30f3cf00
Let me know if further details are needed...
...
In file included from include
On 02/08/07, Al Viro [EMAIL PROTECTED] wrote:
On Thu, Aug 02, 2007 at 10:03:03PM +0200, Jesper Juhl wrote:
I believe Guennadi's point is that gcc does not warn about it in the
case of c[4] = 0123; but only in the case of c[4] = 01234 - so if
we do have such initializations in the kernel we
On 02/08/07, Adrian Bunk [EMAIL PROTECTED] wrote:
On Thu, Aug 02, 2007 at 09:57:07PM +0200, Jesper Juhl wrote:
I get this build error with the current mainline git tree.
Let me know if further details are needed...
...
-ENODOTCONFIG
Attached.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top
On 02/08/07, Jesper Juhl [EMAIL PROTECTED] wrote:
On 02/08/07, Adrian Bunk [EMAIL PROTECTED] wrote:
On Thu, Aug 02, 2007 at 09:57:07PM +0200, Jesper Juhl wrote:
I get this build error with the current mainline git tree.
Let me know if further details are needed...
...
-ENODOTCONFIG
On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote:
On 02/08/07, Andrew Morton [EMAIL PROTECTED] wrote:
[snip]
y'know, we could have a debug option which will spit warnings if someone
does a !__GFP_WAIT allocation while !in_atomic() (only works if
CONFIG_PREEMPT).
But please, make
On 03/08/07, Andrew Morton [EMAIL PROTECTED] wrote:
On Fri, 3 Aug 2007 00:53:44 +0200
Jesper Juhl [EMAIL PROTECTED] wrote:
On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote:
On 02/08/07, Andrew Morton [EMAIL PROTECTED] wrote:
[snip]
y'know, we could have a debug option which
On 03/08/07, Andrew Morton [EMAIL PROTECTED] wrote:
On Fri, 3 Aug 2007 01:10:02 +0200
Jesper Juhl [EMAIL PROTECTED] wrote:
So, where do we go from here?
Where I said ;) Add a new __GFP_ flag which suppresses the warning, add
that flag to known-to-be-OK callsites
only.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/message/fusion/mptbase.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index e866dac..f9bb705 100644
--- a/drivers/mess
"ld -v" could differ as much as it turned out
it can, so my original fix turned out to not cover all bases.
This patch works correctly with all the different "ld -v" output
that people posted in replys to my first patch, so it should be a
clear win over what we have currently.
Pl
as it turned out
it can, so my original fix turned out to not cover all bases.
This patch works correctly with all the different ld -v output
that people posted in replys to my first patch, so it should be a
clear win over what we have currently.
Please apply.
Signed-off-by: Jesper Juhl [EMAIL
.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/message/fusion/mptbase.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index e866dac..f9bb705 100644
--- a/drivers/message/fusion
w to enable XEN support? Thanks.
Go to "Processor type and features" - then enable "Paravirtualization
support (EXPERIMENTAL)", you'll get a new option called "Enable
support for Xen hypervisor".
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb
to Processor type and features - then enable Paravirtualization
support (EXPERIMENTAL), you'll get a new option called Enable
support for Xen hypervisor.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http
On 22/07/07, Jiri Slaby <[EMAIL PROTECTED]> wrote:
> Jesper Juhl napsal(a):
> > drivers/hid/usbhid/hid-core.c |3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
On 22/07/07, Jiri Slaby [EMAIL PROTECTED] wrote:
Jesper Juhl napsal(a):
drivers/hid/usbhid/hid-core.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index b2baeae..3ff7468 100644
--- a/drivers
Hi,
This patch removes the duplicate inclusion of linux/personality.h
from arch/sh64/kernel/signal.c
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/arch/sh64/kernel/signal.c b/arch/sh64/kernel/signal.c
index 0bb4a8f..79fc48c 100644
--- a/arch/sh64/kernel/signal.c
+++
(sorry about the duplicate mail, forgot a recipient first time)
Hi,
This patch removes a few duplicate includes from arch/ia64/
Please consider merging :-)
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/ia64/ia32/sys_ia32.c |1 -
arch/ia64/kernel/setup.c|1 -
Hi,
Here's a patch to clean out a bunch of duplicate includes from
arch/powerpc/
Please consider for inclusion.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/btext.c|1 -
arch/powerpc/kernel/crash.c|1 -
arch/powerpc/
Hi,
This patch removes some duplicate includes from arch/mips/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/mips/kernel/signal32.c |1 -
arch/mips/lemote/lm2e/irq.c |1 -
arch/mips/mipssim/sim_setup.c |1 -
3 files changed, 0 insertions(+), 3 deletions(-)
Hi,
This patch removes the duplicate inclusion of asm/irq.h
from arch/m68knommu/platform/5206e/config.c
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/m68knommu/platform/5206e/config.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/m68knommu/pl
Hi,
arch/blackfin/mach-bf548/boards/ezkit.c includes linux/irq.h twice.
This patch removes the duplicate.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/blackfin/mach-bf548/boards/ezkit.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/blackfi
Hi,
This patch removes the duplicate inclusion of
linux/module.h from arm26.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/arm26/kernel/armksyms.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm26/kernel/armksyms.c b/arch/arm26/kernel/armk
Hi,
This patch removes the duplicate inclusion of
linux/module.h from arm26.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/arm26/kernel/armksyms.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm26/kernel/armksyms.c b/arch/arm26/kernel/armksyms.c
Hi,
arch/blackfin/mach-bf548/boards/ezkit.c includes linux/irq.h twice.
This patch removes the duplicate.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/blackfin/mach-bf548/boards/ezkit.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/blackfin/mach-bf548
Hi,
This patch removes the duplicate inclusion of asm/irq.h
from arch/m68knommu/platform/5206e/config.c
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/m68knommu/platform/5206e/config.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/m68knommu/platform
Hi,
This patch removes some duplicate includes from arch/mips/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/mips/kernel/signal32.c |1 -
arch/mips/lemote/lm2e/irq.c |1 -
arch/mips/mipssim/sim_setup.c |1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git
Hi,
Here's a patch to clean out a bunch of duplicate includes from
arch/powerpc/
Please consider for inclusion.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/powerpc/kernel/btext.c|1 -
arch/powerpc/kernel/crash.c|1 -
arch/powerpc/kernel
(sorry about the duplicate mail, forgot a recipient first time)
Hi,
This patch removes a few duplicate includes from arch/ia64/
Please consider merging :-)
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/ia64/ia32/sys_ia32.c |1 -
arch/ia64/kernel/setup.c|1 -
arch
Hi,
This patch removes the duplicate inclusion of linux/personality.h
from arch/sh64/kernel/signal.c
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/arch/sh64/kernel/signal.c b/arch/sh64/kernel/signal.c
index 0bb4a8f..79fc48c 100644
--- a/arch/sh64/kernel/signal.c
+++ b/arch
On 29/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> Hi,
>
> On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > Hello,
> >
> > This patch makes sure we don't dereference a NULL pointer in
> > drivers/net/usb/pegasus.c::write_bulk_callbac
W3V have a usable WLED */
At conditional (12): "asus_info != 0" taking true path
1239else if (asus_info) {
At conditional (13): "strncmp == 0" taking false path
1240if (strncmp(asus_info->oem_table_id, "L1", 2) == 0)
1241
til after that check.
Please consider merging.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/usb/pegasus.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index a05fd97..04cba6b 100644
---
after that check.
Please consider merging.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/net/usb/pegasus.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index a05fd97..04cba6b 100644
--- a/drivers/net
(model);
1246
1247return AE_OK;
1248}
...
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/acpi/asus_acpi.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
index 9c4bd22..86fd142 100644
On 29/07/07, Satyam Sharma [EMAIL PROTECTED] wrote:
Hi,
On 7/29/07, Jesper Juhl [EMAIL PROTECTED] wrote:
Hello,
This patch makes sure we don't dereference a NULL pointer in
drivers/net/usb/pegasus.c::write_bulk_callback() in the initial
struct net_device *net = pegasus-net; assignment
On 28/07/07, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-07-27 at 23:27 +0200, Jesper Juhl wrote:
> > In sas_smp_get_phy_events() we never test if the call to
> > alloc_smp_req(RPEL_REQ_SIZE) succeeds or fails. That means we run
> > the risk of d
odules and
think about whether or not you need it...
> Another question please, what the symbol "---" near a kernel
> configuration entry in menuconfig means? This entry is activated (with
> * or M) or not?
>
It means that the option was automagically selected by some other
opti
for the other memory allocation in that
function.
This patch reworks the memory allocation a bit to deal with it
(compile tested only).
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/libsas/sas_expander.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff
; How I can find what items in "menuconfig" I need to activate (marking
> it with "m") to compile the modules I need for the system startup?
>
You could start by telling people what modules you are talking about.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post
.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/libsas/sas_expander.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libsas/sas_expander.c
b/drivers/scsi/libsas/sas_expander.c
index b500f0c..7871406 100644
--- a/drivers/scsi/
) to compile the modules I need for the system startup?
You could start by telling people what modules you are talking about.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_expander.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libsas/sas_expander.c
b/drivers/scsi/libsas/sas_expander.c
index b500f0c..7871406 100644
--- a/drivers/scsi/libsas
for the other memory allocation in that
function.
This patch reworks the memory allocation a bit to deal with it
(compile tested only).
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_expander.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git
) or not?
It means that the option was automagically selected by some other
option you selected, so you can't disable it unless you first disable
that other option that selected it.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text
On 28/07/07, James Bottomley [EMAIL PROTECTED] wrote:
On Fri, 2007-07-27 at 23:27 +0200, Jesper Juhl wrote:
In sas_smp_get_phy_events() we never test if the call to
alloc_smp_req(RPEL_REQ_SIZE) succeeds or fails. That means we run
the risk of dereferencing a NULL pointer if it does fail
e sharedbuffers cached
Mem: 20708561724204 346652 0 144708 745328
-/+ buffers/cache: 8341681236688
Swap: 987988 0 987988
This is a Slackware Linux 12.0 system.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.
r
(scripts/checkpatch.pl) to catch trival style violations.
See Documentation/CodingStyle for guidance here.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.ht
3c7xx=" (driver already removed)
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
I read through your changes and they look good to me.
Acked-by: Jesper Juhl <[EMAIL PROTECTED]>
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T
makes by hand.
Feel free to fix it up/improve it.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-ke
statement.
The patch also changes the layout of the 'switch' to be more in line
with CodingStyle.
Patch has been compile tested.
Please consider merging.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
net/dccp/feat.c | 14 ++
1 files changed, 10 insertions(+), 4 del
0 987988
This is a Slackware Linux 12.0 system.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
) to catch trival style violations.
See Documentation/CodingStyle for guidance here.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send
-off-by: Randy Dunlap [EMAIL PROTECTED]
I read through your changes and they look good to me.
Acked-by: Jesper Juhl [EMAIL PROTECTED]
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com
.
Feel free to fix it up/improve it.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
statement.
The patch also changes the layout of the 'switch' to be more in line
with CodingStyle.
Patch has been compile tested.
Please consider merging.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
net/dccp/feat.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions
how swap prefetch helps, it's got nothing to do with updatedb
as such - at least not as I see it.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe
,
suggestions etc.
Any ideas people?
On Sunday 15 July 2007 04:04:50 Jesper Juhl wrote:
> On 09/07/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > I just experienced a long hang and a lot of unpleasant messages in dmesg
> > while building randconfig kernels in a loop.
>
is not laggy when I
come back. The "laggyness" doesn't last too long and is hard to
quantify, but I'll try getting some numbers (if in no other way, then
perhaps by using a stop watch)
Fact is, this is a scenario that is common to me and one where swap
prefetch definately makes the box f
. The laggyness doesn't last too long and is hard to
quantify, but I'll try getting some numbers (if in no other way, then
perhaps by using a stop watch)
Fact is, this is a scenario that is common to me and one where swap
prefetch definately makes the box feel nicer to work with.
--
Jesper Juhl [EMAIL
,
suggestions etc.
Any ideas people?
On Sunday 15 July 2007 04:04:50 Jesper Juhl wrote:
On 09/07/07, Jesper Juhl [EMAIL PROTECTED] wrote:
I just experienced a long hang and a lot of unpleasant messages in dmesg
while building randconfig kernels in a loop.
It just happened again without
with updatedb
as such - at least not as I see it.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
On 24/07/07, Patrick McHardy <[EMAIL PROTECTED]> wrote:
Jesper Juhl wrote:
> This patch cleans up duplicate includes in
> net/netfilter/
I've queued this one and the bridge-netfilter patch (27/37), thanks
Jesper.
Thanks for the feedback Patrick.
--
Jesper Juhl <[
On 24/07/07, Patrick McHardy [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
This patch cleans up duplicate includes in
net/netfilter/
I've queued this one and the bridge-netfilter patch (27/37), thanks
Jesper.
Thanks for the feedback Patrick.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top
tement is a macro, braces sometimes make a lot
of sense...
Suggested further improvement; check that patches don't modify files
listed in Documentation/dontdiff
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails
ast, Con has maintained it
nicely and cleaned up everything that people have pointed out - it's
mature, does no harm - let's just get it merged. It's too late for
2.6.23-rc1 now, but let's try and get this in by -rc2 - it's long
overdue...
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http:/
);
...
needs to be turned into
...
fail:
kfree(peers_ch);
kfree(response);
kfree(right_response);
...
drbd_req.c::drbd_make_request_common() also needs to get rid of
...
if (b) kfree(b); /* if someone else has beaten us to it... */
...
fail_and_free_req:
On 23/07/07, Takashi Iwai <[EMAIL PROTECTED]> wrote:
At Sat, 21 Jul 2007 17:04:07 +0200,
Jesper Juhl wrote:
>
> Hi,
>
> This patch cleans up duplicate includes in
> /
sound/ppc? :)
Hehe, yup. Seems I forgot to edit my mail template for that one :)
>
&
On 23/07/07, Takashi Iwai [EMAIL PROTECTED] wrote:
At Sat, 21 Jul 2007 17:04:07 +0200,
Jesper Juhl wrote:
Hi,
This patch cleans up duplicate includes in
/
sound/ppc? :)
Hehe, yup. Seems I forgot to edit my mail template for that one :)
Signed-off-by: Jesper Juhl [EMAIL
beaten us to it... */
...
fail_and_free_req:
if (b) kfree(b);
...
and just turn it into
...
kfree(b); /* if someone else has beaten us to it... */
...
fail_and_free_req:
kfree(b);
...
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T
maintained it
nicely and cleaned up everything that people have pointed out - it's
mature, does no harm - let's just get it merged. It's too late for
2.6.23-rc1 now, but let's try and get this in by -rc2 - it's long
overdue...
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr
is a macro, braces sometimes make a lot
of sense...
Suggested further improvement; check that patches don't modify files
listed in Documentation/dontdiff
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http
On Sunday 22 July 2007 04:30:41 Satyam Sharma wrote:
> On 7/21/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > [...]
> > These are the patches in this series :
>
> Ok, I've reviewed all patches in this series except:
>
> > [PATCH][12/37] Clean up duplicate
On Sunday 22 July 2007 04:30:41 Satyam Sharma wrote:
> On 7/21/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > [...]
> > These are the patches in this series :
>
> Ok, I've reviewed all patches in this series except:
>
> > [PATCH][12/37] Clean up duplicate
On Sunday 22 July 2007 04:30:41 you wrote:
> On 7/21/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > [...]
> > These are the patches in this series :
>
> Ok, I've reviewed all patches in this series except:
>
> > [PATCH][12/37] Clean up duplicate include
On 22/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
On 7/21/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> Hi,
>
> This patch cleans up duplicate includes in
> kernel/
>
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Reviewed-by: Satyam Sharm
ree_urb() and jumps to that one instead, in the problem case.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/hid/usbhid/hid-core.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index b2baeae..3ff
nused parameters, expressions that
are always false, etc. Although I doubt anyone is going to complain
too loudly about stuff that only shows up with "-W", cleaning it up
can't hurt.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.ht
On 21/07/07, David Brownell <[EMAIL PROTECTED]> wrote:
On Saturday 21 July 2007, Jesper Juhl wrote:
> Hi,
>
> This patch cleans up duplicate includes in
> drivers/spi/
>
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
ACK ... although, on general pr
Hi,
This patch cleans up duplicate includes in
sound/soc/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/sound/soc/pxa/spitz.c b/sound/soc/pxa/spitz.c
index 80e8210..4dd8f35 100644
--- a/sound/soc/pxa/spitz.c
+++ b/sound/soc/pxa/spitz.c
@@ -34,7 +34,6 @@
#i
Hi,
This patch cleans up duplicate includes in
sound/core/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c
index e470c3c..8a91cf8 100644
--- a/sound/core/rawmidi.c
+++ b/sound/core/rawmidi.c
@@ -30,7 +30,6 @@
#i
Hi,
This patch cleans up duplicate includes in
net/tipc/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/tipc/port.c b/net/tipc/port.c
index 5d2b9ce..7608815 100644
--- a/net/tipc/port.c
+++ b/net/tipc/port.c
@@ -41,7 +41,6 @@
#include "addr.h"
Hi,
This patch cleans up duplicate includes in
/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
index 1aa0b46..27b6189 100644
--- a/sound/ppc/snd_ps3.c
+++ b/sound/ppc/snd_ps3.c
@@ -33,7 +33,6 @@
#include
#i
Hi,
This patch cleans up duplicate includes in
net/sched/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/sched/act_police.c b/net/sched/act_police.c
index bf90e60..6085be5 100644
--- a/net/sched/act_police.c
+++ b/net/sched/act_police.c
@@ -16,7 +16,6 @@
#i
Hi,
This patch cleans up duplicate includes in
net/netfilter/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/netfilter/nf_conntrack_proto_tcp.c
b/net/netfilter/nf_conntrack_proto_tcp.c
index 87ad3cc..eb3fe74 100644
--- a/net/netfilter/nf_conntrack_proto
Hi,
This patch cleans up duplicate includes in
net/xfrm/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index c3a4b0a..e67489a 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -23,10 +23,9 @@
#i
Hi,
This patch cleans up duplicate includes in
net/bridge/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/bridge/netfilter/ebt_log.c b/net/bridge/netfilter/ebt_log.c
index 031bfa4..89d0d59 100644
--- a/net/bridge/netfilter/ebt_log.c
+++ b/net/bridge/net
Hi,
This patch cleans up duplicate includes in
net/ipv6/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index d67fb1e..db50114 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -56,7 +56,6 @@
#include
#i
Hi,
This patch cleans up duplicate includes in
include/linux/nfs_fs.h
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
index 9ba4aec..badc051 100644
--- a/include/linux/nfs_fs.h
+++ b/include/linux/nfs_fs.h
@@ -47,10
601 - 700 of 2260 matches
Mail list logo
