Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic of Acer SWIFT with ALC256

2021-02-25 Thread Jian-Hong Pan
Jian-Hong Pan 於 2021年2月26日 週五 上午10:05寫道: > > 於 2021年2月26日 週五 上午9:04寫道: > > > > From: Chris Chiu > > > > The Acer SWIFT Swift SF314-54/55 laptops with ALC256 cannot detect > > both the headset mic and the internal mic. Introduce new fixup > > to enable t

Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic of Acer SWIFT with ALC256

2021-02-25 Thread Jian-Hong Pan
is Intel SST DMIC that does not connect to Realtek HDA CODEC. (Not sure for this one) The quirk of NID 0x19 is okay for me. BR, Jian-Hong Pan > + { } > + }, > + .chained = true, > + .chain_id = ALC269_FIXUP_HEADSET_MODE

[PATCH] ALSA: hda/realtek: Enable headset of ASUS B1400CEPE with ALC256

2021-01-21 Thread Jian-Hong Pan
Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index ed5b6b894dc1..290645516313 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c

Re: [PATCH v2] HID: Add Wireless Radio Control feature for Chicony devices

2021-01-10 Thread Jian-Hong Pan
Jiri Kosina 於 2021年1月7日 週四 下午5:23寫道: > > On Wed, 23 Dec 2020, Jian-Hong Pan wrote: > > > Some Chicony's keyboards support airplane mode hotkey (Fn+F2) with > > "Wireless Radio Control" feature. For example, the wireless keyboard > > [04f2:1236] shipped with A

Re: [PATCH] HID: Add Wireless Radio Control feature for Chicony devices

2020-12-24 Thread Jian-Hong Pan
Pavel Machek 於 2020年12月25日 週五 上午3:06寫道: > > On Tue 2020-12-22 15:38:56, Jian-Hong Pan wrote: > > Some Chicony's keyboards support airplane mode hotkey (Fn+F2) with > > "Wireless Radio Control" feature. For example, the wireless keyboard > > [04f2:1236] sh

[PATCH v2] HID: Add Wireless Radio Control feature for Chicony devices

2020-12-22 Thread Jian-Hong Pan
ID and 0x1 as the value when the key is pressed down. This patch maps the event as KEY_RFKILL. Signed-off-by: Jian-Hong Pan --- v2: Remove the duplicated key pressed check. drivers/hid/hid-chicony.c | 55 +++ drivers/hid/hid-ids.h | 1 + 2 files changed, 56

Re: [PATCH] HID: Add Wireless Radio Control feature for Chicony devices

2020-12-22 Thread Jian-Hong Pan
Chris Chiu 於 2020年12月23日 週三 上午12:41寫道: > > On Tue, Dec 22, 2020 at 3:41 PM Jian-Hong Pan wrote: > > > > Some Chicony's keyboards support airplane mode hotkey (Fn+F2) with > > "Wireless Radio Control" feature. For example, the wireless keyboard > > [04f2:12

[PATCH] HID: Add Wireless Radio Control feature for Chicony devices

2020-12-21 Thread Jian-Hong Pan
ID and 0x1 as the value when the key is pressed down. This patch maps the event as KEY_RFKILL. Signed-off-by: Jian-Hong Pan --- drivers/hid/hid-chicony.c | 58 +++ drivers/hid/hid-ids.h | 1 + 2 files changed, 59 insertions(+) diff --git a/drivers/hid/hid-c

[PATCH] ALSA: hda/realtek: Enable headset of ASUS UX482EG & B9400CEA with ALC294

2020-11-24 Thread Jian-Hong Pan
Some laptops like ASUS UX482EG & B9400CEA's headset audio does not work until the quirk ALC294_FIXUP_ASUS_HPE is applied. Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci

[PATCH v2] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887

2020-10-06 Thread Jian-Hong Pan
the function like alc887_fixup_asus_jack to enable the audio jacks. Signed-off-by: Jian-Hong Pan Signed-off-by: Kailang Yang --- v2: - Change the magic numbers to meaningful macros. - Change snd_hda_codec_write to snd_hda_set_pin_ctl and snd_hda_set_pin_ctl_cache accroding to Takashi's

[PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887

2020-10-06 Thread Jian-Hong Pan
the function like alc887_fixup_asus_jack to enable the audio jacks. Signed-off-by: Jian-Hong Pan Signed-off-by: Kailang Yang --- sound/pci/hda/patch_realtek.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda

Re: [QUESTION] Enable the wireless module on Pinebook Pro

2020-09-30 Thread Jian-Hong Pan
I forgot to mail to Dan Johansen as well. Jian-Hong Pan 於 2020年9月30日 週三 下午4:15寫道: > > Hi, > > According to the preloaded system Manjaro ARM on Pinebook Pro [1], I > found the firmware files in ap6256-firmware package [2] enable the > wireless module, including WiFi and Bluet

[QUESTION] Enable the wireless module on Pinebook Pro

2020-09-30 Thread Jian-Hong Pan
of license should follow? [1] https://www.pine64.org/pinebook-pro/ [2] https://gitlab.manjaro.org/manjaro-arm/packages/community/ap6256-firmware Jian-Hong Pan

[PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort

2020-09-24 Thread Jian-Hong Pan
://patchwork.kernel.org/patch/11794141/#23639877 Signed-off-by: Jian-Hong Pan --- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399

Re: [PATCH] drm/rockchip: skip probed failed device

2020-09-24 Thread Jian-Hong Pan
Heiko Stübner 於 2020年9月23日 週三 下午7:16寫道: > > Am Mittwoch, 23. September 2020, 13:05:26 CEST schrieb Robin Murphy: > > On 2020-09-23 07:59, Jian-Hong Pan wrote: > > > The cdn-dp sub driver probes the device failed on PINEBOOK Pro. > > > > > > kernel

[PATCH] drm/rockchip: skip probed failed device

2020-09-23 Thread Jian-Hong Pan
/022352.html Signed-off-by: Jian-Hong Pan --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 0f3eb392fe39..de13588602b4 100644 --- a/drivers/gpu

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-04 Thread Jian-Hong Pan
... $ xxd /proc/device-tree/soc/hdmi@7ef05700/clocks : 0010 000d 0010 000e 0010: 0017 0001 001a Do I miss something? [1]: https://gist.github.com/starnight/649ea5a8384313f0354aca504f78ad70#file-config [2]: https://gist.github.com/starnight/649ea5a8384313f0354aca504f78ad70#file-dmesg-log Jian-Hong Pan

[PATCH] brcm: Add 4356 based AP6356S NVRAM for the khadas VIM2

2020-08-11 Thread Jian-Hong Pan
c92a668a3d Suggested-by: Nick Xie Signed-off-by: Jian-Hong Pan --- brcm/brcmfmac4356-sdio.khadas,vim2.txt | 128 + 1 file changed, 128 insertions(+) create mode 100644 brcm/brcmfmac4356-sdio.khadas,vim2.txt diff --git a/brcm/brcmfmac4356-sdio.khadas,vim2.txt b/brcm/br

[PATCH] ALSA: hda/realtek: Enable headset mic of Acer TravelMate B311R-31 with ALC256

2020-07-13 Thread Jian-Hong Pan
The Acer TravelMate B311R-31 laptop's audio (1025:1430) with ALC256 cannot detect the headset microphone until ALC256_FIXUP_ACER_MIC_NO_PRESENCE quirk maps the NID 0x19 as the headset mic pin. Signed-off-by: Jian-Hong Pan --- Re-send for wrong email address sound/pci/hda/patch_realtek.c | 11

Re: [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline

2020-07-10 Thread Jian-Hong Pan
Hi Maxime, Thanks for your version 4 patch again. I took the patches and applied them upon next-20200708. I make system cold reboot to multi-user target and the text console shows on the screen. Then, I simply hot re-plug the HDMI cable on HDMI0 port, I not only lose the text console on the

[PATCH v3 3/3] ALSA: hda/realtek: Enable headset mic of Acer Veriton N4660G with ALC269VC

2020-07-06 Thread Jian-Hong Pan
The Acer Veriton N4660G desktop's audio (1025:1248) with ALC269VC cannot detect the headset microphone until ALC269VC_FIXUP_ACER_MIC_NO_PRESENCE quirk maps the NID 0x18 as the headset mic pin. Signed-off-by: Jian-Hong Pan --- v3: Change the chained ID to ALC269_FIXUP_HEADSET_MIC according

[PATCH v3 2/3] ALSA: hda/realtek: Enable headset mic of Acer C20-820 with ALC269VC

2020-07-06 Thread Jian-Hong Pan
The Acer Aspire C20-820 AIO's audio (1025:1065) with ALC269VC can't detect the headset microphone until ALC269VC_FIXUP_ACER_HEADSET_MIC quirk maps the NID 0x18 as the headset mic pin. Signed-off-by: Jian-Hong Pan Signed-off-by: Daniel Drake --- v3: Change the chained ID

[PATCH v3 1/3] ALSA: hda/realtek - Enable audio jacks of Acer vCopperbox with ALC269VC

2020-07-06 Thread Jian-Hong Pan
The Acer desktop vCopperbox with ALC269VC cannot detect the MIC of headset, the line out and internal speaker until ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS quirk applied. Signed-off-by: Jian-Hong Pan Signed-off-by: Chris Chiu --- v3: Change the chained ID to ALC269_FIXUP_HEADSET_MIC according

[PATCH v2 1/3] ALSA: hda/realtek - Enable audio jacks of Acer vCopperbox with ALC269VC

2020-07-03 Thread Jian-Hong Pan
The Acer desktop vCopperbox with ALC269VC cannot detect the MIC of headset, the line out and internal speaker until ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS quirk applied. Signed-off-by: Jian-Hong Pan Signed-off-by: Chris Chiu --- sound/pci/hda/patch_realtek.c | 13 + 1 file changed, 13

[PATCH 3/3] ALSA: hda/realtek: Enable headset mic of Acer Veriton N4660G with ALC269VC

2020-07-03 Thread Jian-Hong Pan
The Acer Veriton N4660G desktop's audio (1025:1248) with ALC269VC cannot detect the headset microphone until ALC269VC_FIXUP_ACER_MIC_NO_PRESENCE quirk maps the NID 0x18 as the headset mic pin. Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 11 +++ 1 file changed, 11

[PATCH 2/3] ALSA: hda/realtek: Enable headset mic of Acer C20-820 with ALC269VC

2020-07-03 Thread Jian-Hong Pan
The Acer Aspire C20-820 AIO's audio (1025:1065) with ALC269VC can't detect the headset microphone until ALC269VC_FIXUP_ACER_HEADSET_MIC quirk maps the NID 0x18 as the headset mic pin. Signed-off-by: Jian-Hong Pan Signed-off-by: Daniel Drake --- sound/pci/hda/patch_realtek.c | 11 +++ 1

[PATCH 1/3] ALSA: hda/realtek - Enable audio jacks of Acer vCopperbox with ALC269VC

2020-07-03 Thread Jian-Hong Pan
The Acer desktop vCopperbox with ALC269VC cannot detect the MIC of headset, the line out and internal speaker until ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS quirk applied. Signed-off-by: Jian-Hong Pan Signed-off-by: Chris Chiu --- sound/pci/hda/patch_realtek.c | 13 + 1 file changed, 13

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-06-30 Thread Jian-Hong Pan
Maxime Ripard 於 2020年6月29日 週一 下午10:21寫道: > > Hi! > > On Fri, Jun 05, 2020 at 04:44:51PM +0800, Jian-Hong Pan wrote: > > Maxime Ripard 於 2020年6月2日 週二 下午7:04寫道: > > > > > > Hi, > > > > > > On Mon, Jun 01, 2020 at 03:58:26PM +0800, Jian-Hong Pan

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-06-05 Thread Jian-Hong Pan
Maxime Ripard 於 2020年6月2日 週二 下午7:04寫道: > > Hi, > > On Mon, Jun 01, 2020 at 03:58:26PM +0800, Jian-Hong Pan wrote: > > Maxime Ripard 於 2020年5月28日 週四 下午3:30寫道: > > > > > > Hi Daniel, > > > > > > On Wed, May 27, 2020 at 05:15:12PM +0800, Danie

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-06-01 Thread Jian-Hong Pan
st.github.com/starnight/3f317dca121065a361cf08e91225e389 2. The screen flashes suddenly sometimes. 3. The higher resolutions, like 1920x1080 ... are lost after hot re-plug HDMI cable (HDMI0) Jian-Hong Pan

[PATCH 3/3] ALSA: hda/realtek: Enable headset mic of ASUS UX581LV with ALC295

2020-05-12 Thread Jian-Hong Pan
The ASUS UX581LV laptop's audio (1043:19e1) with ALC295 can't detect the headset microphone until ALC295_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b

[PATCH 2/3] ALSA: hda/realtek - Enable headset mic of ASUS UX550GE with ALC295

2020-05-12 Thread Jian-Hong Pan
The ASUS laptop UX550GE with ALC295 can't detect the headset microphone until ALC295_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Jian-Hong Pan Signed-off-by: Daniel Drake --- sound/pci/hda/patch_realtek.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda

[PATCH 1/3] ALSA: hda/realtek - Enable headset mic of ASUS GL503VM with ALC295

2020-05-12 Thread Jian-Hong Pan
From: Chris Chiu The ASUS laptop GL503VM with ALC295 can't detect the headset microphone. The headset microphone does not work until pin 0x19 is enabled for it. Signed-off-by: Chris Chiu Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 14

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-05-10 Thread Jian-Hong Pan
Jian-Hong Pan 於 2020年5月8日 週五 下午2:20寫道: > > Maxime Ripard 於 2020年5月8日 週五 上午1:22寫道: > > > > On Mon, May 04, 2020 at 02:35:08PM +0800, Jian-Hong Pan wrote: > > > Maxime Ripard 於 2020年4月29日 週三 上午12:21寫道: > > > > > > > > Hi, > > > >

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-05-08 Thread Jian-Hong Pan
Maxime Ripard 於 2020年5月8日 週五 上午1:22寫道: > > On Mon, May 04, 2020 at 02:35:08PM +0800, Jian-Hong Pan wrote: > > Maxime Ripard 於 2020年4月29日 週三 上午12:21寫道: > > > > > > Hi, > > > > > > On Mon, Apr 27, 2020 at 03:23:42PM +0800, Jian-Hong Pan wrote: >

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-05-04 Thread Jian-Hong Pan
Maxime Ripard 於 2020年4月29日 週三 上午12:21寫道: > > Hi, > > On Mon, Apr 27, 2020 at 03:23:42PM +0800, Jian-Hong Pan wrote: > > Hi Maxime, > > > > Thanks for your V2 patch series! I'm testing it. > > > > This patch series is applied upon mainline kernel 5.7-

[PATCH] drm/radeon: drm/amdgpu: Disable [1002:6611] in radeon

2020-04-30 Thread Jian-Hong Pan
/amd/-/issues/1117 Signed-off-by: Jian-Hong Pan --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 11 +++ include/drm/drm_pciids.h| 1 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu

[PATCH] PCI/MSI: Fix restoring of MSI-X vector control's mask bit

2019-10-07 Thread Jian-Hong Pan
://bugzilla.kernel.org/show_bug.cgi?id=204887 Fixed: f2440d9acbe8 ("PCI MSI: Refactor interrupt masking code") Signed-off-by: Jian-Hong Pan --- drivers/pci/msi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 08

[PATCH] nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T

2019-09-24 Thread Jian-Hong Pan
ink: https://bugzilla.kernel.org/show_bug.cgi?id=204887 Signed-off-by: Jian-Hong Pan --- drivers/nvme/host/core.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 1ede1763a5ee..84fe3c4059a2 100644 --- a/drivers/nvme/host/core.c +++ b/drivers

[PATCH] Bluetooth: btrtl: Additional Realtek 8822CE Bluetooth devices

2019-09-03 Thread Jian-Hong Pan
#EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204707 Signed-off-by: Jian-Hong Pan --- drivers/bluetooth/btusb.c | 3 +++ 1 file changed, 3 insertions

Re: [PATCH] ALSA: hda/realtek - Enable internal speaker & headset mic of ASUS UX431FL

2019-09-02 Thread Jian-Hong Pan
Takashi Iwai 於 2019年9月2日 週一 下午7:41寫道: > > On Mon, 02 Sep 2019 12:00:56 +0200, > Jian-Hong Pan wrote: > > > > Original pin node values of ASUS UX431FL with ALC294: > > > > 0x12 0xb7a60140 > > 0x13 0x4000 > > 0x14 0x90170110 > > 0x15 0x41

Re: [PATCH v4] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-09-02 Thread Jian-Hong Pan
Kalle Valo 於 2019年9月2日 週一 下午8:18寫道: > > Tony Chuang writes: > > >> From: Jian-Hong Pan > >> Subject: [PATCH v4] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ > >> > >> There is a mass of jobs between spin lock and unlock in the hardware &g

[PATCH] ALSA: hda/realtek - Enable internal speaker & headset mic of ASUS UX431FL

2019-09-02 Thread Jian-Hong Pan
internal speakers (0x14 & 0x17) which makes the output route become confused. So, the output volume cannot be changed by setting. 2. Misses the headset mic pin node. This patch disables the confusing speaker (NID 0x14) and enables the headset mic (NID 0x19). Signed-off-by: Jian-Hong

Re: [PATCH v3] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-26 Thread Jian-Hong Pan
Tony Chuang 於 2019年8月21日 週三 下午4:16寫道: > > Hi, > > > From: Jian-Hong Pan [mailto:jian-h...@endlessm.com] > > > > There is a mass of jobs between spin lock and unlock in the hardware > > IRQ which will occupy much time originally. To make system work more > >

[PATCH v4] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-26 Thread Jian-Hong Pan
There is a mass of jobs between spin lock and unlock in the hardware IRQ which will occupy much time originally. To make system work more efficiently, this patch moves the jobs to the soft IRQ (bottom half) to reduce the time in hardware IRQ. Signed-off-by: Jian-Hong Pan --- v2: Change

[PATCH v3] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-19 Thread Jian-Hong Pan
There is a mass of jobs between spin lock and unlock in the hardware IRQ which will occupy much time originally. To make system work more efficiently, this patch moves the jobs to the soft IRQ (bottom half) to reduce the time in hardware IRQ. Signed-off-by: Jian-Hong Pan --- v2: Change

Re: [PATCH v2] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-18 Thread Jian-Hong Pan
Tony Chuang 於 2019年8月16日 週五 下午6:44寫道: > > > From: Jian-Hong Pan > > > > There is a mass of jobs between spin lock and unlock in the hardware > > IRQ which will occupy much time originally. To make system work more > > efficiently, this patch moves the

[PATCH v2] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-16 Thread Jian-Hong Pan
There is a mass of jobs between spin lock and unlock in the hardware IRQ which will occupy much time originally. To make system work more efficiently, this patch moves the jobs to the soft IRQ (bottom half) to reduce the time in hardware IRQ. Signed-off-by: Jian-Hong Pan --- v2: Change

Re: [PATCH] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-16 Thread Jian-Hong Pan
Tony Chuang 於 2019年8月16日 週五 下午4:07寫道: > > Hi, > > A few more questions below > > > > From: Jian-Hong Pan [mailto:jian-h...@endlessm.com] > > > > > > There is a mass of jobs between spin lock and unlock in the hardware > > > IRQ which will oc

[PATCH] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-16 Thread Jian-Hong Pan
There is a mass of jobs between spin lock and unlock in the hardware IRQ which will occupy much time originally. To make system work more efficiently, this patch moves the jobs to the soft IRQ (bottom half) to reduce the time in hardware IRQ. Signed-off-by: Jian-Hong Pan --- drivers/net

Re: [PATCH] rtw88: pci: Use general byte arrays as the elements of RX ring

2019-07-26 Thread Jian-Hong Pan
David Laight 於 2019年7月26日 週五 下午5:23寫道: > > From: Jian-Hong Pan > > Sent: 26 July 2019 07:18 > ... > > > While allocating all 512 buffers in one block (just over 4MB) > > > is probably not a good idea, you may need to allocated (and dma map) > > > th

Re: [PATCH] rtw88: pci: Use general byte arrays as the elements of RX ring

2019-07-26 Thread Jian-Hong Pan
David Laight 於 2019年7月25日 週四 下午5:21寫道: > > From: Jian-Hong Pan > > Sent: 25 July 2019 09:09 > > Each skb as the element in RX ring was expected with sized buffer 8216 > > (RTK_PCI_RX_BUF_SIZE) bytes. However, the skb buffer's true size is > > 16640 bytes for ali

[PATCH] rtw88: pci: Use general byte arrays as the elements of RX ring

2019-07-25 Thread Jian-Hong Pan
wasted memory, this patch follows David's suggestion [1] and uses general buffer arrays, instead of skbs as the elements in RX ring. [1] https://www.spinics.net/lists/linux-wireless/msg187870.html Signed-off-by: Jian-Hong Pan Cc: --- drivers/net/wireless/realtek/rtw88/pci.c | 132

Re: [PATCH v4 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-24 Thread Jian-Hong Pan
Jian-Hong Pan 於 2019年7月11日 週四 下午1:28寫道: > > Jian-Hong Pan 於 2019年7月11日 週四 下午1:25寫道: > > > > Testing with RTL8822BE hardware, when available memory is low, we > > frequently see a kernel panic and system freeze. > > > > First, rtw_pci_rx_isr encounters

Re: [PATCH v4 2/2] rtw88: pci: Use DMA sync instead of remapping in RX ISR

2019-07-10 Thread Jian-Hong Pan
Jian-Hong Pan 於 2019年7月11日 週四 下午1:25寫道: > > Since each skb in RX ring is reused instead of new allocation, we can > treat the DMA in a more efficient way by DMA synchronization. > > Signed-off-by: Jian-Hong Pan > Cc: > --- Sorry, also forget to place the version differ

Re: [PATCH v4 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-10 Thread Jian-Hong Pan
Jian-Hong Pan 於 2019年7月11日 週四 下午1:25寫道: > > Testing with RTL8822BE hardware, when available memory is low, we > frequently see a kernel panic and system freeze. > > First, rtw_pci_rx_isr encounters a memory allocation failure (trimmed): > > rx routine starvation > W

[PATCH v4 2/2] rtw88: pci: Use DMA sync instead of remapping in RX ISR

2019-07-10 Thread Jian-Hong Pan
Since each skb in RX ring is reused instead of new allocation, we can treat the DMA in a more efficient way by DMA synchronization. Signed-off-by: Jian-Hong Pan Cc: --- drivers/net/wireless/realtek/rtw88/pci.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions

[PATCH v4 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-10 Thread Jian-Hong Pan
low memory conditions. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204053 Signed-off-by: Jian-Hong Pan Cc: --- drivers/net/wireless/realtek/rtw88/pci.c | 49 +++- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/d

Re: [PATCH v3 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-10 Thread Jian-Hong Pan
David Laight 於 2019年7月10日 週三 下午4:57寫道: > > From: Jian-Hong Pan > > Sent: 10 July 2019 09:38 > > > > Testing with RTL8822BE hardware, when available memory is low, we > > frequently see a kernel panic and system freeze. > > > > First, rtw_pci_rx_isr encou

Re: [PATCH v2 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-10 Thread Jian-Hong Pan
In both cases, the > > original, full size ring skb is reused. > > > > In addition, to fixing the kernel crash, the RX routine should now > > generally behave better under low memory conditions. > > > > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204053 > >

[PATCH v3 2/2] rtw88: pci: Use DMA sync instead of remapping in RX ISR

2019-07-10 Thread Jian-Hong Pan
Since each skb in RX ring is reused instead of new allocation, we can treat the DMA in a more efficient way by DMA synchronization. Signed-off-by: Jian-Hong Pan Cc: --- v2: - New patch by following [PATCH v3 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR. v3: - Remove

[PATCH v3 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-10 Thread Jian-Hong Pan
low memory conditions. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204053 Signed-off-by: Jian-Hong Pan Cc: --- v2: - Allocate new data-sized skb and put data into it, then pass it to mac80211. Reuse the original skb in RX ring by DMA sync. - Modify the commit message. - Introduce following

[PATCH v2 2/2] rtw88: pci: Use DMA sync instead of remapping in RX ISR

2019-07-09 Thread Jian-Hong Pan
Since each skb in RX ring is reused instead of new allocation, we can treat the DMA in a more efficient way by DMA synchronization. Signed-off-by: Jian-Hong Pan --- drivers/net/wireless/realtek/rtw88/pci.c | 35 ++-- 1 file changed, 32 insertions(+), 3 deletions(-) diff

[PATCH v2 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-09 Thread Jian-Hong Pan
low memory conditions. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204053 Signed-off-by: Jian-Hong Pan Cc: --- drivers/net/wireless/realtek/rtw88/pci.c | 49 +++- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/d

Re: [PATCH] rtw88/pci: Rearrange the memory usage for skb in RX ISR

2019-07-08 Thread Jian-Hong Pan
on, to fixing the kernel crash, the RX routine should now > > generally behave better under low memory conditions. > > > > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204053 > > Signed-off-by: Jian-Hong Pan > > Reviewed-by: Daniel Drake > > Cc: > >

[PATCH] rtw88/pci: Rearrange the memory usage for skb in RX ISR

2019-07-08 Thread Jian-Hong Pan
tter under low memory conditions. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204053 Signed-off-by: Jian-Hong Pan Reviewed-by: Daniel Drake Cc: --- drivers/net/wireless/realtek/rtw88/pci.c | 28 +++- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/d

[PATCH v3] Bluetooth: btrtl: HCI reset on close for Realtek BT chip

2019-06-25 Thread Jian-Hong Pan
off, then turned on again, it works correctly again. According to the vendor driver, the HCI_QUIRK_RESET_ON_CLOSE flag is set during probing. So, this patch makes Realtek's BT reset on close to fix this issue. Link: https://bugzilla.kernel.org/show_bug.cgi?id=203429 Signed-off-by: Jian-Hong Pan

[PATCH v2] Bluetooth: btrtl: HCI reset on close for Realtek BT chip

2019-06-24 Thread Jian-Hong Pan
to the vendor driver, the HCI_QUIRK_RESET_ON_CLOSE flag is set during probing. So, this patch makes Realtek's BT reset on close to fix this issue. Signed-off-by: Jian-Hong Pan --- v2: - According to the vendor driver, it makes "all" Realtek's BT reset on close. So, this version makes i

[PATCH] Bluetooth: btrtl: HCI reset on close for RTL8822BE

2019-06-21 Thread Jian-Hong Pan
makes RTL8822BE BT reset on close to fix this issue. Signed-off-by: Jian-Hong Pan --- drivers/bluetooth/btrtl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c index 208feef63de4..7e9930f0f231 100644 --- a/drivers/bluetooth

[tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T

2019-04-16 Thread tip-bot for Jian-Hong Pan
Commit-ID: 0082517fa4bce073e7cf542633439f26538a14cc Gitweb: https://git.kernel.org/tip/0082517fa4bce073e7cf542633439f26538a14cc Author: Jian-Hong Pan AuthorDate: Fri, 12 Apr 2019 16:01:53 +0800 Committer: Ingo Molnar CommitDate: Tue, 16 Apr 2019 10:01:24 +0200 x86/reboot, efi: Use EFI

[tip:x86/urgent] x86/reboot: Use EFI reboot for Acer TravelMate X514-51T

2019-04-16 Thread tip-bot for Jian-Hong Pan
Commit-ID: 5767575c1211e8958e5dd80d6542998b519c8478 Gitweb: https://git.kernel.org/tip/5767575c1211e8958e5dd80d6542998b519c8478 Author: Jian-Hong Pan AuthorDate: Fri, 12 Apr 2019 16:01:53 +0800 Committer: Ingo Molnar CommitDate: Tue, 16 Apr 2019 09:49:16 +0200 x86/reboot: Use EFI

[PATCH v2] x86/reboot: Use efi reboot for Acer TravelMate X514-51T

2019-04-12 Thread Jian-Hong Pan
://bugzilla.kernel.org/show_bug.cgi?id=203119 Signed-off-by: Jian-Hong Pan Signed-off-by: Daniel Drake --- v2: - Add the EFI runtime state checking in set_efi_reboot function for the quirk. - Refine the printing information by writing "EFI" in the string directly. arch/x86/kernel/reb

Re: [PATCH] x86/reboot: Use efi reboot for Acer TravelMate X514-51T

2019-04-08 Thread Jian-Hong Pan
Thomas Gleixner 於 2019年4月6日 週六 上午5:14寫道: > > On Mon, 1 Apr 2019, Jian-Hong Pan wrote: > > +/* > > + * Some machines require the "reboot=e" commandline options > > + */ > > +static int __init set_efi_reboot(const struct dmi_system_id *d) >

[PATCH] x86/reboot: Use efi reboot for Acer TravelMate X514-51T

2019-04-01 Thread Jian-Hong Pan
able to identify the exact conditions that trigger the issue to come and go. However, after extensive testing, we observe that using the EFI reboot method reliably avoids the issue in all cases. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=203119 Signed-off-by: Jian-Hong Pan Signed-off

[PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233

2019-03-31 Thread Jian-Hong Pan
The Acer TravelMate B114-21 laptop cannot detect and record sound from headset MIC. This patch adds the ALC233_FIXUP_ACER_HEADSET_MIC HDA verb quirk chained with ALC233_FIXUP_ASUS_MIC_NO_PRESENCE pin quirk to fix this issue. Signed-off-by: Jian-Hong Pan Signed-off-by: Daniel Drake --- sound

[PATCH 3/3] ALSA: hda/realtek: Enable headset MIC of ASUS X430UN and X512DK with ALC256

2019-03-21 Thread Jian-Hong Pan
The ASUS X430UN and X512DK with ALC256 cannot detect the headset MIC until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Jian-Hong Pan Signed-off-by: Daniel Drake --- sound/pci/hda/patch_realtek.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda

[PATCH 2/3] ALSA: hda/realtek: Enable headset mic of ASUS P5440FF with ALC256

2019-03-21 Thread Jian-Hong Pan
From: Chris Chiu The ASUS laptop P5440FF with ALC256 can't detect the headset microphone until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Chris Chiu Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 4 1 file changed, 4

[PATCH 1/3] ALSA: hda/realtek: Enable ASUS X441MB and X705FD headset MIC with ALC256

2019-03-21 Thread Jian-Hong Pan
The ASUS laptop X441MB and X705FD with ALC256 cannot detect the headset MIC until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Chris Chiu Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 14 ++ 1 file changed, 14

[PATCH] ALSA: hda/realtek - Add support for Acer Aspire E5-523G/ES1-432 headset mic

2019-03-21 Thread Jian-Hong Pan
From: Chris Chiu The Acer laptop Aspire E5-523G and ES1-432 with ALC255 can't detect the headset microphone until ALC255_FIXUP_ACER_MIC_NO_PRESENCE quirk applied. Signed-off-by: Chris Chiu Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 2 ++ 1

[PATCH] ALSA: hda/realtek: Enable headset MIC of Acer Aspire Z24-890 with ALC286

2019-03-21 Thread Jian-Hong Pan
The Acer Aspire Z24-890 cannot detect the headset MIC until ALC286_FIXUP_ACER_AIO_HEADSET_MIC quirk applied. Signed-off-by: Jian-Hong Pan Signed-off-by: Daniel Drake --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci

Re: [PATCH v2] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286

2019-03-19 Thread Jian-Hong Pan
Takashi Iwai 於 2019年3月15日 週五 下午7:24寫道: > > On Fri, 15 Mar 2019 10:51:09 +0100, > Jian-Hong Pan wrote: > > > > Some Acer AIO desktops like Veriton Z6860G, Z4860G and Z4660G cannot > > record sound from headset MIC. This patch adds the > > ALC286_FIXUP_ACER_AIO_HE

[PATCH v2] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286

2019-03-15 Thread Jian-Hong Pan
Some Acer AIO desktops like Veriton Z6860G, Z4860G and Z4660G cannot record sound from headset MIC. This patch adds the ALC286_FIXUP_ACER_AIO_HEADSET_MIC quirk to fix this issue. Signed-off-by: Jian-Hong Pan --- v2: According to Realtek's suggestion, change the COEF 0x4f from 0xd429

[PATCH] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286

2019-03-14 Thread Jian-Hong Pan
Some Acer AIO desktops like Veriton Z6860G, Z4860G and Z4660G cannot record sound from headset MIC. This patch adds the ALC286_FIXUP_ACER_AIO_HEADSET_MIC quirk to fix this issue. Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 17 ++--- 1 file changed, 14

[PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate X514-51T with ALC255

2019-03-13 Thread Jian-Hong Pan
The Acer TravelMate X514-51T with ALC255 cannot detect the headset MIC until ALC255_FIXUP_ACER_HEADSET_MIC quirk applied. Although, the internal DMIC uses another module - snd_soc_skl as the driver. We still need the NID 0x1a in the quirk to enable the headset MIC. Signed-off-by: Jian-Hong Pan

[PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX362FA with ALC294

2019-02-21 Thread Jian-Hong Pan
audio initial pin config values. So, this patch replaces SND_PCI_QUIRK of UX533FD with a new SND_HDA_PIN_QUIRK which benefits both UX362FA and UX533FD. Signed-off-by: Jian-Hong Pan Signed-off-by: Ming Shuo Chiu --- sound/pci/hda/patch_realtek.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [RFC PATCH 5/5] net: lorawan: Split skb definitions into another header

2019-01-16 Thread Jian-Hong Pan
lude/linux/lora/lorawan/skb.h 4. Split the lorawan skb stuff from lora/lorawan_netdev.h to include/linux/lorawan/skb.h #1, #2 and #3 are good to me. So, the intersection is choice #3. Regards, Jian-Hong Pan

Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

2019-01-16 Thread Jian-Hong Pan
Andreas Färber 於 2019年1月16日 週三 下午11:07寫道: > > Am 16.01.19 um 15:33 schrieb Jiri Pirko: > > Wed, Jan 16, 2019 at 03:24:54PM CET, starni...@g.ncu.edu.tw wrote: > >> Signed-off-by: Jian-Hong Pan > >> --- > > > > Patches like this are in general frowned upon

[RFC PATCH 5/5] net: lorawan: Split skb definitions into another header

2019-01-16 Thread Jian-Hong Pan
Split LoRaWAN related skb definitions from lora/lorawan_netdev.h into another header lora/lorawan_skb.h. Signed-off-by: Jian-Hong Pan --- include/linux/lora/lorawan_netdev.h | 20 - include/linux/lora/lorawan_skb.h| 33 + net/lorawan/socket.c

[RFC PATCH 4/5] net: lorawan: Fulfill the help text of Kconfig

2019-01-16 Thread Jian-Hong Pan
Mention the LoRaWAN network feature to distinguish it from other Low-Power Wide-Area Network like Sigfox and NB-IoT. Signed-off-by: Jian-Hong Pan --- net/lorawan/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/lorawan/Kconfig b/net/lorawan/Kconfig index

[RFC PATCH 5/5] net: lorawan: Split skb definitions into another header

2019-01-16 Thread Jian-Hong Pan
Split LoRaWAN related skb definitions from lora/lorawan_netdev.h into another header lora/lorawan_skb.h. Signed-off-by: Jian-Hong Pan --- include/linux/lora/lorawan_netdev.h | 20 - include/linux/lora/lorawan_skb.h| 33 + net/lorawan/socket.c

[RFC PATCH 3/5] net; lorawan: Fix net device leakage

2019-01-16 Thread Jian-Hong Pan
The net device may be missed to be put after error check. This patch fixes the issue to prevent the leakage. Signed-off-by: Jian-Hong Pan --- net/lorawan/socket.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/net/lorawan/socket.c b/net/lorawan/socket.c index

[RFC PATCH 2/5] net: lorawan: Remove unused lrw_dev_hard_header function

2019-01-16 Thread Jian-Hong Pan
The lorawan module is an abastraction layer over the LoRaWAN soft and hard MAC. It passes the original buffer to the real MAC layer. So, this patch removes the lrw_dev_hard_header function. Signed-off-by: Jian-Hong Pan --- net/lorawan/socket.c | 12 1 file changed, 12 deletions

[RFC PATCH 1/5] net: lorawan: Refine the coding style

2019-01-16 Thread Jian-Hong Pan
Signed-off-by: Jian-Hong Pan --- include/linux/lora/lorawan_netdev.h | 5 ++-- net/lorawan/socket.c| 43 ++--- 2 files changed, 22 insertions(+), 26 deletions(-) diff --git a/include/linux/lora/lorawan_netdev.h b/include/linux/lora/lorawan_netdev.h

[RFC PATCH 0/5] net: lorawan: Refine the lorawan protocol module

2019-01-16 Thread Jian-Hong Pan
Jian-Hong Pan (5): net: lorawan: Refine the coding style net: lorawan: Remove unused lrw_dev_hard_header function net; lorawan: Fix net device leakage net: lorawan: Fulfill the help text of Kconfig net: lorawan: Split skb definitions into another header include/linux/lora

Re: [PATCH v5 1/6] net: lorawan: Add LoRaWAN socket module

2019-01-13 Thread Jian-Hong Pan
Jian-Hong Pan 於 2019年1月7日 週一 下午10:47寫道: > > Andreas Färber 於 2018年12月29日 週六 下午3:27寫道: > > > > Hi Jian-Hong, > > > > Am 16.12.18 um 11:18 schrieb Jian-Hong Pan: > > > This patch adds a new address/protocol family for LoRaWAN network. > > > It also i

Re: [PATCH v5 1/6] net: lorawan: Add LoRaWAN socket module

2019-01-07 Thread Jian-Hong Pan
Andreas Färber 於 2018年12月29日 週六 下午3:27寫道: > > Hi Jian-Hong, > > Am 16.12.18 um 11:18 schrieb Jian-Hong Pan: > > This patch adds a new address/protocol family for LoRaWAN network. > > It also implements the the functions and maps to Datagram socket for > > LoR

[PATCH] ALSA: hda/realtek: Enable the headset mic auto detection for ASUS laptops

2018-12-27 Thread Jian-Hong Pan
The headset mic of ASUS laptops like UX533FD, UX433FN and UX333FA, whose CODEC is Realtek ALC294 has jack auto detection feature. This patch enables the feature. Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module

2018-12-19 Thread Jian-Hong Pan
> > Am 18.12.18 um 15:27 schrieb Jian-Hong Pan: > > >> Sun, Dec 16, 2018 at 11:18:59AM CET, starni...@g.ncu.edu.tw wrote: > > >>> LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa > > devices. > > >>> > > >>&

Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module

2018-12-18 Thread Jian-Hong Pan
pes > >> > > >> >On the other side, it defines the basic interface and operation > >> >functions for compatible LoRa device drivers. > >> > > >> >Signed-off-by: Jian-Hong Pan > >> >--- > >> >V2: > >> >- Split the LoR

Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module

2018-12-18 Thread Jian-Hong Pan
1. End-device receive slot timing > >2. Only single channel and single data rate for now > >3. Unconfirmed data up/down message types > > > >On the other side, it defines the basic interface and operation > >functions for compatible LoRa device drivers. > > > &

  1   2   3   >