[PATCH] pidff driver should work correctly with more than one concurrent effect

2015-02-26 Thread Jim Keir
o this at the start of pidff_upload_effect. Signed-off-by: Jim Keir --- drivers/hid/usbhid/hid-pidff.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 0b531c6..1b3fa70 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/dri

[PATCH] pidff driver should work correctly with more than one concurrent effect

2015-02-26 Thread Jim Keir
] at the end of pid_upload_effect, for later use. However, if an effect is modified and re-sent then this identifier is not being copied back from pidff-pid_id[effect-id] before sending the command to the device. The fix is to do this at the start of pidff_upload_effect. Signed-off-by: Jim Keir jimk

[PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-27 Thread Jim Keir
o this at the start of pidff_upload_effect. Signed-off-by: Jim Keir drivers/hid/usbhid/hid-pidff.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 0b531c6..1b3fa70 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/dri

[PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-27 Thread Jim Keir
-id] at the end of pid_upload_effect, for later use. However, if an effect is modified and re-sent then this identifier is not being copied back from pidff-pid_id[effect-id] before sending the command to the device. The fix is to do this at the start of pidff_upload_effect. Signed-off-by: Jim Keir

Re: [PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-24 Thread Jim Keir
OK, I am pushing a little bit, I just don't want today to go deep in the code :-) On Fri, Jan 23, 2015 at 12:21 PM, Jim Keir wrote: --- Hi, Changes from previous patches: - All changes removed from higher-level files - Extra debug line removed Signed-off-by: Jim Keir drivers/hid/usbhid/hid

Re: [PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-24 Thread Jim Keir
:-) On Fri, Jan 23, 2015 at 12:21 PM, Jim Keir jimk...@oracledbadirect.com wrote: --- Hi, Changes from previous patches: - All changes removed from higher-level files - Extra debug line removed Signed-off-by: Jim Keir jimk...@oracledbadirect.com drivers/hid/usbhid/hid-pidff.c | 6 ++ 1 file

[PATCH 1/2] Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-23 Thread Jim Keir
--- Hi, Changes from previous patches: - All changes removed from higher-level files - Calls to hid_device_io_start/stop added here Signed-off-by: Jim Keir drivers/hid/usbhid/hid-pidff.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid

[PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-23 Thread Jim Keir
--- Hi, Changes from previous patches: - All changes removed from higher-level files - Extra debug line removed Signed-off-by: Jim Keir drivers/hid/usbhid/hid-pidff.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c

[PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-23 Thread Jim Keir
--- Hi, Changes from previous patches: - All changes removed from higher-level files - Extra debug line removed Signed-off-by: Jim Keir jimk...@oracledbadirect.com drivers/hid/usbhid/hid-pidff.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/usbhid/hid-pidff.c b

[PATCH 1/2] Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-23 Thread Jim Keir
--- Hi, Changes from previous patches: - All changes removed from higher-level files - Calls to hid_device_io_start/stop added here Signed-off-by: Jim Keir jimk...@oracledbadirect.com drivers/hid/usbhid/hid-pidff.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/usbhid

Re: [PATCHv2 001/002] usbhid: Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-21 Thread Jim Keir
was using before. Apologies for the mistakes, I'm still feeling my way around here. --- Allow the Microsoft Sidewinder Force Feedback 2 joystick to perform the required communication with the device during initialisation. Signed-off-by: Jim Keir --- diff --git a/drivers/hid/usbhid/hid

Re: [PATCHv2 002/002] usbhid: Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-21 Thread Jim Keir
Hi, Here's the second part of the patch which allows existing effects to be modified. Cheers, Jim --- Modifications to existing force effects in the Microsoft Sidewinder Force Feedback 2 joystick are sent with the correct effect ID. Signed-off-by: Jim Keir --- diff --git a/drivers/hid

Re: [PATCHv2 001/002] usbhid: Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-21 Thread Jim Keir
was using before. Apologies for the mistakes, I'm still feeling my way around here. --- Allow the Microsoft Sidewinder Force Feedback 2 joystick to perform the required communication with the device during initialisation. Signed-off-by: Jim Keir jimk...@oracledbadirect.com --- diff --git

Re: [PATCHv2 002/002] usbhid: Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-21 Thread Jim Keir
Hi, Here's the second part of the patch which allows existing effects to be modified. Cheers, Jim --- Modifications to existing force effects in the Microsoft Sidewinder Force Feedback 2 joystick are sent with the correct effect ID. Signed-off-by: Jim Keir jimk...@oracledbadirect.com

[PATCH 001/001] usbhid: Fix initialisation and force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-18 Thread Jim Keir
From: Jim Keir Signed-off-by: Jim Keir Currently the SWFF2 driver fails during initialisation, making the force capability of the joystick unusable. Further, there is a long-standing bug in the same driver where commands to update force parameters are addressed to the last-created force effect

[PATCH 001/001] usbhid: Fix initialisation and force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-18 Thread Jim Keir
From: Jim Keir jimk...@yahoo.co.uk Signed-off-by: Jim Keir jimk...@yahoo.co.uk Currently the SWFF2 driver fails during initialisation, making the force capability of the joystick unusable. Further, there is a long-standing bug in the same driver where commands to update force parameters