Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

2018-11-19 Thread Jiri Kosina
ther mail. Actually Tim's patchset seems to already deal with IBPB in a consistent way as well in [11/16] x86/speculation: Add Spectre v2 app to app protection modes but the fact that it's still using TIF_STIBP makes it a bit confusing and hidden. So I'd suggest to fold something like

Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

2018-11-19 Thread Jiri Kosina
On Mon, 19 Nov 2018, Thomas Gleixner wrote: > > On Sat, 17 Nov 2018, Jiri Kosina wrote: > > > Subject: [PATCH] x86/speculation: enforce STIBP for SECCOMP tasks in lite > > mode > > > > If 'lite' mode of app2app protection from spectre_v2 is selected on > >

Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

2018-11-19 Thread Jiri Kosina
On Mon, 19 Nov 2018, Thomas Gleixner wrote: > > On Sat, 17 Nov 2018, Jiri Kosina wrote: > > > Subject: [PATCH] x86/speculation: enforce STIBP for SECCOMP tasks in lite > > mode > > > > If 'lite' mode of app2app protection from spectre_v2 is selected on > >

Re: [PATCH] l1tf: drop the swap storage limit restriction when l1tf=off

2018-11-19 Thread Jiri Kosina
n both > hypervisor and bare metal. > > Sounds better? > > > With that > > > > Acked-by: Jiri Kosina > > Thanks! Yes, I think that makes it absolutely clear. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] l1tf: drop the swap storage limit restriction when l1tf=off

2018-11-19 Thread Jiri Kosina
n both > hypervisor and bare metal. > > Sounds better? > > > With that > > > > Acked-by: Jiri Kosina > > Thanks! Yes, I think that makes it absolutely clear. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] Revert "HID: uhid: use strlcpy() instead of strncpy()"

2018-11-19 Thread Jiri Kosina
strncpy(hid->phys, ev->u.create2.phys, len); > + len = min(sizeof(hid->uniq), sizeof(ev->u.create2.uniq)) - 1; > + strncpy(hid->uniq, ev->u.create2.uniq, len); Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] Revert "HID: uhid: use strlcpy() instead of strncpy()"

2018-11-19 Thread Jiri Kosina
strncpy(hid->phys, ev->u.create2.phys, len); > + len = min(sizeof(hid->uniq), sizeof(ev->u.create2.uniq)) - 1; > + strncpy(hid->uniq, ev->u.create2.uniq, len); Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

2018-11-19 Thread Jiri Kosina
overlooked that (valid) concern in the thread. Thanks for spotting that, Andy. I've now applied Eric's patch. Thanks everybody, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

2018-11-19 Thread Jiri Kosina
overlooked that (valid) concern in the thread. Thanks for spotting that, Andy. I've now applied Eric's patch. Thanks everybody, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

2018-11-19 Thread Jiri Kosina
t;private_data; @@ -771,6 +780,7 @@ static const struct file_operations uhid_fops = { .release= uhid_char_release, .read = uhid_char_read, .write = uhid_char_write, + .splice_write = uhid_char_splice_write, .poll = uhid_char_poll, .llseek = no_llseek, }; -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

2018-11-19 Thread Jiri Kosina
t;private_data; @@ -771,6 +780,7 @@ static const struct file_operations uhid_fops = { .release= uhid_char_release, .read = uhid_char_read, .write = uhid_char_write, + .splice_write = uhid_char_splice_write, .poll = uhid_char_poll, .llseek = no_llseek, }; -- Jiri Kosina SUSE Labs

Re: STIBP by default.. Revert?

2018-11-19 Thread Jiri Kosina
so it's going to be explicit an > explicit requirement. Do you already have an idea whether you'd proceed with Tim's patchset for current cycle? If so, great as far as I am concerned. If not, I'll send a patch that switches this to opt-in via kernel cmdline (+boot-time warning if not mitigated). Thanks, -- Jiri Kosina SUSE Labs

Re: STIBP by default.. Revert?

2018-11-19 Thread Jiri Kosina
so it's going to be explicit an > explicit requirement. Do you already have an idea whether you'd proceed with Tim's patchset for current cycle? If so, great as far as I am concerned. If not, I'll send a patch that switches this to opt-in via kernel cmdline (+boot-time warning if not mitigated). Thanks, -- Jiri Kosina SUSE Labs

Re: STIBP by default.. Revert?

2018-11-18 Thread Jiri Kosina
On Sun, 18 Nov 2018, Jiri Kosina wrote: > It's probably not just browsers, but anything running JITed sandboxed > code. So the most straightforward way might be the prctl() aproach, where > userspace would claim "I do care about this, please fix it up for me". So > prc

Re: STIBP by default.. Revert?

2018-11-18 Thread Jiri Kosina
On Sun, 18 Nov 2018, Jiri Kosina wrote: > It's probably not just browsers, but anything running JITed sandboxed > code. So the most straightforward way might be the prctl() aproach, where > userspace would claim "I do care about this, please fix it up for me". So > prc

Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

2018-11-18 Thread Jiri Kosina
On Sat, 17 Nov 2018, Jiri Kosina wrote: > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > > b/Documentation/admin-guide/kernel-parameters.txt > > index 81d1d5a..9c306e3 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Do

Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

2018-11-18 Thread Jiri Kosina
On Sat, 17 Nov 2018, Jiri Kosina wrote: > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > > b/Documentation/admin-guide/kernel-parameters.txt > > index 81d1d5a..9c306e3 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Do

Re: STIBP by default.. Revert?

2018-11-18 Thread Jiri Kosina
e consistent (and get even a few more % of performance back), but that's easy as well. Thanks, -- Jiri Kosina SUSE Labs

Re: STIBP by default.. Revert?

2018-11-18 Thread Jiri Kosina
e consistent (and get even a few more % of performance back), but that's easy as well. Thanks, -- Jiri Kosina SUSE Labs

Re: STIBP by default.. Revert?

2018-11-18 Thread Jiri Kosina
than turning SMT off, which might possibly have even *worse* performance numbers depending on workload. [1] https://lore.kernel.org/lkml/?q=cover.1542418936.git.tim.c.chen%40linux.intel.com (*) no code to implement STIBP sanely, no recommendation about turning SMT off at least for some workloads Thanks, -- Jiri Kosina SUSE Labs

Re: STIBP by default.. Revert?

2018-11-18 Thread Jiri Kosina
than turning SMT off, which might possibly have even *worse* performance numbers depending on workload. [1] https://lore.kernel.org/lkml/?q=cover.1542418936.git.tim.c.chen%40linux.intel.com (*) no code to implement STIBP sanely, no recommendation about turning SMT off at least for some workloads Thanks, -- Jiri Kosina SUSE Labs

Re: [Patch v5 12/16] x86/speculation: Create PRCTL interface to restrict indirect branch speculation

2018-11-17 Thread Jiri Kosina
uot;indirect branch predictions" in general terms, but really controls only the SMT aspect of it (STIBP), as quite confusing. So I believe it should either be renamed, or actually control semantics of IBPB as well, no? Thanks, -- Jiri Kosina SUSE Labs

Re: [Patch v5 12/16] x86/speculation: Create PRCTL interface to restrict indirect branch speculation

2018-11-17 Thread Jiri Kosina
uot;indirect branch predictions" in general terms, but really controls only the SMT aspect of it (STIBP), as quite confusing. So I believe it should either be renamed, or actually control semantics of IBPB as well, no? Thanks, -- Jiri Kosina SUSE Labs

Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

2018-11-17 Thread Jiri Kosina
indirect branch speculation via the > + PR_SET_SPECULATION_CTRL prctl(). Don't we also want to do the same for SECCOMP processess, analogically how we do it for SSBD? Thanks, -- Jiri Kosina SUSE Labs

Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

2018-11-17 Thread Jiri Kosina
indirect branch speculation via the > + PR_SET_SPECULATION_CTRL prctl(). Don't we also want to do the same for SECCOMP processess, analogically how we do it for SSBD? Thanks, -- Jiri Kosina SUSE Labs

Re: [Patch v5 00/16] Provide task property based options to enable Spectre v2 userspace-userspace protection

2018-11-17 Thread Jiri Kosina
t some of the lost performance back (I am pretty sure it will be taken for all -stable branches as well anyway). Thanks, -- Jiri Kosina SUSE Labs

Re: [Patch v5 00/16] Provide task property based options to enable Spectre v2 userspace-userspace protection

2018-11-17 Thread Jiri Kosina
t some of the lost performance back (I am pretty sure it will be taken for all -stable branches as well anyway). Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] l1tf: drop the swap storage limit restriction when l1tf=off

2018-11-13 Thread Jiri Kosina
o avoid any confusion (as otherwise the l1tf cmdline parameter is purely about hypervisor mitigations). With that Acked-by: Jiri Kosina Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] l1tf: drop the swap storage limit restriction when l1tf=off

2018-11-13 Thread Jiri Kosina
o avoid any confusion (as otherwise the l1tf cmdline parameter is purely about hypervisor mitigations). With that Acked-by: Jiri Kosina Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: hidraw: enforce minors_lock locking via lockdep

2018-11-12 Thread Jiri Kosina
On Fri, 9 Nov 2018, Benjamin Tissoires wrote: > On Thu, Nov 8, 2018 at 10:38 PM Jiri Kosina wrote: > > > > From: Jiri Kosina > > > > lockdep is much more powerful enforcing the locking rules than code > > comments, > > so let's switch to

Re: [PATCH] HID: hidraw: enforce minors_lock locking via lockdep

2018-11-12 Thread Jiri Kosina
On Fri, 9 Nov 2018, Benjamin Tissoires wrote: > On Thu, Nov 8, 2018 at 10:38 PM Jiri Kosina wrote: > > > > From: Jiri Kosina > > > > lockdep is much more powerful enforcing the locking rules than code > > comments, > > so let's switch to

Re: [PATCH v4 01/10] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-11-12 Thread Jiri Kosina
emoved. For kgdb, the return > > value can actually be used. > > Hm, this looks reasonable and good to me. > > Reviewed-by: Masami Hiramatsu Yes, I guess this is much better than putting the 'enforcement by comment' back in place :) Acked-by: Jiri Kosina Thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH v4 01/10] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-11-12 Thread Jiri Kosina
emoved. For kgdb, the return > > value can actually be used. > > Hm, this looks reasonable and good to me. > > Reviewed-by: Masami Hiramatsu Yes, I guess this is much better than putting the 'enforcement by comment' back in place :) Acked-by: Jiri Kosina Thanks. -- Jiri Kosina SUSE Labs

[PATCH] HID: hidraw: enforce minors_lock locking via lockdep

2018-11-08 Thread Jiri Kosina
From: Jiri Kosina lockdep is much more powerful enforcing the locking rules than code comments, so let's switch to it. Signed-off-by: Jiri Kosina --- drivers/hid/hidraw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c

[PATCH] HID: hidraw: enforce minors_lock locking via lockdep

2018-11-08 Thread Jiri Kosina
From: Jiri Kosina lockdep is much more powerful enforcing the locking rules than code comments, so let's switch to it. Signed-off-by: Jiri Kosina --- drivers/hid/hidraw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c

[GIT PULL] HID fixes

2018-11-07 Thread Jiri Kosina
wiht CONFIG_ASUS_WMI disabled Benjamin Tissoires (2): Revert "HID: add NOGET quirk for Eaton Ellipse MAX UPS" HID: alps: allow incoming reports when only the trackstick is opened Breno Leitao (1): HID: hiddev: fix potential Spectre v1 Jiri Kosina (1): HID: movin

[GIT PULL] HID fixes

2018-11-07 Thread Jiri Kosina
wiht CONFIG_ASUS_WMI disabled Benjamin Tissoires (2): Revert "HID: add NOGET quirk for Eaton Ellipse MAX UPS" HID: alps: allow incoming reports when only the trackstick is opened Breno Leitao (1): HID: hiddev: fix potential Spectre v1 Jiri Kosina (1): HID: movin

Re: [PATCH] HID: asus: fix build warning wiht CONFIG_ASUS_WMI disabled

2018-11-06 Thread Jiri Kosina
by WMI") > Signed-off-by: Arnd Bergmann Applied to for-4.20/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: asus: fix build warning wiht CONFIG_ASUS_WMI disabled

2018-11-06 Thread Jiri Kosina
by WMI") > Signed-off-by: Arnd Bergmann Applied to for-4.20/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v3 1/7] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-11-03 Thread Jiri Kosina
mmit. > > This partially reverts commit 9222f606506c ("x86/alternatives: > Lockdep-enforce text_mutex in text_poke*()") Alright, what can we do. It's probably better to have this, rather than to trying to work this around in kgdb to accomodate the rest of the world. > Cc: Jiri Kos

Re: [PATCH v3 1/7] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-11-03 Thread Jiri Kosina
mmit. > > This partially reverts commit 9222f606506c ("x86/alternatives: > Lockdep-enforce text_mutex in text_poke*()") Alright, what can we do. It's probably better to have this, rather than to trying to work this around in kgdb to accomodate the rest of the world. > Cc: Jiri Kos

Re: [PATCH v4 1/3] arm64: implement ftrace with regs

2018-10-31 Thread Jiri Kosina
we use '-pg -mfentry', to make sure we hook the function *before* prologue. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4 1/3] arm64: implement ftrace with regs

2018-10-31 Thread Jiri Kosina
we use '-pg -mfentry', to make sure we hook the function *before* prologue. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: moving to group maintainership model

2018-10-29 Thread Jiri Kosina
On Mon, 29 Oct 2018, Benjamin Tissoires wrote: > > From: Jiri Kosina > > Date: Sat, 27 Oct 2018 14:16:13 +0200 > > Subject: [PATCH] HID: moving to group maintainership model > > > > Benjamin and myself will from now on be sharing maintainership > > responsi

Re: [PATCH v2] HID: moving to group maintainership model

2018-10-29 Thread Jiri Kosina
On Mon, 29 Oct 2018, Benjamin Tissoires wrote: > > From: Jiri Kosina > > Date: Sat, 27 Oct 2018 14:16:13 +0200 > > Subject: [PATCH] HID: moving to group maintainership model > > > > Benjamin and myself will from now on be sharing maintainership > > responsi

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Jiri Kosina
indicated that Peter probably has found the issue in the code (failure to properly reset on direction change) that might be causing this. Adding to CC. Peter? Thanks, -- Jiri Kosina SUSE Labs

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Jiri Kosina
indicated that Peter probably has found the issue in the code (failure to properly reset on direction change) that might be causing this. Adding to CC. Peter? Thanks, -- Jiri Kosina SUSE Labs

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Jiri Kosina
ieve is a very noble and nice goal. But you really have to know at least a little bit who's there on the other end. Otherwise failure to communicate might be sort of inevitable. -- Jiri Kosina SUSE Labs

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Jiri Kosina
ieve is a very noble and nice goal. But you really have to know at least a little bit who's there on the other end. Otherwise failure to communicate might be sort of inevitable. -- Jiri Kosina SUSE Labs

Re: Another HID problem this merge window..

2018-10-27 Thread Jiri Kosina
tely escaped attention. That should never ever have been set to default y, I take blame for not noticing that while applying the patch. Thanks, -- Jiri Kosina SUSE Labs

Re: Another HID problem this merge window..

2018-10-27 Thread Jiri Kosina
tely escaped attention. That should never ever have been set to default y, I take blame for not noticing that while applying the patch. Thanks, -- Jiri Kosina SUSE Labs

Re: Oops in current tree in i2c

2018-10-27 Thread Jiri Kosina
improve I guess; will fix that next week. Benjamin, do you have something for that in place already? Thanks, -- Jiri Kosina SUSE Labs

Re: Oops in current tree in i2c

2018-10-27 Thread Jiri Kosina
improve I guess; will fix that next week. Benjamin, do you have something for that in place already? Thanks, -- Jiri Kosina SUSE Labs

[PATCH v2] HID: moving to group maintainership model

2018-10-27 Thread Jiri Kosina
From: Jiri Kosina Date: Sat, 27 Oct 2018 14:16:13 +0200 Subject: [PATCH] HID: moving to group maintainership model Benjamin and myself will from now on be sharing maintainership responsibilities for hid.git. Update maintainers to reflect that change, and also move a git repository to shared

[PATCH v2] HID: moving to group maintainership model

2018-10-27 Thread Jiri Kosina
From: Jiri Kosina Date: Sat, 27 Oct 2018 14:16:13 +0200 Subject: [PATCH] HID: moving to group maintainership model Benjamin and myself will from now on be sharing maintainership responsibilities for hid.git. Update maintainers to reflect that change, and also move a git repository to shared

[PATCH] HID: moving to group maintainership model

2018-10-27 Thread Jiri Kosina
From: Jiri Kosina Benjamin and myself will from now on be sharing maintainership responsibilities for hid.git. Update maintainers to reflect that change, and also move a git repository to shared space at kernel.org. Signed-off-by: Jiri Kosina --- Stephen, could you please update

[PATCH] HID: moving to group maintainership model

2018-10-27 Thread Jiri Kosina
From: Jiri Kosina Benjamin and myself will from now on be sharing maintainership responsibilities for hid.git. Update maintainers to reflect that change, and also move a git repository to shared space at kernel.org. Signed-off-by: Jiri Kosina --- Stephen, could you please update

Re: [PATCH] HID: alps: allow incoming reports when only the trackstick is opened

2018-10-26 Thread Jiri Kosina
; while keeping the trackstick active. > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1559632 > Link: https://gitlab.gnome.org/GNOME/mutter/issues/128 > Signed-off-by: Benjamin Tissoires Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: alps: allow incoming reports when only the trackstick is opened

2018-10-26 Thread Jiri Kosina
; while keeping the trackstick active. > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1559632 > Link: https://gitlab.gnome.org/GNOME/mutter/issues/128 > Signed-off-by: Benjamin Tissoires Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH 0/3] HID: debug: fix the ring buffer implementation

2018-10-26 Thread Jiri Kosina
modified kernel and fuzzer-reader > at: https://gist.github.com/nefigtut/33d56e3870b67493cc867344aed2a062 Vladis, thanks for cleaning it up. I actually like your rewrite quite a lot. Quick question -- how well was it tested in which scenarios? -- Jiri Kosina SUSE Labs

Re: [PATCH 0/3] HID: debug: fix the ring buffer implementation

2018-10-26 Thread Jiri Kosina
modified kernel and fuzzer-reader > at: https://gist.github.com/nefigtut/33d56e3870b67493cc867344aed2a062 Vladis, thanks for cleaning it up. I actually like your rewrite quite a lot. Quick question -- how well was it tested in which scenarios? -- Jiri Kosina SUSE Labs

Re: [PATCH] Revert "HID: add NOGET quirk for Eaton Ellipse MAX UPS"

2018-10-26 Thread Jiri Kosina
> Reported-by: Laurent Bigonville > Signed-off-by: Benjamin Tissoires Ok, fingers crossed. Applied, -- Jiri Kosina SUSE Labs

Re: [PATCH] Revert "HID: add NOGET quirk for Eaton Ellipse MAX UPS"

2018-10-26 Thread Jiri Kosina
> Reported-by: Laurent Bigonville > Signed-off-by: Benjamin Tissoires Ok, fingers crossed. Applied, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: i2c-hid: Add a small delay after sleep command for Raydium touchpanel

2018-10-26 Thread Jiri Kosina
; timeframe. So add a small delay to workaround the issue. > > Signed-off-by: Kai-Heng Feng > --- > v2: > - Use quirk to only match affected touchpanel > - Only delay the next power on if the time hasn't elapsed Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: i2c-hid: Add a small delay after sleep command for Raydium touchpanel

2018-10-26 Thread Jiri Kosina
; timeframe. So add a small delay to workaround the issue. > > Signed-off-by: Kai-Heng Feng > --- > v2: > - Use quirk to only match affected touchpanel > - Only delay the next power on if the time hasn't elapsed Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH AUTOSEL 4.4 08/65] btrfs: cleaner_kthread() doesn't need explicit freeze

2018-10-26 Thread Jiri Kosina
extent pages), so there is no need to leave any traces of > >> freezer in this kthread. > >> > >> Fixes: 80ad623edd2d ("Revert "btrfs: clear PF_NOFREEZE in > >> Fixes: cleaner_kthread()") > >> Fixes: 696249132158 ("btrfs: clear PF_NOFREEZE in cle

Re: [PATCH AUTOSEL 4.4 08/65] btrfs: cleaner_kthread() doesn't need explicit freeze

2018-10-26 Thread Jiri Kosina
extent pages), so there is no need to leave any traces of > >> freezer in this kthread. > >> > >> Fixes: 80ad623edd2d ("Revert "btrfs: clear PF_NOFREEZE in > >> Fixes: cleaner_kthread()") > >> Fixes: 696249132158 ("btrfs: clear PF_NOFREEZE in cle

Re: Is Fixes line enough?

2018-10-23 Thread Jiri Kosina
new PCI/USB/ACPI IDs or DMI quirks are usually accepted > into stable but normally lack "Fixes" tag. That could easily be made an easily identifiable exception to the rule though. -- Jiri Kosina SUSE Labs

Re: Is Fixes line enough?

2018-10-23 Thread Jiri Kosina
new PCI/USB/ACPI IDs or DMI quirks are usually accepted > into stable but normally lack "Fixes" tag. That could easily be made an easily identifiable exception to the rule though. -- Jiri Kosina SUSE Labs

[GIT PULL] HID for 4.20

2018-10-23 Thread Jiri Kosina
ble high-resolution scrolling on Logitech mice HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice Hong Liu (2): HID: intel-ish-hid: use resource-managed api HID: intel-ish-hid: using list_head for ipc write queue Jason Gerecke (1): HID: wacom: Work around HID descripto

[GIT PULL] HID for 4.20

2018-10-23 Thread Jiri Kosina
ble high-resolution scrolling on Logitech mice HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice Hong Liu (2): HID: intel-ish-hid: use resource-managed api HID: intel-ish-hid: using list_head for ipc write queue Jason Gerecke (1): HID: wacom: Work around HID descripto

Re: [PATCH v5 1/2] x86/speculation: apply IBPB more strictly to avoid cross-process data leak

2018-10-21 Thread Jiri Kosina
hat's currently being discussed) is eventually going to achieve. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v5 1/2] x86/speculation: apply IBPB more strictly to avoid cross-process data leak

2018-10-21 Thread Jiri Kosina
hat's currently being discussed) is eventually going to achieve. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: usbhid: Add quirk for Redragon/Dragonrise Seymur 2

2018-10-11 Thread Jiri Kosina
sue. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200995 > BugLink: https://bugs.launchpad.net/bugs/1793846 > Signed-off-by: Kai-Heng Feng Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: usbhid: Add quirk for Redragon/Dragonrise Seymur 2

2018-10-11 Thread Jiri Kosina
sue. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200995 > BugLink: https://bugs.launchpad.net/bugs/1793846 > Signed-off-by: Kai-Heng Feng Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: elan: fix spelling mistake "registred" -> "registered"

2018-10-09 Thread Jiri Kosina
return 0; > > if (!drvdata->input) { > - hid_err(hdev, "Input device is not registred\n"); > + hid_err(hdev, "Input device is not registered\n"); Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: elan: fix spelling mistake "registred" -> "registered"

2018-10-09 Thread Jiri Kosina
return 0; > > if (!drvdata->input) { > - hid_err(hdev, "Input device is not registred\n"); > + hid_err(hdev, "Input device is not registered\n"); Applied, thanks. -- Jiri Kosina SUSE Labs

[PATCH] HID: google: drop superfluous const before SIMPLE_DEV_PM_OPS()

2018-10-09 Thread Jiri Kosina
From: Jiri Kosina SIMPLE_DEV_PM_OPS() already implies const for the type; drop the extra modifier. Fixes: eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c ("HID: google: add support tablet mode switch for Whiskers") Signed-off-by: Jiri Kosina --- In hid.git#for-4.20/google drivers/hid/

[PATCH] HID: google: drop superfluous const before SIMPLE_DEV_PM_OPS()

2018-10-09 Thread Jiri Kosina
From: Jiri Kosina SIMPLE_DEV_PM_OPS() already implies const for the type; drop the extra modifier. Fixes: eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c ("HID: google: add support tablet mode switch for Whiskers") Signed-off-by: Jiri Kosina --- In hid.git#for-4.20/google drivers/hid/

Re: [PATCH v2 1/2] mfd: cros: add "base attached" MKBP switch definition

2018-10-09 Thread Jiri Kosina
okhov > > --- > > > > v2 changes: None > > > > Lee, I was wondering if it would be OK for cros_ec_commands.h to be > > merged through HID tree. > > Yes, so long as it goes through in this merge-window. > > Acked-by: Lee Jones Thanks; both patches now queued in hid.git#for-4.20/google -- Jiri Kosina SUSE Labs

Re: [PATCH v2 1/2] mfd: cros: add "base attached" MKBP switch definition

2018-10-09 Thread Jiri Kosina
okhov > > --- > > > > v2 changes: None > > > > Lee, I was wondering if it would be OK for cros_ec_commands.h to be > > merged through HID tree. > > Yes, so long as it goes through in this merge-window. > > Acked-by: Lee Jones Thanks; both patches now queued in hid.git#for-4.20/google -- Jiri Kosina SUSE Labs

Re: [POC][RFC][PATCH 1/2] jump_function: Addition of new feature "jump_function"

2018-10-08 Thread Jiri Kosina
y objtool at all anyway. -- Jiri Kosina SUSE Labs

Re: [POC][RFC][PATCH 1/2] jump_function: Addition of new feature "jump_function"

2018-10-08 Thread Jiri Kosina
y objtool at all anyway. -- Jiri Kosina SUSE Labs

Re: [PATCH v2] Input: reserve 2 events code because of HID

2018-10-04 Thread Jiri Kosina
ough your tree, as the input-event-codes > changes that introduce REL_WHEEL_HI_RES are in your for-4.20/logitech-highres. Applied, thanks Benjamin. -- Jiri Kosina SUSE Labs

Re: [PATCH v2] Input: reserve 2 events code because of HID

2018-10-04 Thread Jiri Kosina
ough your tree, as the input-event-codes > changes that introduce REL_WHEEL_HI_RES are in your for-4.20/logitech-highres. Applied, thanks Benjamin. -- Jiri Kosina SUSE Labs

Re: [PATCH V2] hid: hid-core: Fix a sleep-in-atomic-context bug in __hid_request()

2018-10-04 Thread Jiri Kosina
ge the two drivers, and explicitly anotate __hid_request() > with might_sleep(). Thanks. Are you planning to submit a patch to do that? -- Jiri Kosina SUSE Labs

Re: [PATCH V2] hid: hid-core: Fix a sleep-in-atomic-context bug in __hid_request()

2018-10-04 Thread Jiri Kosina
ge the two drivers, and explicitly anotate __hid_request() > with might_sleep(). Thanks. Are you planning to submit a patch to do that? -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: i2c-hid: Add a small delay after powering on/off the device

2018-10-03 Thread Jiri Kosina
g.\n"); > + else > + msleep(20); In case there really is no other way around it, at least please add comment explaining why this ugly msleep() is there. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: i2c-hid: Add a small delay after powering on/off the device

2018-10-03 Thread Jiri Kosina
g.\n"); > + else > + msleep(20); In case there really is no other way around it, at least please add comment explaining why this ugly msleep() is there. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] [v4] HID: add support for Apple Magic Trackpad 2

2018-10-03 Thread Jiri Kosina
B and bluetooth, putting > the device in multi-touch mode. Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] [v4] HID: add support for Apple Magic Trackpad 2

2018-10-03 Thread Jiri Kosina
B and bluetooth, putting > the device in multi-touch mode. Applied, thanks. -- Jiri Kosina SUSE Labs

[GIT PULL] HID fixes

2018-10-03 Thread Jiri Kosina
, 12 insertions(+), 18 deletions(-) -- Jiri Kosina SUSE Labs

[GIT PULL] HID fixes

2018-10-03 Thread Jiri Kosina
, 12 insertions(+), 18 deletions(-) -- Jiri Kosina SUSE Labs

Re: [PATCH 2/2] x86/speculation: Provide application property based STIBP protection

2018-10-02 Thread Jiri Kosina
ll probably agree. So > anyway, I encourage a pragmatic approach similar to that for SSBD. Which is what Tim's patchset is implementing on top. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 2/2] x86/speculation: Provide application property based STIBP protection

2018-10-02 Thread Jiri Kosina
ll probably agree. So > anyway, I encourage a pragmatic approach similar to that for SSBD. Which is what Tim's patchset is implementing on top. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH V2] hid: hid-core: Fix a sleep-in-atomic-context bug in __hid_request()

2018-09-29 Thread Jiri Kosina
ets on being able to allocate the buffer > > without sleeping, > > In my opinion, I prefer this way. Why? Forcing all the report buffer to be limited to be non-sleeping allocations just because of two drivers, looks like an overkill, and actually calls for more issues (as GFP_ATOMIC is of course in principle less likely to succeed). -- Jiri Kosina SUSE Labs

Re: [PATCH V2] hid: hid-core: Fix a sleep-in-atomic-context bug in __hid_request()

2018-09-29 Thread Jiri Kosina
ets on being able to allocate the buffer > > without sleeping, > > In my opinion, I prefer this way. Why? Forcing all the report buffer to be limited to be non-sleeping allocations just because of two drivers, looks like an overkill, and actually calls for more issues (as GFP_ATOMIC is of course in principle less likely to succeed). -- Jiri Kosina SUSE Labs

[tip:x86/pti] x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation

2018-09-26 Thread tip-bot for Jiri Kosina
Commit-ID: 53c613fe6349994f023245519265999eed75957f Gitweb: https://git.kernel.org/tip/53c613fe6349994f023245519265999eed75957f Author: Jiri Kosina AuthorDate: Tue, 25 Sep 2018 14:38:55 +0200 Committer: Thomas Gleixner CommitDate: Wed, 26 Sep 2018 14:26:52 +0200 x86/speculation

[tip:x86/pti] x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation

2018-09-26 Thread tip-bot for Jiri Kosina
Commit-ID: 53c613fe6349994f023245519265999eed75957f Gitweb: https://git.kernel.org/tip/53c613fe6349994f023245519265999eed75957f Author: Jiri Kosina AuthorDate: Tue, 25 Sep 2018 14:38:55 +0200 Committer: Thomas Gleixner CommitDate: Wed, 26 Sep 2018 14:26:52 +0200 x86/speculation

[tip:x86/pti] x86/speculation: Propagate information about RSB filling mitigation to sysfs

2018-09-26 Thread tip-bot for Jiri Kosina
Commit-ID: bb4b3b7762735cdaba5a40fd94c9303d9ffa147a Gitweb: https://git.kernel.org/tip/bb4b3b7762735cdaba5a40fd94c9303d9ffa147a Author: Jiri Kosina AuthorDate: Tue, 25 Sep 2018 14:39:28 +0200 Committer: Thomas Gleixner CommitDate: Wed, 26 Sep 2018 14:26:52 +0200 x86/speculation

<    1   2   3   4   5   6   7   8   9   10   >