On Wed, 2021-01-20 at 20:55 -0800, Bart Van Assche wrote:
> On 1/20/21 7:57 PM, Jiapeng Zhong wrote:
> > - return snprintf(buf, PAGE_SIZE, "%d.%02d.%02d (%x)\n",
> > + return sysfs_emit_at(buf, PAGE_SIZE, "%d.%02d.%02d (%x)\n",
> >
On Thu, 2021-01-21 at 11:29 +0800, ChunyouTang wrote:
> From: tangchunyou
>
> Increase maping spelling error check
Hi again. Thank you. I appreciate the addition.
Your word choice here is slightly odd English.
When you 'increase' a spelling error check, you might better use another
word
On Wed, 2021-01-20 at 19:56 +0100, Rafael J. Wysocki wrote:
> This series cleans up messaging in some source files under drivers/acpi/
> and get rids of some debug code pieces that aren't needed any more.
Thanks Rafael.
On Wed, 2021-01-20 at 18:23 +0530, Aditya wrote:
> On 20/1/21 2:51 pm, Joe Perches wrote:
> > On Wed, 2021-01-20 at 12:55 +0530, Aditya Srivastava wrote:
> > > Local symbols prefixed with '.L' do not emit symbol table entries, as
> > > they have special meaning for the
On Wed, 2021-01-20 at 14:15 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The CSR SiRF prima2/atlas platforms are getting removed, so this driver
> is no longer needed.
Should this platform really be removed?
While I followed the removal thread just a little,
isn't prima still in use
On Wed, 2021-01-20 at 12:55 +0530, Aditya Srivastava wrote:
> Local symbols prefixed with '.L' do not emit symbol table entries, as
> they have special meaning for the assembler.
>
> '.L' prefixed symbols can be used within a code region, but should be
> avoided for denoting a range of code via
On Mon, 2021-01-18 at 15:53 +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2021 at 12:34:28AM +, Daniel Scally wrote:
> > This driver only covered one scenario in which ACPI devices with _HID
> > INT3472 are found, and its functionality has been taken over by the
> > intel-skl-int3472 module,
On Mon, 2021-01-18 at 20:56 +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2021 at 10:43:14AM -0800, Joe Perches wrote:
> > On Mon, 2021-01-18 at 15:39 +0200, Andy Shevchenko wrote:
> > > On Mon, Jan 18, 2021 at 12:34:25AM +, Daniel Scally wrote:
> > > > We
On Mon, 2021-01-18 at 15:39 +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2021 at 12:34:25AM +, Daniel Scally wrote:
> > We want to refer to an i2c device by name before it has been
>
> I²C
Andy, are you next going to suggest renaming all the files with i2c?
$ git ls-files | grep i2c | wc
Improve the TYPECAST_INT_CONSTANT test by showing the suggested
conversion for various type of uses like (unsigned int)1 to 1U.
Signed-off-by: Joe Perches
---
Douglas Gilbert sent me a private email (and in that email said he
'loves to hate checkpatch' ;) complaining that checkpatch warned
On Mon, 2021-01-18 at 11:18 +0800, Chengyang Fan wrote:
> I'm doing the work.
Good, thank you.
> Should I submit patches individually or together?
I believe you should submit multiple patches, one for each subsystem.
For instance, a single patch should change all of:
>
On Mon, 2021-01-18 at 09:52 +0800, Chengyang Fan wrote:
> Remove superfluous semicolons after function definitions.
Are you intending to submit patches for all of these?
(there are probably many more)
$ git grep -P 'static\s+inline.*\(.*\)\s*\{\s*;?\s*\}\s*;' -- '*.[ch]'
w this hasn't been tested or
compiled in 5+ years...
commit 0fec65130b9f11a73d74f47025491f97f82ba070
Author: Joe Perches
Date: Tue May 5 10:06:06 2015 -0700
Acked-by: Joe Perches
> Signed-off-by: Tom Rix
> ---
> drivers/net/arcnet/com20020_cs.c | 2 +-
>
f03b01 ("RDMA: Convert various random sprintf sysfs _show uses to
sysfs_emit")
Reported-by: James Bottomley
Signed-off-by: Joe Perches
---
drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/usnic/u
On Fri, 2021-01-15 at 14:15 -0800, James Bottomley wrote:
> On Fri, 2021-01-15 at 13:23 -0800, Joe Perches wrote:
> > In commit e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs
> > _show
> > uses to sysfs_emit") I mistakenly used len = sysfs_emit_at to
>
ed. Do so.
Fixes: e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show uses to
sysfs_emit")
Reported-by: James Bottomley
Signed-off-by: Joe Perches
---
drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On Fri, 2021-01-15 at 09:10 +0100, Mauro Carvalho Chehab wrote:
> The phy USB3 driver for Hisilicon 970 (hi3670) is ready
> for mainstream. Mode it from staging into the main driver's
> phy/ directory.
[]
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml
>
On Thu, 2021-01-14 at 13:18 -0800, Linus Torvalds wrote:
> On Thu, Jan 14, 2021 at 11:52 AM Joe Perches wrote:
> >
> > Given the upgrade requirement, and how clang version requirements
> > constantly change, how much more difficult would it be for others
> > to use gc
On Thu, 2021-01-14 at 10:43 -0800, Linus Torvalds wrote:
> On Thu, Jan 14, 2021 at 12:18 AM Ard Biesheuvel wrote:
> >
> > So if the arguments are piling up, what is holding us back, other than
> > inertia?
>
> I think we can most certainly just try increasing the minimum version
> to 5.1 in the
On Thu, 2021-01-14 at 18:35 +0100, Mauro Carvalho Chehab wrote:
> Instead of using 1/0 for true/false, change the type to boolean
> and change the returned value.
[]
> diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
[]
> @@ -326,24 +326,24 @@
On Thu, 2021-01-14 at 09:57 +, Jankowski, Konrad0 wrote:
> > -Original Message-
> > From: Intel-wired-lan On Behalf Of Wei
> > Xu
[]
> > Use the ARRAY_SIZE macro to calculate the size of an array.
> > This code was detected with the help of Coccinelle.
[]
> > diff --git
On Thu, 2021-01-14 at 11:39 +0800, Leo Yan wrote:
> When sort on the respective metrics (lcl_hitm, rmt_hitm, tot_hitm),
> macro FILTER_HITM is to filter out the cache line entries if its
> overhead is less than 1%.
>
> This patch introduces static function filter_display() to replace macro;
> and
On Thu, 2021-01-14 at 02:57 +0900, Masahiro Yamada wrote:
> On Thu, Jan 14, 2021 at 1:08 AM Catalin Marinas
> wrote:
> >
> > On Tue, 12 Jan 2021 22:48:32 +, Will Deacon wrote:
> > > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references
> > > beyond the stack pointer,
commit 989e43c7ec34 ("mpt3sas: Added OEM Gen2 PnP ID branding names")
consolidated individual functions for OEM branding into a single function
but left a test for intel only at the top so no other vendor branding
was output. Remove the test.
Signed-off-by: Joe Perches
---
If no o
On Tue, 2021-01-12 at 17:40 +, Johannes Thumshirn wrote:
> On 12/01/2021 18:38, Joe Perches wrote:
> > static void
> > _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
> > {
> > + const char *b = NULL; /* brand */
> > + const char *v = NULL;
/mpt3sas_base.o.new
72285 88 288 72661 11bd5 drivers/scsi/mpt3sas/mpt3sas_base.o.old
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 144 ++--
1 file changed, 54 insertions(+), 90 deletions(-)
diff --git a/drivers/scsi/mpt3sas
On Mon, 2021-01-11 at 14:51 -0800, Ben Widawsky wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -4459,6 +4459,16 @@ F: fs/configfs/
> F: include/linux/configfs.h
> F: samples/configfs/
>
> +COMPUTE EXPRESS LINK (CXL)
> +M: Vishal Verma
> +M: Ira Weiny
> +M: Ben Widawsky
$line | cut -f1 -d':')
link=$(echo $line | cut -f2- -d':')
newlink=$(cvt_lkml_to_lore $link)
if [[ -n "$newlink" ]] ; then
sed -i -e "s#\b$link\b#$newlink#" $file
fi
done
Link: https://lore.kernel.org/patchwork/patch/1265849/#14626
Prefer using ftrace over function entry/exit logging messages.
Warn with various function entry/exit only logging that only
use __func__ with or without descriptive decoration.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 35 +++
1 file changed, 35
On Fri, 2021-01-08 at 10:53 +, Lee Jones wrote:
> On Fri, 08 Jan 2021, Zheng Yongjun wrote:
>
> You're still not using the correct subject format.
>
> It should be:
>
> "mfd: : Description starting with an uppercase char"
IMO: overly pedantic
On Thu, 2021-01-07 at 13:16 -0800, Kees Cook wrote:
> On Tue, Jan 05, 2021 at 01:28:18AM -0800, Joe Perches wrote:
> > On Tue, 2021-01-05 at 14:29 +0530, Dwaipayan Ray wrote:
> > > On Tue, Jan 5, 2021 at 2:14 PM Joe Perches wrote:
> > > >
> > > > On Tue
On Wed, 2021-01-06 at 22:36 +0300, Dan Carpenter wrote:
> On Wed, Jan 06, 2021 at 10:25:26AM -0800, Joe Perches wrote:
> > On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote:
> > > > On 06-Ja
On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote:
> Signed-off-by: Thomas Bogendoerfer
[]
> diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h
[]
> @@ -26,11 +26,6 @@
> * DMA channel.
> */
>
>
> -#ifdef CONFIG_MACH_TX49XX
> -static inline bool
On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote:
> > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote:
> > > > There is a debug message using hardcoded
On Wed, 2021-01-06 at 18:48 +0530, Bhaskar Chowdhury wrote:
> Good point Randy, there were several driver file witch have "defautly" in it
> and I tried to correct that.Only that spell made it a "de-faulty" as dic
> suggested . But I think it should be "by default" as you said.
What tool
On Wed, 2021-01-06 at 14:36 +0800, YANG LI wrote:
> The snprintf() function returns the number of characters which would
> have been printed if there were enough space, but the scnprintf()
> returns the number of characters which were actually printed. If the
> buffer is not large enough, then
On Tue, 2021-01-05 at 17:11 +0530, Bhaskar Chowdhury wrote:
> On 22:24 Tue 05 Jan 2021, Julian Calaby wrote:
> > Hi Bhaskar,
[]
> > and your change is just making this comment worse.
> really??? Not sure about it.
I agree with Julian. I'm fairly sure it's worse.
The change you suggest doesn't
On Tue, 2021-01-05 at 10:35 +, David Laight wrote:
> From: Joe Perches
> > Sent: 05 January 2021 10:01
> >
> > On Tue, 2021-01-05 at 15:05 +0530, Dwaipayan Ray wrote:
> > > Perl 5.22 onwards require that "A literal "{" should now be
> > >
On Tue, 2021-01-05 at 16:00 +0530, Dwaipayan Ray wrote:
> Indentations should use tabs wherever possible.
> Replace spaces by tabs for indents.
Thanks.
Acked-by: Joe Perches
>
> Signed-off-by: Dwaipayan Ray
> ---
> scripts/checkpatch.pl | 18 +-
&g
On Tue, 2021-01-05 at 15:05 +0530, Dwaipayan Ray wrote:
> Perl 5.22 onwards require that "A literal "{" should now be
> escaped in a pattern".
Not quite correct.
> checkpatch contains several literal "{". Fix such instances
> by preceding them with a backslash.
Not all literal left braces need
On Tue, 2021-01-05 at 14:29 +0530, Dwaipayan Ray wrote:
> On Tue, Jan 5, 2021 at 2:14 PM Joe Perches wrote:
> >
> > On Tue, 2021-01-05 at 13:53 +0530, Dwaipayan Ray wrote:
> > > strcpy() performs no bounds checking on the destination buffer.
> > > This could
On Mon, 2021-01-04 at 14:09 -0800, Joe Perches wrote:
> On Sun, 2021-01-03 at 08:50 +0100, Nicolai Fischer wrote:
> > Adds a new warning in case the indentation level of the
> > first line of a Kconfig help message is not at least two spaces
> > higher than the keyword it
On Tue, 2021-01-05 at 13:53 +0530, Dwaipayan Ray wrote:
> strcpy() performs no bounds checking on the destination buffer.
> This could result in linear overflows beyond the end of the buffer.
>
> strlcpy() reads the entire source buffer first. This read
> may exceed the destination size limit.
On Sun, 2021-01-03 at 08:50 +0100, Nicolai Fischer wrote:
> Adds a new warning in case the indentation level of the
> first line of a Kconfig help message is not at least two spaces
> higher than the keyword itself.
> Blank lines between the message and the help keyword
> are ignored.
>
>
q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/
Signed-off-by: Joe Perches
---
Resend adding alsa-devel as requested by Takashi Iwai
sound/aoa/codecs/onyx.c| 2 +-
sound/aoa/codecs/tas.c | 2 +-
sound/aoa/codecs/toonie.c | 2 +-
sound/aoa
e existing tests to avoid these false positives.
Miscellanea:
o Add volatile to $Attribute
This also reduces checkpatch runtime a bit by moving the indentation
comparison test to the start of the block to avoid multiple unnecessary
regex tests.
Signed-off-by: Joe Perches
---
scripts/checkpat
On Thu, 2020-12-31 at 23:04 +0100, Jonathan Neuschäfer wrote:
> Hi,
>
> I've encountered a case where the DT_SPLIT_BINDING_PATCH warning was
> emitted even though I didn't change anything outside of Documentation/
> devicetree/bindings. I just converted a binding from plain text to YAML.
Rob?
q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/
Signed-off-by: Joe Perches
---
sound/aoa/codecs/onyx.c| 2 +-
sound/aoa/codecs/tas.c | 2 +-
sound/aoa/codecs/toonie.c | 2 +-
sound/aoa/core/alsa.c | 8
sound/aoa/fabr
On Wed, 2020-12-30 at 14:36 +0100, Jan Schlien wrote:
> Hi,
>
> I found some odd behavior of checkpatch.pl, which I'm currently using
> for own projects outside the kernel, but I verified that kernel patches
> can be affected as well.
Hello Jan.
I've had this patch locally for awhile that I
/^.\s*\.\w+\s*=\s*.*\bNR_CPUS\b/)
> {
> WARN("NR_CPUS",
> "usage of NR_CPUS is often wrong - consider using
> cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" .
> $herecurr);
Thanks.
Acked-by: Joe Perches
On Wed, 2020-12-30 at 15:14 +0800, Peng Wang wrote:
> Some max_length wants to hold as large room as possible to
> ensure enough size to tackle with the biggest NR_CPUS.
> An example below:
>
> kernel/cgroup/cpuset.c:
> static struct cftype legacy_files[] = {
> {
> .name =
On Wed, 2020-12-30 at 14:41 +0800, YANG LI wrote:
> For safety, modify '%u' to '%d' to keep the type consistent.
There is no additional safety here.
The for loop ensures that i is positive as num_ioq_vector is also
int and so i can not be negative as it's incremented from 0.
> diff --git
On Wed, 2020-12-30 at 14:07 +0800, YANG LI wrote:
> The warning was because of the following line in function
> liquidio_set_fec():
>
> retval = wait_for_sc_completion_timeout(oct, sc, 0);
> if (retval)
> return (-EIO);
I presume abaci is a robot
Perhaps also the robot could look for
On Wed, 2020-12-30 at 12:13 +0800, Peng Wang wrote:
> Some max_length wants to hold as large room as possible to
> ensure enough size to tackle with the biggest NR_CPUS. As
> an example below:
>
> kernel/cgroup/cpuset.c:
> static struct cftype legacy_files[] = {
> {
>
On Fri, 2020-12-25 at 13:19 -0700, Jim Cromie wrote:
> Well, we're mostly overeating, but we can all look forward to a diet
> in January. And more exersize.
>
> dyndbg's compiled-in data-table currently uses 56 bytes per prdebug;
> this includes 3 pointers to hierarchical "decorator" data, which
On Tue, 2020-12-29 at 21:53 +0800, Zheng Yongjun wrote:
> Use kzalloc rather than kcalloc(1,...)
[]
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
[]
> @@ -1782,7 +1782,7 @@ static int
On Mon, 2020-12-28 at 15:09 +0100, Greg KH wrote:
> On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> > Fixed a checkpatch warning:
> >
> > WARNING: Block comments use * on subsequent lines
> > #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> >
On Mon, 2020-12-28 at 11:17 +0800, Zefan Li wrote:
> Those URLs are no longer accessable.
>
> Reported-by: Steve Wahl
> Signed-off-by: Zefan Li
> ---
> MAINTAINERS | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ae9b1dd748c4..2fe8eb54639e 100644
>
On Sat, 2020-12-26 at 09:10 -0800, Joe Perches wrote:
> Alphanumeric characters after vsprintf pointer extension %pI4 are
> not valid and are not emitted.
>
> Remove the invalid characters from the %pI4 uses.
self-nak. I believe I misunderstood the format specifier.
Alphanumeric characters after vsprintf pointer extension %pI4 are
not valid and are not emitted.
Remove the invalid characters from the %pI4 uses.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 6 +++---
drivers/net/ethernet/intel/i40e/i40e_main.c
On Sat, 2020-12-26 at 15:05 +0100, Nicolai Fischer wrote:
> Adds a new warning in case the indentation level of the
> first line of a Kconfig help message is not two spaces
> higher than the keyword itself.
> Blank lines between the message and the help keyword
> are ignored.
[]
> diff --git
On Fri, 2020-12-25 at 18:35 -0700, Nathan Chancellor wrote:
> Clang errors:
>
> ../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does
> not return a value [-Werror,-Wreturn-type]
> }
> ^
> ../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '('
>
On Fri, 2020-12-25 at 14:13 -0800, Tom Rix wrote:
> On 12/25/20 9:06 AM, Joe Perches wrote:
> > On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote:
> > > On 12/24/20 2:39 PM, Joe Perches wrote:
> > []
> > > > Kernel code doesn't use a signed char or short
On Fri, 2020-12-25 at 18:27 +0100, Nicolai Fischer wrote:
> On 12/21/20 6:17 PM, Joe Perches wrote:
[]
> > The message you used:
> > + WARN("CONFIG_DESCRIPTION",
> > + "help text is not inden
On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote:
> On 12/24/20 2:39 PM, Joe Perches wrote:
[]
> > Kernel code doesn't use a signed char or short with %hx or %hu very often
> > but in case you didn't already know, any signed char/short emitted with
> > anything like %hx or
On Thu, 2020-12-24 at 14:14 -0800, Tom Rix wrote:
> On 12/24/20 12:21 PM, Simon Horman wrote:
> > On Wed, Dec 23, 2020 at 12:20:53PM -0800, t...@redhat.com wrote:
> > > From: Tom Rix
> > >
> > > This change fixes the checkpatch warning described in this commit
> > > commit cbacb5ab0aa0 ("docs:
On Wed, 2020-12-23 at 21:22 +0100, Ayoub Soussi wrote:
> Fixed coding style issue.
[]
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
> b/drivers/staging/ralink-gdma/ralink-gdma.c
[]
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
> struct gdma_data *data;
> void __iomem *base;
>
On Tue, 2020-12-22 at 15:17 +0100, Michael Straube wrote:
> Add missing braces around else arm of if else statement to clear
> style issues reported by checkpatch.
>
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Unbalanced braces around else statement
[]
> diff --git
On Wed, 2020-12-23 at 12:33 -0800, Tom Rix wrote:
> On 12/23/20 12:14 PM, Joe Perches wrote:
> > On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote:
> > > From: Tom Rix
> > >
> > > This change fixes the checkpatch warning described in this commit
>
On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote:
> From: Tom Rix
>
> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]")
>
> Standard integer promotion is already
On Wed, 2020-12-23 at 02:50 +, patchwork-bot+netdev...@kernel.org
wrote:
> Hello:
>
> This patch was applied to netdev/net.git (refs/heads/master):
>
> On Sat, 19 Dec 2020 10:55:38 -0800 you wrote:
> > When searching for inactive maintainers it's useful to filter
> > out mailing list
Perhaps this on top.
trace isn't a good name as it's not a trace mechanism, it is a
typical debug mechanism.
Rename uvc_trace/uvc_trace_cont macros to uvc_dbg/uvc_dbg_cont.
Rename uvc_trace_param to uvc_dbg_param
Rename UVC_TRACE_ defines to UVC_DBG_
Use ## concatenation in uvc_dbg macros to
Prefer strscpy over the deprecated strlcpy function.
Requested-by: Andrew Morton
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 00085308ed9d..27679cc0ec17 100755
--- a/scripts
On Tue, 2020-12-22 at 14:12 +0100, Christoph Hellwig wrote:
> On Mon, Dec 21, 2020 at 08:08:20PM -0800, Joe Perches wrote:
> > On Thu, 2020-12-10 at 13:27 -0800, Joe Perches wrote:
> > > On Thu, 2020-12-10 at 20:09 +, Matthew Wilcox wrote:
> > > > On Thu, Dec 10,
The bt_dev_ macros already append a newline.
Signed-off-by: Joe Perches
---
The "No memory" message could be removed as bt_skb_alloc already does
a dump_stack() on allocation failure.
drivers/bluetooth/btusb.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
On Tue, 2020-12-22 at 09:52 +0100, Greg KH wrote:
> On Mon, Dec 21, 2020 at 08:25:47AM -0800, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > Attributing the function allows the compiler to more thoroughly
> > check the use of the function with -Wformat and similar flags.
> >
> >
On Thu, 2020-12-10 at 13:27 -0800, Joe Perches wrote:
> On Thu, 2020-12-10 at 20:09 +, Matthew Wilcox wrote:
> > On Thu, Dec 10, 2020 at 12:05:04PM -0800, Joe Perches wrote:
> > > Also, given the ever increasing average identifier length, strict
> > > adherence to 8
On Mon, 2020-12-21 at 08:25 -0800, t...@redhat.com wrote:
> From: Tom Rix
>
> Attributing the function allows the compiler to more thoroughly
> check the use of the function with -Wformat and similar flags.
>
> Signed-off-by: Tom Rix
> ---
> drivers/usb/musb/musb_debug.h | 1 +
> 1 file
On Mon, 2020-12-21 at 16:08 +0100, Nicolai Fischer wrote:
> On Sun, 2020-12-20 at 20:16 +0100, Joe Perches wrote:
> > On Mon, 2020-12-14 at 11:24 +0100, Nicolai Fischer wrote:
> > > Kconfig parsing does not recognise all type attributes.
> > > This adds the missing 'in
On Mon, 2020-12-14 at 11:24 +0100, Nicolai Fischer wrote:
> Kconfig parsing does not recognise all type attributes.
> This adds the missing 'int', 'sting' and 'hex' types.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3321,7 +3321,7 @@ sub process {
>
On Mon, 2020-12-14 at 11:24 +0100, Nicolai Fischer wrote:
> Kconfig parsing does not recognise all type attributes.
> This adds the missing 'int', 'sting' and 'hex' types.
>
> Signed-off-by: Nicolai Fischer
> Co-developed-by: Johannes Czekay
> Signed-off-by: Johannes Czekay
[]
> diff --git
y: Johannes Czekay
Acked-by: Joe Perches
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 52f467fd32f9..5cd98f2b75f6 100755
> --- a/scripts/checkpatch.pl
> +++ b/
On 2020-12-19 10:55, Jakub Kicinski wrote:
When searching for inactive maintainers it's useful to filter
out mailing list addresses. Such "maintainers" will obviously
never feature in a "From:" line of an email or a review tag.
Since "L:" entries only provide the address of a mailing list
On Fri, 2020-12-18 at 09:49 +, David Laight wrote:
> From: Joe Perches
> > Sent: 17 December 2020 23:58
> >
> > On Thu, 2020-12-17 at 15:45 -0800, Daniel West wrote:
> > > Fixed a coding style issue.
> >
> > It may pass checkpatch without warning,
On Thu, 2020-12-17 at 17:56 -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> The lkml.org, marc.info, spinics.net, etc archives are not quite as useful
> as lore.kernel.org because they use different styles, add advertising, and
> may disappear in the future. The lore archives are more
On Thu, 2020-12-17 at 15:45 -0800, Daniel West wrote:
> Fixed a coding style issue.
It may pass checkpatch without warning, but it's uncommon kernel coding style.
> diff --git a/drivers/staging/most/video/video.c
> b/drivers/staging/most/video/video.c
[]
> @@ -365,8 +365,8 @@ static const
Hello Anton.
I was looking around for bare inline uses and found this in
fs/ntfs/inode.[ch]:
$ git grep -w ntfs_new_extent_inode
fs/ntfs/inode.c:inline ntfs_inode *ntfs_new_extent_inode(struct super_block *sb,
fs/ntfs/inode.h:extern ntfs_inode *ntfs_new_extent_inode(struct super_block *sb,
On Thu, 2020-12-17 at 09:27 -0800, Linus Torvalds wrote:
> On Thu, Dec 17, 2020 at 8:25 AM Josh Poimboeuf wrote:
> >
> > Oh yeah, I forgot about that. That would be another option if my patch
> > doesn't work out.
>
> Well, one option is to just say "ok, we know gcc generates horrible
> code
On Thu, 2020-12-17 at 18:42 +0100, Helge Deller wrote:
> On 12/17/20 6:27 PM, Joe Perches wrote:
> > On Thu, 2020-12-17 at 18:11 +0100, Helge Deller wrote:
> > > In most cases people use lookup_symbol_name() to resolve a kernel symbol
> > > a
On Thu, 2020-12-17 at 18:11 +0100, Helge Deller wrote:
> In most cases people use lookup_symbol_name() to resolve a kernel symbol
> and then print it via printk().
>
> In such cases using the %ps, %pS, %pSR or %pB printk formats are easier
> to use and thus should be preferred.
[]
> diff --git
On Wed, 2020-12-16 at 21:15 +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
If you are going to submit patches for comma/semicolon conversions,
please to not use checkpatch to produce them.
checkpatch is a trivial tool that does not have very good
On Thu, 2020-12-17 at 19:12 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns for long line in commit messages even for
> URL lines.
>
> An evaluation over v4.13..v5.8 showed that out of ~11000 warnings for
> this class, around 790 are due to the line containing link.
>
> E.g. running
On Tue, 2020-12-15 at 13:33 -0800, t...@redhat.com wrote:
> From: Tom Rix
>
> See Documentation/core-api/printk-formats.rst.
>
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]")
>
> Standard integer promotion is already done and %hx
On Tue, 2020-12-15 at 06:24 -0800, t...@redhat.com wrote:
> From: Tom Rix
>
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
>
> Signed-off-by: Tom Rix
> ---
> drivers/atm/horizon.c | 6 +++---
Chas?
Madge has been out of
On Tue, 2020-12-15 at 07:18 +0200, Leon Romanovsky wrote:
> On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote:
> > I prefer revisions to single patches (as opposed to large patch series)
> > in the same thread.
>
> It depends which side you are in that game. Fr
On Mon, 2020-12-14 at 21:20 +0100, Bean Huo wrote:
> From: Bean Huo
>
> Current EM macro definition, we use stringize operator '#', which turns
> the argument it precedes into a quoted string. Thus requires the symbol
> of __print_symbolic() should be the string corresponding to the name of
>
On Mon, 2020-12-14 at 11:03 -0800, Jakub Kicinski wrote:
> On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote:
> > On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote:
> > > It is fix for semantic patch warning available in
> > > scripts/coccinelle/misc/boolinit.cocci
> > > Fix
On Mon, 2020-12-14 at 17:14 +0100, Bean Huo wrote:
> From: Bean Huo
>
> Current EM macro definition, we use stringize operator '#', which turns
> the argument it precedes into a quoted string. Thus requires the symbol
> of __print_symbolic() should be the string corresponding to the name of
>
On Mon, 2020-12-14 at 13:28 +0530, Dwaipayan Ray wrote:
> Analyzing misspellings over the past 10k commit messages,
> a few more corrections are added to spelling.txt
I don't agree with all of these.
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
[]
> @@ -1253,6 +1260,7 @@
On Sun, 2020-12-13 at 11:21 -0800, Tom Rix wrote:
> On 12/2/20 2:34 PM, Nick Desaulniers wrote:
> > On Tue, Nov 10, 2020 at 2:04 PM Joe Perches wrote:
> > > On Tue, 2020-11-10 at 14:00 -0800, Nick Desaulniers wrote:
> > >
> > > > Yeah, we could go through a
201 - 300 of 18599 matches
Mail list logo