On Sun, 2020-11-22 at 16:40 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns if logical continuations are placed at the
> start of a line and not at the end of previous line.
>
> E.g., running checkpatch on commit 3485507fc272 ("staging:
> bcm2835-camera: Reduce length of enum
On Sun, 2020-11-22 at 16:40 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns if logical continuations are placed at the
> start of a line and not at the end of previous line.
>
> E.g., running checkpatch on commit 3485507fc272 ("staging:
> bcm2835-camera: Reduce length of enum
On Sun, 2020-11-22 at 00:04 +0100, Marc Kleine-Budde wrote:
> On 11/21/20 8:50 PM, Joe Perches wrote:
> > > What about moving the default to the end if the case, which is more
> > > common anyways:
> > >
> > > diff --git a/drivers/net/can/usb/peak_usb/pcan_
On Sun, 2020-11-22 at 02:34 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns if logical continuations are placed at the
> start of a line and not at the end of previous line.
>
> E.g., running checkpatch on commit 3485507fc272 ("staging:
> bcm2835-camera: Reduce length of enum
On Sat, 2020-11-21 at 21:47 +0530, Dwaipayan Ray wrote:
> Provide fix option to INCLUDE_LINUX check to replace asm
> includes.
>
> Macros of type:
> #include
>
> are corrected to:
> #include
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -5468,8 +5468,11 @@ sub
On Sat, 2020-11-21 at 10:50 -0800, Guenter Roeck wrote:
> On Fri, Nov 20, 2020 at 12:36:04PM -0600, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the
On Sat, 2020-11-21 at 14:17 +0100, Marc Kleine-Budde wrote:
> On 11/20/20 7:34 PM, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the next case.
> >
On Sat, 2020-11-21 at 13:43 -0500, William Breathitt Gray wrote:
> Acked-by: Kamel Bouhara
> Signed-off-by: William Breathitt Gray
> ---
> Changes in v2:
> - Reorder section names alphabetically
> - Rename title to ARM/Microchip etc...
> - Add linux-arm-ker...@lists.infradead.org as mailing
On Sat, 2020-11-21 at 23:43 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns if logical continuations are placed at the
> start of a line and not at the end of previous line.
>
> E.g., running checkpatch on commit 3485507fc272 ("staging:
> bcm2835-camera: Reduce length of enum
On Sat, 2020-11-21 at 09:18 -0800, James Bottomley wrote:
> On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
> > A difficult part of automating commits is composing the subsystem
> > preamble in the commit log. For the ongoing effort of a fixer
> > producing one or two fixes a release
On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
> A difficult part of automating commits is composing the subsystem
> preamble in the commit log. For the ongoing effort of a fixer producing
> one or two fixes a release the use of 'treewide:' does not seem appropriate.
>
> It would be
On Sat, 2020-11-21 at 17:45 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns if logical continuations are placed at the
> start of a line and not at the end of previous line.
>
> E.g., running checkpatch on commit 3485507fc272 ("staging:
> bcm2835-camera: Reduce length of enum
On Sat, 2020-11-21 at 16:19 +, Jonathan Cameron wrote:
> On Mon, 16 Nov 2020 08:11:41 -0500
> William Breathitt Gray wrote:
>
> > Cc: Kamel Bouhara
> > Signed-off-by: William Breathitt Gray
> Purely for the record, Kamel, would you mind giving an
> Acked-by for this?
[]
> > diff --git
On Sat, 2020-11-21 at 17:34 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns us if an assignment operator is placed
> at the start of a line and not at the end of previous line.
Right, thanks.
Acked-by: Joe Perches
>
> E.g., running checkpatch on commit 8195b1396ec8
On Fri, 2020-11-20 at 17:28 -0600, Gustavo A. R. Silva wrote:
> On 11/20/20 17:18, Joe Perches wrote:
>
> > My preference would be to change these to break and not fallthrough;
>
> And my preference is fallthrough.
If so, that's an unusual choice here as it seems most o
On Fri, 2020-11-20 at 12:23 -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple fallthrough pseudo-keywords
> in places where the code is intended to fall through to the next
> case.
This is the first
Reduce code duplication and generic neatening of logging macros
Joe Perches (2):
scsi: pm8001: Neaten debug logging macros and uses
scsi: pm8001: Make implicit use of pm8001_ha in pm8001_printk explicit
drivers/scsi/pm8001/pm8001_ctl.c |7 +-
drivers/scsi/pm8001/pm8001_hwi.c | 1370
Make the pm8001_printk macro take an explicit HBA instead of
assuming the existence of an unspecified pm8001_ha argument
Miscellanea:
o Add pm8001_ha to the few uses of pm8001_printk
o Add HBA to the pm8001_dbg macro call to pm8001_printk
Signed-off-by: Joe Perches
---
drivers/scsi/pm8001
On Fri, 2020-11-20 at 12:21 -0600, Gustavo A. R. Silva wrote:
> Hi all,
>
> This series aims to fix almost all remaining fall-through warnings in
> order to enable -Wimplicit-fallthrough for Clang.
>
> In preparation to enable -Wimplicit-fallthrough for Clang, explicitly
> add multiple
On Fri, 2020-11-20 at 16:11 +0530, Aditya wrote:
> On 17/11/20 10:48 pm, Aditya Srivastava wrote:
> > Currently, checkpatch warns us if an assignment operator is placed
> > at the start of a line and not at the end of previous line.
> >
> > E.g., running checkpatch on commit 8195b1396ec8
On Thu, 2020-11-19 at 21:21 -0800, Jakub Kicinski wrote:
> We do have our own comment style rule in networking since the beginning
> of time, and reverse xmas tree, so it's not completely crazy.
reverse xmas tree is completely crazy.
But I posted a patch to checkpatch to suggest it for net/
and
On Thu, 2020-11-19 at 17:16 +0200, Andy Shevchenko wrote:
> On Thu, Nov 19, 2020 at 4:09 PM Alexandru Ardelean
> wrote:
> >
> > Hey,
> >
> > So, I stumbled on a new check that could be added to checkpatch.
> > Since it's in Perl, I'm reluctant to try it.
> >
> > Seems many drivers got to a
atch drivers containing XDP related bits.
>
> Previously Joe Perches suggested this pattern match,
> which I don't fully understand... could you explain Joe?
>
> (?:\b|_)xdp(?:\b|_)
This regex matches only:
xdp
xdp_
_xdp_
_xdp
> For the filename (N:
On Wed, 2020-11-18 at 23:24 -0800, Dmitry Torokhov wrote:
> Let's use BIT() macro instead of explicitly shifting '1'.
[]
> diff --git a/drivers/input/keyboard/adp5589-keys.c
> b/drivers/input/keyboard/adp5589-keys.c
> @@ -651,13 +652,13 @@ static int adp5589_setup(struct adp5589_kpad *kpad)
>
On Wed, 2020-11-18 at 20:01 -0800, Andersen, John wrote:
> I just noticed that patches which have "added, moved or deleted file(s)" and
> updated MAINTAINERS still trigger the following warning:
Please to not directly message me.
Send any questions to the lkml list and cc me.
On Thu, 2020-11-19 at 01:52 +0530, Dwaipayan Ray wrote:
> On Thu, Nov 19, 2020 at 1:28 AM Joe Perches wrote:
> > On Thu, 2020-11-19 at 00:15 +0530, Dwaipayan Ray wrote:
> > > On Thu, Nov 19, 2020 at 12:09 AM Joe Perches wrote:
> > > > On Thu, 2020-11-19 at 00
On Thu, 2020-11-19 at 00:15 +0530, Dwaipayan Ray wrote:
> On Thu, Nov 19, 2020 at 12:09 AM Joe Perches wrote:
> >
> > On Thu, 2020-11-19 at 00:03 +0530, Dwaipayan Ray wrote:
> > > On Wed, Nov 18, 2020 at 11:44 PM Joe Perches wrote:
> > > >
> > > &
On Thu, 2020-11-19 at 00:03 +0530, Dwaipayan Ray wrote:
> On Wed, Nov 18, 2020 at 11:44 PM Joe Perches wrote:
> >
> > On Wed, 2020-11-18 at 18:10 +0530, Dwaipayan Ray wrote:
> > > Brace style misuses of the following types are now
> > > corrected:
> > []
&
On Wed, 2020-11-18 at 18:10 +0530, Dwaipayan Ray wrote:
> Brace style misuses of the following types are now
> corrected:
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3937,9 +3937,23 @@ sub process {
> #print
>
On Wed, 2020-11-18 at 10:35 +0100, Uwe Kleine-König wrote:
> Actually I'd prefer keeping the symbolic name because this is easier to
> grep for. So to convince me a better reason than "checkpatch says so" is
> needed.
On Wed, 2020-11-18 at 11:58 -0500, Armin Gholampoor wrote:
> Fixed bracings for if statements
>
> Fixed spacings around operators
Do you really think this new code looks better:
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
[old]
static const unsigned char new_state[16] = {
/* current
On Wed, 2020-11-18 at 16:15 +0800, Tian Tao wrote:
> use kmem_cache_zalloc instead kmem_cache_alloc and memset.
[]
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
[]
> @@ -313,12 +313,10 @@ struct sk_buff *__build_skb(void *data, unsigned int
> frag_size)
> {
> struct sk_buff *skb;
>
On Wed, 2020-11-18 at 01:37 -0500, Armin Gholampoor wrote:
> Fixed bracing style issue.
>
> Signed-off-by: Armin Gholampoor
> ---
> net/ipv4/tcp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index b2bc3d7fe..37bc91e4a 100644
>
On Tue, 2020-11-17 at 10:09 -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break statements instead of
> letting the code fall through to the next case.
Thanks Gustavo.
I think this is better
On Tue, 2020-11-17 at 14:37 +0530, Dwaipayan Ray wrote:
> I have seen that
> the perl_version_ok check mandates perl 5.10 which was
> released more than 10 years back.
>
> Do you think that check could be removed completely?
> Maybe sometime in the future or just have it lay around
> for backward
On Tue, 2020-11-17 at 16:22 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns us if an assignment operator is placed
> at the start of a line and not at the end of previous line.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3542,8 +3542,14 @@ sub process {
>
On Mon, 2020-11-16 at 20:26 -0800, Joe Perches wrote:
> On Tue, 2020-11-17 at 09:35 +0530, Aditya Srivastava wrote:
> > Checkpatch expects entries in MAINTAINERS file in a specific order and
> > warns if the changes made do not follow the specified order.
> >
> &g
On Tue, 2020-11-17 at 09:35 +0530, Aditya Srivastava wrote:
> Checkpatch expects entries in MAINTAINERS file in a specific order and
> warns if the changes made do not follow the specified order.
>
> E.g., running checkpatch on commit b33bc2b878e0 ("nexthop: Add entry to
> MAINTAINERS") reports
AINTAINERS") reports this warning:
>
> WARNING: Misordered MAINTAINERS entry - list file patterns in
> alphabetic order
> +F: include/uapi/linux/nexthop.h
> +F: include/net/netns/nexthop.h
OK, this should work.
Thanks Aditya.
Acked-by: Joe Perches
>
> Provid
On Sun, 2020-11-15 at 19:43 -0800, Joe Perches wrote:
> On Mon, 2020-11-16 at 01:59 +0530, Dwaipayan Ray wrote:
> > There is an unescaped left brace in a regex in OPEN_BRACE
> > check. This throws a runtime error when checkpatch is run
> > with --fix flag and the OPEN_BR
On Mon, 2020-11-16 at 12:49 +0530, Aditya Srivastava wrote:
> Checkpatch expects entries in MAINTAINERS file in a specific order and
> warns if the changes made do not follow the specified order.
>
> E.g., running checkpatch on commit 6f736909f0a4 ("MAINTAINERS: Add
> patchwork link for PWM
mmonly this changelog would go below the --- separator line.
>
> Changes v6->v7:
> - Magic numbers removed and used IEEE80211 macors
> - usb.c is split into two files firmware.c and dbgfs.c
> - Other code style and timer function fixes (mod_timer)
> Changes v5->v6:
> - C
On Mon, 2020-11-16 at 14:07 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns us for long lines in commits even for
> signature tag lines.
Thanks Aditya.
Acked-by: Joe Perches
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2961,8 +2961,8 @@
On Mon, 2020-11-09 at 10:19 +0100, Lukas Bulwahn wrote:
> The two file patterns in the NETFILTER section:
>
> F: include/linux/netfilter*
> F: include/uapi/linux/netfilter*
>
> intended to match the directories:
>
> ./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
>
> A
; Fixes: 8d1824780f2f ("checkpatch: add --fix option for a couple OPEN_BRACE
> misuses")
> Signed-off-by: Dwaipayan Ray
Thanks Dwaipayan.
Obviously that code path hasn't been tested in awhile.
I think the notice to require an escape for a { was added back in
perl 5.16 or so.
Ack
On Sun, 2020-11-15 at 22:51 +, tip-bot2 for Helge Deller wrote:
> The following commit has been merged into the timers/core branch of tip:
>
> Commit-ID: da88f9b3113620dcd30fc203236aa53d5430ee98
> Gitweb:
> https://git.kernel.org/tip/da88f9b3113620dcd30fc203236aa53d5430ee98
>
On Fri, 2020-11-13 at 13:48 +, Lee Jones wrote:
> This patch fixes nearly 400 warnings!
>
> These structures are too widely used in too many varying
> configurations to be split-up into different headers or moved into
> source files.
>
> Instead, we'll mark them as __maybe_unused which tells
On Sun, 2020-11-15 at 18:56 +, tip-bot2 for Ira Weiny wrote:
> The following commit has been merged into the core/entry branch of tip:
[]
> s/assemenbly/assembly/
[]
> diff --git a/include/linux/entry-common.h b/include/linux/entry-common.h
[]
> @@ -438,7 +438,7 @@ irqentry_state_t noinstr
Convert the unbounded uses of sprintf to sysfs_emit.
A few conversions may now not end in a newline if the output buffer
is overflowed.
Signed-off-by: Joe Perches
---
v2: Add back missing test for page in slabs_cpu_partial_show()
mm/slub.c | 150
Use the sysfs_emit function instead of the sprintf family.
Done with cocci script as in commit 3c6bff3cf988
("RDMA: Convert sysfs kobject * show functions to use sysfs_emit()")
Signed-off-by: Joe Perches
---
mm/huge_memory.c | 28
mm/hugetlb.
-by: Joe Perches
---
mm/shmem.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 028f4596fc16..48bafe10c6c2 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -4047,7 +4047,7 @@ int __init shmem_init(void)
#if defined
Use the new sysfs_emit family and not the sprintf family.
V2: Correct missing page test defect in mm/slub.c slabs_cpu_partial_show()
Trivial update to commit message in mm: shmem
Joe Perches (5):
mm: Use sysfs_emit for struct kobject * uses
mm: huge_memory: Convert remaining use
Convert the only use of sprintf with struct kobject * that the cocci
script could not convert.
Miscellanea:
o Neaten the uses of a constant string with sysfs_emit to use a const
char * to reduce overall object size
Signed-off-by: Joe Perches
---
mm/huge_memory.c | 52
The cocci script used in commit bdacbb8d04f ("mm: Use sysfs_emit
for struct kobject * uses") does not convert the name##_show macro
because the macro uses concatenation via ##.
Convert it by hand.
Signed-off-by: Joe Perches
---
mm/backing-dev.c | 8
1 file changed, 4 insert
On Fri, 2020-11-13 at 18:00 +0100, Uwe Kleine-König wrote:
> On Fri, Nov 13, 2020 at 08:36:44AM -0800, Joe Perches wrote:
> > On Fri, 2020-11-13 at 10:11 +0100, Uwe Kleine-König wrote:
> > > Signed-off-by: Uwe Kleine-König
> > > ---
> > > Hello,
&g
On Fri, 2020-11-13 at 12:54 +0200, Sakari Ailus wrote:
> Hi Joe,
>
> On Tue, Nov 03, 2020 at 08:49:36AM -0800, Joe Perches wrote:
> > On Tue, 2020-11-03 at 16:56 +0200, Sakari Ailus wrote:
> > > On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote:
> > >
On Fri, 2020-11-13 at 10:11 +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König
> ---
> Hello,
>
> this can also be squashed into the respective patches instead.
>
> Best regards
> Uwe
>
> scripts/checkpatch.pl | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git
somehow evaluates to true on MSVC, but my godbolt link shows it does
> > not.
> >
> > Could the upstream ACPICA project be #define'ing something that could
> > be altering this? (Or not #define'ing something?)
> >
> > Worst case, we could do as Joe Perches su
On Fri, 2020-11-13 at 20:53 +0530, Dwaipayan Ray wrote:
> Delete repeated word in scripts/checkpatch.pl:
> "are are" -> "are"
>
> Fix typos:
> "commments" -> "comments"
> "falsly" -> "falsely"
>
> Sign
:
> https://github.com/0day-ci/linux/commits/Joe-Perches/mm-Convert-sysfs-sprintf-family-to-sysfs_emit/20201102-041456
[]
> on test machine: 8 threads Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz with 32G
> memory
>
> caused below changes (please refer to attached dmesg/kmsg for entir
On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> Delete repeated word in scripts/checkpatch.pl:
> "are are" -> "are"
>
> Fix typos:
> "commments" -> "comments"
> "falsly" -> "falsely"
>
> Signed-off-by: Dwaipayan Ray
> ---
style: this should have subject prefix:
"[PATCH V2]
On Thu, 2020-11-12 at 11:30 -0800, Nick Desaulniers wrote:
> On Thu, Nov 12, 2020 at 7:13 AM Moore, Robert wrote:
> > -Original Message-
> > From: Nick Desaulniers
> > On Wed, Nov 11, 2020 at 7:15 AM Moore, Robert
> > wrote:
> > > Yes, but: isn't the "fallthrough" keyword
On Wed, 2020-11-11 at 16:39 +0530, Aditya wrote:
> On 11/11/20 4:00 pm, Lukas Bulwahn wrote:
> > On Wed, Nov 11, 2020 at 10:01 AM Aditya Srivastava
> > wrote:
> > >
> > > Currently checkpatch warns us if there is no 'Signed-off-by' line
> > > for the patch.
> > >
> > > E.g., running checkpatch
On Tue, 2020-11-10 at 14:00 -0800, Nick Desaulniers wrote:
> Yeah, we could go through and remove %h and %hh to solve this, too, right?
Yup.
I think one of the checkpatch improvement mentees is adding
some suggestion and I hope an automated fix mechanism for that.
On Wed, 2020-11-11 at 00:36 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns us if there is no 'Signed-off-by' line
> for the patch.
trivial style and a comment:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2755,6 +2757,10 @@ sub process {
> if
On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote:
> This rfc will describe
> An upcoming treewide cleanup.
> How clang tooling was used to programatically do the clean up.
> Solicit opinions on how to generally use clang tooling.
>
> The clang warning -Wextra-semi-stmt produces about 10k
On Sat, 2020-11-07 at 00:11 -0800, Nick Desaulniers wrote:
> Clang is more aggressive about -Wformat warnings when the format flag
> specifies a type smaller than the parameter. Turns out, struct
> Scsi_Host's member can_queue is actually an int. Fixes:
>
> warning: format specifies type 'short'
On Sun, 2020-11-08 at 14:34 +0800, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> Fix the following coccinelle report:
>
> ./drivers/s390/net/qeth_l3_main.c:107:2-4: WARNING: possible condition with
> no effect (if == else)
>
> Both branches are the same, so remove them.
[]
> diff --git
On Sun, 2020-11-08 at 19:13 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns us if the author of the commit signs-off
> as co-developed-by.
[]
> A quick manual check found out that all fixes were correct in those
> cases.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
.org/lkml/20201108100632.75340-1-dwaipayanr...@gmail.com/T/#u
Thanks Dwaipayan.
Acked-by: Joe Perches
> Signed-off-by: Dwaipayan Ray
> ---
You should start to add changelog blocks to these
versioned patches so it's easier to look for what
changed between versions.
here...
> diff --git a/scr
On Sun, 2020-11-08 at 08:34 +0100, Lukas Bulwahn wrote:
> On Sat, 7 Nov 2020, Joe Perches wrote:
> > On Fri, 2020-11-06 at 23:55 -0800, Nick Desaulniers wrote:
> > > Clang is more aggressive about -Wformat warnings when the format flag
> > > specifies a type smaller
On Sat, 2020-11-07 at 20:54 +0800, Alex Shi wrote:
> 在 2020/11/7 上午12:39, Florian Fainelli 写道:
> > > It is good to remember that there are multiple readers of source
> > > files. There is the compiler which generates code from it, and there
> > > is the human trying to understand what is going on,
On Fri, 2020-11-06 at 23:55 -0800, Nick Desaulniers wrote:
> Clang is more aggressive about -Wformat warnings when the format flag
> specifies a type smaller than the parameter. Fixes 8 instances of:
>
> warning: format specifies type 'unsigned short' but the argument has
> type 'int' [-Wformat]
On Sat, 2020-11-07 at 10:11 +0530, Dwaipayan Ray wrote:
> On Sat, Nov 7, 2020 at 3:34 AM Joe Perches wrote:
> >
> > On Sat, 2020-11-07 at 03:15 +0530, Dwaipayan Ray wrote:
> > > checkpatch doesn't report warnings for many common mistakes
> > > in emails.
On Sat, 2020-11-07 at 03:15 +0530, Dwaipayan Ray wrote:
> checkpatch doesn't report warnings for many common mistakes
> in emails. Some of which are trailing commas and incorrect
> use of email comments.
Assuming it all works, this looks good. I haven't tested it.
How did you test the $fix
On Fri, 2020-11-06 at 13:32 -0800, Andrii Nakryiko wrote:
> On Thu, Nov 5, 2020 at 11:12 PM wrote:
> > Fix following warning from coccinelle:
> > ./tools/lib/bpf/libbpf.c:1478:43-48: WARNING: conversion to bool not needed
> > here
[]
> > diff --git a/tools/lib/bpf/libbpf.c
On Fri, 2020-11-06 at 16:28 +0800, Alex Shi wrote:
>
> 在 2020/11/6 下午2:36, Joe Perches 写道:
> > On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> > > There are some macros unused, they causes much gcc warnings. Let's
> > > remove them to tame gcc.
> >
> &
On Thu, 2020-11-05 at 23:26 -0800, Dmitry Torokhov wrote:
> On Wed, Nov 04, 2020 at 04:24:17PM +, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
> >
On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> There are some macros unused, they causes much gcc warnings. Let's
> remove them to tame gcc.
I believe these to be essentially poor warnings.
Aren't these warnings generated only when adding W=2 to the make
command line?
Perhaps it's better
On Fri, 2020-11-06 at 02:46 +0530, Dwaipayan Ray wrote:
> > Can you send me a file with the BAD_SIGN_OFF messages generated
> > and if possible the git SHA-1s of the commits?
> Yes sure, am attaching the file for data tested on about 27k commits
> from v5.4.
Thanks.
> Excluded the duplicate
On Wed, 2020-11-04 at 13:24 +0800, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> Fix the gcc warning:
>
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c:2673:9: warning: this
> 'for' clause does not guard... [-Wmisleading-indentation]
> 2673 | for (i = 0; i < n; ++i) \
On Thu, 2020-11-05 at 10:50 +0100, Ricardo Ribalda wrote:
> Hi Joe
Rehi Ricardo.
> On Thu, Nov 5, 2020 at 12:59 AM Joe Perches wrote:
> > It looks as if all the pr_cont uses in the code are odd and repetitive.
> >
> > Perhaps it'd be sensible to add something like:
(adding stable and Greg KH for additional review)
On Thu, 2020-11-05 at 17:29 +0530, Dwaipayan Ray wrote:
> checkpatch doesn't report warnings for many common mistakes
> in emails. Some of which are trailing commas and incorrect
> use of email comments.
I presume you've tested this against the
On Thu, 2020-11-05 at 07:44 +0100, Miguel Ojeda wrote:
> There are a few important new features:
https://clang.llvm.org/docs/ClangFormatStyleOptions.html
> - AlignConsecutiveMacros is probably one of the biggest one for the
> kernel that we were missing so far.
There's no control as to
On Thu, 2020-11-05 at 00:01 +0100, Ricardo Ribalda wrote:
> Hi Joe
>
> On Thu, Nov 5, 2020 at 12:00 AM Joe Perches wrote:
> >
> > On Wed, 2020-11-04 at 23:31 +0100, Ricardo Ribalda wrote:
> >
> > > I have updated my tree with the dev_ variants
> >
On Wed, 2020-11-04 at 23:31 +0100, Ricardo Ribalda wrote:
> I have updated my tree with the dev_ variants
>
> https://github.com/ribalda/linux/commit/b8785fd8efb4f2e5bbf5d0f2df3e0d69a5439015
I looked at this link and was confused so you made me look.
I think you meant:
On Wed, 2020-11-04 at 23:42 +0200, Laurent Pinchart wrote:
> Hi Joe,
Hi Laurent.
> On Wed, Nov 04, 2020 at 11:29:30AM -0800, Joe Perches wrote:
> > On Wed, 2020-11-04 at 19:07 +0100, Ricardo Ribalda wrote:
> > > Replace all the uses of printk(KERN_CONT ... with pr_cont().
&g
On Wed, 2020-11-04 at 19:07 +0100, Ricardo Ribalda wrote:
> Replace all the uses of printk(KERN_CONT ... with pr_cont().
Perhaps remove the uvc_printk macro and uses and use the more
common pr_fmt and pr_ mechanisms.
Something like:
---
drivers/media/usb/uvc/uvc_ctrl.c | 5 +++--
On Wed, 2020-11-04 at 16:48 +0100, Maximilian Luz wrote:
> On 11/4/20 6:13 AM, Joe Perches wrote:
>
> [...]
>
> > > Yes. I scanned drivers/acpi for trailing whitespaces after I noticed a
> > > couple of them. I did not explicitly scan for other stuff like spaces
&g
On Wed, 2020-11-04 at 10:16 +0100, Johan Hovold wrote:
> Running scrips/get_maintainer.pl on this series [1] gave the wrong
> address for Nick Desaulniers:
>
> Nick Desaulniers
> (commit_signer:1/2=50%,commit_signer:1/8=12%)
>
> It seems he recently misspelled his address in a
On Tue, 2020-11-03 at 22:30 +0100, Maximilian Luz wrote:
> On 11/3/20 10:12 PM, Bjorn Helgaas wrote:
> > On Mon, Nov 02, 2020 at 02:36:41PM +0100, Maximilian Luz wrote:
> > > Remove trailing whitespace and fix some whitespace inconsitencies while
> > > at it.
> >
> > I'm OK with this as long as
On Wed, 2020-11-04 at 04:57 +0100, Miguel Ojeda wrote:
> On Wed, Nov 4, 2020 at 4:15 AM Joe Perches wrote:
> >
> > No one ever will use clang-format on the current kernel sources
> > without having a recent version of clang and clang-format.
>
> Why? Many distros
On Wed, 2020-11-04 at 04:10 +0100, Miguel Ojeda wrote:
> On Wed, Nov 4, 2020 at 1:56 AM Joe Perches wrote:
> >
> > Do remember that this patch is for the current kernel and
> > not any old version that someone might be compiling.
> >
> > The current kernel _req
On Tue, 2020-11-03 at 17:08 -0800, Nick Desaulniers wrote:
> On Tue, Nov 3, 2020 at 1:33 PM Miguel Ojeda
> wrote:
> > On Tue, Nov 3, 2020 at 7:29 PM Joe Perches wrote:
> > >
> > > Now that the clang minimum supported version is > 10.0, enable the
> > &
On Tue, 2020-11-03 at 22:33 +0100, Miguel Ojeda wrote:
> It is, yeah; however, the concern is that there may be developers
> running an old clang-format from their distro (i.e. not using it for
> compiling the kernel).
I expect that'd be extremely unusual.
> We need to compare the functionality
On Tue, 2020-11-03 at 09:10 +0100, Lukas Bulwahn wrote:
> Maybe you can coordinate among each other who would want to create
> suitable fix rules here?
Yes please.
> Also, start with the class of the most frequent mistakes for
> unexpected content after email addresses.
>
> I imagine that a
Now that the clang minimum supported version is > 10.0, enable the
commented out conditional reformatting key:value lines in the file.
Signed-off-by: Joe Perches
---
Hey Miguel.
I don't use this, but on its face it seems a reasonable change
if the commented out key:value lines are corr
On Tue, 2020-11-03 at 16:56 +0200, Sakari Ailus wrote:
> On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote:
> > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > > pixel formats denoted by
On Tue, 2020-11-03 at 11:28 +0530, Dwaipayan Ray wrote:
> On Tue, Nov 3, 2020 at 11:18 AM Dwaipayan Ray wrote:
> >
> > checkpatch doesn't report warnings for many common mistakes
> > in emails. Some of which are trailing commas and incorrect
> > use of email comments.
> >
> > At the same time
On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> Andy brought to my attention the fact that users allocating an array of
> equally sized elements should check if the size multiplication doesn't
> overflow. This is why we have helpers like
401 - 500 of 18599 matches
Mail list logo
