Re: [PATCH v8 1/2] Added AMS tsl2591 driver implementation

On Sun, Apr 18, 2021 at 10:08:30AM +0100, Jonathan Cameron wrote: > On Fri, 16 Apr 2021 18:49:01 +0100 > Joe Sandom wrote: > > > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > > > This driver supports configuration via device tree and sysfs. >

Re: [PATCH v8 1/2] Added AMS tsl2591 driver implementation

On Sat, Apr 17, 2021 at 03:50:16PM +0300, Andy Shevchenko wrote: > On Fri, Apr 16, 2021 at 8:49 PM Joe Sandom wrote: > > > > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > > > This driver supports configuration via device tree and sysfs. >

[PATCH v8 1/2] Added AMS tsl2591 driver implementation

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet: https://ams.com/tsl25911#tab/documents Signed-off-by: Joe Sandom --- Changes in v8; - tsl2591_write_raw() - goto after tsl2591_set_als_gain_int_time() not

[PATCH v8 2/2] Added AMS tsl2591 device tree binding

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Signed-off-by: Joe Sandom Reviewed-by: Rob Herring --- Changes in v8: - No changes Notes: - Re-submitted to align the version with part 1 of the patch series .../bindings

[PATCH v7 1/2] Added AMS tsl2591 driver implementation

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet: https://ams.com/tsl25911#tab/documents Signed-off-by: Joe Sandom --- Changes in v7; - Revert back to using plain numbers in register defines instead of BIT and

[PATCH v7 2/2] Added AMS tsl2591 device tree binding

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Signed-off-by: Joe Sandom Reviewed-by: Rob Herring --- Changes in v7: - No changes Notes: - Re-submitted to align the version with part 1 of the patch series .../bindings

Re: [PATCH v6 1/2] Added AMS tsl2591 driver implementation

On Fri, Mar 26, 2021 at 01:01:57PM +0200, Andy Shevchenko wrote: > On Fri, Mar 26, 2021 at 12:05 AM Joe Sandom wrote: > > > > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > > > This driver supports configuration via device tree and sysfs. >

[RESEND][PATCH v6 2/2] Added AMS tsl2591 device tree binding

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet: https://ams.com/tsl25911#tab/documents Signed-off-by: Joe Sandom Reviewed-by: Rob Herring --- Changes in v6: - No changes Notes: - Re-submitted to align the

Re: [PATCH v6 2/2] Added AMS tsl2591 device tree binding

On Thu, Mar 25, 2021 at 05:43:43PM -0600, Rob Herring wrote: > On Thu, 25 Mar 2021 22:05:04 +0000, Joe Sandom wrote: > > Device tree binding for AMS/TAOS tsl2591 ambient light sensor. > > > > This driver supports configuration via device tree and sysfs. > > Supporte

[PATCH v6 1/2] Added AMS tsl2591 driver implementation

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet: https://ams.com/tsl25911#tab/documents Signed-off-by: Joe Sandom --- Changes in v6; - Separated tsl2591_set_als_thresholds into tsl2591_set_als_lower_threshold

[PATCH v6 2/2] Added AMS tsl2591 device tree binding

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet: https://ams.com/tsl25911#tab/documents Signed-off-by: Joe Sandom --- Changes in v6: - No changes Notes: - Re-submitted to align the version with part 1 of the

Re: [PATCH v5] Added AMS tsl2591 driver implementation

O Sat, Mar 13, 2021 at 07:15:54PM +, Jonathan Cameron wrote: > On Tue, 9 Mar 2021 01:17:15 + > Joe Sandom wrote: > > > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > > > This driver supports configuration via device tree and sysfs. >

[PATCH v5] Added AMS tsl2591 driver implementation

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet: https://ams.com/tsl25911#tab/documents Signed-off-by: Joe Sandom --- Changes in v5: - Added counterpart macro for integration time in ms to field value

Re: [RESEND][PATCH v4 1/2] Added AMS tsl2591 driver implementation

:12 +0000 > > Joe Sandom wrote: > > I will give my review on top of Jonathan's ones. > > ... > > > > Datasheet Available at: https://ams.com/tsl25911 > > Can we use Datasheet tag, please? > > Datasheet: > > > >

[RESEND][PATCH v4 2/2] Added AMS tsl2591 device tree binding

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet Available at: https://ams.com/tsl25911 Signed-off-by: Joe Sandom --- Changes in v4: - Corrected id field to include vendor name in prefix Notes: - Previously

[RESEND][PATCH v4 1/2] Added AMS tsl2591 driver implementation

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet Available at: https://ams.com/tsl25911 Signed-off-by: Joe Sandom --- Changes in v4: - Moved binding document to a separate patch and is now formed as a patch

[PATCH v4 2/2] Added AMS tsl2591 device tree binding

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet Available at: https://ams.com/tsl25911 Signed-off-by: Joe Sandom --- Changes in v4: - Corrected id field to include vendor name in prefix Notes: - Previously

[PATCH v4 1/2] Added AMS tsl2591 driver implementation

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet Available at: https://ams.com/tsl25911 Signed-off-by: Joe Sandom --- Changes in v4: - Moved binding document to a separate patch and is now formed as a patch

Re: [PATCH v3 RESEND] Added AMS tsl2591 driver implementation

On Sun, Feb 14, 2021 at 12:23:53PM +, Jonathan Cameron wrote: > On Sat, 13 Feb 2021 13:22:41 + > Joe Sandom wrote: > > > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > > > This driver supports configuration via device tree and sysfs. >

[PATCH v3 RESEND] Added AMS tsl2591 driver implementation

thresholds. This is a very-high sensitivity light-to-digital converter that transforms light intensity into a digital signal. Datasheet Available at: https://ams.com/tsl25911 Signed-off-by: Joe Sandom --- Changes in v3: - Cleaned up descriptions in binding file and Kconfig - Changed macros to be