Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Joerg Dorchain
On Wed, May 30, 2007 at 01:19:45PM +0200, Geert Uytterhoeven wrote: > > > Actually, this is the only way to define circular referencing > > structures. > > No, you have forward declarations for that. These are missing here. I am no gcc expert, but might this be considred an implicit

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Joerg Dorchain
On Wed, May 30, 2007 at 09:06:08AM +0200, Geert Uytterhoeven wrote: [...] > > > > > > I think it could be tightened up even if it happens not to warn? > > > > > > struct a { > > struct not_yet_defined *start, *end; > > }; > > > > struct not_yet_defined { > > void *foo; > > }; > > > >

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Joerg Dorchain
On Wed, May 30, 2007 at 09:06:08AM +0200, Geert Uytterhoeven wrote: [...] I think it could be tightened up even if it happens not to warn? struct a { struct not_yet_defined *start, *end; }; struct not_yet_defined { void *foo; }; Is a valid and gives no

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Joerg Dorchain
On Wed, May 30, 2007 at 01:19:45PM +0200, Geert Uytterhoeven wrote: Actually, this is the only way to define circular referencing structures. No, you have forward declarations for that. These are missing here. I am no gcc expert, but might this be considred an implicit declaration? IIRC

[Patch] bug in gdth.c crashing machine

2007-02-23 Thread Joerg Dorchain
2.6.20. Kind regards, Joerg Signed-off-by: Joerg Dorchain <[EMAIL PROTECTED]> --- gdth.c.orig 2007-02-23 12:48:56.0 +0100 +++ gdth.c 2007-02-23 12:51:44.0 +0100 @@ -3092,6 +3092,7 @@ cmdp->u.raw64.direction = gdth_direction_tab[scp

[Patch] bug in gdth.c crashing machine

2007-02-23 Thread Joerg Dorchain
regards, Joerg Signed-off-by: Joerg Dorchain [EMAIL PROTECTED] --- gdth.c.orig 2007-02-23 12:48:56.0 +0100 +++ gdth.c 2007-02-23 12:51:44.0 +0100 @@ -3092,6 +3092,7 @@ cmdp-u.raw64.direction = gdth_direction_tab[scp-cmnd[0]]==DOU

Re: Kbuild problem

2007-02-20 Thread Joerg Dorchain
On Tue, Feb 20, 2007 at 02:56:27PM +0100, Tilman Schmidt wrote: > > One disadvantage of this approach is that in a kernel with > > CONFIG_GIGASET_BASE=y, you can't later compile and load the usb_gigaset > > or ser_gigaset modules without rebooting since they require a change to > > the kernel

Re: Kbuild problem

2007-02-20 Thread Joerg Dorchain
On Tue, Feb 20, 2007 at 02:56:27PM +0100, Tilman Schmidt wrote: One disadvantage of this approach is that in a kernel with CONFIG_GIGASET_BASE=y, you can't later compile and load the usb_gigaset or ser_gigaset modules without rebooting since they require a change to the kernel image.