On Mon, 2017-02-27 at 10:31 +0200, Jonathan Dieter wrote:
> The usbip userspace tools call sprintf()/snprintf() and don't check for
> the return value which can lead the paths to overflow, truncating the
> final file in the path.
>
> More urgently, GCC 7 now warns that these
On Mon, 2017-02-27 at 10:31 +0200, Jonathan Dieter wrote:
> The usbip userspace tools call sprintf()/snprintf() and don't check for
> the return value which can lead the paths to overflow, truncating the
> final file in the path.
>
> More urgently, GCC 7 now warns that these
, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com>
Signed-off-by: Jonathan Dieter <jdie...@lesbg.com>
---
Chan
, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin
Signed-off-by: Jonathan Dieter
---
Changes since v3
* Cast sizeof to long unsigned when
.se...@gmail.com>
Signed-off-by: Jonathan Dieter <jdie...@lesbg.com>
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip
-by: Jonathan Dieter
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char
, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com>
Signed-off-by: Jonathan Dieter <jdie...@lesbg.com>
---
Chan
.se...@gmail.com>
Signed-off-by: Jonathan Dieter <jdie...@lesbg.com>
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip
, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin
Signed-off-by: Jonathan Dieter
---
Changes since v2
* Converted size back to int because
-by: Jonathan Dieter
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char
On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote:
> Hi,
>
> W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze:
> > char busid[SYSFS_BUS_ID_SIZE];
> > + unsigned int size;
>
> I'm not really convinced to use unsigned here. snprintf() is declared
> to
On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote:
> Hi,
>
> W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze:
> > char busid[SYSFS_BUS_ID_SIZE];
> > + unsigned int size;
>
> I'm not really convinced to use unsigned here. snprintf() is declared
> to
, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com>
Signed-off-by: Jonathan Dieter <jdie...@lesbg.com>
---
too
, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin
Signed-off-by: Jonathan Dieter
---
tools/usb/usbip/libsrc/usbip_common.c | 8
.se...@gmail.com>
Signed-off-by: Jonathan Dieter <jdie...@lesbg.com>
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip
-by: Jonathan Dieter
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char
On Tue, 2017-02-21 at 08:48 +0200, Jonathan Dieter wrote:
> On Tue, 2017-02-21 at 07:12 +0100, Krzysztof Opasiak wrote:
> > Hi,
> >
> > W dniu 2017-02-20 o 21:51, Jonathan Dieter pisze:
> > > + err("busid length %i >= SYSFS_BUS_ID_SIZE",
>
On Tue, 2017-02-21 at 08:48 +0200, Jonathan Dieter wrote:
> On Tue, 2017-02-21 at 07:12 +0100, Krzysztof Opasiak wrote:
> > Hi,
> >
> > W dniu 2017-02-20 o 21:51, Jonathan Dieter pisze:
> > > + err("busid length %i >= SYSFS_BUS_ID_SIZE",
>
Thanks for looking at this. One quick question before I put out
version two with your corrections:
On Tue, 2017-02-21 at 07:12 +0100, Krzysztof Opasiak wrote:
> Hi,
>
> W dniu 2017-02-20 o 21:51, Jonathan Dieter pisze:
> > The usbip userspace tools call sprintf()/snprintf()
Thanks for looking at this. One quick question before I put out
version two with your corrections:
On Tue, 2017-02-21 at 07:12 +0100, Krzysztof Opasiak wrote:
> Hi,
>
> W dniu 2017-02-20 o 21:51, Jonathan Dieter pisze:
> > The usbip userspace tools call sprintf()/snprintf()
.se...@gmail.com>
Signed-off-by: Jonathan Dieter <jdie...@lesbg.com>
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip
, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com>
Signed-off-by: Jonathan Dieter <jdie...@lesbg.com>
---
too
-by: Jonathan Dieter
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char
, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin
Signed-off-by: Jonathan Dieter
---
tools/usb/usbip/libsrc/usbip_common.c | 8
24 matches
Mail list logo