Re: [PATCH] drm/rockchip: Cope with endpoints that haven't been registered yet

2021-04-16 Thread Jonathan McDowell
On Sun, Mar 21, 2021 at 07:58:13PM +0100, Heiko Stuebner wrote: > Am Dienstag, 16. März 2021, 19:27:53 CET schrieb Jonathan McDowell: > > The Rockchip RGB CRTC output driver attempts to avoid probing Rockchip > > subdrivers to see if they're a connected panel or bridge. However

[PATCH] drm/rockchip: Cope with endpoints that haven't been registered yet

2021-03-16 Thread Jonathan McDowell
-by: Jonathan McDowell --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 8 ++-- drivers/gpu/drm/rockchip/rockchip_rgb.c | 7 --- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c

[PATCH net-next] net: stmmac: Set FIFO sizes for ipq806x

2021-03-13 Thread Jonathan McDowell
the larger MTU required to support this.) Signed-off-by: Jonathan McDowell --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq80

Re: PGP pathfinder service is no longer maintained

2020-12-17 Thread Jonathan McDowell
In article <20201216224344.h3r7wbo7fgatupm5@chatter.i7.local> (earth.lists.linux-kernel) you wrote: > On Wed, Dec 16, 2020 at 10:20:18PM +, Matthew Wilcox wrote: > > > Unfortunately the site https://pgp.cs.uu.nl/ is not maintained > > > anymore > > > and the "Finding paths to Linus" link

Re: [PATCH] dt-bindings: dmaengine: Convert Qualcomm ADM bindings to yaml

2020-12-10 Thread Jonathan McDowell
On Mon, Dec 07, 2020 at 01:12:22PM -0600, Rob Herring wrote: > On Sun, Nov 15, 2020 at 06:12:42PM +0000, Jonathan McDowell wrote: > > Converts the device tree bindings for the Qualcomm Application Data > > Mover (ADM) DMA controller over to YAML schemas. > > > > Signe

Re: [PATCH] ARM: dts: qcom: add prng definition to ipq806x

2020-11-29 Thread Jonathan McDowell
Gentle poke; did this just get missed or is there some reason not to apply it? On Sun, Jul 05, 2020 at 03:25:44PM +0100, Jonathan McDowell wrote: > Add missing prng definition for ipq806x SoC > > Signed-off-by: Jonathan McDowell > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 7 ++

[PATCH] dmaengine: qcom: Fix ADM driver kerneldoc markup

2020-11-26 Thread Jonathan McDowell
' not described in 'adm_start_dma' Signed-off-by: Jonathan McDowell --- drivers/dma/qcom/qcom_adm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c index 9b6f8e050ecc..ee78bed8d60d 100644 --- a/drivers/dma/qcom

[PATCH] dt-bindings: dmaengine: Convert Qualcomm ADM bindings to yaml

2020-11-15 Thread Jonathan McDowell
Converts the device tree bindings for the Qualcomm Application Data Mover (ADM) DMA controller over to YAML schemas. Signed-off-by: Jonathan McDowell --- .../devicetree/bindings/dma/qcom,adm.yaml | 102 ++ .../devicetree/bindings/dma/qcom_adm.txt | 61 --- 2

[PATCH v5] dmaengine: qcom: Add ADM driver

2020-11-14 Thread Jonathan McDowell
COMPILE_TEST coverage without having to spend effort on kludging things in the code that will never actually be needed on real hardware. Signed-off-by: Andy Gross Signed-off-by: Thomas Pedersen Signed-off-by: Jonathan McDowell (I'm not sure how best to attribute this. It's originally from Andy Gross

Re: [PATCH v4] dmaengine: qcom: Add ADM driver

2020-11-09 Thread Jonathan McDowell
On Mon, Nov 09, 2020 at 05:11:21PM +0530, Vinod Koul wrote: > HI Jonathan, > > On 23-09-20, 20:40, Jonathan McDowell wrote: > > Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA > > controller found in the MSM8x60 and IPQ/APQ8064 platforms. > >

[PATCH net] net: dsa: qca8k: Fix port MTU setting

2020-10-30 Thread Jonathan McDowell
kernel.org Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 53064e0e1618..5bdac669a339 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c

Re: [PATCH v4] dmaengine: qcom: Add ADM driver

2020-10-25 Thread Jonathan McDowell
Gentle ping on this one; looks like I missed the window for 5.10, but is there anything outstanding for it to hit 5.11 or should I just have patience? On Wed, Sep 23, 2020 at 08:40:56PM +0100, Jonathan McDowell wrote: > Add the DMA engine driver for the QCOM Application Data Mover (ADM)

[PATCH v4] dmaengine: qcom: Add ADM driver

2020-09-23 Thread Jonathan McDowell
for transactions to/from peripheral devices. The initial release of this driver supports slave transfers to/from peripherals and also incorporates CRCI (client rate control interface) flow control. Signed-off-by: Andy Gross Signed-off-by: Thomas Pedersen Signed-off-by: Jonathan McDowell (I'm not sure

[PATCH v3] dmaengine: qcom: Add ADM driver

2020-09-20 Thread Jonathan McDowell
for transactions to/from peripheral devices. The initial release of this driver supports slave transfers to/from peripherals and also incorporates CRCI (client rate control interface) flow control. Signed-off-by: Andy Gross Signed-off-by: Thomas Pedersen Signed-off-by: Jonathan McDowell (I'm not sure

[PATCH v2] dmaengine: qcom: Add ADM driver

2020-09-19 Thread Jonathan McDowell
for transactions to/from peripheral devices. The initial release of this driver supports slave transfers to/from peripherals and also incorporates CRCI (client rate control interface) flow control. Signed-off-by: Andy Gross Signed-off-by: Thomas Pedersen Signed-off-by: Jonathan McDowell (I'm not sure

Re: [PATCH] dmaengine: qcom: Add ADM driver

2020-09-18 Thread Jonathan McDowell
On Fri, Sep 18, 2020 at 05:04:43PM +0530, Vinod Koul wrote: > Hello Jonathan > > On 16-09-20, 07:43, Jonathan McDowell wrote: > > From: Andy Gross > > > > (I'm not sure how best to attribute this. It's originally from Andy > > Gross, the version I picked u

[PATCH] dmaengine: qcom: Add ADM driver

2020-09-16 Thread Jonathan McDowell
interface) flow control. Signed-off-by: Andy Gross Signed-off-by: Thomas Pedersen Signed-off-by: Jonathan McDowell diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig index 3bcb689162c6..75ee112ccea9 100644 --- a/drivers/dma/qcom/Kconfig +++ b/drivers/dma/qcom/Kconfig @@ -28,3

Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-08-14 Thread Jonathan McDowell
On Fri, Aug 14, 2020 at 11:20:54AM +0300, Vadym Kochan wrote: > On Thu, Aug 13, 2020 at 09:03:22AM +0100, Jonathan McDowell wrote: > > On Mon, Jul 27, 2020 at 03:22:37PM +0300, Vadym Kochan wrote: > > > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > >

Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-08-13 Thread Jonathan McDowell
On Mon, Jul 27, 2020 at 03:22:37PM +0300, Vadym Kochan wrote: > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely > wireless SMB deployment. > > The current implementation supports only boards designed for the

[PATCH net 2/2] net: ethernet: stmmac: Disable hardware multicast filter

2020-08-12 Thread Jonathan McDowell
to receiving all multicast packets, internally setting ALLMULTI. Use the new fallback support in the dwmac1000 driver to correctly achieve the same with the mainline IPQ806x driver. Confirmed to fix IPv6 functionality on an RB3011 router. Cc: sta...@vger.kernel.org Signed-off-by: Jonathan

[PATCH net 1/2] net: stmmac: dwmac1000: provide multicast filter fallback

2020-08-12 Thread Jonathan McDowell
-by: Jonathan McDowell --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c index efc6ec1b8027..fc8759f146c7 100644 --- a/drivers/net

[PATCH net 0/2] net: stmmac: Fix multicast filter on IPQ806x

2020-08-12 Thread Jonathan McDowell
of the vendor driver (nss-gmac from the qsdk) shows that it does not enable the multicast filter and instead falls back to allmulti. Extend the base dwmac1000 driver to fall back when there's no suitable hardware filter, and update the ipq806x platform to request this. Jonathan McDowell (2

[PATCH net-next v3 2/2] net: dsa: qca8k: Add 802.1q VLAN support

2020-08-01 Thread Jonathan McDowell
correctly treats this as no tag Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 181 drivers/net/dsa/qca8k.h | 27 ++ 2 files changed, 208 insertions(+) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 3ebc4da63074

[PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID

2020-08-01 Thread Jonathan McDowell
Rather than using a magic value of 1 when configuring the port VIDs add a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the bitmask in the process; the top 4 bits are reserved so this wasn't a problem, but only masking 12 bits is the correct approach. Signed-off-by: Jonathan

Re: [PATCH net-next v2] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-30 Thread Jonathan McDowell
On Tue, Jul 28, 2020 at 07:34:57PM +0300, Vladimir Oltean wrote: > Hi Jonathan, > > On Sun, Jul 26, 2020 at 03:56:11PM +0100, Jonathan McDowell wrote: > > This adds full 802.1q VLAN support to the qca8k, allowing the use of > > vlan_filtering and more complicated bridgin

[PATCH net-next v2] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-26 Thread Jonathan McDowell
sensible errnos on failure rather than -1 (rmk) - Style cleanups based on Florian's feedback - Silently allow VLAN 0 as device correctly treats this as no tag Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 191 ++-- drivers/net/dsa/qca8k.h | 28

Re: [RFC PATCH] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-25 Thread Jonathan McDowell
On Thu, Jul 23, 2020 at 01:58:47AM +0300, Vladimir Oltean wrote: > On Wed, Jul 22, 2020 at 03:36:38PM -0700, Florian Fainelli wrote: > > On 7/22/20 12:38 PM, Jonathan McDowell wrote: > > > On Tue, Jul 21, 2020 at 10:26:07AM -0700, Florian Fainelli wrote: > > >>

Re: [RFC PATCH] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-22 Thread Jonathan McDowell
On Tue, Jul 21, 2020 at 10:26:07AM -0700, Florian Fainelli wrote: > On 7/21/20 10:16 AM, Jonathan McDowell wrote: > > This adds full 802.1q VLAN support to the qca8k, allowing the use of > > vlan_filtering and more complicated bridging setups than allowed by > > ba

Re: [RFC PATCH] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-22 Thread Jonathan McDowell
On Tue, Jul 21, 2020 at 09:48:18PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Jul 21, 2020 at 06:16:24PM +0100, Jonathan McDowell wrote: > > This adds full 802.1q VLAN support to the qca8k, allowing the use of > > vlan_filtering and more complicated bridging setu

[RFC PATCH] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-21 Thread Jonathan McDowell
-by: Jonathan McDowell diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index a5566de82853..cce05493075f 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -408,6 +408,104 @@ qca8k_fdb_flush(struct qca8k_priv *priv) mutex_unlock(>reg_mutex); } +static

[PATCH v2] net: dsa: qca8k: implement the port MTU callbacks

2020-07-18 Thread Jonathan McDowell
This switch has a single max frame size configuration register, so we track the requested MTU for each port and apply the largest. v2: - Address review feedback from Vladimir Oltean Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 31 +++ drivers/net

Re: [PATCH] net: dsa: qca8k: implement the port MTU callbacks

2020-07-18 Thread Jonathan McDowell
On Sat, Jul 18, 2020 at 01:38:08PM +0300, Vladimir Oltean wrote: > On Sat, Jul 18, 2020 at 10:35:55AM +0100, Jonathan McDowell wrote: > > This switch has a single max frame size configuration register, so we > > track the requested MTU for each port and apply the largest. >

[PATCH] net: dsa: qca8k: implement the port MTU callbacks

2020-07-18 Thread Jonathan McDowell
This switch has a single max frame size configuration register, so we track the requested MTU for each port and apply the largest. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 38 ++ drivers/net/dsa/qca8k.h | 3 +++ 2 files changed, 41

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-17 Thread Jonathan McDowell
On Fri, Jul 17, 2020 at 01:38:22AM +0300, Vladimir Oltean wrote: > On Thu, Jul 16, 2020 at 03:09:25PM -0700, Jakub Kicinski wrote: > > On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: > > > +- qca,sgmii-rxclk-falling-edge: If present, sets receive clock phase to > > > +

[PATCH] ARM: dts: qcom: add prng definition to ipq806x

2020-07-05 Thread Jonathan McDowell
Add missing prng definition for ipq806x SoC Signed-off-by: Jonathan McDowell --- arch/arm/boot/dts/qcom-ipq8064.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi index b912da9a3ff3..22e0669b9133 100644

[PATCH] firmware: qcom_scm: Fix legacy convention SCM accessors

2020-07-04 Thread Jonathan McDowell
;) Cc: sta...@vger.kernel.org Signed-off-by: Jonathan McDowell --- drivers/firmware/qcom_scm.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 0e7233a20f34..d4fda210adfe 100644 --- a/drivers/firmware/qcom_scm.c +++ b/driver

[PATCH net-next v5 2/3] net: dsa: qca8k: Improve SGMII interface handling

2020-06-20 Thread Jonathan McDowell
it is enabled. Tested with a device where the CPU connection is RGMII (i.e. the common current use case) + one where the CPU connection is SGMII. I don't have any devices where the SGMII interface is brought out to something other than the CPU. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c

[PATCH net-next v5 3/3] net: dsa: qca8k: Minor comment spelling fix

2020-06-20 Thread Jonathan McDowell
Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 11d1c290d90f..4acad5fa0c84 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -647,7 +647,7

[PATCH net-next v5 1/3] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-20 Thread Jonathan McDowell
Update the driver to use the new PHYLINK callbacks, removing the legacy adjust_link callback. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 306 +++- 1 file changed, 210 insertions(+), 96 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b

[PATCH net-next v5 0/3] net: dsa: qca8k: Improve SGMII interface handling

2020-06-20 Thread Jonathan McDowell
ion options Jonathan McDowell (3): net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB net: dsa: qca8k: Improve SGMII interface handling net: dsa: qca8k: Minor comment spelling fix drivers/net/dsa/qca8k.c | 341 drivers/net/dsa/qca8k.h | 13 ++ 2 fi

[PATCH] ARM: dts: qcom: add qfprom definition to ipq806x

2020-06-16 Thread Jonathan McDowell
Add missing qfprom definition for ipq806x SoC Signed-off-by: Jonathan McDowell --- arch/arm/boot/dts/qcom-ipq8064.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi index b912da9a3ff3..8f299cae2628 100644

Re: [PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties

2020-06-15 Thread Jonathan McDowell
On Mon, Jun 15, 2020 at 11:45:16AM -0600, Rob Herring wrote: > On Fri, Jun 05, 2020 at 07:10:02PM +0100, Jonathan McDowell wrote: > > This patch documents the qca8k's SGMII related properties that allow > > configuration of the SGMII port. > > > > Signe

Re: [RFC PATCH v4 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-14 Thread Jonathan McDowell
On Sat, Jun 13, 2020 at 11:10:49PM +0300, Vladimir Oltean wrote: > On Sat, 13 Jun 2020 at 14:32, Jonathan McDowell wrote: > > > > This patch improves the handling of the SGMII interface on the QCA8K > > devices. Previously the driver did no configuration of the port, even i

[RFC PATCH v4 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-13 Thread Jonathan McDowell
it is enabled. Tested with a device where the CPU connection is RGMII (i.e. the common current use case) + one where the CPU connection is SGMII. I don't have any devices where the SGMII interface is brought out to something other than the CPU. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c

[RFC PATCH v4 0/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-13 Thread Jonathan McDowell
for PHY_INTERFACE_MODE_1000BASEX when setting SGMII port mode. - Address Vladimir's review comments v3: - Move phylink changes to separate patch - Address rmk review comments v2: - Switch to phylink - Avoid need for device tree configuration options Jonathan McDowell (2): net: dsa: qca8k: Switch to PHYLINK instead

[RFC PATCH v4 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-13 Thread Jonathan McDowell
Update the driver to use the new PHYLINK callbacks, removing the legacy adjust_link callback. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 308 +++- 1 file changed, 211 insertions(+), 97 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-12 Thread Jonathan McDowell
On Thu, Jun 11, 2020 at 09:55:23AM +0100, Russell King - ARM Linux admin wrote: > On Wed, Jun 10, 2020 at 08:14:03PM +0100, Jonathan McDowell wrote: > > Update the driver to use the new PHYLINK callbacks, removing the > > legacy adjust_link callback. > > Looks good, there

Re: [PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-11 Thread Jonathan McDowell
On Wed, Jun 10, 2020 at 08:31:11PM -0700, Florian Fainelli wrote: > On 6/10/2020 12:15 PM, Jonathan McDowell wrote: > > This patch improves the handling of the SGMII interface on the QCA8K > > devices. Previously the driver did no configuration of the port, even if > > it

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-11 Thread Jonathan McDowell
On Thu, Jun 11, 2020 at 11:58:43AM +0300, Vladimir Oltean wrote: > Hi Jonathan, > > On Wed, 10 Jun 2020 at 23:19, Jonathan McDowell wrote: > > > > Update the driver to use the new PHYLINK callbacks, removing the > > legacy adjust_link callback. > > >

[PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-10 Thread Jonathan McDowell
it is enabled. Tested with a device where the CPU connection is RGMII (i.e. the common current use case) + one where the CPU connection is SGMII. I don't have any devices where the SGMII interface is brought out to something other than the CPU. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c

[RFC PATCH v3 0/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-10 Thread Jonathan McDowell
configuration options Jonathan McDowell (2): net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB net: dsa: qca8k: Improve SGMII interface handling drivers/net/dsa/qca8k.c | 337 drivers/net/dsa/qca8k.h | 13 ++ 2 files changed, 252 insertions(+), 98 deletions

[PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-10 Thread Jonathan McDowell
Update the driver to use the new PHYLINK callbacks, removing the legacy adjust_link callback. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 309 +++- 1 file changed, 212 insertions(+), 97 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b

Re: R: [PATCH v6 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver

2020-06-09 Thread Jonathan McDowell
gt; > > doesn't work at all. > > > > FWIW I tested this on my RB3011 so feel free to add: > > > > Tested-by: Jonathan McDowell > > > > One minor comment; would PHY_QCOM_USB_IPQ806X not be a better > > choice than PHY_QCOM_IPQ806X_USB given the ex

[RFC PATCH v2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-08 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > I'll go away and roll a v2 moving qca8k over to phylink and then using > that to auto select the appropriate SGMII mode. Thanks for the feedback. Ok, take 2. I've switched the driver over to phylink which has let m

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 02:43:56PM +0100, Russell King - ARM Linux admin wrote: > On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > > So the device in question is a 7 port stand alone switch chip. There's a > > single SGMII port which is configurable between port

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 09:37:41AM +0100, Russell King - ARM Linux admin wrote: > On Sat, Jun 06, 2020 at 08:49:16AM +0100, Jonathan McDowell wrote: > > On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > > > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonat

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > > mode depending on what it's connected to (e.g. CPU vs external

[PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-05 Thread Jonathan McDowell
, and device tree support for configuring the connection details. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 44 - drivers/net/dsa/qca8k.h | 12 +++ 2 files changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa

[PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties

2020-06-05 Thread Jonathan McDowell
This patch documents the qca8k's SGMII related properties that allow configuration of the SGMII port. Signed-off-by: Jonathan McDowell --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa

[PATCH 0/2] net: dsa: qca8k: Add SGMII configuration options

2020-06-05 Thread Jonathan McDowell
to an external phy, or to a CPU, or to an SFP cage) as well as allowing for autonegotiation to be disabled and a delay configured. Tested on a MikroTik RB3011; the second switch is connected to the CPU via SGMII. Jonathan McDowell (2): dt-bindings: net: dsa: qca8k: document SGMII properties

Re: [PATCH v6 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver

2020-06-04 Thread Jonathan McDowell
On Wed, Jun 03, 2020 at 03:22:34PM +0200, Ansuel Smith wrote: > This has lost in the original push for the dwc3 qcom driver. > This is needed for ipq806x SoC as without this the usb ports > doesn't work at all. FWIW I tested this on my RB3011 so feel free to add: Tested-by: Jonathan

[PATCH] net: ethernet: stmmac: Enable interface clocks on probe for IPQ806x

2020-05-21 Thread Jonathan McDowell
/support-for-mikrotik-rb3011uias-rm/4064/257 correctly enables the clock; we have already configured the source just before this. Tested on a MikroTik RB3011. Signed-off-by: Jonathan McDowell --- diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c b/drivers/net/ethernet/stmicro

[PATCH 1/3] dt-bindings: vendor-prefixes: Add MikroTik

2020-05-18 Thread Jonathan McDowell
MikroTik (SIA Mikrotīkls) is a Latvian company who develop routers and wireless ISP systems. Signed-off-by: Jonathan McDowell --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml

[PATCH 2/3] ARM: dts: qcom: add ethernet definitions to ipq8064

2020-05-18 Thread Jonathan McDowell
Plumb in the 4 IPQ8064 stmmac based ethernet interfaces. Signed-off-by: Jonathan McDowell --- arch/arm/boot/dts/qcom-ipq8064.dtsi | 108 1 file changed, 108 insertions(+) diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi index

[PATCH 0/3] Add initial support for MikroTik RB3011

2020-05-18 Thread Jonathan McDowell
ports fully functional (the second bank of 5 require some extra patches to the QCA8K driver which will follow later). The bootloader NOR is also supported, but the 128MB NAND is not yet enabled. Jonathan McDowell (3): dt-bindings: vendor-prefixes: Add MikroTik ARM: dts: qcom: add ethernet

[PATCH 3/3] ARM: dts: qcom: Add MikroTik RB3011

2020-05-18 Thread Jonathan McDowell
This patch adds a DTS file for the MikroTik RouterBoard 3011, which is a 1U rackmount router based on the IPQ8064, supporting the serial UART, dual QCA8337 Gigabit ethernet switches, boot loader NOR and user LED device. Signed-off-by: Jonathan McDowell --- arch/arm/boot/dts/Makefile

[PATCHv2] ARM: dts: sun8i-h3: Add dts for the Mapleboard MP130

2018-10-30 Thread Jonathan McDowell
shipped with the board which uses mapleboard,mp130- prefixes instead of the allwinner,sun8i variants. v2: Fold in review comments from Maxime Ripard Signed-off-by: Jonathan McDowell --- arch/arm/boot/dts/Makefile| 1 + .../boot/dts/sun8i-h3-mapleboard-mp130.dts| 174

[PATCHv2] ARM: dts: sun8i-h3: Add dts for the Mapleboard MP130

2018-10-30 Thread Jonathan McDowell
shipped with the board which uses mapleboard,mp130- prefixes instead of the allwinner,sun8i variants. v2: Fold in review comments from Maxime Ripard Signed-off-by: Jonathan McDowell --- arch/arm/boot/dts/Makefile| 1 + .../boot/dts/sun8i-h3-mapleboard-mp130.dts| 174

Re: [PATCH] dts: sun8i-h3: Add DTS for Mapleboard MP130

2018-10-30 Thread Jonathan McDowell
On Mon, Oct 29, 2018 at 04:20:52PM +0100, Maxime Ripard wrote: > Thanks for your patch. Thanks for the comments. > On Thu, Oct 25, 2018 at 08:55:19PM +0100, Jonathan McDowell wrote: ... > The prefix of your patch should be "ARM: dts: sun8i-h3: ..." Ok. > > diff

Re: [PATCH] dts: sun8i-h3: Add DTS for Mapleboard MP130

2018-10-30 Thread Jonathan McDowell
On Mon, Oct 29, 2018 at 04:20:52PM +0100, Maxime Ripard wrote: > Thanks for your patch. Thanks for the comments. > On Thu, Oct 25, 2018 at 08:55:19PM +0100, Jonathan McDowell wrote: ... > The prefix of your patch should be "ARM: dts: sun8i-h3: ..." Ok. > > diff

[PATCH] dts: sun8i-h3: Add DTS for Mapleboard MP130

2018-10-25 Thread Jonathan McDowell
shipped with the board which uses mapleboard,mp130- prefixes instead of the allwinner,sun8i variants. Signed-off-by: Jonathan McDowell diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index b5bd3de87c33..dcf1b9e7f71e 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts

[PATCH] dts: sun8i-h3: Add DTS for Mapleboard MP130

2018-10-25 Thread Jonathan McDowell
shipped with the board which uses mapleboard,mp130- prefixes instead of the allwinner,sun8i variants. Signed-off-by: Jonathan McDowell diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index b5bd3de87c33..dcf1b9e7f71e 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts

Re: [PATCH] ACPI / WMI: Call acpi_wmi_init() later

2018-01-06 Thread Jonathan McDowell
> > > For this reason, move the acpi_wmi_init() invocation to the > > initcall_sync level which should still be early enough for things > > to work correctly in the WMI land. > > > > Link: https://marc.info/?t=15127459672=1=2 > > Reported-by: Jonathan McD

Re: [PATCH] ACPI / WMI: Call acpi_wmi_init() later

2018-01-06 Thread Jonathan McDowell
invocation to the > > initcall_sync level which should still be early enough for things > > to work correctly in the WMI land. > > > > Link: https://marc.info/?t=15127459672=1=2 > > Reported-by: Jonathan McDowell > > Reported-by: Joonsoo Kim > > Tested-

Re: ACPI issues on cold power on [bisected]

2018-01-03 Thread Jonathan McDowell
On Wed, Jan 03, 2018 at 11:11:29AM +0900, Joonsoo Kim wrote: > On Tue, Jan 02, 2018 at 11:25:01AM +0100, Rafael J. Wysocki wrote: > > On Tue, Jan 2, 2018 at 3:54 AM, Joonsoo Kim <iamjoonsoo@lge.com> wrote: > > > On Fri, Dec 29, 2017 at 04:36:59PM +, Jonathan McDow

Re: ACPI issues on cold power on [bisected]

2018-01-03 Thread Jonathan McDowell
On Wed, Jan 03, 2018 at 11:11:29AM +0900, Joonsoo Kim wrote: > On Tue, Jan 02, 2018 at 11:25:01AM +0100, Rafael J. Wysocki wrote: > > On Tue, Jan 2, 2018 at 3:54 AM, Joonsoo Kim wrote: > > > On Fri, Dec 29, 2017 at 04:36:59PM +, Jonathan McDowell wrote: > > >>

Re: ACPI issues on cold power on [bisected]

2017-12-29 Thread Jonathan McDowell
On Fri, Dec 22, 2017 at 09:21:09AM +0900, Joonsoo Kim wrote: > On Fri, Dec 08, 2017 at 03:11:59PM +0000, Jonathan McDowell wrote: > > I've been sitting on this for a while and should have spent time to > > investigate sooner, but it's been an odd failure mode that wasn't qu

Re: ACPI issues on cold power on [bisected]

2017-12-29 Thread Jonathan McDowell
On Fri, Dec 22, 2017 at 09:21:09AM +0900, Joonsoo Kim wrote: > On Fri, Dec 08, 2017 at 03:11:59PM +0000, Jonathan McDowell wrote: > > I've been sitting on this for a while and should have spent time to > > investigate sooner, but it's been an odd failure mode that wasn't qu

ACPI issues on cold power on [bisected]

2017-12-08 Thread Jonathan McDowell
I've been sitting on this for a while and should have spent time to investigate sooner, but it's been an odd failure mode that wasn't quite obvious. In 4.9 if I cold power on my laptop (Dell E7240) it fails to boot - I don't see anything after grub says its booting. In 4.10 onwards the laptop

ACPI issues on cold power on [bisected]

2017-12-08 Thread Jonathan McDowell
I've been sitting on this for a while and should have spent time to investigate sooner, but it's been an odd failure mode that wasn't quite obvious. In 4.9 if I cold power on my laptop (Dell E7240) it fails to boot - I don't see anything after grub says its booting. In 4.10 onwards the laptop

Re: [PATCH 2/5] x86/cpuid: Add generic table for cpuid dependencies

2017-06-22 Thread Jonathan McDowell
In article <20170621234106.16548-3-a...@firstfloor.org> you wrote: > Some CPUID features depend on other features. Currently it's > possible to to clear dependent features, but not clear the base features, > which can cause various interesting problems. > This patch implements a generic table to

Re: [PATCH 2/5] x86/cpuid: Add generic table for cpuid dependencies

2017-06-22 Thread Jonathan McDowell
In article <20170621234106.16548-3-a...@firstfloor.org> you wrote: > Some CPUID features depend on other features. Currently it's > possible to to clear dependent features, but not clear the base features, > which can cause various interesting problems. > This patch implements a generic table to

[PATCH v2] [media] dw2102: don't do DMA on stack

2017-02-15 Thread Jonathan McDowell
river over to using a buffer within the device state structure, as has been done with other DVB-USB drivers. Tested against 4.9.10 but applies to Linus' master cleanly. Signed-off-by: Jonathan McDowell <nood...@earth.li> Cc: <sta...@vger.kernel.org> - diff --git a/drivers/media/usb/dvb-u

[PATCH v2] [media] dw2102: don't do DMA on stack

2017-02-15 Thread Jonathan McDowell
river over to using a buffer within the device state structure, as has been done with other DVB-USB drivers. Tested against 4.9.10 but applies to Linus' master cleanly. Signed-off-by: Jonathan McDowell Cc: - diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw2102.c ind

[PATCH] [media] dw2102: don't do DMA on stack

2017-02-15 Thread Jonathan McDowell
() and the resulting attempt to do DMA with them. Patch below switches this driver over to using a buffer within the device state structure, as has been done with other DVB-USB drivers. Tested against 4.9.10 but applies to Linus' master cleanly. Signed-off-by: Jonathan McDowell <nood...@earth.li> Cc

[PATCH] [media] dw2102: don't do DMA on stack

2017-02-15 Thread Jonathan McDowell
() and the resulting attempt to do DMA with them. Patch below switches this driver over to using a buffer within the device state structure, as has been done with other DVB-USB drivers. Tested against 4.9.10 but applies to Linus' master cleanly. Signed-off-by: Jonathan McDowell Cc: - diff --git

[PATCH] Remove spurious blank lines in dw2101 kernel messages

2016-06-06 Thread Jonathan McDowell
The DW2102 DVB-S/S2 driver uses the info() logging function from dvb-usb.h. This function already appends a newline to the provided log message, causing the dmesg output from DW2102 to include blank lines. Fix this by removing the newline in the calls to info(). Signed-off-by: Jonathan McDowell

[PATCH] Remove spurious blank lines in dw2101 kernel messages

2016-06-06 Thread Jonathan McDowell
The DW2102 DVB-S/S2 driver uses the info() logging function from dvb-usb.h. This function already appends a newline to the provided log message, causing the dmesg output from DW2102 to include blank lines. Fix this by removing the newline in the calls to info(). Signed-off-by: Jonathan McDowell

[PATCH] Convert Wideview WT220 DVB USB driver to rc-core

2016-05-20 Thread Jonathan McDowell
to the rc-core infrastructure for its handling of IR remotes. This device can receive generic NEC / NEC Extended signals and the switch to the newer core enables the easy use of tools such as ir-keytable to modify the active key map. Signed-off-by: Jonathan McDowell <nood...@earth.li>

[PATCH] Convert Wideview WT220 DVB USB driver to rc-core

2016-05-20 Thread Jonathan McDowell
to the rc-core infrastructure for its handling of IR remotes. This device can receive generic NEC / NEC Extended signals and the switch to the newer core enables the easy use of tools such as ir-keytable to modify the active key map. Signed-off-by: Jonathan McDowell - diff --git a/drivers

[PATCH] Fix RC5 decoding with Fintek CIR chipset

2016-05-14 Thread Jonathan McDowell
not want to provide details of a space longer than 6350us. This meant that RC5 remotes working on a Fintek setup on 3.16 failed on 3.17 and later. Fix this by shortening the trailer check to 6 units (allowing for a previous space in the received remote command). Signed-off-by: Jonathan McDowell <n

[PATCH] Fix RC5 decoding with Fintek CIR chipset

2016-05-14 Thread Jonathan McDowell
not want to provide details of a space longer than 6350us. This meant that RC5 remotes working on a Fintek setup on 3.16 failed on 3.17 and later. Fix this by shortening the trailer check to 6 units (allowing for a previous space in the received remote command). Signed-off-by: Jonathan McDowell

[PATCH] Re: [4.3-rc1 regression] modular 8250 doesn't load

2015-09-21 Thread Jonathan McDowell
le: > > MODULE_LICENSE("GPL"); line added to the 8250_base file. > Wait, 8250_base.c has a module license line. 8250_base.c doesn't exist; it is built from 8250_port.c and 8250_dma.c, neither of which have a MODULE_LICENSE line. Adding MODULE_LICENSE("GPL") as per below

[PATCH] Re: [4.3-rc1 regression] modular 8250 doesn't load

2015-09-21 Thread Jonathan McDowell
le: > > MODULE_LICENSE("GPL"); line added to the 8250_base file. > Wait, 8250_base.c has a module license line. 8250_base.c doesn't exist; it is built from 8250_port.c and 8250_dma.c, neither of which have a MODULE_LICENSE line. Adding MODULE_LICENSE("GPL") as per b

Re: Audio crackles with 4.1-rc1

2015-06-14 Thread Jonathan McDowell
On Fri, Jun 12, 2015 at 04:13:16PM +0200, Takashi Iwai wrote: > At Fri, 12 Jun 2015 12:09:55 +0200, > Takashi Iwai wrote: > > At Fri, 12 Jun 2015 12:45:23 +0300, > > Mihai Donțu wrote: > > > Nice shot! It appears to work. :-) No clicks, no static. > > > > Good to hear! > > > > > I had to apply

Re: Audio crackles with 4.1-rc1

2015-06-14 Thread Jonathan McDowell
On Fri, Jun 12, 2015 at 04:13:16PM +0200, Takashi Iwai wrote: At Fri, 12 Jun 2015 12:09:55 +0200, Takashi Iwai wrote: At Fri, 12 Jun 2015 12:45:23 +0300, Mihai Donțu wrote: Nice shot! It appears to work. :-) No clicks, no static. Good to hear! I had to apply it by hand over

Re: Audio crackles with 4.1-rc1

2015-05-20 Thread Jonathan McDowell
On Wed, May 20, 2015 at 07:01:12AM +0200, Takashi Iwai wrote: > At Tue, 19 May 2015 22:53:10 +0100, > Jonathan McDowell wrote: > > > > On Tue, May 19, 2015 at 07:09:12PM +0200, Takashi Iwai wrote: > > > At Tue, 19 May 2015 17:19:11 +0100, > > > Jonathan McD

Re: Audio crackles with 4.1-rc1

2015-05-20 Thread Jonathan McDowell
On Wed, May 20, 2015 at 07:01:12AM +0200, Takashi Iwai wrote: At Tue, 19 May 2015 22:53:10 +0100, Jonathan McDowell wrote: On Tue, May 19, 2015 at 07:09:12PM +0200, Takashi Iwai wrote: At Tue, 19 May 2015 17:19:11 +0100, Jonathan McDowell wrote: On Tue, May 19, 2015 at 08:15

Re: Audio crackles with 4.1-rc1

2015-05-19 Thread Jonathan McDowell
On Tue, May 19, 2015 at 07:09:12PM +0200, Takashi Iwai wrote: > At Tue, 19 May 2015 17:19:11 +0100, > Jonathan McDowell wrote: > > > > On Tue, May 19, 2015 at 08:15:32AM +0200, Takashi Iwai wrote: > > > Does the patch below have any improvement? > > > >

Re: Audio crackles with 4.1-rc1

2015-05-19 Thread Jonathan McDowell
On Tue, May 19, 2015 at 08:15:32AM +0200, Takashi Iwai wrote: > At Sat, 2 May 2015 16:05:13 +0100, > Jonathan McDowell wrote: > > > > On Thu, Apr 30, 2015 at 07:06:31PM +0200, Takashi Iwai wrote: > > > At Thu, 30 Apr 2015 16:01:31 +0100, Jonathan McDowell wrote: >

  1   2   >