Re: [PATCH] net: broadcom: fix a mistake about ioremap resource

2020-05-05 Thread Jonathan Richardson
On Tue, May 5, 2020 at 12:20 AM Markus Elfring wrote: > > > Commit d7a5502b0bb8b ("net: broadcom: convert to > > devm_platform_ioremap_resource_byname()") will broke this driver. > > idm_base and nicpm_base were optional, after this change, they are > > mandatory. it will probe fails with -22

Re: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver

2016-10-31 Thread Jonathan Richardson
On 16-10-30 06:38 PM, Rob Herring wrote: > On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote: >> From: Jonathan Richardson <jonat...@broadcom.com> >> >> Reviewed-by: Ray Jui <ray....@broadcom.com> >> Tested-by: Jonathan Richardson <j

Re: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver

2016-10-31 Thread Jonathan Richardson
On 16-10-30 06:38 PM, Rob Herring wrote: > On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote: >> From: Jonathan Richardson >> >> Reviewed-by: Ray Jui >> Tested-by: Jonathan Richardson >> Signed-off-by: Scott Branden >> Sign

[PATCH v1 3/3] ARM: dts: Add node for Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson <jonat...@broadcom.com> Reviewed-by: Ray Jui <ray@broadcom.com> Tested-by: Jonathan Richardson <jonathan.richard...@broadcom.com> Signed-off-by: Scott Branden <scott.bran...@broadcom.com> Signed-off-by: Oza Pawandeep <o...@broadcom.c

[PATCH v1 2/3] nvmem: Add the Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson <jonat...@broadcom.com> Add support for 32 and 64-bit versions of Broadcom's On-Chip OTP controller. These controllers are used on SoC's such as Cygnus and Stingray. Reviewed-by: Ray Jui <ray@broadcom.com> Tested-by: Jonathan Richardson <j

[PATCH v1 3/3] ARM: dts: Add node for Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson Reviewed-by: Ray Jui Tested-by: Jonathan Richardson Signed-off-by: Scott Branden Signed-off-by: Oza Pawandeep Signed-off-by: Jonathan Richardson --- arch/arm/boot/dts/bcm-cygnus.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/bcm

[PATCH v1 2/3] nvmem: Add the Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson Add support for 32 and 64-bit versions of Broadcom's On-Chip OTP controller. These controllers are used on SoC's such as Cygnus and Stingray. Reviewed-by: Ray Jui Tested-by: Jonathan Richardson Signed-off-by: Scott Branden Signed-off-by: Oza Pawandeep Signed-off

[PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson <jonat...@broadcom.com> Reviewed-by: Ray Jui <ray@broadcom.com> Tested-by: Jonathan Richardson <jonathan.richard...@broadcom.com> Signed-off-by: Scott Branden <scott.bran...@broadcom.com> Signed-off-by: Oza Pawandeep <o...@broadcom.c

[PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver

2016-10-24 Thread Jonathan Richardson
From: Jonathan Richardson Reviewed-by: Ray Jui Tested-by: Jonathan Richardson Signed-off-by: Scott Branden Signed-off-by: Oza Pawandeep Signed-off-by: Jonathan Richardson --- Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 + 1 file changed, 17 insertions

[PATCH v1 0/3] Add support for Broadcom OTP controller

2016-10-24 Thread Jonathan Richardson
This patch set adds support for Broadcom's OTP controller found on chips such as Cygnus and Stingray. A node has been added to the Cygnus dts. Jonathan Richardson (3): dt-bindings: Document Broadcom OTP controller driver nvmem: Add the Broadcom OTP controller driver ARM: dts: Add node

[PATCH v1 0/3] Add support for Broadcom OTP controller

2016-10-24 Thread Jonathan Richardson
This patch set adds support for Broadcom's OTP controller found on chips such as Cygnus and Stingray. A node has been added to the Cygnus dts. Jonathan Richardson (3): dt-bindings: Document Broadcom OTP controller driver nvmem: Add the Broadcom OTP controller driver ARM: dts: Add node

Re: [PATCH] pwm: Avoid double mutex lock on pwm_enable

2015-11-23 Thread Jonathan Richardson
th_common+0x80/0xb0) >>>>>>>>> [2.701836] [] (warn_slowpath_common) from [] >>>>>>>>> (warn_slowpath_fmt+0x30/0x40) >>>>>>>>> [2.701849] [] (warn_slowpath_fmt) from [] >>>>>>>>> (__mutex_lock_sl

Re: [PATCH] pwm: Avoid double mutex lock on pwm_enable

2015-11-23 Thread Jonathan Richardson
t;>>>>>>>> (dump_stack+0x84/0xc4) >>>>>>>>> [2.701824] [] (dump_stack) from [] >>>>>>>>> (warn_slowpath_common+0x80/0xb0) >>>>>>>>> [2.701836] [] (warn_slowpath_common) from [] >>>>>>

[PATCH v10 0/1] Fix bugs in kona pwm driver and pwm core

2015-10-16 Thread Jonathan Richardson
. Jonathan Richardson (1): pwm: core: Set enable state properly on failed call to enable drivers/pwm/core.c | 33 ++--- include/linux/pwm.h | 2 ++ 2 files changed, 28 insertions(+), 7 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line

[PATCH v10 1/1] pwm: core: Set enable state properly on failed call to enable

2015-10-16 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Reviewed

Re: [PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-10-16 Thread Jonathan Richardson
On 15-08-17 07:31 AM, Thierry Reding wrote: > On Mon, Jun 15, 2015 at 04:22:27PM -0700, Jonathan Richardson wrote: >> On 15-06-15 02:21 PM, Jonathan Richardson wrote: >>> The pwm_enable function didn't clear the enabled bit if a call to a >>> clients enable function re

[PATCH v10 1/1] pwm: core: Set enable state properly on failed call to enable

2015-10-16 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson <jo

[PATCH v10 0/1] Fix bugs in kona pwm driver and pwm core

2015-10-16 Thread Jonathan Richardson
. Jonathan Richardson (1): pwm: core: Set enable state properly on failed call to enable drivers/pwm/core.c | 33 ++--- include/linux/pwm.h | 2 ++ 2 files changed, 28 insertions(+), 7 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line

Re: [PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-10-16 Thread Jonathan Richardson
On 15-08-17 07:31 AM, Thierry Reding wrote: > On Mon, Jun 15, 2015 at 04:22:27PM -0700, Jonathan Richardson wrote: >> On 15-06-15 02:21 PM, Jonathan Richardson wrote: >>> The pwm_enable function didn't clear the enabled bit if a call to a >>> clients enable function re

Re: [PATCH v9 1/2] pwm: kona: Modify settings application sequence

2015-07-02 Thread Jonathan Richardson
Hi Theirry, If there are no more comments can this patch be applied? Thanks, Jon On 15-06-15 02:21 PM, Jonathan Richardson wrote: > Update the driver so that settings are applied in accordance with the > most recent version of the hardware spec. The revised sequence clears > the tr

Re: [PATCH v9 1/2] pwm: kona: Modify settings application sequence

2015-07-02 Thread Jonathan Richardson
Hi Theirry, If there are no more comments can this patch be applied? Thanks, Jon On 15-06-15 02:21 PM, Jonathan Richardson wrote: Update the driver so that settings are applied in accordance with the most recent version of the hardware spec. The revised sequence clears the trigger bit

Re: [PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-06-15 Thread Jonathan Richardson
On 15-06-15 02:21 PM, Jonathan Richardson wrote: > The pwm_enable function didn't clear the enabled bit if a call to a > clients enable function returned an error. The result was that the state > of the pwm core was wrong. Clearing the bit when enable returns an error > ensur

[PATCH v9 1/2] pwm: kona: Modify settings application sequence

2015-06-15 Thread Jonathan Richardson
was not properly reflected in the PWM output. Reviewed-by: Arun Ramamurthy Reviewed-by: Scott Branden Tested-by: Scott Branden Reviewed-by: Tim Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 47 +++- 1 file changed, 38

[PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-06-15 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Reviewed

[PATCH v9 0/2] Fix bugs in kona pwm driver and pwm core

2015-06-15 Thread Jonathan Richardson
properly now when the pwm driver is registered with the pwm framework. Jonathan Richardson (2): pwm: kona: Modify settings application sequence pwm: core: Set enable state properly on failed call to enable drivers/pwm/core.c | 19 +++--- drivers/pwm/pwm-bcm-kona.c

[PATCH v9 1/2] pwm: kona: Modify settings application sequence

2015-06-15 Thread Jonathan Richardson
was not properly reflected in the PWM output. Reviewed-by: Arun Ramamurthy arunr...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com Tested-by: Scott Branden sbran...@broadcom.com Reviewed-by: Tim Kryger tim.kry...@gmail.com Signed-off-by: Jonathan Richardson jonat...@broadcom.com

[PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-06-15 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson jonat

[PATCH v9 0/2] Fix bugs in kona pwm driver and pwm core

2015-06-15 Thread Jonathan Richardson
properly now when the pwm driver is registered with the pwm framework. Jonathan Richardson (2): pwm: kona: Modify settings application sequence pwm: core: Set enable state properly on failed call to enable drivers/pwm/core.c | 19 +++--- drivers/pwm/pwm-bcm-kona.c

Re: [PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable

2015-06-15 Thread Jonathan Richardson
On 15-06-15 02:21 PM, Jonathan Richardson wrote: The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly

Re: [PATCH v8 4/5] pwm: kona: Add debug info to config function

2015-06-12 Thread Jonathan Richardson
On 15-05-30 09:42 AM, Tim Kryger wrote: > On Tue, May 26, 2015 at 1:08 PM, Jonathan Richardson > wrote: >> Adds debugging info to config function where duty cycle and period >> are calculated and verified. >> >> Signed-off-by: Jonathan Richardson >> --- &

Re: [PATCH v8 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-06-12 Thread Jonathan Richardson
On 15-05-30 09:41 AM, Tim Kryger wrote: > On Tue, May 26, 2015 at 1:08 PM, Jonathan Richardson > wrote: >> The config procedure didn't follow the spec which periodically resulted >> in failing to enable the output signal. This happened one in ten or >> twenty atte

Re: [PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-06-12 Thread Jonathan Richardson
On 15-06-12 02:49 AM, Thierry Reding wrote: > On Tue, May 26, 2015 at 01:08:20PM -0700, Jonathan Richardson wrote: >> The pwm_enable function didn't clear the enabled bit if a call to a >> clients enable function returned an error. The result was that the state >> of t

Re: [PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-06-12 Thread Jonathan Richardson
On 15-06-12 02:49 AM, Thierry Reding wrote: On Tue, May 26, 2015 at 01:08:20PM -0700, Jonathan Richardson wrote: The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing

Re: [PATCH v8 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-06-12 Thread Jonathan Richardson
On 15-05-30 09:41 AM, Tim Kryger wrote: On Tue, May 26, 2015 at 1:08 PM, Jonathan Richardson jonat...@broadcom.com wrote: The config procedure didn't follow the spec which periodically resulted in failing to enable the output signal. This happened one in ten or twenty attempts. Following

Re: [PATCH v8 4/5] pwm: kona: Add debug info to config function

2015-06-12 Thread Jonathan Richardson
On 15-05-30 09:42 AM, Tim Kryger wrote: On Tue, May 26, 2015 at 1:08 PM, Jonathan Richardson jonat...@broadcom.com wrote: Adds debugging info to config function where duty cycle and period are calculated and verified. Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers

[PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-05-26 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Reviewed

[PATCH v8 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe

2015-05-26 Thread Jonathan Richardson
Signed-off-by: Scott Branden Signed-off-by: Tim Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 02bc048..32b3ec6 100644

[PATCH v8 1/5] drivers: pwm: core: Add pwmchip_add_inversed

2015-05-26 Thread Jonathan Richardson
Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/core.c | 36 include/linux/pwm.h |6 ++ 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index ba34c7d..224645f 100644 --- a/drivers/pwm

[PATCH v8 0/5] Fix bugs in kona pwm driver and pwm core

2015-05-26 Thread Jonathan Richardson
that resolved difference between hardware default polarity and pwm framework default polarity. The default polarity is set properly now when the pwm driver is registered with the pwm framework. Arun Ramamurthy (1): drivers: pwm: bcm-kona: Dont set polarity in probe Jonathan Richardson (3

[PATCH v8 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-26 Thread Jonathan Richardson
follow the spec. The old procedures would result in no change in signal when called. Reviewed-by: Arun Ramamurthy Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 47 +++- 1 file

[PATCH v8 4/5] pwm: kona: Add debug info to config function

2015-05-26 Thread Jonathan Richardson
Adds debugging info to config function where duty cycle and period are calculated and verified. Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers

[PATCH v8 0/5] Fix bugs in kona pwm driver and pwm core

2015-05-26 Thread Jonathan Richardson
that resolved difference between hardware default polarity and pwm framework default polarity. The default polarity is set properly now when the pwm driver is registered with the pwm framework. Arun Ramamurthy (1): drivers: pwm: bcm-kona: Dont set polarity in probe Jonathan Richardson (3

[PATCH v8 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-26 Thread Jonathan Richardson
follow the spec. The old procedures would result in no change in signal when called. Reviewed-by: Arun Ramamurthy arunr...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com Tested-by: Scott Branden sbran...@broadcom.com Signed-off-by: Jonathan Richardson jonat...@broadcom.com

[PATCH v8 1/5] drivers: pwm: core: Add pwmchip_add_inversed

2015-05-26 Thread Jonathan Richardson
. Signed-off-by: Tim Kryger tim.kry...@gmail.com Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers/pwm/core.c | 36 include/linux/pwm.h |6 ++ 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/pwm/core.c b/drivers

[PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-05-26 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson jonat

[PATCH v8 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe

2015-05-26 Thread Jonathan Richardson
arunr...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com Signed-off-by: Tim Kryger tim.kry...@gmail.com Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers/pwm/pwm-bcm-kona.c |9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH v8 4/5] pwm: kona: Add debug info to config function

2015-05-26 Thread Jonathan Richardson
Adds debugging info to config function where duty cycle and period are calculated and verified. Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers/pwm/pwm-bcm-kona.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm

Re: [PATCH v7 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-21 Thread Jonathan Richardson
On 15-05-17 09:53 PM, Tim Kryger wrote: > On Tue, May 12, 2015 at 4:28 PM, Jonathan Richardson > wrote: > >> The polarity procedure no longer applies the settings to change the >> output signal because it can't be called when the pwm is enabled anyway. >> T

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-21 Thread Jonathan Richardson
On 15-05-20 11:33 PM, Richard Cochran wrote: > On Wed, May 20, 2015 at 04:38:02PM -0700, Jonathan Richardson wrote: >> >> Richard, this design isn't going to work. We need to have both kernel >> and user space consumers. > > But you did not implement even a single kern

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-21 Thread Jonathan Richardson
On 15-05-20 11:33 PM, Richard Cochran wrote: On Wed, May 20, 2015 at 04:38:02PM -0700, Jonathan Richardson wrote: Richard, this design isn't going to work. We need to have both kernel and user space consumers. But you did not implement even a single kernel consumer. We don't want all

Re: [PATCH v7 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-21 Thread Jonathan Richardson
On 15-05-17 09:53 PM, Tim Kryger wrote: On Tue, May 12, 2015 at 4:28 PM, Jonathan Richardson jonat...@broadcom.com wrote: The polarity procedure no longer applies the settings to change the output signal because it can't be called when the pwm is enabled anyway. The polarity is only updated

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-20 Thread Jonathan Richardson
On 15-05-14 04:30 AM, Richard Cochran wrote: > On Wed, May 13, 2015 at 04:25:49PM -0700, Jonathan Richardson wrote: >> On 15-05-13 01:27 PM, Richard Cochran wrote: >>> If the ISR is delivering batches of time stamps, then the interrupt >>> rate aught to be the highe

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-20 Thread Jonathan Richardson
On 15-05-14 04:30 AM, Richard Cochran wrote: On Wed, May 13, 2015 at 04:25:49PM -0700, Jonathan Richardson wrote: On 15-05-13 01:27 PM, Richard Cochran wrote: If the ISR is delivering batches of time stamps, then the interrupt rate aught to be the highest rate that the system can support

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-14 Thread Jonathan Richardson
On 15-05-14 12:08 PM, Mark Brown wrote: > On Thu, May 14, 2015 at 11:19:01AM -0700, Scott Branden wrote: >> On 15-05-14 03:31 AM, Mark Brown wrote: > >>> Chip vendors often say this sort of thing and then get surprised by what >>> their users choose to do, and even if it only ever gets used with

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-14 Thread Jonathan Richardson
On 15-05-14 11:36 AM, Scott Branden wrote: > On 15-05-14 11:28 AM, Florian Fainelli wrote: >> On 14/05/15 11:19, Scott Branden wrote: >>> Hi Mark, >>> >>> On 15-05-14 03:31 AM, Mark Brown wrote: On Wed, May 13, 2015 at 05:19:06PM -0700, Scott Branden wrote: > The purpose of this mspi

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-14 Thread Jonathan Richardson
On 15-05-14 11:36 AM, Scott Branden wrote: On 15-05-14 11:28 AM, Florian Fainelli wrote: On 14/05/15 11:19, Scott Branden wrote: Hi Mark, On 15-05-14 03:31 AM, Mark Brown wrote: On Wed, May 13, 2015 at 05:19:06PM -0700, Scott Branden wrote: The purpose of this mspi interface is to connect

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-14 Thread Jonathan Richardson
On 15-05-14 12:08 PM, Mark Brown wrote: On Thu, May 14, 2015 at 11:19:01AM -0700, Scott Branden wrote: On 15-05-14 03:31 AM, Mark Brown wrote: Chip vendors often say this sort of thing and then get surprised by what their users choose to do, and even if it only ever gets used with flash all

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-13 Thread Jonathan Richardson
On 15-05-12 12:17 PM, Mark Brown wrote: > On Tue, May 12, 2015 at 10:38:13AM -0700, Jonathan Richardson wrote: > >> +/* Wait for interrupt indicating transfer is complete. */ >> +if (!wait_for_completion_timeout(>xfer_done, >> +msecs_to_jiffies(1

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
On 15-05-13 01:27 PM, Richard Cochran wrote: > On Wed, May 13, 2015 at 12:50:02PM -0700, Jonathan Richardson wrote: >> ptp_clock_adjtime() casts it to an unsigned and returns an error: >> >>if ((unsigned long) ts.tv_nsec >= NSEC_PER_SEC) >>return -EINVA

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
On 15-05-13 08:35 AM, Richard Cochran wrote: > On Fri, May 08, 2015 at 01:02:17PM -0700, Jonathan Richardson wrote: >> For the clock functions I think we can use the existing framework >> unchanged with one exception: ptp_clock_adjtime() doesn't allow negative >> time adjustme

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
Richard, glad you retrieved our driver. Comments below. On 15-05-13 08:21 AM, Richard Cochran wrote: > On Fri, May 01, 2015 at 12:01:07PM -0700, Jonathan Richardson wrote: >> The DTE creates timestamps of hardware based events such as GPIO, I2S >> signals for audio, etc. It wa

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
Richard, glad you retrieved our driver. Comments below. On 15-05-13 08:21 AM, Richard Cochran wrote: > On Fri, May 01, 2015 at 12:01:07PM -0700, Jonathan Richardson wrote: >> The DTE creates timestamps of hardware based events such as GPIO, I2S >> signals for audio, etc. It wa

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
Richard, glad you retrieved our driver. Comments below. On 15-05-13 08:21 AM, Richard Cochran wrote: On Fri, May 01, 2015 at 12:01:07PM -0700, Jonathan Richardson wrote: The DTE creates timestamps of hardware based events such as GPIO, I2S signals for audio, etc. It was also intended

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
Richard, glad you retrieved our driver. Comments below. On 15-05-13 08:21 AM, Richard Cochran wrote: On Fri, May 01, 2015 at 12:01:07PM -0700, Jonathan Richardson wrote: The DTE creates timestamps of hardware based events such as GPIO, I2S signals for audio, etc. It was also intended

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
On 15-05-13 08:35 AM, Richard Cochran wrote: On Fri, May 08, 2015 at 01:02:17PM -0700, Jonathan Richardson wrote: For the clock functions I think we can use the existing framework unchanged with one exception: ptp_clock_adjtime() doesn't allow negative time adjustments and we would like

Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-13 Thread Jonathan Richardson
On 15-05-12 12:17 PM, Mark Brown wrote: On Tue, May 12, 2015 at 10:38:13AM -0700, Jonathan Richardson wrote: +/* Wait for interrupt indicating transfer is complete. */ +if (!wait_for_completion_timeout(mspi-xfer_done, +msecs_to_jiffies(10))) { What if we have a large

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-13 Thread Jonathan Richardson
On 15-05-13 01:27 PM, Richard Cochran wrote: On Wed, May 13, 2015 at 12:50:02PM -0700, Jonathan Richardson wrote: ptp_clock_adjtime() casts it to an unsigned and returns an error: if ((unsigned long) ts.tv_nsec = NSEC_PER_SEC) return -EINVAL; The value of a timeval is the sum

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-12 Thread Jonathan Richardson
A bit more info is required here. > Get timestamp: This is a bit more complicated. Currently the PTP driver > does list management for timestamps from external timestamp channels. > Timestamps from all channels go into the same list. In our driver we > have a s/w FIFO for each client and it

[PATCH v7 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-12 Thread Jonathan Richardson
-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 47 +--- 1 file changed, 36 insertions(+), 11 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 32b3ec6..0654981 100644 --- a/drivers/pwm/pwm-bcm-kona.c +++ b

[PATCH v7 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe

2015-05-12 Thread Jonathan Richardson
Signed-off-by: Scott Branden Signed-off-by: Tim Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 02bc048..32b3ec6 100644

[PATCH v7 5/5] pwm: core: Set enable state properly on failed call to enable

2015-05-12 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Reviewed

[PATCH v7 4/5] pwm: kona: Add debug info to config function

2015-05-12 Thread Jonathan Richardson
Adds debugging info to config function where duty cycle and period are calculated and verified. Signed-off-by: Jonathan Richardson --- drivers/pwm/pwm-bcm-kona.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers

[PATCH v7 1/5] drivers: pwm: core: Add pwmchip_add_inversed

2015-05-12 Thread Jonathan Richardson
Kryger Signed-off-by: Jonathan Richardson --- drivers/pwm/core.c | 36 include/linux/pwm.h |6 ++ 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index ba34c7d..224645f 100644 --- a/drivers/pwm

[PATCH v7 0/5] Fix bugs in kona pwm driver and pwm core

2015-05-12 Thread Jonathan Richardson
polarity is set properly now when the pwm driver is registered with the pwm framework. Arun Ramamurthy (1): drivers: pwm: bcm-kona: Dont set polarity in probe Jonathan Richardson (3): pwm: kona: Fix incorrect config, disable, and polarity procedures pwm: kona: Add debug info to config

[PATCH 0/2] Add Broadcom MSPI driver

2015-05-12 Thread Jonathan Richardson
This patchset adds support for Broadcoms MSPI SPI controller. It can be found on various SoC's such as Cygnus. Jonathan Richardson (2): ARM: dts: Add binding for Broadcom MSPI driver. spi: bcm-mspi: Add support for Broadcom MSPI driver. .../devicetree/bindings/spi/brcm,mspi-spi.txt

[PATCH 1/2] ARM: dts: Add binding for Broadcom MSPI driver.

2015-05-12 Thread Jonathan Richardson
Signed-off-by: Jonathan Richardson --- .../devicetree/bindings/spi/brcm,mspi-spi.txt | 39 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/brcm,mspi-spi.txt diff --git a/Documentation/devicetree/bindings/spi/brcm,mspi

[PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-12 Thread Jonathan Richardson
The MSPI controller is a SPI controller found on various Broadcom SoC's such as Cygnus. Signed-off-by: Jonathan Richardson --- drivers/spi/Kconfig|5 + drivers/spi/Makefile |1 + drivers/spi/spi-bcm-mspi.c | 505 3 files

[PATCH 0/2] Add Broadcom MSPI driver

2015-05-12 Thread Jonathan Richardson
This patchset adds support for Broadcoms MSPI SPI controller. It can be found on various SoC's such as Cygnus. Jonathan Richardson (2): ARM: dts: Add binding for Broadcom MSPI driver. spi: bcm-mspi: Add support for Broadcom MSPI driver. .../devicetree/bindings/spi/brcm,mspi-spi.txt

[PATCH 1/2] ARM: dts: Add binding for Broadcom MSPI driver.

2015-05-12 Thread Jonathan Richardson
Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- .../devicetree/bindings/spi/brcm,mspi-spi.txt | 39 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/brcm,mspi-spi.txt diff --git a/Documentation/devicetree

[PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

2015-05-12 Thread Jonathan Richardson
The MSPI controller is a SPI controller found on various Broadcom SoC's such as Cygnus. Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers/spi/Kconfig|5 + drivers/spi/Makefile |1 + drivers/spi/spi-bcm-mspi.c | 505

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-12 Thread Jonathan Richardson
A bit more info is required here. Get timestamp: This is a bit more complicated. Currently the PTP driver does list management for timestamps from external timestamp channels. Timestamps from all channels go into the same list. In our driver we have a s/w FIFO for each client and it closely

[PATCH v7 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe

2015-05-12 Thread Jonathan Richardson
arunr...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com Signed-off-by: Tim Kryger tim.kry...@gmail.com Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers/pwm/pwm-bcm-kona.c |9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH v7 5/5] pwm: core: Set enable state properly on failed call to enable

2015-05-12 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson jonat

[PATCH v7 4/5] pwm: kona: Add debug info to config function

2015-05-12 Thread Jonathan Richardson
Adds debugging info to config function where duty cycle and period are calculated and verified. Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers/pwm/pwm-bcm-kona.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm

[PATCH v7 1/5] drivers: pwm: core: Add pwmchip_add_inversed

2015-05-12 Thread Jonathan Richardson
. Signed-off-by: Tim Kryger tim.kry...@gmail.com Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers/pwm/core.c | 36 include/linux/pwm.h |6 ++ 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/pwm/core.c b/drivers

[PATCH v7 0/5] Fix bugs in kona pwm driver and pwm core

2015-05-12 Thread Jonathan Richardson
polarity is set properly now when the pwm driver is registered with the pwm framework. Arun Ramamurthy (1): drivers: pwm: bcm-kona: Dont set polarity in probe Jonathan Richardson (3): pwm: kona: Fix incorrect config, disable, and polarity procedures pwm: kona: Add debug info to config

[PATCH v7 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-12 Thread Jonathan Richardson
...@broadcom.com Tested-by: Scott Branden sbran...@broadcom.com Signed-off-by: Jonathan Richardson jonat...@broadcom.com --- drivers/pwm/pwm-bcm-kona.c | 47 +--- 1 file changed, 36 insertions(+), 11 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm

Re: [PATCH v6 3/4] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-11 Thread Jonathan Richardson
Tim, just one comment below. All other suggestions will be made for the next patch set. On 15-05-06 09:26 PM, Tim Kryger wrote: > On Fri, Apr 10, 2015 at 11:58 AM, Jonathan Richardson > wrote: > >> The polarity procedure no longer applies the settings to change the >>

Re: [PATCH v6 3/4] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-11 Thread Jonathan Richardson
Tim, just one comment below. All other suggestions will be made for the next patch set. On 15-05-06 09:26 PM, Tim Kryger wrote: On Fri, Apr 10, 2015 at 11:58 AM, Jonathan Richardson jonat...@broadcom.com wrote: The polarity procedure no longer applies the settings to change the output

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-08 Thread Jonathan Richardson
On 15-05-01 12:40 PM, Arnd Bergmann wrote: > On Friday 01 May 2015 20:30:04 One Thousand Gnomes wrote: >> >>> channel control, unless I'm missing something. If people are flexible >>> with extending that I could propose something. Let me know which way you >>> prefer to go. Thanks. >> >> I would

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-08 Thread Jonathan Richardson
On 15-05-01 12:40 PM, Arnd Bergmann wrote: On Friday 01 May 2015 20:30:04 One Thousand Gnomes wrote: channel control, unless I'm missing something. If people are flexible with extending that I could propose something. Let me know which way you prefer to go. Thanks. I would strongly favour

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-01 Thread Jonathan Richardson
Arnd, some more info is provided and also some questions before I can proceed. On 15-04-23 01:04 AM, Arnd Bergmann wrote: > On Wednesday 22 April 2015 16:22:03 Jonathan Richardson wrote: >> Reviewed-by: Scott Branden >> Tested-by: Scott Branden >> Signed-off-by

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-05-01 Thread Jonathan Richardson
Arnd, some more info is provided and also some questions before I can proceed. On 15-04-23 01:04 AM, Arnd Bergmann wrote: On Wednesday 22 April 2015 16:22:03 Jonathan Richardson wrote: Reviewed-by: Scott Branden sbran...@broadcom.com Tested-by: Scott Branden sbran...@broadcom.com Signed-off

Re: [PATCH v6 0/4] Fix bugs in kona pwm driver and pwm core

2015-04-28 Thread Jonathan Richardson
possibly make a new cygnus pwm driver, though it would be mostly the same as the existing kona driver. Or add a DT version to the existing driver that has the new modified behaviour - though I think this would be messy. Thanks. On 15-04-10 11:58 AM, Jonathan Richardson wrote: > This patchset fi

Re: [PATCH v6 0/4] Fix bugs in kona pwm driver and pwm core

2015-04-28 Thread Jonathan Richardson
possibly make a new cygnus pwm driver, though it would be mostly the same as the existing kona driver. Or add a DT version to the existing driver that has the new modified behaviour - though I think this would be messy. Thanks. On 15-04-10 11:58 AM, Jonathan Richardson wrote: This patchset fixes

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-04-23 Thread Jonathan Richardson
Hi Arnd, Thanks for the initial feedback. I'll investigate your suggestions and get back to you if I have any questions before making some of the API changes you've suggested. On 15-04-23 01:04 AM, Arnd Bergmann wrote: > On Wednesday 22 April 2015 16:22:03 Jonathan Richardson wrote: >>

Re: [PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-04-23 Thread Jonathan Richardson
Hi Arnd, Thanks for the initial feedback. I'll investigate your suggestions and get back to you if I have any questions before making some of the API changes you've suggested. On 15-04-23 01:04 AM, Arnd Bergmann wrote: On Wednesday 22 April 2015 16:22:03 Jonathan Richardson wrote: Reviewed

[PATCH 1/2] misc: Add DT binding for cygnus Digital Timing Engine (DTE) driver.

2015-04-22 Thread Jonathan Richardson
Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- .../bindings/arm/bcm/brcm,cygnus-dte.txt | 24 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,cygnus-dte.txt diff

[PATCH 2/2] misc: Add initial Digital Timing Engine (DTE) driver for cygnus

2015-04-22 Thread Jonathan Richardson
Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/misc/Kconfig | 11 + drivers/misc/Makefile |1 + drivers/misc/bcm_cygnus_dte.c | 927 include/linux/bcm_cygnus_dte.h | 99

[PATCH 0/2] Add DTE driver for Cygnus

2015-04-22 Thread Jonathan Richardson
This patchset includes the Digital Timing Engine (DTE) driver for Cygnus SoC's. Jonathan Richardson (2): misc: Add DT binding for cygnus Digital Timing Engine (DTE) driver. misc: Add initial Digital Timing Engine (DTE) driver for cygnus .../bindings/arm/bcm/brcm,cygnus-dte.txt

  1   2   3   >