[PATCH 3/4] kconfig: Regenerate parser with current Bison prior to making changes

2015-05-13 Thread Josh Triplett
Before making changes to the parser, regenerate the parser with current Bison to avoid mixing those changes with those produced by updating Bison. Signed-off-by: Josh Triplett --- scripts/kconfig/zconf.tab.c_shipped | 1244 --- 1 file changed, 561 insertions

[PATCH 2/4] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-13 Thread Josh Triplett
init/Kconfig.expert, to make this harder to do accidentally, and to break up the exceedingly long init/Kconfig a bit. Signed-off-by: Josh Triplett --- init/Kconfig| 232 +--- init/Kconfig.expert | 231

[PATCH 1/4] init/Kconfig: Fix break in middle of EXPERT menu

2015-05-13 Thread Josh Triplett
_TRACING kernels, make it more configurable") Signed-off-by: Josh Triplett --- init/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index dc24dec..e2f16f1 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1341,6 +13

Re: [RFC PATCH v6] Documentation/arch: Add Documentation/arch-features.txt

2015-05-13 Thread Josh Triplett
On Wed, May 13, 2015 at 09:27:57AM -0700, Josh Triplett wrote: > How likely is this to get out of date? Are people going to remember to > patch this when they add a feature to their architecture? If > they found out they had work to do by reading this file, which is the > goal,

Re: [PATCH tip/core/rcu 2/3] rcutorture: Test both RCU-sched and RCU-bh for Tiny RCU

2015-05-13 Thread Josh Triplett
t; > This change resulted in the test failure caused by list mishandling, > which is fixed by the next commit. > > Reported-by: "Ahmed, Iftekhar" > Signed-off-by: Paul E. McKenney > Much better, thanks. In particular, the information about TINY01 and TINY02 was

Re: [RFC PATCH v6] Documentation/arch: Add Documentation/arch-features.txt

2015-05-13 Thread Josh Triplett
On Wed, May 13, 2015 at 03:48:42PM +0200, Ingo Molnar wrote: > From 93f6bd67b4348bf4bf27cbac8ffa9f1def4fa6aa Mon Sep 17 00:00:00 2001 > From: Ingo Molnar > Date: Wed, 13 May 2015 10:30:11 +0200 > Subject: [PATCH] Documentation/arch: Add Documentation/arch-features.txt > > Add a support matrix

[PATCH 3/4] kconfig: Regenerate parser with current Bison prior to making changes

2015-05-13 Thread Josh Triplett
Before making changes to the parser, regenerate the parser with current Bison to avoid mixing those changes with those produced by updating Bison. Signed-off-by: Josh Triplett j...@joshtriplett.org --- scripts/kconfig/zconf.tab.c_shipped | 1244 --- 1 file changed

[PATCH 2/4] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-13 Thread Josh Triplett
this harder to do accidentally, and to break up the exceedingly long init/Kconfig a bit. Signed-off-by: Josh Triplett j...@joshtriplett.org --- init/Kconfig| 232 +--- init/Kconfig.expert | 231

[PATCH 1/4] init/Kconfig: Fix break in middle of EXPERT menu

2015-05-13 Thread Josh Triplett
configurable) Signed-off-by: Josh Triplett j...@joshtriplett.org --- init/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index dc24dec..e2f16f1 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1341,6 +1341,16 @@ config

[PATCH 4/4] kconfig: Introduce showif to factor out conditions on visibility

2015-05-13 Thread Josh Triplett
... endif block effectively has if expr added to its prompt. Use that new construct to simplify the expert menu. Now, making a symbol no longer invisible when !EXPERT requires moving it out of the EXPERT menu, which makes it more difficult to break the EXPERT menu. Signed-off-by: Josh Triplett j

Re: [RFC PATCH v6] Documentation/arch: Add Documentation/arch-features.txt

2015-05-13 Thread Josh Triplett
On Wed, May 13, 2015 at 03:48:42PM +0200, Ingo Molnar wrote: From 93f6bd67b4348bf4bf27cbac8ffa9f1def4fa6aa Mon Sep 17 00:00:00 2001 From: Ingo Molnar mi...@kernel.org Date: Wed, 13 May 2015 10:30:11 +0200 Subject: [PATCH] Documentation/arch: Add Documentation/arch-features.txt Add a support

Re: [PATCH tip/core/rcu 2/3] rcutorture: Test both RCU-sched and RCU-bh for Tiny RCU

2015-05-13 Thread Josh Triplett
, Iftekhar ahm...@onid.oregonstate.edu Signed-off-by: Paul E. McKenney paul...@linux.vnet.ibm.com Much better, thanks. In particular, the information about TINY01 and TINY02 was not obvious from the patch. Reviewed-by: Josh Triplett j...@joshtriplett.org -- To unsubscribe from this list: send the line

Re: [RFC PATCH v6] Documentation/arch: Add Documentation/arch-features.txt

2015-05-13 Thread Josh Triplett
On Wed, May 13, 2015 at 09:27:57AM -0700, Josh Triplett wrote: How likely is this to get out of date? Are people going to remember to patch this when they add a feature to their architecture? If they found out they had work to do by reading this file, which is the goal, then they'll likely

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-12 Thread Josh Triplett
On Tue, May 12, 2015 at 10:17:28AM +0200, Ingo Molnar wrote: > * Josh Triplett wrote: > > > Looks good to me, but I have not looked very deeply ... > > > > I sent out a v2 with the co-author information moved from the > > signoffs to the commit message. If i

Re: [PATCH] init/Kconfig: Fix break in middle of EXPERT menu

2015-05-12 Thread Josh Triplett
On Tue, May 12, 2015 at 09:04:55AM +0200, Ingo Molnar wrote: > > * Josh Triplett wrote: > > > Commit e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y && > > !CONFIG_TRACING kernels, make it more configurable") made BPF_SYSCALL no > > longer h

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-12 Thread Josh Triplett
On Tue, May 12, 2015 at 09:56:58AM +0530, Vineet Gupta wrote: > On Monday 11 May 2015 08:17 PM, Josh Triplett wrote: > > On Mon, May 11, 2015 at 02:31:39PM +, Vineet Gupta wrote: > >> On Tuesday 21 April 2015 11:17 PM, Josh Triplett wrote: > >>> clone with CL

Re: [PATCH] init/Kconfig: Fix break in middle of EXPERT menu

2015-05-12 Thread Josh Triplett
On Tue, May 12, 2015 at 09:04:55AM +0200, Ingo Molnar wrote: * Josh Triplett j...@joshtriplett.org wrote: Commit e1abf2cc8d5 (bpf: Fix the build on BPF_SYSCALL=y !CONFIG_TRACING kernels, make it more configurable) made BPF_SYSCALL no longer hidden with !EXPERT, but left

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-12 Thread Josh Triplett
On Tue, May 12, 2015 at 09:56:58AM +0530, Vineet Gupta wrote: On Monday 11 May 2015 08:17 PM, Josh Triplett wrote: On Mon, May 11, 2015 at 02:31:39PM +, Vineet Gupta wrote: On Tuesday 21 April 2015 11:17 PM, Josh Triplett wrote: clone with CLONE_SETTLS accepts an argument to set

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-12 Thread Josh Triplett
On Tue, May 12, 2015 at 10:17:28AM +0200, Ingo Molnar wrote: * Josh Triplett j...@joshtriplett.org wrote: Looks good to me, but I have not looked very deeply ... I sent out a v2 with the co-author information moved from the signoffs to the commit message. If it looks reasonable to you

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Tue, May 12, 2015 at 12:36:49AM +0200, Luis R. Rodriguez wrote: > On Mon, May 11, 2015 at 01:23:02PM -0700, Josh Triplett wrote: > > init/Kconfig| 232 > > +--- > > init

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Tue, May 12, 2015 at 12:01:27AM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 14:47 -0700, Josh Triplett wrote: > > On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: > > > Is squashing those two lines worth a new kconfig mechanism? > > > > I

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > > --- /dev/null > > +++ b/init/Kconfig.expert > > @@ -0,0 +1,231 @@ > > +menuconfig EXPERT > > + bool "Configure standard kernel features

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 14:18 -0700, Josh Triplett wrote: > > However, that would produce *two* entries under the "General setup" > > menu: a yes/no entry "Configure standard kernel features (expe

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:01:22PM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > > I'd also like to factor the "if EXPERT" off of all the prompts and into a > > single scoped item wrapped around all of them, but kconfig doesn't ha

[PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
init/Kconfig.expert, to make this harder to do accidentally, and to break up the exceedingly long init/Kconfig a bit. Signed-off-by: Josh Triplett --- This applies on top of "init/Kconfig: Fix break in middle of EXPERT menu". Please apply both. I'd also like to factor the &quo

[PATCHv2 2/2] x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit

2015-05-11 Thread Josh Triplett
For 32-bit userspace on a 64-bit kernel, this requires modifying stub32_clone to actually swap the appropriate arguments to match CONFIG_CLONE_BACKWARDS, rather than just leaving the C argument for tls broken. Patch co-authored by Josh Triplett and Thiago Macieira. Signed-off-by: Josh Triplett

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 04:00:43PM +0200, Ingo Molnar wrote: > > * Josh Triplett wrote: > > > On Mon, May 11, 2015 at 12:13:13PM +0200, Ingo Molnar wrote: > > > > > > * j...@joshtriplett.org wrote: > > > > > > > On Tue, M

[PATCHv2 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
to sys_clone in favor of the pt_regs captured at kernel entry, and thus will be unable to introduce new versions of the clone syscall. Patch co-authored by Josh Triplett and Thiago Macieira. Signed-off-by: Josh Triplett Acked-by: Andy Lutomirski --- arch/Kconfig | 7 ++ include/linux

[PATCHv2 0/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
co-author from signoffs to a note in the commit message, as required by Ingo Molnar. Josh Triplett (2): clone: Support passing tls argument via C rather than pt_regs magic x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit arch/Kconfig | 7 ++ arch/x

Re: [PATCH] force inlining of spinlock ops

2015-05-11 Thread Josh Triplett
e. > Signed-off-by: Denys Vlasenko > Cc: Thomas Graf > Cc: David S. Miller > Cc: Bart Van Assche > Cc: Peter Zijlstra > Cc: David Rientjes > Cc: David S. Miller > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: Oleg Nesterov > Cc: Paul E. McKenney > Cc: Ingo

[PATCH] init/Kconfig: Fix break in middle of EXPERT menu

2015-05-11 Thread Josh Triplett
_TRACING kernels, make it more configurable") Signed-off-by: Josh Triplett --- Ingo, do you want to take this through -tip? Or should this go through some other tree? I'm also thinking about splitting the entire EXPERT menu into a separate Kconfig.expert and including it from init/Kconf

Re: [PATCH V4] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
lversion-next is -next-20150511) and fixes > > Signed-off-by: Nicholas Mc Guire Seems like a reasonable addition. Reviewed-by: Josh Triplett > --- > > V4: fix-up to include the origin of the issue being fixed as requeseted by > Steven Rostedt . > > kernel/rcu/tree.c |

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
int != bool, > > Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y) > > Patch is against 4.1-rc3 (localversion-next is -next-20150511) > > Signed-off-by: Nicholas Mc Guire Reviewed-by: Josh Triplett Thanks! > --- > > V3: fix-up of commit m

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
if the specified > > CPU has any callback", this probably should be a bool. All (3) > > call-sites currently treat it as bool so the declaration. > > > > > > Signed-off-by: Nicholas Mc Guire > > --- > > > > V2: fixed up commit messag

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 02:31:39PM +, Vineet Gupta wrote: > On Tuesday 21 April 2015 11:17 PM, Josh Triplett wrote: > > clone with CLONE_SETTLS accepts an argument to set the thread-local > > storage area for the new thread. sys_clone declares an int argument > > tls_v

Re: [PATCH] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
s probably should be a bool > All (3) call sites are conditions and are treating it as boolean. > > Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y) ...some of this information should be in the commit message, as well as a description of what tool produced th

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 12:13:13PM +0200, Ingo Molnar wrote: > > * j...@joshtriplett.org wrote: > > > On Tue, May 05, 2015 at 08:53:03PM +0200, Thomas Gleixner wrote: > > > On Tue, 21 Apr 2015, Josh Triplett wrote: > > > > > > > > Signed-off-

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 12:13:13PM +0200, Ingo Molnar wrote: * j...@joshtriplett.org j...@joshtriplett.org wrote: On Tue, May 05, 2015 at 08:53:03PM +0200, Thomas Gleixner wrote: On Tue, 21 Apr 2015, Josh Triplett wrote: Signed-off-by: Josh Triplett j...@joshtriplett.org

Re: [PATCH] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
are conditions and are treating it as boolean. Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y) ...some of this information should be in the commit message, as well as a description of what tool produced this warning. With that changed, Reviewed-by: Josh Triplett j

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 02:31:39PM +, Vineet Gupta wrote: On Tuesday 21 April 2015 11:17 PM, Josh Triplett wrote: clone with CLONE_SETTLS accepts an argument to set the thread-local storage area for the new thread. sys_clone declares an int argument tls_val in the appropriate point

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
CPU has any callback, this probably should be a bool. All (3) call-sites currently treat it as bool so the declaration. Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- V2: fixed up commit message and tool infos as requested by Josh Triplett j...@joshtriplett.org

[PATCH] init/Kconfig: Fix break in middle of EXPERT menu

2015-05-11 Thread Josh Triplett
configurable) Signed-off-by: Josh Triplett j...@joshtriplett.org --- Ingo, do you want to take this through -tip? Or should this go through some other tree? I'm also thinking about splitting the entire EXPERT menu into a separate Kconfig.expert and including it from init/Kconfig, to make it clear

Re: [PATCH] force inlining of spinlock ops

2015-05-11 Thread Josh Triplett
Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Ingo Molnar mi...@kernel.org Cc: Paul E. McKenney paul...@linux.vnet.ibm.com CC: linux-kernel@vger.kernel.org Reviewed-by: Josh Triplett j...@joshtriplett.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCHv2 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
to sys_clone in favor of the pt_regs captured at kernel entry, and thus will be unable to introduce new versions of the clone syscall. Patch co-authored by Josh Triplett and Thiago Macieira. Signed-off-by: Josh Triplett j...@joshtriplett.org Acked-by: Andy Lutomirski l...@kernel.org --- arch/Kconfig

Re: [PATCH V4] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
...@osadl.org Seems like a reasonable addition. Reviewed-by: Josh Triplett j...@joshtriplett.org --- V4: fix-up to include the origin of the issue being fixed as requeseted by Steven Rostedt rost...@goodmis.org. kernel/rcu/tree.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCHv2 2/2] x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit

2015-05-11 Thread Josh Triplett
For 32-bit userspace on a 64-bit kernel, this requires modifying stub32_clone to actually swap the appropriate arguments to match CONFIG_CLONE_BACKWARDS, rather than just leaving the C argument for tls broken. Patch co-authored by Josh Triplett and Thiago Macieira. Signed-off-by: Josh Triplett j

Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 04:00:43PM +0200, Ingo Molnar wrote: * Josh Triplett j...@joshtriplett.org wrote: On Mon, May 11, 2015 at 12:13:13PM +0200, Ingo Molnar wrote: * j...@joshtriplett.org j...@joshtriplett.org wrote: On Tue, May 05, 2015 at 08:53:03PM +0200, Thomas

[PATCHv2 0/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-05-11 Thread Josh Triplett
signoffs to a note in the commit message, as required by Ingo Molnar. Josh Triplett (2): clone: Support passing tls argument via C rather than pt_regs magic x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit arch/Kconfig | 7 ++ arch/x86/Kconfig

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 14:18 -0700, Josh Triplett wrote: However, that would produce *two* entries under the General setup menu: a yes/no entry Configure standard kernel features (expert users) with no submenu, and a Some separate

[PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
this harder to do accidentally, and to break up the exceedingly long init/Kconfig a bit. Signed-off-by: Josh Triplett j...@joshtriplett.org --- This applies on top of init/Kconfig: Fix break in middle of EXPERT menu. Please apply both. I'd also like to factor the if EXPERT off of all the prompts

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:01:22PM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: I'd also like to factor the if EXPERT off of all the prompts and into a single scoped item wrapped around all of them, but kconfig doesn't have any way to do

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: --- /dev/null +++ b/init/Kconfig.expert @@ -0,0 +1,231 @@ +menuconfig EXPERT + bool Configure standard kernel features (expert users) + # Unhide debug options

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Tue, May 12, 2015 at 12:36:49AM +0200, Luis R. Rodriguez wrote: On Mon, May 11, 2015 at 01:23:02PM -0700, Josh Triplett wrote: init/Kconfig| 232 +--- init/Kconfig.expert | 231

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Tue, May 12, 2015 at 12:01:27AM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 14:47 -0700, Josh Triplett wrote: On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: Is squashing those two lines worth a new kconfig mechanism? In my opinion, yes. If you use the implicit

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
with x86_64_defconfig (implies CONFIG_TREE_RCU=y) Patch is against 4.1-rc3 (localversion-next is -next-20150511) Signed-off-by: Nicholas Mc Guire hof...@osadl.org Reviewed-by: Josh Triplett j...@joshtriplett.org Thanks! --- V3: fix-up of commit message again (hope I got it right this time

Re: [RFC] init.h: mark init functions hot instead of cold

2015-05-09 Thread Josh Triplett
ery stable in > > each case, so I think the 2% is ok, but of course only applies to that > > specific .config running in a virtual machine on my hardware. > > 2% on boot is basically noise. I disagree; there are people working on shaving milliseconds from boot. - Josh Triplett -- To unsub

Re: [RFC] init.h: mark init functions hot instead of cold

2015-05-09 Thread Josh Triplett
in a virtual machine on my hardware. 2% on boot is basically noise. I disagree; there are people working on shaving milliseconds from boot. - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

[PATCH] uidgid: Make uid_valid and gid_valid work with !CONFIG_MULTIUSER

2015-05-07 Thread Josh Triplett
in the normal CONFIG_MULTIUSER=y case, but with !CONFIG_MULTIUSER will make {u,g}id_valid constant-fold into "return true;" rather than "return false;". This fixes uses of devpts without CONFIG_MULTIUSER. Signed-off-by: Josh Triplett --- include/linux/uidgid.h | 4 ++-

[PATCHv2] devpts: If initialization failed, don't crash when opening /dev/ptmx

2015-05-07 Thread Josh Triplett
and devpts_pty_new fail gracefully with ENODEV in that case, which then becomes the return value to the userspace open call on /dev/ptmx. Signed-off-by: Josh Triplett Reviewed-by: Peter Hurley --- v2: Fix copy-paste error caught by Peter Hurley. As mentioned in v1, this is separate from fixing the bug

[PATCH] uidgid: Make uid_valid and gid_valid work with !CONFIG_MULTIUSER

2015-05-07 Thread Josh Triplett
in the normal CONFIG_MULTIUSER=y case, but with !CONFIG_MULTIUSER will make {u,g}id_valid constant-fold into return true; rather than return false;. This fixes uses of devpts without CONFIG_MULTIUSER. Signed-off-by: Josh Triplett j...@joshtriplett.org --- include/linux/uidgid.h | 4 ++-- 1 file

[PATCHv2] devpts: If initialization failed, don't crash when opening /dev/ptmx

2015-05-07 Thread Josh Triplett
and devpts_pty_new fail gracefully with ENODEV in that case, which then becomes the return value to the userspace open call on /dev/ptmx. Signed-off-by: Josh Triplett j...@joshtriplett.org Reviewed-by: Peter Hurley pe...@hurleysoftware.com --- v2: Fix copy-paste error caught by Peter Hurley. As mentioned

[PATCH] devpts: If initialization failed, don't crash when opening /dev/ptmx

2015-05-06 Thread Josh Triplett
and devpts_pty_new fail gracefully with ENODEV in that case, which then becomes the return value to the userspace open call on /dev/ptmx. Signed-off-by: Josh Triplett --- This fixes a crash found by Fengguang Wu's 0-day service ("BUG: unable to handle kernel paging request at ffee"). It doesn

[PATCH] devpts: If initialization failed, don't crash when opening /dev/ptmx

2015-05-06 Thread Josh Triplett
and devpts_pty_new fail gracefully with ENODEV in that case, which then becomes the return value to the userspace open call on /dev/ptmx. Signed-off-by: Josh Triplett j...@joshtriplett.org --- This fixes a crash found by Fengguang Wu's 0-day service (BUG: unable to handle kernel paging request at ffee

Re: [PATCH] rcu: declare rcu_data variables in the section they are defined in

2015-05-03 Thread Josh Triplett
ree.h. > > This makes clang report a section mismatch (-Wsection warning) when > building LLVMLinux because the variables are declared in .data..percpu > but defined in .data..percpu..shared_aligned. > > Signed-off-by: Nicolas Iooss Good catch. Reviewed-by: Josh Triplett >

Re: [PATCH] rcu: declare rcu_data variables in the section they are defined in

2015-05-03 Thread Josh Triplett
report a section mismatch (-Wsection warning) when building LLVMLinux because the variables are declared in .data..percpu but defined in .data..percpu..shared_aligned. Signed-off-by: Nicolas Iooss nicolas.iooss_li...@m4x.org Good catch. Reviewed-by: Josh Triplett j...@joshtriplett.org

Re: [CONFIG_MULTIUSER] init: error.c:320: Assertion failed in nih_error_get: CURRENT_CONTEXT->error != NULL

2015-05-02 Thread Josh Triplett
g would already not be expected to boot unmodified Ubuntu. - Josh triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [CONFIG_MULTIUSER] init: error.c:320: Assertion failed in nih_error_get: CURRENT_CONTEXT-error != NULL

2015-05-02 Thread Josh Triplett
not be expected to boot unmodified Ubuntu. - Josh triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-23 Thread Josh Triplett
On Thu, Apr 23, 2015 at 08:24:38AM +0200, Ingo Molnar wrote: > * Josh Triplett wrote: > > On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: > > > On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett > > > wrote: > > > > > > > > I do th

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-23 Thread Josh Triplett
On Thu, Apr 23, 2015 at 08:24:38AM +0200, Ingo Molnar wrote: * Josh Triplett j...@joshtriplett.org wrote: On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett j...@joshtriplett.org wrote: I do think my two-patch

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Josh Triplett
On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: > On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett wrote: > > > > I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing > > this > > Ugh, I absolutely detesrt that patch. > >

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Josh Triplett
r comment on top of the two-patch series I just sent? Thanks, Josh Triplett > --Andy > > > > > Signed-off-by: Denys Vlasenko > > CC: Linus Torvalds > > CC: Steven Rostedt > > CC: Ingo Molnar > > CC: Borislav Petkov > > CC: "H. Peter Anvin

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Josh Triplett
, Josh Triplett --Andy Signed-off-by: Denys Vlasenko dvlas...@redhat.com CC: Linus Torvalds torva...@linux-foundation.org CC: Steven Rostedt rost...@goodmis.org CC: Ingo Molnar mi...@kernel.org CC: Borislav Petkov b...@alien8.de CC: H. Peter Anvin h...@zytor.com CC: Andy Lutomirski l

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Josh Triplett
On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett j...@joshtriplett.org wrote: I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing this Ugh, I absolutely detesrt that patch. Don't make random crazy

[PATCH 2/2] x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit

2015-04-21 Thread Josh Triplett
For 32-bit userspace on a 64-bit kernel, this requires modifying stub32_clone to actually swap the appropriate arguments to match CONFIG_CLONE_BACKWARDS, rather than just leaving the C argument for tls broken. Signed-off-by: Josh Triplett Signed-off-by: Thiago Macieira Acked-by: Andy Lutomirski

[PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-04-21 Thread Josh Triplett
to sys_clone in favor of the pt_regs captured at kernel entry, and thus will be unable to introduce new versions of the clone syscall. Signed-off-by: Josh Triplett Signed-off-by: Thiago Macieira Acked-by: Andy Lutomirski --- arch/Kconfig | 7 ++ include/linux/sched.h| 14

[PATCH 0/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-04-21 Thread Josh Triplett
have acks. I'd like to go ahead and submit these two so that other architectures can begin building on top of this and opting into HAVE_COPY_THREAD_TLS. However, I'm also happy to wait and send these through the next merge window (along with v3 of clone4) if anyone would prefer that. Josh T

[PATCH 0/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-04-21 Thread Josh Triplett
. I'd like to go ahead and submit these two so that other architectures can begin building on top of this and opting into HAVE_COPY_THREAD_TLS. However, I'm also happy to wait and send these through the next merge window (along with v3 of clone4) if anyone would prefer that. Josh Triplett (2

[PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

2015-04-21 Thread Josh Triplett
to sys_clone in favor of the pt_regs captured at kernel entry, and thus will be unable to introduce new versions of the clone syscall. Signed-off-by: Josh Triplett j...@joshtriplett.org Signed-off-by: Thiago Macieira thiago.macie...@intel.com Acked-by: Andy Lutomirski l...@kernel.org --- arch/Kconfig

[PATCH 2/2] x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit

2015-04-21 Thread Josh Triplett
For 32-bit userspace on a 64-bit kernel, this requires modifying stub32_clone to actually swap the appropriate arguments to match CONFIG_CLONE_BACKWARDS, rather than just leaving the C argument for tls broken. Signed-off-by: Josh Triplett j...@joshtriplett.org Signed-off-by: Thiago Macieira

Re: [PATCH] x86: Align jump targets to 1 byte boundaries

2015-04-11 Thread Josh Triplett
mp target optimization suggestion > > really worth this price? The patch below boots fine and I've not > > measured any noticeable slowdown, but I've not tried hard. > > Good point, adding Josh Triplett on CC. I suspect that he might be > interested. ;-) Quite intereste

Re: [PATCH] x86: Align jump targets to 1 byte boundaries

2015-04-11 Thread Josh Triplett
. Good point, adding Josh Triplett on CC. I suspect that he might be interested. ;-) Quite interested, yes. Even if there *are* benchmarks to support keeping the optimization (which wouldn't surprise me), it'd be nice to have a Kconfig option to enable the jump-target optimization. (With 'y

Re: [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor

2015-04-08 Thread Josh Triplett
ating flags/IDs/etc. No need for them to match the current clonefd_info structure if userspace has opted into a new version. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor

2015-04-08 Thread Josh Triplett
. If you pass a flag saying you can handle a new set of potential structures, those structures can then include any necessary disambiguating flags/IDs/etc. No need for them to match the current clonefd_info structure if userspace has opted into a new version. - Josh Triplett -- To unsubscribe from

Re: [PATCH v2 7/7] clone4: Add a CLONE_FD flag to get task exit notification via fd

2015-04-06 Thread Josh Triplett
On Mon, Apr 06, 2015 at 05:30:35PM +0900, Sergey Senozhatsky wrote: > On (03/15/15 01:00), Josh Triplett wrote: > [..] > > + > > +/* Handle the CLONE_FD case for copy_process. */ > > +int clonefd_do_clone(u64 clone_flags, struct task_struct *p, > > +st

Re: [PATCH v2 7/7] clone4: Add a CLONE_FD flag to get task exit notification via fd

2015-04-06 Thread Josh Triplett
On Mon, Apr 06, 2015 at 05:30:35PM +0900, Sergey Senozhatsky wrote: On (03/15/15 01:00), Josh Triplett wrote: [..] + +/* Handle the CLONE_FD case for copy_process. */ +int clonefd_do_clone(u64 clone_flags, struct task_struct *p, +struct clone4_args *args, struct

Re: [PATCH v2 7/7] clone4: Add a CLONE_FD flag to get task exit notification via fd

2015-03-25 Thread Josh Triplett
On Mon, Mar 23, 2015 at 05:38:45PM +, David Drysdale wrote: > On Sun, Mar 15, 2015 at 8:00 AM, Josh Triplett wrote: > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index 9daa017..1dc680b 100644 > > --- a/include/linux/sched.h > > +++ b/include/l

Re: [PATCH v2 7/7] clone4: Add a CLONE_FD flag to get task exit notification via fd

2015-03-25 Thread Josh Triplett
On Mon, Mar 23, 2015 at 05:38:45PM +, David Drysdale wrote: On Sun, Mar 15, 2015 at 8:00 AM, Josh Triplett j...@joshtriplett.org wrote: diff --git a/include/linux/sched.h b/include/linux/sched.h index 9daa017..1dc680b 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h

Re: [PATCH] reiserfs: kstrdup() memory handling

2015-03-22 Thread Josh Triplett
On Sun, Mar 22, 2015 at 08:12:46PM -0400, Sanidhya Kashyap wrote: > On Sat, Mar 21, 2015 at 1:15 PM, Josh Triplett wrote: > > On Sat, Mar 21, 2015 at 01:00:13PM -0400, Sanidhya Kashyap wrote: > >> Checking for ENOMEM even for new_opts in reiserfs_remount function as > >

Re: [PATCH] reiserfs: kstrdup() memory handling

2015-03-22 Thread Josh Triplett
On Sun, Mar 22, 2015 at 08:12:46PM -0400, Sanidhya Kashyap wrote: On Sat, Mar 21, 2015 at 1:15 PM, Josh Triplett j...@joshtriplett.org wrote: On Sat, Mar 21, 2015 at 01:00:13PM -0400, Sanidhya Kashyap wrote: Checking for ENOMEM even for new_opts in reiserfs_remount function

Re: [PATCH] reiserfs: kstrdup() memory handling

2015-03-21 Thread Josh Triplett
On Sat, Mar 21, 2015 at 01:00:13PM -0400, Sanidhya Kashyap wrote: > Checking for ENOMEM even for new_opts in reiserfs_remount function as > there is a possibility of nothing being allocated. You don't need to add a new label; kfree(NULL) is a no-op. > Signed-off-by: Sanidhya Kashyap > --- >

Re: [PATCH] reiserfs: kstrdup() memory handling

2015-03-21 Thread Josh Triplett
On Sat, Mar 21, 2015 at 01:00:13PM -0400, Sanidhya Kashyap wrote: Checking for ENOMEM even for new_opts in reiserfs_remount function as there is a possibility of nothing being allocated. You don't need to add a new label; kfree(NULL) is a no-op. Signed-off-by: Sanidhya Kashyap

Re: [RFC PATCH v13] sys_membarrier(): system/process-wide memory barrier (x86)

2015-03-17 Thread Josh Triplett
tely *always* supply a flags argument with any new syscall, even if you have no flags yet. As for QUERY, I assume that exists because the more expensive forms of barriers (e.g. expedited) are sufficiently invasive that you don't want to trigger one when not needed just to test if they work? If so, the

Re: [RFC PATCH v13] sys_membarrier(): system/process-wide memory barrier (x86)

2015-03-17 Thread Josh Triplett
no flags yet. As for QUERY, I assume that exists because the more expensive forms of barriers (e.g. expedited) are sufficiently invasive that you don't want to trigger one when not needed just to test if they work? If so, then yeah, having that flag seems fine. - Josh Triplett -- To unsubscribe

Re: [RFC PATCH] sys_membarrier(): system/process-wide memory barrier (x86) (v12)

2015-03-15 Thread Josh Triplett
ming nit fixed: Reviewed-by: Josh Triplett - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 5/7] clone4: Add a CLONE_AUTOREAP flag to automatically reap the child process

2015-03-15 Thread Josh Triplett
On Sun, Mar 15, 2015 at 08:55:06PM +0100, Oleg Nesterov wrote: > On 03/15, Josh Triplett wrote: > > On Sun, Mar 15, 2015 at 03:52:23PM +0100, Oleg Nesterov wrote: > > > On 03/15, Josh Triplett wrote: > > > > Add a CLONE_AUTOREAP flag to request this behavior un

Re: [PATCH v2 5/7] clone4: Add a CLONE_AUTOREAP flag to automatically reap the child process

2015-03-15 Thread Josh Triplett
On Sun, Mar 15, 2015 at 03:52:23PM +0100, Oleg Nesterov wrote: > On 03/15, Josh Triplett wrote: > > Add a CLONE_AUTOREAP flag to request this behavior unconditionally, > > Yes, CLONE_AUTOREAP is much better. And I agree (mostly) with that > we should rely on do_notify_par

Re: [PATCH 0/6] CLONE_FD: Task exit notification via file descriptor

2015-03-15 Thread Josh Triplett
On Sun, Mar 15, 2015 at 10:18:05AM +, David Drysdale wrote: > On Sat, Mar 14, 2015 at 7:29 PM, Josh Triplett wrote: > > On Sat, Mar 14, 2015 at 12:03:12PM -0700, Thiago Macieira wrote: > >> On Friday 13 March 2015 18:11:32 Thiago Macieira wrote: > >> > On Frid

Re: [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor

2015-03-15 Thread Josh Triplett
On Sun, Mar 15, 2015 at 12:59:17AM -0700, Josh Triplett wrote: > This patch series also introduces a clone flag CLONE_AUTOREAP, which causes > the > kernel to automatically reap the child process when it exits, just as it does > for processes using SIGCHLD when the parent has SIG

[PATCH v2 4/7] kernel/fork.c: Pass arguments to _do_fork and copy_process using clone4_args

2015-03-15 Thread Josh Triplett
structure initializers to only initialize the arguments they care about. Future extensions to clone4_args will thus not need to touch clone4, fork, vfork, or other callers of _do_fork. Signed-off-by: Josh Triplett Signed-off-by: Thiago Macieira --- kernel/fork.c | 77

[PATCH v2 man-pages] clone4.2: New manpage documenting clone4(2)

2015-03-15 Thread Josh Triplett
Also includes new cross-reference from clone.2. Signed-off-by: Josh Triplett --- man2/clone.2 | 1 + man2/clone4.2 | 345 ++ 2 files changed, 346 insertions(+) create mode 100644 man2/clone4.2 diff --git a/man2/clone.2 b/man2/clone.2

<    2   3   4   5   6   7   8   9   10   11   >