[PATCH] staging: dwc2: add check on dwc2_core_reset return

2013-11-20 Thread Julien DELACOU
If the GRSTCTL_CSFTRST self-clearing bit never comes back to 0 for any reason, the controller is under reset state and cannot be used. It's preferable to abort initialization in such case. Signed-off-by: Julien Delacou --- drivers/staging/dwc2/core.c | 58

[PATCH] staging: dwc2: add check on dwc2_core_reset return

2013-11-20 Thread Julien DELACOU
If the GRSTCTL_CSFTRST self-clearing bit never comes back to 0 for any reason, the controller is under reset state and cannot be used. It's preferable to abort initialization in such case. Signed-off-by: Julien Delacou julien.dela...@st.com --- drivers/staging/dwc2/core.c | 58

Re: [PATCH] staging: dwc2: do not clear pending interrupts twice

2013-11-15 Thread Julien DELACOU
On 11/15/2013 11:55 AM, Dan Carpenter wrote: > On Fri, Nov 15, 2013 at 11:39:38AM +0100, Julien DELACOU wrote: >> Pending interrupts clearing is done in dwc2_enable_common_interrupts >> so we don't need to do it twice. >> > Are there any user visible effects to thi

[PATCH] staging: dwc2: do not clear pending interrupts twice

2013-11-15 Thread Julien DELACOU
Pending interrupts clearing is done in dwc2_enable_common_interrupts so we don't need to do it twice. Signed-off-by: Julien Delacou --- drivers/staging/dwc2/core.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c index c8ff668

[PATCH] staging: dwc2: do not clear pending interrupts twice

2013-11-15 Thread Julien DELACOU
Pending interrupts clearing is done in dwc2_enable_common_interrupts so we don't need to do it twice. Signed-off-by: Julien Delacou julien.dela...@st.com --- drivers/staging/dwc2/core.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2

Re: [PATCH] staging: dwc2: do not clear pending interrupts twice

2013-11-15 Thread Julien DELACOU
On 11/15/2013 11:55 AM, Dan Carpenter wrote: On Fri, Nov 15, 2013 at 11:39:38AM +0100, Julien DELACOU wrote: Pending interrupts clearing is done in dwc2_enable_common_interrupts so we don't need to do it twice. Are there any user visible effects to this bug? How did you spot it? regards

[PATCH] staging: dwc2: fix value used in dwc2_set_all_params

2013-07-11 Thread Julien Delacou
From: Julien Delacou This fix uses 'value' parameter as it should be instead of hardcoded -1. Signed-off-by: Julien Delacou Acked-by: Paul Zimmerman --- drivers/staging/dwc2/hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dwc2/hcd.c b/drivers

[PATCH] staging: dwc2: fix value used in dwc2_set_all_params

2013-07-11 Thread Julien Delacou
From: Julien Delacou julien.dela...@stericsson.com This fix uses 'value' parameter as it should be instead of hardcoded -1. Signed-off-by: Julien Delacou julien.dela...@stericsson.com Acked-by: Paul Zimmerman pa...@synopys.com --- drivers/staging/dwc2/hcd.c |2 +- 1 file changed, 1

Re: [PATCH 1/2] pinctrl: add sleep mode management for hogs

2012-12-13 Thread Julien DELACOU
On 12/12/2012 08:31 PM, Linus Walleij wrote: On Tue, Dec 11, 2012 at 10:11 PM, Stephen Warren wrote: Since I assume those function are only supposed to be used by pinctrl drivers themselves, should the prototypes go into drivers/pinctrl/core.h or similar, rather than something in

Re: [PATCH 1/2] pinctrl: add sleep mode management for hogs

2012-12-13 Thread Julien DELACOU
On 12/12/2012 08:31 PM, Linus Walleij wrote: On Tue, Dec 11, 2012 at 10:11 PM, Stephen Warrenswar...@wwwdotorg.org wrote: Since I assume those function are only supposed to be used by pinctrl drivers themselves, should the prototypes go into drivers/pinctrl/core.h or similar, rather than