RE: [PATCH v4] HID: core: move Usage Page concatenation to Main item

On Thursday, March 28, 2019 6:49 AM Benjamin Tissoires wrote: >> >> Hi Nicolas, >> >> V4 looks good to me. > >Looks good to me too. > >Terry, can I consider this as a formal Rev-by you? Benjamin, Yes, thank you. What is the normal way of formally indicating Rev-by? Regards, Terry > >Cheers,

RE: [PATCH v4] HID: core: move Usage Page concatenation to Main item

Hi Nicolas, V4 looks good to me. Thanks, Terry >-Original Message- >Subject: [PATCH v4] HID: core: move Usage Page concatenation to Main item >

RE: [PATCH v3] HID: core: move Usage Page concatenation to Main item

Hi Nicolas, This patch looks good except for one comment/question below. Thanks, Terry On Tuesday, March 26, 2019 1:04 PM Nicolas Saenz Julienne wrote: > >As seen on some USB wireless keyboards manufactured by Primax, the HID >parser was using some assumptions that are not always true. In

RE: [RFC/RFT] HID: primax: Fix wireless keyboards descriptor

This could also be a parser error. In the HID specification section 6.2.2.8 it states that the last declared Usage Page is applied to Usages when the Main item is encountered. "If the bSize field = 1 or 2 then the Usage is interpreted as an unsigned value that selects a Usage ID on the

RE: [PATCH] Partially revert "HID: generic: create one input report per application type"

For what it's worth the Report Descriptor is a little questionable which could be causing the collection to split in two >-Original Message- >From: linux-input-ow...@vger.kernel.org [mailto:linux-input- >ow...@vger.kernel.org] On Behalf Of Benjamin Tissoires >Sent: Friday, August 31, 2018

RE: [PATCH] Partially revert "HID: generic: create one input report per application type"

For what it's worth the Report Descriptor is a little questionable which could be causing the collection to split in two >-Original Message- >From: linux-input-ow...@vger.kernel.org [mailto:linux-input- >ow...@vger.kernel.org] On Behalf Of Benjamin Tissoires >Sent: Friday, August 31, 2018