Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports

On Tue, Jan 16, 2018 at 1:18 AM, Sebastian Gottschall wrote: > >> According to my understanding of igmpv3_newpack(), the destination >> address should always be IGMPV3_ALL_MCR = 224.0.0.22. That is what I >> see in my testing. >> >> However, your packet trace says

Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports

On Tue, Jan 16, 2018 at 1:18 AM, Sebastian Gottschall wrote: > >> According to my understanding of igmpv3_newpack(), the destination >> address should always be IGMPV3_ALL_MCR = 224.0.0.22. That is what I >> see in my testing. >> >> However, your packet trace says 239.35.100.8. I don't know how

Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports

On Mon, Jan 15, 2018 at 8:44 PM, Sebastian Gottschall <s.gottsch...@dd-wrt.com> wrote: > Am 16.01.2018 um 05:32 schrieb Kevin Cernekee: >> >> On Mon, Jan 15, 2018 at 8:26 PM, Sebastian Gottschall >> <s.gottsch...@dd-wrt.com> wrote: >>> >>> hav

Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports

On Mon, Jan 15, 2018 at 8:44 PM, Sebastian Gottschall wrote: > Am 16.01.2018 um 05:32 schrieb Kevin Cernekee: >> >> On Mon, Jan 15, 2018 at 8:26 PM, Sebastian Gottschall >> wrote: >>> >>> havent check the source addresses right now. i basicly discovered

Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports

On Mon, Jan 15, 2018 at 8:26 PM, Sebastian Gottschall wrote: > havent check the source addresses right now. i basicly discovered that this > patch breaks the igmp routing and all traffic stops > this here is from a working system with the reverted patch. if you really >

Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports

On Mon, Jan 15, 2018 at 8:26 PM, Sebastian Gottschall wrote: > havent check the source addresses right now. i basicly discovered that this > patch breaks the igmp routing and all traffic stops > this here is from a working system with the reverted patch. if you really > need that i break it again

Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports

On Mon, Jan 15, 2018 at 7:50 PM, Sebastian Gottschall wrote: > please revert that on 4.9 and 4.14 > it breaks igmp routing. it can be reproduced with any iptv connection using > igmp-proxy. reverting this patch fixes the issue. Hi Sebastian, Is this the correct

Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports

On Mon, Jan 15, 2018 at 7:50 PM, Sebastian Gottschall wrote: > please revert that on 4.9 and 4.14 > it breaks igmp routing. it can be reproduced with any iptv connection using > igmp-proxy. reverting this patch fixes the issue. Hi Sebastian, Is this the correct igmp-proxy (based on mrouted)?

[PATCH] net: igmp: Use correct source address on IGMPv3 reports

hip=239.0.1.68:10.1.1.1 & sleep 1 ip addr del 10.1.1.1/24 dev dummy0 sleep 5 kill %tcpdump RFC 3376 specifies that the report must be sent with a valid IP source address from the destination subnet, or from address 0.0.0.0. Add an extra check to make sure this is the case. Si

[PATCH] net: igmp: Use correct source address on IGMPv3 reports

hip=239.0.1.68:10.1.1.1 & sleep 1 ip addr del 10.1.1.1/24 dev dummy0 sleep 5 kill %tcpdump RFC 3376 specifies that the report must be sent with a valid IP source address from the destination subnet, or from address 0.0.0.0. Add an extra check to make sure this is the case. Si

[PATCH V2] netlink: Add netns check on taps

-binary abc123 /tmp/nlmon.pcap Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- net/netlink/af_netlink.c | 3 +++ 1 file changed, 3 insertions(+) V1->V2: Drop the special exception for init_net. Compile-tested only, will retest later today. diff --git a/net/netlink/af_

[PATCH V2] netlink: Add netns check on taps

-binary abc123 /tmp/nlmon.pcap Signed-off-by: Kevin Cernekee --- net/netlink/af_netlink.c | 3 +++ 1 file changed, 3 insertions(+) V1->V2: Drop the special exception for init_net. Compile-tested only, will retest later today. diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlin

Re: [PATCH] netlink: Add netns check on taps

On Tue, Dec 5, 2017 at 6:19 PM, David Ahern wrote: >> + if (!net_eq(dev_net(dev), sock_net(sk)) && >> + !net_eq(dev_net(dev), _net)) { > > Why is init_net special? Seems like snooping should be limited to the > namespace you are in. Depends how important it is to

Re: [PATCH] netlink: Add netns check on taps

On Tue, Dec 5, 2017 at 6:19 PM, David Ahern wrote: >> + if (!net_eq(dev_net(dev), sock_net(sk)) && >> + !net_eq(dev_net(dev), _net)) { > > Why is init_net special? Seems like snooping should be limited to the > namespace you are in. Depends how important it is to preserve the current

[PATCH] netfilter: xt_osf: Add missing permission checks

_NET_ADMIN to bypass the netlink_net_capable() check: vpnns -- nfnl_osf -f /tmp/pf.os vpnns -- nfnl_osf -f /tmp/pf.os -d These non-root operations successfully modify the systemwide OS fingerprint list. Add new capable() checks so that they can't. Signed-off-by: Kevin Cernekee <cerne...

[PATCH] netfilter: xt_osf: Add missing permission checks

_NET_ADMIN to bypass the netlink_net_capable() check: vpnns -- nfnl_osf -f /tmp/pf.os vpnns -- nfnl_osf -f /tmp/pf.os -d These non-root operations successfully modify the systemwide OS fingerprint list. Add new capable() checks so that they can't. Signed-off-by: Kevin Cernekee --- net

[PATCH] netlink: Add netns check on taps

00 grep abc123 /tmp/nlmon.pcap Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- net/netlink/af_netlink.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index b9e0ee4..88381a2 100644 --- a/net/netlink/af_netlink

[PATCH] netlink: Add netns check on taps

00 grep abc123 /tmp/nlmon.pcap Signed-off-by: Kevin Cernekee --- net/netlink/af_netlink.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index b9e0ee4..88381a2 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netli

[PATCH] netfilter: nfnetlink_cthelper: Add missing permission checks

a_len = 24, .status = enabled, }; Add capable() checks in nfnetlink_cthelper, as this is cleaner than trying to generalize the solution. Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- net/netfilter/nfnetlink_cthelper.c | 10 ++ 1 file changed, 10 inserti

[PATCH] netfilter: nfnetlink_cthelper: Add missing permission checks

a_len = 24, .status = enabled, }; Add capable() checks in nfnetlink_cthelper, as this is cleaner than trying to generalize the solution. Signed-off-by: Kevin Cernekee --- net/netfilter/nfnetlink_cthelper.c | 10 ++ 1 file changed, 10 insertions(+) I think xt_osf ha

[PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing

ead of generating an error. Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- V1->V2: - Add comment and update changelog, per code review feedback - Rebase + retest on net-next net/netfilter/nf_conntrack_netlink.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-)

[PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing

ead of generating an error. Signed-off-by: Kevin Cernekee --- V1->V2: - Add comment and update changelog, per code review feedback - Rebase + retest on net-next net/netfilter/nf_conntrack_netlink.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/net/net

[PATCH V2 1/2] netfilter: ctnetlink: Fix regression in CTA_STATUS processing

and helpers because they operate on unconfirmed connections. Instead of returning -EBUSY if the user program asks to modify an unchangeable bit, simply ignore the change. Also, fix the logic so that user programs are allowed to clear the bits that they are allowed to change. Signed-off-by: Ke

[PATCH V2 1/2] netfilter: ctnetlink: Fix regression in CTA_STATUS processing

and helpers because they operate on unconfirmed connections. Instead of returning -EBUSY if the user program asks to modify an unchangeable bit, simply ignore the change. Also, fix the logic so that user programs are allowed to clear the bits that they are allowed to change. Signed-off-by: Ke

[PATCH 1/4] xfrm: Constify xfrm_user arguments and xfrm_mgr callback APIs

This provides a better sense of the data flow and inputs/outputs. No change to code size or functionality. Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- include/net/xfrm.h | 36 -- net/key/af_key.c | 34 +++-- net/xfrm/xfrm_policy.c | 8 +- net/xfrm/xfrm_s

[PATCH 0/4] Make xfrm usable by 32-bit programs

www.spinics.net/lists/netdev/msg126176.html Kevin Cernekee (4): xfrm: Constify xfrm_user arguments and xfrm_mgr callback APIs xfrm_user: Allow common functions to be called from another file xfrm_user: Initial commit of xfrm_user_legacy.c xfrm_user: Add new 32/64-agnostic netlink m

[PATCH 0/4] Make xfrm usable by 32-bit programs

www.spinics.net/lists/netdev/msg126176.html Kevin Cernekee (4): xfrm: Constify xfrm_user arguments and xfrm_mgr callback APIs xfrm_user: Allow common functions to be called from another file xfrm_user: Initial commit of xfrm_user_legacy.c xfrm_user: Add new 32/64-agnostic netlink m

[PATCH 1/4] xfrm: Constify xfrm_user arguments and xfrm_mgr callback APIs

This provides a better sense of the data flow and inputs/outputs. No change to code size or functionality. Signed-off-by: Kevin Cernekee --- include/net/xfrm.h | 36 -- net/key/af_key.c | 34 +++-- net/xfrm/xfrm_policy.c | 8 +- net/xfrm/xfrm_state.c | 2 +- net/xfrm

[PATCH 2/4] xfrm_user: Allow common functions to be called from another file

xfrm_user_legacy.c will need to call a few common functions. Make sure them have an "xfrm_" prefix, and declare them in a new xfrm_user.h header. Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- net/xfrm/xfrm_user.c | 147 +

[PATCH 2/4] xfrm_user: Allow common functions to be called from another file

xfrm_user_legacy.c will need to call a few common functions. Make sure them have an "xfrm_" prefix, and declare them in a new xfrm_user.h header. Signed-off-by: Kevin Cernekee --- net/xfrm/xfrm_user.c | 147 +-- net/xfrm/xfrm_us

[PATCH 4/4] xfrm_user: Add new 32/64-agnostic netlink messages

use the old format or the new format (for both requests and replies). For kernel->user multicasts, both types will be sent. setsockopt() will deduce the format from the length. Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- include/uapi/linux/xf

[PATCH 4/4] xfrm_user: Add new 32/64-agnostic netlink messages

use the old format or the new format (for both requests and replies). For kernel->user multicasts, both types will be sent. setsockopt() will deduce the format from the length. Signed-off-by: Kevin Cernekee --- include/uapi/linux/xfrm.h | 152 ++- ne

[PATCH 3/4] xfrm_user: Initial commit of xfrm_user_legacy.c

ecessary functions from xfrm_user.c, for ease of reviewing. The next commit will contain all of the changes needed to make these functions handle legacy messages correctly. Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- net/xfrm/Kconfig| 14 + net/xfrm/Makefile

[PATCH 3/4] xfrm_user: Initial commit of xfrm_user_legacy.c

ecessary functions from xfrm_user.c, for ease of reviewing. The next commit will contain all of the changes needed to make these functions handle legacy messages correctly. Signed-off-by: Kevin Cernekee --- net/xfrm/Kconfig| 14 + net/xfrm/Makefile |8 +- net/xfrm/

[RFC/PATCH 1/3] netfilter: ctnetlink: Fix regression in CTA_TIMEOUT processing

f 0 is set for an unconfirmed connection, restore the old behavior of ignoring it (rather than setting up a connection that expires immediately). Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- net/netfilter/nf_conntrack_netlink.c | 12 1 file changed, 8 insertions(+), 4 de

[RFC/PATCH 1/3] netfilter: ctnetlink: Fix regression in CTA_TIMEOUT processing

f 0 is set for an unconfirmed connection, restore the old behavior of ignoring it (rather than setting up a connection that expires immediately). Signed-off-by: Kevin Cernekee --- net/netfilter/nf_conntrack_netlink.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/net

[RFC/PATCH 2/3] netfilter: ctnetlink: Fix regression in CTA_STATUS processing

use they operate on unconfirmed connections. Instead of returning -EBUSY if the user program asks to modify an unchangeable bit, simply ignore the change. Also, fix the logic so that user programs are allowed to clear the bits that they are allowed to change. Signed-off-by: Kevin Cernekee <

[RFC/PATCH 3/3] netfilter: ctnetlink: Fix regression in CTA_HELP processing

If a user program specifies CTA_HELP but the argument matches the current conntrack helper name, ignore it instead of generating an error. Signed-off-by: Kevin Cernekee <cerne...@chromium.org> --- net/netfilter/nf_conntrack_netlink.c | 13 + 1 file changed, 9 insertions

[RFC/PATCH 2/3] netfilter: ctnetlink: Fix regression in CTA_STATUS processing

use they operate on unconfirmed connections. Instead of returning -EBUSY if the user program asks to modify an unchangeable bit, simply ignore the change. Also, fix the logic so that user programs are allowed to clear the bits that they are allowed to change. Signed-off-by: Kevin Cernekee --- incl

[RFC/PATCH 3/3] netfilter: ctnetlink: Fix regression in CTA_HELP processing

If a user program specifies CTA_HELP but the argument matches the current conntrack helper name, ignore it instead of generating an error. Signed-off-by: Kevin Cernekee --- net/netfilter/nf_conntrack_netlink.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/net

[RFC/PATCH 0/3] Fix ctnetlink regressions

remains bug-compatible with old user code. Kevin Cernekee (3): netfilter: ctnetlink: Fix regression in CTA_TIMEOUT processing netfilter: ctnetlink: Fix regression in CTA_STATUS processing netfilter: ctnetlink: Fix regression in CTA_HELP processing include/uapi/linux/netfilter/nf_conntrack_c

[RFC/PATCH 0/3] Fix ctnetlink regressions

remains bug-compatible with old user code. Kevin Cernekee (3): netfilter: ctnetlink: Fix regression in CTA_TIMEOUT processing netfilter: ctnetlink: Fix regression in CTA_STATUS processing netfilter: ctnetlink: Fix regression in CTA_HELP processing include/uapi/linux/netfilter/nf_conntrack_c

[PATCH] printk: Make %pS print offsets into modules

, print the offset from the module's base, so that the offending location can be easily located in a disassembly of the .ko file: Call trace: [] [mwifiex_pcie+0x37f4/0x9000] [] [mwifiex_pcie+0x40ac/0x9000] [] mwifiex_main_process+0xdc/0x6fc [mwifiex] Signed-off-by: Kevin Cernekee

[PATCH] printk: Make %pS print offsets into modules

, print the offset from the module's base, so that the offending location can be easily located in a disassembly of the .ko file: Call trace: [] [mwifiex_pcie+0x37f4/0x9000] [] [mwifiex_pcie+0x40ac/0x9000] [] mwifiex_main_process+0xdc/0x6fc [mwifiex] Signed-off-by: Kevin Cernekee

Re: [PATCH] MIPS: Flush cache after DMA_FROM_DEVICE for agressively speculative CPUs

On Wed, May 13, 2015 at 6:49 PM, Leonid Yegoshin wrote: > Some MIPS CPUs have an aggressive speculative load and may erroneuosly load > some cache line in the middle of DMA transaction. CPU discards result but > cache > doesn't. If DMA happens from device then additional cache invalidation is >

Re: [PATCH] MIPS: Flush cache after DMA_FROM_DEVICE for agressively speculative CPUs

On Wed, May 13, 2015 at 6:49 PM, Leonid Yegoshin leonid.yegos...@imgtec.com wrote: Some MIPS CPUs have an aggressive speculative load and may erroneuosly load some cache line in the middle of DMA transaction. CPU discards result but cache doesn't. If DMA happens from device then additional

Re: [PATCH V4 3/5] ASoC: tas571x: Add DT binding document

On Tue, May 5, 2015 at 3:32 PM, Mark Brown wrote: > On Tue, May 05, 2015 at 03:14:15PM -0700, Kevin Cernekee wrote: >> Document the bindings for the soon-to-be-added tas571x driver. > > If this is different to the already applied patches send incremental > updates. I

[PATCH] ASoC: tas571x: Eliminate redundant dev->of_node NULL check

of_match_device() checks if dev->of_node is NULL, so we don't need to do it again in the probe function. Signed-off-by: Kevin Cernekee --- This applies to the broonie/sound.git for-next branch. sound/soc/codecs/tas571x.c | 13 - 1 file changed, 4 insertions(+), 9 deleti

[PATCH V4 3/5] ASoC: tas571x: Add DT binding document

Document the bindings for the soon-to-be-added tas571x driver. Signed-off-by: Kevin Cernekee --- .../devicetree/bindings/sound/tas571x.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tas571x.txt diff --git

[PATCH V4 2/5] regmap: Use regcache_mark_dirty() to indicate power loss or reset

ed any writes, they should be sent to the hardware regardless of whether they match the HW default. Currently this will write out all values in the regcache, since we don't maintain per-register dirty bits. Suggested-by: Mark Brown Signed-off-by: Kevin Cernekee --- drivers/base/regmap/in

[PATCH V4 1/5] regmap: Add a helper function for regcache sync test

We're going to add another "does this register need syncing?" check, so rather than repeating it in three places, we'll separate all of the relevant logic into a helper function. Signed-off-by: Kevin Cernekee --- drivers/base/regmap/regcache.c | 26 +++--- 1 file c

[PATCH V4 4/5] ASoC: tas571x: New driver for TI TAS571x power amplifiers

Introduce a new codec driver for the Texas Instruments TAS5711/TAS5717/TAS5719 power amplifier chips. These chips are typically used to take an I2S digital audio input and drive 10-20W into a pair of speakers. Signed-off-by: Kevin Cernekee --- sound/soc/codecs/Kconfig | 5 + sound/soc

[PATCH V4 5/5] MAINTAINERS: Add entry for tas571x ASoC codec driver

Add self as maintainer for the new driver. Signed-off-by: Kevin Cernekee --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea0001760035..15153fc37cc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9878,6 +9878,12 @@ L: net

[PATCH V4 0/5] tas571x amplifier driver

V3->V4: Eliminate unnecessary dev->of_node NULL check. Move the "should I sync this register?" test into a common helper function. Clear map->no_sync_defaults at the end of the regcache_sync functions. Kevin Cernekee (5): regmap: Add a helper function for regcache sync

Re: [PATCH 3/6] MAINTAINERS: Remove section BROADCOM BCM33XX MIPS ARCHITECTURE

On Tue, May 5, 2015 at 9:32 AM, Joe Perches wrote: > commit 5f2d44591fb3 ("MIPS: bcm3384: Rename "bcm3384" target to "bmips"") > renamed the files and integrated them into an existing section. > > Remove the section. > > Signed-off-by: Joe Perches

Re: [PATCH V4 3/5] ASoC: tas571x: Add DT binding document

On Tue, May 5, 2015 at 3:32 PM, Mark Brown broo...@kernel.org wrote: On Tue, May 05, 2015 at 03:14:15PM -0700, Kevin Cernekee wrote: Document the bindings for the soon-to-be-added tas571x driver. If this is different to the already applied patches send incremental updates

[PATCH] ASoC: tas571x: Eliminate redundant dev-of_node NULL check

of_match_device() checks if dev-of_node is NULL, so we don't need to do it again in the probe function. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- This applies to the broonie/sound.git for-next branch. sound/soc/codecs/tas571x.c | 13 - 1 file changed, 4 insertions

[PATCH V4 4/5] ASoC: tas571x: New driver for TI TAS571x power amplifiers

Introduce a new codec driver for the Texas Instruments TAS5711/TAS5717/TAS5719 power amplifier chips. These chips are typically used to take an I2S digital audio input and drive 10-20W into a pair of speakers. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- sound/soc/codecs/Kconfig

[PATCH V4 0/5] tas571x amplifier driver

V3-V4: Eliminate unnecessary dev-of_node NULL check. Move the should I sync this register? test into a common helper function. Clear map-no_sync_defaults at the end of the regcache_sync functions. Kevin Cernekee (5): regmap: Add a helper function for regcache sync test regmap: Use

[PATCH V4 5/5] MAINTAINERS: Add entry for tas571x ASoC codec driver

Add self as maintainer for the new driver. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea0001760035..15153fc37cc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9878,6 +9878,12 @@ L

[PATCH V4 1/5] regmap: Add a helper function for regcache sync test

We're going to add another does this register need syncing? check, so rather than repeating it in three places, we'll separate all of the relevant logic into a helper function. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- drivers/base/regmap/regcache.c | 26

[PATCH V4 3/5] ASoC: tas571x: Add DT binding document

Document the bindings for the soon-to-be-added tas571x driver. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- .../devicetree/bindings/sound/tas571x.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound

[PATCH V4 2/5] regmap: Use regcache_mark_dirty() to indicate power loss or reset

, they should be sent to the hardware regardless of whether they match the HW default. Currently this will write out all values in the regcache, since we don't maintain per-register dirty bits. Suggested-by: Mark Brown broo...@kernel.org Signed-off-by: Kevin Cernekee cerne...@chromium.org --- drivers

Re: [PATCH 3/6] MAINTAINERS: Remove section BROADCOM BCM33XX MIPS ARCHITECTURE

On Tue, May 5, 2015 at 9:32 AM, Joe Perches j...@perches.com wrote: commit 5f2d44591fb3 (MIPS: bcm3384: Rename bcm3384 target to bmips) renamed the files and integrated them into an existing section. Remove the section. Signed-off-by: Joe Perches j...@perches.com cc: Kevin Cernekee cerne

Re: [PATCH V3 1/4] regmap: Use regcache_mark_dirty() to indicate power loss or reset

On Sun, May 3, 2015 at 11:38 PM, Lars-Peter Clausen wrote: >> diff --git a/drivers/base/regmap/regcache.c >> b/drivers/base/regmap/regcache.c >> index 7eb7b3b98794..63af3103d0c6 100644 >> --- a/drivers/base/regmap/regcache.c >> +++ b/drivers/base/regmap/regcache.c >> @@ -253,6 +253,9 @@ static

Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

On Mon, May 4, 2015 at 4:45 AM, Mark Brown wrote: > On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote: >> + if (dev->of_node) { >> + const struct of_device_id *of_id; >> + >> + of_id = of_match_device(tas571x_of_match, de

Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

On Mon, May 4, 2015 at 4:45 AM, Mark Brown broo...@kernel.org wrote: On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote: + if (dev-of_node) { + const struct of_device_id *of_id; + + of_id = of_match_device(tas571x_of_match, dev

Re: [PATCH V3 1/4] regmap: Use regcache_mark_dirty() to indicate power loss or reset

On Sun, May 3, 2015 at 11:38 PM, Lars-Peter Clausen l...@metafoo.de wrote: diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 7eb7b3b98794..63af3103d0c6 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -253,6 +253,9 @@ static

[PATCH V3 4/4] MAINTAINERS: Add entry for tas571x ASoC codec driver

Add self as maintainer for the new driver. Signed-off-by: Kevin Cernekee --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea0001760035..15153fc37cc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9878,6 +9878,12 @@ L: net

[PATCH V3 2/4] ASoC: tas571x: Add DT binding document

Document the bindings for the soon-to-be-added tas571x driver. Signed-off-by: Kevin Cernekee --- .../devicetree/bindings/sound/tas571x.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tas571x.txt diff --git

[PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

Introduce a new codec driver for the Texas Instruments TAS5711/TAS5717/TAS5719 power amplifier chips. These chips are typically used to take an I2S digital audio input and drive 10-20W into a pair of speakers. Signed-off-by: Kevin Cernekee --- sound/soc/codecs/Kconfig | 5 + sound/soc

[PATCH V3 1/4] regmap: Use regcache_mark_dirty() to indicate power loss or reset

ed any writes, they should be sent to the hardware regardless of whether they match the HW default. Currently this will write out all values in the regcache, since we don't maintain per-register dirty bits. Suggested-by: Mark Brown Signed-off-by: Kevin Cernekee --- drivers/base/regmap/in

[PATCH V3 0/4] tas571x amplifier driver

ile in cache_only (tas571x pdn) mode. One assumption here is that regcache_sync() will be called once on resume, before any other writes. If it fails, the no_sync_defaults flag will be cleared and the next sync attempt, if any, will try to write out all contents of the cache. Kevin Cernekee

[PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

Introduce a new codec driver for the Texas Instruments TAS5711/TAS5717/TAS5719 power amplifier chips. These chips are typically used to take an I2S digital audio input and drive 10-20W into a pair of speakers. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- sound/soc/codecs/Kconfig

[PATCH V3 1/4] regmap: Use regcache_mark_dirty() to indicate power loss or reset

, they should be sent to the hardware regardless of whether they match the HW default. Currently this will write out all values in the regcache, since we don't maintain per-register dirty bits. Suggested-by: Mark Brown broo...@kernel.org Signed-off-by: Kevin Cernekee cerne...@chromium.org --- drivers

[PATCH V3 2/4] ASoC: tas571x: Add DT binding document

Document the bindings for the soon-to-be-added tas571x driver. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- .../devicetree/bindings/sound/tas571x.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound

[PATCH V3 0/4] tas571x amplifier driver

in cache_only (tas571x pdn) mode. One assumption here is that regcache_sync() will be called once on resume, before any other writes. If it fails, the no_sync_defaults flag will be cleared and the next sync attempt, if any, will try to write out all contents of the cache. Kevin Cernekee (4): regmap

[PATCH V3 4/4] MAINTAINERS: Add entry for tas571x ASoC codec driver

Add self as maintainer for the new driver. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea0001760035..15153fc37cc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9878,6 +9878,12 @@ L

Re: [PATCH V2 1/4] regmap: cache: Add "was_reset" argument to regcache_sync_region()

On Wed, Apr 29, 2015 at 9:46 AM, Mark Brown wrote: > On Wed, Apr 29, 2015 at 07:13:27AM -0700, Kevin Cernekee wrote: >> On Wed, Apr 29, 2015 at 3:40 AM, Mark Brown wrote: > >> > Like I said above we can tell if the hardware was reset because >> > mark_dirty

Re: [PATCH V2 1/4] regmap: cache: Add "was_reset" argument to regcache_sync_region()

On Wed, Apr 29, 2015 at 3:40 AM, Mark Brown wrote: > On Tue, Apr 28, 2015 at 09:58:48PM -0700, Kevin Cernekee wrote: >> On Sat, Apr 25, 2015 at 4:32 AM, Mark Brown wrote: > >> > What we should be doing here is providing a way for users to tell regmap >> > if

Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

On Wed, Apr 29, 2015 at 9:46 AM, Mark Brown broo...@kernel.org wrote: On Wed, Apr 29, 2015 at 07:13:27AM -0700, Kevin Cernekee wrote: On Wed, Apr 29, 2015 at 3:40 AM, Mark Brown broo...@kernel.org wrote: Like I said above we can tell if the hardware was reset because mark_dirty() is called

Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

On Wed, Apr 29, 2015 at 3:40 AM, Mark Brown broo...@kernel.org wrote: On Tue, Apr 28, 2015 at 09:58:48PM -0700, Kevin Cernekee wrote: On Sat, Apr 25, 2015 at 4:32 AM, Mark Brown broo...@kernel.org wrote: What we should be doing here is providing a way for users to tell regmap if they've

Re: [PATCH V2 1/4] regmap: cache: Add "was_reset" argument to regcache_sync_region()

On Sat, Apr 25, 2015 at 4:32 AM, Mark Brown wrote: > On Fri, Apr 24, 2015 at 03:36:45PM -0700, Kevin Cernekee wrote: > >> index 116655d92269..ece122a6fdeb 100644 >> --- a/include/linux/regmap.h >> +++ b/include/linux/regmap.h >> @@ -438,7 +438,7 @@ bool regmap_ca

[PATCH] MIPS: BMIPS: Delete unused Kconfig symbol

This was left over from an earlier iteration of the BMIPS irqchip changes. It doesn't actually have an effect, so let's nuke it. Reported-by: Valentin Rothberg Signed-off-by: Kevin Cernekee --- Ralf - could you please pull this for 4.1? arch/mips/Kconfig | 1 - 1 file changed, 1 deletion

Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

On Sat, Apr 25, 2015 at 4:32 AM, Mark Brown broo...@kernel.org wrote: On Fri, Apr 24, 2015 at 03:36:45PM -0700, Kevin Cernekee wrote: index 116655d92269..ece122a6fdeb 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -438,7 +438,7 @@ bool regmap_can_raw_write(struct regmap

[PATCH] MIPS: BMIPS: Delete unused Kconfig symbol

This was left over from an earlier iteration of the BMIPS irqchip changes. It doesn't actually have an effect, so let's nuke it. Reported-by: Valentin Rothberg valentinrothb...@gmail.com Signed-off-by: Kevin Cernekee cerne...@chromium.org --- Ralf - could you please pull this for 4.1? arch

Re: [PATCH V2 1/4] regmap: cache: Add "was_reset" argument to regcache_sync_region()

On Fri, Apr 24, 2015 at 3:36 PM, Kevin Cernekee wrote: > regcache_sync() and regcache_sync_region() currently assume that the > hardware has just emerged from a clean reset, and that all registers are > in their default states. But that isn't the only possibility; the device > m

[PATCH V2 2/4] ASoC: tas571x: Add DT binding document

Document the bindings for the soon-to-be-added tas571x driver. Signed-off-by: Kevin Cernekee --- .../devicetree/bindings/sound/tas571x.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tas571x.txt diff --git

[PATCH V2 4/4] MAINTAINERS: Add entry for tas571x ASoC codec driver

Add self as maintainer for the new driver. Signed-off-by: Kevin Cernekee --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea0001760035..15153fc37cc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9878,6 +9878,12 @@ L: net

[PATCH V2 1/4] regmap: cache: Add "was_reset" argument to regcache_sync_region()

-by: Kevin Cernekee --- drivers/base/regmap/internal.h| 5 ++- drivers/base/regmap/regcache-lzo.c| 2 +- drivers/base/regmap/regcache-rbtree.c | 5 ++- drivers/base/regmap/regcache.c| 75 --- drivers/media/radio/radio-si476x.c| 18

[PATCH V2 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

Introduce a new codec driver for the Texas Instruments TAS5711/TAS5717/TAS5719 power amplifier chips. These chips are typically used to take an I2S digital audio input and drive 10-20W into a pair of speakers. Signed-off-by: Kevin Cernekee --- sound/soc/codecs/Kconfig | 5 + sound/soc

[PATCH V2 0/4] tas571x amplifier driver

are registers that don't contain their power-on-reset values Kevin Cernekee (4): regmap: cache: Add "was_reset" argument to regcache_sync_region() ASoC: tas571x: Add DT binding document ASoC: tas571x: New driver for TI TAS571x power amplifiers MAINTAINERS: Add entry for tas57

Re: [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers

On Fri, Apr 24, 2015 at 2:28 AM, Mark Brown wrote: > On Thu, Apr 23, 2015 at 05:47:49PM -0700, Kevin Cernekee wrote: > >> This is mostly working OK, but regcache_sync() assumes that the >> hardware registers have been reset back to the default values. The >> "pdn

Re: [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers

On Fri, Apr 24, 2015 at 2:28 AM, Mark Brown broo...@kernel.org wrote: On Thu, Apr 23, 2015 at 05:47:49PM -0700, Kevin Cernekee wrote: This is mostly working OK, but regcache_sync() assumes that the hardware registers have been reset back to the default values. The pdn GPIO doesn't actually

[PATCH V2 0/4] tas571x amplifier driver

registers that don't contain their power-on-reset values Kevin Cernekee (4): regmap: cache: Add was_reset argument to regcache_sync_region() ASoC: tas571x: Add DT binding document ASoC: tas571x: New driver for TI TAS571x power amplifiers MAINTAINERS: Add entry for tas571x ASoC codec

[PATCH V2 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

Introduce a new codec driver for the Texas Instruments TAS5711/TAS5717/TAS5719 power amplifier chips. These chips are typically used to take an I2S digital audio input and drive 10-20W into a pair of speakers. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- sound/soc/codecs/Kconfig

[PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

-by: Kevin Cernekee cerne...@chromium.org --- drivers/base/regmap/internal.h| 5 ++- drivers/base/regmap/regcache-lzo.c| 2 +- drivers/base/regmap/regcache-rbtree.c | 5 ++- drivers/base/regmap/regcache.c| 75 --- drivers/media/radio/radio-si476x.c

[PATCH V2 4/4] MAINTAINERS: Add entry for tas571x ASoC codec driver

Add self as maintainer for the new driver. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea0001760035..15153fc37cc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9878,6 +9878,12 @@ L

[PATCH V2 2/4] ASoC: tas571x: Add DT binding document

Document the bindings for the soon-to-be-added tas571x driver. Signed-off-by: Kevin Cernekee cerne...@chromium.org --- .../devicetree/bindings/sound/tas571x.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound

Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

On Fri, Apr 24, 2015 at 3:36 PM, Kevin Cernekee cerne...@chromium.org wrote: regcache_sync() and regcache_sync_region() currently assume that the hardware has just emerged from a clean reset, and that all registers are in their default states. But that isn't the only possibility; the device

  1   2   3   4   5   6   >