Re: [PATCH] media: meson-ge2d: fix rotation parameters

2021-04-19 Thread Kevin Hilman
Neil Armstrong writes: > With these settings, 90deg and 270deg rotation leads to inverted > vertical, fix them to have correct rotation. > > Fixes: 59a635327ca7 ("media: meson: Add M2M driver for the Amlogic GE2D > Accelerator Unit") > Signed-off-by: Neil Armstrong

Re: [PATCH v2 0/3] arm64: dts: meson: add support for MeCool KII-Pro/KIII-Pro

2021-04-07 Thread Kevin Hilman
800b70f607ed7638870 [2/3] arm64: dts: meson: add initial device-tree for MeCool KII Pro commit: d5454e7ce24a28bd22beb2fc02f1571b5748dfbb [3/3] arm64: dts: meson: add initial device-tree for MeCool KIII Pro commit: 727d93ed3ba67307a82c3ac5ebc7e335265e8b9e Best regards, -- Kevin Hilman

Re: [PATCH 0/3] arm64: dts: meson: add support for MeCool KII-Pro/KIII-Pro

2021-04-07 Thread Kevin Hilman
800b70f607ed7638870 [2/3] arm64: dts: meson: add initial device-tree for MeCool KII Pro commit: d5454e7ce24a28bd22beb2fc02f1571b5748dfbb [3/3] arm64: dts: meson: add initial device-tree for MeCool KIII Pro commit: 727d93ed3ba67307a82c3ac5ebc7e335265e8b9e Best regards, -- Kevin Hilman

Re: [PATCH 0/3] arm64: dts: meson: add support for MeCool KII-Pro/KIII-Pro

2021-03-31 Thread Kevin Hilman
Christian Hewitt writes: > This series adds support for the MeCool (Videostrong) KII Pro (GXL) > and KIII Pro (GXM) Android STB devices. These are quite popular due > to the embedded multi-standard tuner card (which is sadly not-yet > supported in the kernel). Both devices closely follow the

Re: [PATCH 3/3] arm64: dts: meson: add GPIO line names to ODROID N2/N2+

2021-03-31 Thread Kevin Hilman
Hi Christian, Christian Hewitt writes: > From: Hyeonki Hong > > Add GPIO line-name identifiers to the ODROID N2/N2+ common dtsi. > > Signed-off-by: Hyeonki Hong You need to add your SoB here also. Kevin

Re: [PATCH 2/3] tty: serial: meson: retrieve port FIFO size from DT

2021-03-15 Thread Kevin Hilman
Neil Armstrong writes: > Now the DT bindings has a property to get the FIFO size for a particular port, > retrieve it and use to setup the FIFO interrupts threshold. > > Signed-off-by: Neil Armstrong Reviewed-by: Kevin Hilman

Re: [PATCH] drm: meson_drv add shutdown function

2021-03-09 Thread Kevin Hilman
Neil Armstrong writes: > On 09/03/2021 18:13, Kevin Hilman wrote: >> Hi Neil, >> >> Neil Armstrong writes: >> >>> On 02/03/2021 05:22, Artem Lapkin wrote: >>>> Problem: random stucks on reboot stage about 1/20 stuck/reboots >>>> //

Re: [PATCH] drm: meson_drv add shutdown function

2021-03-09 Thread Kevin Hilman
Hi Neil, Neil Armstrong writes: > On 02/03/2021 05:22, Artem Lapkin wrote: >> Problem: random stucks on reboot stage about 1/20 stuck/reboots >> // debug kernel log >> [4.496660] reboot: kernel restart prepare CMD:(null) >> [4.498114] meson_ee_pwrc

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add support for the Minix NEO U9-H

2021-03-08 Thread Kevin Hilman
commit: 15c4dd131ce576f0150fadf7a3264c865b051eba [2/2] arm64: dts: meson: add initial device-tree for Minix NEO U9-H commit: 0e9fed92c67cb886b3308df4890126d75db2ad67 Best regards, -- Kevin Hilman

Re: [PATCH] drm: meson_drv add shutdown function

2021-03-08 Thread Kevin Hilman
I_0_2_FN_SYSTEM_RESET reboot_mode:0 cmd:(null) > bl31 reboot reason: 0xd > bl31 reboot reason: 0x0 > system cmd 1. > ...REBOOT... > > Tested: on VIM1 VIM2 VIM3 VIM3L khadas sbcs - 1000+ successful reboots > and Odroid boards, WeTek Play2 (GXBB) > > Tested-by: Christian Hewitt > Signed-off-by: Artem Lapkin Acked-by: Kevin Hilman

Re: [PATCH] Revert "arm64: dts: amlogic: add missing ethernet reset ID"

2021-03-03 Thread Kevin Hilman
Hi Neil, Neil Armstrong writes: > It has been reported on IRC and in KernelCI boot tests, this change breaks > internal PHY support on the Amlogic G12A/SM1 Based boards. > > We suspect the added signal to reset more than the Ethernet MAC but also > the MDIO/(RG)MII mux used to redirect the MAC

Re: [PATCH v3 0/5] arm64: dts: meson: add support for ODROID-HC4

2021-02-03 Thread Kevin Hilman
96f2f9c [4/5] dt-bindings: arm: amlogic: add ODROID-HC4 bindings commit: 1429c7d223ed436f54e1c30efa7f87eb15d50b31 [5/5] arm64: dts: meson: add initial device-tree for ODROID-HC4 commit: 9be09db3e2adf5843ec1e20771c598e70d2bd34a Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: fix broken wifi node for Khadas VIM3L

2021-02-03 Thread Kevin Hilman
ted Applied, thanks! [1/1] arm64: dts: meson: fix broken wifi node for Khadas VIM3L commit: 39be8f441f78908e97ff913571e10ec03387a63a Best regards, -- Kevin Hilman

Re: [PATCH 10/21] rtc: meson: quiet maybe-unused variable warning

2021-02-02 Thread Kevin Hilman
Alexandre Belloni writes: > When CONFIG_OF is disabled then the matching table is not referenced. > > Signed-off-by: Alexandre Belloni Acked-by: Kevin Hilman > --- > drivers/rtc/rtc-meson.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

Re: [PATCH] arm64: dts: meson-gx: remove wrong reserved BL31 memory

2021-02-01 Thread Kevin Hilman
Artem Lapkin writes: > Kernel boot fail on Khadas VIM1 VIM2 (meson GX) boards > SOLUTION: just remove wrong mem reservation for 0x1000 0x20 You don't explain why it's wrong. This region was added becasue there there are definitely GX devices which have secure memory in this area, and

Re: [PATCH v2 0/5] arm64: dts: meson: add support for ODROID-HC4

2021-02-01 Thread Kevin Hilman
Hi Christian, Christian Hewitt writes: > This series fixes minor sort-order issues in the Amlogic bindings yaml and > dtb Makefile, then converts the existing ODROID-C2 dts into dtsi so we can > support its new sister product the ODROID-HC4. > > I've also given the devices different audio card

Re: [PATCH] Revert "arm64: dts: amlogic: add missing ethernet reset ID"

2021-01-27 Thread Kevin Hilman
hernet reset ID" commit: 19f6fe976a61f9afc289b062b7ef67f99b72e7b9 Best regards, -- Kevin Hilman

Re: [PATCH 0/5] Thermal zone configuration for Meson8/Meson8b/Meson8m2

2021-01-26 Thread Kevin Hilman
: dts: meson8b: add the thermal-zones with cooling configuration commit: 9073f694efd8733b0e7c97d3396d81161bd05582 [5/5] ARM: multi_v7_defconfig: Enable support for the ADC thermal sensor commit: 726731566a862fa375de44313f601e49c4d40377 Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: shorten audio card names for alsa compatibility

2021-01-26 Thread Kevin Hilman
t; [0] > https://github.com/torvalds/linux/blob/master/Documentation/sound/alsa-configuration.rst#common-parameters-for-top-sound-card-modules Applied, thanks! [1/1] arm64: dts: meson: shorten audio card names for alsa compatibility commit: cf21697a8c5bf65eb4e05717ca5caee8215c3797 Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: add i2c3/rtc nodes and rtc aliases to ODROID-N2 dtsi

2021-01-26 Thread Kevin Hilman
OID-N2 dtsi commit: 930f424bd8cec154466d7929c10f1ad0525f605f Best regards, -- Kevin Hilman

Re: [PATCH v3 0/2] arm64: dts: meson: add support for Beelink GS-King-X

2021-01-25 Thread Kevin Hilman
-X device-tree commit: f3d4ad4f106e21161d232c41a6676416e2498ae4 Best regards, -- Kevin Hilman

Re: [PATCH v2 0/5] Amlogic Meson Always-On ARC remote-processor support

2021-01-25 Thread Kevin Hilman
Martin Blumenstingl writes: > Amlogic Meson6/8/8b/8m2 come with an ARC core in the Always-On (AO) > power-domain. This is typically used for waking up the ARM CPU after > powering it down for system suspend. > > The exact ARC core used on Meson6 and earlier is not known. I believe > it is an

Re: [PATCH] PM / clk: make PM clock layer compatible with clocks that must sleep

2021-01-19 Thread Kevin Hilman
[ + Geert.. renesas SoCs are the primary user of PM clk ] Nicolas Pitre writes: > The clock API splits its interface into sleepable ant atomic contexts: > > - clk_prepare/clk_unprepare for stuff that might sleep > > - clk_enable_clk_disable for anything that may be done in atomic context > >

Re: [PATCH v9 4/4] arm64: dts: meson: Fix schema warnings for pwm-leds

2021-01-04 Thread Kevin Hilman
Alexander Dahl writes: > The node names for devices using the pwm-leds driver follow a certain > naming scheme (now). Parent node name is not enforced, but recommended > by DT project. > > Signed-off-by: Alexander Dahl > Reviewed-by: Neil Armstrong Queued for 5.12, Thanks, Kevin

Re: [PATCH 1/2] arm64: dts: meson: vim3: whitespace fixups

2021-01-04 Thread Kevin Hilman
Jerome Brunet writes: > Spaces have been used to indent 2 nodes. > Replace those with tabs and remove one extra newline > > Signed-off-by: Jerome Brunet Queued, Thanks. Kevin

Re: [PATCH v4 02/10] arm64: dts: amlogic: meson-g12: Set FL-adj property value

2020-12-11 Thread Kevin Hilman
Serge Semin writes: > In accordance with the DWC USB3 bindings the property is supposed to have > uint32 type. It's erroneous from the DT schema and driver points of view > to declare it as boolean. As Neil suggested set it to 0x20 so not break > the platform and to make the dtbs checker happy.

[PATCH] tty: serial: meson: enable console as module

2020-12-10 Thread Kevin Hilman
Enable serial driver to be built as a module. To do so, init the console support on driver/module load instead of using console_initcall(). Signed-off-by: Kevin Hilman --- Yes, I'm well aware that having the serial console as a module makes devices hard to debug, so I'm not changing any default

Re: [PATCH] arm64: dts: meson: add i2c3/rtc nodes and vrtc alias to GT-King/GT-King-Pro

2020-12-08 Thread Kevin Hilman
registered as rtc0 > [5.265016] rtc-hym8563 0-0051: setting system clock to > 2020-11-30T09:16:54 UTC (1606727814) Applied, thanks! [1/1] arm64: dts: meson: add i2c3/rtc nodes and vrtc alias to GT-King/GT-King-Pro commit: 7704b100719cf0fead976a1bc839c60ee552d045 Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: minor fixups for Khadas VIM/VIM2 dts

2020-12-07 Thread Kevin Hilman
commit: c993c4e84369acf5686a6f345ebb0efb0107f73e Best regards, -- Kevin Hilman

Re: [PATCH v3 1/5] arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements

2020-12-07 Thread Kevin Hilman
4/5] arm64: dts: meson: g12a: x96-max: fix PHY deassert timing requirements commit: 3d07c3b3a886fefd583c1b485b5e4e3c4e2da493 [5/5] arm64: dts: meson: g12b: w400: fix PHY deassert timing requirements commit: 9e454e37dc7c0ee9e108d70b983e7a71332aedff Best regards, -- Kevin Hilman

Re: [PATCH v4 0/7] arm64: dts: meson: add more GX soundcards

2020-12-07 Thread Kevin Hilman
ck to wetek-play2 commit: 5e3ee48ea072a6fd2c46c552d013e047dc54d1c6 Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: add KHAMSIN IR remote node to SML5442TW

2020-12-07 Thread Kevin Hilman
On Thu, 26 Nov 2020 05:04:40 +, Christian Hewitt wrote: > Set the IR keymap to the KHAMSIN remote shipped with the SML5442TW. Applied, thanks! [1/1] arm64: dts: meson: add KHAMSIN IR remote node to SML5442TW commit: 2493a9a515cf2bfa958d1d68beab507a1c7f5962 Best regards, -- Ke

Re: [PATCH v4 0/4] media: meson: Add support for the Amlogic GE2D Accelerator Unit

2020-12-07 Thread Kevin Hilman
f9cc43ad87c63b44a89344 Best regards, -- Kevin Hilman

Re: linux-next: Fixes tag needs some work in the amlogic tree

2020-11-30 Thread Kevin Hilman
Stephen Rothwell writes: > Hi all, > > In commit > > 9d822ed94237 ("soc: amlogic: canvas: add missing put_device() call in > meson_canvas_get()") > > Fixes tag > > Fixes: commit 382f8be04551 ("soc: amlogic: canvas: Fix meson_canvas_get > when probe failed") > > has these problem(s): > >

Re: [PATCH 0/3] usb: meson: fix shared reset control use

2020-11-30 Thread Kevin Hilman
Amjad Ouled-Ameur writes: > Hello Felipe and Kevin, > > > Could you please review this patchset ? The changes are OK with me. Please update based on Martin's suggestions and this can be queued up by the USB maintainers. Kevin > Thank you in advance. > > On 13/11/2020 01:05, Amjad Ouled-Ameur

Re: [PATCH] soc: amlogic: replace devm_reset_control_array_get()

2020-11-30 Thread Kevin Hilman
On Wed, 18 Nov 2020 10:48:20 +0800, Yejune Deng wrote: > devm_reset_control_array_get_exclusive() looks more readable Applied, thanks! [1/1] soc: amlogic: replace devm_reset_control_array_get() commit: 978d0dbb98c7ce9a5d6897744ac49ac5ff85831e Best regards, -- Kevin Hilman

Re: [PATCH 0/4] arm64: dts: meson-axg-s400: add support for USB and PCIe

2020-11-20 Thread Kevin Hilman
Kevin Hilman writes: > On Fri, 20 Nov 2020 16:32:25 +0100, Neil Armstrong wrote: >> This adds the USB and PCIe to AXG, and enables USB & the two M.2 PCIe ports >> on the S400 board. >> >> Dependencies: >> - Patch 1, 2, 4: None >> - Patch 3: [1] arm64:

Re: [PATCH] arm64: meson: ship only the necessary clock controllers

2020-11-20 Thread Kevin Hilman
ntrollers (no commit info) Best regards, -- Kevin Hilman

Re: [PATCH 0/2] arm64: dts: meson-axg-s400: add support for Power Controller & MIPI-DSI PHY

2020-11-20 Thread Kevin Hilman
3ddf2f85e84b0824770cf9f42ea768adcb4 Best regards, -- Kevin Hilman

Re: [PATCH 0/4] arm64: dts: meson-axg-s400: add support for USB and PCIe

2020-11-20 Thread Kevin Hilman
son-axg-s400: enable USB OTG commit: 160f1630878e11668336fded29eeb0fe82fb3faf [3/4] arm64: dts: meson-axg: add PCIe nodes commit: 9bfc5abed67ae7dcc837dd8f6d61396d1cc9ac2b [4/4] arm64: dts: meson-axg-s400: enable PCIe M.2 Key E slots commit: eee685ef92d8cbabb2a61c45fe7d976c3ebc9b1e Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: enable rtc node on Khadas VIM1/VIM2 boards

2020-11-20 Thread Kevin Hilman
ble to read the hardware clock > [8.126768] rtc-hym8563 1-0051: no valid clock/calendar values available > > [...] Applied, thanks! [1/1] arm64: dts: meson: enable rtc node on Khadas VIM1/VIM2 boards commit: a735defaf1ee74e9f06a616162f1ba6f26555d38 Best regards, -- Kevin Hilman

Re: [PATCH 0/2] arm64: dts: meson-axg-s400: add support for Power Controller & MIPI-DSI PHY

2020-11-20 Thread Kevin Hilman
Neil Armstrong writes: > This adds the Power Controller and MIPI DSI PHY nodes to AXG, since the > corresponding > driver and dt-bindings had been applied for next release. > > Dependencies: > - Patch 1: [1] applied for 5.11 in meson-clk tree & [2] merged for 5.10 > - Patch 2: [3] & [4] both

Re: [PATCH] arm64: meson: ship only the necessary clock controllers

2020-11-09 Thread Kevin Hilman
ntrollers (no commit info) Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: remove empty lines from aml-s905x-cc v2 dts

2020-11-05 Thread Kevin Hilman
On Mon, 26 Oct 2020 13:41:01 +, Christian Hewitt wrote: > Applied, thanks! [1/1] arm64: dts: meson: remove empty lines from aml-s905x-cc v2 dts commit: 8e9c052a483db5f9ae098d9b686ed80e2e98a8c5 Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: add watchdog to g12-common dtsi

2020-11-05 Thread Kevin Hilman
1/1] arm64: dts: meson: add watchdog to g12-common dtsi commit: 7bd5175918eb4b294c0979c75056f20fd90a50bf Best regards, -- Kevin Hilman

Re: [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table

2020-11-03 Thread Kevin Hilman
(!CONFIG_OF && !CONFIG_MODULES): > > drivers/mmc/host/meson-gx-mmc.c:1252:34: warning: > ‘meson_mmc_of_match’ defined but not used [-Wunused-const-variable=] > > Reported-by: kernel test robot > Signed-off-by: Krzysztof Kozlowski Thanks for the fix. Acked-by: Kevin Hilman Kevin

Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module

2020-10-26 Thread Kevin Hilman
Marc Zyngier writes: > On 2020-10-26 16:18, Kevin Hilman wrote: >> Marc Zyngier writes: >> >>> On Tue, 20 Oct 2020 08:25:30 +0100, >>> Neil Armstrong wrote: >>>> >>>> In order to reduce the kernel Image size on multi-platform >&

Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module

2020-10-26 Thread Kevin Hilman
Kevin Hilman writes: > Marc Zyngier writes: > >> On 2020-10-26 16:18, Kevin Hilman wrote: >>> Marc Zyngier writes: >>> >>>> On Tue, 20 Oct 2020 08:25:30 +0100, >>>> Neil Armstrong wrote: >>>>> >>>>> In orde

Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module

2020-10-26 Thread Kevin Hilman
Marc Zyngier writes: > On 2020-10-26 16:18, Kevin Hilman wrote: >> Marc Zyngier writes: >> >>> On Tue, 20 Oct 2020 08:25:30 +0100, >>> Neil Armstrong wrote: >>>> >>>> In order to reduce the kernel Image size on multi-platform >&

Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module

2020-10-26 Thread Kevin Hilman
Marc Zyngier writes: > On Tue, 20 Oct 2020 08:25:30 +0100, > Neil Armstrong wrote: >> >> In order to reduce the kernel Image size on multi-platform distributions, >> make it possible to build the Amlogic GPIO IRQ controller as a module >> by switching it to a platform driver. >> >> The second

Re: [PATCH v2 0/3] clk: add api to get clk consumer from clk_hw

2020-10-26 Thread Kevin Hilman
the dev as >argument as most devm function do. However, as Stephen pointed out >we don't expect this to differ from the one linked to clk_hw. In >this case a warning is thrown. > * Add a first usage of this in the amlogic clock driver. Tested-by: Kevin Hilman Tested this o

Re: [PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm

2020-10-23 Thread Kevin Hilman
gt; > > pwm-regulator regulator-vddcpu-b: Failed to get PWM: -16 > > Like on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the > problem Applied, thanks! [1/1] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm (no commit info) Best regards, -- Kevin Hilman

Re: [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection

2020-10-20 Thread Kevin Hilman
Neil Armstrong writes: > Selecting MESON_IRQ_GPIO forces it as built-in, but we may need to build it > as a module, thus remove it here and let the "default ARCH_MESON" build as > built-in by default with the option to switch it to module. > > Signed-off-by: Neil Armstrong I'll queue this one

Re: [PATCH] arm64: dts: amlogic: add missing ethernet reset ID

2020-10-20 Thread Kevin Hilman
On Tue, 20 Oct 2020 14:01:41 +0200, Jerome Brunet wrote: > Add reset external reset of the ethernet mac controller Applied, thanks! [1/1] arm64: dts: amlogic: add missing ethernet reset ID commit: f3362f0c18174a1f334a419ab7d567a36bd1b3f3 Best regards, -- Kevin Hilman

Re: [PATCH v2 3/3] phy: amlogic: phy-meson-axg-mipi-pcie-analog: add support for MIPI DSI analog

2020-10-20 Thread Kevin Hilman
Hi Kishon, It's been another few weeks, so another slightly less gentle ping. :) Kevin Neil Armstrong writes: > Hi Kishon, > > Gentle ping. > > Thanks, > Neil > > On 15/09/2020 15:03, Neil Armstrong wrote: >> The AXG Analog MIPI-DSI PHY also provides functions to the PCIe PHY, >> thus we need

Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module

2020-10-20 Thread Kevin Hilman
Neil Armstrong writes: > In order to reduce the kernel Image size on multi-platform distributions, > make it possible to build the Amlogic GPIO IRQ controller as a module > by switching it to a platform driver. > > Signed-off-by: Neil Armstrong Reviewed-by: Kevin Hilman T

Re: [PATCH] arm64: meson: ship only the necessary clock controllers

2020-10-20 Thread Kevin Hilman
we'll have no clock providers. I think you also need a default value (e.g. `default y`) in drivers/clk/meson/Kconfig for each of these entries to keep the same defaults. But these defaults could be overridden by SoC-specific defconfigs leading to more flexibilty. So, assuming you queue up a drivers/clk patch to go in when this lands... Acked-by: Kevin Hilman

Re: [PATCH] arm64: dts: amlogic: add missing ethernet reset ID

2020-10-20 Thread Kevin Hilman
Neil Armstrong writes: > On 20/10/2020 14:01, Jerome Brunet wrote: >> From: Anand Moon >> >> Add reset external reset of the ethernet mac controller >> >> Signed-off-by: Anand Moon >> Signed-off-by: Jerome Brunet [...] > Reviewed-by: Neil Armstrong Neil, do we need this in u-boot also?

Re: [PATCH] reset: meson: make it possible to build as a module

2020-10-16 Thread Kevin Hilman
r = { > .of_match_table = meson_reset_dt_ids, > }, > }; > -builtin_platform_driver(meson_reset_driver); > +module_platform_driver(meson_reset_driver); I tried this as as a module, and it never probed because it's missing this on the compatible table: MODULE_DEVICE_TABLE(of, meson_reset_dt_ids); With that minor change: Reviewed-by: Kevin Hilman Tested-by: Kevin Hilman Kevin

Re: [PATCH] reset: Add reset controller API

2020-10-02 Thread Kevin Hilman
Amjad Ouled-Ameur writes: > The current reset framework API does not allow to release what is done by > reset_control_reset(), IOW decrement triggered_count. Add the new > reset_control_resettable() call to do so. > > When reset_control_reset() has been called once, the counter >

Re: [PATCH] arm64: dts: meson: add SM1 soundcard name to VIM3L

2020-10-02 Thread Kevin Hilman
Jerome Brunet writes: > On Fri 02 Oct 2020 at 20:45, Kevin Hilman wrote: > >> Christian Hewitt writes: >> >>>> On 2 Oct 2020, at 6:44 pm, Jerome Brunet wrote: >>>> >>>> On Fri 02 Oct 2020 at 16:16, Christian Hewitt >>>>

Re: [PATCH] pci: meson: build as module by default

2020-10-02 Thread Kevin Hilman
Hi Lorenzo, Lorenzo Pieralisi writes: > On Fri, Sep 18, 2020 at 11:12:51AM -0700, Kevin Hilman wrote: >> Enable pci-meson to build as a module whenever ARCH_MESON is enabled. >> >> Cc: Yue Wang >> Signed-off-by: Kevin Hilman >> --- >> Tested on Kha

Re: [PATCH] arm64: dts: amlogic: meson-g12: use the G12A specific dwmac compatible

2020-10-02 Thread Kevin Hilman
ks! [1/1] arm64: dts: amlogic: meson-g12: use the G12A specific dwmac compatible commit: c0c6f8e527a652d4785cb38ac82be0c95913349d Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: add SM1 soundcard name to VIM3L

2020-10-02 Thread Kevin Hilman
hanks! [1/1] arm64: dts: meson: add SM1 soundcard name to VIM3L commit: 0fe4c285ef8bd0475da7e288c844cb55fc850970 Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: add SM1 soundcard name to VIM3L

2020-10-02 Thread Kevin Hilman
Christian Hewitt writes: >> On 2 Oct 2020, at 6:44 pm, Jerome Brunet wrote: >> >> On Fri 02 Oct 2020 at 16:16, Christian Hewitt >> wrote: >> >>> VIM3L now inherits the sound node from the VIM3 common dtsi but is >>> an SM1 device, so label it as such, and stop users blaming future >>>

Re: [PATCH RESEND v1] ARM: dts: meson8: remove two invalid interrupt lines from the GPU node

2020-10-02 Thread Kevin Hilman
Martin Blumenstingl writes: > Hi Kevin, > > On Mon, Aug 24, 2020 at 11:16 PM Kevin Hilman wrote: > [...] >> Applied, thanks! >> >> [1/1] ARM: dts: meson8: remove two invalid interrupt lines from the GPU node >> commit: b468412409c0e5752ad3396b147

Re: [PATCH v2 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board

2020-10-02 Thread Kevin Hilman
Neil Armstrong writes: > Hi Kevin, > > On 17/09/2020 08:59, Neil Armstrong wrote: >> The Amlogic AXG is close to the GXL Glue but with a single OTG PHY. >> >> It needs the same init sequence as GXL & GXM, but it seems it doesn't need >> the host disconnect bit. >> >> The Glue driver reuses the

Re: [PATCH v2 1/1] mmc: host: meson-gx-mmc: fix possible deadlock condition for preempt_rt

2020-09-28 Thread Kevin Hilman
Brad Harper writes: > --- > drivers/mmc/host/meson-gx-mmc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) This patch still needs changelog summarizing the problem and what is being fixed by the patch. Most of what's in the cover letter belongs here. The cover letter can be used

Re: [PATCH] mmc: host: meson-gx-mmc: fix possible deadlock condition for preempt_rt

2020-09-24 Thread Kevin Hilman
Hi Brad, Brad Harper writes: > Force threaded interrupts for meson_mmc_irq to prevent possible deadlock > condition > during mmc operations when using preempt_rt with 5.9.0-rc3-rt3 patches > on arm64. > > Using meson-gx-mmc with an emmc device on Hardkernel Odroid N2+ > configured with >

Re: [PATCH] mailbox: cancel timer before starting it

2020-09-24 Thread Kevin Hilman
this race condition. > > Fixes: 0cc67945ea59 ("mailbox: switch to hrtimer for tx_complete polling") > Reported-by: Da Xue > Signed-off-by: Jerome Brunet Reviewed-by: Kevin Hilman Kevin

Re: [PATCH] MAINTAINERS: remove Maxime Jourdan as maintainer of Amlogic VDEC

2020-09-24 Thread Kevin Hilman
Neil Armstrong writes: > Maxime is no more a BayLibre employee, and his e-mail address is now invalid. > > I'll be happy to add him back using another e-mail address if he wants to > continue > maintaining this driver. > > Signed-off-by: Neil Armstrong Acked-by: Kevin Hilman

Re: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout

2020-09-21 Thread Kevin Hilman
> > Signed-off-by: Neil Armstrong Tested-by: Kevin Hilman

Re: [PATCH -next] rtc: meson: simplify the return expression of meson_vrtc_probe

2020-09-21 Thread Kevin Hilman
Liu Shixin writes: > Simplify the return expression. > > Signed-off-by: Liu Shixin Acked-by: Kevin Hilman

Re: [PATCH v2 0/3] arm64: dts: meson: add support for ODROID-N2+

2020-09-18 Thread Kevin Hilman
support for the ODROID-N2+ commit: 98d24896ee117b1f0969405476c943e9307e30d4 Best regards, -- Kevin Hilman

Re: [PATCH 0/2] arm64: dts: meson: add aml-s905x-cc v2 support

2020-09-18 Thread Kevin Hilman
/meson-gxl-s905x-libretech-cc-v2.dts Applied, thanks! [1/2] dt-bindings: arm: amlogic: add support for libretch s905x cc v2 commit: 0748c77fc8dc6bb20f9af395872ea35d8ac85998 [2/2] arm64: dts: meson: initial support for aml-s905x-cc v2 commit: 63fafc5a046b1e21756de691b48f0c70c25e1426 Best regards, -- Kevin Hilman

Re: [PATCH v2 0/2] soc: amlogic: add support for the Meson AXG Power Controller

2020-09-18 Thread Kevin Hilman
on AXG SoCs commit: 525054782a74d28503c3f585e00d9860d67d7ad1 Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: vim3l: remove sound card definition

2020-09-18 Thread Kevin Hilman
efinition (no commit info) Best regards, -- Kevin Hilman

[PATCH] MAINTAINERS: drop myself from PM AVS drivers

2020-09-18 Thread Kevin Hilman
I haven't had the time or the expertise to adequately review and maintain these drivers for awhile, so make it official. Signed-off-by: Kevin Hilman --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index deaafb617361..f1bf6071c438 100644

Re: [PATCH -next] power: avs: qcom-cpr: simplify the return expression of cpr_disable()

2020-09-18 Thread Kevin Hilman
Bjorn Andersson writes: > On Mon 14 Sep 22:26 CDT 2020, Liu Shixin wrote: > >> Simplify the return expression. >> >> Signed-off-by: Liu Shixin > > Reviewed-by: Bjorn Andersson Acked-by: Kevin Hilman Rafael, please apply directly.

[PATCH] pci: meson: build as module by default

2020-09-18 Thread Kevin Hilman
Enable pci-meson to build as a module whenever ARCH_MESON is enabled. Cc: Yue Wang Signed-off-by: Kevin Hilman --- Tested on Khadas VIM3 and Khadas VIM3 using NVMe SSD devices. drivers/pci/controller/dwc/Kconfig | 3 ++- drivers/pci/controller/dwc/pci-meson.c | 8 +++- 2 files changed

Re: [PATCH 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board

2020-09-14 Thread Kevin Hilman
Neil Armstrong writes: > The Amlogic AXG is close from the GXL Glue but with a single OTG PHY. minor grammar nit: s/close from/close to/ (also in patches 2 & 3). Otherwise.. Reviewed-by: Kevin Hilman Kevin > It needs the same init sequence as GXL & GXM, but it seems i

Re: [PATCH 3/4] clk: meson: axg: add Video Clocks

2020-09-11 Thread Kevin Hilman
Neil Armstrong writes: > On 10/09/2020 12:13, Jerome Brunet wrote: [...] >> Why is NOCACHE ? Is there something poking behind CCF back ? if yes, why >> is this required ? > > I'm surprised you ask this since the situation hasn't changed since I pushed > the > video clock for GXBB, then G12A.

Re: [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

2020-08-31 Thread Kevin Hilman
Wolfram Sang writes: > Signed-off-by: Wolfram Sang Reviewed-by: Kevin Hilman > --- > > Only buildtested. Found while analyzing retune-handling in the core. > > drivers/mmc/host/meson-gx-mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] ARM: dts: meson: move the L2 cache-controller inside the SoC node

2020-08-24 Thread Kevin Hilman
L2 cache-controller inside the SoC node commit: 8bcbcdb7293cc24eb7b24b67ef2b29b3a45a49e0 Best regards, -- Kevin Hilman

Re: [PATCH RESEND v1] ARM: dts: meson8: remove two invalid interrupt lines from the GPU node

2020-08-24 Thread Kevin Hilman
ine INT_MALI_PP7_MMUAM_IRQ(179) > > [...] Applied, thanks! [1/1] ARM: dts: meson8: remove two invalid interrupt lines from the GPU node commit: b468412409c0e5752ad3396b147cac563ff8dd3b Best regards, -- Kevin Hilman

Re: [PATCH] ARM: dts: meson: move the L2 cache-controller inside the SoC node

2020-08-24 Thread Kevin Hilman
Martin Blumenstingl writes: > All IO mapped SoC peripherals should be within the "soc" node. Move the > L2 cache-controller there as well since it's the only one not following > this pattern. > > Signed-off-by: Martin Blumenstingl Boot tested on meson8b-odroidc1

Re: [PATCH RESEND v1] ARM: dts: meson8: remove two invalid interrupt lines from the GPU node

2020-08-24 Thread Kevin Hilman
Martin Blumenstingl writes: > The 3.10 vendor kernel defines the following GPU 20 interrupt lines: > #define INT_MALI_GP AM_IRQ(160) > #define INT_MALI_GP_MMU AM_IRQ(161) > #define INT_MALI_PP AM_IRQ(162) > #define INT_MALI_PMU

Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

2020-08-11 Thread Kevin Hilman
Sibi Sankar writes: > This is for power domains which needs to stay powered on for suspend > but can be powered on/off as part of runtime PM. This flag is aimed at > power domains coupled to remote processors which enter suspend states > independent to that of the application processor. Such

Re: [PATCH 0/2] arm64: dts: meson: odroid-n2: update sound card

2020-08-10 Thread Kevin Hilman
n2: add jack audio output support > > [...] Applied, thanks! [1/2] arm64: dts: meson: odroid-n2: enable audio loopback (no commit info) [2/2] arm64: dts: meson: odroid-n2: add jack audio output support (no commit info) Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: vim3: make sound card common to all variants

2020-08-10 Thread Kevin Hilman
t info) Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: vim3: correct led polarity

2020-08-10 Thread Kevin Hilman
On Mon, 3 Aug 2020 16:18:50 +0200, Jerome Brunet wrote: > The LEDs on the vim3 are active when the gpio is high, not low. Applied, thanks! [1/1] arm64: dts: meson: vim3: correct led polarity (no commit info) Best regards, -- Kevin Hilman

Re: [PATCH v2] arm64: dts: meson: fix mmc0 tuning error on Khadas VIM3

2020-07-27 Thread Kevin Hilman
2a80fa5b48c43003680a7b64 Best regards, -- Kevin Hilman

Re: [PATCH v2] arm64: dts: meson: misc fixups for w400 dtsi

2020-07-27 Thread Kevin Hilman
> [35561.875332] mmc0: tuning execution failed: -5 > [61733.348709] mmc0: tuning execution failed: -5 > > [...] Applied, thanks! [1/1] arm64: dts: meson: misc fixups for w400 dtsi commit: 2fa17dd09533d5d83201be3229a28c1010a8ea3e Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: update spifc node name on Khadas VIM3/VIM3L

2020-07-21 Thread Kevin Hilman
commit: d57c69ca6d4ab890e8edac5c8e10c7c2b54d500c Best regards, -- Kevin Hilman

Re: [PATCH 0/2] arm64: dts: meson: add more SM1 soundcards

2020-07-21 Thread Kevin Hilman
ks! [1/2] arm64: dts: meson: add audio playback to odroid-c4 commit: 725da67ce4d77540d4d6f7ecc3ac5a885a684716 [2/2] arm64: dts: meson: add audio playback to khadas-vim3l commit: b8b85d01be916a30c9863a5456c218d802e01d97 Best regards, -- Kevin Hilman

Re: [PATCH v3 0/2] arm64: dts: meson: add support for WeTek Core 2

2020-07-21 Thread Kevin Hilman
94b8d23860ae44a56b0af404a6c7e4c [2/2] arm64: dts: meson: add support for the WeTek Core 2 commit: ea232b9f2f55fe231441f3908c31c7136c4f Best regards, -- Kevin Hilman

Re: [PATCH v2 0/3] GPU DVFS for Meson GXBB/GXL/GXM/G12A/G12B/SM1

2020-07-21 Thread Kevin Hilman
f03f86b13fbc9943e5dc936671ea6e Best regards, -- Kevin Hilman

Re: [PATCH] arm64: dts: meson: misc fixups for w400 dtsi

2020-07-20 Thread Kevin Hilman
Christian Hewitt writes: > Current devices using the W400 dtsi show mmc tuning errors: > > [12483.917391] mmc0: tuning execution failed: -5 > [30535.551221] mmc0: tuning execution failed: -5 > [35359.953671] mmc0: tuning execution failed: -5 > [35561.875332] mmc0: tuning execution failed: -5 >

Re: [PATCH] arm64: dts: meson: fix mmc0 tuning error on Khadas VIM3

2020-07-20 Thread Kevin Hilman
Christian Hewitt writes: > Similar to other G12B devices using the W400 dtsi, I see reports of mmc0 > tuning errors on VIM3 after a few hours uptime: > > [12483.917391] mmc0: tuning execution failed: -5 > [30535.551221] mmc0: tuning execution failed: -5 > [35359.953671] mmc0: tuning execution

Re: [PATCH 0/3] ARM: dts: use the SDHC MMC controller for eMMC

2020-07-13 Thread Kevin Hilman
b: ec100: enable the SDHC controller commit: 73501b890a6f15460613878b463319d0e0cd1632 [3/3] ARM: dts: meson8b: odroidc1: enable the SDHC controller commit: d6a3873c7be6d58914ea5584dc7875f2045d6721 Best regards, -- Kevin Hilman

  1   2   3   4   5   6   7   8   9   10   >