are configured for I2S
* i don't see how existing off-tree sound cards with pcm512x codec could be
configured differently - it would not work
* tested explicitly, that there is no regression with Raspberry Pi +
sound card `sound/soc/bcm/hifiberry_dacplus.c`
Signed-off-by: Kirill Marinushkin
Cc: Mark
Set format from `set_fmt()` func instead of `hw_params()`, plus supportive
commits
Kirill Marinushkin (4):
ASoC: pcm512x: Fix not setting word length if DAIFMT_CBS_CFS
ASoC: pcm512x: Rearrange operations in `hw_params()`
ASoC: pcm512x: Move format check into `set_fmt()`
ASoC: pcm512x: Add
hecking
`SND_SOC_DAIFMT_MASTER_MASK`.
Tested with Raspberry Pi + sound card `hifiberry_dacplus` in CBS_CFS format
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: Takashi Iwai
Cc: Liam Girdwood
Cc: Matthias Reichl
Cc: Kuninori Morimoto
Cc: Peter Ujfalusi
Cc: alsa-de...@alsa-project
atch/
20201109212133.25869-1-kmarinush...@birdec.com/
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: Takashi Iwai
Cc: Liam Girdwood
Cc: Matthias Reichl
Cc: Kuninori Morimoto
Cc: Peter Ujfalusi
Cc: alsa-de...@alsa-project.org
Cc: linux-kernel@vger.kerne
This commit is a preparation for the next patch in the series.
It's goal is to make format check easy-to-move-out. Theoretically, more
butifications are possile in `hw_params()` func, but my intention in this
commit is to keep behaviour unchanged.
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Hello Peter,
On 11/12/2020 08:41 AM, Peter Ujfalusi wrote:
> Hi Kirill,
>
> On 11/11/2020 9.54, Kirill Marinushkin wrote:
>> Hello Peter,
>>
>> than you for your review!
>>
>>> The bus format and
>>>
>>>>switch
are configured for I2S
* i don't see how existing off-tree sound cards with pcm512x codec could be
configured differently - it would not work
* tested explicitly, that there is no regression with Raspberry Pi +
sound card `sound/soc/bcm/hifiberry_dacplus.c`
Signed-off-by: Kirill Marinushkin
Cc: Mark
how to
use DSP_A and DSP_B. I will add them, and submit as patch v2
Best regards,
Kirill
On 11/10/2020 07:59 AM, Peter Ujfalusi wrote:
>
>
> On 09/11/2020 23.21, Kirill Marinushkin wrote:
>> Currently, pcm512x driver supports only I2S data format.
>> This commit adds RJ and L
for I2S
* i don't see how existing off-tree sound cards with pcm512x codec could be
configured differently - it would not work
* tested explicitly, that there is no regression with Raspberry Pi +
sound card `sound/soc/bcm/hifiberry_dacplus.c`
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc
Signed-off-by: Kirill Marinushkin
---
MAINTAINERS| 2 +-
sound/soc/codecs/pcm3060-i2c.c | 4 ++--
sound/soc/codecs/pcm3060-spi.c | 4 ++--
sound/soc/codecs/pcm3060.c | 4 ++--
sound/soc/codecs/pcm3060.h | 2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
diff
On 06/11/19 19:49, Thomas Preston wrote:
> Add an I2C based codec driver for ST TDA7802 amplifier. By default, the
> amplifier supports 4 audio channels but can support up to 16 with
> multiple devices. Input is configurable for I2S or TDM.
>
> The unified device properties API is used to get
Softly reset registers values on module probe
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 8
1 file changed, 8 insertions(+)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index 6714aa8d9026..543cb86fd764 100644
--- a/sound/soc/codecs
for both ADC and DAC.
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 27 +++
sound/soc/codecs/pcm3060.h | 5 +
2 files changed, 32 insertions(+)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index 543cb86fd764..32b26f1c2282
>> First problem: I cannot compile the kernel with my version of compiler
>> Second problem: when I disable the feature - it cannot take effect,
>> because the parse-time error happens before `syncconfig`
On 12/08/18 13:42, Borislav Petkov wrote:
> Does this help?
>
>
>> First problem: I cannot compile the kernel with my version of compiler
>> Second problem: when I disable the feature - it cannot take effect,
>> because the parse-time error happens before `syncconfig`
On 12/08/18 13:42, Borislav Petkov wrote:
> Does this help?
>
>
$ make
arch/x86/Makefile:224: *** You are building kernel with non-retpoline
compiler, please update your compiler.. Stop.
Fixes: 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend on compiler
support")
Signed-off-by: Kirill Marinushkin
Cc: Thomas Gleixner
Cc: Ingo
$ make
arch/x86/Makefile:224: *** You are building kernel with non-retpoline
compiler, please update your compiler.. Stop.
Fixes: 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend on compiler
support")
Signed-off-by: Kirill Marinushkin
Cc: Thomas Gleixner
Cc: Ingo
Enable DAC/ADC only when playing/capturing
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 14 ++
sound/soc/codecs/pcm3060.h | 2 ++
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index
Enable DAC/ADC only when playing/capturing
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 14 ++
sound/soc/codecs/pcm3060.h | 2 ++
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index
:12:53 +0100, Kirill Marinushkin wrote:
>> Output of pcm3060 codec may be configured as single-ended or differential
>>
>> Signed-off-by: Kirill Marinushkin
>> Cc: devicet...@vger.kernel.org
>> ---
>> Hello Mark,
>>
>> yesterday there was a misunders
:12:53 +0100, Kirill Marinushkin wrote:
>> Output of pcm3060 codec may be configured as single-ended or differential
>>
>> Signed-off-by: Kirill Marinushkin
>> Cc: devicet...@vger.kernel.org
>> ---
>> Hello Mark,
>>
>> yesterday there was a misunders
Output of pcm3060 codec may be configured as single-ended or differential
Signed-off-by: Kirill Marinushkin
Cc: devicet...@vger.kernel.org
---
Hello Mark,
yesterday there was a misunderstanding: when I wrote you
> I think you forgot one patch in the series
you accidently applied the alre
Output of pcm3060 codec may be configured as single-ended or differential
Signed-off-by: Kirill Marinushkin
Cc: devicet...@vger.kernel.org
---
Hello Mark,
yesterday there was a misunderstanding: when I wrote you
> I think you forgot one patch in the series
you accidently applied the alre
s to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
> From b1cbde8fb287f4fd3493ca4167efee344c3e Mon Sep 17 00:00:00 2001
> From: Kirill Marinushkin
> Date: Mon, 12 Nov 2018 08:08:33 +0100
> Subject: [PATCH] ASoC: pcm3060: Add DT property for single-end
s to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
> From b1cbde8fb287f4fd3493ca4167efee344c3e Mon Sep 17 00:00:00 2001
> From: Kirill Marinushkin
> Date: Mon, 12 Nov 2018 08:08:33 +0100
> Subject: [PATCH] ASoC: pcm3060: Add DT property for single-end
nded
output")
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index 5f479aa61097..1dd851a7b43b 100644
--- a/sound/soc/codecs/pcm3060.c
++
nded
output")
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index 5f479aa61097..1dd851a7b43b 100644
--- a/sound/soc/codecs/pcm3060.c
++
Output of pcm3060 codec may be configured as single-ended or differential
Signed-off-by: Kirill Marinushkin
Cc: devicet...@vger.kernel.org
---
Documentation/devicetree/bindings/sound/pcm3060.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound
DAC output may be differential (default) or single-ended.
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 14 ++
sound/soc/codecs/pcm3060.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index
Output of pcm3060 codec may be configured as single-ended or differential
Signed-off-by: Kirill Marinushkin
Cc: devicet...@vger.kernel.org
---
Documentation/devicetree/bindings/sound/pcm3060.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound
DAC output may be differential (default) or single-ended.
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 14 ++
sound/soc/codecs/pcm3060.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index
Hello Mark,
On 11/05/18 12:20, Mark Brown wrote:
> On Mon, Oct 29, 2018 at 09:59:12AM +0100, Kirill Marinushkin wrote:
>> DAC may be switched between differential and single-ended output.
>
> Isn't this something that'd be better controlled by DT - it's usually
> going to be
Hello Mark,
On 11/05/18 12:20, Mark Brown wrote:
> On Mon, Oct 29, 2018 at 09:59:12AM +0100, Kirill Marinushkin wrote:
>> DAC may be switched between differential and single-ended output.
>
> Isn't this something that'd be better controlled by DT - it's usually
> going to be
t")
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index f792ad637ae4..078a3b1fc064 100644
--- a/sound/soc/codecs/pcm3060.c
+++ b/sound/
t")
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index f792ad637ae4..078a3b1fc064 100644
--- a/sound/soc/codecs/pcm3060.c
+++ b/sound/
DAC may be switched between differential and single-ended output.
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 9 +
sound/soc/codecs/pcm3060.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index
DAC may be switched between differential and single-ended output.
Signed-off-by: Kirill Marinushkin
---
sound/soc/codecs/pcm3060.c | 9 +
sound/soc/codecs/pcm3060.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
index
Hello Takashi, Mike,
@Takashi
On 10/25/18 09:37, Takashi Iwai wrote:
> Well, in the API POV, it's nothing wrong to keep hwptr sticking while
> updating only delay value. It implies that the hardware chip doesn't
> provide the hwptr update.
Thank you for the clarification. Modifying
Hello Takashi, Mike,
@Takashi
On 10/25/18 09:37, Takashi Iwai wrote:
> Well, in the API POV, it's nothing wrong to keep hwptr sticking while
> updating only delay value. It implies that the hardware chip doesn't
> provide the hwptr update.
Thank you for the clarification. Modifying
Hello Mike,
We are not on the same page. What you hear is not what I tell you.
Either you don't understand what happens in your commit, or I don't understand
what happens in the driver.
Hopefully somebody in the community can comment here.
On 10/24/18 21:54, Mike Brady wrote:
You modify
Hello Mike,
We are not on the same page. What you hear is not what I tell you.
Either you don't understand what happens in your commit, or I don't understand
what happens in the driver.
Hopefully somebody in the community can comment here.
On 10/24/18 21:54, Mike Brady wrote:
You modify
Hello Mike,
On 10/24/18 10:20, Mike Brady wrote:
> Hi Kirill. Thanks for your comments.
>
>> On 22 Oct 2018, at 23:25, Kirill Marinushkin wrote:
>>
>> AFAIU, this patch is wrong. Please correct me, maybe I misunderstand
>> something.
>>
>>>
Hello Mike,
On 10/24/18 10:20, Mike Brady wrote:
> Hi Kirill. Thanks for your comments.
>
>> On 22 Oct 2018, at 23:25, Kirill Marinushkin wrote:
>>
>> AFAIU, this patch is wrong. Please correct me, maybe I misunderstand
>> something.
>>
>>>
Hello Mike,
AFAIU, this patch is wrong. Please correct me, maybe I misunderstand something.
> The problem that this patch seeks to resolve is that when userland asks for
> the delay
The userspace asks not for delay, but for the pointer.
You modify the function, which is called
Hello Mike,
AFAIU, this patch is wrong. Please correct me, maybe I misunderstand something.
> The problem that this patch seeks to resolve is that when userland asks for
> the delay
The userspace asks not for delay, but for the pointer.
You modify the function, which is called
Hello Mike,
On 10/18/18 12:57, Mike Brady wrote:
> + ktime_t now = ktime_get();
> +
> + /* Give userspace better delay reporting by interpolating between GPU
> + * notifications, assuming audio speed is close enough to the clock
> + * used for ktime
> + */
> +
> + if
Hello Mike,
On 10/18/18 12:57, Mike Brady wrote:
> + ktime_t now = ktime_get();
> +
> + /* Give userspace better delay reporting by interpolating between GPU
> + * notifications, assuming audio speed is close enough to the clock
> + * used for ktime
> + */
> +
> + if
Modified some if-statements to make them more clear
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: alsa-de...@alsa-project.org
Cc: linux-kernel@vger.kernel.org
---
sound/soc/codecs/pcm3060.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs
Modified some if-statements to make them more clear
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: alsa-de...@alsa-project.org
Cc: linux-kernel@vger.kernel.org
---
sound/soc/codecs/pcm3060.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs
Modified the complete file comments in C++ style, to make them look more
intentional
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: alsa-de...@alsa-project.org
Cc: linux-kernel@vger.kernel.org
---
sound/soc/codecs/pcm3060-i2c.c | 9 -
sound/soc/codecs/pcm3060-spi.c | 9
Modified the complete file comments in C++ style, to make them look more
intentional
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: alsa-de...@alsa-project.org
Cc: linux-kernel@vger.kernel.org
---
sound/soc/codecs/pcm3060-i2c.c | 9 -
sound/soc/codecs/pcm3060-spi.c | 9
This commit adds support for TI PCM3060 CODEC.
The technical documentation is available at [1].
[1] http://ti.com/product/pcm3060
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: Liam Girdwood
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: M R Swami Reddy
Cc: Vishwas A Deshpande
Cc: Kevin
This commit adds support for TI PCM3060 CODEC.
The technical documentation is available at [1].
[1] http://ti.com/product/pcm3060
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: Liam Girdwood
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: M R Swami Reddy
Cc: Vishwas A Deshpande
Cc: Kevin
Hello Mark,
I am developing sound support for a Linux-based device, with playback and
capture through the TI PCM3060 codec.
With the following patch, I propose to add the PCM3060 codec driver into
the kernel.
Best Regards,
Kirill
Kirill Marinushkin (1):
ASoC: pcm3060: Add codec driver
Hello Mark,
I am developing sound support for a Linux-based device, with playback and
capture through the TI PCM3060 codec.
With the following patch, I propose to add the PCM3060 codec driver into
the kernel.
Best Regards,
Kirill
Kirill Marinushkin (1):
ASoC: pcm3060: Add codec driver
0c>] snd_open+0xa8/0x14c [snd]
[<802ce590>] chrdev_open+0xac/0x188
[<802c57b4>] do_dentry_open+0x10c/0x314
[<802c6ba8>] vfs_open+0x5c/0x88
[<802d9a68>] path_openat+0x368/0x944
[<802dacd4>] do_filp_open+0x70/0xc4
[<802c6f70>] do_sys_open+0
0c>] snd_open+0xa8/0x14c [snd]
[<802ce590>] chrdev_open+0xac/0x188
[<802c57b4>] do_dentry_open+0x10c/0x314
[<802c6ba8>] vfs_open+0x5c/0x88
[<802d9a68>] path_openat+0x368/0x944
[<802dacd4>] do_filp_open+0x70/0xc4
[<802c6f70>] do_sys_open+0x
On 04/25/18 08:16, Greg Kroah-Hartman wrote:
> On Tue, Apr 24, 2018 at 09:57:29PM +0200, Kirill Marinushkin wrote:
>> In the current implementation, vchi_instance is inited during the first
>> call of bcm2835_audio_open_connection(), and is never freed. It causes a
>> memory
On 04/25/18 08:16, Greg Kroah-Hartman wrote:
> On Tue, Apr 24, 2018 at 09:57:29PM +0200, Kirill Marinushkin wrote:
>> In the current implementation, vchi_instance is inited during the first
>> call of bcm2835_audio_open_connection(), and is never freed. It causes a
>> memory
0c>] snd_open+0xa8/0x14c [snd]
[<802ce590>] chrdev_open+0xac/0x188
[<802c57b4>] do_dentry_open+0x10c/0x314
[<802c6ba8>] vfs_open+0x5c/0x88
[<802d9a68>] path_openat+0x368/0x944
[<802dacd4>] do_filp_open+0x70/0xc4
[<802c6f70>] do_sys_open+0
0c>] snd_open+0xa8/0x14c [snd]
[<802ce590>] chrdev_open+0xac/0x188
[<802c57b4>] do_dentry_open+0x10c/0x314
[<802c6ba8>] vfs_open+0x5c/0x88
[<802d9a68>] path_openat+0x368/0x944
[<802dacd4>] do_filp_open+0x70/0xc4
[<802c6f70>] do_sys_open+0x
On 04/24/18 20:35, Andy Shevchenko wrote:
> On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin
> <k.marinush...@gmail.com> wrote:
>
>> @Andy
>>
>>> AFAIR I gave you a tag and you again missed it.
>>> Before sending anything just check twice if all pr
On 04/24/18 20:35, Andy Shevchenko wrote:
> On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin
> wrote:
>
>> @Andy
>>
>>> AFAIR I gave you a tag and you again missed it.
>>> Before sending anything just check twice if all prerequisites are fulfilled.
>&g
again missed it.
> Before sending anything just check twice if all prerequisites are fulfilled.
I think you mix it up. This is a new patch, you didn't review it before.
> And yes, kbuild bot is right. You need to return known value.
Yes, that's right. I will fix it.
Best Regards,
Kirill
again missed it.
> Before sending anything just check twice if all prerequisites are fulfilled.
I think you mix it up. This is a new patch, you didn't review it before.
> And yes, kbuild bot is right. You need to return known value.
Yes, that's right. I will fix it.
Best Regards,
Kirill
0c>] snd_open+0xa8/0x14c [snd]
[<802ce590>] chrdev_open+0xac/0x188
[<802c57b4>] do_dentry_open+0x10c/0x314
[<802c6ba8>] vfs_open+0x5c/0x88
[<802d9a68>] path_openat+0x368/0x944
[<802dacd4>] do_filp_open+0x70/0xc4
[<802c6f70>] do_sys_open+0
0c>] snd_open+0xa8/0x14c [snd]
[<802ce590>] chrdev_open+0xac/0x188
[<802c57b4>] do_dentry_open+0x10c/0x314
[<802c6ba8>] vfs_open+0x5c/0x88
[<802d9a68>] path_openat+0x368/0x944
[<802dacd4>] do_filp_open+0x70/0xc4
[<802c6f70>] do_sys_open+0x
On 04/23/18 15:50, Greg Kroah-Hartman wrote:
> On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote:
>> In the current implementation, vchi_instance is inited during the first
>> call of bcm2835_audio_open_connection(), and is never freed. It causes a
>> memory
On 04/23/18 15:50, Greg Kroah-Hartman wrote:
> On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote:
>> In the current implementation, vchi_instance is inited during the first
>> call of bcm2835_audio_open_connection(), and is never freed. It causes a
>> memory
0c>] snd_open+0xa8/0x14c [snd]
[<802ce590>] chrdev_open+0xac/0x188
[<802c57b4>] do_dentry_open+0x10c/0x314
[<802c6ba8>] vfs_open+0x5c/0x88
[<802d9a68>] path_openat+0x368/0x944
[<802dacd4>] do_filp_open+0x70/0xc4
[<802c6f70>] do_sys_open+0
0c>] snd_open+0xa8/0x14c [snd]
[<802ce590>] chrdev_open+0xac/0x188
[<802c57b4>] do_dentry_open+0x10c/0x314
[<802c6ba8>] vfs_open+0x5c/0x88
[<802d9a68>] path_openat+0x368/0x944
[<802dacd4>] do_filp_open+0x70/0xc4
[<802c6f70>] do_sys_open+0x
with the corresponding patch for linux.
Signed-off-by: Kirill Marinushkin <k.marinush...@gmail.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com>
Tested-by: Pan Xiuli <xiuli@linux.intel.com>
Tested-by: Pierre-Louis Bossart <pierre-louis.boss..
with the corresponding patch for linux.
Signed-off-by: Kirill Marinushkin
Reviewed-by: Pierre-Louis Bossart
Tested-by: Pan Xiuli
Tested-by: Pierre-Louis Bossart
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: Mark Brown
Cc: Liam Girdwood
Cc: linux-kernel@vger.kernel.org
Cc: alsa-de...@alsa-project.org
be gated
}
SectionLink."Codec" {
# used for binding to the physical link
id "0"
hw_configs [
"CodecHWConfig"
]
default_hw_conf_id "1"
}
Signed-off-by: Kirill Marinushkin <k.marinush...@gmail.com>
R
be gated
}
SectionLink."Codec" {
# used for binding to the physical link
id "0"
hw_configs [
"CodecHWConfig"
]
default_hw_conf_id "1"
}
Signed-off-by: Kirill Marinushkin
Reviewed-by: Pierre-Louis Bossart
This improves the coding style of this piece of code.
Signed-off-by: Kirill Marinushkin <k.marinush...@gmail.com>
Cc: Mark Brown <broo...@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com>
Cc: Jaroslav Kysela <pe...@perex.cz>
Cc: Takashi Iwai <t
This improves the coding style of this piece of code.
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: Pierre-Louis Bossart
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: Pan Xiuli
Cc: Liam Girdwood
Cc: linux-kernel@vger.kernel.org
Cc: alsa-de...@alsa-project.org
---
sound/soc/soc
series,
please apply it to Linux.
Best Regards,
Kirill
Kirill Marinushkin (3):
ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()
ASoC: topology: Add missing clock gating parameter when parsing
hw_configs
ASoC: topology: Add definitions for mclk_direction
be gated
}
SectionLink."Codec" {
# used for binding to the physical link
id "0"
hw_configs [
"CodecHWConfig"
]
default_hw_conf_id "1"
}
Signed-off-by: Kirill Marinushkin <k.marinush...@gmail.com>
R
The values of bclk and fsync are inverted WRT the codec. But the existing
solution already works for Broadwell, see the alsa-lib config:
`alsa-lib/src/conf/topology/broadwell/broadwell.conf`
This commit provides the backwards-compatible solution to fix this misuse.
Signed-off-by: Kirill
series,
please apply it to Linux.
Best Regards,
Kirill
Kirill Marinushkin (3):
ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()
ASoC: topology: Add missing clock gating parameter when parsing
hw_configs
ASoC: topology: Add definitions for mclk_direction
be gated
}
SectionLink."Codec" {
# used for binding to the physical link
id "0"
hw_configs [
"CodecHWConfig"
]
default_hw_conf_id "1"
}
Signed-off-by: Kirill Marinushkin
Reviewed-by: Pierre-Louis Bossart
The values of bclk and fsync are inverted WRT the codec. But the existing
solution already works for Broadwell, see the alsa-lib config:
`alsa-lib/src/conf/topology/broadwell/broadwell.conf`
This commit provides the backwards-compatible solution to fix this misuse.
Signed-off-by: Kirill
Current comment makes not clear the direction of mclk. Previously, similar
description caused a misunderstanding for bclk_master and fsync_master.
This commit solves the potential confusion the same way it is solved for
bclk_master and fsync_master.
Signed-off-by: Kirill Marinushkin <k.marin
Current comment makes not clear the direction of mclk. Previously, similar
description caused a misunderstanding for bclk_master and fsync_master.
This commit solves the potential confusion the same way it is solved for
bclk_master and fsync_master.
Signed-off-by: Kirill Marinushkin
Acked
On 04/03/18 19:21, Pierre-Louis Bossart wrote:
>
>
> On 04/03/2018 12:15 AM, Kirill Marinushkin wrote:
>> On 04/03/18 02:57, Pierre-Louis Bossart wrote:
>>>
>>> On 04/02/2018 04:17 PM, Kirill Marinushkin wrote:
>>>> Hello Pierre-Louis,
>>&
On 04/03/18 19:21, Pierre-Louis Bossart wrote:
>
>
> On 04/03/2018 12:15 AM, Kirill Marinushkin wrote:
>> On 04/03/18 02:57, Pierre-Louis Bossart wrote:
>>>
>>> On 04/02/2018 04:17 PM, Kirill Marinushkin wrote:
>>>> Hello Pierre-Louis,
>>&
On 04/03/18 02:57, Pierre-Louis Bossart wrote:
>
>
> On 04/02/2018 04:17 PM, Kirill Marinushkin wrote:
>> Hello Pierre-Louis,
>>
>> I explicitly clarified with Takashi: to have this patch series merged, we
>> need a
>> tag "Reviewed-by" from you.
On 04/03/18 02:57, Pierre-Louis Bossart wrote:
>
>
> On 04/02/2018 04:17 PM, Kirill Marinushkin wrote:
>> Hello Pierre-Louis,
>>
>> I explicitly clarified with Takashi: to have this patch series merged, we
>> need a
>> tag "Reviewed-by" from you.
sa-lib, v3 2/2] ASoC: topology: Add missing clock gating
parameter when parsing hw_configs
On 03/27/18 22:56, Kirill Marinushkin wrote:
> Hello Jaroslav, Takashi, Mark,
>
> This patch series is a resend of [1] and [2], rebased on top of the latest
> head. It was logical to resend them tog
sa-lib, v3 2/2] ASoC: topology: Add missing clock gating
parameter when parsing hw_configs
On 03/27/18 22:56, Kirill Marinushkin wrote:
> Hello Jaroslav, Takashi, Mark,
>
> This patch series is a resend of [1] and [2], rebased on top of the latest
> head. It was logical to resend them tog
with the corresponding patch for linux.
Signed-off-by: Kirill Marinushkin <k.marinush...@gmail.com>
Tested-by: Pan Xiuli <xiuli@linux.intel.com>
Tested-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com>
Cc: Jaroslav Kysela <pe...@perex.cz>
Cc: Takashi Iwai <ti
with the corresponding patch for linux.
Signed-off-by: Kirill Marinushkin
Tested-by: Pan Xiuli
Tested-by: Pierre-Louis Bossart
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: Mark Brown
Cc: Liam Girdwood
Cc: linux-kernel@vger.kernel.org
Cc: alsa-de...@alsa-project.org
---
include/sound/asoc.h
be gated
}
SectionLink."Codec" {
# used for binding to the physical link
id "0"
hw_configs [
"CodecHWConfig"
]
default_hw_conf_id "1"
}
Signed-off-by: Kirill Marinushkin <k.marinush...@gmail.com
be gated
}
SectionLink."Codec" {
# used for binding to the physical link
id "0"
hw_configs [
"CodecHWConfig"
]
default_hw_conf_id "1"
}
Signed-off-by: Kirill Marinushkin
Cc: Jaroslav Kysela
Cc: Tak
Below is the alsa-lib part of the patch-series
"ASoC: topology: Improve parsing hw_configs"
Kirill Marinushkin (2):
ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()
ASoC: topology: Add missing clock gating parameter when parsing
hw_configs
include/so
Below is the alsa-lib part of the patch-series
"ASoC: topology: Improve parsing hw_configs"
Kirill Marinushkin (2):
ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()
ASoC: topology: Add missing clock gating parameter when parsing
hw_configs
include/so
be gated
}
SectionLink."Codec" {
# used for binding to the physical link
id "0"
hw_configs [
"CodecHWConfig"
]
default_hw_conf_id "1"
}
Signed-off-by: Kirill Marinushkin <k.marinush...@gmail.com
be gated
}
SectionLink."Codec" {
# used for binding to the physical link
id "0"
hw_configs [
"CodecHWConfig"
]
default_hw_conf_id "1"
}
Signed-off-by: Kirill Marinushkin
Cc: Jaroslav Kysela
Cc: Tak
The values of bclk and fsync are inverted WRT the codec. But the existing
solution already works for Broadwell, see the alsa-lib config:
`alsa-lib/src/conf/topology/broadwell/broadwell.conf`
This commit provides the backwards-compatible solution to fix this misuse.
Signed-off-by: Kirill
1 - 100 of 201 matches
Mail list logo
