Re: [PATCH] staging: sm750fb: fix c99 comments

2015-06-12 Thread Konrad Zapalowicz
On 06/12, Juston Li wrote: > fixed all checkpatch.pl ERROR: do not use C99 // comments > > Any C99 comments used to comment out code are simply removed. > Also some of the errors occur inside '#if 0' blocks which I > might as well fix since checkpatch.pl caught them but the blocks > themselves

Re: [PATCH] staging: sm750fb: fix c99 comments

2015-06-12 Thread Konrad Zapalowicz
On 06/12, Juston Li wrote: fixed all checkpatch.pl ERROR: do not use C99 // comments Any C99 comments used to comment out code are simply removed. Also some of the errors occur inside '#if 0' blocks which I might as well fix since checkpatch.pl caught them but the blocks themselves should

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Konrad Zapalowicz
On 06/02, Sudip Mukherjee wrote: > On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote: > > On 06/02, Sudip Mukherjee wrote: > > > size_t should print using %zu, but here it was using %d and hence we > > > were getting warning while printing. > &

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Konrad Zapalowicz
On 06/02, Sudip Mukherjee wrote: > size_t should print using %zu, but here it was using %d and hence we > were getting warning while printing. > > Signed-off-by: Sudip Mukherjee > --- > > I think it will be easy to remove the other warnings if all the typedefs > are removed first. > >

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Konrad Zapalowicz
On 06/02, Sudip Mukherjee wrote: On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote: On 06/02, Sudip Mukherjee wrote: size_t should print using %zu, but here it was using %d and hence we were getting warning while printing. Signed-off-by: Sudip Mukherjee su

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Konrad Zapalowicz
On 06/02, Sudip Mukherjee wrote: size_t should print using %zu, but here it was using %d and hence we were getting warning while printing. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- I think it will be easy to remove the other warnings if all the typedefs are removed first.

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Konrad Zapalowicz
On 01/11, Pavel Machek wrote: > On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote: > > On 01/11, atull wrote: > > > On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: > > > > > > > On 01/06, at...@opensource.altera.com wrote: > > > > > From: Alan

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Konrad Zapalowicz
On 01/11, atull wrote: > On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: > > > On 01/06, at...@opensource.altera.com wrote: > > > From: Alan Tull > > > > Alan, there is something wrong with your email client configuration > > and you need to fix. >

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Konrad Zapalowicz
On 01/11, atull wrote: On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something wrong with your email client configuration and you need to fix. thanks, konrad Hi Konrad

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Konrad Zapalowicz
On 01/11, Pavel Machek wrote: On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote: On 01/11, atull wrote: On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-10 Thread Konrad Zapalowicz
On 01/06, at...@opensource.altera.com wrote: > From: Alan Tull Alan, there is something wrong with your email client configuration and you need to fix. thanks, konrad > v8 changes the compatible string for SOCFPGA FPGA managers > to be more chip specific. > > "altr,fpga-mgr" becomes

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-10 Thread Konrad Zapalowicz
On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something wrong with your email client configuration and you need to fix. thanks, konrad v8 changes the compatible string for SOCFPGA FPGA managers to be more chip specific.

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-06 Thread Konrad Zapalowicz
On 01/06, Sudip Mukherjee wrote: > On Tue, Jan 06, 2015 at 10:08:37AM +, Ian Abbott wrote: > > On 06/01/15 06:02, Sudip Mukherjee wrote: > > >On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote: > > >>On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zap

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-06 Thread Konrad Zapalowicz
On 01/06, Sudip Mukherjee wrote: On Tue, Jan 06, 2015 at 10:08:37AM +, Ian Abbott wrote: On 06/01/15 06:02, Sudip Mukherjee wrote: On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote: On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote: On 01/04, Piotr Kubus

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-04 Thread Konrad Zapalowicz
On 01/04, Piotr Kubus wrote: > This is a patch to the dmm32at.c file that fixes up a code indent error found > by the checkpatch.pl tool. Nice however improve your commit message. The rule is that the lines should wrap at 72nd column except for quoted material such as compiler output, etc...

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-04 Thread Konrad Zapalowicz
On 01/04, Piotr Kubus wrote: This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool. Nice however improve your commit message. The rule is that the lines should wrap at 72nd column except for quoted material such as compiler output, etc... The

Re: [PATCH 0/5] *** SUBJECT HERE ***

2015-01-03 Thread Konrad Zapalowicz
On 01/03, Paul Bolle wrote: > On Sat, 2015-01-03 at 08:45 -0800, Greg KH wrote: > > On Sat, Jan 03, 2015 at 02:06:22PM +0530, jitendra kumar khasdev wrote: > > > *** BLURB HERE *** > > > > What blurb? What subject? > > jitendra used git-send-email to send this series. You'd expect >

Re: [PATCH] staging: gdm724x: fix coding style issues

2015-01-03 Thread Konrad Zapalowicz
On 01/03, Ning Zhou wrote: > Signed-off-by: Ning Zhou You need to describe your changes, a vague subject is not enough. Also keep in mind that one patch shall address one category of stuff and seems that yours could be separated into two. thanks, konrad > --- >

Re: [PATCH] staging: gdm724x: fix coding style issues

2015-01-03 Thread Konrad Zapalowicz
On 01/03, Ning Zhou wrote: Signed-off-by: Ning Zhou zhou.ning...@gmail.com You need to describe your changes, a vague subject is not enough. Also keep in mind that one patch shall address one category of stuff and seems that yours could be separated into two. thanks, konrad ---

Re: [PATCH 0/5] *** SUBJECT HERE ***

2015-01-03 Thread Konrad Zapalowicz
On 01/03, Paul Bolle wrote: On Sat, 2015-01-03 at 08:45 -0800, Greg KH wrote: On Sat, Jan 03, 2015 at 02:06:22PM +0530, jitendra kumar khasdev wrote: *** BLURB HERE *** What blurb? What subject? jitendra used git-send-email to send this series. You'd expect git-send-email to die

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: > On 31 December 2014 at 19:00, Konrad Zapalowicz > wrote: > > > > You also fix the line length here which shall be the subject of a > > separate patch as this is not C99 comments related change. > > > > Apologie

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 841 > ++- > 1 file changed, 432

Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Serguey Parkhomovsky wrote: > Fixes the following sparse warnings: > > drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: > symbol 'libcfs_arch_init' was not declared. Should it be static? > drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning: >

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com --- drivers/staging/rtl8192u/r8192U_dm.c | 841 ++- 1 file changed, 432

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: On 31 December 2014 at 19:00, Konrad Zapalowicz bergo.tor...@gmail.com wrote: You also fix the line length here which shall be the subject of a separate patch as this is not C99 comments related change. Apologies - I missed this, will prepare a v2

Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Serguey Parkhomovsky wrote: Fixes the following sparse warnings: drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: symbol 'libcfs_arch_init' was not declared. Should it be static? drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning:

Re: [PATCH] Staging: line6: pcm: Corrected checkpatch notices in pcm.h

2014-12-26 Thread Konrad Zapalowicz
On 12/26, Damon Swayn wrote: > Fixed a coding style issue You need to be more specific here, describe what kind of issue this patch is fixing. Keep in mind that this message, when formulated properly, will end up as a comment to the Linux kernel source - it must, therefore, contain valuable

Re: [PATCH] Staging: line6: pcm: Corrected checkpatch notices in pcm.h

2014-12-26 Thread Konrad Zapalowicz
On 12/26, Damon Swayn wrote: Fixed a coding style issue You need to be more specific here, describe what kind of issue this patch is fixing. Keep in mind that this message, when formulated properly, will end up as a comment to the Linux kernel source - it must, therefore, contain valuable

Re: [PATCH] drivers:staging:octeon:ethernet-rx.c: Added blank line after declarations

2014-11-30 Thread Konrad Zapalowicz
On 11/30, Anjana Sasindran wrote: > This patch fixes the checkpatch.pl warnings: Your subject line is somewhat broken as it does not really follow the canonical patch format. You can read up on it here (section 15) https://www.kernel.org/doc/Documentation/SubmittingPatches and this is the short

Re: [PATCH] drivers:staging:octeon:ethernet-rx.c: Added blank line after declarations

2014-11-30 Thread Konrad Zapalowicz
On 11/30, Anjana Sasindran wrote: This patch fixes the checkpatch.pl warnings: Your subject line is somewhat broken as it does not really follow the canonical patch format. You can read up on it here (section 15) https://www.kernel.org/doc/Documentation/SubmittingPatches and this is the short

Re: [PATCH] staging: media: bcm2048: fix coding style error

2014-11-15 Thread Konrad Zapalowicz
On 11/15, Pavel Machek wrote: > On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote: > > On 11/15, Christian Resell wrote: > > > Simple style fix (checkpatch.pl: "space prohibited before that ','"). > > > For the eudyptula challenge (http://eudyptula-challeng

Re: [PATCH] staging: media: bcm2048: fix coding style error

2014-11-15 Thread Konrad Zapalowicz
On 11/15, Christian Resell wrote: > Simple style fix (checkpatch.pl: "space prohibited before that ','"). > For the eudyptula challenge (http://eudyptula-challenge.org/). Nice, however we do not need the information about the 'eudyptula challenge' in the commit message. If you want to include

Re: [PATCH] staging: media: bcm2048: fix coding style error

2014-11-15 Thread Konrad Zapalowicz
On 11/15, Christian Resell wrote: Simple style fix (checkpatch.pl: space prohibited before that ','). For the eudyptula challenge (http://eudyptula-challenge.org/). Nice, however we do not need the information about the 'eudyptula challenge' in the commit message. If you want to include extra

Re: [PATCH] staging: media: bcm2048: fix coding style error

2014-11-15 Thread Konrad Zapalowicz
On 11/15, Pavel Machek wrote: On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote: On 11/15, Christian Resell wrote: Simple style fix (checkpatch.pl: space prohibited before that ','). For the eudyptula challenge (http://eudyptula-challenge.org/). Nice, however we do not need

[PATCH 4/5] serial: jsm: Replace magic value with the proper define

2014-11-08 Thread Konrad Zapalowicz
The changed function flushes the tx UART and the '4' corresponds to the UART_FCR_CLEAR_XMIT value. This commit replaces the magic number with this define. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm_neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/5] serial: jsm: Remove unnecessary parameter from clear_break()

2014-11-08 Thread Konrad Zapalowicz
The 'force' parameter to the {cls,neo}_send_break() function has been removed because it has not been used. The client to this API (the tty code) always called this function with only one value. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm.h | 2 +- drivers/tty/serial/jsm

[PATCH 2/5] serial: jsm: Remove unnecessary if statement

2014-11-08 Thread Konrad Zapalowicz
The flow of {neo,cls}_param() shows that at this stage the baud rate has a non-zero value. This fact makes the if clausule obsolete and acknowledges it's removal. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm_cls.c | 3 --- drivers/tty/serial/jsm/jsm_neo.c | 3 --- 2 files

[PATCH 0/5] serial: jsm: Provide better code quality

2014-11-08 Thread Konrad Zapalowicz
This series of patches fixes a few minor issues in the jsm driver. The patches do not only address the coding style issues however none of them changes the logic. These patches are against the current tty-next. Konrad Zapalowicz (5): serial: jsm: Remove unnecessary parameter from clear_break

[PATCH 5/5] serial: jsm: Fix unnecessary space before function ptr arguments

2014-11-08 Thread Konrad Zapalowicz
This commit deals with the checkpatch warning "Unnecessary space before function pointer arguments". Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/tty/

[PATCH 3/5] serial: jsm: Fix the alignment of the switch satement

2014-11-08 Thread Konrad Zapalowicz
This commit fixes the alignment of the 'case's i the switch statement. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm_neo.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm_neo.c b/drivers/tty/serial/jsm

[PATCH 3/5] serial: jsm: Fix the alignment of the switch satement

2014-11-08 Thread Konrad Zapalowicz
This commit fixes the alignment of the 'case's i the switch statement. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm_neo.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm_neo.c b

[PATCH 0/5] serial: jsm: Provide better code quality

2014-11-08 Thread Konrad Zapalowicz
This series of patches fixes a few minor issues in the jsm driver. The patches do not only address the coding style issues however none of them changes the logic. These patches are against the current tty-next. Konrad Zapalowicz (5): serial: jsm: Remove unnecessary parameter from clear_break

[PATCH 5/5] serial: jsm: Fix unnecessary space before function ptr arguments

2014-11-08 Thread Konrad Zapalowicz
This commit deals with the checkpatch warning Unnecessary space before function pointer arguments. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers

[PATCH 1/5] serial: jsm: Remove unnecessary parameter from clear_break()

2014-11-08 Thread Konrad Zapalowicz
The 'force' parameter to the {cls,neo}_send_break() function has been removed because it has not been used. The client to this API (the tty code) always called this function with only one value. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h | 2

[PATCH 2/5] serial: jsm: Remove unnecessary if statement

2014-11-08 Thread Konrad Zapalowicz
The flow of {neo,cls}_param() shows that at this stage the baud rate has a non-zero value. This fact makes the if clausule obsolete and acknowledges it's removal. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm_cls.c | 3 --- drivers/tty/serial/jsm

[PATCH 4/5] serial: jsm: Replace magic value with the proper define

2014-11-08 Thread Konrad Zapalowicz
The changed function flushes the tx UART and the '4' corresponds to the UART_FCR_CLEAR_XMIT value. This commit replaces the magic number with this define. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm_neo.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 3/4] staging: dgnc: Remove driver in favor of serial/jsm driver

2014-11-06 Thread Konrad Zapalowicz
On 11/06, Greg KH wrote: > On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote: > > This commit removes the staging/dgnc driver in favor of the serial/jsm > > driver. > > > > This is because the serial/jsm driver now supports all of the hardware

Re: [PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-06 Thread Konrad Zapalowicz
On 11/06, Greg KH wrote: > On Mon, Nov 03, 2014 at 07:52:38PM +0100, Konrad Zapalowicz wrote: > > This commit adds the Digi Classic board implementation to the > > staging/jsm driver. > > > > The code here is taken from the staging/dgnc driver and modified to >

[PATCH v2 1/4] drivers: serial: jsm: Add the Classic board implementation

2014-11-06 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty/serial/jsm/jsm.h

[PATCH v2 4/4] drivers: serial: jsm: Remove FSF address from the file documentation/header

2014-11-06 Thread Konrad Zapalowicz
This commit removes the address of Free Software Foundation from each of the mentioned file in order to suppress the checkpatch warning. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm.h| 5 - drivers/tty/serial/jsm/jsm_cls.c| 5 - drivers/tty/serial/jsm

[PATCH v2 2/4] drivers: serial: jsm: Enable support for Digi Classic adapters

2014-11-06 Thread Konrad Zapalowicz
This commit enables support for the Digi Classic adapters line in the jsm driver. This means changes in: - device probing code - device cleanup code - driver description (Kconfig) The init/cleanup code is based on the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz

[PATCH v2 0/4] serial: jsm: Add support for the Digi Classic adapters

2014-11-06 Thread Konrad Zapalowicz
of the series. since Greg has already merged the patch 01 from the first series this time it is not attached therefore this series has only 4 patches in it (previously was 5). Konrad Zapalowicz (4): drivers: serial: jsm: Add the Classic

[PATCH v2 0/4] serial: jsm: Add support for the Digi Classic adapters

2014-11-06 Thread Konrad Zapalowicz
of the series. since Greg has already merged the patch 01 from the first series this time it is not attached therefore this series has only 4 patches in it (previously was 5). Konrad Zapalowicz (4): drivers: serial: jsm: Add the Classic

[PATCH v2 2/4] drivers: serial: jsm: Enable support for Digi Classic adapters

2014-11-06 Thread Konrad Zapalowicz
This commit enables support for the Digi Classic adapters line in the jsm driver. This means changes in: - device probing code - device cleanup code - driver description (Kconfig) The init/cleanup code is based on the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz

[PATCH v2 1/4] drivers: serial: jsm: Add the Classic board implementation

2014-11-06 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty

[PATCH v2 4/4] drivers: serial: jsm: Remove FSF address from the file documentation/header

2014-11-06 Thread Konrad Zapalowicz
This commit removes the address of Free Software Foundation from each of the mentioned file in order to suppress the checkpatch warning. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h| 5 - drivers/tty/serial/jsm/jsm_cls.c| 5

Re: [PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-06 Thread Konrad Zapalowicz
On 11/06, Greg KH wrote: On Mon, Nov 03, 2014 at 07:52:38PM +0100, Konrad Zapalowicz wrote: This commit adds the Digi Classic board implementation to the staging/jsm driver. The code here is taken from the staging/dgnc driver and modified to match the serial/jsm state. This work

Re: [PATCH v2 3/4] staging: dgnc: Remove driver in favor of serial/jsm driver

2014-11-06 Thread Konrad Zapalowicz
On 11/06, Greg KH wrote: On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote: This commit removes the staging/dgnc driver in favor of the serial/jsm driver. This is because the serial/jsm driver now supports all of the hardware that has been supported by the staging/dgnc

[PATCH 3/5] drivers: serial: jsm: Enable support for Digi Classic adapters

2014-11-03 Thread Konrad Zapalowicz
This commit enables support for the Digi Classic adapters line in the jsm driver. This means changes in: - device probing code - device cleanup code - driver description (Kconfig) The init/cleanup code is based on the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz

[PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-03 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty/serial/jsm/jsm.h

[PATCH 1/5] drivers: serial: jsm: Add Classic board UART structure

2014-11-03 Thread Konrad Zapalowicz
This commit adds the UART structure for the Digi Classic cards. This code comes from the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm.h | 59 +++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git

[PATCH 1/5] drivers: serial: jsm: Add Classic board UART structure

2014-11-03 Thread Konrad Zapalowicz
This commit adds the UART structure for the Digi Classic cards. This code comes from the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h | 59 +++- 1 file changed, 58 insertions(+), 1 deletion

[PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-03 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty

[PATCH 3/5] drivers: serial: jsm: Enable support for Digi Classic adapters

2014-11-03 Thread Konrad Zapalowicz
This commit enables support for the Digi Classic adapters line in the jsm driver. This means changes in: - device probing code - device cleanup code - driver description (Kconfig) The init/cleanup code is based on the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz

[PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-02 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty/serial/jsm/jsm.h

[PATCH 5/5] drivers: serial: jsm: Remove FSF address from the file documentation/header

2014-11-02 Thread Konrad Zapalowicz
This commit removes the address of Free Software Foundation from each of the mentioned file in order to suppress the checkpatch warning. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm.h| 5 - drivers/tty/serial/jsm/jsm_cls.c| 5 - drivers/tty/serial/jsm

[PATCH 3/5] drivers: serial: jsm: Enable support for Digi Classic adapters

2014-11-02 Thread Konrad Zapalowicz
This commit enables support for the Digi Classic adapters line in the jsm driver. This means changes in: - device probing code - device cleanup code - driver description (Kconfig) The init/cleanup code is based on the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz

[PATCH 1/5] drivers: serial: jsm: Add Classic board UART structure

2014-11-02 Thread Konrad Zapalowicz
This commit adds the UART structure for the Digi Classic cards. This code comes from the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz --- drivers/tty/serial/jsm/jsm.h | 59 +++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git

[PATCH 0/5] serial: jsm: Add support for the Digi Classic adapters

2014-11-02 Thread Konrad Zapalowicz
it is highly recommended that someone tests it. Konrad Zapalowicz (5): drivers: serial: jsm: Add Classic board UART structure drivers: serial: jsm: Add the Classic board implementation drivers: serial: jsm: Enable support for Digi Classic adapters staging: dgnc: Remove driver in favor

Re: [PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

2014-11-02 Thread Konrad Zapalowicz
On 11/01, Aya Mahfouz wrote: > This patch removes one debug message and replaces a dev_err > call by pr_err. Usually you would like to send this as two separate patches because replacing a debug message is way different than removing some code. It should look like: PATCH 0/2 staging:

Re: [PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

2014-11-02 Thread Konrad Zapalowicz
On 11/01, Aya Mahfouz wrote: This patch removes one debug message and replaces a dev_err call by pr_err. Usually you would like to send this as two separate patches because replacing a debug message is way different than removing some code. It should look like: PATCH 0/2 staging:

[PATCH 1/5] drivers: serial: jsm: Add Classic board UART structure

2014-11-02 Thread Konrad Zapalowicz
This commit adds the UART structure for the Digi Classic cards. This code comes from the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h | 59 +++- 1 file changed, 58 insertions(+), 1 deletion

[PATCH 0/5] serial: jsm: Add support for the Digi Classic adapters

2014-11-02 Thread Konrad Zapalowicz
it is highly recommended that someone tests it. Konrad Zapalowicz (5): drivers: serial: jsm: Add Classic board UART structure drivers: serial: jsm: Add the Classic board implementation drivers: serial: jsm: Enable support for Digi Classic adapters staging: dgnc: Remove driver in favor

[PATCH 3/5] drivers: serial: jsm: Enable support for Digi Classic adapters

2014-11-02 Thread Konrad Zapalowicz
This commit enables support for the Digi Classic adapters line in the jsm driver. This means changes in: - device probing code - device cleanup code - driver description (Kconfig) The init/cleanup code is based on the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz

[PATCH 5/5] drivers: serial: jsm: Remove FSF address from the file documentation/header

2014-11-02 Thread Konrad Zapalowicz
This commit removes the address of Free Software Foundation from each of the mentioned file in order to suppress the checkpatch warning. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h| 5 - drivers/tty/serial/jsm/jsm_cls.c| 5

[PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-02 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty

Re: [PATCH v3] staging: panel: Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: > Remove Lindent and checkpatch.pl tasks from TODO file as the first one > is obsolete and the other one is already done. > > Signed-off-by: Mariusz Gorski > --- > v3: Fixed commit summary Great. Thanks. regards, konrad > drivers/staging/panel/TODO | 2 -- >

Re: [PATCH v2] staging: panel: Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: > Remove Lindent and checkpatch.pl tasks from TODO file as the first one > is obsolete and the other one is already done. > > v2: Fixed commit summary This is something that should not be a part of the commit message. This kind of extra information shall be placed

Re: [PATCH] Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: > Remove Lindent and checkpatch.pl tasks from TODO file as the first one > is obsolete and the other one is already done. Great however your topic is ill formated. It should contain the "staging: panel:" prefix. thanks, konrad > > Signed-off-by: Mariusz Gorski

Re: [PATCH] Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: Remove Lindent and checkpatch.pl tasks from TODO file as the first one is obsolete and the other one is already done. Great however your topic is ill formated. It should contain the staging: panel: prefix. thanks, konrad Signed-off-by: Mariusz Gorski

Re: [PATCH v2] staging: panel: Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: Remove Lindent and checkpatch.pl tasks from TODO file as the first one is obsolete and the other one is already done. v2: Fixed commit summary This is something that should not be a part of the commit message. This kind of extra information shall be placed

Re: [PATCH v3] staging: panel: Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: Remove Lindent and checkpatch.pl tasks from TODO file as the first one is obsolete and the other one is already done. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com --- v3: Fixed commit summary Great. Thanks. regards, konrad

Re: [PATCH 3/7] staging: ft1000: space required after that ','

2014-10-19 Thread Konrad Zapalowicz
On 10/19, Chen Weixiang wrote: > Remove code style error from ft1000/ft1000-usb/ft1000_debug.c: > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Chen Weixiang > --- > drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 18 +- > 1 file changed, 9 insertions(+),

Re: [PATCH 3/7] staging: ft1000: space required after that ','

2014-10-19 Thread Konrad Zapalowicz
On 10/19, Chen Weixiang wrote: Remove code style error from ft1000/ft1000-usb/ft1000_debug.c: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Chen Weixiang weixiang.c...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 18 +- 1 file changed, 9

Re: [Patch v2 0/2] Move Digi Neo card support from dgnc to jsm

2014-09-09 Thread Konrad Zapalowicz
On 09/08, Bill Pemberton wrote: > On 09/08/2014 04:17 PM, Greg KH wrote: > >On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote: > >>From: Bill Pemberton > >> > >>The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo > >>cards that dgnc (staging) supports. In

Re: [Patch v2 0/2] Move Digi Neo card support from dgnc to jsm

2014-09-09 Thread Konrad Zapalowicz
On 09/08, Bill Pemberton wrote: On 09/08/2014 04:17 PM, Greg KH wrote: On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote: From: Bill Pemberton wf...@worldbroken.com The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo cards that dgnc (staging) supports.

[PATCH v2] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
This commit add check for return value of init_ring_common() in the init_render_ring(). Now, when failure is detected the error code is propagated to the caller instead of being ignored. Signed-off-by: Konrad Zapalowicz --- v2: - remove from commit message references to the Oops. drivers

Re: [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
On 06/19, Daniel Vetter wrote: > On Thu, Jun 19, 2014 at 4:35 PM, Daniel Vetter wrote: > > The actual bug we seem to have is blowing up on the ggtt_unpin in > > context_fini. Which is doubly-impossible: Gen4 doesn't have hw > > contexts, so should have dctx->obj == NULL. And ring init failures >

Re: [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
On 06/19, Daniel Vetter wrote: > On Thu, Jun 19, 2014 at 12:38 AM, Konrad Zapalowicz > wrote: > > This commit add check for return value of init_ring_common() in the > > init_render_ring(). Now, when failure is detected the error code is > > propagated to the caller layer

Re: [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
On 06/19, Daniel Vetter wrote: On Thu, Jun 19, 2014 at 12:38 AM, Konrad Zapalowicz bergo.tor...@gmail.com wrote: This commit add check for return value of init_ring_common() in the init_render_ring(). Now, when failure is detected the error code is propagated to the caller layer instead

Re: [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
On 06/19, Daniel Vetter wrote: On Thu, Jun 19, 2014 at 4:35 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: The actual bug we seem to have is blowing up on the ggtt_unpin in context_fini. Which is doubly-impossible: Gen4 doesn't have hw contexts, so should have dctx-obj == NULL. And ring

[PATCH v2] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
This commit add check for return value of init_ring_common() in the init_render_ring(). Now, when failure is detected the error code is propagated to the caller instead of being ignored. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- v2: - remove from commit message references

[PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-18 Thread Konrad Zapalowicz
-by: Konrad Zapalowicz --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 279488a..d205b0d 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm

[PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-18 Thread Konrad Zapalowicz
-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 279488a..d205b0d 100644 --- a/drivers/gpu/drm/i915

[PATCH] net: phy: fix sparse warning in fixed.c

2014-06-05 Thread Konrad Zapalowicz
-off-by: Konrad Zapalowicz --- include/linux/phy_fixed.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h index 4f2478b..ae612ac 100644 --- a/include/linux/phy_fixed.h +++ b/include/linux/phy_fixed.h @@ -17,6 +17,7 @@ extern int

[PATCH] net: phy: fix sparse warning in fixed.c

2014-06-05 Thread Konrad Zapalowicz
-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- include/linux/phy_fixed.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h index 4f2478b..ae612ac 100644 --- a/include/linux/phy_fixed.h +++ b/include/linux/phy_fixed.h @@ -17,6 +17,7

[PATCH] usb: pci_quirks: fix sparse 'symbol not declared' warning

2014-05-27 Thread Konrad Zapalowicz
This commit fixes the following sparse warning: drivers/usb/host/pci-quirks.c: - 252: warning: symbol 'usb_hcd_amd_remote_wakeup_quirk' was not declared. Should it be static? This function is exported so the fix was to add it's declaration to the header file. Signed-off-by: Konrad

[PATCH] usb: pci_quirks: fix sparse 'symbol not declared' warning

2014-05-27 Thread Konrad Zapalowicz
This commit fixes the following sparse warning: drivers/usb/host/pci-quirks.c: - 252: warning: symbol 'usb_hcd_amd_remote_wakeup_quirk' was not declared. Should it be static? This function is exported so the fix was to add it's declaration to the header file. Signed-off-by: Konrad

[PATCH 1/2] staging: rtl8821ae: fix double const in sw.c

2014-05-17 Thread Konrad Zapalowicz
This commit fixes the following sparse warning: drivers/staging/rtl8821ae/rtl8821ae/sw.c: - 449:14: warning: duplicate const Signed-off-by: Konrad Zapalowicz --- drivers/staging/rtl8821ae/rtl8821ae/sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 0/2] staging: rtl8821ae: fix sparse warnings in sw.c

2014-05-17 Thread Konrad Zapalowicz
This patch set fixes sparse warnings in sw.c file of rtl8821ae driver. In particular it deals with: 1) double const definition 2) missing 'static' for a few local symbols Konrad Zapalowicz (2): staging: rtl8821ae: fix double const in sw.c staging: rtl8821ae: fix not declared symbols

  1   2   >