[PATCH 2/4] iommu: constify of_phandle_args in xlate

2024-02-16 Thread Krzysztof Kozlowski
The xlate callbacks are supposed to translate of_phandle_args to proper provider without modifying the of_phandle_args. Make the argument pointer to const for code safety and readability. Signed-off-by: Krzysztof Kozlowski --- drivers/iommu/apple-dart.c | 3 ++- drivers/iommu

[PATCH 1/4] iommu: constify pointer to bus_type

2024-02-16 Thread Krzysztof Kozlowski
Make pointer to bus_type a pointer to const for code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/iommu/iommu-priv.h | 5 +++-- drivers/iommu/iommu.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/iommu-priv.h b/drivers/iommu/iommu-priv.h

Re: [PATCH v10 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-02-15 Thread Krzysztof Kozlowski
On 13/02/2024 21:37, Tanmay Shah wrote: > Hello, > > Thanks for reviews please find my comments below. > > On 2/13/24 1:20 PM, Rob Herring wrote: >> On Tue, 13 Feb 2024 09:54:48 -0800, Tanmay Shah wrote: >>> From: Radhey Shyam Pandey >>> >>> Introduce bindings for TCM memory address space on

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-12 Thread Krzysztof Kozlowski
On 12/02/2024 12:02, Pavel Machek wrote: > Hi! >>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >>> but I did best I could. >>> >>> Signed-off-by: Pavel Machek >>> >> >> You miss proper diffstat which makes reviewing difficult. > >> Actually entire patch is corrupted and

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-11 Thread Krzysztof Kozlowski
On 09/02/2024 20:51, Pavel Machek wrote: > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > but I did best I could. > > Signed-off-by: Pavel Machek > You miss proper diffstat which makes reviewing difficult. Actually entire patch is corrupted and impossible to apply.

Re: [PATCH v2 1/3] dt-bindings: soc: qcom: qcom,saw2: add msm8226 l2 compatible

2024-02-11 Thread Krzysztof Kozlowski
On 10/02/2024 17:28, Luca Weiss wrote: > Add the compatible for the SAW2 for L2 cache found on MSM8226. > > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/soc/qcom/qcom,saw2.yaml | 1 + Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/3] dt-bindings: power: rpmpd: Add MSM8974 power domains

2024-02-11 Thread Krzysztof Kozlowski
On 10/02/2024 17:38, Luca Weiss wrote: > Add the compatibles and indexes for the rpmpd in MSM8974, both with the > standard PM8841+PM8941 PMICs but also devices found with PMA8084. > > Signed-off-by: Luca Weiss > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

2024-01-30 Thread Krzysztof Kozlowski
On 29/01/2024 08:48, Luca Weiss wrote: > Some SC7280-based boards crash when providing the "secure_non_pixel" > context bank, so allow only one iommu in the bindings also. > > Signed-off-by: Luca Weiss > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the X1E80100 aDSP & cDSP

2024-01-30 Thread Krzysztof Kozlowski
tions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/4] dt-bindings: remoteproc: Add compatibility for TEE support

2024-01-26 Thread Krzysztof Kozlowski
On 18/01/2024 11:04, Arnaud Pouliquen wrote: > The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration > where the Cortex-M4 firmware is loaded by the Trusted execution Environment > (TEE). > For instance, this compatible is used in both the Linux and OP-TEE > device-tree: > - In

Re: [PATCH RFC v3 19/35] arm64: mte: Discover tag storage memory

2024-01-26 Thread Krzysztof Kozlowski
On 25/01/2024 17:42, Alexandru Elisei wrote: > Allow the kernel to get the base address, size, block size and associated > memory node for tag storage from the device tree blob. > Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that

Re: [PATCH 1/3] dt-bindings: clock: gcc-msm8953: add reset for MDSS subsystem

2024-01-23 Thread Krzysztof Kozlowski
On 23/01/2024 22:03, Luca Weiss wrote: > From: Vladimir Lypak > > Add a new define for the GCC_MDSS_BCR found on MSM8953. > > Signed-off-by: Vladimir Lypak > [luca: expand commit message] > Signed-off-by: Luca Weiss Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/3] dt-bindings: input: imagis: Document touch keys

2024-01-22 Thread Krzysztof Kozlowski
On 20/01/2024 22:16, Duje Mihanović wrote: > IST3032C (and possibly some other models) has touch keys. Document this. > > Signed-off-by: Duje Mihanović > --- Please provide changelog describing what changed against v1. Cover letter has something but it is not accurate. It says nothing about

[PATCH] dt-bindings: remoteproc: do not override firmware-name $ref

2024-01-15 Thread Krzysztof Kozlowski
dtschema package defines firmware-name as string-array, so individual bindings should not make it a string but instead just narrow the number of expected firmware file names. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Krzysztof Kozlowski
On 28/12/2023 10:39, Karel Balej wrote: > diff --git a/drivers/mfd/88pm88x.c b/drivers/mfd/88pm88x.c > index 69a8e39d43b3..999d0539b720 100644 > --- a/drivers/mfd/88pm88x.c > +++ b/drivers/mfd/88pm88x.c > @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { > .num_resources =

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Krzysztof Kozlowski
On 07/01/2024 10:49, Karel Balej wrote: > Mark, > > On Fri Jan 5, 2024 at 4:18 PM CET, Mark Brown wrote: >> On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote: >> >>> @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { >>> .num_resources =

Re: [PATCH 2/3] clk: qcom: hfpll: Add QCS404-specific compatible

2024-01-06 Thread Krzysztof Kozlowski
On 06/01/2024 11:19, Luca Weiss wrote: > On Dienstag, 2. Jänner 2024 11:41:26 CET Krzysztof Kozlowski wrote: >> On 31/12/2023 15:48, Luca Weiss wrote: >>> It doesn't appear that the configuration is for the HFPLL is generic, so >> >> That's ok... >> >>>

Re: [RFC PATCH 3/5] dt-bindings: regulator: add documentation entry for 88pm88x-regulator

2024-01-04 Thread Krzysztof Kozlowski
On 04/01/2024 10:25, Krzysztof Kozlowski wrote: > On 28/12/2023 10:39, Karel Balej wrote: >> From: Karel Balej >> > > A nit, subject: drop second/last, redundant "documentation entry". The > "dt-bindings" prefix is already stating that these are bindi

Re: [RFC PATCH 3/5] dt-bindings: regulator: add documentation entry for 88pm88x-regulator

2024-01-04 Thread Krzysztof Kozlowski
On 28/12/2023 10:39, Karel Balej wrote: > From: Karel Balej > A nit, subject: drop second/last, redundant "documentation entry". The "dt-bindings" prefix is already stating that these are bindings. > The Marvell 88PM88X PMICs provide regulators among other things. > Document how to use them.

Re: [PATCH 2/3] clk: qcom: hfpll: Add QCS404-specific compatible

2024-01-02 Thread Krzysztof Kozlowski
On 31/12/2023 15:48, Luca Weiss wrote: > It doesn't appear that the configuration is for the HFPLL is generic, so That's ok... > add a qcs404-specific compatible and rename the existing struct to but why this is the solution? If the qcom,hfpll compatible was deprecated, but it is not. This

Re: [PATCH 1/3] dt-bindings: clock: qcom,hfpll: Convert to YAML

2024-01-02 Thread Krzysztof Kozlowski
m,hfpll"; > +reg = <0xf9016000 0x30>; > +clocks = <_board>; > + clock-names = "xo"; > +clock-output-names = "hfpll_l2"; > +#clock-cells = <0>; > +}; > + # Example 2 - HFPLL for CPU0 Just keep one example, they are the same. And then drop the comment. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: soc: qcom: qcom,pmic-glink: document QCM6490 compatible

2023-12-21 Thread Krzysztof Kozlowski
On 20/12/2023 11:02, Luca Weiss wrote: > Document the QCM6490 compatible used to describe the pmic glink on this > platform. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree

2023-12-13 Thread Krzysztof Kozlowski
On 13/12/2023 21:33, André Apitzsch wrote: > This dts adds support for Motorola Moto G 4G released in 2013. > > Add a device tree with initial support for: > > - GPIO keys > - Hall sensor > - SDHCI > - Vibrator > > Signed-off-by: André Apitzsch > --- > arch/arm/boot/dts/qcom/Makefile

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G

2023-12-13 Thread Krzysztof Kozlowski
On 13/12/2023 21:33, André Apitzsch wrote: > Document the compatible for the MSM8926-based Motorola Moto G 4G smartphone. > > Signed-off-by: André Apitzsch > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] dt-bindings: arm: qcom: Fix up htc-memul compatible

2023-12-11 Thread Krzysztof Kozlowski
ini 2") > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] arm64: dts: qcom: sm8250-xiaomi-elish: Sort ufs node

2023-11-24 Thread Krzysztof Kozlowski
On 24/11/2023 14:57, Jianhua Lu wrote: > ufs node isn't in a right place, 'f' is front of 's', so move it to > above usb node. Please not. If we change the order to match DTSI, then this patch would be wrong. Best regards, Krzysztof

[PATCH] dt-bindings: correct white-spaces in examples

2023-11-24 Thread Krzysztof Kozlowski
Use only one and exactly one space around '=' in DTS example. Signed-off-by: Krzysztof Kozlowski --- Merging idea: Rob's DT. Should apply cleanly on Rob's for-next. --- .../devicetree/bindings/auxdisplay/hit,hd44780.yaml | 2 +- .../devicetree/bindings/clock/baikal,bt1-ccu-pll.yaml

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-30 Thread Krzysztof Kozlowski
rtions(+), 1 deletion(-)' Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-30 Thread Krzysztof Kozlowski
On 30/10/2023 09:29, Neil Armstrong wrote: > Ok, I fixed all that > >> >>> + - if: >>> + properties: >>> +compatible: >>> + enum: >>> +- qcom,sm8650-mpss-pas >>> +then: >> >> I am not sure if keeping it in the same binding as sm8550 avoids that >> much

Re: [PATCH 1/2] dt-bindings: mwifiex: document use with the SD8777 chipset

2023-10-29 Thread Krzysztof Kozlowski
On 29/10/2023 12:08, Karel Balej wrote: > Document the corresponding compatible string for the use of this driver > with the Marvell SD8777 wireless chipset. > > Signed-off-by: Karel Balej > --- Acked-by: Krzysztof Kozlowski --- This is an automated instruction, just in cas

Re: [PATCH 7/9] arm64: dts: qcom: sc7280: Add CDSP node

2023-10-28 Thread Krzysztof Kozlowski
t; though I cannot be sure there. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 5 + > arch/arm64/boot/dts/qcom/sc7280.dtsi | 138 > + > 2 files changed, 143 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Add ADSP node

2023-10-28 Thread Krzysztof Kozlowski
On 27/10/2023 16:20, Luca Weiss wrote: > Add the node for the ADSP found on the SC7280 SoC, using standard > Qualcomm firmware. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/9] dt-bindings: remoteproc: qcom: sc7180-pas: Add SC7280 compatibles

2023-10-28 Thread Krzysztof Kozlowski
e changed, 21 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/9] arm64: dts: qcom: sc7280: Remove unused second MPSS reg

2023-10-28 Thread Krzysztof Kozlowski
compatible is used. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi | 2 ++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +-- > 2 files changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/9] dt-bindings: remoteproc: qcom: sc7180-pas: Fix SC7280 MPSS PD-names

2023-10-28 Thread Krzysztof Kozlowski
om,sc7180-pas: split into > separate file") > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2023-10-27 Thread Krzysztof Kozlowski
On 26/10/2023 15:24, Stefan Hansson wrote: > This was not enabled in the matisse-wifi tree. Without this, it is not > possible to use the USB port for serial debugging via a "Carkit debug > cable". > > Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-27 Thread Krzysztof Kozlowski
-samsung-matisse-wifi.dts (85%) > copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts => > qcom-msm8226-samsung-matisse-common.dtsi} (86%) Thanks. For me this diff is much more readable - I clearly see what was removed from final DTSI file thus what I should expect in DT

Re: [PATCH v4 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2023-10-27 Thread Krzysztof Kozlowski
> > Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:35, Neil Armstrong wrote: > Document the DSP Peripheral Authentication Service on the SM8650 Platform. > > Signed-off-by: Neil Armstrong > --- > .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 > +- > 1 file changed, 40 insertions(+), 1 deletion(-)

Re: [PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-25 Thread Krzysztof Kozlowski
On 25/10/2023 10:52, Stefan Hansson wrote: > > > On 2023-10-25 10:48, Krzysztof Kozlowski wrote: >> On 25/10/2023 10:37, Stefan Hansson wrote: >>> This series adds a common samsung-matisse dtsi and reworks >>> samsung-matisse-wifi to use it, and introduces

Re: [PATCH v3 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-25 Thread Krzysztof Kozlowski
On 25/10/2023 10:37, Stefan Hansson wrote: > According to the dts from the kernel source code released by Samsung, > matissewifi and matisselte only have minor differences in hardware, so > use a shared dtsi to reduce duplicated code. Additionally, this should > make adding support for matisse3g

Re: [PATCH v3 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-25 Thread Krzysztof Kozlowski
On 25/10/2023 10:37, Stefan Hansson wrote: > This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) > which is a tablet by Samsung based on the MSM8926 SoC. > > Signed-off-by: Stefan Hansson > --- This is a friendly reminder during the review process. It looks like you received a

Re: [PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-25 Thread Krzysztof Kozlowski
On 25/10/2023 10:37, Stefan Hansson wrote: > This series adds a common samsung-matisse dtsi and reworks > samsung-matisse-wifi to use it, and introduces samsung-matisselte. I > choose matisselte over matisse-lte as this is how most other devices > (klte, s3ve3g) do it and it is the codename that

Re: [PATCH v2 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2023-10-25 Thread Krzysztof Kozlowski
On 24/10/2023 22:33, Stefan Hansson wrote: > This was not enabled in the matisse-wifi tree. Your commit msg should explain why this should be enabled. > > Signed-off-by: Stefan Hansson > --- > .../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4 > 1 file changed, 4

Re: [PATCH v2 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-25 Thread Krzysztof Kozlowski
On 24/10/2023 22:33, Stefan Hansson wrote: > This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) > which is a tablet by Samsung based on the MSM8926 SoC. > > Signed-off-by: Stefan Hansson > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + Revi

Re: [PATCH v2 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-25 Thread Krzysztof Kozlowski
On 24/10/2023 22:33, Stefan Hansson wrote: > According to the dts from the kernel source code released by Samsung, > matissewifi and matisselte only have minor differences in hardware, so > use a shared dtsi to reduce duplicated code. Additionally, this should > make adding support for matisse3g

Re: [PATCH] dt-bindings: arm: cpus: Add Qualcomm Kryo 465

2023-10-22 Thread Krzysztof Kozlowski
On 21/10/2023 09:16, David Wronek wrote: > Add a compatible for the Qualcomm Kryo 465 found in SM7125. > > Signed-off-by: David Wronek > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 1 Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: usb: add NXP PTN36502 Type-C redriver bindings

2023-10-15 Thread Krzysztof Kozlowski
; Signed-off-by: Luca Weiss Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings

2023-10-13 Thread Krzysztof Kozlowski
On 13/10/2023 10:54, Luca Weiss wrote: >> We expect the bindings to be dual licensed. What was the license of the >> original work? > > Yes, just GPL-2.0-only: >

Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings

2023-10-13 Thread Krzysztof Kozlowski
On 13/10/2023 10:09, Luca Weiss wrote: > Add the defines for the ADC channels found on the PM7325. The list is > taken from downstream msm-5.4 and adjusted for mainline. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE`

Re: [PATCH 1/3] dt-bindings: watchdog: qcom-wdt: Add MSM8226 and MSM8974 compatibles

2023-10-11 Thread Krzysztof Kozlowski
On 11/10/2023 18:33, Luca Weiss wrote: > From: Matti Lehtimäki > > Add compatibles for the MSM8226 and MSM8974 platforms to the Qualcomm > watchdog binding. > > Signed-off-by: Matti Lehtimäki Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: vendor-prefixes: document HTC Corporation

2023-10-11 Thread Krzysztof Kozlowski
On 11/10/2023 19:02, Luca Weiss wrote: > Add the vendor prefix for HTC (https://www.htc.com/). > > Signed-off-by: Luca Weiss > --- So it is the first HTC device in upstream? That's a surprise... Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: arm: qcom: Add HTC One Mini 2

2023-10-11 Thread Krzysztof Kozlowski
On 11/10/2023 19:02, Luca Weiss wrote: > Document the compatible for the MSM8926-based HTC One Mini 2 smartphone. > > Signed-off-by: Luca Weiss Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/7] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 9S

2023-10-09 Thread Krzysztof Kozlowski
On 07/10/2023 15:58, David Wronek wrote: > Document the Xiaomi Redmi Note 9S (curtana) smartphone, which is based > on the Qualcomm SM7125 SoC. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/7] dt-bindings: phy: Add QMP UFS PHY compatible for SC7180

2023-10-09 Thread Krzysztof Kozlowski
On 07/10/2023 15:58, David Wronek wrote: > Document the QMP UFS PHY compatible for SC7180 > > Signed-off-by: David Wronek > --- > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git >

Re: [PATCH 1/7] dt-bindings: ufs: qcom: Add SC7180 compatible string

2023-10-09 Thread Krzysztof Kozlowski
On 07/10/2023 15:58, David Wronek wrote: > Document the compatible for the UFS found on SC7180. > > Signed-off-by: David Wronek > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios

2023-10-02 Thread Krzysztof Kozlowski
On 02/10/2023 09:00, Luca Weiss wrote: > Use gpio@ instead of pinctrl@ as that's the name expected by the > qcom,spmi-pmic.yaml schema. Update it to fix dt validation. > > Signed-off-by: Luca Weiss Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples

2023-10-02 Thread Krzysztof Kozlowski
files to > use the plural _gpios label instead of the singular _gpio as label but > this example wasn't updated. But since we should just drop the label > alltogether, do that. > > Signed-off-by: Luca Weiss Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: i2c: qcom-cci: Document SC7280 compatible

2023-10-02 Thread Krzysztof Kozlowski
On 02/10/2023 08:55, Luca Weiss wrote: > Document the compatible for the CCI block found on SC7280 SoC. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Luca Weiss > --- Thanks, looks good now. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: Update gpio example

2023-09-30 Thread Krzysztof Kozlowski
On 29/09/2023 10:17, Luca Weiss wrote: > As per commit ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node > label for PMIC gpios") all dts files now use the plural _gpios instead > of the singular _gpio as label. Update the schema example also to match. > > Signed-off-by: Luca Weiss > --- >

Re: [PATCH 1/3] dt-bindings: i2c: qcom-cci: Document SC7280 compatible

2023-09-30 Thread Krzysztof Kozlowski
On 29/09/2023 10:01, Luca Weiss wrote: > Document the compatible for the CCI block found on SC7280 SoC. > > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2 7/7] arm64: dts: qcom: qcm6490: Add device-tree for Fairphone 5

2023-09-19 Thread Krzysztof Kozlowski
Power & volume buttons > * RTC > * SD card > * USB > * Various plumbing like regulators, i2c, spi, etc Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 6/7] dt-bindings: arm: qcom: Add QCM6490 Fairphone 5

2023-09-19 Thread Krzysztof Kozlowski
On 19/09/2023 14:46, Luca Weiss wrote: > Fairphone 5 is a smartphone based on the QCM6490 SoC. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 3/7] arm64: dts: qcom: pm7250b: make SID configurable

2023-09-19 Thread Krzysztof Kozlowski
; --- Matches our discussion offline today. Looks good, thank you! Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: msm8939-huawei-kiwi: Add initial device tree

2023-09-16 Thread Krzysztof Kozlowski
On 16/09/2023 15:41, Lukas Walter wrote: > This dts adds support for Huawei Honor 5X / GR5 (2016) smartphone > released in 2015. > > Add device tree with initial support for: > > - GPIO keys > - Hall sensor > - SDHCI (internal and external storage) > - WCNSS (BT/WIFI) > - Sensors (accelerometer,

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Huawei Honor 5X / GR5 (2016)

2023-09-16 Thread Krzysztof Kozlowski
On 16/09/2023 15:41, Lukas Walter wrote: > Add a compatible for Huawei Honor 5X / GR5 (2016). > > Signed-off-by: Lukas Walter > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 06/14] arm64: dts: qcom: sdm630: Drop RPM bus clocks

2023-09-14 Thread Krzysztof Kozlowski
On 13/09/2023 14:08, Konrad Dybcio wrote: > On 13.09.2023 09:13, Krzysztof Kozlowski wrote: >> On 12/09/2023 15:31, Konrad Dybcio wrote: >>> These clocks are now handled from within the icc framework and are >>> no longer registered from within the CCF. Remove them. &g

Re: [PATCH v6 1/4] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 14:36, Rob Herring wrote: > > On Wed, 13 Sep 2023 06:16:41 -0500, Hari Nagalla wrote: >> K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. >> The remote processor's life cycle management and IPC mechanisms are >> similar across the R5F and M4F cores from remote

Re: [PATCH v6 1/4] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 15:59, Hari Nagalla wrote: > On 9/13/23 06:32, Krzysztof Kozlowski wrote: >>> - Removed unrelated items from examples >>> >>> Changes since v4: >>> - Rebased to the latest kernel-next tree >>> - Added optional sram memory reg

Re: [PATCH v6 3/4] remoteproc: k3: Split out functions common with M4 driver

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 13:16, Hari Nagalla wrote: > From: Martyn Welch > > In the next commit we will be adding the M4F driver which shares a lot of > commonality with the DSP driver. Split this shared functionality out so > that it can be used by both drivers. > > Signed-off-by: Martyn Welch >

Re: [PATCH v6 4/4] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 13:16, Hari Nagalla wrote: > From: Martyn Welch > > The AM62x and AM64x SoCs of the TI K3 family has a Cortex M4F core in > the MCU domain. This core is typically used for safety applications in a > stand alone mode. However, some application (non safety related) may > want to use

Re: [PATCH v6 4/4] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 13:16, Hari Nagalla wrote: > From: Martyn Welch > > The AM62x and AM64x SoCs of the TI K3 family has a Cortex M4F core in > the MCU domain. This core is typically used for safety applications in a > stand alone mode. However, some application (non safety related) may > want to use

Re: [PATCH v6 2/4] remoteproc: k3: Split out data structures common with M4 driver

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 13:16, Hari Nagalla wrote: > From: Martyn Welch > > We will be adding the M4F driver which shares a lot of commonality > with the DSP driver. Common data structures are introduced here. > > Signed-off-by: Martyn Welch > Signed-off-by: Hari Nagalla > --- > Changes in v6: > -

Re: [PATCH v6 1/4] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 13:16, Hari Nagalla wrote: > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain. > The remote processor's life cycle management and IPC mechanisms are > similar across the R5F and M4F cores from remote processor driver > point of view. However, there are subtle

Re: [PATCH v2 01/14] arm64: dts: qcom: msm8916: Drop RPM bus clocks

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 12:48, Konrad Dybcio wrote: > On 13.09.2023 10:53, Krzysztof Kozlowski wrote: >> On 13/09/2023 10:47, Konrad Dybcio wrote: >>> On 13.09.2023 09:07, Krzysztof Kozlowski wrote: >>>> On 12/09/2023 15:31, Konrad Dybcio wrote: >>>>> The

Re: [PATCH v2 01/14] arm64: dts: qcom: msm8916: Drop RPM bus clocks

2023-09-13 Thread Krzysztof Kozlowski
On 13/09/2023 10:47, Konrad Dybcio wrote: > On 13.09.2023 09:07, Krzysztof Kozlowski wrote: >> On 12/09/2023 15:31, Konrad Dybcio wrote: >>> These clocks are now handled from within the icc framework and are >> >> That's a driver behavior, not hardware. > I bel

Re: [PATCH v2 14/14] arm64: dts: qcom: sdm630: Fix USB2 clock-names order

2023-09-13 Thread Krzysztof Kozlowski
On 12/09/2023 15:31, Konrad Dybcio wrote: > The last 2 clock-names entries for the USB2 controller were swapped, > resulting in schema warnings: > > ['cfg_noc', 'core', 'mock_utmi', 'sleep'] is too short > 'iface' was expected > 'sleep' was expected > 'mock_utmi' was

Re: [PATCH v2 14/14] arm64: dts: qcom: sdm630: Fix USB2 clock-names order

2023-09-13 Thread Krzysztof Kozlowski
On 12/09/2023 15:31, Konrad Dybcio wrote: > The last 2 clock-names entries for the USB2 controller were swapped, > resulting in schema warnings: > > ['cfg_noc', 'core', 'mock_utmi', 'sleep'] is too short > 'iface' was expected > 'sleep' was expected > 'mock_utmi' was

Re: [PATCH v2 08/14] dt-bindings: remoteproc: qcom,adsp: Remove AGGRE2 clock

2023-09-13 Thread Krzysztof Kozlowski
On 12/09/2023 15:31, Konrad Dybcio wrote: > The AGGRE2 clock is a clock for the entire AGGRE2 bus, managed from > within the interconnect driver. Attaching it to SLPI was a total hack. > Get rid of it. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlows

Re: [PATCH v2 07/14] arm64: dts: qcom: msm8939: Drop RPM bus clocks

2023-09-13 Thread Krzysztof Kozlowski
On 12/09/2023 15:31, Konrad Dybcio wrote: > These clocks are now handled from within the icc framework and are > no longer registered from within the CCF. Remove them. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 06/14] arm64: dts: qcom: sdm630: Drop RPM bus clocks

2023-09-13 Thread Krzysztof Kozlowski
On 12/09/2023 15:31, Konrad Dybcio wrote: > These clocks are now handled from within the icc framework and are > no longer registered from within the CCF. Remove them. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 49 > +++- > 1

Re: [PATCH v2 01/14] arm64: dts: qcom: msm8916: Drop RPM bus clocks

2023-09-13 Thread Krzysztof Kozlowski
On 12/09/2023 15:31, Konrad Dybcio wrote: > These clocks are now handled from within the icc framework and are That's a driver behavior, not hardware. > no longer registered from within the CCF. Remove them. > Changes in Linux clock drivers should not cause some clocks to disappear from DTS...

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Krzysztof Kozlowski
On 12/09/2023 10:49, Iuliana Prodan wrote: >>> Should I test this on other tree(s)? >> You test the patch on the tree you send it. What is the point to test it >> on some old code, cherry-pick with bugs and then send? >> >> If you have cross-tree dependencies between subsystem, isn't linux-next >>

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Krzysztof Kozlowski
On 12/09/2023 10:13, Iuliana Prodan wrote: > On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: >> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: >>> From: Iuliana Prodan >>> >>> Add the reserve-memory nodes used by DSP when the rpmsg >>> feature is

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Krzysztof Kozlowski
On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > > Add the reserve-memory nodes used by DSP when the rpmsg > feature is enabled. > These can be later used in a dsp node, like: > dsp: dsp@3b6e8000 { > compatible = "fsl,imx8mp-dsp"; > reg = <0x3b6e8000

Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable

2023-09-11 Thread Krzysztof Kozlowski
On 11/09/2023 10:34, Luca Weiss wrote: > On Tue Sep 5, 2023 at 10:30 AM CEST, Luca Weiss wrote: >> On Thu Aug 31, 2023 at 2:27 PM CEST, Dmitry Baryshkov wrote: >>> On Thu, 31 Aug 2023 at 14:54, Krzysztof Kozlowski >>> wrote: >>>> >>>> On 31/08/2

Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable

2023-09-11 Thread Krzysztof Kozlowski
On 11/09/2023 11:59, Luca Weiss wrote: > On Mon Sep 11, 2023 at 11:44 AM CEST, Krzysztof Kozlowski wrote: >> On 11/09/2023 10:34, Luca Weiss wrote: >>> On Tue Sep 5, 2023 at 10:30 AM CEST, Luca Weiss wrote: >>>> On Thu Aug 31, 2023 at 2:27 PM CEST, Dmitry Baryshkov wr

[PATCH 9/9] regulator: s2mps11: Drop initialization via platform data

2021-04-20 Thread Krzysztof Kozlowski
None of the platforms with S2MPS11 use board files, so any initialization via platform data can be safely removed. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/s2mps11.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/regulator

[PATCH 7/9] rtc: s5m: Remove reference to parent's device pdata

2021-04-20 Thread Krzysztof Kozlowski
The S5M RTC driver does not use parent's device (sec-core PMIC driver) platform data so there is no need to check for it. Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index

[PATCH 8/9] regulator: s2mpa01: Drop initialization via platform data

2021-04-20 Thread Krzysztof Kozlowski
None of the platforms with S2MPA01 use board files, so any initialization via platform data can be safely removed. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/s2mpa01.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/regulator/s2mpa01.c b/drivers/regulator/s2mpa01.c

[PATCH 5/9] mfd: sec: Enable wakeup from suspend via devicetree property

2021-04-20 Thread Krzysztof Kozlowski
for waking up and sets device wakeup unconditionally. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c | 8 include/linux/mfd/samsung/core.h | 3 --- 2 files changed, 11 deletions(-) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index a9d4fbc51997

[PATCH 6/9] mfd: sec: Remove unused platform data members

2021-04-20 Thread Krzysztof Kozlowski
to reduce memory footprint and source code size. Signed-off-by: Krzysztof Kozlowski --- include/linux/mfd/samsung/core.h | 25 - 1 file changed, 25 deletions(-) diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/core.h index b0d049a56d16

[PATCH 3/9] mfd: sec: Remove unused device_type in platform data

2021-04-20 Thread Krzysztof Kozlowski
The 'device_type' field of platform data structure is not used and can be safely dropped. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c | 5 + include/linux/mfd/samsung/core.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/mfd/sec

[PATCH 4/9] mfd: sec: Remove unused irq_base in platform data

2021-04-20 Thread Krzysztof Kozlowski
The 'irq_base' field of platform data structure is not assigned, therefore its default value of 0 has no impact and can be safely dropped. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c | 1 - drivers/mfd/sec-irq.c| 4 +--- include/linux/mfd/samsung/core.h

[PATCH 2/9] mfd: sec: Remove unused cfg_pmic_irq in platform data

2021-04-20 Thread Krzysztof Kozlowski
The 'cfg_pmic_irq' field of platform data structure is not used and can be safely dropped. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c | 3 --- include/linux/mfd/samsung/core.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd

[PATCH 0/9] mfd/rtc/regulator: Drop board file support for Samsung PMIC

2021-04-20 Thread Krzysztof Kozlowski
patches can be picked up independently via regulator and rtc trees. There are no board files currently, so the code in these drivers is basically dead code and feature-bisection is preserved. Best regards, Krzysztof Krzysztof Kozlowski (9): mfd: sec: Drop support for board files and require

[PATCH 1/9] mfd: sec: Drop support for board files and require devicetree

2021-04-20 Thread Krzysztof Kozlowski
The Samsung PMIC drivers since long time are used only on devicetree platforms (Samsung Exynos) and there are no users with board files. Drop the support for board files entirely and depend on OF for matching. Suggested-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski --- drivers/mfd

[PATCH 10/11] ARM: dts: exynos: enable PMIC wakeup from suspend on Odroid XU3/XU4 family

2021-04-20 Thread Krzysztof Kozlowski
The RTC on S2MPS11 PMIC on Odroid XU3/XU4 family of boards can wakeup the system from suspend to RAM. Add a generic property for this. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts

[PATCH 11/11] arm64: dts: exynos: enable PMIC wakeup from suspend on TM2

2021-04-20 Thread Krzysztof Kozlowski
The RTC on S2MPS13 PMIC can wakeup the system from suspend to RAM. Add a generic property for this. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2

[PATCH 09/11] ARM: dts: exynos: enable PMIC wakeup from suspend on SMDK5420

2021-04-20 Thread Krzysztof Kozlowski
The RTC on S2MPS11 PMIC can wakeup the system from suspend to RAM. Add a generic property for this. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-smdk5420.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts

<    1   2   3   4   5   6   7   8   9   10   >