Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support

> + /* before widget power up */ > + if (SND_SOC_DAPM_EVENT_ON(event)) { > + /* Turn on the chip */ > + tpa6130a2_power(data, true); > + /* Sync the registers */ > + ret = regcache_sync(data->regmap); > + if (ret < 0) { > +

Re: [PATCH 1/1] staging: iio: initialize data pointer before using it

On 06/18/2016 11:12 PM, Nicolas Iooss wrote: > ad7606_spi_read_block() reads SPI big-endian data into a buffer which is > then converted to CPU byte-order with a second variable. This variable, > data, has been left unitialized after commit 87787e5ef727 ("Staging: > iio: Fix sparse endian

Re: [PATCH 1/1] staging: iio: initialize data pointer before using it

On 06/18/2016 11:12 PM, Nicolas Iooss wrote: > ad7606_spi_read_block() reads SPI big-endian data into a buffer which is > then converted to CPU byte-order with a second variable. This variable, > data, has been left unitialized after commit 87787e5ef727 ("Staging: > iio: Fix sparse endian

Re: [PATCH 4/4] ASoC: tpa6130a2: Add DAPM support

On 06/19/2016 01:21 AM, Sebastian Reichel wrote: > Hi, > > On Sat, Jun 18, 2016 at 12:26:31AM -0300, Helen Koike wrote: >> Add DAPM support and updated rx51 accordingly. >> As a consequence: >> - the exported function tpa6130a2_stereo_enable is not needed anymore >> - the mutex is dealt in the

Re: [PATCH 4/4] ASoC: tpa6130a2: Add DAPM support

On 06/19/2016 01:21 AM, Sebastian Reichel wrote: > Hi, > > On Sat, Jun 18, 2016 at 12:26:31AM -0300, Helen Koike wrote: >> Add DAPM support and updated rx51 accordingly. >> As a consequence: >> - the exported function tpa6130a2_stereo_enable is not needed anymore >> - the mutex is dealt in the

Re: [RFC] regmap: Add regmap_pipe_read API

On 06/17/2016 09:04 AM, Crestez Dan Leonard wrote: > On 06/16/2016 06:43 PM, Geert Uytterhoeven wrote: >> Hi Leonard, >> >> On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard >> wrote: >>> The regmap API usually assumes that bulk read operations will read a >>> range

Re: [RFC] regmap: Add regmap_pipe_read API

On 06/17/2016 09:04 AM, Crestez Dan Leonard wrote: > On 06/16/2016 06:43 PM, Geert Uytterhoeven wrote: >> Hi Leonard, >> >> On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard >> wrote: >>> The regmap API usually assumes that bulk read operations will read a >>> range of registers but some

Re: [PATCH 1/1] iio: fix config watermark initial value

On 06/16/2016 06:16 PM, Jonathan Cameron wrote: > > > On 16 June 2016 12:56:11 BST, Daniel Baluta <daniel.bal...@gmail.com> wrote: >> On Mon, Mar 28, 2016 at 1:02 PM, Jonathan Cameron <ji...@kernel.org> >> wrote: >>> On 24/03/16 09:23, Lars-Peter Clausen

Re: [PATCH 1/1] iio: fix config watermark initial value

On 06/16/2016 06:16 PM, Jonathan Cameron wrote: > > > On 16 June 2016 12:56:11 BST, Daniel Baluta wrote: >> On Mon, Mar 28, 2016 at 1:02 PM, Jonathan Cameron >> wrote: >>> On 24/03/16 09:23, Lars-Peter Clausen wrote: >>>> On 03/24/2016 10:09 AM,

Re: [PATCH] spi: add spi_sync_single_transfer wrapper for single spi_transfer

On 06/16/2016 01:40 AM, Andi Shyti wrote: > The spi_sync_single_transfer function calls spi_sync_transfer > with a single spi_transfer element, instead of an array. So, what's the advantage of using this as opposed to calling spi_sync_transfer with a 1 for the number of transfers?

Re: [PATCH] spi: add spi_sync_single_transfer wrapper for single spi_transfer

On 06/16/2016 01:40 AM, Andi Shyti wrote: > The spi_sync_single_transfer function calls spi_sync_transfer > with a single spi_transfer element, instead of an array. So, what's the advantage of using this as opposed to calling spi_sync_transfer with a 1 for the number of transfers?

Re: [PATCH v2] staging: iio: ad5933: fix order of cycle conditions

sed on the Table 13 at the bottom of Page 25 of the Data Sheet: >> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf >> >> Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> >> Reviewed-by: Lars-Peter Clausen <l...@metafoo.de>

Re: [PATCH v2] staging: iio: ad5933: fix order of cycle conditions

sed on the Table 13 at the bottom of Page 25 of the Data Sheet: >> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf >> >> Signed-off-by: Luis de Bethencourt >> Reviewed-by: Lars-Peter Clausen > While Lars did review, it I'm not seeing an

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

On 04/25/2016 09:41 AM, Mika Westerberg wrote: > On Mon, Apr 25, 2016 at 09:39:41AM +0200, Wolfram Sang wrote: >> On Mon, Apr 25, 2016 at 10:25:53AM +0300, Mika Westerberg wrote: >>> On Sun, Apr 24, 2016 at 10:14:37PM +0200, Wolfram Sang wrote: > The above should work with both DT and

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

On 04/25/2016 09:41 AM, Mika Westerberg wrote: > On Mon, Apr 25, 2016 at 09:39:41AM +0200, Wolfram Sang wrote: >> On Mon, Apr 25, 2016 at 10:25:53AM +0300, Mika Westerberg wrote: >>> On Sun, Apr 24, 2016 at 10:14:37PM +0200, Wolfram Sang wrote: > The above should work with both DT and

Re: [PATCH] Dyna-Image AL3320A update, add AL3010 driver

On 06/03/2016 06:02 AM, Rocky Hsiao wrote: > 1. Change al3320a.c to match light sensor test flow. > 2. Add al3010.c to add new device AL3010. >original file copy from al3320a.c Hi, Thanks for the patch. In addition to what Daniel said, for upstream patch submissions it is important to have

Re: [PATCH] Dyna-Image AL3320A update, add AL3010 driver

On 06/03/2016 06:02 AM, Rocky Hsiao wrote: > 1. Change al3320a.c to match light sensor test flow. > 2. Add al3010.c to add new device AL3010. >original file copy from al3320a.c Hi, Thanks for the patch. In addition to what Daniel said, for upstream patch submissions it is important to have

Re: [PATCH v2 3/7] iio: adc: ad7793: claim direct mode when writing frequency

unction to clarify look-up followed by lock sequence. > > Signed-off-by: Alison Schofield <amsfiel...@gmail.com> > Cc: Daniel Baluta <daniel.bal...@gmail.com> Looks good, thanks. Acked-by: Lars-Peter Clausen <l...@metafoo.de>

Re: [PATCH v2 3/7] iio: adc: ad7793: claim direct mode when writing frequency

unction to clarify look-up followed by lock sequence. > > Signed-off-by: Alison Schofield > Cc: Daniel Baluta Looks good, thanks. Acked-by: Lars-Peter Clausen

Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing frequency

unction to clarify look-up followed by lock sequence. > > Signed-off-by: Alison Schofield <amsfiel...@gmail.com> > Cc: Daniel Baluta <daniel.bal...@gmail.com> Looks good, thanks. Acked-by: Lars-Peter Clausen <l...@metafoo.de>

Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing frequency

unction to clarify look-up followed by lock sequence. > > Signed-off-by: Alison Schofield > Cc: Daniel Baluta Looks good, thanks. Acked-by: Lars-Peter Clausen

Re: [PATCH] staging: iio: ad5933: fix handling of settling time cycles

On 06/01/2016 05:55 PM, Luis de Bethencourt wrote: > Correctly handle the settling time cycles value. The else branch was an > impossible condition (> 1022 in the else branch of > 511) and the handling > of the values was dividing by 2 and 4, with a left shift, instead of > multiplying. > > Based

Re: [PATCH] staging: iio: ad5933: fix handling of settling time cycles

On 06/01/2016 05:55 PM, Luis de Bethencourt wrote: > Correctly handle the settling time cycles value. The else branch was an > impossible condition (> 1022 in the else branch of > 511) and the handling > of the values was dividing by 2 and 4, with a left shift, instead of > multiplying. > > Based

Re: [RFC 4/7] iio: Add current_trigger_id alternative

On 05/23/2016 08:39 PM, Crestez Dan Leonard wrote: > This allows controlling the current trigger by numeric ID rather than > name. This is most certainly the far better interface, but so far we've tried to have only one way to do a certain task with the IIO userspace ABI and try to live with our

Re: [RFC 4/7] iio: Add current_trigger_id alternative

On 05/23/2016 08:39 PM, Crestez Dan Leonard wrote: > This allows controlling the current trigger by numeric ID rather than > name. This is most certainly the far better interface, but so far we've tried to have only one way to do a certain task with the IIO userspace ABI and try to live with our

Re: [RFC 6/7] iio: Refuse to register triggers with duplicate names

On 05/30/2016 02:49 PM, Crestez Dan Leonard wrote: > On 05/29/2016 10:48 PM, Jonathan Cameron wrote: >> On 23/05/16 19:40, Crestez Dan Leonard wrote: >>> The trigger name is documented as unique but drivers are currently >>> allowed to register triggers with duplicate names. This should be >>>

Re: [RFC 6/7] iio: Refuse to register triggers with duplicate names

On 05/30/2016 02:49 PM, Crestez Dan Leonard wrote: > On 05/29/2016 10:48 PM, Jonathan Cameron wrote: >> On 23/05/16 19:40, Crestez Dan Leonard wrote: >>> The trigger name is documented as unique but drivers are currently >>> allowed to register triggers with duplicate names. This should be >>>

Re: [PATCH 3/7] iio: adc: ad7793: claim direct mode when writing frequency

l.com> >> >> Acked-by: Daniel Baluta <daniel.bal...@gmail.com> > Again, this one is not quite so trivial so I'll wait for Lars to take a look > even though I'm happy with it. Same as patch too. Looks good otherwise. Acked-by: Lars-Peter Clausen <l...@metafoo.de>

Re: [PATCH 3/7] iio: adc: ad7793: claim direct mode when writing frequency

trivial so I'll wait for Lars to take a look > even though I'm happy with it. Same as patch too. Looks good otherwise. Acked-by: Lars-Peter Clausen

Re: [PATCH 2/7] iio: adc: ad7791: claim direct mode when writing frequency

On 05/29/2016 07:06 PM, Jonathan Cameron wrote: > On 25/05/16 11:34, Daniel Baluta wrote: >> On Tue, May 24, 2016 at 10:16 PM, Alison Schofield >> wrote: >>> Driver was checking for direct mode and trying to lock it, but >>> left a gap where mode could change before the

Re: [PATCH 2/7] iio: adc: ad7791: claim direct mode when writing frequency

On 05/29/2016 07:06 PM, Jonathan Cameron wrote: > On 25/05/16 11:34, Daniel Baluta wrote: >> On Tue, May 24, 2016 at 10:16 PM, Alison Schofield >> wrote: >>> Driver was checking for direct mode and trying to lock it, but >>> left a gap where mode could change before the desired operation. >>>

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

On 05/16/2016 06:05 PM, Michal Nazarewicz wrote: > So I’ve been looking at AIO handling in f_fs and either I’m stupid or > the code is broken. The code was broken. Fixed in commit 332a5b446b791 ("usb: gadget: f_fs: Fix EFAULT generation for async read operations:).

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

On 05/16/2016 06:05 PM, Michal Nazarewicz wrote: > So I’ve been looking at AIO handling in f_fs and either I’m stupid or > the code is broken. The code was broken. Fixed in commit 332a5b446b791 ("usb: gadget: f_fs: Fix EFAULT generation for async read operations:).

Re: [PATCH v8 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation

On 05/12/2016 02:29 PM, Kedareswara rao Appana wrote: [...] > +- xlnx,include-sg: Indicates the controller to operate in simple or > + scatter gather dma mode This is also a software runtime configuration parameter.

Re: [PATCH v8 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation

On 05/12/2016 02:29 PM, Kedareswara rao Appana wrote: [...] > +- xlnx,include-sg: Indicates the controller to operate in simple or > + scatter gather dma mode This is also a software runtime configuration parameter.

Re: [PATCH] media: fix use-after-free in cdev_put() when app exits after driver unbind

On 05/03/2016 05:06 PM, Shuah Khan wrote: > On 05/02/2016 04:16 AM, Lars-Peter Clausen wrote: >> On 04/30/2016 12:37 AM, Shuah Khan wrote: >> [...] >>> diff --git a/include/media/media-devnode.h b/include/media/media-devnode.h >>> index 5bb3b0e..ce9b051 100

Re: [PATCH] media: fix use-after-free in cdev_put() when app exits after driver unbind

On 05/03/2016 05:06 PM, Shuah Khan wrote: > On 05/02/2016 04:16 AM, Lars-Peter Clausen wrote: >> On 04/30/2016 12:37 AM, Shuah Khan wrote: >> [...] >>> diff --git a/include/media/media-devnode.h b/include/media/media-devnode.h >>> index 5bb3b0e..ce9b051 100

Re: [PATCH] media: fix use-after-free in cdev_put() when app exits after driver unbind

On 04/30/2016 12:37 AM, Shuah Khan wrote: [...] > diff --git a/include/media/media-devnode.h b/include/media/media-devnode.h > index 5bb3b0e..ce9b051 100644 > --- a/include/media/media-devnode.h > +++ b/include/media/media-devnode.h > @@ -72,6 +72,7 @@ struct media_file_operations { > * @fops:

Re: [PATCH] media: fix use-after-free in cdev_put() when app exits after driver unbind

On 04/30/2016 12:37 AM, Shuah Khan wrote: [...] > diff --git a/include/media/media-devnode.h b/include/media/media-devnode.h > index 5bb3b0e..ce9b051 100644 > --- a/include/media/media-devnode.h > +++ b/include/media/media-devnode.h > @@ -72,6 +72,7 @@ struct media_file_operations { > * @fops:

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/28/2016 03:24 PM, One Thousand Gnomes wrote: >> It's clearly wrong. But the problem is there might be an application that >> depends on the wrong behavior, the driver has been around for 2.5 years. So >> it's difficult to fix. We might just go ahead in this case and take the >> chance that

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/28/2016 03:24 PM, One Thousand Gnomes wrote: >> It's clearly wrong. But the problem is there might be an application that >> depends on the wrong behavior, the driver has been around for 2.5 years. So >> it's difficult to fix. We might just go ahead in this case and take the >> chance that

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/28/2016 03:30 PM, Peter Meerwald-Stadler wrote: > >>> It's clearly wrong. But the problem is there might be an application that >>> depends on the wrong behavior, the driver has been around for 2.5 years. So >>> it's difficult to fix. We might just go ahead in this case and take the >>>

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/28/2016 03:30 PM, Peter Meerwald-Stadler wrote: > >>> It's clearly wrong. But the problem is there might be an application that >>> depends on the wrong behavior, the driver has been around for 2.5 years. So >>> it's difficult to fix. We might just go ahead in this case and take the >>>

Re: [PATCH v7 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation

On 04/28/2016 11:00 AM, Appana Durga Kedareswara Rao wrote: > Hi Lars, > > Thanks for the review... > >> -Original Message----- >> From: Lars-Peter Clausen [mailto:l...@metafoo.de] >> Sent: Wednesday, April 27, 2016 6:10 PM >> To: Appana Durga

Re: [PATCH v7 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation

On 04/28/2016 11:00 AM, Appana Durga Kedareswara Rao wrote: > Hi Lars, > > Thanks for the review... > >> -Original Message----- >> From: Lars-Peter Clausen [mailto:l...@metafoo.de] >> Sent: Wednesday, April 27, 2016 6:10 PM >> To: Appana Durga Ked

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/27/2016 06:58 PM, Crestez Dan Leonard wrote: > On 04/26/2016 06:21 PM, Daniel Baluta wrote: >> On Tue, Apr 26, 2016 at 4:14 PM, Yong Li wrote: >>> I am thinking if there is any application is using this incorrect >>> name, the application should be fix too >> >> The rule

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/27/2016 06:58 PM, Crestez Dan Leonard wrote: > On 04/26/2016 06:21 PM, Daniel Baluta wrote: >> On Tue, Apr 26, 2016 at 4:14 PM, Yong Li wrote: >>> I am thinking if there is any application is using this incorrect >>> name, the application should be fix too >> >> The rule is: "Don't break

Re: [PATCH] media: fix media_ioctl use-after-free when driver unbinds

On 04/27/2016 11:56 PM, Shuah Khan wrote: >>> dev_dbg(mdev->dev, "Media device unregistered\n"); >>> } >>> diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c >>> index 29409f4..9af9ba1 100644 >>> --- a/drivers/media/media-devnode.c >>> +++

Re: [PATCH] media: fix media_ioctl use-after-free when driver unbinds

On 04/27/2016 11:56 PM, Shuah Khan wrote: >>> dev_dbg(mdev->dev, "Media device unregistered\n"); >>> } >>> diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c >>> index 29409f4..9af9ba1 100644 >>> --- a/drivers/media/media-devnode.c >>> +++

Re: [PATCH] media: fix media_ioctl use-after-free when driver unbinds

Looks mostly good, a few comments. On 04/27/2016 05:08 AM, Shuah Khan wrote: [...] > @@ -428,7 +428,7 @@ static long media_device_ioctl(struct file *filp, > unsigned int cmd, > unsigned long arg) > { > struct media_devnode *devnode = media_devnode_data(filp);

Re: [PATCH] media: fix media_ioctl use-after-free when driver unbinds

Looks mostly good, a few comments. On 04/27/2016 05:08 AM, Shuah Khan wrote: [...] > @@ -428,7 +428,7 @@ static long media_device_ioctl(struct file *filp, > unsigned int cmd, > unsigned long arg) > { > struct media_devnode *devnode = media_devnode_data(filp);

Re: [PATCH 1/2] ASoC: dmaengine_pcm: Add support for packed transfers

the constraints is now transferred to the DAI > driver and it's responsible to provide proper configuration and > check for possible corner cases that aren't handled by the ALSA core. > > Signed-off-by: Matthias Reichl <h...@horus.com> Looks good, thanks. Acked-by: Lars-Peter Clausen <l...@metafoo.de>

Re: [PATCH 1/2] ASoC: dmaengine_pcm: Add support for packed transfers

the constraints is now transferred to the DAI > driver and it's responsible to provide proper configuration and > check for possible corner cases that aren't handled by the ALSA core. > > Signed-off-by: Matthias Reichl Looks good, thanks. Acked-by: Lars-Peter Clausen

Re: [PATCH v7 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation

On 04/27/2016 09:33 AM, Appana Durga Kedareswara Rao wrote: > Hi Lars, > >> -Original Message----- >> From: Lars-Peter Clausen [mailto:l...@metafoo.de] >> Sent: Wednesday, April 27, 2016 12:42 PM >> To: Appana Durga Kedareswara Rao <appa...@xilinx.com

Re: [PATCH v7 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation

On 04/27/2016 09:33 AM, Appana Durga Kedareswara Rao wrote: > Hi Lars, > >> -Original Message----- >> From: Lars-Peter Clausen [mailto:l...@metafoo.de] >> Sent: Wednesday, April 27, 2016 12:42 PM >> To: Appana Durga Kedareswara Rao ; >> robh...@kerne

Re: [PATCH v7 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation

On 04/27/2016 09:05 AM, Kedareswara rao Appana wrote: [...] > +- xlnx,include-sg: Indicates the controller to operate in simple or > + scatter gather dma mode > +- xlnx,ratectrl : Scheduling interval in terms of clock cycles > for > +

Re: [PATCH v7 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation

On 04/27/2016 09:05 AM, Kedareswara rao Appana wrote: [...] > +- xlnx,include-sg: Indicates the controller to operate in simple or > + scatter gather dma mode > +- xlnx,ratectrl : Scheduling interval in terms of clock cycles > for > +

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/26/2016 01:47 PM, Yong Li wrote: > Thanks for your mails. Just FYI, we are testing this tmp006 sensor on > our system. and our application framework is using these device names, > so I submitted this patch. Your patch is certainly correct. But the problem is, or rather the question is, will

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/26/2016 01:47 PM, Yong Li wrote: > Thanks for your mails. Just FYI, we are testing this tmp006 sensor on > our system. and our application framework is using these device names, > so I submitted this patch. Your patch is certainly correct. But the problem is, or rather the question is, will

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/25/2016 11:11 PM, Jonathan Cameron wrote: > On 25/04/16 21:59, Crestez Dan Leonard wrote: >> On 04/25/2016 10:33 PM, Jonathan Cameron wrote: >>> On 22/04/16 04:43, Yong Li wrote: When load the driver using the below command: echo tmp006 0x40 > /sys/bus/i2c/devices/i2c-0/new_device

Re: [PATCH] iio: tmp006: Set correct iio name

On 04/25/2016 11:11 PM, Jonathan Cameron wrote: > On 25/04/16 21:59, Crestez Dan Leonard wrote: >> On 04/25/2016 10:33 PM, Jonathan Cameron wrote: >>> On 22/04/16 04:43, Yong Li wrote: When load the driver using the below command: echo tmp006 0x40 > /sys/bus/i2c/devices/i2c-0/new_device

Re: [PATCH 1/3] MIPS: JZ4740: Qi LB60: Remove support for AVT2 variant

On 04/18/2016 08:58 PM, Maarten ter Huurne wrote: > AVT2 was a prototype board of which about 5 were made, none of which > are in use anymore. > > Signed-off-by: Maarten ter Huurne <maar...@treewalker.org> Acked-by: Lars-Peter Clausen <l...@metafoo.de> Thanks.

Re: [PATCH 1/3] MIPS: JZ4740: Qi LB60: Remove support for AVT2 variant

On 04/18/2016 08:58 PM, Maarten ter Huurne wrote: > AVT2 was a prototype board of which about 5 were made, none of which > are in use anymore. > > Signed-off-by: Maarten ter Huurne Acked-by: Lars-Peter Clausen Thanks.

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

On 04/22/2016 12:43 PM, Jim Lin wrote: > Android N adds os_desc_compat in v2_descriptor by init_functionfs() > (system/core/adb/usb_linux_client.cpp) to support automatic install > of MTP driver on Windows for USB device mode. > > Current __ffs_data_do_os_desc() of f_fs.c will check reserved1

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

On 04/22/2016 12:43 PM, Jim Lin wrote: > Android N adds os_desc_compat in v2_descriptor by init_functionfs() > (system/core/adb/usb_linux_client.cpp) to support automatic install > of MTP driver on Windows for USB device mode. > > Current __ffs_data_do_os_desc() of f_fs.c will check reserved1

Re: [RFC PATCH 3/3] Documentation: iio: Add IIO software devices docs

On 04/20/2016 05:45 PM, Daniel Baluta wrote: > + > +What:/config/iio/triggers/dummy s/triggers/devices

Re: [RFC PATCH 3/3] Documentation: iio: Add IIO software devices docs

On 04/20/2016 05:45 PM, Daniel Baluta wrote: > + > +What:/config/iio/triggers/dummy s/triggers/devices

Re: [PATCH 1/2] Documentation: DT: vdma: Add clock support for vdma

On 04/20/2016 10:39 AM, Appana Durga Kedareswara Rao wrote: [...] >> however we should keep the names same as the TRM. > > Why?? Why can't we use simple convenient names that refers to equivalent > clocks of h/w Because it is confusing. If you use the same name it's very straight forward to

Re: [PATCH 1/2] Documentation: DT: vdma: Add clock support for vdma

On 04/20/2016 10:39 AM, Appana Durga Kedareswara Rao wrote: [...] >> however we should keep the names same as the TRM. > > Why?? Why can't we use simple convenient names that refers to equivalent > clocks of h/w Because it is confusing. If you use the same name it's very straight forward to

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

On 04/19/2016 03:16 PM, Mika Westerberg wrote: > On Tue, Apr 19, 2016 at 03:02:06PM +0200, Lars-Peter Clausen wrote: >> On 04/19/2016 02:40 PM, Mika Westerberg wrote: >>> On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote: >>>> A generic API by indexe

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

On 04/19/2016 03:16 PM, Mika Westerberg wrote: > On Tue, Apr 19, 2016 at 03:02:06PM +0200, Lars-Peter Clausen wrote: >> On 04/19/2016 02:40 PM, Mika Westerberg wrote: >>> On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote: >>>> A generic API by indexe

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

On 04/19/2016 02:40 PM, Mika Westerberg wrote: > On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote: >> A generic API by indexes wont work. The order between DT and ACPI will most >> likely be different. I'd even assume that the order will be different with >&

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

On 04/19/2016 02:40 PM, Mika Westerberg wrote: > On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote: >> A generic API by indexes wont work. The order between DT and ACPI will most >> likely be different. I'd even assume that the order will be different with >&

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

On 04/18/2016 05:20 PM, Srinivas Pandruvada wrote: > On Fri, 2016-04-15 at 11:01 +0300, Mika Westerberg wrote: >> +Srinivas >> >> On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: >>> >>> Some I2C devices have multiple addresses assigned, for example each >>> address >>>

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

On 04/18/2016 05:20 PM, Srinivas Pandruvada wrote: > On Fri, 2016-04-15 at 11:01 +0300, Mika Westerberg wrote: >> +Srinivas >> >> On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: >>> >>> Some I2C devices have multiple addresses assigned, for example each >>> address >>>

Re: [PATCH 1/5] max44000: Initial commit

On 04/18/2016 12:32 PM, Mark Brown wrote: [...] This always seems like a good idea, but tends to cause issues. FLAT is really only meant for very high performance devices, you are probably better with something else here. If you are doing this deliberately to make the below

Re: [PATCH 1/5] max44000: Initial commit

On 04/18/2016 12:32 PM, Mark Brown wrote: [...] This always seems like a good idea, but tends to cause issues. FLAT is really only meant for very high performance devices, you are probably better with something else here. If you are doing this deliberately to make the below

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/11/2016 04:08 PM, Jose Abreu wrote: [...] >> Currently there is also zero support of of-graph in ASoC, so a bit of work >> is required to get this integrated properly. >> > > I also believe this would be the better option but in the meantime can't I > integrate the audio like it is being

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/11/2016 04:08 PM, Jose Abreu wrote: [...] >> Currently there is also zero support of of-graph in ASoC, so a bit of work >> is required to get this integrated properly. >> > > I also believe this would be the better option but in the meantime can't I > integrate the audio like it is being

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/11/2016 01:32 PM, Jose Abreu wrote: > Hi Lars, > > > On 11-04-2016 10:33, Lars-Peter Clausen wrote: >> On 04/11/2016 11:27 AM, Jose Abreu wrote: >>> Hi Lars, >>> >>> >>> On 09-04-2016 16:02, Lars-Peter Clause

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/11/2016 01:32 PM, Jose Abreu wrote: > Hi Lars, > > > On 11-04-2016 10:33, Lars-Peter Clausen wrote: >> On 04/11/2016 11:27 AM, Jose Abreu wrote: >>> Hi Lars, >>> >>> >>> On 09-04-2016 16:02, Lars-Peter Clause

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/11/2016 11:27 AM, Jose Abreu wrote: > Hi Lars, > > > On 09-04-2016 16:02, Lars-Peter Clausen wrote: >> On 04/08/2016 06:12 PM, Jose Abreu wrote: >> [...] >>>> [...] >>>>> +- adi,enable-audio: If set the ADV7511 driver will regis

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/11/2016 11:27 AM, Jose Abreu wrote: > Hi Lars, > > > On 09-04-2016 16:02, Lars-Peter Clausen wrote: >> On 04/08/2016 06:12 PM, Jose Abreu wrote: >> [...] >>>> [...] >>>>> +- adi,enable-audio: If set the ADV7511 driver will regis

Re: [PATCH v2 27/30] iio: use parity32 in adxrs450

On 04/10/2016 04:37 PM, Jonathan Cameron wrote: > On 06/04/16 11:16, zengzhao...@163.com wrote: >> From: Zhaoxiu Zeng >> >> Signed-off-by: Zhaoxiu Zeng > Applied to the togreg branch of iio.git as you seem to have addressed > Lars' comments. The

Re: [PATCH v2 27/30] iio: use parity32 in adxrs450

On 04/10/2016 04:37 PM, Jonathan Cameron wrote: > On 06/04/16 11:16, zengzhao...@163.com wrote: >> From: Zhaoxiu Zeng >> >> Signed-off-by: Zhaoxiu Zeng > Applied to the togreg branch of iio.git as you seem to have addressed > Lars' comments. The whole series needs to go through the same tree

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/08/2016 06:12 PM, Jose Abreu wrote: [...] >> >> [...] >>> +- adi,enable-audio: If set the ADV7511 driver will register a codec >>> interface >>> + into ALSA SoC. >> This is not a description of the hardware. > > Is this okay: "adi,enable-audio: Set this boolean parameter if ADV7511 >

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/08/2016 06:12 PM, Jose Abreu wrote: [...] >> >> [...] >>> +- adi,enable-audio: If set the ADV7511 driver will register a codec >>> interface >>> + into ALSA SoC. >> This is not a description of the hardware. > > Is this okay: "adi,enable-audio: Set this boolean parameter if ADV7511 >

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

On 04/08/2016 06:08 PM, Jose Abreu wrote: > Hi Lars, > > > On 08-04-2016 16:52, Lars-Peter Clausen wrote: >> On 04/08/2016 12:06 PM, Jose Abreu wrote: >>> Hi Mark, >>> >>> >>> On 07-04-2016 18:53, Mark Brown wrote: >>&

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

On 04/08/2016 06:08 PM, Jose Abreu wrote: > Hi Lars, > > > On 08-04-2016 16:52, Lars-Peter Clausen wrote: >> On 04/08/2016 12:06 PM, Jose Abreu wrote: >>> Hi Mark, >>> >>> >>> On 07-04-2016 18:53, Mark Brown wrote: >>&

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

On 04/08/2016 12:06 PM, Jose Abreu wrote: > Hi Mark, > > > On 07-04-2016 18:53, Mark Brown wrote: >> On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: >> >>> + Optional properties: >>> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set >>> + it is required to

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

On 04/08/2016 12:06 PM, Jose Abreu wrote: > Hi Mark, > > > On 07-04-2016 18:53, Mark Brown wrote: >> On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: >> >>> + Optional properties: >>> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set >>> + it is required to

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/07/2016 06:53 PM, Jose Abreu wrote: > This patch adds audio support for the ADV7511 HDMI transmitter > using ALSA SoC. > > The code was ported from Analog Devices linux tree from > commit 1770c4a1e32b ("Merge remote-tracking branch > 'xilinx/master' into xcomm_zynq"), which is available at:

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

On 04/07/2016 06:53 PM, Jose Abreu wrote: > This patch adds audio support for the ADV7511 HDMI transmitter > using ALSA SoC. > > The code was ported from Analog Devices linux tree from > commit 1770c4a1e32b ("Merge remote-tracking branch > 'xilinx/master' into xcomm_zynq"), which is available at:

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > >> -Original Message- >> From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] >> Sent: Wednesday, April 06, 2016 9:50 PM >> To: Appana Durga Kedareswara Rao >> Cc: robh...@kernel.org;

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > >> -Original Message- >> From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] >> Sent: Wednesday, April 06, 2016 9:50 PM >> To: Appana Durga Kedareswara Rao >> Cc: robh...@kernel.org; pawel.m...@arm.com;

Re: [PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

On 04/06/2016 06:11 AM, Alison Schofield wrote: > Replace the code that guarantees the device stays in direct mode with > iio_device_{claim|release}_direct_mode() which does same. > > Signed-off-by: Alison Schofield <amsfiel...@gmail.com> Looks good, thanks. Acked-by: Lar

Re: [PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

On 04/06/2016 06:11 AM, Alison Schofield wrote: > Replace the code that guarantees the device stays in direct mode with > iio_device_{claim|release}_direct_mode() which does same. > > Signed-off-by: Alison Schofield Looks good, thanks. Acked-by: Lars-Peter Clausen > ---

Re: [PATCH] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

On 04/03/2016 11:09 AM, Jonathan Cameron wrote: > On 01/04/16 17:53, Alison Schofield wrote: >> Two instances are moved to the new claim/release API: >> >> In the first instance, the driver was using mlock followed by >> iio_buffer_enabled(). Replace that code with the new API to guarantee >> the

Re: [PATCH] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

On 04/03/2016 11:09 AM, Jonathan Cameron wrote: > On 01/04/16 17:53, Alison Schofield wrote: >> Two instances are moved to the new claim/release API: >> >> In the first instance, the driver was using mlock followed by >> iio_buffer_enabled(). Replace that code with the new API to guarantee >> the

Re: staging:iio:adis162** cleanup

On 04/05/2016 08:03 AM, Valentin Rothberg wrote: > Hi Lars-Peter, > > both of your commits 88ae3aedb8ec ("staging:iio:adis16204: Remove > adis16204 driver") and 2bcdb3f2e05f ("staging:iio:adis16220: Remove > adis16220 driver") have shown up in today's linux-next. > > The corresponding Kconfig

<    1   2   3   4   5   6   7   8   9   10   >