Re: [RFC 4/4] iio: ina2xx: add SOFTWARE buffer mode using an iio kfifo.

On 11/10/2015 05:07 PM, Marc Titinger wrote: > Capture the active scan_elements into a kfifo. > The capture thread will compute the remaining time until the next capture > tick, and do an active wait (udelay). > > This will produce a stream of up to fours channels plus a 64bits > timestamps (ns).

Re: [RFC PATCH 1/2] genirq: Add runtime resume/suspend support for IRQ chips

On 11/10/2015 05:47 PM, Grygorii Strashko wrote: [...] >> I was trying to simplify matters by placing the resume call in >> __setup_irq() as opposed to requested_threaded_irq(). However, the would >> mean the resume is inside the bus_lock and may be I should not assume >> that I can sleep here. >>

Re: [PATCH V1 1/1] iio: as6200: add AS6200 temperature sensor driver from ams AG

On 11/10/2015 10:38 AM, Florian Lobmaier wrote: > The AS6200 is a compact temperature sensor chip with I2C interface. > > Add a driver to support the AS6200 temperature sensor. > > Signed-off-by: Elitsa Polizoeva > Signed-off-by: Florian Lobmaier

Re: [PATCH v10 1/5] configfs: Allow dynamic group creation

On 11/06/2015 09:48 AM, Daniel Baluta wrote: > On Fri, Nov 6, 2015 at 9:50 AM, Christoph Hellwig wrote: >> Is this going into 4.4 through the iio tree? If not is there any chance >> to get it in through some other tree? While we're not past the merge >> window is trivial new functionality that

Re: [PATCH v10 1/5] configfs: Allow dynamic group creation

On 11/06/2015 09:48 AM, Daniel Baluta wrote: > On Fri, Nov 6, 2015 at 9:50 AM, Christoph Hellwig wrote: >> Is this going into 4.4 through the iio tree? If not is there any chance >> to get it in through some other tree? While we're not past the merge >> window is trivial new

Re: [PATCH 1/4] dmaengine: Add transfer termination synchronization support

On 10/29/2015 10:59 PM, Andy Shevchenko wrote: > On Tue, Oct 20, 2015 at 12:46 PM, Lars-Peter Clausen wrote: >> The DMAengine API has a long standing race condition that is inherent to >> the API itself. Calling dmaengine_terminate_all() is supposed to stop and >> abort

Re: [PATCH 1/4] dmaengine: Add transfer termination synchronization support

On 10/29/2015 10:59 PM, Andy Shevchenko wrote: > On Tue, Oct 20, 2015 at 12:46 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: >> The DMAengine API has a long standing race condition that is inherent to >> the API itself. Calling dmaengine_terminate_all() is supposed to

Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources

On 10/27/2015 04:53 PM, Linus Walleij wrote: > On Fri, Oct 23, 2015 at 3:36 PM, Soren Brinkmann > wrote: > >> The driver uses runtime PM to leverage low power techniques. For >> use-cases using GPIO as interrupt the device needs to be in an >> appropriate state. >> >> Reported-by: John Linn >>

Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources

On 10/27/2015 04:53 PM, Linus Walleij wrote: > On Fri, Oct 23, 2015 at 3:36 PM, Soren Brinkmann > wrote: > >> The driver uses runtime PM to leverage low power techniques. For >> use-cases using GPIO as interrupt the device needs to be in an >> appropriate state. >> >>

Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap

On 10/24/2015 11:37 PM, Robert Jarzmik wrote: [...] > -static unsigned int ac97_read(struct snd_soc_codec *codec, > - unsigned int reg); > -static int ac97_write(struct snd_soc_codec *codec, > - unsigned int reg, unsigned int val); For review purposes it would be helpful to split this

Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap

On 10/24/2015 11:37 PM, Robert Jarzmik wrote: [...] > -static unsigned int ac97_read(struct snd_soc_codec *codec, > - unsigned int reg); > -static int ac97_write(struct snd_soc_codec *codec, > - unsigned int reg, unsigned int val); For review purposes it would be helpful to split this

Re: [PATCH 4/4] ALSA: pcm_dmaengine: Properly synchronize DMA on shutdown

[...] > I've tested this series with xrun injection and some modifications to the > DMA driver to always trigger the race condition when the stream is stopped. > And I've not seen any issues after the transfer re-started. (There is a > dead-lock condition though but that does not seem to be

Re: [PATCH 4/4] ALSA: pcm_dmaengine: Properly synchronize DMA on shutdown

On 10/20/2015 01:17 PM, Takashi Iwai wrote: > On Tue, 20 Oct 2015 11:46:31 +0200, > Lars-Peter Clausen wrote: >> >> Use the new dmaengine_synchronize() function to make sure that all complete >> callbacks have finished running before the runtime data, which is accessed >

[PATCH 1/4] dmaengine: Add transfer termination synchronization support

to be done when the device_synchronize() callback is implemented. But it also helps with implementing support for devices where stopping the controller can require operations that may sleep. Signed-off-by: Lars-Peter Clausen --- Documentation/dmaengine/client.txt | 38 ++- Documentation

[PATCH 3/4] dmaengine: axi_dmac: Add synchronization support

is to wait for all currently running complete callbacks to finish. Signed-off-by: Lars-Peter Clausen --- drivers/dma/dma-axi-dmac.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 5b2395e..c346809 100644 --- a/drivers/dma

[PATCH 0/4] dmaengine: Add transfer termination synchronization support

more will follow. - Lars Lars-Peter Clausen (4): dmaengine: Add transfer termination synchronization support dmaengine: virt-dma: Add synchronization helper function dmaengine: axi_dmac: Add synchronization support ALSA: pcm_dmaengine: Properly synchronize DMA on shutdown Documentation

[PATCH 2/4] dmaengine: virt-dma: Add synchronization helper function

additional operations might be necessary in addition to calling vchan_synchronize() to ensure proper synchronization. Signed-off-by: Lars-Peter Clausen --- drivers/dma/virt-dma.h | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h

[PATCH 4/4] ALSA: pcm_dmaengine: Properly synchronize DMA on shutdown

-by: Lars-Peter Clausen --- sound/core/pcm_dmaengine.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c index fba365a..697c166 100644 --- a/sound/core/pcm_dmaengine.c +++ b/sound/core/pcm_dmaengine.c @@ -202,13

[PATCH 1/4] dmaengine: Add transfer termination synchronization support

to be done when the device_synchronize() callback is implemented. But it also helps with implementing support for devices where stopping the controller can require operations that may sleep. Signed-off-by: Lars-Peter Clausen <l...@metafoo.de> --- Documentation/dmaengine/client.txt

[PATCH 4/4] ALSA: pcm_dmaengine: Properly synchronize DMA on shutdown

-by: Lars-Peter Clausen <l...@metafoo.de> --- sound/core/pcm_dmaengine.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c index fba365a..697c166 100644 --- a/sound/core/pcm_dmaengine.c +++ b/soun

[PATCH 0/4] dmaengine: Add transfer termination synchronization support

more will follow. - Lars Lars-Peter Clausen (4): dmaengine: Add transfer termination synchronization support dmaengine: virt-dma: Add synchronization helper function dmaengine: axi_dmac: Add synchronization support ALSA: pcm_dmaengine: Properly synchronize DMA on shutdown Documentation

[PATCH 3/4] dmaengine: axi_dmac: Add synchronization support

is to wait for all currently running complete callbacks to finish. Signed-off-by: Lars-Peter Clausen <l...@metafoo.de> --- drivers/dma/dma-axi-dmac.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 5b2395e..c346809

[PATCH 2/4] dmaengine: virt-dma: Add synchronization helper function

additional operations might be necessary in addition to calling vchan_synchronize() to ensure proper synchronization. Signed-off-by: Lars-Peter Clausen <l...@metafoo.de> --- drivers/dma/virt-dma.h | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/dma/virt-dma.h b/d

Re: [PATCH 4/4] ALSA: pcm_dmaengine: Properly synchronize DMA on shutdown

On 10/20/2015 01:17 PM, Takashi Iwai wrote: > On Tue, 20 Oct 2015 11:46:31 +0200, > Lars-Peter Clausen wrote: >> >> Use the new dmaengine_synchronize() function to make sure that all complete >> callbacks have finished running before the runtime data, which is accessed >

Re: [PATCH 4/4] ALSA: pcm_dmaengine: Properly synchronize DMA on shutdown

[...] > I've tested this series with xrun injection and some modifications to the > DMA driver to always trigger the race condition when the stream is stopped. > And I've not seen any issues after the transfer re-started. (There is a > dead-lock condition though but that does not seem to be

Re: [PATCH v3 2/3] iio:adc:palmas: add DT support

On 10/16/2015 02:53 PM, H. Nikolaus Schaller wrote: [...] > +Optional sub-nodes: > +ti,channel0-current-microamp: Channel 0 current in uA. > + Values are rounded to derive 0uA, 5uA, 15uA, 20uA. > +ti,channel3-current-microamp: Channel 3 current in uA. > + Valid are rounded to derive 0uA,

Re: [PATCH] iio: accel: add support for Memsic MXC6255XC sensor

On 10/16/2015 12:29 PM, Teodora Baluta wrote: > This patch adds a minimal implementation for the Memsic MXC6255XC > orientation sensing accelerometer. The supported operations are reading > raw acceleration values for X/Y axis that can be scaled using the > exposed scale. > > Signed-off-by:

Re: [PATCH] iio: accel: add support for Memsic MXC6255XC sensor

On 10/16/2015 12:29 PM, Teodora Baluta wrote: > This patch adds a minimal implementation for the Memsic MXC6255XC > orientation sensing accelerometer. The supported operations are reading > raw acceleration values for X/Y axis that can be scaled using the > exposed scale. > > Signed-off-by:

Re: [PATCH v3 2/3] iio:adc:palmas: add DT support

On 10/16/2015 02:53 PM, H. Nikolaus Schaller wrote: [...] > +Optional sub-nodes: > +ti,channel0-current-microamp: Channel 0 current in uA. > + Values are rounded to derive 0uA, 5uA, 15uA, 20uA. > +ti,channel3-current-microamp: Channel 3 current in uA. > + Valid are rounded to derive 0uA,

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

On 10/16/2015 11:29 AM, Jon Hunter wrote: > > On 16/10/15 09:53, Lars-Peter Clausen wrote: >> On 10/16/2015 10:25 AM, Jon Hunter wrote: >>> On driver removal, before killing any tasklets, ensure that the channel >>> interrupts are disabled so that the task

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

On 10/16/2015 10:25 AM, Jon Hunter wrote: > On driver removal, before killing any tasklets, ensure that the channel > interrupts are disabled so that the tasklet will not try to run during > or after the removal of the driver. > > Signed-off-by: Jon Hunter > --- > drivers/dma/tegra20-apb-dma.c

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

On 10/16/2015 11:29 AM, Jon Hunter wrote: > > On 16/10/15 09:53, Lars-Peter Clausen wrote: >> On 10/16/2015 10:25 AM, Jon Hunter wrote: >>> On driver removal, before killing any tasklets, ensure that the channel >>> interrupts are disabled so that the task

Re: [PATCH 6/6] dmaengine: tegra-apb: Disable interrupts on removal

On 10/16/2015 10:25 AM, Jon Hunter wrote: > On driver removal, before killing any tasklets, ensure that the channel > interrupts are disabled so that the tasklet will not try to run during > or after the removal of the driver. > > Signed-off-by: Jon Hunter > --- >

Re: [alsa-devel] [RFC PATCH] ASoC: Modify check condition of multiple bindings of components

On 10/15/2015 02:10 PM, Mark Brown wrote: > On Wed, Oct 14, 2015 at 11:00:01AM +0200, Lars-Peter Clausen wrote: > >> It was never intended that it is possible to bind a component to multiple >> cards. That it was possible was a bug that was overlooked and some people >&

Re: [PATCH v6 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1

On 10/15/2015 03:36 AM, Shawn Lin wrote: [...] > + > + if (snd_dmaengine_pcm_get_caps(>dev, _caps) == 0) { > + if (dma_caps.max_burst > 4) { > + i2s->playback_dma_data.maxburst = 4; > + i2s->capture_dma_data.maxburst = 4; > + }

Re: [PATCH v6 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1

On 10/15/2015 03:36 AM, Shawn Lin wrote: [...] > + > + if (snd_dmaengine_pcm_get_caps(>dev, _caps) == 0) { > + if (dma_caps.max_burst > 4) { > + i2s->playback_dma_data.maxburst = 4; > + i2s->capture_dma_data.maxburst = 4; > + }

Re: [alsa-devel] [RFC PATCH] ASoC: Modify check condition of multiple bindings of components

On 10/15/2015 02:10 PM, Mark Brown wrote: > On Wed, Oct 14, 2015 at 11:00:01AM +0200, Lars-Peter Clausen wrote: > >> It was never intended that it is possible to bind a component to multiple >> cards. That it was possible was a bug that was overlooked and some people >&

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

On 10/14/2015 06:54 PM, Sören Brinkmann wrote: > On Wed, 2015-10-14 at 05:57PM +0200, Lars-Peter Clausen wrote: >> On 10/14/2015 05:18 PM, Sören Brinkmann wrote: >>> On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: >>>> MIPSfpga uses the axi gpio

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

On 10/14/2015 05:18 PM, Sören Brinkmann wrote: > On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: >> MIPSfpga uses the axi gpio controller. Enable the driver for MIPS. >> >> Signed-off-by: Zubair Lutfullah Kakakhel >> --- >> drivers/gpio/Kconfig | 2 +- >> 1 file changed, 1

Re: [PATCH v3] iio: mma8452: support either of the available interrupt pins

On 10/14/2015 03:15 PM, Martin Kepplinger wrote: [...] > + if (irq1 > 0) > + client->irq = irq1; You must not overwrite client->irq, that field is manged by the I2C core and is supposed to be read only for device drivers. > +

Re: [alsa-devel] [RFC PATCH] ASoC: Modify check condition of multiple bindings of components

On 10/14/2015 03:19 AM, Koro Chen wrote: > On Tue, 2015-10-13 at 16:42 +0200, Lars-Peter Clausen wrote: >> On 10/13/2015 04:18 PM, Koro Chen wrote: >>> On Tue, 2015-10-13 at 15:44 +0200, Lars-Peter Clausen wrote: >>>> On 10/13/2015 03:37 PM, Koro Chen wrote:

Re: [PATCH v3] iio: mma8452: support either of the available interrupt pins

On 10/14/2015 03:15 PM, Martin Kepplinger wrote: [...] > + if (irq1 > 0) > + client->irq = irq1; You must not overwrite client->irq, that field is manged by the I2C core and is supposed to be read only for device drivers. > +

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

On 10/14/2015 05:18 PM, Sören Brinkmann wrote: > On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: >> MIPSfpga uses the axi gpio controller. Enable the driver for MIPS. >> >> Signed-off-by: Zubair Lutfullah Kakakhel >> --- >> drivers/gpio/Kconfig |

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

On 10/14/2015 06:54 PM, Sören Brinkmann wrote: > On Wed, 2015-10-14 at 05:57PM +0200, Lars-Peter Clausen wrote: >> On 10/14/2015 05:18 PM, Sören Brinkmann wrote: >>> On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: >>>> MIPSfpga uses the axi gpio

Re: [alsa-devel] [RFC PATCH] ASoC: Modify check condition of multiple bindings of components

On 10/14/2015 03:19 AM, Koro Chen wrote: > On Tue, 2015-10-13 at 16:42 +0200, Lars-Peter Clausen wrote: >> On 10/13/2015 04:18 PM, Koro Chen wrote: >>> On Tue, 2015-10-13 at 15:44 +0200, Lars-Peter Clausen wrote: >>>> On 10/13/2015 03:37 PM, Koro Chen wrote:

Re: [alsa-devel] [RFC PATCH] ASoC: Modify check condition of multiple bindings of components

On 10/13/2015 04:18 PM, Koro Chen wrote: > On Tue, 2015-10-13 at 15:44 +0200, Lars-Peter Clausen wrote: >> On 10/13/2015 03:37 PM, Koro Chen wrote: >>> The patch "ASoC: Prevent components from being bound to multiple cards" >>> adds check to prevent multipl

Re: [RFC PATCH] ASoC: Modify check condition of multiple bindings of components

On 10/13/2015 03:37 PM, Koro Chen wrote: > The patch "ASoC: Prevent components from being bound to multiple cards" > adds check to prevent multiple cards from using the same component. > However, snd_soc_register_platform() or snd_soc_register_codec() will > also create components, and sharing the

Re: [PATCHv2 1/3] Documentation: ad5064: Added devicetree bindings documentation

>> + >> +Optional properties: >> +- vref-supply: phandle to the external reference voltage supply. >> + This should only be set if there is an external reference voltage >> + connected to the vref or vref[A-D] pins. > > I don't understand. Surely the latter case means you're

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

On 10/13/2015 07:44 AM, Jonathan Cameron wrote: > > > On 12 October 2015 18:59:57 BST, Daniel Baluta > wrote: >> >> +static unsigned instances = 1; +module_param(instances, uint, 0); >> >> One concern about this. We will still create a default number of >> 'instances' >> when using

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

On 10/13/2015 07:44 AM, Jonathan Cameron wrote: > > > On 12 October 2015 18:59:57 BST, Daniel Baluta > wrote: >> >> +static unsigned instances = 1; +module_param(instances, uint, 0); >> >> One concern about this. We will still create a default number of >>

Re: [RFC PATCH] ASoC: Modify check condition of multiple bindings of components

On 10/13/2015 03:37 PM, Koro Chen wrote: > The patch "ASoC: Prevent components from being bound to multiple cards" > adds check to prevent multiple cards from using the same component. > However, snd_soc_register_platform() or snd_soc_register_codec() will > also create components, and sharing the

Re: [PATCHv2 1/3] Documentation: ad5064: Added devicetree bindings documentation

>> + >> +Optional properties: >> +- vref-supply: phandle to the external reference voltage supply. >> + This should only be set if there is an external reference voltage >> + connected to the vref or vref[A-D] pins. > > I don't understand. Surely the latter case means you're

Re: [alsa-devel] [RFC PATCH] ASoC: Modify check condition of multiple bindings of components

On 10/13/2015 04:18 PM, Koro Chen wrote: > On Tue, 2015-10-13 at 15:44 +0200, Lars-Peter Clausen wrote: >> On 10/13/2015 03:37 PM, Koro Chen wrote: >>> The patch "ASoC: Prevent components from being bound to multiple cards" >>> adds check to prevent multipl

Re: [alsa-devel] [PATCH v5 06/10] dmaengine: add API for getting dma controller's quirk

On 10/09/2015 01:31 PM, Shawn Lin wrote: > 在 2015/10/8 16:31, Lars-Peter Clausen 写道: >> On 10/06/2015 11:21 AM, Shawn Lin wrote: >>> Hi Vinod, >>> >>> On 2015/10/5 23:37, Vinod Koul wrote: >>>> On Mon, Sep 14, 2015 at 07:48:59AM +0800, Sha

Re: [alsa-devel] [PATCH v5 06/10] dmaengine: add API for getting dma controller's quirk

On 10/09/2015 01:31 PM, Shawn Lin wrote: > 在 2015/10/8 16:31, Lars-Peter Clausen 写道: >> On 10/06/2015 11:21 AM, Shawn Lin wrote: >>> Hi Vinod, >>> >>> On 2015/10/5 23:37, Vinod Koul wrote: >>>> On Mon, Sep 14, 2015 at 07:48:59AM +0800, Sha

Re: [alsa-devel] [PATCH v5 06/10] dmaengine: add API for getting dma controller's quirk

On 10/06/2015 11:21 AM, Shawn Lin wrote: > Hi Vinod, > > On 2015/10/5 23:37, Vinod Koul wrote: >> On Mon, Sep 14, 2015 at 07:48:59AM +0800, Shawn Lin wrote: >>> Add dmaengine_get_quirks API for peripheral devices to query >>> quirks if they need it to make special workaround due to broken >>> dma

Re: [alsa-devel] [PATCH v5 06/10] dmaengine: add API for getting dma controller's quirk

On 10/06/2015 11:21 AM, Shawn Lin wrote: > Hi Vinod, > > On 2015/10/5 23:37, Vinod Koul wrote: >> On Mon, Sep 14, 2015 at 07:48:59AM +0800, Shawn Lin wrote: >>> Add dmaengine_get_quirks API for peripheral devices to query >>> quirks if they need it to make special workaround due to broken >>> dma

Re: [alsa-devel] [PATCH linux-next v3 1/1] ASoC: ad193x: add support to ad1934

Looks basically good. On 09/29/2015 04:41 PM, Cyrille Pitchen wrote: > The AD1934 codec has no DAC feature. Hence it register mapping is slightly Should be "has no ADC feature". Otherwise Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH] MIPS: jz4740: qi_lb60: Remove unused linux/leds_pwm.h include

On 10/05/2015 02:42 PM, Thierry Reding wrote: > The board code never sets up a leds-pwm device, so including the header > is not necessary. > > Signed-off-by: Thierry Reding Acked-by: Lars-Peter Clausen Thanks -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH] MIPS: jz4740: qi_lb60: Remove unused linux/leds_pwm.h include

On 10/05/2015 02:42 PM, Thierry Reding wrote: > The board code never sets up a leds-pwm device, so including the header > is not necessary. > > Signed-off-by: Thierry Reding Acked-by: Lars-Peter Clausen Thanks -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH] MIPS: jz4740: qi_lb60: Remove unused linux/leds_pwm.h include

On 10/05/2015 02:42 PM, Thierry Reding wrote: > The board code never sets up a leds-pwm device, so including the header > is not necessary. > > Signed-off-by: Thierry Reding <thierry.red...@gmail.com> Acked-by: Lars-Peter Clausen <l...@metafoo.de> Thanks -- To unsubscr

Re: [PATCH] MIPS: jz4740: qi_lb60: Remove unused linux/leds_pwm.h include

On 10/05/2015 02:42 PM, Thierry Reding wrote: > The board code never sets up a leds-pwm device, so including the header > is not necessary. > > Signed-off-by: Thierry Reding <thierry.red...@gmail.com> Acked-by: Lars-Peter Clausen <l...@metafoo.de> Thanks -- To unsubscr

Re: [alsa-devel] [PATCH linux-next v3 1/1] ASoC: ad193x: add support to ad1934

Looks basically good. On 09/29/2015 04:41 PM, Cyrille Pitchen wrote: > The AD1934 codec has no DAC feature. Hence it register mapping is slightly Should be "has no ADC feature". Otherwise Acked-by: Lars-Peter Clausen <l...@metafoo.de> -- To unsubscribe from this

Re: [PATCH] Staging: iio: meter: Use devm functions

On 10/04/2015 06:34 AM, Shraddha Barke wrote: > [...] Hi, Thanks for the patch. > - st->trig = iio_trigger_alloc("%s-dev%d", > - spi_get_device_id(st->us)->name, > - indio_dev->id); > + st->trig =

Re: [PATCH] staging: iio: adc: fix comment block coding style issue

On 10/03/2015 08:32 PM, Hugo Camboulive wrote: > This patch to ad7746.c makes the comment block end with a */ > on a separate line. > > Signed-off-by: Hugo Camboulive > --- > drivers/staging/iio/cdc/ad7746.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] Staging: iio: meter: Use devm functions

On 10/04/2015 06:34 AM, Shraddha Barke wrote: > [...] Hi, Thanks for the patch. > - st->trig = iio_trigger_alloc("%s-dev%d", > - spi_get_device_id(st->us)->name, > - indio_dev->id); > + st->trig =

Re: [PATCH] staging: iio: adc: fix comment block coding style issue

On 10/03/2015 08:32 PM, Hugo Camboulive wrote: > This patch to ad7746.c makes the comment block end with a */ > on a separate line. > > Signed-off-by: Hugo Camboulive > --- > drivers/staging/iio/cdc/ad7746.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 1/1] ASoC: ad193x: add support to ad1934

On 09/29/2015 10:36 AM, Cyrille Pitchen wrote: > The AD1934 codec has no DAC feature. Hence it register mapping is slightly > different from the register mapping of other members of the AD193x family. > > Some ASoC controls and widgets are related to the DAC feature so are not > relevant in the

Re: [PATCH 1/1] ASoC: ad193x: add support to ad1934

On 09/29/2015 10:36 AM, Cyrille Pitchen wrote: > The AD1934 codec has no DAC feature. Hence it register mapping is slightly > different from the register mapping of other members of the AD193x family. > > Some ASoC controls and widgets are related to the DAC feature so are not > relevant in the

Re: [PATCH] iio: adc: ad799x: leave sysfs naming to the core

On 09/25/2015 11:54 AM, Martin Kepplinger wrote: > This shouldn't change anything since the core calls the events folder > "events" anyways. > > Signed-off-by: Martin Kepplinger Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 1/3] iio: dac: ad5504: leave sysfs naming to the core

On 09/25/2015 11:45 AM, Martin Kepplinger wrote: > This shouldn't actually change anything since the core calls the events > sysfs folder "events" anyways. > > Signed-off-by: Martin Kepplinger Acked-by: Lars-Peter Clausen Thanks. -- To unsubscribe from this list: send

Re: [PATCH] iio: adc: ad799x: leave sysfs naming to the core

On 09/25/2015 11:54 AM, Martin Kepplinger wrote: > This shouldn't change anything since the core calls the events folder > "events" anyways. > > Signed-off-by: Martin Kepplinger <mart...@posteo.de> Acked-by: Lars-Peter Clausen <l...@metafoo.de> -- To unsubsc

Re: [PATCH 1/3] iio: dac: ad5504: leave sysfs naming to the core

On 09/25/2015 11:45 AM, Martin Kepplinger wrote: > This shouldn't actually change anything since the core calls the events > sysfs folder "events" anyways. > > Signed-off-by: Martin Kepplinger <mart...@posteo.de> Acked-by: Lars-Peter Clausen <l...@metafoo.de&g

Re: [PATCH v5 2/2] iio: mcp4531: Driver for Microchip digital potentiometers

On 09/23/2015 01:57 PM, Peter Rosin wrote: [...] Looks pretty good. One thing I'm concerned about is that this array > +static const struct mcp4531_cfg mcp4531_cfg[] = { > + { /* MCP4531-502 */ .wipers = 1, .max_pos = 128, .kohms = 5, }, > + { /* MCP4531-103 */ .wipers = 1, .max_pos =

Re: [PATCH v4 2/2] iio: mcp4531: Driver for Microchip digital potentiometers

On 09/23/2015 09:39 AM, Peter Rosin wrote: > On 2015-09-22 20:22, Jonathan Cameron wrote: >> On 22 September 2015 16:36:49 BST, Peter Rosin wrote: > > *snip* lots of cosmetics that I'll fix in the next spin... > >>> + >>> +static int mcp4531_read_raw(struct iio_dev *indio_dev, >>> +

Re: [PATCH v5 2/2] iio: mcp4531: Driver for Microchip digital potentiometers

On 09/23/2015 01:57 PM, Peter Rosin wrote: [...] Looks pretty good. One thing I'm concerned about is that this array > +static const struct mcp4531_cfg mcp4531_cfg[] = { > + { /* MCP4531-502 */ .wipers = 1, .max_pos = 128, .kohms = 5, }, > + { /* MCP4531-103 */ .wipers = 1, .max_pos =

Re: [PATCH v4 2/2] iio: mcp4531: Driver for Microchip digital potentiometers

On 09/23/2015 09:39 AM, Peter Rosin wrote: > On 2015-09-22 20:22, Jonathan Cameron wrote: >> On 22 September 2015 16:36:49 BST, Peter Rosin wrote: > > *snip* lots of cosmetics that I'll fix in the next spin... > >>> + >>> +static int mcp4531_read_raw(struct iio_dev

Re: Driver for Microchip digital potentiometers, v2

On 09/21/2015 11:18 PM, Peter Rosin wrote: > From: Peter Rosin > > Hi! > > This is a new attempt for a driver for these chips. It is a > complete rewrite since the first version which was a dirty > misc driver (plagiarized from another misc driver) that got > shredded in review. Yeah, we need

Re: Driver for Microchip digital potentiometers, v2

On 09/21/2015 11:18 PM, Peter Rosin wrote: > From: Peter Rosin > > Hi! > > This is a new attempt for a driver for these chips. It is a > complete rewrite since the first version which was a dirty > misc driver (plagiarized from another misc driver) that got > shredded in

Re: [RFC v2 4/4] iio: chemical: add SGX VZ89x VOC sensor support

On 09/07/2015 06:27 AM, Matt Ranostay wrote: > Thinking this over do we needed a IIO_CHAN_INFO_PROCESSED_OFFSET to > signal that it needs to be after the (value - offset) * scale > calculation? Well, value * scale + offset = (value + offset/scale) * scale. So just scale your offset inversely to

Re: [RFC v2 4/4] iio: chemical: add SGX VZ89x VOC sensor support

On 09/07/2015 06:27 AM, Matt Ranostay wrote: > Thinking this over do we needed a IIO_CHAN_INFO_PROCESSED_OFFSET to > signal that it needs to be after the (value - offset) * scale > calculation? Well, value * scale + offset = (value + offset/scale) * scale. So just scale your offset inversely to

Re: [PATCH v7 1/5] configfs: Allow dynamic group (un)registration

[...] > +int configfs_register_group(struct config_group *parent_group, > + struct config_group *group) > +{ > + struct dentry *dentry; > + int ret; > + > + link_group(parent_group, group); This needs to hold subsys->su_mutex I think from here to before the return we need to hold

Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

On 08/11/2015 12:42 AM, Daniel Baluta wrote: [...] > + > +static struct iio_sw_trigger *iio_trig_hrtimer_probe(const char *name) > +{ > + struct iio_hrtimer_info *trig_info; > + int ret; > + > + trig_info = kzalloc(sizeof(*trig_info), GFP_KERNEL); > + if (!trig_info) > +

Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

On 08/17/2015 02:45 PM, Vladimir Barinov wrote: > Hello Daniel, > > I've verified that your hrtimer trigger works. > > I have minor suggestions. > > Will not it be useful to have ability to stop/start hrtimer polling > not only during attach/detach trigger. > > f.e. writing 0 to

Re: [PATCH v7 3/5] iio: core: Introduce IIO software triggers

On 08/11/2015 12:42 AM, Daniel Baluta wrote: > A software trigger associates an IIO device trigger with a software > interrupt source (e.g: timer, sysfs). This patch adds the generic > infrastructure for handling software triggers. > > Software interrupts sources are kept in a

Re: [PATCH v7 3/5] iio: core: Introduce IIO software triggers

On 08/11/2015 12:42 AM, Daniel Baluta wrote: > A software trigger associates an IIO device trigger with a software > interrupt source (e.g: timer, sysfs). This patch adds the generic > infrastructure for handling software triggers. > > Software interrupts sources are kept in a

Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

On 08/17/2015 02:45 PM, Vladimir Barinov wrote: > Hello Daniel, > > I've verified that your hrtimer trigger works. > > I have minor suggestions. > > Will not it be useful to have ability to stop/start hrtimer polling > not only during attach/detach trigger. > > f.e. writing 0 to

Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

On 08/11/2015 12:42 AM, Daniel Baluta wrote: [...] > + > +static struct iio_sw_trigger *iio_trig_hrtimer_probe(const char *name) > +{ > + struct iio_hrtimer_info *trig_info; > + int ret; > + > + trig_info = kzalloc(sizeof(*trig_info), GFP_KERNEL); > + if (!trig_info) > +

Re: [PATCH v7 1/5] configfs: Allow dynamic group (un)registration

[...] > +int configfs_register_group(struct config_group *parent_group, > + struct config_group *group) > +{ > + struct dentry *dentry; > + int ret; > + > + link_group(parent_group, group); This needs to hold subsys->su_mutex I think from here to before the return we need to hold

Re: [PATCH v4 1/2] Documentation: dt: Add Xilinx zynqmp dma device tree binding documentation

On 08/06/2015 05:19 AM, Punnaiah Choudary Kalluri wrote: [...] > +Optional properties: > +- xlnx,include-sg: Indicates the controller to operate in simple or scatter > +gather dma mode > +- xlnx,ratectrl: Scheduling interval in terms of clock cycles for > + source AXI

Re: [PATCH v4 1/2] Documentation: dt: Add Xilinx zynqmp dma device tree binding documentation

On 08/06/2015 05:19 AM, Punnaiah Choudary Kalluri wrote: [...] +Optional properties: +- xlnx,include-sg: Indicates the controller to operate in simple or scatter +gather dma mode +- xlnx,ratectrl: Scheduling interval in terms of clock cycles for + source AXI

Re: [PATCH] Altera Modular ADC driver device tree binding

On 08/20/2015 09:46 AM, Chee Nouk Phoo wrote: > From: Chee Nouk Phoon > > Altera Modular ADC is soft IP that wraps the hardened ADC block in a Max1 > device. It can be configured to dual ADC mode that supports two channel > synchronous sampling or independent single ADCs. ADC sampled values will

Re: [PATCH 10/18] iio: dac: ad7303: Add OF match table

e SPI > core can do an OF style match. > > Signed-off-by: Javier Martinez Canillas Acked-by: Lars-Peter Clausen Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 01/18] iio: Export SPI module alias information in missing drivers

ice (i.e: SPI id table or OF match table). > > So drivers needs to export the SPI id table and this be built into > the module or udev won't have the necessary information to autoload > the needed driver module when the device is added. > > Signed-off-by: Javier Martinez Canillas

Re: [PATCH 16/18] iio: frequency: adf4350: Add OF match table

the table to the > driver so the SPI core can do an OF style match. > > Signed-off-by: Javier Martinez Canillas Acked-by: Lars-Peter Clausen Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH 16/18] iio: frequency: adf4350: Add OF match table

core can do an OF style match. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com Acked-by: Lars-Peter Clausen l...@metafoo.de Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 01/18] iio: Export SPI module alias information in missing drivers

-Peter Clausen l...@metafoo.de Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 10/18] iio: dac: ad7303: Add OF match table

match. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com Acked-by: Lars-Peter Clausen l...@metafoo.de Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] Altera Modular ADC driver device tree binding

On 08/20/2015 09:46 AM, Chee Nouk Phoo wrote: From: Chee Nouk Phoon cnph...@altera.com Altera Modular ADC is soft IP that wraps the hardened ADC block in a Max1 device. It can be configured to dual ADC mode that supports two channel synchronous sampling or independent single ADCs. ADC

Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

On 08/15/2015 09:57 PM, Jonathan Cameron wrote: > On 11/08/15 19:43, Lars-Peter Clausen wrote: >> On 08/10/2015 11:51 PM, Joe Perches wrote: >>> Using 'extern' is not necessary for function prototypes. >>> >>> Signed-off-by: Joe Perches >> >

<    3   4   5   6   7   8   9   10   11   12   >