Re: Request for review of adjtimex(2) man page

2015-01-07 Thread Laurent Georget
Hello, >I've added a large number > of FIXMEs in the draft below, and would be happy if anyone can supply > some content to fill any of the gaps. Isn't the man page going to be very long and hard to read if we explain all the NTP internals in adjtimex.2? I think we could create a second man pag

Re: [PATCH 2/2] adjtimex.2: Change 'PPM' (parts per million) to 'ppm'

2015-01-02 Thread Laurent Georget
Hi again, this is the second patch of the new series of patchs for adjtimex.2. This is a trivia patch correcting "PPM" (parts per million) to the more usual "ppm". Credits to Jeff Epler . --- man2/adjtimex.2 | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/m

[PATCH 1/2] adjtimex.2: Clarify the 'ppm scaling' used in struct timex

2015-01-02 Thread Laurent Georget
Hi, this is the last version of a new series of patchs for adjtimex.2. Please ignore all previous versions of this series. This patch makes explicit and clarifies the unit used for fields "freq", "ppsfreq" and "stabil" in struct timex. It closes a FIXME in the man page. Reviewed-By: Jeff Epler

Re: [PATCH] adjtimex: PPM scaling is by 2^-16

2015-01-02 Thread Laurent Georget
Le 02/01/2015 22:15, Jeff Epler a écrit : > However, the patch got line-wrapped again (I fixed it manually above). > With line-wrapped fix, consider it > > Reviewed-by: Jeff Epler Sorry, I'm giving up on 'normal' email clients to send patchs. 'git format-patch' and 'mutt' will do. > > hm, as a

Re: [PATCH] adjtimex: PPM scaling is by 2^-16

2015-01-02 Thread Laurent Georget
Hi, Le 02/01/2015 07:29, Richard Cochran a écrit : > On Thu, Jan 01, 2015 at 08:41:20PM -0600, Jeff Epler wrote: >> Like Laurent Georget, I found by reading ntpd source >> the scale is 2^16 (i.e., 1 ~= 1.5e-5 ppm, 65536 = 1ppm) > > Yep, you wont find this documented in pro

Re: [PATCH] adjtimex.2: Add details about ADJ_FREQUENCY

2014-12-30 Thread Laurent Georget
Hi again, Le 30/12/2014 19:05, Richard Cochran a écrit : >> diff --git a/man2/adjtimex.2 b/man2/adjtimex.2 >> index 18823c8..2652fc6 100644 >> --- a/man2/adjtimex.2 >> +++ b/man2/adjtimex.2 >> @@ -55,8 +55,8 @@ struct timex { >> status flag is set, otherwise >>

[PATCH] adjtimex.2: Add details about ADJ_FREQUENCY

2014-12-30 Thread Laurent Georget
Hi, this is another patch for adjtimex(2) man page which fixes a FIXME by giving the scaling unit of timex.freq and adds a detail about the value expected by ADJ_FREQUENCY. Laurent diff --git a/man2/adjtimex.2 b/man2/adjtimex.2 index 18823c8..2652fc6 100644 --- a/man2/adjtimex.2 +++ b/man2/adjti

[PATCH 1/2 v3] adjtimex.2: add fields in struct timex description

2014-11-30 Thread Laurent Georget
Hello, this is a refactored series of patches for adjtimex(2) man page. Please ignore all previous patches I sent for adjtimex.2. The first patch updates the man page with the new fields added in struct timex since last edition of the man page. Thank you for your time. These are my first patches

[PATCH 2/2 v3] adjtimex.2: add explanation on ADJ_TAI mode

2014-11-30 Thread Laurent Georget
ment ADJ_TAI (added in Linux 2.6.26) -.\"commit 153b5d054ac2d98ea0d86504884326b6777f683d +.\" Modified 2014-11-30 by Laurent Georget .\" .\" FIXME Document ADJ_MICRO and ADJ_NANO (added in Linux 2.6.26) .\"commit eea83d896e318bda54be2d2770d2c5d6668d11db @@ -101,

Re: [patch v2] adjtimex.2: add explanation about ADJ_TAI action

2014-11-29 Thread Laurent Georget
/adjtimex.2 >> +++ b/man2/adjtimex.2 >> @@ -26,9 +26,6 @@ >> .\" Modified 2004-05-27 by Michael Kerrisk >> .\" Modified 2014-11-28 by Laurent Georget >> .\" >> -.\" FIXME Document ADJ_TAI (added in Linux 2.6.26) >> -.\" commit 1

Re: [patch v2] adjtimex.2: add explanation about ADJ_TAI action

2014-11-28 Thread Laurent Georget
Le 28/11/2014 22:00, Richard Cochran a écrit : > On Fri, Nov 28, 2014 at 02:40:44PM +0100, Laurent Georget wrote: >> @@ -101,7 +99,19 @@ combination of zero or more of the following bits: >> Ordinary users are restricted to a zero value for >> .IR modes . >> Onl

[patch] adjtimex.2: add explanation about ADJ_TAI action

2014-11-28 Thread Laurent Georget
chael Kerrisk .\" Modified 2014-11-28 by Laurent Georget .\" -.\" FIXME Document ADJ_TAI (added in Linux 2.6.26) -.\"commit 153b5d054ac2d98ea0d86504884326b6777f683d -.\" .\" FIXME Document ADJ_MICRO and ADJ_NANO (added in L