[PATCH] staging: unisys: visorbus: add missing include

2016-10-15 Thread Laurent Navet
' was not declared. Should it be static? warning: symbol 'visorchannel_create' was not declared. Should it be static? warning: symbol 'visorchannel_create_with_lock' was not declared. Should it be static? Signed-off-by: Laurent Navet <laurent.na...@gmail.com> --- drivers/staging/unisys/visorbus/visorcha

[PATCH] staging: unisys: visorbus: add missing include

2016-10-15 Thread Laurent Navet
' was not declared. Should it be static? warning: symbol 'visorchannel_create' was not declared. Should it be static? warning: symbol 'visorchannel_create_with_lock' was not declared. Should it be static? Signed-off-by: Laurent Navet --- drivers/staging/unisys/visorbus/visorchannel.c | 1 + 1 file changed, 1

[PATCH] docs/driver-model: fix typo

2016-09-15 Thread Laurent Navet
No need to be be, just be should be sufficient. Signed-off-by: Laurent Navet <laurent.na...@gmail.com> --- Documentation/driver-model/device.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/driver-model/device.txt b/Documentation/driver-model/devi

[PATCH] docs/driver-model: fix typo

2016-09-15 Thread Laurent Navet
No need to be be, just be should be sufficient. Signed-off-by: Laurent Navet --- Documentation/driver-model/device.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/driver-model/device.txt b/Documentation/driver-model/device.txt index 1e70220..2403eb8 100644

Re: [PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread Laurent Navet
why not directly ? struct region_devres *dr = devres_alloc(devm_region_release, sizeof(struct region_devres),.. 2015-12-29 14:24 UTC+01:00, Bojan Prtvar : > Few lines below dr is reinitialized by devres_alloc() > so we don't need to init it by NULL in the beginning of > __devm_request_region()

Re: [PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread Laurent Navet
why not directly ? struct region_devres *dr = devres_alloc(devm_region_release, sizeof(struct region_devres),.. 2015-12-29 14:24 UTC+01:00, Bojan Prtvar : > Few lines below dr is reinitialized by devres_alloc() > so we don't need to init it by NULL in the beginning of >

[PATCH V2] i2c: s3c2410: remove unused variable

2015-07-17 Thread Laurent Navet
in i2c_s3c_irq_nextbyte() ret is assigned zero and just used to return. Remove it and make i2c_s3c_irq_nextbyte() a void function. Found by using coccinelle. Signed-off-by: Laurent Navet --- drivers/i2c/busses/i2c-s3c2410.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

[PATCH V2] i2c: s3c2410: remove unused variable

2015-07-17 Thread Laurent Navet
in i2c_s3c_irq_nextbyte() ret is assigned zero and just used to return. Remove it and make i2c_s3c_irq_nextbyte() a void function. Found by using coccinelle. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/i2c/busses/i2c-s3c2410.c | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH] i2c: s3c2410: remove unused variable

2015-07-16 Thread Laurent Navet
ret is assigned zero and just used to return. remove it. Found by using coccinelle. Signed-off-by: Laurent Navet --- drivers/i2c/busses/i2c-s3c2410.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index

[PATCH] i2c: s3c2410: remove unused variable

2015-07-16 Thread Laurent Navet
ret is assigned zero and just used to return. remove it. Found by using coccinelle. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/i2c/busses/i2c-s3c2410.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c

[PATCH] ext4 crypto: fix typo

2015-07-09 Thread Laurent Navet
derivatio -> derivation. Signed-off-by: Laurent Navet --- fs/ext4/crypto_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c index ce75bc8..1d510c1 100644 --- a/fs/ext4/crypto_key.c +++ b/fs/ext4/crypto_key.c @@ -30,7 +3

[PATCH V2] ext4 crypto: exit cleanly if ext4_derive_key_aes() fails

2015-07-09 Thread Laurent Navet
Return value of ext4_derive_key_aes() is stored but not used. Add test to exit cleanly if ext4_derive_key_aes() fail. Also fix coverity CID 1309760. Signed-off-by: Laurent Navet --- fs/ext4/crypto_key.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/crypto_key.c b/fs/ext4

Re: [PATCH] ext4 crypto: remove unneeded assignation

2015-07-09 Thread Laurent Navet
Make sense, I send a v2, thank's 2015-07-08 22:01 UTC+02:00, Darrick J. Wong : > On Wed, Jul 08, 2015 at 09:51:15PM +0200, Laurent Navet wrote: >> Return value of ext4_derive_key_aes() is stored but never used before >> being overwritten. >> Also fix coverity CID 1309

Re: [PATCH] ext4 crypto: remove unneeded assignation

2015-07-09 Thread Laurent Navet
Make sense, I send a v2, thank's 2015-07-08 22:01 UTC+02:00, Darrick J. Wong darrick.w...@oracle.com: On Wed, Jul 08, 2015 at 09:51:15PM +0200, Laurent Navet wrote: Return value of ext4_derive_key_aes() is stored but never used before being overwritten. Also fix coverity CID 1309760. Signed

[PATCH] ext4 crypto: fix typo

2015-07-09 Thread Laurent Navet
derivatio - derivation. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- fs/ext4/crypto_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c index ce75bc8..1d510c1 100644 --- a/fs/ext4/crypto_key.c +++ b/fs/ext4

[PATCH V2] ext4 crypto: exit cleanly if ext4_derive_key_aes() fails

2015-07-09 Thread Laurent Navet
Return value of ext4_derive_key_aes() is stored but not used. Add test to exit cleanly if ext4_derive_key_aes() fail. Also fix coverity CID 1309760. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- fs/ext4/crypto_key.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4

[PATCH] ext4 crypto: remove unneeded assignation

2015-07-08 Thread Laurent Navet
Return value of ext4_derive_key_aes() is stored but never used before being overwritten. Also fix coverity CID 1309760. Signed-off-by: Laurent Navet --- fs/ext4/crypto_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c index

[PATCH] [media] dvb-core: remove ktime_add_us() call

2015-07-08 Thread Laurent Navet
Calling ktime_add_us() seems useless as is only useful for it's return value which is ignored. Also fix coverity CID 1309761. Signed-off-by: Laurent Navet --- drivers/media/dvb-core/dvb_frontend.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b

[PATCH] ext4 crypto: remove unneeded assignation

2015-07-08 Thread Laurent Navet
Return value of ext4_derive_key_aes() is stored but never used before being overwritten. Also fix coverity CID 1309760. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- fs/ext4/crypto_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/crypto_key.c b/fs/ext4

[PATCH] [media] dvb-core: remove ktime_add_us() call

2015-07-08 Thread Laurent Navet
Calling ktime_add_us() seems useless as is only useful for it's return value which is ignored. Also fix coverity CID 1309761. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/media/dvb-core/dvb_frontend.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-core

[PATCH] gpiolib: remove unneeded assignation

2015-07-07 Thread Laurent Navet
ret is assigned value from of_property_read_string_index but is overwritten before being used so remove it. Also fix coverity CID 1309759 Signed-off-by: Laurent Navet --- drivers/gpio/gpiolib-of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib-of.c b

[PATCH] gpiolib: remove unneeded assignation

2015-07-07 Thread Laurent Navet
ret is assigned value from of_property_read_string_index but is overwritten before being used so remove it. Also fix coverity CID 1309759 Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/gpio/gpiolib-of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] iio: buffer: remove unneeded test

2015-05-30 Thread Laurent Navet
The same code is executed regardless ret value, so this test can be removed. Also fix coverity scan CID 1268786. Signed-off-by: Laurent Navet --- drivers/iio/industrialio-buffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio

[PATCH] iio: buffer: remove unneeded test

2015-05-30 Thread Laurent Navet
The same code is executed regardless ret value, so this test can be removed. Also fix coverity scan CID 1268786. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/iio/industrialio-buffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iio/industrialio-buffer.c b

[PATCH] staging: gdm72xx: remove unneeded test

2015-05-27 Thread Laurent Navet
The same code is executed regardless ret value, so this test can be removed. Signed-off-by: Laurent Navet --- drivers/staging/gdm72xx/usb_boot.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c index 3ccc447..7f80553

[PATCH] staging: gdm72xx: remove unneeded test

2015-05-27 Thread Laurent Navet
The same code is executed regardless ret value, so this test can be removed. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/staging/gdm72xx/usb_boot.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c

[PATCH] i40e: remove unneeded tests

2015-05-26 Thread Laurent Navet
The same code is executed regardless ret_code value, so these tests can be removed. Fix Coverity CID 1268789 and 1268791 Signed-off-by: Laurent Navet --- drivers/net/ethernet/intel/i40e/i40e_hmc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c

[PATCH] MAINTAINERS: update Emulex ocrdma email addresses

2015-05-26 Thread Laurent Navet
@emulex.com addresses respond to use @avagotech.com. Signed-off-by: Laurent Navet --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f8e0afb..05766f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8846,9 +8846,9 @@ S

[PATCH] i40e: remove unneeded tests

2015-05-26 Thread Laurent Navet
The same code is executed regardless ret_code value, so these tests can be removed. Fix Coverity CID 1268789 and 1268791 Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/net/ethernet/intel/i40e/i40e_hmc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet

[PATCH] MAINTAINERS: update Emulex ocrdma email addresses

2015-05-26 Thread Laurent Navet
@emulex.com addresses respond to use @avagotech.com. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f8e0afb..05766f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH] RDMA/ocrdma: remove unneeded tests

2015-05-21 Thread Laurent Navet
The same code is executed regardless status value, so these tests can be removed. Fix Coverity CID 1271151 and 1268788 Signed-off-by: Laurent Navet --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b

[PATCH] RDMA/ocrdma: remove unneeded tests

2015-05-21 Thread Laurent Navet
The same code is executed regardless status value, so these tests can be removed. Fix Coverity CID 1271151 and 1268788 Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/infiniband/hw

[PATCH] [media] fc0013: remove unneeded test

2015-04-02 Thread Laurent Navet
The same code is executed if ret is true or false, so this test can be removed. Fix Coverity CID 1268782. Signed-off-by: Laurent Navet --- drivers/media/tuners/fc0013.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/tuners/fc0013.c b/drivers/media/tuners/fc0013.c index

[PATCH] [media] fc0013: remove unneeded test

2015-04-02 Thread Laurent Navet
The same code is executed if ret is true or false, so this test can be removed. Fix Coverity CID 1268782. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/media/tuners/fc0013.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/tuners/fc0013.c b/drivers/media

Re: [PATCH] staging: line6: fix possible overrun

2014-04-27 Thread Laurent Navet
ak the driver > completely and make it unusable. > >> >> As a side note I'm not sure if pod_try_init from >> drivers/staging/line6/pod.c >> cleans up properly after failed line6_init_audio. > > Yeah. It doesn't seem to clean up at all. > Laurent Navet. -- « On ne réso

Re: [PATCH] staging: line6: fix possible overrun

2014-04-27 Thread Laurent Navet
/pod.c cleans up properly after failed line6_init_audio. Yeah. It doesn't seem to clean up at all. Laurent Navet. -- « On ne résout pas un problème avec les modes de pensée qui l’ont engendré. » « You cannot solve current problems with current thinking. Current problems are the result

[PATCH] staging: line6: fix possible overrun

2014-04-26 Thread Laurent Navet
The strcpy operation may write past the end of the fixed-size destination buffer if the source buffer is too large. Found by coverity scan : CID 144979 Signed-off-by: Laurent Navet --- build tested only drivers/staging/line6/audio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[PATCH] staging: line6: fix possible overrun

2014-04-26 Thread Laurent Navet
The strcpy operation may write past the end of the fixed-size destination buffer if the source buffer is too large. Found by coverity scan : CID 144979 Signed-off-by: Laurent Navet laurent.na...@gmail.com --- build tested only drivers/staging/line6/audio.c | 5 +++-- 1 file changed, 3

[PATCH] staging: slicoss: fix possible missing iounmap

2013-11-15 Thread Laurent Navet
if slic_card_locate failed, memmapped_ioaddr is not unmapped. Signed-off-by: Laurent Navet --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 652272b..ab7206d

[PATCH] staging: slicoss: fix possible missing iounmap

2013-11-15 Thread Laurent Navet
if slic_card_locate failed, memmapped_ioaddr is not unmapped. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c

[PATCH 1/2] octeon_mgmt: remove double validation of mac address

2013-10-29 Thread Laurent Navet
Mac address validity is already checked in of_get_mac_address(). No need to do it twice. Signed-off-by: Laurent Navet --- drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net

[PATCH] mvneta: remove double validation of mac address

2013-10-29 Thread Laurent Navet
Mac address validity is already checked in of_get_mac_address(). No need to do it twice. Signed-off-by: Laurent Navet --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet

[PATCH] mvneta: remove double validation of mac address

2013-10-29 Thread Laurent Navet
Mac address validity is already checked in of_get_mac_address(). No need to do it twice. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b

[PATCH 1/2] octeon_mgmt: remove double validation of mac address

2013-10-29 Thread Laurent Navet
Mac address validity is already checked in of_get_mac_address(). No need to do it twice. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/octeon

[PATCH] staging: lustre: use ERR_CAST() function

2013-07-05 Thread Laurent Navet
use ERR_CAST() function instead of ERR_PTR() and PTR_ERR() found using coccinelle and err_cast.cocci Signed-off-by: Laurent Navet --- drivers/staging/lustre/lustre/llite/llite_nfs.c|2 +- drivers/staging/lustre/lustre/llite/rw.c |2 +- drivers/staging/lustre/lustre

[PATCH] staging: lustre: use ERR_CAST() function

2013-07-05 Thread Laurent Navet
use ERR_CAST() function instead of ERR_PTR() and PTR_ERR() found using coccinelle and err_cast.cocci Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/staging/lustre/lustre/llite/llite_nfs.c|2 +- drivers/staging/lustre/lustre/llite/rw.c |2

[PATCH V2] drivers: video: mxsfb: clean use of devm_ioremap_resource()

2013-05-21 Thread Laurent Navet
Check of 'res' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet --- drivers/video/mxsfb.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index

[PATCH V2] drivers: video: mxsfb: clean use of devm_ioremap_resource()

2013-05-21 Thread Laurent Navet
Check of 'res' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/video/mxsfb.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers

Re: [PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource()

2013-05-16 Thread Laurent Navet
2013/5/16, Jingoo Han : > It makes build warning as below: > > drivers/video/mxsfb.c:887:13: warning: 'host' is used uninitialized in this > function [-Wuninitialized] > drivers/video/mxsfb.c:965:21: warning: 'fb_info' may be used uninitialized > in this function [-Wuninitialized] > > It breaks

[PATCH V2] drivers: mmc: host: use devm_ioremap_resource()

2013-05-16 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet --- drivers/mmc/host/mvsdio.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH V2] drivers: mmc: host: use devm_ioremap_resource()

2013-05-16 Thread Laurent Navet
This second version fix a typo in commit message reported by Jingoo Han Regards, Laurent. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

[PATCH V2] drivers: mmc: host: use devm_ioremap_resource()

2013-05-16 Thread Laurent Navet
This second version fix a typo in commit message reported by Jingoo Han Regards, Laurent. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

[PATCH V2] drivers: mmc: host: use devm_ioremap_resource()

2013-05-16 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/mmc/host/mvsdio.c |6 +++--- 1 file changed, 3

Re: [PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource()

2013-05-16 Thread Laurent Navet
2013/5/16, Jingoo Han jg1@samsung.com: It makes build warning as below: drivers/video/mxsfb.c:887:13: warning: 'host' is used uninitialized in this function [-Wuninitialized] drivers/video/mxsfb.c:965:21: warning: 'fb_info' may be used uninitialized in this function [-Wuninitialized]

Re: [PATCH] drivers: pinctrl: vt8500: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
> Oh is that deprecated? I had no clue :-/ > Can you point to some rationale about this so I'm not > totally misguided in my world..? > Yes: https://lkml.org/lkml/2013/1/21/360 > > Grant is just going to *not* love this type of patches replacing > nullchecks with IS_ERR() stuff all over the

[PATCH] drivers: gpio: gpio-msm-v1.c: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet --- drivers/gpio/gpio-msm-v1.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH] drivers: dma: sh: sudmac: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet --- drivers/dma/sh/sudmac.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH] drivers/spi/spi-tegra114.c clean use of devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Check of 'r' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet --- drivers/spi/spi-tegra114.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi

[PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Check of 'res' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet --- drivers/video/mxsfb.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
>> --- a/drivers/net/ethernet/freescale/fec_main.c >> +++ b/drivers/net/ethernet/freescale/fec_main.c >> @@ -1843,8 +1843,6 @@ fec_probe(struct platform_device *pdev) >> pdev->id_entry = of_id->data; >> >> r = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if

Re: [PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
--- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1843,8 +1843,6 @@ fec_probe(struct platform_device *pdev) pdev-id_entry = of_id-data; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) -

[PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Check of 'res' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/video/mxsfb.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/video/mxsfb.c b

[PATCH] drivers/spi/spi-tegra114.c clean use of devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Check of 'r' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/spi/spi-tegra114.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/spi/spi-tegra114.c b

[PATCH] drivers: dma: sh: sudmac: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/dma/sh/sudmac.c |6 +++--- 1 file changed, 3

[PATCH] drivers: gpio: gpio-msm-v1.c: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/gpio/gpio-msm-v1.c | 12 ++-- 1 file

Re: [PATCH] drivers: pinctrl: vt8500: use devm_ioremap_resource()

2013-05-14 Thread Laurent Navet
Oh is that deprecated? I had no clue :-/ Can you point to some rationale about this so I'm not totally misguided in my world..? Yes: https://lkml.org/lkml/2013/1/21/360 Grant is just going to *not* love this type of patches replacing nullchecks with IS_ERR() stuff all over the kernel.

[PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. also remove tests on 'r' since devm_ioremap_resource() checks for it in a better way. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet

[PATCH] drivers: net: can: grcan: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. dev_err() message is no more needed since it's already displayed in devm_ioremap_resource(). Signed-off-by: Laurent Navet --- drivers/net/can/grcan.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions

[PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. also remove tests on 'res' since devm_ioremap_resource() checks for it in a better form. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet

Re: [PATCH] arch: sparc: kernel: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
May 12, 2013 at 04:10:07PM +0200, Laurent Navet wrote: >> Replace a call to deprecated devm_request_and_ioremap by >> devm_ioremap_resource. >> >> Found with coccicheck and this semantic patch: >> scripts/coccinelle/api/devm_request_and_ioremap.cocci. >> >>

Re: [PATCH] arch: sparc: kernel: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
: On Sun, May 12, 2013 at 04:10:07PM +0200, Laurent Navet wrote: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na

[PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. also remove tests on 'res' since devm_ioremap_resource() checks for it in a better form. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet

[PATCH] drivers: net: can: grcan: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. dev_err() message is no more needed since it's already displayed in devm_ioremap_resource(). Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/net/can/grcan.c |7 +++ 1 file changed, 3

[PATCH] net: ethernet: freescale: use devm_ioremap_resource()

2013-05-13 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. also remove tests on 'r' since devm_ioremap_resource() checks for it in a better way. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet

Re: [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
Please, don't take this one I'll send a more complete one later, Sorry, 2013/5/12, Laurent Navet : > Replace a call to deprecated devm_request_and_ioremap by > devm_ioremap_resource. > > Found with coccicheck and this semantic patch: > scripts/coccinelle/api/devm_ioremap

[PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet --- drivers/net/ethernet/broadcom/bcm63xx_enet.c |6 +++--- 1 file changed, 3

[PATCH] drivers: pinctrl: vt8500: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet --- drivers/pinctrl/vt8500/pinctrl-wmt.c |6 +++--- 1 file changed, 3 insertions

[PATCH] drivers: mmc: host: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
eplace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet --- drivers/mmc/host/mvsdio.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] arch: sparc: kernel: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- arch/sparc/kernel/leon_pci_grpci1.c |8 +++- 1 file changed, 3

[PATCH] arch: sparc: kernel: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- arch/sparc/kernel/leon_pci_grpci1.c |8 +++- 1

[PATCH] drivers: mmc: host: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
eplace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/mmc/host/mvsdio.c |6 +++--- 1 file changed, 3

[PATCH] drivers: pinctrl: vt8500: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/pinctrl/vt8500/pinctrl-wmt.c |6 +++--- 1 file

[PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/net/ethernet/broadcom/bcm63xx_enet.c |6

Re: [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()

2013-05-12 Thread Laurent Navet
Please, don't take this one I'll send a more complete one later, Sorry, 2013/5/12, Laurent Navet laurent.na...@gmail.com: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api

[PATCH] iio: adc: exynos_adc: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/iio/adc/exynos_adc.c | 12 ++-- 1 file changed, 6 insertions

[PATCH] drivers: mtd: devices: elm: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/mtd/devices/elm.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH V2] drivers: mtd: nand: davinci: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/mtd/nand/davinci_nand.c | 13 - 1 file changed, 8

[PATCH] drivers: mtd: nand: davinci: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/mtd/nand/davinci_nand.c | 13 - 1 file changed, 8

[PATCH] drivers: misc: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/misc/sram.c |7 --- 1 file changed, 4 insertions(+), 3

[PATCH] drivers: spi: bmc2835: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/spi/spi-bcm2835.c |7 +++ 1 file changed, 3 insertions(+), 4

[PATCH] drivers: crypto: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/crypto/omap-aes.c |7 +++ drivers/crypto/omap-sham.c |7

[PATCH] staging: imx-drm: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/staging/imx-drm/imx-tve.c |8 +++- 1 file changed, 3

[PATCH] staging: dwc2: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/staging/dwc2/pci.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] staging: dwc2: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/staging/dwc2/pci.c |6 +++--- 1 file

[PATCH] staging: imx-drm: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/staging/imx-drm/imx-tve.c |8 +++- 1

[PATCH] drivers: crypto: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/crypto/omap-aes.c |7 +++ drivers

[PATCH] drivers: spi: bmc2835: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/spi/spi-bcm2835.c |7 +++ 1 file

[PATCH] drivers: misc: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/misc/sram.c |7 --- 1 file changed, 4

[PATCH] drivers: mtd: nand: davinci: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/mtd/nand/davinci_nand.c | 13 - 1

[PATCH V2] drivers: mtd: nand: davinci: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/mtd/nand/davinci_nand.c | 13 - 1

  1   2   >