Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses

2019-04-04 Thread Lawrence Brakmo
On 4/4/19, 11:39 AM, "Tilmans, Olivier (Nokia - BE/Antwerp)" wrote: > DCTCP is meant to be used in environments where the switches/routers do > ECN marking, so it is not surprising that it performs badly when used in > environments where it was not meant to be used. Has anyone

Re: [PATCH] tcp_nv: fix division by zero in tcpnv_acked()

2017-11-01 Thread Lawrence Brakmo
hlebni...@yandex-team.ru Acked-by: Lawrence Brakmo <bra...@fb.com> --- net/ipv4/tcp_nv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c index 1ff73982e28c..125fc1450b01 100644 --- a/net/ipv4/tcp_n

Re: [PATCH] tcp_nv: fix division by zero in tcpnv_acked()

2017-11-01 Thread Lawrence Brakmo
Thank you for finding and fixing this. On 11/1/17, 6:32 AM, "Konstantin Khlebnikov" wrote: Average RTT could become zero. This happened in real life at least twice. This patch treats zero as 1us. Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru Acked-by

Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case

2017-07-04 Thread Lawrence Brakmo
etected by CoverityScan, CID#1449376 ("Missing break in switch") > > Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Daniel Borkmann dan...@iogearbox.net A

Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case

2017-07-04 Thread Lawrence Brakmo
bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp") > Signed-off-by: Colin Ian King Acked-by: Daniel Borkmann dan...@iogearbox.net Acked-by: Lawrence Brakmo > --- > net/core/filter.c | 1 + > 1 file changed, 1 insertion(+)