Re: [PATCH 00/15] [Set 2] Rid W=1 warnings from ATA

On Thu, 18 Mar 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > This is set 2 out of 2 sets required. > > Lee Jones (15): > ata: pat

Re: [PATCH v1 1/7] Add Driver for SUNIX PCI(e) I/O expansion board

++ b/spi_pack.c > @@ -0,0 +1,1506 @@ -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] Add Driver for SUNIX PCI(e) I/O expansion board

InputDeltaReg:x%08x\n", dio_chl->info.line, InputDeltaReg); No unused code. > + InputDeltaReg &= > cib_info->dio_bank_cap[BankIndex].io_mask; > + //printk("SUNIX: DIO (%d), get bank input delta state, > INDIVIDUAL, 2, Inp

[PATCH 1/1] of: base: Fix spelling issue with function param 'prop'

:1855: warning: Excess function parameter 'prob' description in 'of_remove_property' Cc: Rob Herring Cc: Frank Rowand Cc: "David S. Miller" Cc: devicet...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition

On Mon, 29 Mar 2021, Jonathan Cameron wrote: > On Fri, 26 Mar 2021 14:34:56 + > Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/hid/hid-sensor-hub.c:54: warning: Function parameter or member

Re: linux-next: build warnings after merge of the devicetree tree

escription > in 'of_remove_property' > > Introduced by commit > > 3637d49e1121 ("of: base: Fix some formatting issues and provide missing > descriptions") Ah, I see. Will fix. Please bear with me. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro

Re: [PATCH v7 01/13] dt-bindings: mfd: Add 'nxp,imx8mq-vpu-ctrl' to syscon list

ntation/devicetree/bindings/mfd/syscon.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2 1/1] mfd: intel_quark_i2c_gpio: Don't play dirty trick with const

; drivers/mfd/intel_quark_i2c_gpio.c | 26 -- > 1 file changed, 12 insertions(+), 14 deletions(-) Neat. Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[PATCH 24/25] HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues

: Benjamin Tissoires Cc: Sumit Semwal Cc: "Christian König" Cc: Rushikesh S Kadam Cc: linux-in...@vger.kernel.org Cc: linux-me...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid

[PATCH 25/25] HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning

->ishtp_dev->print_log; | ^~~ Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Daniel Drubin Cc: linux-in...@vger.kernel.org Suggested-by: Arnd Bergmann Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ish

[PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition

-in...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-sensor-hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index 36b6852f75dd5..95cf88f3bafb9 100644 --- a/drivers/hid/hid-sensor-hub.c

[PATCH 22/25] HID: hid-sensor-hub: Remove unused struct member 'quirks'

described in 'sensor_hub_data' Cc: Jiri Kosina Cc: Jonathan Cameron Cc: Srinivas Pandruvada Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-sensor-hub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/d

[PATCH 20/25] HID: hid-sensor-custom: Remove unused variable 'ret'

Tissoires Cc: linux-in...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-sensor-custom.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c index 2628bc53ed809

[PATCH 21/25] HID: wacom_sys: Demote kernel-doc abuse

: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/wacom_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 8328ef155c468..57bfa0ae98361 100644 --- a/drivers/hid/wacom_sys.c +++ b

[PATCH 19/25] HID: hid-uclogic-params: Ensure function names are present and correct in kernel-doc headers

/hid/hid-uclogic-params.c:706: warning: expecting prototype for uclogic_params_init(). Prototype was for uclogic_params_huion_init() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-uclogic-params.c | 8 +--- 1 file

[PATCH 16/25] HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses

: Lopez Casado Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-logitech-hidpp.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index d459e2dbe6474..d598094dadd0c 100644

[PATCH 15/25] HID: hid-picolcd_core: Remove unused variable 'ret'

es Cc: "L. Vinyard, Jr" Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-picolcd_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c index 1b5c63241af05..bbda231a7ce30

[PATCH 17/25] HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs

Fixes the following W=1 kernel build warning(s): drivers/hid/hid-uclogic-rdesc.c:645: warning: wrong kernel-doc identifier on line: Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-uclogic-rdesc.c | 2 +- 1 file changed, 1

[PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses

: Alexandre Torgue Cc: Dario Pagani Cc: Kim Kuparinen Cc: linux-in...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Lee Jones --- drivers/hid/hid-thrustmaster.c | 24 1 file changed, 12 insertions(+), 12

[PATCH 09/25] HID: hid-alps: Correct struct misnaming

-by: Lee Jones --- drivers/hid/hid-alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 6b665931147df..2b986d0dbde46 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -74,7 +74,7 @@ enum dev_num

[PATCH 12/25] HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header

sztof Wilczyński" Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c index 47b

[PATCH 13/25] HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()

-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index

[PATCH 07/25] HID: intel-ish-hid: Fix a little doc-rot

in 'ishtp_cl_allocate' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Lee Jones Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses

was for pidff_find_effects() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Anssi Hannula Cc: linux-...@vger.kernel.org Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description

Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: message to Cc: linux-...@vger.kernel.org Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid

[PATCH 14/25] HID: hid-kye: Fix incorrect function name for kye_tablet_enable()

Fixes the following W=1 kernel build warning(s): drivers/hid/hid-kye.c:666: warning: expecting prototype for Enable fully(). Prototype was for kye_tablet_enable() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid

[PATCH 11/25] HID: hid-core: Fix incorrect function name in header

-by: Lee Jones --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 097cb1ee31268..0ae9f6df59d10 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2129,7 +2129,7 @@ struct hid_dynid

[PATCH 05/25] HID: intel-ish: Fix a naming disparity and a formatting error

identifier on line: Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid

[PATCH 10/25] HID: intel-ish-hid: Fix potential copy/paste error

Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp

[PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used

Tissoires Cc: Daniel Drubin Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 + drivers/hid/intel-ish-hid/ishtp-hid.h| 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 03/25] HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'

: Benjamin Tissoires Cc: Zhang Lixu Cc: Kai-Heng Feng Cc: Daniel Drubin Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc

[PATCH 04/25] HID: intel-ish: Supply some missing param descriptions

-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "Uwe Kleine-König" Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- d

[PATCH 01/25] HID: intel-ish-hid: Remove unused variable 'err'

: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp/client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp

[RESEND 00/25] Rid W=1 warnings from HID

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (25): HID: intel-ish-hid: Remove unused variable 'err' HID: ishtp-hid-client: Move variable to where it's actually used HID: intel

[RESEND 00/25] Rid W=1 warnings from HID

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. [RESEND] contains no functional changes. Only 18 of 25 patches actually made it to the list during the first attempt. Lee Jones (25): HID

Re: [PATCH 00/25] Rid W=1 warnings from HID

On Fri, 26 Mar 2021, Lee Jones wrote: > On Fri, 26 Mar 2021, Jonathan Cameron wrote: > > > On Wed, 24 Mar 2021 17:33:39 +0000 > > Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds,

Re: [PATCH 00/25] Rid W=1 warnings from HID

On Fri, 26 Mar 2021, Jonathan Cameron wrote: > On Wed, 24 Mar 2021 17:33:39 + > Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings.

[PATCH 16/18] fs: gfs2: super: Fix kernel-doc issues where feasible demote one other

: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/super.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 9e91c9d92bd65..aba117aa433dc 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c

[PATCH 18/18] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header

: Excess function parameter 'mv' description in 'gfs2_update_stats' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lock_dlm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c

[PATCH 15/18] fs: gfs2: recovery: Provide missing param descriptions and remove one other

parameter or member 'pass' not described in 'foreach_descriptor' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/recovery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c

[PATCH 17/18] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses

or member 'file' not described in 'gfs2_io_error_bh_i' fs/gfs2/util.c:546: warning: Function parameter or member 'line' not described in 'gfs2_io_error_bh_i' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/util.c | 19

[PATCH 09/18] fs: gfs2: meta_io: Add missing description for 'rahead' param

Fixes the following W=1 kernel build warning(s): fs/gfs2/meta_io.c:249: warning: Function parameter or member 'rahead' not described in 'gfs2_meta_read' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/meta_io.c | 1 + 1 file

[PATCH 10/18] fs: gfs2: inode: Fix worthy function headers demote others

in 'gfs2_setattr_simple' fs/gfs2/inode.c:1976: warning: Function parameter or member 'mnt_userns' not described in 'gfs2_setattr' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/inode.c | 22 -- 1 file changed, 12

[PATCH 12/18] fs: gfs2: ops_fstype: Fix a little doc-rot

: warning: Excess function parameter 'args' description in 'gfs2_fill_super' fs/gfs2/ops_fstype.c:1102: warning: Excess function parameter 'silent' description in 'gfs2_fill_super' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2

[PATCH 11/18] fs: gfs2: file: Strip out superflouous param description and demote kernel-doc abuse

Signed-off-by: Lee Jones --- fs/gfs2/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 2d500f90cdacf..afab20e5954fd 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -118,7 +118,7 @@ static int gfs2_readdir(struct file *file

[PATCH 14/18] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours

: warning: Function parameter or member 'rgd' not described in 'fast_to_acquire' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/rgrp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c

[PATCH 13/18] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad'

: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 6e173ae378c44..33520eed467c2 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -1534,7 +1534,7 @@ void gfs2_wake_up_statfs

[PATCH 08/18] fs: gfs2: aops: Fix a little potential doc-rot

-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/aops.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index cc4f987687f3c..23b5be3db044c 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -540,10 +540,7 @@ int gfs2_internal_read

[PATCH 06/18] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others

parameter or member 'sdp' not described in 'databuf_lo_before_commit' fs/gfs2/lops.c:983: warning: Function parameter or member 'tr' not described in 'databuf_lo_before_commit' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lops.c

[PATCH 07/18] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

parameter or member 'p' not described in 'nq_m_sync' fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/glock.c | 9 - 1 file

[PATCH 05/18] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers

: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/log.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 6410281546f92..eef33cd251e4b 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@ -65,7 +65,6 @@ unsigned int

[PATCH 02/18] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones

Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/xattr.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/fs/gfs2/xattr.c b/fs/gfs2/xattr.c index 124b3d5a72665..fe2109789f75b 100644 --- a/fs/gfs2/xattr.c

[PATCH 04/18] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others

: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/glops.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index ef0b583c3417c..5711b2c8de9e2 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2

[PATCH 01/18] fs: gfs2: dir: Finish off mostly complete headers demote others

-off-by: Lee Jones --- fs/gfs2/dir.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index c0f2875c946c9..9c1caaef3f0cd 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -767,7 +767,7 @@ static int get_leaf

[PATCH 03/18] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others

Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/bmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 7a358ae051851..7ff20db4999fb 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -1477,7

[PATCH 00/18] Rid W=1 warnings from GFS2

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (18): fs: gfs2: dir: Finish off mostly complete headers demote others fs: gfs2: xattr: Help out some kernel-doc header demote non

Re: [GIT PULL] Immutable branch between MFD and Input due for the v5.13 merge window

On Thu, 25 Mar 2021, Dmitry Torokhov wrote: > Hi Lee, > > On Wed, Mar 10, 2021 at 11:12:50AM +0000, Lee Jones wrote: > > On Tue, 09 Mar 2021, Lee Jones wrote: > > > > > On Tue, 09 Mar 2021, Lee Jones wrote: > > > > > > > Enjoy!

Re: [PATCH v1 1/1] mfd: intel_quark_i2c_gpio: Don't play dirty trick with const

M].end = pci_resource_end(pdev, bar); If you do end up using 'MFD_I2C_BAR' again in here, please omit the line wrap. 80-char lines are so 1990s! > res[INTEL_QUARK_IORES_IRQ].start = pci_irq_vector(pdev, 0); > res[INTEL_QUARK_IORES_IRQ].end = pci_irq_vector(pdev, 0); > @@ -

Re: [PATCH v5 4/7] mfd: hi6421-spmi-pmic: move driver from staging

%) Could you please resend this with out using the -M flag. I can't review a driver I can't see. Thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[GIT PULL] MFD fixes for v5.12

structures Andy Shevchenko (1): mfd: intel_quark_i2c_gpio: Revert "Constify static struct resources" drivers/mfd/intel_quark_i2c_gpio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead

Re: [PATCH v5 1/6] mfd: rt4831: Adds support for Richtek RT4831 core

On Thu, 25 Mar 2021, ChiYuan Huang wrote: > HI, Lee: > > ChiYuan Huang 於 2021年1月13日 週三 下午10:09寫道： > > > > Lee Jones 於 2021年1月13日 週三 下午8:21寫道： > > > > > > On Thu, 17 Dec 2020, cy_huang wrote: > > > > > > > From: ChiYuan Huang > &

Re: [PATCH v4 1/1] mfd: intel_quark_i2c_gpio: enable MSI interrupt

, 16 insertions(+), 6 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses

: Alexandre Torgue Cc: Dario Pagani Cc: Kim Kuparinen Cc: linux-in...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Lee Jones --- drivers/hid/hid-thrustmaster.c | 24 1 file changed, 12 insertions(+), 12

[PATCH 15/25] HID: hid-picolcd_core: Remove unused variable 'ret'

es Cc: "L. Vinyard, Jr" Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-picolcd_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c index 1b5c63241af05..bbda231a7ce30

[PATCH 10/25] HID: intel-ish-hid: Fix potential copy/paste error

Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c index 393bed0abee99

[PATCH 12/25] HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header

sztof Wilczyński" Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c index 47bbeb8b492b0..9037816e2b

[PATCH 17/25] HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs

Fixes the following W=1 kernel build warning(s): drivers/hid/hid-uclogic-rdesc.c:645: warning: wrong kernel-doc identifier on line: Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-uclogic-rdesc.c | 2 +- 1 file changed, 1

[PATCH 04/25] HID: intel-ish: Supply some missing param descriptions

-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "Uwe Kleine-König" Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp

[PATCH 16/25] HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses

: Lopez Casado Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-logitech-hidpp.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index d459e2dbe6474..d598094dadd0c 100644

[PATCH 14/25] HID: hid-kye: Fix incorrect function name for kye_tablet_enable()

Fixes the following W=1 kernel build warning(s): drivers/hid/hid-kye.c:666: warning: expecting prototype for Enable fully(). Prototype was for kye_tablet_enable() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid

[PATCH 13/25] HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()

-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 24599280105d8..042a7091802dd 100644

[PATCH 07/25] HID: intel-ish-hid: Fix a little doc-rot

in 'ishtp_cl_allocate' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Lee Jones Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp

[PATCH 11/25] HID: hid-core: Fix incorrect function name in header

-by: Lee Jones --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 097cb1ee31268..0ae9f6df59d10 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2129,7 +2129,7 @@ struct hid_dynid

[PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses

was for pidff_find_effects() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Anssi Hannula Cc: linux-...@vger.kernel.org Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/25] HID: hid-alps: Correct struct misnaming

-by: Lee Jones --- drivers/hid/hid-alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 6b665931147df..2b986d0dbde46 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -74,7 +74,7 @@ enum dev_num

[PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description

Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: message to Cc: linux-...@vger.kernel.org Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid

[PATCH 05/25] HID: intel-ish: Fix a naming disparity and a formatting error

identifier on line: Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c b

[PATCH 03/25] HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'

: Benjamin Tissoires Cc: Zhang Lixu Cc: Kai-Heng Feng Cc: Daniel Drubin Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel

[PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used

Tissoires Cc: Daniel Drubin Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 + drivers/hid/intel-ish-hid/ishtp-hid.h| 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp

[PATCH 00/25] Rid W=1 warnings from HID

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (25): HID: intel-ish-hid: Remove unused variable 'err' HID: ishtp-hid-client: Move variable to where it's actually used HID: intel

[PATCH 01/25] HID: intel-ish-hid: Remove unused variable 'err'

: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp/client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c index 1cc157126fce7

Re: [PATCH v3 1/1] mfd: intel_quark_i2c_gpio: enable MSI interrupt

ged, 16 insertions(+), 6 deletions(-) Doesn't apply. :( What repo is this based on? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2 00/10] Rid W=1 warnings from OF

On Wed, 24 Mar 2021, Rob Herring wrote: > On Tue, Mar 23, 2021 at 2:36 AM Lee Jones wrote: > > > > On Mon, 22 Mar 2021, Rob Herring wrote: > > > > > On Thu, Mar 18, 2021 at 4:40 AM Lee Jones wrote: > > > > > > > > This set is part of a l

Re: [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: enable MSI interrupt

On Wed, 24 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 01:07:23PM +0000, Lee Jones wrote: > > On Wed, 24 Mar 2021, Andy Shevchenko wrote: > > > > > On Wed, Mar 24, 2021 at 11:50:33AM +, Lee Jones wrote: > > > > On Wed

Re: [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: enable MSI interrupt

On Wed, 24 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 11:50:33AM +0000, Lee Jones wrote: > > On Wed, 24 Mar 2021, Andy Shevchenko wrote: > > > > > On Wed, Mar 24, 2021 at 10:47:29AM +, Lee Jones wrote: > > > > On Wed, 24 Mar 2021, Andy She

Re: [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: enable MSI interrupt

On Wed, 24 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 10:47:29AM +0000, Lee Jones wrote: > > On Wed, 24 Mar 2021, Andy Shevchenko wrote: > > > On Wed, Mar 24, 2021 at 10:29:31AM +, Lee Jones wrote: > > > > On Tue, 23 Mar 2021, Andy Shevchenko wro

Re: [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: enable MSI interrupt

On Wed, 24 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 10:29:31AM +0000, Lee Jones wrote: > > On Tue, 23 Mar 2021, Andy Shevchenko wrote: > > > > > Allow interrupts to be MSI if supported by hardware. > > > > > > Signed-off-by: Andy

Re: [RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location

On Wed, 03 Mar 2021, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for > ‘hvc_vio_init_early’ [-Wmissing-prototypes] > 385 | void __init hvc_vio_init_early(void) > | ^

Re: [RESEND 00/19] Rid GPU from W=1 warnings

equires work and take the rest perhaps? > Lee Jones (19): > drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc > drm/nouveau/dispnv50/disp: Remove unused variable 'ret' > drm/msm/dp/dp_display: Remove unused variable 'hpd' > include: drm: drm_atomic: Make use

Re: [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: enable MSI interrupt

; > > + pci_set_master(pdev); > + > + ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES); Is there any way these magic number can be defined or sizeof()'ed? [...] -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Reuse BAR definitions for MFD cell indexing

indices for MFD cells in the array (Lee) > drivers/mfd/intel_quark_i2c_gpio.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v4] mfd: ntxec: Support for EC in Tolino Shine 2 HD

fd/ntxec.c | 56 --- > include/linux/mfd/ntxec.h | 1 + > 2 files changed, 54 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

On Wed, 24 Mar 2021, Geert Uytterhoeven wrote: > Hi Lee, > > On Tue, Mar 23, 2021 at 9:40 AM Lee Jones wrote: > > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > > Add a compatible for PMI

Re: [PATCH v6 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller

On Wed, 24 Mar 2021, Campion.Kang wrote: > Thanks a lot, please see below descriptions. > > >-Original Message----- > >From: Lee Jones > >Sent: Friday, March 19, 2021 10:15 PM > >To: Campion.Kang > >Cc: chia-lin@canonical.com; devicet...@vger.kernel

Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

On Tue, 23 Mar 2021, Mark Brown wrote: > On Tue, Mar 23, 2021 at 05:20:02PM +0000, Lee Jones wrote: > > On Tue, 23 Mar 2021, Mark Brown wrote: > > > > > On Mon, Mar 22, 2021 at 02:59:25PM +, Lee Jones wrote: > > > > On Thu, 11 Mar 2021, Mark Brown wrote: &

Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

On Tue, 23 Mar 2021, Mark Brown wrote: > On Mon, Mar 22, 2021 at 02:59:25PM +0000, Lee Jones wrote: > > On Thu, 11 Mar 2021, Mark Brown wrote: > > > > If there were more users it'd be better to have this in the core so that > > > problems we can detect like cache st

Re: [PATCH][next] drm/amd/display/dc/calcs/dce_calcs: Fix allocation size for dceip and vbios

ile changed, 2 insertions(+), 2 deletions(-) Fixed already mate. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] backlight: journada720: fix Wmisleading-indentation warning

light: Adds HP Jornada 700 series backlight driver") > Signed-off-by: Arnd Bergmann > --- > drivers/video/backlight/jornada720_bl.c | 44 - > 1 file changed, 22 insertions(+), 22 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Devel

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

On Tue, 23 Mar 2021, Daniel Thompson wrote: > On Tue, Mar 23, 2021 at 08:39:35AM +0000, Lee Jones wrote: > > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > > Add a compatible for PMI

Re: [PATCH V5 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

hanged, 6 insertions(+), 6 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

<    1   2   3   4   5   6   7   8   9   10   >