Re: [External] Re: [PATCH v1] ARM: dts: Fix 64MiB OpenBMC flash layout and aspeed-ast2600-evb.dts

-boot patch to update the `bootm` address and make sure it only applies to the 64MiB layout. Without the above two changes, I would suggest holding the merge. -- BRs, Lei YU

Re: [PATCH] jffs2: Hook up splice_write callback

; > /* jffs2_file_inode_operations */ > -- > 2.30.2 > Verified on g220a openbmc system that the patch fixes the issue. Tested-by: Lei YU

Re: [External] Re: [PATCH 1/3] misc: aspeed: Add Aspeed UART routing control driver.

upstream. So we end up sending this patch here for upstream's comment. If it's considered not a good option, we will have to keep it downstream. [1] https://lore.kernel.org/openbmc/20180711053122.30773-1-and...@aj.id.au/ -- BRs, Lei YU

Re: [PATCH] clocksource/drivers/fttmr010: fix set_next_event handler

ds randomly; With the patch, usleep(100) takes about 600~700 microseconds stably. Tested-by: Lei YU

Re: [PATCH] clocksource/drivers/fttmr010: fix set_next_event handler

ds randomly; With the patch, usleep(100) takes about 600~700 microseconds stably. Tested-by: Lei YU

Re: [PATCH v2] perf: Fix clean error

this commit. On Mon, Sep 3, 2018 at 10:50 AM Lei YU wrote: > > When make perf with -O, it gets error when make clean with below log: > > $ make -C tools/perf O= # OK > $ make -C tools/perf O= clean # Got below error > > find: cannot delete ‘/builtin-script.o’: No such file or &

Re: [PATCH v2] perf: Fix clean error

this commit. On Mon, Sep 3, 2018 at 10:50 AM Lei YU wrote: > > When make perf with -O, it gets error when make clean with below log: > > $ make -C tools/perf O= # OK > $ make -C tools/perf O= clean # Got below error > > find: cannot delete ‘/builtin-script.o’: No such file or &

[PATCH v2] perf: Fix clean error

)` as well, where RM is defined as `rm -f` so it does not return error when file does not exist. Signed-off-by: Lei YU --- v2: Fix missing "make clean" in commit message --- tools/build/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/build/Makefile b/t

[PATCH v2] perf: Fix clean error

)` as well, where RM is defined as `rm -f` so it does not return error when file does not exist. Signed-off-by: Lei YU --- v2: Fix missing "make clean" in commit message --- tools/build/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/build/Makefile b/t

[PATCH] perf: Fix clean error

as `rm -f` so it does not return error when file does not exist. Signed-off-by: Lei YU --- tools/build/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/build/Makefile b/tools/build/Makefile index 5edf65e..ae38db2 100644 --- a/tools/build/Makefile +++ b/tools

[PATCH] perf: Fix clean error

as `rm -f` so it does not return error when file does not exist. Signed-off-by: Lei YU --- tools/build/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/build/Makefile b/tools/build/Makefile index 5edf65e..ae38db2 100644 --- a/tools/build/Makefile +++ b/tools

[PATCH] clk: aspeed: Fix SDCLK name

The SDCLK was named SDCLKCLK, and no one has used this yet. Fix it. Signed-off-by: Lei YU --- drivers/clk/clk-aspeed.c | 2 +- include/dt-bindings/clock/aspeed-clock.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk

[PATCH] clk: aspeed: Fix SDCLK name

The SDCLK was named SDCLKCLK, and no one has used this yet. Fix it. Signed-off-by: Lei YU --- drivers/clk/clk-aspeed.c | 2 +- include/dt-bindings/clock/aspeed-clock.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk

[PATCH] clk: aspeed: Add 24MHz fixed clock

Add a 24MHz fixed clock. This clock will be used for certain devices, e.g. pwm. Signed-off-by: Lei YU <mine260...@gmail.com> --- drivers/clk/clk-aspeed.c | 9 - include/dt-bindings/clock/aspeed-clock.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff

[PATCH] clk: aspeed: Add 24MHz fixed clock

Add a 24MHz fixed clock. This clock will be used for certain devices, e.g. pwm. Signed-off-by: Lei YU --- drivers/clk/clk-aspeed.c | 9 - include/dt-bindings/clock/aspeed-clock.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk

Re: [PATCH] hwmon: (aspeed-pwm-tacho) Use 24MHz clock

On Wed, May 9, 2018 at 11:43 AM, Guenter Roeck wrote: > > I am not going to accept this change, period. This is not one, it is five > steps > backward. If "aspeed_set_clock_source(priv->regmap, 0)" changes the clock > speed, > or the clock source, read it later, and attach to

Re: [PATCH] hwmon: (aspeed-pwm-tacho) Use 24MHz clock

On Wed, May 9, 2018 at 11:43 AM, Guenter Roeck wrote: > > I am not going to accept this change, period. This is not one, it is five > steps > backward. If "aspeed_set_clock_source(priv->regmap, 0)" changes the clock > speed, > or the clock source, read it later, and attach to the correct clock.

Re: [PATCH] hwmon: (aspeed-pwm-tacho) Use 24MHz clock

On Tue, May 8, 2018 at 9:51 PM, Guenter Roeck wrote: > No mixed C/C++ comments in hwmon drivers. > >> aspeed_set_clock_source(priv->regmap, 0); >> + priv->clk_freq = 2400; >> > > > Are you saying that clk_get_rate() is wrong ? Anyway, if the DT is bad, it >

Re: [PATCH] hwmon: (aspeed-pwm-tacho) Use 24MHz clock

On Tue, May 8, 2018 at 9:51 PM, Guenter Roeck wrote: > No mixed C/C++ comments in hwmon drivers. > >> aspeed_set_clock_source(priv->regmap, 0); >> + priv->clk_freq = 2400; >> > > > Are you saying that clk_get_rate() is wrong ? Anyway, if the DT is bad, it > should be fixed.

[PATCH] hwmon: (aspeed-pwm-tacho) Use 24MHz clock

The clock source for aspeed pwm is set to 24MHz, so use the hard-coded clock frequency instead of the one in device tree. Otherwise, in case of the clock specified in device tree is not 24MHz, the fan speed will be incorrect. Signed-off-by: Lei YU <mine260...@gmail.com> --- drivers/hwmon/

[PATCH] hwmon: (aspeed-pwm-tacho) Use 24MHz clock

The clock source for aspeed pwm is set to 24MHz, so use the hard-coded clock frequency instead of the one in device tree. Otherwise, in case of the clock specified in device tree is not 24MHz, the fan speed will be incorrect. Signed-off-by: Lei YU --- drivers/hwmon/aspeed-pwm-tacho.c | 7

Re: [PATCH v2 2/2] clk: aspeed: Prevent reset if clock is enabled

> static int aspeed_clk_enable(struct clk_hw *hw) > { > struct aspeed_clk_gate *gate = to_aspeed_clk_gate(hw); > @@ -215,6 +227,11 @@ static int aspeed_clk_enable(struct clk_hw *hw) > > spin_lock_irqsave(gate->lock, flags); > > + if (aspeed_clk_is_enabled(hw)) { > +

Re: [PATCH v2 2/2] clk: aspeed: Prevent reset if clock is enabled

> static int aspeed_clk_enable(struct clk_hw *hw) > { > struct aspeed_clk_gate *gate = to_aspeed_clk_gate(hw); > @@ -215,6 +227,11 @@ static int aspeed_clk_enable(struct clk_hw *hw) > > spin_lock_irqsave(gate->lock, flags); > > + if (aspeed_clk_is_enabled(hw)) { > +

Re: [PATCH] clk: aspeed: Prevent reset if clock is enabled

On Thu, Mar 8, 2018 at 11:42 AM, Joel Stanley wrote: >> + /* Only reset/enable/unreset if clock is stopped */ >> + regmap_read(gate->map, ASPEED_CLK_STOP_CTRL, ); >> + if (!(reg & clk)) >> + return 0; > > This doesn't generalise to all of the

Re: [PATCH] clk: aspeed: Prevent reset if clock is enabled

On Thu, Mar 8, 2018 at 11:42 AM, Joel Stanley wrote: >> + /* Only reset/enable/unreset if clock is stopped */ >> + regmap_read(gate->map, ASPEED_CLK_STOP_CTRL, ); >> + if (!(reg & clk)) >> + return 0; > > This doesn't generalise to all of the clocks, as some clocks

[PATCH v4 3/3] hwmon: (w83773g) Add documentation

Add documentation for the w83773g driver. Signed-off-by: Lei YU <mine260...@gmail.com> --- v2: - Add notes for offset and update_interval --- Documentation/hwmon/w83773g | 33 + 1 file changed, 33 insertions(+) create mode 100644 Documentation/hwmon/w

[PATCH v4 1/3] DT: i2c: W83773G is a trivial device

Signed-off-by: Lei YU <mine260...@gmail.com> --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index af284fb..63ad2f1

[PATCH v4 3/3] hwmon: (w83773g) Add documentation

Add documentation for the w83773g driver. Signed-off-by: Lei YU --- v2: - Add notes for offset and update_interval --- Documentation/hwmon/w83773g | 33 + 1 file changed, 33 insertions(+) create mode 100644 Documentation/hwmon/w83773g diff --git

[PATCH v4 1/3] DT: i2c: W83773G is a trivial device

Signed-off-by: Lei YU --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index af284fb..63ad2f1 100644 --- a/Documentation

[PATCH v4 0/3] Add W83773G hwmon sensor driver and doc

devm_hwmon_device_register_with_info() v4: - Fix review comments Lei YU (3): DT: i2c: W83773G is a trivial device drivers: hwmon: Add W83773G driver hwmon: (w83773g) Add documentation .../devicetree/bindings/trivial-devices.txt| 1 + Documentation/hwmon/w83773g| 33

[PATCH v4 2/3] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU <mine260...@gmail.com> --- v2: - Rewrite the driver using regmap - Add offset and update_interval v3: - Use devm_hwmon_device_register_with_info() with is_v

[PATCH v4 0/3] Add W83773G hwmon sensor driver and doc

devm_hwmon_device_register_with_info() v4: - Fix review comments Lei YU (3): DT: i2c: W83773G is a trivial device drivers: hwmon: Add W83773G driver hwmon: (w83773g) Add documentation .../devicetree/bindings/trivial-devices.txt| 1 + Documentation/hwmon/w83773g| 33

[PATCH v4 2/3] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU --- v2: - Rewrite the driver using regmap - Add offset and update_interval v3: - Use devm_hwmon_device_register_with_info() with is_visible/read/write

Re: [PATCH v3 2/3] drivers: hwmon: Add W83773G driver

On Fri, Nov 10, 2017 at 10:49 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On 11/08/2017 11:09 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote temperature sensors. >> >> Signed-off-by: Lei

Re: [PATCH v3 2/3] drivers: hwmon: Add W83773G driver

On Fri, Nov 10, 2017 at 10:49 PM, Guenter Roeck wrote: > On 11/08/2017 11:09 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote temperature sensors. >> >> Signed-off-by: Lei YU > > > Nicely

Re: [PATCH v2 2/3] drivers: hwmon: Add W83773G driver

On Thu, Nov 9, 2017 at 1:59 AM, Guenter Roeck <li...@roeck-us.net> wrote: > On Wed, Nov 08, 2017 at 02:03:34PM +0800, Lei YU wrote: >> On Tue, Nov 7, 2017 at 10:33 PM, Guenter Roeck <li...@roeck-us.net> wrote: >> > On 11/07/2017 12:27 AM, Lei YU wrote: >> &g

Re: [PATCH v2 2/3] drivers: hwmon: Add W83773G driver

On Thu, Nov 9, 2017 at 1:59 AM, Guenter Roeck wrote: > On Wed, Nov 08, 2017 at 02:03:34PM +0800, Lei YU wrote: >> On Tue, Nov 7, 2017 at 10:33 PM, Guenter Roeck wrote: >> > On 11/07/2017 12:27 AM, Lei YU wrote: >> >> >> >> Nuvoton W83773G is

[PATCH v3 2/3] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU <mine260...@gmail.com> --- v2: - Rewrite the driver using regmap - Add offset and update_interval v3: - Use devm_hwmon_device_register_with_info() with is_v

[PATCH v3 2/3] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU --- v2: - Rewrite the driver using regmap - Add offset and update_interval v3: - Use devm_hwmon_device_register_with_info() with is_visible/read/write

[PATCH v3 0/3] Add W83773G hwmon sensor driver and doc

devm_hwmon_device_register_with_info() Lei YU (3): DT: i2c: W83773G is a trivial device drivers: hwmon: Add W83773G driver hwmon: (w83773g) Add documentation .../devicetree/bindings/trivial-devices.txt| 1 + Documentation/hwmon/w83773g| 33 ++ drivers/hwmon/Kconfig

[PATCH v3 0/3] Add W83773G hwmon sensor driver and doc

devm_hwmon_device_register_with_info() Lei YU (3): DT: i2c: W83773G is a trivial device drivers: hwmon: Add W83773G driver hwmon: (w83773g) Add documentation .../devicetree/bindings/trivial-devices.txt| 1 + Documentation/hwmon/w83773g| 33 ++ drivers/hwmon/Kconfig

[PATCH v3 3/3] hwmon: (w83773g) Add documentation

Add documentation for the w83773g driver. Signed-off-by: Lei YU <mine260...@gmail.com> --- v2: - Add notes for offset and update_interval --- Documentation/hwmon/w83773g | 33 + 1 file changed, 33 insertions(+) create mode 100644 Documentation/hwmon/w

[PATCH v3 3/3] hwmon: (w83773g) Add documentation

Add documentation for the w83773g driver. Signed-off-by: Lei YU --- v2: - Add notes for offset and update_interval --- Documentation/hwmon/w83773g | 33 + 1 file changed, 33 insertions(+) create mode 100644 Documentation/hwmon/w83773g diff --git

[PATCH v3 1/3] DT: i2c: W83773G is a trivial device

Signed-off-by: Lei YU <mine260...@gmail.com> --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index af284fb..63ad2f1

[PATCH v3 1/3] DT: i2c: W83773G is a trivial device

Signed-off-by: Lei YU --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index af284fb..63ad2f1 100644 --- a/Documentation

Re: [PATCH v2 2/3] drivers: hwmon: Add W83773G driver

On Tue, Nov 7, 2017 at 10:33 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On 11/07/2017 12:27 AM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote temperature sensors. >> >> Signed-off-by: Lei

Re: [PATCH v2 2/3] drivers: hwmon: Add W83773G driver

On Tue, Nov 7, 2017 at 10:33 PM, Guenter Roeck wrote: > On 11/07/2017 12:27 AM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote temperature sensors. >> >> Signed-off-by: Lei YU >> --- >&g

[PATCH v2 1/3] DT: i2c: W83773G is a trivial device

Signed-off-by: Lei YU <mine260...@gmail.com> --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index af284fb..63ad2f1

[PATCH v2 1/3] DT: i2c: W83773G is a trivial device

Signed-off-by: Lei YU --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index af284fb..63ad2f1 100644 --- a/Documentation

[PATCH v2 0/3] Add W83773G hwmon sensor driver and doc

Nuvoton W83773G is a hardware monitoring chip, which integrates two remote and one local temperature sensors. --- v2: - The driver is re-written as v1's comment, so the author is changed to me. - Added the device to trivial-devices.txt Lei YU (3): DT: i2c: W83773G is a trivial device

[PATCH v2 2/3] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU <mine260...@gmail.com> --- v2: - Rewrite the driver using regmap - Add offset and update_interval --- drivers/hwmon/Kconfig | 10 ++ drivers/hwmon/Ma

[PATCH v2 3/3] hwmon: (w83773g) Add documentation

Add documentation for the w83773g driver. Signed-off-by: Lei YU <mine260...@gmail.com> --- v2: - Add notes for offset and update_interval --- Documentation/hwmon/w83773g | 33 + 1 file changed, 33 insertions(+) create mode 100644 Documentation/hwmon/w

[PATCH v2 0/3] Add W83773G hwmon sensor driver and doc

Nuvoton W83773G is a hardware monitoring chip, which integrates two remote and one local temperature sensors. --- v2: - The driver is re-written as v1's comment, so the author is changed to me. - Added the device to trivial-devices.txt Lei YU (3): DT: i2c: W83773G is a trivial device

[PATCH v2 2/3] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU --- v2: - Rewrite the driver using regmap - Add offset and update_interval --- drivers/hwmon/Kconfig | 10 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon

[PATCH v2 3/3] hwmon: (w83773g) Add documentation

Add documentation for the w83773g driver. Signed-off-by: Lei YU --- v2: - Add notes for offset and update_interval --- Documentation/hwmon/w83773g | 33 + 1 file changed, 33 insertions(+) create mode 100644 Documentation/hwmon/w83773g diff --git

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

Hi Guenter, Thanks a lot for the detailed review. I will try to fix all the comments and send v2 patch. On Sun, Nov 5, 2017 at 3:30 AM, Guenter Roeck <li...@roeck-us.net> wrote: > On 11/01/2017 11:33 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor I

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

Hi Guenter, Thanks a lot for the detailed review. I will try to fix all the comments and send v2 patch. On Sun, Nov 5, 2017 at 3:30 AM, Guenter Roeck wrote: > On 11/01/2017 11:33 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> tempe

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

On Thu, Nov 2, 2017 at 10:04 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On 11/01/2017 11:33 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote temperature sensors. >> > This chip is pretty clo

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

On Thu, Nov 2, 2017 at 10:04 PM, Guenter Roeck wrote: > On 11/01/2017 11:33 PM, Lei YU wrote: >> >> Nuvoton W83773G is a hardware monitor IC providing one local >> temperature and two remote temperature sensors. >> > This chip is pretty close to LM90. Ha

[PATCH 2/2] hwmon: (w83773g) Add documentation

Add documentation for the w83773g driver. Signed-off-by: Lei YU <mine260...@gmail.com> --- Documentation/hwmon/w83773g | 28 1 file changed, 28 insertions(+) create mode 100644 Documentation/hwmon/w83773g diff --git a/Documentation/hwmon/w83773g b/Documen

[PATCH 2/2] hwmon: (w83773g) Add documentation

Add documentation for the w83773g driver. Signed-off-by: Lei YU --- Documentation/hwmon/w83773g | 28 1 file changed, 28 insertions(+) create mode 100644 Documentation/hwmon/w83773g diff --git a/Documentation/hwmon/w83773g b/Documentation/hwmon/w83773g new file

[PATCH 0/2] Add W83773G hwmon sensor driver and doc

Nuvoton W83773G is a hardware monitoring chip, which integrates two remote and one local temperature sensors. Lei YU (2): drivers: hwmon: Add W83773G driver hwmon: (w83773g) Add documentation Documentation/hwmon/w83773g | 28 + drivers/hwmon/Kconfig | 11 ++ drivers/hwmon

[PATCH 1/2] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU <mine260...@gmail.com> --- drivers/hwmon/Kconfig | 11 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon/w83773g.c

[PATCH 0/2] Add W83773G hwmon sensor driver and doc

Nuvoton W83773G is a hardware monitoring chip, which integrates two remote and one local temperature sensors. Lei YU (2): drivers: hwmon: Add W83773G driver hwmon: (w83773g) Add documentation Documentation/hwmon/w83773g | 28 + drivers/hwmon/Kconfig | 11 ++ drivers/hwmon

[PATCH 1/2] drivers: hwmon: Add W83773G driver

Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. Signed-off-by: Lei YU --- drivers/hwmon/Kconfig | 11 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon/w83773g.c | 276 3 files